chef 18.9.4 → 18.11.11

data/lib/chef/resource/windows_update_settings.rb

@@ -29,26 +29,26 @@ class Chef
       description "Use the **windows_update_settings** resource to manage the various Windows Update patching options."
       introduced "17.3"
       examples <<~DOC
-      **Set Windows Update settings**:
-
-      ```ruby
-      windows_update_settings 'Settings to Configure Windows Nodes to automatically receive updates' do
-        disable_os_upgrades true
-        elevate_non_admins true
-        block_windows_update_website true
-        automatically_install_minor_updates true
-        scheduled_install_day 'Friday'
-        scheduled_install_hour 18
-        update_other_ms_products true
-        action :enable
-      end
-      ```
+        **Set Windows Update settings**:
+
+        ```ruby
+        windows_update_settings 'Settings to Configure Windows Nodes to automatically receive updates' do
+          disable_os_upgrades true
+          elevate_non_admins true
+          block_windows_update_website true
+          automatically_install_minor_updates true
+          scheduled_install_day 'Friday'
+          scheduled_install_hour 18
+          update_other_ms_products true
+          action :enable
+        end
+        ```
       DOC
 
       # required for the alias to pass validation
       allowed_actions :set, :enable
 
-      DAYS = %W{Everyday Monday Tuesday Wednesday Thursday Friday Saturday Sunday}.freeze
+      DAYS = %w{Everyday Monday Tuesday Wednesday Thursday Friday Saturday Sunday}.freeze
       UPDATE_OPTIONS = {
                         notify: 2,
                         download_and_notify: 3,
@@ -87,8 +87,8 @@ class Chef
       # HKLM\Software\Policies\Microsoft\Windows\WindowsUpdate\AU
 
       property :automatic_update_option, [Integer, Symbol], equal_to: UPDATE_OPTIONS.keys, coerce: proc { |x| UPDATE_OPTIONS.key(x) || x },
-                default: :download_and_schedule,
-                description: "Control what to do when updates are found. This allows you to notify, automatically download and notify to install, automatically download and schedule the install, or let the local admin decide what action to take."
+        default: :download_and_schedule,
+        description: "Control what to do when updates are found. This allows you to notify, automatically download and notify to install, automatically download and schedule the install, or let the local admin decide what action to take."
       # options: 2 - notify before download
       #          3 - auto download and notify
       #          4 - auto download and schedule - must also set day and time (below)
@@ -104,11 +104,11 @@ class Chef
       #          1 - yeah, buddy, i want to set my own interval for checking for updates - true
 
       property :custom_detection_frequency, Integer, default: 22, description: "If you decided to override the OS default detection frequency, specify your choice here. Valid choices are 0 - 22",
-      callbacks: {
-        "should be a valid detection frequency (0-22)" => lambda { |p|
-          p >= 0 && p <= 22
-        },
-      }
+        callbacks: {
+          "should be a valid detection frequency (0-22)" => lambda { |p|
+            p.between?(0, 22)
+          },
+        }
       # a time period of between 0 and 22 hours to check for new updates
       # this is a hex value - convert it from dec to hex
 
@@ -125,11 +125,11 @@ class Chef
       #          Sunday - Saturday day of the week to install, 1 == sunday
 
       property :scheduled_install_hour, Integer, description: "If you chose a scheduled day to install, then choose an hour on that day for you installation",
-                callbacks: {
-                  "should be a valid hour in a 24 hour clock" => lambda { |p|
-                    p > 0 && p < 25
-                  },
-                }
+        callbacks: {
+          "should be a valid hour in a 24 hour clock" => lambda { |p|
+            p > 0 && p < 25
+          },
+        }
       # options: --- 2-digit number representing an hour of the day, uses a 24-hour clock, 12 == noon, 24 == midnight
 
       property :update_other_ms_products, [true, false], default: true, description: "Allows for other Microsoft products to get updates too"

data/lib/chef/resource/windows_user_privilege.rb

@@ -28,67 +28,67 @@ class Chef
       introduced "16.0"
 
       examples <<~DOC
-      **Set the SeNetworkLogonRight privilege for the Builtin Administrators and Authenticated Users groups**:
+        **Set the SeNetworkLogonRight privilege for the Builtin Administrators and Authenticated Users groups**:
 
-      The `:set` action will add this privilege for these two groups and remove this privilege from all other groups or users.
+        The `:set` action will add this privilege for these two groups and remove this privilege from all other groups or users.
 
-      ```ruby
-      windows_user_privilege 'Network Logon Rights' do
-        privilege      'SeNetworkLogonRight'
-        users          ['BUILTIN\\Administrators', 'NT AUTHORITY\\Authenticated Users']
-        action         :set
-      end
-      ```
+        ```ruby
+        windows_user_privilege 'Network Logon Rights' do
+          privilege      'SeNetworkLogonRight'
+          users          ['BUILTIN\\Administrators', 'NT AUTHORITY\\Authenticated Users']
+          action         :set
+        end
+        ```
 
-      **Set the SeCreatePagefilePrivilege privilege for the Builtin Guests and Administrator groups**:
+        **Set the SeCreatePagefilePrivilege privilege for the Builtin Guests and Administrator groups**:
 
-      The `:set` action will add this privilege for these two groups and remove this privilege from all other groups or users.
+        The `:set` action will add this privilege for these two groups and remove this privilege from all other groups or users.
 
-      ```ruby
-      windows_user_privilege 'Create Pagefile' do
-        privilege      'SeCreatePagefilePrivilege'
-        users          ['BUILTIN\\Guests', 'BUILTIN\\Administrators']
-        action         :set
-      end
-      ```
+        ```ruby
+        windows_user_privilege 'Create Pagefile' do
+          privilege      'SeCreatePagefilePrivilege'
+          users          ['BUILTIN\\Guests', 'BUILTIN\\Administrators']
+          action         :set
+        end
+        ```
 
-      **Add the SeDenyRemoteInteractiveLogonRight privilege to the 'Remote interactive logon' principal**:
+        **Add the SeDenyRemoteInteractiveLogonRight privilege to the 'Remote interactive logon' principal**:
 
-      ```ruby
-      windows_user_privilege 'Remote interactive logon' do
-        privilege      'SeDenyRemoteInteractiveLogonRight'
-        action         :add
-      end
-      ```
+        ```ruby
+        windows_user_privilege 'Remote interactive logon' do
+          privilege      'SeDenyRemoteInteractiveLogonRight'
+          action         :add
+        end
+        ```
 
-      **Add the SeCreatePageFilePrivilege privilege to the Builtin Guests group**:
+        **Add the SeCreatePageFilePrivilege privilege to the Builtin Guests group**:
 
-      ```ruby
-      windows_user_privilege 'Guests add Create Pagefile' do
-        principal      'BUILTIN\\Guests'
-        privilege      'SeCreatePagefilePrivilege'
-        action         :add
-      end
-      ```
+        ```ruby
+        windows_user_privilege 'Guests add Create Pagefile' do
+          principal      'BUILTIN\\Guests'
+          privilege      'SeCreatePagefilePrivilege'
+          action         :add
+        end
+        ```
 
-      **Remove the SeCreatePageFilePrivilege privilege from the Builtin Guests group**:
+        **Remove the SeCreatePageFilePrivilege privilege from the Builtin Guests group**:
 
-      ```ruby
-      windows_user_privilege 'Create Pagefile' do
-        privilege      'SeCreatePagefilePrivilege'
-        users          ['BUILTIN\\Guests']
-        action         :remove
-      end
-      ```
+        ```ruby
+        windows_user_privilege 'Create Pagefile' do
+          privilege      'SeCreatePagefilePrivilege'
+          users          ['BUILTIN\\Guests']
+          action         :remove
+        end
+        ```
 
-      **Clear the SeDenyNetworkLogonRight privilege from all users**:
+        **Clear the SeDenyNetworkLogonRight privilege from all users**:
 
-      ```ruby
-      windows_user_privilege 'Allow any user the Network Logon right' do
-        privilege      'SeDenyNetworkLogonRight'
-        action         :clear
-      end
-      ```
+        ```ruby
+        windows_user_privilege 'Allow any user the Network Logon right' do
+          privilege      'SeDenyNetworkLogonRight'
+          action         :clear
+        end
+        ```
       DOC
 
       PRIVILEGE_OPTS = %w{ SeAssignPrimaryTokenPrivilege
@@ -139,20 +139,20 @@ class Chef
                           }.freeze
 
       property :principal, String,
-               description: "An optional property to add the privilege for given principal. Use only with add and remove action. Principal can either be a user, group, or [special identity](https://docs.microsoft.com/en-us/windows/security/identity-protection/access-control/special-identities).",
-               name_property: true
+        description: "An optional property to add the privilege for given principal. Use only with add and remove action. Principal can either be a user, group, or [special identity](https://docs.microsoft.com/en-us/windows/security/identity-protection/access-control/special-identities).",
+        name_property: true
 
       property :users, [Array, String],
-               description: "An optional property to set the privilege for the specified users. Use only with `:set` action",
-               coerce: proc { |v| Array(v) }
+        description: "An optional property to set the privilege for the specified users. Use only with `:set` action",
+        coerce: proc { |v| Array(v) }
 
       property :privilege, [Array, String],
-               description: "One or more privileges to set for principal or users/groups. For more information, see [Microsoft's documentation on what each privilege does](https://learn.microsoft.com/en-us/windows/security/threat-protection/security-policy-settings/user-rights-assignment).",
-               required: true,
-               coerce: proc { |v| Array(v) },
-               callbacks: {
-                 "Privilege property restricted to the following values: #{PRIVILEGE_OPTS}" => lambda { |n| (n - PRIVILEGE_OPTS).empty? },
-               }, identity: true
+        description: "One or more privileges to set for principal or users/groups. For more information, see [Microsoft's documentation on what each privilege does](https://learn.microsoft.com/en-us/windows/security/threat-protection/security-policy-settings/user-rights-assignment).",
+        required: true,
+        coerce: proc { |v| Array(v) },
+        callbacks: {
+          "Privilege property restricted to the following values: #{PRIVILEGE_OPTS}" => lambda { |n| (n - PRIVILEGE_OPTS).empty? },
+        }, identity: true
 
       load_current_value do |new_resource|
         if new_resource.principal && (new_resource.action.include?(:add) || new_resource.action.include?(:remove))
@@ -222,7 +222,7 @@ class Chef
         missing_res_privileges = (new_resource.privilege - curr_res_privilege)
 
         if missing_res_privileges
-          Chef::Log.info("User \'#{new_resource.principal}\' for Privilege: #{missing_res_privileges.join(", ")} not found. Nothing to remove.")
+          Chef::Log.info("User '#{new_resource.principal}' for Privilege: #{missing_res_privileges.join(", ")} not found. Nothing to remove.")
         end
 
         (new_resource.privilege - missing_res_privileges).each do |principal_right|

data/lib/chef/resource/windows_workgroup.rb

@@ -27,20 +27,20 @@ class Chef
       description "Use the **windows_workgroup** resource to join or change the workgroup of a Windows host."
       introduced "14.5"
       examples <<~DOC
-      **Join a workgroup**:
+        **Join a workgroup**:
 
-      ```ruby
-      windows_workgroup 'myworkgroup'
-      ```
+        ```ruby
+        windows_workgroup 'myworkgroup'
+        ```
 
-      **Join a workgroup using a specific user**:
+        **Join a workgroup using a specific user**:
 
-      ```ruby
-      windows_workgroup 'myworkgroup' do
-        user 'Administrator'
-        password 'passw0rd'
-      end
-      ```
+        ```ruby
+        windows_workgroup 'myworkgroup' do
+          user 'Administrator'
+          password 'passw0rd'
+        end
+        ```
       DOC
 
       property :workgroup_name, String,
@@ -107,7 +107,7 @@ class Chef
         # return [String] the appropriate PS command to joint the workgroup
         def join_command
           cmd = ""
-          cmd << "$pswd = ConvertTo-SecureString \'#{new_resource.password}\' -AsPlainText -Force;" if new_resource.password
+          cmd << "$pswd = ConvertTo-SecureString '#{new_resource.password}' -AsPlainText -Force;" if new_resource.password
           cmd << "$credential = New-Object System.Management.Automation.PSCredential (\"#{new_resource.user}\",$pswd);" if new_resource.password
           cmd << "Add-Computer -WorkgroupName #{new_resource.workgroup_name}"
           cmd << " -Credential $credential" if new_resource.password

data/lib/chef/resource/yum_package.rb

@@ -24,7 +24,7 @@ class Chef
     class YumPackage < Chef::Resource::Package
 
       provides :yum_package
-      provides :package, platform_family: "fedora_derived"
+      provides :package, platform_family: %w{fedora rhel amazon}
 
       description "Use the **yum_package** resource to install, upgrade, and remove packages with Yum for the Red Hat and CentOS platforms. The yum_package resource is able to resolve `provides` data for packages much like Yum can do when it is run from the command line. This allows a variety of options for installing packages, like minimum versions, virtual provides, and library names. Note: Support for using file names to install packages (as in `yum_package '/bin/sh'`) is not available because the volume of data required to parse for this is excessive."
       examples <<~DOC

data/lib/chef/resource/yum_repository.rb

@@ -27,24 +27,24 @@ class Chef
       description "Use the **yum_repository** resource to manage a Yum repository configuration file located at `/etc/yum.repos.d/repositoryid.repo` on the local machine. This configuration file specifies which repositories to reference, how to handle cached data, etc."
       introduced "12.14"
       examples <<~DOC
-      **Add an internal company repository**:
-
-      ```ruby
-      yum_repository 'OurCo' do
-        description 'OurCo yum repository'
-        mirrorlist 'http://artifacts.ourco.org/mirrorlist?repo=ourco-8&arch=$basearch'
-        gpgkey 'http://artifacts.ourco.org/pub/yum/RPM-GPG-KEY-OURCO-8'
-        action :create
-      end
-      ```
-
-      **Delete a repository**:
-
-      ```ruby
-      yum_repository 'CentOS-Media' do
-        action :delete
-      end
-      ```
+        **Add an internal company repository**:
+
+        ```ruby
+        yum_repository 'OurCo' do
+          description 'OurCo yum repository'
+          mirrorlist 'http://artifacts.ourco.org/mirrorlist?repo=ourco-8&arch=$basearch'
+          gpgkey 'http://artifacts.ourco.org/pub/yum/RPM-GPG-KEY-OURCO-8'
+          action :create
+        end
+        ```
+
+        **Delete a repository**:
+
+        ```ruby
+        yum_repository 'CentOS-Media' do
+          action :delete
+        end
+        ```
       DOC
 
       # http://linux.die.net/man/5/yum.conf as well as
@@ -67,8 +67,8 @@ class Chef
         default: true
 
       property :cost, String, regex: /^\d+$/,
-               description: "Relative cost of accessing this repository. Useful for weighing one repo's packages as greater/less than any other.",
-               validation_message: "The cost property must be a numeric value!"
+        description: "Relative cost of accessing this repository. Useful for weighing one repo's packages as greater/less than any other.",
+        validation_message: "The cost property must be a numeric value!"
 
       property :description, String,
         description: "Descriptive name for the repository channel and maps to the 'name' parameter in a repository .conf.",
@@ -99,7 +99,7 @@ class Chef
         description: "URL pointing to the ASCII-armored GPG key file for the repository. This is used if Yum needs a public key to verify a package and the required key hasn't been imported into the RPM database. If this option is set, Yum will automatically import the key from the specified URL. Multiple URLs may be specified in the same manner as the baseurl option. If a GPG key is required to install a package from a repository, all keys specified for that repository will be installed.\nMultiple URLs may be specified in the same manner as the baseurl option. If a GPG key is required to install a package from a repository, all keys specified for that repository will be installed."
 
       property :http_caching, String, equal_to: %w{packages all none},
-               description: "Determines how upstream HTTP caches are instructed to handle any HTTP downloads that Yum does. This option can take the following values:\n - `all` means all HTTP downloads should be cached\n - `packages` means only RPM package downloads should be cached, but not repository metadata downloads\n - `none` means no HTTP downloads should be cached.\n\nThe default value of `all` is recommended unless you are experiencing caching related issues."
+        description: "Determines how upstream HTTP caches are instructed to handle any HTTP downloads that Yum does. This option can take the following values:\n - `all` means all HTTP downloads should be cached\n - `packages` means only RPM package downloads should be cached, but not repository metadata downloads\n - `none` means no HTTP downloads should be cached.\n\nThe default value of `all` is recommended unless you are experiencing caching related issues."
 
       property :include_config, String,
         description: "An external configuration file using the format `url://to/some/location`."
@@ -122,19 +122,19 @@ class Chef
         description: "Number of times any attempt to retrieve a file should retry before returning an error. Setting this to `0` makes Yum try forever."
 
       property :metadata_expire, String, regex: [/^\d+$/, /^\d+[mhd]$/, /never/],
-               description: "Time (in seconds) after which the metadata will expire. If the current metadata downloaded is less than the value specified, then Yum will not update the metadata against the repository. If you find that Yum is not downloading information on updates as often as you would like lower the value of this option. You can also change from the default of using seconds to using days, hours or minutes by appending a `d`, `h` or `m` respectively. The default is six hours to compliment yum-updates running once per hour. It is also possible to use the word `never`, meaning that the metadata will never expire. Note: When using a metalink file, the metalink must always be newer than the metadata for the repository due to the validation, so this timeout also applies to the metalink file.",
-               validation_message: "The metadata_expire property must be a numeric value for time in seconds, the string 'never', or a numeric value appended with with `d`, `h`, or `m`!"
+        description: "Time (in seconds) after which the metadata will expire. If the current metadata downloaded is less than the value specified, then Yum will not update the metadata against the repository. If you find that Yum is not downloading information on updates as often as you would like lower the value of this option. You can also change from the default of using seconds to using days, hours or minutes by appending a `d`, `h` or `m` respectively. The default is six hours to compliment yum-updates running once per hour. It is also possible to use the word `never`, meaning that the metadata will never expire. Note: When using a metalink file, the metalink must always be newer than the metadata for the repository due to the validation, so this timeout also applies to the metalink file.",
+        validation_message: "The metadata_expire property must be a numeric value for time in seconds, the string 'never', or a numeric value appended with with `d`, `h`, or `m`!"
 
       property :metalink, String,
         description: "Specifies a URL to a metalink file for the repomd.xml, a list of mirrors for the entire repository are generated by converting the mirrors for the repomd.xml file to a baseurl."
 
       property :mirror_expire, String, regex: [/^\d+$/, /^\d+[mhd]$/],
-               description: "Time (in seconds) after which the mirrorlist locally cached will expire. If the current mirrorlist is less than this many seconds old then Yum will not download another copy of the mirrorlist, it has the same extra format as metadata_expire. If you find that Yum is not downloading the mirrorlists as often as you would like lower the value of this option. You can also change from the default of using seconds to using days, hours or minutes by appending a `d`, `h` or `m` respectively.",
-               validation_message: "The mirror_expire property must be a numeric value for time in seconds, the string 'never', or a numeric value appended with with `d`, `h`, or `m`!"
+        description: "Time (in seconds) after which the mirrorlist locally cached will expire. If the current mirrorlist is less than this many seconds old then Yum will not download another copy of the mirrorlist, it has the same extra format as metadata_expire. If you find that Yum is not downloading the mirrorlists as often as you would like lower the value of this option. You can also change from the default of using seconds to using days, hours or minutes by appending a `d`, `h` or `m` respectively.",
+        validation_message: "The mirror_expire property must be a numeric value for time in seconds, the string 'never', or a numeric value appended with with `d`, `h`, or `m`!"
 
       property :mirrorlist_expire, String, regex: [/^\d+$/, /^\d+[mhd]$/],
-               description: "Specifies the time (in seconds) after which the mirrorlist locally cached will expire. If the current mirrorlist is less than the value specified, then Yum will not download another copy of the mirrorlist. You can also change from the default of using seconds to using days, hours or minutes by appending a `d`, `h` or `m` respectively.",
-               validation_message: "The mirrorlist_expire property must be a numeric value for time in seconds, the string 'never', or a numeric value appended with with `d`, `h`, or `m`!"
+        description: "Specifies the time (in seconds) after which the mirrorlist locally cached will expire. If the current mirrorlist is less than the value specified, then Yum will not download another copy of the mirrorlist. You can also change from the default of using seconds to using days, hours or minutes by appending a `d`, `h` or `m` respectively.",
+        validation_message: "The mirrorlist_expire property must be a numeric value for time in seconds, the string 'never', or a numeric value appended with with `d`, `h`, or `m`!"
 
       property :mirrorlist, String,
         description: "URL to a file containing a list of baseurls. This can be used instead of or with the baseurl option. Substitution variables, described below, can be used with this option."
@@ -146,14 +146,14 @@ class Chef
       property :options, Hash,
         description: "Specifies the repository options."
 
-      property :password, String,
+      property :password, String, sensitive: true,
         description: "Password to use with the username for basic authentication."
 
       property :priority, String, regex: /^(\d?[1-9]|[0-9][0-9])$/,
-               description: "Assigns a priority to a repository where the priority value is between `1` and `99` inclusive. Priorities are used to enforce ordered protection of repositories. Packages from repositories with a lower priority (higher numerical value) will never be used to upgrade packages that were installed from a repository with a higher priority (lower numerical value). The repositories with the lowest numerical priority number have the highest priority.",
-               validation_message: "The priority property must be a numeric value from 1-99!"
+        description: "Assigns a priority to a repository where the priority value is between `1` and `99` inclusive. Priorities are used to enforce ordered protection of repositories. Packages from repositories with a lower priority (higher numerical value) will never be used to upgrade packages that were installed from a repository with a higher priority (lower numerical value). The repositories with the lowest numerical priority number have the highest priority.",
+        validation_message: "The priority property must be a numeric value from 1-99!"
 
-      property :proxy_password, String,
+      property :proxy_password, String, sensitive: true,
         description: "Password for this proxy."
 
       property :proxy_username, String,
@@ -169,9 +169,9 @@ class Chef
         description: "Determines whether to report the instance ID when using Amazon Linux AMIs and repositories."
 
       property :repositoryid, String, regex: [%r{^[^/]+$}],
-               description: "An optional property to set the repository name if it differs from the resource block's name.",
-               validation_message: "repositoryid property cannot contain a forward slash '/'",
-               name_property: true
+        description: "An optional property to set the repository name if it differs from the resource block's name.",
+        validation_message: "repositoryid property cannot contain a forward slash '/'",
+        name_property: true
 
       property :skip_if_unavailable, [TrueClass, FalseClass],
         description: "Allow yum to continue if this repository cannot be contacted for any reason."
@@ -195,8 +195,8 @@ class Chef
         description: "Enable bandwidth throttling for downloads."
 
       property :timeout, String, regex: /^\d+$/,
-               description: "Number of seconds to wait for a connection before timing out. Defaults to 30 seconds. This may be too short of a time for extremely overloaded sites.",
-               validation_message: "The timeout property must be a numeric value!"
+        description: "Number of seconds to wait for a connection before timing out. Defaults to 30 seconds. This may be too short of a time for extremely overloaded sites.",
+        validation_message: "The timeout property must be a numeric value!"
 
       property :username, String,
         description: "Username to use for basic authentication to a repository."

data/lib/chef/resource.rb

@@ -255,7 +255,7 @@ class Chef
         when "before"
           notifies_before(action, resource)
         else
-          raise ArgumentError,  "invalid timing: #{timing} for notifies(#{action}, #{resources.inspect}, #{timing}) resource #{self} "\
+          raise ArgumentError,  "invalid timing: #{timing} for notifies(#{action}, #{resources.inspect}, #{timing}) resource #{self} " \
             "Valid timings are: :delayed, :immediate, :immediately, :before"
         end
       end

data/lib/chef/resource_collection/resource_set.rb

@@ -170,12 +170,11 @@ class Chef
         rescue Chef::Exceptions::ResourceNotFound => e
           if arg =~ MULTIPLE_RESOURCE_MATCH
             begin
-              results = []
               resource_type = $1
               arg =~ /^.+\[(.+)\]$/
               resource_list = $1
-              resource_list.split(",").each do |instance_name|
-                results << lookup(create_key(resource_type, instance_name))
+              results = resource_list.split(",").map do |instance_name|
+                lookup(create_key(resource_type, instance_name))
               end
               Chef.deprecated(:multiresource_match, "The resource_collection multi-resource syntax is deprecated")
               return results

data/lib/chef/resource_inspector.rb

@@ -85,8 +85,7 @@ class Chef
         # Here we do some magic to extract resources from files where there are multiple resources
         # in a file - to do this, we load the file, and take the delta of which resources
         # exist in object space
-        existing_classes = []
-        ObjectSpace.each_object(Class).select { |k| k < Chef::Resource }.each { |klass| existing_classes << klass }
+        existing_classes = ObjectSpace.each_object(Class).select { |k| k < Chef::Resource }.map { |klass| klass }
         # Load the set of resources from this file
         Chef::Resource::LWRPBase.build_from_file(name, pth, Chef::RunContext.new(Chef::Node.new, nil, nil))
         # Finally, process every new class added to the object space by that

data/lib/chef/run_context.rb

@@ -318,7 +318,7 @@ class Chef
     #
     def add_delayed_action(notification)
       if delayed_actions.any? { |existing_notification| existing_notification.duplicates?(notification) }
-        logger.info( "#{notification.notifying_resource} not queuing delayed action #{notification.action} on #{notification.resource}"\
+        logger.info( "#{notification.notifying_resource} not queuing delayed action #{notification.action} on #{notification.resource}" \
                        " (delayed), as it's already been queued")
       else
         delayed_actions << notification
@@ -415,7 +415,7 @@ class Chef
           Recipe `#{recipe_name}` is not in the run_list, and cookbook '#{cookbook_name}'
           is not a dependency of any cookbook in the run_list. To load this recipe,
           first add a dependency of the cookbook '#{cookbook_name}' into the metadata
-		  of the cookbook which depends on '#{cookbook_name}'.
+          of the cookbook which depends on '#{cookbook_name}'.
         ERROR_MESSAGE
       end
 

data/lib/chef/runner.rb

@@ -161,7 +161,7 @@ class Chef
     end
 
     def run_delayed_notification(notification)
-      Chef::Log.info( "#{notification.notifying_resource} sending #{notification.action}"\
+      Chef::Log.info( "#{notification.notifying_resource} sending #{notification.action}" \
                       " action to #{notification.resource} (delayed)")
       # notifications may have lazy strings in them to resolve
       notification.resolve_resource_reference(run_context.resource_collection)

data/lib/chef/secret_fetcher/akeyless_vault.rb

@@ -54,4 +54,3 @@ class Chef
     end
   end
 end
-

data/lib/chef/secret_fetcher/hashi_vault.rb

@@ -131,4 +131,3 @@ class Chef
     end
   end
 end
-

data/lib/chef/shell/ext.rb

@@ -239,9 +239,9 @@ module Shell
 
       desc "returns an object to control a paused #{ChefUtils::Dist::Infra::PRODUCT} run"
       subcommands resume: "resume the #{ChefUtils::Dist::Infra::PRODUCT} run",
-                  step: "run only the next resource",
-                  skip_back: "move back in the run list",
-                  skip_forward: "move forward in the run list"
+        step: "run only the next resource",
+        skip_back: "move back in the run list",
+        skip_forward: "move forward in the run list"
       def chef_run
         Shell.session.resource_collection.iterator
       end
@@ -393,17 +393,17 @@ module Shell
           This will strip the admin privileges from any client named after borat.
       E
       subcommands all: "list all api clients",
-                  show: "load an api client by name",
-                  search: "search for API clients",
-                  transform: "edit all api clients via a code block and save them"
+        show: "load an api client by name",
+        search: "search for API clients",
+        transform: "edit all api clients via a code block and save them"
       def clients
         @clients ||= Shell::ModelWrapper.new(Chef::ApiClient, :client)
       end
 
       desc "Find and edit cookbooks"
       subcommands all: "list all cookbooks",
-                  show: "load a cookbook by name",
-                  transform: "edit all cookbooks via a code block and save them"
+        show: "load a cookbook by name",
+        transform: "edit all cookbooks via a code block and save them"
       def cookbooks
         @cookbooks ||= Shell::ModelWrapper.new(Chef::CookbookVersion)
       end
@@ -455,9 +455,9 @@ module Shell
           This will assign the attribute to every node with a FQDN matching the regex.
       E
       subcommands all: "list all nodes",
-                  show: "load a node by name",
-                  search: "search for nodes",
-                  transform: "edit all nodes via a code block and save them"
+        show: "load a node by name",
+        search: "search for nodes",
+        transform: "edit all nodes via a code block and save them"
       def nodes
         @nodes ||= Shell::ModelWrapper.new(Chef::Node)
       end
@@ -477,9 +477,9 @@ module Shell
           See the help for +nodes+ for more information about the subcommands.
       E
       subcommands all: "list all roles",
-                  show: "load a role by name",
-                  search: "search for roles",
-                  transform: "edit all roles via a code block and save them"
+        show: "load a role by name",
+        search: "search for roles",
+        transform: "edit all roles via a code block and save them"
       def roles
         @roles ||= Shell::ModelWrapper.new(Chef::Role)
       end
@@ -503,9 +503,9 @@ module Shell
 
       E
       subcommands all: "list all items in the data bag",
-                  show: "load a data bag item by id",
-                  search: "search for items in the data bag",
-                  transform: "edit all items via a code block and save them"
+        show: "load a data bag item by id",
+        search: "search for items in the data bag",
+        transform: "edit all items via a code block and save them"
       def databags(databag_name)
         @named_databags_wrappers ||= {}
         @named_databags_wrappers[databag_name] ||= Shell::NamedDataBagWrapper.new(databag_name)
@@ -526,9 +526,9 @@ module Shell
           See the help for +nodes+ for more information about the subcommands.
       E
       subcommands all: "list all environments",
-                  show: "load an environment by name",
-                  search: "search for environments",
-                  transform: "edit all environments via a code block and save them"
+        show: "load an environment by name",
+        search: "search for environments",
+        transform: "edit all environments via a code block and save them"
       def environments
         @environments ||= Shell::ModelWrapper.new(Chef::Environment)
       end

data/lib/chef/shell/shell_session.rb

@@ -268,7 +268,7 @@ module Shell
 
     def register
       @rest = Chef::ServerAPI.new(Chef::Config[:chef_server_url], client_name: Chef::Config[:node_name],
-                                                                  signing_key_filename: Chef::Config[:client_key])
+        signing_key_filename: Chef::Config[:client_key])
     end
 
   end

data/lib/chef/shell.rb

@@ -72,6 +72,13 @@ module Shell
     # to get access to the main object before irb starts.
     ::IRB.setup(nil)
 
+    # Apply Windows AltGr input fix for affected Reline versions (< 0.3.2).
+    # European keyboard layouts (e.g. German) use AltGr (Ctrl+Alt) to produce
+    # characters such as { } [ ]. Without this patch Reline emits a spurious ESC
+    # prefix making chef-shell unusable for those users. Safe no-op on non-Windows
+    # and on Reline versions where the upstream fix is already present.
+    require_relative "monkey_patches/reline-windows"
+
     irb_conf[:USE_COLORIZE] = options.config[:use_colorize]
     irb_conf[:USE_SINGLELINE] = options.config[:use_singleline]
     irb_conf[:USE_MULTILINE] = options.config[:use_multiline]