chef 18.2.7 → 18.4.2

data/lib/chef/resource/_rest_resource.rb

@@ -351,7 +351,7 @@ action_class do
     Chef.run_context.transport.connection
   end
 
-  # Remove all empty keys (recusively) from Hash.
+  # Remove all empty keys (recursively) from Hash.
   # @see https://stackoverflow.com/questions/56457020/#answer-56458673
   def deep_compact!(hsh)
     raise TypeError unless hsh.is_a? Hash

data/lib/chef/resource/apt_package.rb

@@ -52,6 +52,21 @@ class Chef
         options '--no-install-recommends'
       end
       ```
+
+      **Prevent the apt_package resource from installing packages with pattern matching names**:
+
+      By default, the apt_package resource will install the named package.
+      If it can't find a package with the exact same name, it will treat the package name as regular expression string and match with any package that matches that regular expression.
+      This may lead Chef Infra Client to install one or more packages with names that match that regular expression.
+
+      In this example, `anchor_package_regex true` prevents the apt_package resource from installing matching packages if it can't find the `lua5.3` package.
+
+      ```ruby
+      apt_package 'lua5.3' do
+        version '5.3.3-1.1ubuntu2'
+        anchor_package_regex true
+      end
+      ```
       DOC
 
       description "Use the **apt_package** resource to manage packages on Debian, Ubuntu, and other platforms that use the APT package system."
@@ -75,6 +90,10 @@ class Chef
         description: "A Hash of response file variables in the form of {'VARIABLE' => 'VALUE'}.",
         default: {}, desired_state: false
 
+      property :anchor_package_regex, [TrueClass, FalseClass],
+        introduced: "18.3",
+        description: "A Boolean flag that indicates whether the package name, which can be a regular expression, must match the entire name of the package (true) or if the regular expression is allowed to match a subset of the name (false).",
+        default: false
     end
   end
 end

data/lib/chef/resource/apt_repository.rb

@@ -98,6 +98,19 @@ class Chef
         end
         ```
 
+        **Add repository that needs custom options**:
+
+        ```ruby
+        apt_repository 'corretto' do
+          uri          'https://apt.corretto.aws'
+          arch         'amd64'
+          distribution 'stable'
+          components   ['main']
+          options      ['target-=Contents-deb']
+          key          'https://apt.corretto.aws/corretto.key'
+        end
+        ```
+
         **Remove a repository from the list**:
 
         ```ruby
@@ -159,6 +172,10 @@ class Chef
         description: "Determines whether to rebuild the APT package cache.",
         default: true, desired_state: false
 
+      property :options, [String, Array],
+        description: "Additional options to set for the repository.",
+        default: [], coerce: proc { |x| Array(x) }
+
       default_action :add
       allowed_actions :add, :remove
 
@@ -388,19 +405,21 @@ class Chef
         # @param [Array] components
         # @param [Boolean] trusted
         # @param [String] arch
+        # @param [Array] options
         # @param [Boolean] add_src
         #
         # @return [String] complete repo config text
-        def build_repo(uri, distribution, components, trusted, arch, add_src = false)
+        def build_repo(uri, distribution, components, trusted, arch, options, add_src = false)
           uri = make_ppa_url(uri) if is_ppa_url?(uri)
 
           uri = Addressable::URI.parse(uri)
           components = Array(components).join(" ")
-          options = []
-          options << "arch=#{arch}" if arch
-          options << "trusted=yes" if trusted
-          optstr = unless options.empty?
-                     "[" + options.join(" ") + "]"
+          options_list = []
+          options_list << "arch=#{arch}" if arch
+          options_list << "trusted=yes" if trusted
+          options_list += options
+          optstr = unless options_list.empty?
+                     "[" + options_list.join(" ") + "]"
                    end
           info = [ optstr, uri.normalize.to_s, distribution, components ].compact.join(" ")
           repo =  "deb      #{info}\n"
@@ -461,6 +480,7 @@ class Chef
           repo_components,
           new_resource.trusted,
           new_resource.arch,
+          new_resource.options,
           new_resource.deb_src
         )
 

data/lib/chef/resource/chef_client_systemd_timer.rb

@@ -176,7 +176,7 @@ class Chef
           }
 
           unit["Service"]["ConditionACPower"] = "true" unless new_resource.run_on_battery
-          unit["Service"]["CPUQuota"] = new_resource.cpu_quota if new_resource.cpu_quota
+          unit["Service"]["CPUQuota"] = "#{new_resource.cpu_quota}%" if new_resource.cpu_quota
           unit["Service"]["Environment"] = new_resource.environment.collect { |k, v| "\"#{k}=#{v}\"" } unless new_resource.environment.empty?
           unit
         end

data/lib/chef/resource/chocolatey_installer.rb

@@ -0,0 +1,207 @@
+class Chef
+  class Resource
+    class ChocolateyInstaller < Chef::Resource
+      provides :chocolatey_installer
+
+      description "Use the chocolatey_installer resource to ensure that Chocolatey itself is installed to your specification. Use the Chocolatey Feature resource to customize your install. Then use the Chocolatey Package resource to install packages on Windows via Chocolatey."
+      introduced "18.3"
+      examples <<~DOC
+          **Install Chocolatey**
+
+          ```ruby
+          chocolatey_installer 'latest' do
+            action :install
+          end
+          ```
+
+          **Uninstall Chocolatey**
+
+          ```ruby
+          chocolatey_installer 'Some random verbiage' do
+            action :uninstall
+          end
+          ```
+
+          **Install Chocolatey with Parameters**
+
+          ```ruby
+          chocolatey_installer 'latest' do
+            action :install
+            download_url "https://www.contoso.com/foo"
+            chocolatey_version '2.12.24'
+          end
+          ```
+
+          ```ruby
+          chocolatey_installer 'latest' do
+            action :install
+            download_url "c:\\foo\foo.nupkg"
+            chocolatey_version '2.12.24'
+          end
+          ```
+
+          **Upgrade Chocolatey with Parameters**
+
+          ```ruby
+          chocolatey_installer 'latest' do
+            action :upgrade
+            chocolatey_version '2.12.24'
+          end
+          ```
+      DOC
+
+      allowed_actions :install, :uninstall, :upgrade
+
+      property :download_url, String,
+        description: "The URL to download Chocolatey from. This sets the value of $env:ChocolateyDownloadUrl and causes the installer to choose an alternate download location. If this is not set, Chocolatey installs fall back to the official Chocolatey community repository to download Chocolatey from. It can also be used for offline installation by providing a path to a Chocolatey.nupkg."
+
+      property :chocolatey_version, String,
+        description: "Specifies a target version of Chocolatey to install. By default, the latest stable version is installed. This will use the value in $env:ChocolateyVersion by default, if that environment variable is present. This parameter is ignored if download_url is set."
+
+      property :use_native_unzip, [TrueClass, FalseClass], default: false,
+        description: "If set, uses built-in Windows decompression tools instead of 7zip when unpacking the downloaded nupkg. This will be set by default if use_native_unzip is set to a value other than 'false' or '0'. This parameter will be ignored in PS 5+ in favour of using the Expand-Archive built in PowerShell cmdlet directly."
+
+      property :ignore_proxy, [TrueClass, FalseClass], default: false,
+        description: "If set, ignores any configured proxy. This will override any proxy environment variables or parameters. This will be set by default if ignore_proxy is set to a value other than 'false' or '0'."
+
+      property :proxy_url, String,
+        description: "Specifies the proxy URL to use during the download."
+
+      property :proxy_user, String,
+        description: "The username to use to build a proxy credential with. Will be consumed by the proxy_credential property if both this property and proxy_password are set"
+
+      property :proxy_password, String,
+        description: "The password to use to build a proxy credential with. Will be consumed by the proxy_credential property if both this property and proxy_user are set"
+
+      load_current_value do
+        current_state = is_choco_installed?
+        current_value_does_not_exist! if current_state == false
+        current_state
+      end
+
+      def is_choco_installed?
+        ::File.exist?("#{ENV["ALLUSERSPROFILE"]}\\chocolatey\\bin\\choco.exe")
+      end
+
+      def get_choco_version
+        powershell_exec("choco --version").result
+      end
+
+      def existing_version
+        Gem::Version.new(get_choco_version)
+      end
+
+      def define_resource_requirements
+        requirements.assert(:install, :upgrade).each do |a|
+          a.assertion do
+            # This is an exclusive OR - XOR - we're trying to coax an error out if one, but not both,
+            # parameters are empty.
+            new_resource.proxy_user.nil? != new_resource.proxy_password.nil?
+          end
+          a.failure_message(Chef::Exceptions::ValidationFailed, "You must specify both a proxy_user and a proxy_password")
+          a.whyrun("Assuming that if you have configured a 'proxy_user' you must also supply a 'proxy_password'")
+        end
+      end
+
+      action :install, description: "Installs Chocolatey package manager" do
+        if new_resource.download_url
+          powershell_exec("Set-Item -path env:ChocolateyDownloadUrl -Value #{new_resource.download_url}")
+        end
+
+        if new_resource.chocolatey_version
+          powershell_exec("Set-Item -path env:ChocolateyVersion -Value #{new_resource.chocolatey_version}")
+        end
+
+        if new_resource.use_native_unzip
+          powershell_exec("Set-Item -path env:ChocolateyUseWindowsCompression -Value true")
+        end
+
+        if new_resource.ignore_proxy
+          powershell_exec("Set-Item -path env:ChocolateyIgnoreProxy -Value true")
+        end
+
+        if new_resource.proxy_url
+          powershell_exec("Set-Item -path env:ChocolateyProxyLocation -Value #{new_resource.proxy_url}")
+        end
+
+        if new_resource.proxy_user && new_resource.proxy_password
+          powershell_exec("Set-Item -path env:ChocolateyProxyUser -Value #{new_resource.proxy_user}; Set-Item -path env:ChocolateyProxyPassword -Value #{new_resource.proxy_password}")
+        end
+
+        # note that Invoke-Expression is being called on the downloaded script (outer parens),
+        # not triggering the script download (inner parens)
+        converge_if_changed do
+          powershell_exec("Invoke-Expression ((New-Object System.Net.WebClient).DownloadString('https://chocolatey.org/install.ps1'))").error!
+        end
+      end
+
+      action :upgrade, description: "Upgrades the Chocolatey package manager" do
+        if new_resource.chocolatey_version
+          proposed_version = Gem::Version.new(new_resource.chocolatey_version)
+        else
+          proposed_version = nil
+        end
+
+        if new_resource.download_url
+          powershell_exec("Set-Item -path env:ChocolateyDownloadUrl -Value #{new_resource.download_url}")
+        end
+
+        if new_resource.chocolatey_version
+          powershell_exec("Set-Item -path env:ChocolateyVersion -Value #{new_resource.chocolatey_version}")
+        end
+
+        if new_resource.use_native_unzip
+          powershell_exec("Set-Item -path env:ChocolateyUseWindowsCompression -Value true")
+        end
+
+        if new_resource.ignore_proxy
+          powershell_exec("Set-Item -path env:ChocolateyIgnoreProxy -Value true")
+        end
+
+        if new_resource.proxy_url
+          powershell_exec("Set-Item -path env:ChocolateyProxyLocation -Value #{new_resource.proxy_url}")
+        end
+
+        if new_resource.proxy_user && new_resource.proxy_password
+          powershell_exec("Set-Item -path env:ChocolateyProxyUser -Value #{new_resource.proxy_user}; Set-Item -path env:ChocolateyProxyPassword -Value #{new_resource.proxy_password}")
+        end
+
+        if proposed_version && existing_version < proposed_version
+          powershell_exec("Set-Item -path env:ChocolateyVersion -Value #{proposed_version}")
+        else
+          powershell_exec("Remove-Item -path env:ChocolateyVersion")
+        end
+
+        converge_by("upgrade choco version") do
+          powershell_exec("choco upgrade Chocolatey -y").result
+        end
+      end
+
+      action :uninstall, description: "Uninstall Chocolatey package manager" do
+        path = "c:\\programdata\\chocolatey\\bin"
+        if File.exists?(path)
+          converge_by("Uninstall Choco") do
+            powershell_code = <<~CODE
+              Remove-Item $env:ALLUSERSPROFILE\\chocolatey -Recurse -Force
+              [Environment]::SetEnvironmentVariable("ChocolateyLastPathUpdate", $null ,"User")
+              [Environment]::SetEnvironmentVariable("ChocolateyToolsLocation", $null ,"User")
+              [Environment]::SetEnvironmentVariable("ChocolateyInstall", $null ,"Machine")
+              $path = [System.Environment]::GetEnvironmentVariable(
+                  'PATH',
+                  'Machine'
+              )
+              $path = ($path.Split(';') | Where-Object { $_ -ne "#{path}" }) -join ";"
+              [System.Environment]::SetEnvironmentVariable(
+                  'PATH',
+                  $path,
+                  'Machine'
+              )
+            CODE
+            powershell_exec(powershell_code).error!
+          end
+        end
+        Chef::Log.warn("Chocolatey is already uninstalled.")
+      end
+    end
+  end
+end

data/lib/chef/resource/chocolatey_package.rb

@@ -67,6 +67,14 @@ class Chef
         description: "The name of the package. Default value: the name of the resource block.",
         coerce: proc { |x| [x].flatten }
 
+      property :bulk_query, [TrueClass, FalseClass],
+        description: "Bulk query the chocolatey server?  This will cause the provider to list all packages instead of doing individual queries.",
+        default: false
+
+      property :use_choco_list, [TrueClass, FalseClass],
+        description: "Use choco list for getting the locally installed packages, rather than reading the nupkg database directly?  This defaults to false, since reading the package data is faster.",
+        default: false
+
       property :version, [String, Array],
         description: "The version of a package to be installed or upgraded.",
         coerce: proc { |x| [x].flatten }

data/lib/chef/resource/homebrew_cask.rb

@@ -45,8 +45,7 @@ class Chef
         default: true
 
       property :homebrew_path, String,
-        description: "The path to the homebrew binary.",
-        default: "/usr/local/bin/brew"
+        description: "The path to the Homebrew binary."
 
       property :owner, [String, Integer],
         description: "The owner of the Homebrew installation.",
@@ -56,14 +55,14 @@ class Chef
       action :install, description: "Install an application that is packaged as a Homebrew cask." do
         if new_resource.install_cask
           homebrew_tap "homebrew/cask" do
-            homebrew_path new_resource.homebrew_path
+            homebrew_path homebrew_bin_path(new_resource.homebrew_path)
             owner new_resource.owner
           end
         end
 
         unless casked?
           converge_by("install cask #{new_resource.cask_name} #{new_resource.options}") do
-            shell_out!("#{new_resource.homebrew_path} install --cask #{new_resource.cask_name} #{new_resource.options}",
+            shell_out!("#{homebrew_bin_path(new_resource.homebrew_path)} install --cask #{new_resource.cask_name} #{new_resource.options}",
               user: new_resource.owner,
               env:  { "HOME" => ::Dir.home(new_resource.owner), "USER" => new_resource.owner },
               cwd: ::Dir.home(new_resource.owner))
@@ -74,14 +73,14 @@ class Chef
       action :remove, description: "Remove an application that is packaged as a Homebrew cask." do
         if new_resource.install_cask
           homebrew_tap "homebrew/cask" do
-            homebrew_path new_resource.homebrew_path
+            homebrew_path homebrew_bin_path(new_resource.homebrew_path)
             owner new_resource.owner
           end
         end
 
         if casked?
           converge_by("uninstall cask #{new_resource.cask_name}") do
-            shell_out!("#{new_resource.homebrew_path} uninstall --cask #{new_resource.cask_name}",
+            shell_out!("#{homebrew_bin_path(new_resource.homebrew_path)} uninstall --cask #{new_resource.cask_name}",
               user: new_resource.owner,
               env:  { "HOME" => ::Dir.home(new_resource.owner), "USER" => new_resource.owner },
               cwd: ::Dir.home(new_resource.owner))
@@ -99,7 +98,7 @@ class Chef
         # @return [Boolean]
         def casked?
           unscoped_name = new_resource.cask_name.split("/").last
-          shell_out!("#{new_resource.homebrew_path} list --cask 2>/dev/null",
+          shell_out!("#{homebrew_bin_path(new_resource.homebrew_path)} list --cask 2>/dev/null",
             user: new_resource.owner,
             env:  { "HOME" => ::Dir.home(new_resource.owner), "USER" => new_resource.owner },
             cwd: ::Dir.home(new_resource.owner)).stdout.split.include?(unscoped_name)

data/lib/chef/resource/homebrew_package.rb

@@ -63,7 +63,7 @@ class Chef
       allowed_actions :install, :upgrade, :remove, :purge
 
       property :homebrew_user, [ String, Integer ],
-        description: "The name or uid of the Homebrew owner to be used by #{ChefUtils::Dist::Infra::PRODUCT} when executing a command.\n\n#{ChefUtils::Dist::Infra::PRODUCT}, by default, will attempt to execute a Homebrew command as the owner of the `/usr/local/bin/brew` executable. If that executable does not exist, #{ChefUtils::Dist::Infra::PRODUCT} will attempt to find the user by executing `which brew`. If that executable cannot be found, #{ChefUtils::Dist::Infra::PRODUCT} will print an error message: `Could not find the 'brew' executable in /usr/local/bin or anywhere on the path.`.\n\nSet this property to specify the Homebrew owner for situations where Chef Infra Client cannot automatically detect the correct owner.'"
+        description: "The name or UID of the Homebrew owner to be used by #{ChefUtils::Dist::Infra::PRODUCT} when executing a command.\n\n#{ChefUtils::Dist::Infra::PRODUCT}, by default, will attempt to execute a Homebrew command as the owner of the `/usr/local/bin/brew` executable on x86_64 machines or `/opt/homebrew/bin/brew` executable on arm64 machines. If that executable doesn't exist, #{ChefUtils::Dist::Infra::PRODUCT} will attempt to find the user by executing `which brew`. If that executable can't be found, #{ChefUtils::Dist::Infra::PRODUCT} will print an error message: `Couldn't find the 'brew' executable anywhere on the path.`.\n\nSet this property to specify the Homebrew owner for situations where Chef Infra Client cannot automatically detect the correct owner.'"
 
     end
   end

data/lib/chef/resource/homebrew_tap.rb

@@ -41,8 +41,7 @@ class Chef
         description: "The URL of the tap."
 
       property :homebrew_path, String,
-        description: "The path to the Homebrew binary.",
-        default: "/usr/local/bin/brew"
+        description: "The path to the Homebrew binary."
 
       property :owner, String,
         description: "The owner of the Homebrew installation.",
@@ -52,7 +51,7 @@ class Chef
       action :tap, description: "Add a Homebrew tap." do
         unless tapped?(new_resource.tap_name)
           converge_by("tap #{new_resource.tap_name}") do
-            shell_out!("#{new_resource.homebrew_path} tap #{new_resource.tap_name} #{new_resource.url || ""}",
+            shell_out!("#{homebrew_bin_path(new_resource.homebrew_path)} tap #{new_resource.tap_name} #{new_resource.url || ""}",
               user: new_resource.owner,
               env:  { "HOME" => ::Dir.home(new_resource.owner), "USER" => new_resource.owner },
               cwd: ::Dir.home(new_resource.owner))
@@ -63,7 +62,7 @@ class Chef
       action :untap, description: "Remove a Homebrew tap." do
         if tapped?(new_resource.tap_name)
           converge_by("untap #{new_resource.tap_name}") do
-            shell_out!("#{new_resource.homebrew_path} untap #{new_resource.tap_name}",
+            shell_out!("#{homebrew_bin_path(new_resource.homebrew_path)} untap #{new_resource.tap_name}",
               user: new_resource.owner,
               env:  { "HOME" => ::Dir.home(new_resource.owner), "USER" => new_resource.owner },
               cwd: ::Dir.home(new_resource.owner))
@@ -75,8 +74,9 @@ class Chef
       #
       # @return [Boolean]
       def tapped?(name)
+        base_path = ["#{::File.dirname(which("brew"))}/../homebrew", "#{::File.dirname(which("brew"))}/../Homebrew", "/opt/homebrew", "/usr/local/Homebrew", "/home/linuxbrew/.linuxbrew"].uniq.select { |x| Dir.exist?(x) }.first
         tap_dir = name.gsub("/", "/homebrew-")
-        ::File.directory?("/usr/local/Homebrew/Library/Taps/#{tap_dir}")
+        ::File.directory?("#{base_path}/Library/Taps/#{tap_dir}")
       end
     end
   end

data/lib/chef/resource/launchd.rb

@@ -202,7 +202,11 @@ class Chef
         description: "The first argument of `execvp`, typically the file name associated with the file to be executed. This value must be specified if `program_arguments` is not specified, and vice-versa."
 
       property :program_arguments, Array,
-        description: "The second argument of `execvp`. If program is not specified, this property must be specified and will be handled as if it were the first argument."
+        description: "The second argument of `execvp`. If program is not specified, this property must be specified and will be handled as if it were the first argument.",
+        coerce: proc { |args|
+          # Cast all values to a string.  Launchd only supports string values
+          args.map(&:to_s)
+        }
 
       property :queue_directories, Array,
         description: "An array of non-empty directories which, if any are modified, will cause a job to be started."

data/lib/chef/resource/locale.rb

@@ -112,8 +112,11 @@ class Chef
           end
 
           requirements.assert(:all_actions) do |a|
-            # RHEL/CentOS type platforms don't have locale-gen
-            a.assertion { which("locale-gen") }
+            a.assertion do
+              # RHEL/CentOS type platforms don't have locale-gen
+              # Windows has locale-gen as part of the install, but not in the path
+              which("locale-gen") || windows?
+            end
             a.failure_message(Chef::Exceptions::ProviderNotFound, "The locale resource requires the locale-gen tool")
           end
         end

data/lib/chef/resource/macos_pkg.rb

@@ -0,0 +1,111 @@
+#
+# Author:: Joshua Timberman (<jtimberman@chef.io>)
+# Author:: William Theaker (<william.theaker+chef@gusto.com>)
+# Copyright:: Copyright (c) Chef Software Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require_relative "../resource"
+
+class Chef
+  class Resource
+    class MacosPkg < Chef::Resource
+      provides(:macos_pkg) { true }
+
+      description "Use the **macos_pkg** resource to install a macOS `.pkg` file, optionally downloading it from a remote source. A `package_id` property must be provided for idempotency. Either a `file` or `source` property is required."
+      introduced "18.1"
+      examples <<~DOC
+        **Install osquery**:
+
+        ```ruby
+        macos_pkg 'osquery' do
+          checksum   '1fea8ac9b603851d2e76c5fc73138a468a3075a3002c8cb1fd7fff53b889c4dd'
+          package_id 'io.osquery.agent'
+          source     'https://pkg.osquery.io/darwin/osquery-5.8.2.pkg'
+          action     :install
+        end
+        ```
+      DOC
+
+      allowed_actions :install
+      default_action  :install
+
+      property :checksum, String,
+        description: "The sha256 checksum of the `.pkg` file to download."
+
+      property :file, String,
+        description: "The absolute path to the `.pkg` file on the local system."
+
+      property :headers, Hash,
+        description: "Allows custom HTTP headers (like cookies) to be set on the `remote_file` resource.",
+        desired_state: false
+
+      property :package_id, String,
+        description: "The package ID registered with `pkgutil` when a `pkg` or `mpkg` is installed.",
+        required: true
+
+      property :source, String,
+        description: "The remote URL used to download the `.pkg` file."
+
+      property :target, String,
+        description: "The device to install the package on.",
+        default: "/"
+
+      load_current_value do |new_resource|
+        if shell_out("pkgutil --pkg-info '#{new_resource.package_id}'").exitstatus == 0
+          Chef::Log.debug "#{new_resource.package_id} is already installed. To upgrade, try \"sudo pkgutil --forget '#{new_resource.package_id}'\""
+        else
+          current_value_does_not_exist!
+        end
+      end
+
+      action :install, description: "Installs the pkg." do
+        if new_resource.source.nil? && new_resource.file.nil?
+          raise "Must provide either a file or source property for macos_pkg resources."
+        end
+
+        if current_resource.nil?
+          if new_resource.source
+            remote_file pkg_file do
+              source new_resource.source
+              headers new_resource.headers if new_resource.headers
+              checksum new_resource.checksum if new_resource.checksum
+            end
+          end
+
+          converge_by "install #{pkg_file}" do
+            install_cmd = "installer -pkg #{pkg_file} -target #{new_resource.target}"
+
+            execute install_cmd do
+              action :run
+            end
+          end
+        end
+      end
+
+      action_class do
+        # @return [String] the path to the pkg file
+        def pkg_file
+          @pkg_file ||= if new_resource.file.nil?
+                          uri = URI.parse(new_resource.source)
+                          filename = ::File.basename(uri.path)
+                          "#{Chef::Config[:file_cache_path]}/#{filename}"
+                        else
+                          new_resource.file
+                        end
+        end
+      end
+    end
+  end
+end

data/lib/chef/resource/powershell_script.rb

@@ -21,7 +21,7 @@ class Chef
   class Resource
     class PowershellScript < Chef::Resource::WindowsScript
 
-      set_guard_inherited_attributes(:interpreter)
+      set_guard_inherited_attributes(:interpreter, :use_inline_powershell)
 
       provides :powershell_script, os: "windows"
 
@@ -39,6 +39,10 @@ class Chef
         equal_to: %w{powershell pwsh},
         description: "The interpreter type, `powershell` or `pwsh` (PowerShell Core)"
 
+      property :use_inline_powershell, [true, false],
+        default: false,
+        description: "Use inline powershell.dll rather than shelling out - this is faster, but could have different semantics to the traditional method.  In particular, it does not allow for streaming output, nor does it allow for passing custom parameters to the interpreter"
+
       property :convert_boolean_return, [true, false],
         default: false,
         description: <<~DESC

data/lib/chef/resource/service.rb

@@ -93,6 +93,9 @@ class Chef
       # if the service is masked or not
       property :masked, [ TrueClass, FalseClass ], skip_docs: true
 
+      # if the service is static or not
+      property :static, [ TrueClass, FalseClass ], skip_docs: true
+
       # if the service is indirect or not
       property :indirect, [ TrueClass, FalseClass ], skip_docs: true