chef 16.5.77 → 16.6.14

data/spec/unit/mixin/powershell_out_spec.rb

@@ -44,6 +44,20 @@ describe Chef::Mixin::PowershellOut, :windows_only do
       expect(object.powershell_out("Get-Process", timeout: 600)).to eql(ret)
     end
 
+    it "uses pwsh.exe when given :pwsh interpreter" do
+      ret = double("Mixlib::ShellOut")
+      expect(object).to receive(:shell_out).with(
+        "pwsh.exe #{flags} -Command \"Get-Process\"",
+        timeout: 600
+      ).and_return(ret)
+      expect(object.powershell_out("Get-Process", :pwsh, timeout: 600)).to eql(ret)
+    end
+
+    it "raises error if interpreter is invalid" do
+      ret = double("Mixlib::ShellOut")
+      expect { object.powershell_out("Get-Process", :blah, timeout: 600) }.to raise_error(ArgumentError)
+    end
+
     context "when double quote is passed in the powershell command" do
       it "passes if double quote is appended with single escape" do
         result = object.powershell_out("Write-Verbose \"Some String\" -Verbose")

data/spec/unit/provider/powershell_script_spec.rb

@@ -46,5 +46,16 @@ describe Chef::Provider::PowershellScript, "action_run" do
 
       expect(provider.command).to eq(expected)
     end
+
+    it "uses pwsh when given the pwsh interpreter" do
+      new_resource.interpreter = "pwsh"
+      provider.send(:script_file_path=, "C:\\Temp\\Script.ps1")
+
+      expected = <<~CMD.strip
+        "pwsh" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat None  -File "C:\\Temp\\Script.ps1"
+      CMD
+
+      expect(provider.command).to eq(expected)
+    end
   end
 end

data/spec/unit/resource/chef_client_config_spec.rb

@@ -0,0 +1,137 @@
+#
+# Author:: Tim Smith (<tsmith@chef.io>)
+# Copyright:: Copyright (c) Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Resource::ChefClientConfig do
+  let(:node) { Chef::Node.new }
+  let(:events) { Chef::EventDispatch::Dispatcher.new }
+  let(:run_context) { Chef::RunContext.new(node, {}, events) }
+  let(:resource) { Chef::Resource::ChefClientConfig.new("fakey_fakerton", run_context) }
+  let(:provider) { resource.provider_for_action(:create) }
+
+  it "sets the default action as :create" do
+    expect(resource.action).to eql([:create])
+  end
+
+  it "supports :create and :remove actions" do
+    expect { resource.action :create }.not_to raise_error
+    expect { resource.action :remove }.not_to raise_error
+  end
+
+  describe "ssl_verify_mode property" do
+    it "coerces String to Symbol" do
+      resource.ssl_verify_mode "verify_peer"
+      expect(resource.ssl_verify_mode).to eql(:verify_peer)
+    end
+
+    it "coerces Symbol-like String to Symbol" do
+      resource.ssl_verify_mode ":verify_peer"
+      expect(resource.ssl_verify_mode).to eql(:verify_peer)
+    end
+
+    it "raises an error if it is not an allowed value" do
+      expect { resource.ssl_verify_mode("foo") }.to raise_error(Chef::Exceptions::ValidationFailed)
+      expect { resource.ssl_verify_mode(:verify_none) }.not_to raise_error
+      expect { resource.ssl_verify_mode(:verify_peer) }.not_to raise_error
+    end
+  end
+
+  describe "no_proxy property" do
+    it "coerces Array into comma separated list" do
+      resource.no_proxy ["something.com", "example.com"]
+      expect(resource.no_proxy).to eql("something.com,example.com")
+    end
+
+    it "accepts String of comma separated values" do
+      resource.no_proxy "something.com,example.com"
+      expect(resource.no_proxy).to eql("something.com,example.com")
+    end
+  end
+
+  describe "ohai_disabled_plugins property" do
+    it "coerces String values into capitalized symbols" do
+      resource.ohai_disabled_plugins %w{foo Bar}
+      expect(resource.ohai_disabled_plugins).to eql(%i{Foo Bar})
+    end
+
+    it "coerces symbol-like string values into capitalized Symbols" do
+      resource.ohai_disabled_plugins [":foo", ":Bar"]
+      expect(resource.ohai_disabled_plugins).to eql(%i{Foo Bar})
+    end
+
+    it "coerces Symbol values into capitalized Symbols" do
+      resource.ohai_disabled_plugins %i{foo Bar}
+      expect(resource.ohai_disabled_plugins).to eql(%i{Foo Bar})
+    end
+  end
+
+  describe "ohai_optional_plugins property" do
+    it "coerces String values into capitalized symbols" do
+      resource.ohai_optional_plugins %w{foo Bar}
+      expect(resource.ohai_optional_plugins).to eql(%i{Foo Bar})
+    end
+
+    it "coerces symbol-like string values into capitalized Symbols" do
+      resource.ohai_optional_plugins [":foo", ":Bar"]
+      expect(resource.ohai_optional_plugins).to eql(%i{Foo Bar})
+    end
+
+    it "coerces Symbol values into capitalized Symbols" do
+      resource.ohai_optional_plugins %i{foo Bar}
+      expect(resource.ohai_optional_plugins).to eql(%i{Foo Bar})
+    end
+  end
+
+  describe "log_level property" do
+    it "accepts auto trace debug info warn fatal" do
+      expect { resource.log_level(:auto) }.not_to raise_error
+      expect { resource.log_level(:trace) }.not_to raise_error
+      expect { resource.log_level(:debug) }.not_to raise_error
+      expect { resource.log_level(:info) }.not_to raise_error
+      expect { resource.log_level(:warn) }.not_to raise_error
+    end
+
+    it "raises an error if an invalid value is passed" do
+      expect { resource.log_level(":foo") }.to raise_error(Chef::Exceptions::ValidationFailed)
+    end
+  end
+
+  describe "log_location property" do
+    it "accepts a String logfile location" do
+      expect { resource.log_location("/foo/bar/") }.not_to raise_error
+    end
+
+    it "accepts a String form of STDOUT/STDERR" do
+      expect { resource.log_location("STDOUT") }.not_to raise_error
+      expect { resource.log_location("STDERR") }.not_to raise_error
+    end
+
+    it "accepts :syslog or :win_evt Symbols" do
+      expect { resource.log_location(:syslog) }.not_to raise_error
+      expect { resource.log_location(:win_evt) }.not_to raise_error
+      expect { resource.log_location(:nope) }.to raise_error(Chef::Exceptions::ValidationFailed)
+    end
+  end
+
+  describe "#format_handler" do
+    it "provides an array of handler object creation code" do
+      expect(provider.format_handler([{ "class" => "Foo", "arguments" => ["'one'", "two", "three"] }])).to eql(["Foo.new('one',two,three)"])
+    end
+  end
+end

data/spec/unit/resource/powershell_script_spec.rb

@@ -53,9 +53,9 @@ describe Chef::Resource::PowershellScript do
       allow(resource).to receive(:updated).and_return(true)
     end
 
-    it "inherits exactly the :cwd, :environment, :group, :path, :user, :umask, :architecture, :elevated properties from a parent resource class" do
+    it "inherits exactly the :cwd, :environment, :group, :path, :user, :umask, :architecture, :elevated, :interpreter properties from a parent resource class" do
       inherited_difference = Chef::Resource::PowershellScript.guard_inherited_attributes -
-        %i{cwd environment group path user umask architecture elevated}
+        %i{cwd environment group path user umask architecture elevated interpreter}
 
       expect(inherited_difference).to eq([])
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef
 version: !ruby/object:Gem::Version
-  version: 16.5.77
+  version: 16.6.14
 platform: ruby
 authors:
 - Adam Jacob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-28 00:00:00.000000000 Z
+date: 2020-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef-config
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 16.5.77
+        version: 16.6.14
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 16.5.77
+        version: 16.6.14
 - !ruby/object:Gem::Dependency
   name: chef-utils
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 16.5.77
+        version: 16.6.14
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 16.5.77
+        version: 16.6.14
 - !ruby/object:Gem::Dependency
   name: train-core
   requirement: !ruby/object:Gem::Requirement
@@ -1224,6 +1224,7 @@ files:
 - lib/chef/provider/zypper_repository.rb
 - lib/chef/provider_resolver.rb
 - lib/chef/providers.rb
+- lib/chef/pwsh.rb
 - lib/chef/recipe.rb
 - lib/chef/request_id.rb
 - lib/chef/reserved_names.rb
@@ -1241,6 +1242,7 @@ files:
 - lib/chef/resource/breakpoint.rb
 - lib/chef/resource/build_essential.rb
 - lib/chef/resource/cab_package.rb
+- lib/chef/resource/chef_client_config.rb
 - lib/chef/resource/chef_client_cron.rb
 - lib/chef/resource/chef_client_launchd.rb
 - lib/chef/resource/chef_client_scheduled_task.rb
@@ -1344,6 +1346,7 @@ files:
 - lib/chef/resource/solaris_package.rb
 - lib/chef/resource/ssh_known_hosts_entry.rb
 - lib/chef/resource/sudo.rb
+- lib/chef/resource/support/client.erb
 - lib/chef/resource/support/cron.d.erb
 - lib/chef/resource/support/cron_access.erb
 - lib/chef/resource/support/ssh_known_hosts.erb
@@ -2520,6 +2523,7 @@ files:
 - spec/unit/resource/breakpoint_spec.rb
 - spec/unit/resource/build_essential_spec.rb
 - spec/unit/resource/cab_package_spec.rb
+- spec/unit/resource/chef_client_config_spec.rb
 - spec/unit/resource/chef_client_cron_spec.rb
 - spec/unit/resource/chef_client_launchd_spec.rb
 - spec/unit/resource/chef_client_scheduled_task_spec.rb
@@ -2737,7 +2741,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: A systems integration framework, built to bring the benefits of configuration