chef 16.15.22 → 17.0.242

data/spec/unit/knife/cookbook_show_spec.rb

@@ -1,253 +0,0 @@
-#
-# Author:: Adam Jacob (<adam@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Knife::CookbookShow do
-  before do
-    Chef::Config[:node_name] = "webmonkey.example.com"
-    allow(knife).to receive(:rest).and_return(rest)
-    allow(knife).to receive(:pretty_print).and_return(true)
-    allow(knife).to receive(:output).and_return(true)
-    allow(Chef::CookbookVersion).to receive(:load).and_return(cb)
-  end
-
-  let(:knife) do
-    knife = Chef::Knife::CookbookShow.new
-    knife.config = {}
-    knife.name_args = [ "cookbook_name" ]
-    knife
-  end
-
-  let(:cb) do
-    cb = Chef::CookbookVersion.new("cookbook_name")
-    cb.manifest = manifest
-    cb
-  end
-
-  let(:rest) { double(Chef::ServerAPI) }
-
-  let(:content) { "Example recipe text" }
-
-  let(:manifest) do
-    {
-      "all_files" => [
-        {
-          name: "recipes/default.rb",
-          path: "recipes/default.rb",
-          checksum: "1234",
-          url: "http://example.org/files/default.rb",
-        },
-      ],
-    }
-  end
-
-  describe "run" do
-    describe "with 0 arguments: help" do
-      it "should should print usage and exit when given no arguments" do
-        knife.name_args = []
-        expect(knife).to receive(:show_usage)
-        expect(knife.ui).to receive(:fatal)
-        expect { knife.run }.to raise_error(SystemExit)
-      end
-    end
-
-    describe "with 1 argument: versions" do
-      let(:response) do
-        {
-          "cookbook_name" => {
-            "url" => "http://url/cookbooks/cookbook_name",
-            "versions" => [
-              { "version" => "0.10.0", "url" => "http://url/cookbooks/cookbook_name/0.10.0" },
-              { "version" => "0.9.0", "url" => "http://url/cookbookx/cookbook_name/0.9.0" },
-              { "version" => "0.8.0", "url" => "http://url/cookbooks/cookbook_name/0.8.0" },
-            ],
-          },
-        }
-      end
-
-      it "should show the raw cookbook data" do
-        expect(rest).to receive(:get).with("cookbooks/cookbook_name").and_return(response)
-        expect(knife).to receive(:format_cookbook_list_for_display).with(response)
-        knife.run
-      end
-
-      it "should respect the user-supplied environment" do
-        knife.config[:environment] = "foo"
-        expect(rest).to receive(:get).with("environments/foo/cookbooks/cookbook_name").and_return(response)
-        expect(knife).to receive(:format_cookbook_list_for_display).with(response)
-        knife.run
-      end
-    end
-
-    describe "with 2 arguments: name and version" do
-      before do
-        knife.name_args << "0.1.0"
-      end
-
-      let(:output) do
-        { "cookbook_name" => "cookbook_name",
-          "name" => "cookbook_name-0.0.0",
-          "frozen?" => false,
-          "version" => "0.0.0",
-          "metadata" => {
-            "name" => nil,
-            "description" => "",
-            "eager_load_libraries" => true,
-            "long_description" => "",
-            "maintainer" => "",
-            "maintainer_email" => "",
-            "license" => "All rights reserved",
-            "platforms" => {},
-            "dependencies" => {},
-            "providing" => {},
-            "recipes" => {},
-            "version" => "0.0.0",
-            "source_url" => "",
-            "issues_url" => "",
-            "privacy" => false,
-            "chef_versions" => [],
-            "ohai_versions" => [],
-            "gems" => [],
-          },
-          "recipes" =>
-          [{ "name" => "recipes/default.rb",
-             "path" => "recipes/default.rb",
-             "checksum" => "1234",
-             "url" => "http://example.org/files/default.rb" }],
-        }
-      end
-
-      it "should show the specific part of a cookbook" do
-        expect(Chef::CookbookVersion).to receive(:load).with("cookbook_name", "0.1.0").and_return(cb)
-        expect(knife).to receive(:output).with(output)
-        knife.run
-      end
-    end
-
-    describe "with 3 arguments: name, version, and segment" do
-      before(:each) do
-        knife.name_args = [ "cookbook_name", "0.1.0", "recipes" ]
-      end
-
-      it "should print the json of the part" do
-        expect(Chef::CookbookVersion).to receive(:load).with("cookbook_name", "0.1.0").and_return(cb)
-        expect(knife).to receive(:output).with(cb.files_for("recipes"))
-        knife.run
-      end
-    end
-
-    describe "with 4 arguments: name, version, segment and filename" do
-      before(:each) do
-        knife.name_args = [ "cookbook_name", "0.1.0", "recipes", "default.rb" ]
-      end
-
-      it "should print the raw result of the request (likely a file!)" do
-        expect(Chef::CookbookVersion).to receive(:load).with("cookbook_name", "0.1.0").and_return(cb)
-        expect(rest).to receive(:streaming_request).with("http://example.org/files/default.rb").and_return(StringIO.new(content))
-        expect(knife).to receive(:pretty_print).with(content)
-        knife.run
-      end
-    end
-
-    describe "with 4 arguments: name, version, segment and filename -- with specificity" do
-      before(:each) do
-        knife.name_args = [ "cookbook_name", "0.1.0", "files", "afile.rb" ]
-        cb.manifest = {
-          "all_files" => [
-            {
-              name: "files/afile.rb",
-              path: "files/host-examplehost.example.org/afile.rb",
-              checksum: "1111",
-              specificity: "host-examplehost.example.org",
-              url: "http://example.org/files/1111",
-            },
-            {
-              name: "files/afile.rb",
-              path: "files/ubuntu-9.10/afile.rb",
-              checksum: "2222",
-              specificity: "ubuntu-9.10",
-              url: "http://example.org/files/2222",
-            },
-            {
-              name: "files/afile.rb",
-              path: "files/ubuntu/afile.rb",
-              checksum: "3333",
-              specificity: "ubuntu",
-              url: "http://example.org/files/3333",
-            },
-            {
-              name: "files/afile.rb",
-              path: "files/default/afile.rb",
-              checksum: "4444",
-              specificity: "default",
-              url: "http://example.org/files/4444",
-            },
-          ],
-        }
-
-      end
-
-      describe "with --fqdn" do
-        it "should pass the fqdn" do
-          knife.config[:platform] = "example_platform"
-          knife.config[:platform_version] = "1.0"
-          knife.config[:fqdn] = "examplehost.example.org"
-          expect(Chef::CookbookVersion).to receive(:load).with("cookbook_name", "0.1.0").and_return(cb)
-          expect(rest).to receive(:streaming_request).with("http://example.org/files/1111").and_return(StringIO.new(content))
-          expect(knife).to receive(:pretty_print).with(content)
-          knife.run
-        end
-      end
-
-      describe "and --platform" do
-        it "should pass the platform" do
-          knife.config[:platform] = "ubuntu"
-          knife.config[:platform_version] = "1.0"
-          knife.config[:fqdn] = "differenthost.example.org"
-          expect(Chef::CookbookVersion).to receive(:load).with("cookbook_name", "0.1.0").and_return(cb)
-          expect(rest).to receive(:streaming_request).with("http://example.org/files/3333").and_return(StringIO.new(content))
-          expect(knife).to receive(:pretty_print).with(content)
-          knife.run
-        end
-      end
-
-      describe "and --platform-version" do
-        it "should pass the platform" do
-          knife.config[:platform] = "ubuntu"
-          knife.config[:platform_version] = "9.10"
-          knife.config[:fqdn] = "differenthost.example.org"
-          expect(Chef::CookbookVersion).to receive(:load).with("cookbook_name", "0.1.0").and_return(cb)
-          expect(rest).to receive(:streaming_request).with("http://example.org/files/2222").and_return(StringIO.new(content))
-          expect(knife).to receive(:pretty_print).with(content)
-          knife.run
-        end
-      end
-
-      describe "with none of the arguments, it should use the default" do
-        it "should pass them all" do
-          expect(Chef::CookbookVersion).to receive(:load).with("cookbook_name", "0.1.0").and_return(cb)
-          expect(rest).to receive(:streaming_request).with("http://example.org/files/4444").and_return(StringIO.new(content))
-          expect(knife).to receive(:pretty_print).with(content)
-          knife.run
-        end
-      end
-
-    end
-  end
-end

data/spec/unit/knife/cookbook_upload_spec.rb

@@ -1,364 +0,0 @@
-#
-# Author:: Matthew Kent (<mkent@magoazul.com>)
-# Author:: Steven Danna (<steve@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-require "chef/cookbook_uploader"
-require "timeout"
-
-describe Chef::Knife::CookbookUpload do
-  let(:cookbook) do
-    cookbook = Chef::CookbookVersion.new("test_cookbook", "/tmp/blah")
-    allow(cookbook).to receive(:has_metadata_file?).and_return(true)
-    allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
-    cookbook
-  end
-
-  let(:cookbooks_by_name) do
-    { cookbook.name => cookbook }
-  end
-
-  let(:cookbook_loader) do
-    cookbook_loader = cookbooks_by_name.dup
-    allow(cookbook_loader).to receive(:merged_cookbooks).and_return([])
-    allow(cookbook_loader).to receive(:load_cookbooks).and_return(cookbook_loader)
-    allow(cookbook_loader).to receive(:compile_metadata).and_return(nil)
-    allow(cookbook_loader).to receive(:freeze_versions).and_return(nil)
-    cookbook_loader
-  end
-
-  let(:cookbook_uploader) { double(upload_cookbooks: nil) }
-
-  let(:output) { StringIO.new }
-
-  let(:name_args) { ["test_cookbook"] }
-
-  let(:knife) do
-    k = Chef::Knife::CookbookUpload.new
-    k.name_args = name_args
-    allow(k.ui).to receive(:stdout).and_return(output)
-    allow(k.ui).to receive(:stderr).and_return(output)
-    k
-  end
-
-  before(:each) do
-    allow(Chef::CookbookLoader).to receive(:new).and_return(cookbook_loader)
-    allow(Chef::CookbookLoader).to receive(:copy_to_tmp_dir_from_array).and_yield(cookbook_loader)
-  end
-
-  describe "with --concurrency" do
-    it "should upload cookbooks with predefined concurrency" do
-      allow(Chef::CookbookVersion).to receive(:list_all_versions).and_return({})
-      knife.config[:concurrency] = 3
-      test_cookbook = Chef::CookbookVersion.new("test_cookbook", "/tmp/blah")
-      allow(cookbook_loader).to receive(:each).and_yield("test_cookbook", test_cookbook)
-      allow(cookbook_loader).to receive(:cookbook_names).and_return(["test_cookbook"])
-      expect(Chef::CookbookUploader).to receive(:new)
-        .with( kind_of(Array), { force: nil, concurrency: 3 })
-        .and_return(double("Chef::CookbookUploader", upload_cookbooks: true))
-      knife.run
-    end
-  end
-
-  describe "run" do
-    before(:each) do
-      allow(Chef::CookbookUploader).to receive_messages(new: cookbook_uploader)
-      allow(Chef::CookbookVersion).to receive(:list_all_versions).and_return({})
-    end
-
-    it "should print usage and exit when a cookbook name is not provided" do
-      knife.name_args = []
-      expect(knife).to receive(:show_usage)
-      expect(knife.ui).to receive(:fatal)
-      expect { knife.run }.to raise_error(SystemExit)
-    end
-
-    describe "when specifying cookbook without metadata.rb or metadata.json" do
-      let(:name_args) { ["test_cookbook1"] }
-      let(:cookbook) do
-        cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
-        allow(cookbook).to receive(:has_metadata_file?).and_return(false)
-        cookbook
-      end
-
-      it "should upload the cookbook" do
-        expect { knife.run }.to raise_error(Chef::Exceptions::MetadataNotFound)
-      end
-    end
-
-    describe "when name attribute in metadata not set" do
-      let(:name_args) { ["test_cookbook1"] }
-
-      let(:cookbook) do
-        cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
-        allow(cookbook).to receive(:has_metadata_file?).and_return(true)
-        allow(cookbook.metadata).to receive(:name).and_return(nil)
-        cookbook
-      end
-
-      it "should upload the cookbook" do
-        expect { knife.run }.to raise_error(Chef::Exceptions::MetadataNotValid)
-      end
-    end
-
-    describe "when specifying a cookbook name" do
-      it "should upload the cookbook" do
-        expect(knife).to receive(:upload).once
-        knife.run
-      end
-
-      it "should report on success" do
-        expect(knife).to receive(:upload).once
-        expect(knife.ui).to receive(:info).with(/Uploaded 1 cookbook/)
-        knife.run
-      end
-    end
-
-    describe "when specifying the same cookbook name twice" do
-      it "should upload the cookbook only once" do
-        knife.name_args = %w{test_cookbook test_cookbook}
-        expect(knife).to receive(:upload).once
-        knife.run
-      end
-    end
-
-    describe "when specifying a cookbook name among many" do
-      let(:name_args) { ["test_cookbook1"] }
-
-      let(:cookbook) do
-        cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
-        allow(cookbook).to receive(:has_metadata_file?).and_return(true)
-        allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
-        cookbook
-      end
-
-      let(:cookbooks_by_name) do
-        { cookbook.name => cookbook }
-      end
-
-      it "should read only one cookbook" do
-        expect(cookbook_loader).to receive(:[]).once.with("test_cookbook1").and_call_original
-        knife.run
-      end
-
-      it "should not read all cookbooks" do
-        expect(cookbook_loader).to receive(:load_cookbooks)
-        knife.run
-      end
-
-      it "should upload only one cookbook" do
-        expect(knife).to receive(:upload).exactly(1).times
-        knife.run
-      end
-    end
-
-    # This is testing too much.  We should break it up.
-    describe "when specifying a cookbook name with dependencies" do
-      let(:name_args) { ["test_cookbook2"] }
-
-      let(:test_cookbook1) do
-        cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
-        allow(cookbook).to receive(:has_metadata_file?).and_return(true)
-        allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
-        cookbook
-      end
-
-      let(:test_cookbook2) do
-        c = Chef::CookbookVersion.new("test_cookbook2")
-        c.metadata.depends("test_cookbook3")
-        allow(c).to receive(:has_metadata_file?).and_return(true)
-        allow(c.metadata).to receive(:name).and_return(c.name)
-        c
-      end
-
-      let(:test_cookbook3) do
-        c = Chef::CookbookVersion.new("test_cookbook3")
-        c.metadata.depends("test_cookbook1")
-        c.metadata.depends("test_cookbook2")
-        allow(c).to receive(:has_metadata_file?).and_return(true)
-        allow(c.metadata).to receive(:name).and_return(c.name)
-        c
-      end
-
-      let(:cookbooks_by_name) do
-        { "test_cookbook1" => test_cookbook1,
-          "test_cookbook2" => test_cookbook2,
-          "test_cookbook3" => test_cookbook3 }
-      end
-
-      it "should upload all dependencies once" do
-        knife.config[:depends] = true
-        allow(knife).to receive(:cookbook_names).and_return(%w{test_cookbook1 test_cookbook2 test_cookbook3})
-        expect(knife).to receive(:upload).exactly(3).times
-        expect do
-          Timeout.timeout(5) do
-            knife.run
-          end
-        end.not_to raise_error
-      end
-    end
-
-    describe "when specifying a cookbook name with missing dependencies" do
-      let(:cookbook_dependency) { Chef::CookbookVersion.new("dependency", "/tmp/blah") }
-
-      before(:each) do
-        cookbook.metadata.depends("dependency")
-        allow(cookbook_loader).to receive(:[]) do |ckbk|
-          { "test_cookbook" => cookbook,
-            "dependency" => cookbook_dependency }[ckbk]
-        end
-        allow(knife).to receive(:cookbook_names).and_return(%w{cookbook_dependency test_cookbook})
-        @stdout, @stderr, @stdin = StringIO.new, StringIO.new, StringIO.new
-        knife.ui = Chef::Knife::UI.new(@stdout, @stderr, @stdin, {})
-      end
-
-      it "should exit and not upload the cookbook" do
-        expect(cookbook_loader).to receive(:[]).once.with("test_cookbook")
-        expect(cookbook_uploader).not_to receive(:upload_cookbooks)
-        expect { knife.run }.to raise_error(SystemExit)
-      end
-
-      it "should output a message for a single missing dependency" do
-        expect { knife.run }.to raise_error(SystemExit)
-        expect(@stderr.string).to include("Cookbook test_cookbook depends on cookbooks which are not currently")
-        expect(@stderr.string).to include("being uploaded and cannot be found on the server.")
-        expect(@stderr.string).to include("The missing cookbook(s) are: 'dependency' version '>= 0.0.0'")
-      end
-
-      it "should output a message for a multiple missing dependencies which are concatenated" do
-        cookbook_dependency2 = Chef::CookbookVersion.new("dependency2")
-        cookbook.metadata.depends("dependency2")
-        allow(cookbook_loader).to receive(:[]) do |ckbk|
-          { "test_cookbook" => cookbook,
-            "dependency" => cookbook_dependency,
-            "dependency2" => cookbook_dependency2 }[ckbk]
-        end
-        allow(knife).to receive(:cookbook_names).and_return(%w{dependency dependency2 test_cookbook})
-        expect { knife.run }.to raise_error(SystemExit)
-        expect(@stderr.string).to include("Cookbook test_cookbook depends on cookbooks which are not currently")
-        expect(@stderr.string).to include("being uploaded and cannot be found on the server.")
-        expect(@stderr.string).to include("The missing cookbook(s) are:")
-        expect(@stderr.string).to include("'dependency' version '>= 0.0.0'")
-        expect(@stderr.string).to include("'dependency2' version '>= 0.0.0'")
-      end
-    end
-
-    it "should freeze the version of the cookbooks if --freeze is specified" do
-      knife.config[:freeze] = true
-      expect(cookbook_loader).to receive(:freeze_versions).once
-      knife.run
-    end
-
-    describe "with -a or --all" do
-      before(:each) do
-        knife.config[:all] = true
-      end
-
-      context "when cookbooks exist in the cookbook path" do
-        let(:test_cookbook1) do
-          cookbook = Chef::CookbookVersion.new("test_cookbook1", "/tmp/blah")
-          allow(cookbook).to receive(:has_metadata_file?).and_return(true)
-          allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
-          cookbook
-        end
-
-        let(:test_cookbook2) do
-          cookbook = Chef::CookbookVersion.new("test_cookbook2", "/tmp/blah")
-          allow(cookbook).to receive(:has_metadata_file?).and_return(true)
-          allow(cookbook.metadata).to receive(:name).and_return(cookbook.name)
-          cookbook
-        end
-
-        before(:each) do
-          allow(cookbook_loader).to receive(:each).and_yield("test_cookbook1", test_cookbook1).and_yield("test_cookbook2", test_cookbook2)
-          allow(cookbook_loader).to receive(:cookbook_names).and_return(%w{test_cookbook1 test_cookbook2})
-        end
-
-        it "should upload all cookbooks" do
-          expect(knife).to receive(:upload).once
-          knife.run
-        end
-
-        it "should report on success" do
-          expect(knife).to receive(:upload).once
-          expect(knife.ui).to receive(:info).with(/Uploaded all cookbooks/)
-          knife.run
-        end
-
-        it "should update the version constraints for an environment" do
-          allow(knife).to receive(:assert_environment_valid!).and_return(true)
-          knife.config[:environment] = "production"
-          expect(knife).to receive(:update_version_constraints).once
-          knife.run
-        end
-      end
-
-      context "when no cookbooks exist in the cookbook path" do
-        before(:each) do
-          allow(cookbook_loader).to receive(:each)
-        end
-
-        it "should not upload any cookbooks" do
-          expect(knife).to_not receive(:upload)
-          knife.run
-        end
-
-        context "when cookbook path is an array" do
-          it "should warn users that no cookbooks exist" do
-            cookbook_path = windows? ? "C:/chef-repo/cookbooks" : "/chef-repo/cookbooks"
-            knife.config[:cookbook_path] = [cookbook_path, "/home/user/cookbooks"]
-            expect(knife.ui).to receive(:warn).with("Could not find any cookbooks in your cookbook path: '#{knife.config[:cookbook_path].join(", ")}'. Use --cookbook-path to specify the desired path.")
-            knife.run
-          end
-        end
-
-        context "when cookbook path is a string" do
-          it "should warn users that no cookbooks exist" do
-            knife.config[:cookbook_path] = windows? ? "C:/chef-repo/cookbooks" : "/chef-repo/cookbooks"
-            expect(knife.ui).to receive(:warn).with(
-              "Could not find any cookbooks in your cookbook path: '#{knife.config[:cookbook_path]}'. Use --cookbook-path to specify the desired path."
-            )
-            knife.run
-          end
-        end
-      end
-    end
-
-    describe "when a frozen cookbook exists on the server" do
-      it "should fail to replace it" do
-        exception = Chef::Exceptions::CookbookFrozen.new
-        expect(cookbook_uploader).to receive(:upload_cookbooks)
-          .and_raise(exception)
-        allow(knife.ui).to receive(:error)
-        expect(knife.ui).to receive(:error).with(exception)
-        expect { knife.run }.to raise_error(SystemExit)
-      end
-
-      it "should not update the version constraints for an environment" do
-        allow(knife).to receive(:assert_environment_valid!).and_return(true)
-        knife.config[:environment] = "production"
-        allow(knife).to receive(:upload).and_raise(Chef::Exceptions::CookbookFrozen)
-        expect(knife.ui).to receive(:error).with(/Failed to upload 1 cookbook/)
-        expect(knife.ui).to receive(:warn).with(/Not updating version constraints/)
-        expect(knife).not_to receive(:update_version_constraints)
-        expect { knife.run }.to raise_error(SystemExit)
-      end
-    end
-  end # run
-end