chef 16.10.8-universal-mingw32 → 17.0.242-universal-mingw32

data/spec/unit/knife/core/cookbook_scm_repo_spec.rb

@@ -1,187 +0,0 @@
-#
-# Author:: Daniel DeLeo (<dan@chef.io>)
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-require "chef/knife/core/cookbook_scm_repo"
-
-describe Chef::Knife::CookbookSCMRepo do
-  before do
-    @repo_path = File.join(CHEF_SPEC_DATA, "cookbooks")
-    @stdout, @stderr, @stdin = StringIO.new, StringIO.new, StringIO.new
-    @ui = Chef::Knife::UI.new(@stdout, @stderr, @stdin, {})
-    @cookbook_repo = Chef::Knife::CookbookSCMRepo.new(@repo_path, @ui, default_branch: "master")
-
-    @branch_list = Mixlib::ShellOut.new
-    @branch_list.stdout.replace(<<-BRANCHES)
-  chef-vendor-apache2
-  chef-vendor-build-essential
-  chef-vendor-dynomite
-  chef-vendor-ganglia
-  chef-vendor-graphite
-  chef-vendor-python
-  chef-vendor-absent-new
-    BRANCHES
-  end
-
-  it "has a path to the cookbook repo" do
-    expect(@cookbook_repo.repo_path).to eq(@repo_path)
-  end
-
-  it "has a default branch" do
-    expect(@cookbook_repo.default_branch).to eq("master")
-  end
-
-  describe "when sanity checking the repo" do
-    it "exits when the directory does not exist" do
-      expect(::File).to receive(:directory?).with(@repo_path).and_return(false)
-      expect { @cookbook_repo.sanity_check }.to raise_error(SystemExit)
-    end
-
-    describe "and the repo dir exists" do
-      before do
-        allow(::File).to receive(:directory?).with(@repo_path).and_return(true)
-      end
-
-      it "exits when there is no git repo" do
-        allow(::File).to receive(:directory?).with(/.*\.git/).and_return(false)
-        expect { @cookbook_repo.sanity_check }.to raise_error(SystemExit)
-      end
-
-      describe "and the repo is a git repo" do
-        before do
-          allow(::File).to receive(:directory?).with(File.join(@repo_path, ".git")).and_return(true)
-        end
-
-        it "exits when the default branch doesn't exist" do
-          @nobranches = Mixlib::ShellOut.new.tap { |s| s.stdout.replace "\n" }
-          expect(@cookbook_repo).to receive(:shell_out!).with("git branch --no-color", cwd: @repo_path).and_return(@nobranches)
-          expect { @cookbook_repo.sanity_check }.to raise_error(SystemExit)
-        end
-
-        describe "and the default branch exists" do
-          before do
-            @master_branch = Mixlib::ShellOut.new
-            @master_branch.stdout.replace "* master\n"
-            expect(@cookbook_repo).to receive(:shell_out!).with("git branch --no-color", cwd: @repo_path).and_return(@master_branch)
-          end
-
-          it "exits when the git repo is dirty" do
-            @dirty_status = Mixlib::ShellOut.new
-            @dirty_status.stdout.replace(<<-DIRTY)
- M chef/lib/chef/knife/cookbook_site_install.rb
-            DIRTY
-            expect(@cookbook_repo).to receive(:shell_out!).with("git status --porcelain", cwd: @repo_path).and_return(@dirty_status)
-            expect { @cookbook_repo.sanity_check }.to raise_error(SystemExit)
-          end
-
-          describe "and the repo is clean" do
-            before do
-              @clean_status = Mixlib::ShellOut.new.tap { |s| s.stdout.replace("\n") }
-              allow(@cookbook_repo).to receive(:shell_out!).with("git status --porcelain", cwd: @repo_path).and_return(@clean_status)
-            end
-
-            it "passes the sanity check" do
-              @cookbook_repo.sanity_check
-            end
-
-          end
-        end
-      end
-    end
-  end
-
-  it "resets to default state by checking out the default branch" do
-    expect(@cookbook_repo).to receive(:shell_out!).with("git checkout master", cwd: @repo_path)
-    @cookbook_repo.reset_to_default_state
-  end
-
-  it "determines if a the pristine copy branch exists" do
-    expect(@cookbook_repo).to receive(:shell_out!).with("git branch --no-color", cwd: @repo_path).and_return(@branch_list)
-    expect(@cookbook_repo.branch_exists?("chef-vendor-apache2")).to be_truthy
-    expect(@cookbook_repo).to receive(:shell_out!).with("git branch --no-color", cwd: @repo_path).and_return(@branch_list)
-    expect(@cookbook_repo.branch_exists?("chef-vendor-nginx")).to be_falsey
-  end
-
-  it "determines if a the branch not exists correctly without substring search" do
-    expect(@cookbook_repo).to receive(:shell_out!).twice.with("git branch --no-color", cwd: @repo_path).and_return(@branch_list)
-    expect(@cookbook_repo).not_to be_branch_exists("chef-vendor-absent")
-    expect(@cookbook_repo).to be_branch_exists("chef-vendor-absent-new")
-  end
-
-  describe "when the pristine copy branch does not exist" do
-    it "prepares for import by creating the pristine copy branch" do
-      expect(@cookbook_repo).to receive(:shell_out!).with("git branch --no-color", cwd: @repo_path).and_return(@branch_list)
-      expect(@cookbook_repo).to receive(:shell_out!).with("git checkout -b chef-vendor-nginx", cwd: @repo_path)
-      @cookbook_repo.prepare_to_import("nginx")
-    end
-  end
-
-  describe "when the pristine copy branch does exist" do
-    it "prepares for import by checking out the pristine copy branch" do
-      expect(@cookbook_repo).to receive(:shell_out!).with("git branch --no-color", cwd: @repo_path).and_return(@branch_list)
-      expect(@cookbook_repo).to receive(:shell_out!).with("git checkout chef-vendor-apache2", cwd: @repo_path)
-      @cookbook_repo.prepare_to_import("apache2")
-    end
-  end
-
-  describe "when the pristine copy branch was not updated by the changes" do
-    before do
-      @updates = Mixlib::ShellOut.new
-      @updates.stdout.replace("\n")
-      allow(@cookbook_repo).to receive(:shell_out!).with("git status --porcelain -- apache2", cwd: @repo_path).and_return(@updates)
-    end
-
-    it "shows no changes in the pristine copy" do
-      expect(@cookbook_repo.updated?("apache2")).to be_falsey
-    end
-
-    it "does nothing to finalize the updates" do
-      expect(@cookbook_repo.finalize_updates_to("apache2", "1.2.3")).to be_falsey
-    end
-  end
-
-  describe "when the pristine copy branch was updated by the changes" do
-    before do
-      @updates = Mixlib::ShellOut.new
-      @updates.stdout.replace(" M cookbooks/apache2/recipes/default.rb\n")
-      allow(@cookbook_repo).to receive(:shell_out!).with("git status --porcelain -- apache2", cwd: @repo_path).and_return(@updates)
-    end
-
-    it "shows changes in the pristine copy" do
-      expect(@cookbook_repo.updated?("apache2")).to be_truthy
-    end
-
-    it "commits the changes to the repo and tags the commit" do
-      expect(@cookbook_repo).to receive(:shell_out!).with("git add apache2", cwd: @repo_path)
-      expect(@cookbook_repo).to receive(:shell_out!).with("git commit -m \"Import apache2 version 1.2.3\" -- apache2", cwd: @repo_path)
-      expect(@cookbook_repo).to receive(:shell_out!).with("git tag -f cookbook-site-imported-apache2-1.2.3", cwd: @repo_path)
-      expect(@cookbook_repo.finalize_updates_to("apache2", "1.2.3")).to be_truthy
-    end
-  end
-
-  describe "when a custom default branch is specified" do
-    before do
-      @cookbook_repo = Chef::Knife::CookbookSCMRepo.new(@repo_path, @ui, default_branch: "develop")
-    end
-
-    it "resets to default state by checking out the default branch" do
-      expect(@cookbook_repo).to receive(:shell_out!).with("git checkout develop", cwd: @repo_path)
-      @cookbook_repo.reset_to_default_state
-    end
-  end
-end

data/spec/unit/knife/core/gem_glob_loader_spec.rb

@@ -1,209 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Knife::SubcommandLoader::GemGlobLoader do
-  let(:loader) { Chef::Knife::SubcommandLoader::GemGlobLoader.new(File.join(CHEF_SPEC_DATA, "knife-site-subcommands")) }
-  let(:home) { File.join(CHEF_SPEC_DATA, "knife-home") }
-  let(:plugin_dir) { File.join(home, ".chef", "plugins", "knife") }
-
-  before do
-    allow(ChefUtils).to receive(:windows?) { false }
-    Chef::Util::PathHelper.class_variable_set(:@@home_dir, home)
-  end
-
-  after do
-    Chef::Util::PathHelper.class_variable_set(:@@home_dir, nil)
-  end
-
-  it "builds a list of the core subcommand file require paths" do
-    expect(loader.subcommand_files).not_to be_empty
-    loader.subcommand_files.each do |require_path|
-      expect(require_path).to match(%r{chef/knife/.*|plugins/knife/.*})
-    end
-  end
-
-  it "finds files installed via rubygems" do
-    expect(loader.find_subcommands_via_rubygems).to include("chef/knife/node_create")
-    loader.find_subcommands_via_rubygems.each_value { |abs_path| expect(abs_path).to match(%r{chef/knife/.+}) }
-  end
-
-  it "finds files from latest version of installed gems" do
-    gems = [ double("knife-ec2-0.5.12") ]
-    gem_files = [
-      "/usr/lib/ruby/gems/knife-ec2-0.5.12/lib/chef/knife/ec2_base.rb",
-      "/usr/lib/ruby/gems/knife-ec2-0.5.12/lib/chef/knife/ec2_otherstuff.rb",
-    ]
-    expect($LOAD_PATH).to receive(:map).and_return([])
-    if Gem::Specification.respond_to? :latest_specs
-      expect(Gem::Specification).to receive(:latest_specs).with(true).and_return(gems)
-      expect(gems[0]).to receive(:matches_for_glob).with(%r{chef/knife/\*\.rb\{(.*),\.rb,(.*)\}}).and_return(gem_files)
-    else
-      expect(Gem.source_index).to receive(:latest_specs).with(true).and_return(gems)
-      expect(gems[0]).to receive(:require_paths).twice.and_return(["lib"])
-      expect(gems[0]).to receive(:full_gem_path).and_return("/usr/lib/ruby/gems/knife-ec2-0.5.12")
-      expect(Dir).to receive(:[]).with("/usr/lib/ruby/gems/knife-ec2-0.5.12/lib/chef/knife/*.rb").and_return(gem_files)
-    end
-    expect(loader).to receive(:find_subcommands_via_dirglob).and_return({})
-    expect(loader.subcommand_files.select { |file| file =~ /knife-ec2/ }.sort).to eq(gem_files)
-  end
-
-  it "finds files using a dirglob when rubygems is not available" do
-    expect(loader.find_subcommands_via_dirglob).to include("chef/knife/node_create")
-    loader.find_subcommands_via_dirglob.each_value { |abs_path| expect(abs_path).to match(%r{chef/knife/.+}) }
-  end
-
-  it "finds user-specific subcommands in the user's ~/.chef directory" do
-    expected_command = File.join(home, ".chef", "plugins", "knife", "example_home_subcommand.rb")
-    expect(loader.site_subcommands).to include(expected_command)
-  end
-
-  it "finds repo specific subcommands by searching for a .chef directory" do
-    expected_command = File.join(CHEF_SPEC_DATA, "knife-site-subcommands", "plugins", "knife", "example_subcommand.rb")
-    expect(loader.site_subcommands).to include(expected_command)
-  end
-
-  # https://github.com/chef/chef-dk/issues/227
-  #
-  # `knife` in ChefDK isn't from a gem install, it's directly run from a clone
-  # of the source, but there can be one or more versions of chef also installed
-  # as a gem. If the gem install contains a command that doesn't exist in the
-  # source tree of the "primary" chef install, it can be loaded and cause an
-  # error. We also want to ensure that we only load builtin commands from the
-  # "primary" chef install.
-  context "when a different version of chef is also installed as a gem" do
-
-    let(:all_found_commands) do
-      [
-        "/opt/chefdk/embedded/apps/chef/lib/chef/knife/bootstrap.rb",
-        "/opt/chefdk/embedded/apps/chef/lib/chef/knife/client_bulk_delete.rb",
-        "/opt/chefdk/embedded/apps/chef/lib/chef/knife/client_create.rb",
-
-        # We use the fake version 1.0.0 because that version doesn't exist,
-        # which ensures it won't ever equal "chef-#{Chef::VERSION}"
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-1.0.0/lib/chef/knife/bootstrap.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-1.0.0/lib/chef/knife/client_bulk_delete.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-1.0.0/lib/chef/knife/client_create.rb",
-
-        # Test that we don't accept a version number that is different only in
-        # trailing characters, e.g. we are running Chef 12.0.0 but there is a
-        # Chef 12.0.0.rc.0 gem also:
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}.rc.0/lib/chef/knife/thing.rb",
-
-        # Test that we ignore the platform suffix when checking for different
-        # gem versions.
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}-x86-mingw32/lib/chef/knife/valid.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}-i386-mingw64/lib/chef/knife/valid-too.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}-mswin32/lib/chef/knife/also-valid.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}-universal-mingw32/lib/chef/knife/universal-is-valid.rb",
-        # ...but don't ignore the .rc / .dev parts in the case when we have
-        # platform suffixes
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}.rc.0-x86-mingw32/lib/chef/knife/invalid.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}.dev-mswin32/lib/chef/knife/invalid-too.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}.dev.0-x86-mingw64/lib/chef/knife/still-invalid.rb",
-
-        # This command is "extra" compared to what's in the embedded/apps/chef install:
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-1.0.0/lib/chef/knife/data_bag_secret_options.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-vault-2.2.4/lib/chef/knife/decrypt.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/knife-spork-1.4.1/lib/chef/knife/spork-bump.rb",
-
-        # These are fake commands that have names designed to test that the
-        # regex is strict enough
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-foo-#{Chef::VERSION}/lib/chef/knife/chef-foo.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/foo-chef-#{Chef::VERSION}/lib/chef/knife/foo-chef.rb",
-
-        # In a real scenario, we'd use rubygems APIs to only select the most
-        # recent gem, but for this test we want to check that we're doing the
-        # right thing both when the plugin version matches and does not match
-        # the current chef version. Looking at
-        # `SubcommandLoader::MATCHES_THIS_CHEF_GEM` and
-        # `SubcommandLoader::MATCHES_CHEF_GEM` should make it clear why we want
-        # to test these two cases.
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-bar-1.0.0/lib/chef/knife/chef-bar.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/bar-chef-1.0.0/lib/chef/knife/bar-chef.rb",
-      ]
-    end
-
-    let(:expected_valid_commands) do
-      [
-        "/opt/chefdk/embedded/apps/chef/lib/chef/knife/bootstrap.rb",
-        "/opt/chefdk/embedded/apps/chef/lib/chef/knife/client_bulk_delete.rb",
-        "/opt/chefdk/embedded/apps/chef/lib/chef/knife/client_create.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}-x86-mingw32/lib/chef/knife/valid.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}-i386-mingw64/lib/chef/knife/valid-too.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}-mswin32/lib/chef/knife/also-valid.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-#{Chef::VERSION}-universal-mingw32/lib/chef/knife/universal-is-valid.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-vault-2.2.4/lib/chef/knife/decrypt.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/knife-spork-1.4.1/lib/chef/knife/spork-bump.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-foo-#{Chef::VERSION}/lib/chef/knife/chef-foo.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/foo-chef-#{Chef::VERSION}/lib/chef/knife/foo-chef.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-bar-1.0.0/lib/chef/knife/chef-bar.rb",
-        "/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/bar-chef-1.0.0/lib/chef/knife/bar-chef.rb",
-      ]
-    end
-
-    before do
-      expect(loader).to receive(:find_files_latest_gems).with("chef/knife/*.rb").and_return(all_found_commands)
-      expect(loader).to receive(:find_subcommands_via_dirglob).and_return({})
-    end
-
-    it "ignores commands from the non-matching gem install" do
-      expect(loader.find_subcommands_via_rubygems.values).to eq(expected_valid_commands)
-    end
-
-  end
-
-  describe "finding 3rd party plugins" do
-    let(:env_home) { "/home/alice" }
-    let(:manifest_path) { env_home + "/.chef/plugin_manifest.json" }
-
-    before do
-      env_dup = ENV.to_hash
-      allow(ENV).to receive(:[]) { |key| env_dup[key] }
-      allow(ENV).to receive(:[]).with("HOME").and_return(env_home)
-    end
-
-    it "searches rubygems for plugins" do
-      if Gem::Specification.respond_to?(:latest_specs)
-        expect(Gem::Specification).to receive(:latest_specs).and_call_original
-      else
-        expect(Gem.source_index).to receive(:latest_specs).and_call_original
-      end
-      loader.subcommand_files.each do |require_path|
-        expect(require_path).to match(%r{chef/knife/.*|plugins/knife/.*})
-      end
-    end
-
-    context "and HOME environment variable is not set" do
-      before do
-        allow(ENV).to receive(:[]).with("HOME").and_return(nil)
-      end
-
-      it "searches rubygems for plugins" do
-        if Gem::Specification.respond_to?(:latest_specs)
-          expect(Gem::Specification).to receive(:latest_specs).and_call_original
-        else
-          expect(Gem.source_index).to receive(:latest_specs).and_call_original
-        end
-        loader.subcommand_files.each do |require_path|
-          expect(require_path).to match(%r{chef/knife/.*|plugins/knife/.*})
-        end
-      end
-    end
-  end
-end

data/spec/unit/knife/core/hashed_command_loader_spec.rb

@@ -1,112 +0,0 @@
-#
-# Copyright:: Copyright (c) Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require "spec_helper"
-
-describe Chef::Knife::SubcommandLoader::HashedCommandLoader do
-  before do
-    allow(ChefUtils).to receive(:windows?) { false }
-  end
-
-  let(:plugin_manifest) do
-    {
-      "_autogenerated_command_paths" => {
-        "plugins_paths" => {
-          "cool_a" => ["/file/for/plugin/a"],
-          "cooler_b" => ["/file/for/plugin/b"],
-        },
-        "plugins_by_category" => {
-          "cool" => [
-            "cool_a",
-          ],
-          "cooler" => [
-            "cooler_b",
-          ],
-        },
-      },
-    }
-  end
-
-  let(:loader) do
-    Chef::Knife::SubcommandLoader::HashedCommandLoader.new(
-      File.join(CHEF_SPEC_DATA, "knife-site-subcommands"),
-      plugin_manifest
-    )
-  end
-
-  describe "#list_commands" do
-    before do
-      allow(File).to receive(:exist?).and_return(true)
-    end
-
-    it "lists all commands by category when no argument is given" do
-      expect(loader.list_commands).to eq({ "cool" => ["cool_a"], "cooler" => ["cooler_b"] })
-    end
-
-    it "lists only commands in the given category when a category is given" do
-      expect(loader.list_commands("cool")).to eq({ "cool" => ["cool_a"] })
-    end
-
-    context "when the plugin path is invalid" do
-      before do
-        expect(File).to receive(:exist?).with("/file/for/plugin/b").and_return(false)
-      end
-
-      it "lists all commands by category when no argument is given" do
-        expect(Chef::Log).to receive(:error).with(/There are plugin files specified in the knife cache that cannot be found/)
-        expect(Chef::Log).to receive(:error).with("Missing files:\n\t/file/for/plugin/b")
-        expect(loader.list_commands).to eq({})
-      end
-    end
-  end
-
-  describe "#subcommand_files" do
-    it "lists all the files" do
-      expect(loader.subcommand_files).to eq(["/file/for/plugin/a", "/file/for/plugin/b"])
-    end
-  end
-
-  describe "#load_commands" do
-    before do
-      allow(Kernel).to receive(:load).and_return(true)
-    end
-
-    it "returns false for non-existant commands" do
-      expect(loader.load_command(["nothere"])).to eq(false)
-    end
-
-    it "loads the correct file and returns true if the command exists" do
-      allow(File).to receive(:exist?).and_return(true)
-      expect(Kernel).to receive(:load).with("/file/for/plugin/a").and_return(true)
-      expect(loader.load_command(["cool_a"])).to eq(true)
-    end
-  end
-
-  describe "#subcommand_for_args" do
-    it "returns the subcommands for an exact match" do
-      expect(loader.subcommand_for_args(["cooler_b"])).to eq("cooler_b")
-    end
-
-    it "finds the right subcommand even when _'s are elided" do
-      expect(loader.subcommand_for_args(%w{cooler b})).to eq("cooler_b")
-    end
-
-    it "returns nil if the the subcommand isn't in our manifest" do
-      expect(loader.subcommand_for_args(["cooler c"])).to eq(nil)
-    end
-  end
-end