chef 16.1.16 → 16.18.30

Sign up to get free protection for your applications and to get access to all the features.
Files changed (822) hide show
  1. checksums.yaml +4 -4
  2. data/Gemfile +32 -27
  3. data/README.md +5 -5
  4. data/Rakefile +35 -30
  5. data/bin/knife +1 -1
  6. data/chef-universal-mingw32.gemspec +5 -5
  7. data/chef.gemspec +32 -10
  8. data/lib/chef/action_collection.rb +5 -1
  9. data/lib/chef/api_client/registration.rb +2 -2
  10. data/lib/chef/application/apply.rb +19 -13
  11. data/lib/chef/application/base.rb +27 -24
  12. data/lib/chef/application/client.rb +17 -6
  13. data/lib/chef/application/exit_code.rb +13 -4
  14. data/lib/chef/application/knife.rb +22 -11
  15. data/lib/chef/application/solo.rb +2 -1
  16. data/lib/chef/application/windows_service.rb +39 -39
  17. data/lib/chef/application/windows_service_manager.rb +7 -7
  18. data/lib/chef/application.rb +33 -19
  19. data/lib/chef/{whitelist.rb → attribute_allowlist.rb} +11 -11
  20. data/lib/chef/{blacklist.rb → attribute_blocklist.rb} +9 -9
  21. data/lib/chef/chef_class.rb +0 -1
  22. data/lib/chef/chef_fs/chef_fs_data_store.rb +55 -55
  23. data/lib/chef/chef_fs/data_handler/cookbook_data_handler.rb +1 -1
  24. data/lib/chef/chef_fs/data_handler/data_bag_item_data_handler.rb +1 -1
  25. data/lib/chef/chef_fs/data_handler/organization_data_handler.rb +1 -2
  26. data/lib/chef/chef_fs/file_pattern.rb +1 -1
  27. data/lib/chef/chef_fs/file_system/chef_server/acl_entry.rb +10 -10
  28. data/lib/chef/chef_fs/file_system/chef_server/cookbook_file.rb +2 -2
  29. data/lib/chef/chef_fs/file_system/chef_server/cookbooks_dir.rb +1 -5
  30. data/lib/chef/chef_fs/file_system/chef_server/organization_invites_entry.rb +8 -8
  31. data/lib/chef/chef_fs/file_system/chef_server/organization_members_entry.rb +8 -8
  32. data/lib/chef/chef_fs/file_system/repository/base_file.rb +1 -0
  33. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_cookbook_dir.rb +2 -2
  34. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_cookbook_entry.rb +2 -2
  35. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_root_dir.rb +18 -18
  36. data/lib/chef/chef_fs/file_system/repository/directory.rb +1 -1
  37. data/lib/chef/chef_fs/file_system/repository/file_system_entry.rb +1 -1
  38. data/lib/chef/chef_fs/knife.rb +2 -2
  39. data/lib/chef/chef_fs/parallelizer/parallel_enumerable.rb +1 -1
  40. data/lib/chef/chef_fs/parallelizer.rb +0 -1
  41. data/lib/chef/chef_fs/path_utils.rb +1 -1
  42. data/lib/chef/client.rb +32 -59
  43. data/lib/chef/compliance/default_attributes.rb +97 -0
  44. data/lib/chef/compliance/fetcher/automate.rb +80 -0
  45. data/lib/chef/compliance/fetcher/chef_server.rb +134 -0
  46. data/lib/chef/compliance/reporter/automate.rb +201 -0
  47. data/lib/chef/compliance/reporter/chef_server_automate.rb +94 -0
  48. data/lib/chef/compliance/reporter/compliance_enforcer.rb +20 -0
  49. data/lib/chef/compliance/reporter/json_file.rb +19 -0
  50. data/lib/chef/compliance/runner.rb +269 -0
  51. data/lib/chef/cookbook/chefignore.rb +1 -1
  52. data/lib/chef/cookbook/cookbook_version_loader.rb +1 -1
  53. data/lib/chef/cookbook/gem_installer.rb +6 -2
  54. data/lib/chef/cookbook/metadata.rb +1 -1
  55. data/lib/chef/cookbook/remote_file_vendor.rb +1 -3
  56. data/lib/chef/cookbook/synchronizer.rb +2 -2
  57. data/lib/chef/cookbook/syntax_check.rb +1 -2
  58. data/lib/chef/cookbook_loader.rb +15 -29
  59. data/lib/chef/cookbook_manifest.rb +2 -1
  60. data/lib/chef/cookbook_site_streaming_uploader.rb +13 -11
  61. data/lib/chef/cookbook_uploader.rb +1 -1
  62. data/lib/chef/cookbook_version.rb +30 -11
  63. data/lib/chef/data_bag.rb +5 -6
  64. data/lib/chef/data_collector/config_validation.rb +22 -13
  65. data/lib/chef/data_collector/run_end_message.rb +15 -5
  66. data/lib/chef/data_collector/run_start_message.rb +1 -1
  67. data/lib/chef/data_collector.rb +7 -6
  68. data/lib/chef/deprecated.rb +27 -5
  69. data/lib/chef/deprecation/warnings.rb +2 -2
  70. data/lib/chef/digester.rb +4 -3
  71. data/lib/chef/dsl/chef_vault.rb +1 -1
  72. data/lib/chef/dsl/data_query.rb +2 -2
  73. data/lib/chef/dsl/platform_introspection.rb +10 -8
  74. data/lib/chef/dsl/reboot_pending.rb +1 -1
  75. data/lib/chef/encrypted_data_bag_item/assertions.rb +1 -1
  76. data/lib/chef/encrypted_data_bag_item/decryptor.rb +3 -3
  77. data/lib/chef/encrypted_data_bag_item/encryptor.rb +3 -3
  78. data/lib/chef/encrypted_data_bag_item.rb +3 -4
  79. data/lib/chef/environment.rb +6 -7
  80. data/lib/chef/event_loggers/windows_eventlog.rb +2 -2
  81. data/lib/chef/exceptions.rb +16 -6
  82. data/lib/chef/file_access_control/windows.rb +12 -11
  83. data/lib/chef/file_access_control.rb +1 -1
  84. data/lib/chef/file_cache.rb +4 -4
  85. data/lib/chef/file_content_management/deploy/mv_unix.rb +1 -1
  86. data/lib/chef/file_content_management/tempfile.rb +10 -10
  87. data/lib/chef/formatters/doc.rb +7 -6
  88. data/lib/chef/formatters/error_inspectors/api_error_formatting.rb +6 -5
  89. data/lib/chef/formatters/error_inspectors/compile_error_inspector.rb +3 -3
  90. data/lib/chef/formatters/error_inspectors/node_load_error_inspector.rb +3 -3
  91. data/lib/chef/formatters/error_inspectors/registration_error_inspector.rb +9 -9
  92. data/lib/chef/formatters/error_inspectors/resource_failure_inspector.rb +8 -8
  93. data/lib/chef/formatters/error_inspectors/run_list_expansion_error_inspector.rb +3 -3
  94. data/lib/chef/formatters/error_mapper.rb +2 -2
  95. data/lib/chef/formatters/indentable_output_stream.rb +2 -2
  96. data/lib/chef/formatters/minimal.rb +5 -4
  97. data/lib/chef/guard_interpreter/resource_guard_interpreter.rb +28 -39
  98. data/lib/chef/handler/json_file.rb +1 -1
  99. data/lib/chef/handler.rb +2 -0
  100. data/lib/chef/http/auth_credentials.rb +5 -1
  101. data/lib/chef/http/authenticator.rb +4 -2
  102. data/lib/chef/http/basic_client.rb +4 -2
  103. data/lib/chef/http/decompressor.rb +1 -1
  104. data/lib/chef/http/http_request.rb +8 -6
  105. data/lib/chef/http/json_output.rb +1 -1
  106. data/lib/chef/http/socketless_chef_zero_client.rb +5 -2
  107. data/lib/chef/http/ssl_policies.rb +52 -15
  108. data/lib/chef/http.rb +38 -31
  109. data/lib/chef/json_compat.rb +4 -9
  110. data/lib/chef/key.rb +1 -1
  111. data/lib/chef/knife/bootstrap/chef_vault_handler.rb +1 -1
  112. data/lib/chef/knife/bootstrap/templates/chef-full.erb +12 -12
  113. data/lib/chef/knife/bootstrap/templates/windows-chef-client-msi.erb +9 -9
  114. data/lib/chef/knife/bootstrap/train_connector.rb +2 -1
  115. data/lib/chef/knife/bootstrap.rb +93 -40
  116. data/lib/chef/knife/client_bulk_delete.rb +1 -1
  117. data/lib/chef/knife/client_create.rb +3 -3
  118. data/lib/chef/knife/config_get.rb +8 -96
  119. data/lib/chef/knife/config_get_profile.rb +9 -9
  120. data/lib/chef/knife/config_list.rb +139 -0
  121. data/lib/chef/knife/config_list_profiles.rb +8 -95
  122. data/lib/chef/knife/config_show.rb +127 -0
  123. data/lib/chef/knife/config_use.rb +61 -0
  124. data/lib/chef/knife/config_use_profile.rb +12 -17
  125. data/lib/chef/knife/configure.rb +5 -3
  126. data/lib/chef/knife/cookbook_delete.rb +1 -1
  127. data/lib/chef/knife/cookbook_download.rb +1 -1
  128. data/lib/chef/knife/cookbook_metadata.rb +1 -1
  129. data/lib/chef/knife/cookbook_upload.rb +29 -37
  130. data/lib/chef/knife/core/bootstrap_context.rb +3 -3
  131. data/lib/chef/knife/core/cookbook_scm_repo.rb +2 -2
  132. data/lib/chef/knife/core/formatting_options.rb +49 -0
  133. data/lib/chef/knife/core/gem_glob_loader.rb +2 -2
  134. data/lib/chef/knife/core/generic_presenter.rb +1 -1
  135. data/lib/chef/knife/core/hashed_command_loader.rb +3 -2
  136. data/lib/chef/knife/core/node_presenter.rb +0 -25
  137. data/lib/chef/knife/core/object_loader.rb +1 -1
  138. data/lib/chef/knife/core/status_presenter.rb +1 -26
  139. data/lib/chef/knife/core/subcommand_loader.rb +20 -1
  140. data/lib/chef/knife/core/ui.rb +12 -3
  141. data/lib/chef/knife/core/windows_bootstrap_context.rb +51 -42
  142. data/lib/chef/knife/data_bag_create.rb +1 -1
  143. data/lib/chef/knife/delete.rb +15 -15
  144. data/lib/chef/knife/exec.rb +4 -4
  145. data/lib/chef/knife/node_bulk_delete.rb +1 -1
  146. data/lib/chef/knife/node_policy_set.rb +2 -2
  147. data/lib/chef/knife/node_run_list_add.rb +1 -1
  148. data/lib/chef/knife/node_run_list_remove.rb +2 -2
  149. data/lib/chef/knife/node_run_list_set.rb +1 -1
  150. data/lib/chef/knife/node_show.rb +4 -3
  151. data/lib/chef/knife/rehash.rb +3 -21
  152. data/lib/chef/knife/role_bulk_delete.rb +1 -1
  153. data/lib/chef/knife/role_env_run_list_add.rb +1 -1
  154. data/lib/chef/knife/role_env_run_list_set.rb +1 -1
  155. data/lib/chef/knife/role_run_list_add.rb +1 -1
  156. data/lib/chef/knife/role_run_list_set.rb +1 -1
  157. data/lib/chef/knife/search.rb +2 -2
  158. data/lib/chef/knife/serve.rb +3 -3
  159. data/lib/chef/knife/ssh.rb +33 -12
  160. data/lib/chef/knife/ssl_check.rb +3 -3
  161. data/lib/chef/knife/status.rb +10 -13
  162. data/lib/chef/knife/supermarket_share.rb +1 -1
  163. data/lib/chef/knife/supermarket_unshare.rb +1 -1
  164. data/lib/chef/knife/tag_create.rb +1 -1
  165. data/lib/chef/knife/tag_delete.rb +1 -1
  166. data/lib/chef/knife/user_create.rb +2 -2
  167. data/lib/chef/knife/xargs.rb +19 -19
  168. data/lib/chef/knife/yaml_convert.rb +1 -1
  169. data/lib/chef/knife.rb +9 -9
  170. data/lib/chef/local_mode.rb +2 -2
  171. data/lib/chef/log/syslog.rb +2 -2
  172. data/lib/chef/log/winevt.rb +2 -2
  173. data/lib/chef/log.rb +8 -3
  174. data/lib/chef/mixin/checksum.rb +5 -0
  175. data/{spec/functional/resource/base.rb → lib/chef/mixin/chef_utils_wiring.rb} +24 -12
  176. data/lib/chef/mixin/convert_to_class_name.rb +0 -56
  177. data/lib/chef/mixin/deep_merge.rb +35 -18
  178. data/{spec/unit/monkey_patches/uri_spec.rb → lib/chef/mixin/default_paths.rb} +11 -13
  179. data/lib/chef/mixin/openssl_helper.rb +32 -11
  180. data/lib/chef/mixin/path_sanity.rb +5 -4
  181. data/lib/chef/mixin/powershell_exec.rb +17 -22
  182. data/lib/chef/mixin/powershell_out.rb +12 -5
  183. data/lib/chef/mixin/properties.rb +2 -0
  184. data/lib/chef/mixin/securable.rb +2 -2
  185. data/lib/chef/mixin/shell_out.rb +4 -188
  186. data/lib/chef/mixin/template.rb +4 -3
  187. data/lib/chef/mixin/unformatter.rb +1 -1
  188. data/lib/chef/mixin/uris.rb +4 -2
  189. data/lib/chef/mixin/versioned_api.rb +1 -2
  190. data/lib/chef/mixin/which.rb +6 -3
  191. data/lib/chef/mixins.rb +1 -0
  192. data/lib/chef/monkey_patches/webrick-utils.rb +10 -10
  193. data/lib/chef/node/attribute.rb +22 -7
  194. data/lib/chef/node/attribute_collections.rb +2 -6
  195. data/lib/chef/node/mixin/deep_merge_cache.rb +4 -4
  196. data/lib/chef/node/mixin/immutablize_hash.rb +2 -0
  197. data/lib/chef/node.rb +43 -18
  198. data/lib/chef/node_map.rb +21 -18
  199. data/lib/chef/platform/query_helpers.rb +4 -4
  200. data/lib/chef/platform/service_helpers.rb +31 -28
  201. data/lib/chef/policy_builder/dynamic.rb +2 -0
  202. data/lib/chef/policy_builder/policyfile.rb +8 -3
  203. data/lib/chef/powershell.rb +10 -4
  204. data/lib/chef/property.rb +2 -2
  205. data/lib/chef/provider/batch.rb +3 -10
  206. data/lib/chef/provider/cron/unix.rb +0 -2
  207. data/lib/chef/provider/cron.rb +9 -28
  208. data/lib/chef/provider/dsc_resource.rb +12 -24
  209. data/lib/chef/provider/dsc_script.rb +16 -20
  210. data/lib/chef/provider/execute.rb +2 -1
  211. data/lib/chef/provider/file.rb +5 -5
  212. data/lib/chef/provider/git.rb +22 -14
  213. data/lib/chef/provider/group/dscl.rb +3 -3
  214. data/lib/chef/provider/group/suse.rb +5 -5
  215. data/lib/chef/provider/group/windows.rb +13 -2
  216. data/lib/chef/provider/group.rb +14 -8
  217. data/lib/chef/provider/ifconfig/debian.rb +38 -22
  218. data/lib/chef/provider/ifconfig/redhat.rb +54 -18
  219. data/lib/chef/provider/ifconfig.rb +16 -19
  220. data/lib/chef/provider/launchd.rb +3 -13
  221. data/lib/chef/provider/link.rb +0 -9
  222. data/lib/chef/provider/mount/aix.rb +1 -1
  223. data/lib/chef/provider/mount/linux.rb +67 -0
  224. data/lib/chef/provider/mount/mount.rb +41 -43
  225. data/lib/chef/provider/mount/solaris.rb +0 -1
  226. data/lib/chef/provider/mount/windows.rb +2 -2
  227. data/lib/chef/provider/mount.rb +23 -3
  228. data/lib/chef/provider/noop.rb +1 -1
  229. data/lib/chef/provider/package/apt.rb +1 -1
  230. data/lib/chef/provider/package/chocolatey.rb +6 -6
  231. data/lib/chef/provider/package/dnf/dnf_helper.py +23 -6
  232. data/lib/chef/provider/package/dnf/python_helper.rb +6 -6
  233. data/lib/chef/provider/package/dnf.rb +39 -12
  234. data/lib/chef/provider/package/dpkg.rb +3 -12
  235. data/lib/chef/provider/package/freebsd/base.rb +3 -2
  236. data/lib/chef/provider/package/freebsd/pkgng.rb +4 -2
  237. data/lib/chef/provider/package/homebrew.rb +1 -1
  238. data/lib/chef/provider/package/ips.rb +1 -1
  239. data/lib/chef/provider/package/openbsd.rb +1 -1
  240. data/lib/chef/provider/package/portage.rb +2 -2
  241. data/lib/chef/provider/package/powershell.rb +10 -2
  242. data/lib/chef/provider/package/rubygems.rb +25 -22
  243. data/lib/chef/provider/package/snap.rb +99 -34
  244. data/lib/chef/provider/package/solaris.rb +0 -2
  245. data/lib/chef/provider/package/windows/msi.rb +3 -3
  246. data/lib/chef/provider/package/windows/registry_uninstall_entry.rb +12 -10
  247. data/lib/chef/provider/package/windows.rb +12 -7
  248. data/lib/chef/provider/package/yum/rpm_utils.rb +1 -1
  249. data/lib/chef/provider/package/yum/yum_helper.py +4 -10
  250. data/lib/chef/provider/package/zypper.rb +99 -73
  251. data/lib/chef/provider/package.rb +53 -18
  252. data/lib/chef/provider/powershell_script.rb +40 -17
  253. data/lib/chef/provider/registry_key.rb +4 -3
  254. data/lib/chef/provider/remote_file/content.rb +3 -0
  255. data/lib/chef/provider/remote_file/ftp.rb +6 -4
  256. data/lib/chef/provider/remote_file/http.rb +4 -1
  257. data/lib/chef/provider/remote_file/sftp.rb +6 -4
  258. data/lib/chef/provider/route.rb +4 -8
  259. data/lib/chef/provider/script.rb +4 -75
  260. data/lib/chef/provider/service/arch.rb +2 -2
  261. data/lib/chef/provider/service/debian.rb +5 -4
  262. data/lib/chef/provider/service/gentoo.rb +2 -2
  263. data/lib/chef/provider/service/macosx.rb +7 -7
  264. data/lib/chef/provider/service/openbsd.rb +5 -8
  265. data/lib/chef/provider/service/redhat.rb +4 -4
  266. data/lib/chef/provider/service/upstart.rb +1 -1
  267. data/lib/chef/provider/service/windows.rb +11 -11
  268. data/lib/chef/provider/service.rb +2 -2
  269. data/lib/chef/provider/subversion.rb +2 -2
  270. data/lib/chef/provider/systemd_unit.rb +0 -2
  271. data/lib/chef/provider/template/content.rb +2 -1
  272. data/lib/chef/provider/template_finder.rb +2 -10
  273. data/lib/chef/provider/user/aix.rb +1 -1
  274. data/lib/chef/provider/user/dscl.rb +10 -10
  275. data/lib/chef/provider/user/linux.rb +3 -3
  276. data/lib/chef/provider/user/mac.rb +29 -21
  277. data/lib/chef/provider/user/solaris.rb +1 -1
  278. data/lib/chef/provider/user/windows.rb +10 -3
  279. data/lib/chef/provider/user.rb +17 -9
  280. data/lib/chef/provider/windows_script.rb +87 -25
  281. data/lib/chef/provider/yum_repository.rb +3 -3
  282. data/lib/chef/provider/zypper_repository.rb +33 -14
  283. data/lib/chef/provider.rb +1 -5
  284. data/lib/chef/provider_resolver.rb +1 -1
  285. data/lib/chef/providers.rb +1 -4
  286. data/lib/chef/pwsh.rb +71 -0
  287. data/lib/chef/recipe.rb +2 -2
  288. data/lib/chef/resource/alternatives.rb +1 -1
  289. data/lib/chef/resource/apt_package.rb +1 -1
  290. data/lib/chef/resource/apt_repository.rb +7 -15
  291. data/lib/chef/resource/archive_file.rb +28 -8
  292. data/lib/chef/resource/bash.rb +119 -2
  293. data/lib/chef/resource/batch.rb +5 -3
  294. data/lib/chef/resource/bff_package.rb +22 -0
  295. data/lib/chef/resource/breakpoint.rb +59 -2
  296. data/lib/chef/resource/build_essential.rb +7 -10
  297. data/lib/chef/resource/cab_package.rb +29 -0
  298. data/lib/chef/resource/chef_client_config.rb +313 -0
  299. data/lib/chef/resource/chef_client_cron.rb +36 -29
  300. data/lib/chef/resource/chef_client_launchd.rb +194 -0
  301. data/lib/chef/resource/chef_client_scheduled_task.rb +36 -21
  302. data/lib/chef/resource/chef_client_systemd_timer.rb +29 -22
  303. data/lib/chef/resource/chef_client_trusted_certificate.rb +102 -0
  304. data/lib/chef/resource/chef_gem.rb +58 -22
  305. data/lib/chef/resource/chef_handler.rb +149 -4
  306. data/lib/chef/resource/chef_sleep.rb +3 -3
  307. data/lib/chef/resource/chef_vault_secret.rb +14 -14
  308. data/lib/chef/resource/chocolatey_feature.rb +1 -2
  309. data/lib/chef/resource/cookbook_file.rb +2 -2
  310. data/lib/chef/resource/cron/_cron_shared.rb +99 -0
  311. data/lib/chef/resource/cron/cron.rb +46 -0
  312. data/lib/chef/resource/{cron_d.rb → cron/cron_d.rb} +9 -89
  313. data/lib/chef/resource/cron_access.rb +13 -5
  314. data/lib/chef/resource/csh.rb +2 -3
  315. data/lib/chef/resource/dmg_package.rb +2 -2
  316. data/lib/chef/resource/dnf_package.rb +2 -2
  317. data/lib/chef/resource/dsc_resource.rb +0 -1
  318. data/lib/chef/resource/dsc_script.rb +9 -2
  319. data/lib/chef/resource/execute.rb +486 -15
  320. data/lib/chef/resource/file.rb +5 -5
  321. data/lib/chef/resource/freebsd_package.rb +1 -1
  322. data/lib/chef/resource/gem_package.rb +36 -3
  323. data/lib/chef/resource/helpers/cron_validations.rb +6 -3
  324. data/lib/chef/resource/homebrew_cask.rb +16 -10
  325. data/lib/chef/resource/homebrew_package.rb +32 -3
  326. data/lib/chef/resource/homebrew_update.rb +110 -0
  327. data/lib/chef/resource/hostname.rb +27 -40
  328. data/lib/chef/resource/http_request.rb +1 -1
  329. data/lib/chef/resource/ifconfig.rb +52 -5
  330. data/lib/chef/resource/kernel_module.rb +15 -2
  331. data/lib/chef/resource/ksh.rb +3 -3
  332. data/lib/chef/resource/launchd.rb +18 -17
  333. data/lib/chef/resource/locale.rb +4 -4
  334. data/lib/chef/resource/lwrp_base.rb +4 -5
  335. data/lib/chef/resource/macos_userdefaults.rb +176 -61
  336. data/lib/chef/resource/mdadm.rb +2 -2
  337. data/lib/chef/resource/mount.rb +9 -3
  338. data/lib/chef/resource/notify_group.rb +0 -1
  339. data/lib/chef/resource/ohai.rb +46 -3
  340. data/lib/chef/resource/ohai_hint.rb +33 -0
  341. data/lib/chef/resource/openssl_dhparam.rb +29 -5
  342. data/lib/chef/resource/openssl_ec_private_key.rb +8 -3
  343. data/lib/chef/resource/openssl_ec_public_key.rb +4 -2
  344. data/lib/chef/resource/openssl_rsa_private_key.rb +8 -3
  345. data/lib/chef/resource/openssl_rsa_public_key.rb +2 -0
  346. data/lib/chef/resource/openssl_x509_certificate.rb +49 -49
  347. data/lib/chef/resource/openssl_x509_crl.rb +22 -12
  348. data/lib/chef/resource/openssl_x509_request.rb +37 -36
  349. data/lib/chef/resource/osx_profile.rb +292 -6
  350. data/lib/chef/resource/perl.rb +2 -3
  351. data/lib/chef/resource/plist.rb +26 -11
  352. data/lib/chef/resource/powershell_package_source.rb +25 -24
  353. data/lib/chef/resource/powershell_script.rb +40 -41
  354. data/lib/chef/resource/python.rb +2 -3
  355. data/lib/chef/resource/reboot.rb +2 -2
  356. data/lib/chef/resource/registry_key.rb +93 -2
  357. data/lib/chef/resource/remote_directory.rb +1 -1
  358. data/lib/chef/resource/remote_file.rb +26 -10
  359. data/lib/chef/resource/rhsm_register.rb +39 -10
  360. data/lib/chef/resource/rhsm_subscription.rb +5 -5
  361. data/lib/chef/resource/route.rb +1 -1
  362. data/lib/chef/resource/ruby.rb +1 -6
  363. data/lib/chef/resource/ruby_block.rb +2 -2
  364. data/lib/chef/resource/scm/_scm.rb +2 -1
  365. data/lib/chef/resource/scm/git.rb +82 -1
  366. data/lib/chef/resource/scm/subversion.rb +14 -2
  367. data/lib/chef/resource/script.rb +2 -2
  368. data/lib/chef/resource/service.rb +5 -5
  369. data/lib/chef/resource/solaris_package.rb +0 -2
  370. data/lib/chef/resource/ssh_known_hosts_entry.rb +18 -3
  371. data/lib/chef/resource/sudo.rb +32 -5
  372. data/lib/chef/resource/support/client.erb +68 -0
  373. data/lib/chef/resource/support/cron.d.erb +1 -1
  374. data/lib/chef/resource/support/cron_access.erb +1 -1
  375. data/lib/chef/resource/support/sudoer.erb +1 -1
  376. data/lib/chef/resource/support/ulimit.erb +1 -1
  377. data/lib/chef/resource/swap_file.rb +17 -0
  378. data/lib/chef/resource/sysctl.rb +6 -10
  379. data/lib/chef/resource/systemd_unit.rb +45 -4
  380. data/lib/chef/resource/template.rb +4 -4
  381. data/lib/chef/resource/timezone.rb +122 -68
  382. data/lib/chef/resource/user/windows_user.rb +5 -0
  383. data/lib/chef/resource/user_ulimit.rb +2 -1
  384. data/lib/chef/resource/windows_ad_join.rb +51 -13
  385. data/lib/chef/resource/windows_audit_policy.rb +232 -0
  386. data/lib/chef/resource/windows_auto_run.rb +13 -0
  387. data/lib/chef/resource/windows_certificate.rb +95 -39
  388. data/lib/chef/resource/windows_dfs_folder.rb +2 -0
  389. data/lib/chef/resource/windows_dfs_namespace.rb +2 -0
  390. data/lib/chef/resource/windows_dfs_server.rb +9 -4
  391. data/lib/chef/resource/windows_dns_record.rb +25 -5
  392. data/lib/chef/resource/windows_dns_zone.rb +12 -7
  393. data/lib/chef/resource/windows_env.rb +173 -0
  394. data/lib/chef/resource/windows_feature.rb +4 -0
  395. data/lib/chef/resource/windows_feature_dism.rb +10 -0
  396. data/lib/chef/resource/windows_feature_powershell.rb +14 -2
  397. data/lib/chef/resource/windows_firewall_profile.rb +196 -0
  398. data/lib/chef/resource/windows_firewall_rule.rb +14 -14
  399. data/lib/chef/resource/windows_font.rb +7 -5
  400. data/lib/chef/resource/windows_package.rb +30 -6
  401. data/lib/chef/resource/windows_pagefile.rb +5 -1
  402. data/lib/chef/resource/windows_path.rb +38 -0
  403. data/lib/chef/resource/windows_printer.rb +22 -21
  404. data/lib/chef/resource/windows_printer_port.rb +20 -17
  405. data/lib/chef/resource/windows_script.rb +2 -16
  406. data/lib/chef/resource/windows_security_policy.rb +98 -49
  407. data/lib/chef/resource/windows_service.rb +108 -0
  408. data/lib/chef/resource/windows_share.rb +23 -21
  409. data/lib/chef/resource/windows_shortcut.rb +3 -2
  410. data/lib/chef/resource/windows_task.rb +633 -32
  411. data/lib/chef/resource/windows_uac.rb +5 -1
  412. data/lib/chef/resource/windows_user_privilege.rb +111 -77
  413. data/lib/chef/resource/windows_workgroup.rb +11 -10
  414. data/lib/chef/resource/yum_package.rb +2 -2
  415. data/lib/chef/resource/yum_repository.rb +15 -10
  416. data/lib/chef/resource.rb +60 -27
  417. data/lib/chef/resource_collection/resource_set.rb +2 -6
  418. data/lib/chef/resource_collection/stepable_iterator.rb +1 -2
  419. data/lib/chef/resource_inspector.rb +82 -70
  420. data/lib/chef/resource_reporter.rb +1 -3
  421. data/lib/chef/resources.rb +9 -3
  422. data/lib/chef/role.rb +3 -4
  423. data/lib/chef/run_context/cookbook_compiler.rb +21 -21
  424. data/lib/chef/run_context.rb +2 -2
  425. data/lib/chef/run_lock.rb +3 -3
  426. data/lib/chef/run_status.rb +2 -6
  427. data/lib/chef/search/query.rb +7 -6
  428. data/lib/chef/server_api.rb +0 -4
  429. data/lib/chef/server_api_versions.rb +4 -0
  430. data/lib/chef/shell/ext.rb +15 -15
  431. data/lib/chef/shell/shell_session.rb +4 -2
  432. data/lib/chef/shell.rb +63 -27
  433. data/lib/chef/train_transport.rb +5 -104
  434. data/lib/chef/util/backup.rb +2 -2
  435. data/lib/chef/util/diff.rb +16 -17
  436. data/lib/chef/util/dsc/configuration_generator.rb +53 -12
  437. data/lib/chef/util/dsc/lcm_output_parser.rb +4 -7
  438. data/lib/chef/util/dsc/local_configuration_manager.rb +18 -15
  439. data/lib/chef/util/dsc/resource_store.rb +5 -11
  440. data/lib/chef/util/powershell/ps_credential.rb +18 -14
  441. data/lib/chef/util/threaded_job_queue.rb +0 -2
  442. data/lib/chef/util/windows/net_user.rb +1 -1
  443. data/lib/chef/util/windows/volume.rb +1 -1
  444. data/lib/chef/version.rb +2 -2
  445. data/lib/chef/version_string.rb +1 -1
  446. data/lib/chef/win32/api/file.rb +4 -0
  447. data/lib/chef/win32/api.rb +9 -2
  448. data/lib/chef/win32/crypto.rb +1 -1
  449. data/lib/chef/win32/file/version_info.rb +5 -5
  450. data/lib/chef/win32/file.rb +4 -4
  451. data/lib/chef/win32/registry.rb +4 -6
  452. data/lib/chef/win32/security/sid.rb +1 -1
  453. data/lib/chef/win32/security.rb +1 -1
  454. data/lib/chef/win32/unicode.rb +1 -1
  455. data/lib/chef/win32/version.rb +4 -2
  456. data/spec/data/lwrp/providers/buck_passer.rb +1 -1
  457. data/spec/data/lwrp/providers/buck_passer_2.rb +1 -1
  458. data/spec/data/lwrp/providers/embedded_resource_accesses_providers_scope.rb +1 -1
  459. data/spec/data/rubygems.org/latest_specs.4.8.gz +0 -0
  460. data/spec/data/rubygems.org/nonexistent_gem +0 -0
  461. data/spec/data/rubygems.org/sexp_processor +0 -0
  462. data/spec/data/rubygems.org/sexp_processor-4.15.1.gemspec.rz +0 -0
  463. data/spec/data/shef-config.rb +1 -1
  464. data/spec/data/ssl/binary/chef-rspec-der.cert +0 -0
  465. data/spec/data/ssl/binary/chef-rspec-der.key +0 -0
  466. data/spec/data/ssl/chef-rspec.cert +15 -15
  467. data/spec/functional/assets/yumrepo-empty/repodata/01a3b-filelists.sqlite.bz2 +0 -0
  468. data/spec/functional/assets/yumrepo-empty/repodata/401dc-filelists.xml.gz +0 -0
  469. data/spec/functional/assets/yumrepo-empty/repodata/5dc1e-primary.sqlite.bz2 +0 -0
  470. data/spec/functional/assets/yumrepo-empty/repodata/6bf96-other.xml.gz +0 -0
  471. data/spec/functional/assets/yumrepo-empty/repodata/7c365-other.sqlite.bz2 +0 -0
  472. data/spec/functional/assets/yumrepo-empty/repodata/dabe2-primary.xml.gz +0 -0
  473. data/spec/functional/assets/yumrepo-empty/repodata/repomd.xml +55 -0
  474. data/spec/functional/event_loggers/windows_eventlog_spec.rb +6 -5
  475. data/spec/functional/knife/configure_spec.rb +1 -1
  476. data/spec/functional/knife/ssh_spec.rb +5 -16
  477. data/spec/functional/mixin/powershell_out_spec.rb +11 -3
  478. data/spec/functional/resource/aix_service_spec.rb +11 -4
  479. data/spec/functional/resource/aixinit_service_spec.rb +9 -10
  480. data/spec/functional/resource/apt_package_spec.rb +4 -7
  481. data/spec/functional/resource/bash_spec.rb +3 -2
  482. data/spec/functional/resource/bff_spec.rb +3 -3
  483. data/spec/functional/resource/chocolatey_package_spec.rb +11 -3
  484. data/spec/functional/resource/cookbook_file_spec.rb +1 -1
  485. data/spec/functional/resource/cron_spec.rb +24 -6
  486. data/spec/functional/resource/dnf_package_spec.rb +323 -17
  487. data/spec/functional/resource/dsc_resource_spec.rb +1 -1
  488. data/spec/functional/resource/dsc_script_spec.rb +6 -10
  489. data/spec/functional/resource/execute_spec.rb +1 -1
  490. data/spec/functional/resource/git_spec.rb +23 -1
  491. data/spec/functional/resource/group_spec.rb +26 -10
  492. data/spec/functional/resource/ifconfig_spec.rb +9 -1
  493. data/spec/functional/resource/insserv_spec.rb +8 -8
  494. data/spec/functional/resource/link_spec.rb +30 -25
  495. data/spec/functional/resource/mount_spec.rb +19 -3
  496. data/spec/functional/resource/msu_package_spec.rb +9 -3
  497. data/spec/functional/resource/ohai_spec.rb +2 -10
  498. data/spec/functional/resource/powershell_package_source_spec.rb +107 -0
  499. data/spec/functional/resource/powershell_script_spec.rb +65 -22
  500. data/spec/functional/resource/remote_file_spec.rb +9 -15
  501. data/spec/functional/resource/rpm_spec.rb +3 -3
  502. data/spec/functional/resource/timezone_spec.rb +2 -0
  503. data/spec/functional/resource/user/dscl_spec.rb +1 -1
  504. data/spec/functional/resource/user/mac_user_spec.rb +1 -1
  505. data/spec/functional/resource/windows_certificate_spec.rb +206 -382
  506. data/spec/functional/resource/windows_firewall_rule_spec.rb +93 -0
  507. data/spec/functional/resource/windows_font_spec.rb +50 -0
  508. data/spec/functional/resource/windows_package_spec.rb +36 -11
  509. data/spec/functional/resource/windows_path_spec.rb +4 -0
  510. data/spec/functional/resource/windows_security_policy_spec.rb +0 -4
  511. data/spec/functional/resource/windows_service_spec.rb +4 -0
  512. data/spec/functional/resource/windows_share_spec.rb +103 -0
  513. data/spec/functional/resource/windows_task_spec.rb +27 -27
  514. data/spec/functional/resource/windows_user_privilege_spec.rb +1 -2
  515. data/spec/functional/resource/yum_package_spec.rb +16 -1
  516. data/spec/functional/resource/zypper_package_spec.rb +15 -1
  517. data/spec/functional/run_lock_spec.rb +26 -25
  518. data/spec/functional/shell_spec.rb +10 -6
  519. data/spec/functional/version_spec.rb +4 -4
  520. data/spec/functional/win32/crypto_spec.rb +1 -1
  521. data/spec/functional/win32/registry_spec.rb +8 -8
  522. data/spec/functional/win32/service_manager_spec.rb +1 -1
  523. data/spec/integration/client/client_spec.rb +6 -5
  524. data/spec/integration/client/exit_code_spec.rb +3 -2
  525. data/spec/integration/client/fips_spec.rb +21 -0
  526. data/spec/integration/client/ipv6_spec.rb +1 -1
  527. data/spec/integration/compliance/compliance_spec.rb +82 -0
  528. data/spec/integration/knife/client_key_create_spec.rb +1 -1
  529. data/spec/integration/knife/common_options_spec.rb +12 -12
  530. data/spec/integration/knife/config_list_spec.rb +220 -0
  531. data/spec/integration/knife/config_show_spec.rb +192 -0
  532. data/spec/integration/knife/config_use_spec.rb +198 -0
  533. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +1 -1
  534. data/spec/integration/knife/cookbook_upload_spec.rb +28 -1
  535. data/spec/integration/knife/data_bag_from_file_spec.rb +1 -1
  536. data/spec/integration/knife/delete_spec.rb +1 -1
  537. data/spec/integration/knife/diff_spec.rb +3 -1
  538. data/spec/integration/knife/download_spec.rb +5 -3
  539. data/spec/integration/knife/environment_from_file_spec.rb +1 -1
  540. data/spec/integration/knife/node_create_spec.rb +1 -1
  541. data/spec/integration/knife/node_environment_set_spec.rb +1 -1
  542. data/spec/integration/knife/node_from_file_spec.rb +1 -1
  543. data/spec/integration/knife/node_run_list_add_spec.rb +4 -4
  544. data/spec/integration/knife/node_run_list_remove_spec.rb +1 -1
  545. data/spec/integration/knife/node_run_list_set_spec.rb +1 -1
  546. data/spec/integration/knife/node_show_spec.rb +1 -1
  547. data/spec/integration/knife/role_from_file_spec.rb +1 -1
  548. data/spec/integration/knife/serve_spec.rb +5 -5
  549. data/spec/integration/knife/upload_spec.rb +8 -7
  550. data/spec/integration/ohai/ohai_spec.rb +61 -0
  551. data/spec/integration/recipes/accumulator_spec.rb +1 -1
  552. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +2 -2
  553. data/spec/integration/recipes/lwrp_spec.rb +1 -1
  554. data/spec/integration/recipes/notifies_spec.rb +2 -2
  555. data/spec/integration/recipes/notifying_block_spec.rb +1 -1
  556. data/spec/integration/recipes/provider_choice.rb +2 -2
  557. data/spec/integration/recipes/recipe_dsl_spec.rb +6 -1
  558. data/spec/integration/recipes/remote_directory.rb +1 -1
  559. data/spec/integration/recipes/resource_action_spec.rb +14 -0
  560. data/spec/integration/recipes/resource_converge_if_changed_spec.rb +2 -0
  561. data/spec/integration/recipes/resource_load_spec.rb +4 -2
  562. data/spec/integration/recipes/unified_mode_spec.rb +1 -1
  563. data/spec/integration/recipes/use_partial_spec.rb +1 -1
  564. data/spec/integration/solo/solo_spec.rb +5 -5
  565. data/spec/spec_helper.rb +30 -17
  566. data/spec/stress/win32/file_spec.rb +1 -1
  567. data/spec/support/chef_helpers.rb +3 -22
  568. data/spec/support/lib/chef/resource/cat.rb +1 -1
  569. data/spec/support/lib/chef/resource/one_two_three_four.rb +1 -1
  570. data/spec/support/matchers/leak.rb +2 -2
  571. data/spec/support/mock/platform.rb +24 -16
  572. data/spec/support/platform_helpers.rb +36 -41
  573. data/spec/support/platforms/win32/spec_service.rb +2 -2
  574. data/spec/support/shared/functional/directory_resource.rb +1 -1
  575. data/spec/support/shared/functional/execute_resource.rb +2 -2
  576. data/spec/support/shared/functional/file_resource.rb +20 -21
  577. data/spec/support/shared/functional/securable_resource.rb +109 -29
  578. data/spec/support/shared/functional/securable_resource_with_reporting.rb +0 -1
  579. data/spec/support/shared/functional/win32_service.rb +2 -2
  580. data/spec/support/shared/functional/windows_script.rb +5 -5
  581. data/spec/support/shared/integration/integration_helper.rb +22 -52
  582. data/spec/support/shared/integration/knife_support.rb +2 -9
  583. data/spec/support/shared/unit/application_dot_d.rb +5 -4
  584. data/spec/support/shared/unit/execute_resource.rb +1 -1
  585. data/spec/support/shared/unit/knife_shared.rb +1 -1
  586. data/spec/support/shared/unit/provider/file.rb +26 -8
  587. data/spec/support/shared/unit/script_resource.rb +10 -24
  588. data/spec/support/shared/unit/windows_script_resource.rb +16 -29
  589. data/spec/tiny_server.rb +0 -1
  590. data/spec/unit/application/client_spec.rb +2 -2
  591. data/spec/unit/application/exit_code_spec.rb +10 -0
  592. data/spec/unit/application/solo_spec.rb +4 -2
  593. data/spec/unit/application_spec.rb +15 -8
  594. data/spec/unit/chef_fs/config_spec.rb +3 -3
  595. data/spec/unit/chef_fs/data_handler/data_bag_item_data_handler.rb +1 -1
  596. data/spec/unit/chef_fs/diff_spec.rb +8 -8
  597. data/spec/unit/chef_fs/file_system/operation_failed_error_spec.rb +2 -4
  598. data/spec/unit/chef_fs/{parallelizer.rb → parallelizer_spec.rb} +6 -2
  599. data/spec/unit/chef_fs/path_util_spec.rb +1 -1
  600. data/spec/unit/client_spec.rb +25 -5
  601. data/spec/unit/compliance/fetcher/automate_spec.rb +142 -0
  602. data/spec/unit/compliance/fetcher/chef_server_spec.rb +93 -0
  603. data/spec/unit/compliance/reporter/automate_spec.rb +427 -0
  604. data/spec/unit/compliance/reporter/chef_server_automate_spec.rb +177 -0
  605. data/spec/unit/compliance/reporter/compliance_enforcer_spec.rb +48 -0
  606. data/spec/unit/compliance/runner_spec.rb +215 -0
  607. data/spec/unit/cookbook/gem_installer_spec.rb +2 -1
  608. data/spec/unit/cookbook/synchronizer_spec.rb +28 -26
  609. data/spec/unit/cookbook_spec.rb +2 -2
  610. data/spec/unit/cookbook_version_spec.rb +52 -0
  611. data/spec/unit/daemon_spec.rb +1 -5
  612. data/spec/unit/data_bag_spec.rb +6 -3
  613. data/spec/unit/data_collector/config_validation_spec.rb +208 -0
  614. data/spec/unit/data_collector_spec.rb +100 -120
  615. data/spec/unit/decorator_spec.rb +23 -23
  616. data/spec/unit/dsl/declare_resource_spec.rb +1 -1
  617. data/spec/unit/dsl/platform_introspection_spec.rb +1 -0
  618. data/spec/unit/dsl/reboot_pending_spec.rb +2 -2
  619. data/spec/unit/environment_spec.rb +12 -8
  620. data/spec/unit/event_dispatch/dispatcher_spec.rb +3 -0
  621. data/spec/unit/file_access_control_spec.rb +1 -1
  622. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +2 -2
  623. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +11 -11
  624. data/spec/unit/guard_interpreter_spec.rb +1 -1
  625. data/spec/unit/http/api_versions_spec.rb +20 -2
  626. data/spec/unit/http/ssl_policies_spec.rb +125 -66
  627. data/spec/unit/json_compat_spec.rb +1 -1
  628. data/spec/unit/knife/bootstrap_spec.rb +69 -45
  629. data/spec/unit/knife/client_create_spec.rb +2 -2
  630. data/spec/unit/knife/configure_client_spec.rb +5 -5
  631. data/spec/unit/knife/configure_spec.rb +3 -3
  632. data/spec/unit/knife/cookbook_delete_spec.rb +2 -2
  633. data/spec/unit/knife/cookbook_download_spec.rb +8 -8
  634. data/spec/unit/knife/cookbook_list_spec.rb +2 -2
  635. data/spec/unit/knife/cookbook_metadata_from_file_spec.rb +1 -1
  636. data/spec/unit/knife/cookbook_metadata_spec.rb +3 -3
  637. data/spec/unit/knife/cookbook_show_spec.rb +6 -7
  638. data/spec/unit/knife/cookbook_upload_spec.rb +7 -10
  639. data/spec/unit/knife/core/hashed_command_loader_spec.rb +3 -3
  640. data/spec/unit/knife/core/node_editor_spec.rb +1 -1
  641. data/spec/unit/knife/core/status_presenter_spec.rb +54 -0
  642. data/spec/unit/knife/core/ui_spec.rb +1 -0
  643. data/spec/unit/knife/core/windows_bootstrap_context_spec.rb +24 -15
  644. data/spec/unit/knife/data_bag_edit_spec.rb +1 -1
  645. data/spec/unit/knife/environment_compare_spec.rb +3 -3
  646. data/spec/unit/knife/ssh_spec.rb +2 -2
  647. data/spec/unit/knife/supermarket_download_spec.rb +8 -8
  648. data/spec/unit/knife/supermarket_list_spec.rb +3 -3
  649. data/spec/unit/knife/supermarket_search_spec.rb +1 -1
  650. data/spec/unit/knife/supermarket_share_spec.rb +6 -7
  651. data/spec/unit/knife/tag_create_spec.rb +1 -1
  652. data/spec/unit/knife/tag_delete_spec.rb +1 -1
  653. data/spec/unit/knife/user_create_spec.rb +1 -1
  654. data/spec/unit/log/syslog_spec.rb +6 -10
  655. data/spec/unit/log/winevt_spec.rb +21 -13
  656. data/spec/unit/lwrp_spec.rb +12 -9
  657. data/spec/unit/mixin/checksum_spec.rb +28 -0
  658. data/spec/unit/mixin/deep_merge_spec.rb +15 -0
  659. data/spec/unit/mixin/{path_sanity_spec.rb → default_paths_spec.rb} +14 -14
  660. data/spec/unit/mixin/openssl_helper_spec.rb +1 -8
  661. data/spec/unit/mixin/powershell_exec_spec.rb +43 -6
  662. data/spec/unit/mixin/powershell_out_spec.rb +16 -4
  663. data/spec/unit/mixin/powershell_type_coercions_spec.rb +1 -1
  664. data/spec/unit/mixin/securable_spec.rb +2 -3
  665. data/spec/unit/mixin/shell_out_spec.rb +25 -26
  666. data/spec/unit/mixin/subclass_directive_spec.rb +2 -2
  667. data/spec/unit/mixin/template_spec.rb +30 -30
  668. data/spec/unit/mixin/unformatter_spec.rb +2 -2
  669. data/spec/unit/mixin/uris_spec.rb +1 -1
  670. data/spec/unit/mixin/user_context_spec.rb +1 -9
  671. data/spec/unit/mixin/which.rb +9 -1
  672. data/spec/unit/mixin/windows_architecture_helper_spec.rb +4 -4
  673. data/spec/unit/node/immutable_collections_spec.rb +8 -4
  674. data/spec/unit/node_spec.rb +103 -16
  675. data/spec/unit/platform/query_helpers_spec.rb +13 -14
  676. data/spec/unit/policy_builder/policyfile_spec.rb +11 -1
  677. data/spec/unit/property_spec.rb +6 -6
  678. data/spec/unit/provider/batch_spec.rb +130 -0
  679. data/spec/unit/provider/cron/unix_spec.rb +1 -1
  680. data/spec/unit/provider/cron_spec.rb +43 -49
  681. data/spec/unit/provider/dsc_resource_spec.rb +30 -63
  682. data/spec/unit/provider/dsc_script_spec.rb +11 -11
  683. data/spec/unit/provider/execute_spec.rb +1 -8
  684. data/spec/unit/provider/git_spec.rb +3 -3
  685. data/spec/unit/provider/group/windows_spec.rb +6 -0
  686. data/spec/unit/provider/group_spec.rb +1 -1
  687. data/spec/unit/provider/ifconfig_spec.rb +0 -1
  688. data/spec/unit/provider/mdadm_spec.rb +1 -3
  689. data/spec/unit/provider/mount/linux_spec.rb +107 -0
  690. data/spec/unit/provider/mount/mount_spec.rb +73 -10
  691. data/spec/unit/provider/mount/solaris_spec.rb +1 -1
  692. data/spec/unit/provider/mount/windows_spec.rb +1 -0
  693. data/spec/unit/provider/mount_spec.rb +31 -0
  694. data/spec/unit/provider/package/chocolatey_spec.rb +2 -3
  695. data/spec/unit/provider/package/dnf/python_helper_spec.rb +8 -2
  696. data/spec/unit/provider/package/freebsd/pkgng_spec.rb +1 -1
  697. data/spec/unit/provider/package/openbsd_spec.rb +1 -1
  698. data/spec/unit/provider/package/pacman_spec.rb +17 -20
  699. data/spec/unit/provider/package/powershell_spec.rb +162 -99
  700. data/spec/unit/provider/package/rubygems_spec.rb +50 -20
  701. data/spec/unit/provider/package/smartos_spec.rb +1 -1
  702. data/spec/unit/provider/package/snap_spec.rb +1 -1
  703. data/spec/unit/provider/package/windows/registry_uninstall_entry_spec.rb +3 -3
  704. data/spec/unit/provider/package/windows_spec.rb +30 -53
  705. data/spec/unit/provider/package/zypper_spec.rb +0 -25
  706. data/spec/unit/provider/package_spec.rb +2 -2
  707. data/spec/unit/provider/powershell_script_spec.rb +20 -44
  708. data/spec/unit/provider/remote_directory_spec.rb +9 -9
  709. data/spec/unit/provider/route_spec.rb +0 -2
  710. data/spec/unit/provider/script_spec.rb +20 -110
  711. data/spec/unit/provider/service/arch_service_spec.rb +3 -2
  712. data/spec/unit/provider/service/debian_service_spec.rb +1 -1
  713. data/spec/unit/provider/service/gentoo_service_spec.rb +7 -7
  714. data/spec/unit/provider/service/macosx_spec.rb +6 -6
  715. data/spec/unit/provider/service/redhat_spec.rb +3 -3
  716. data/spec/unit/provider/service/upstart_service_spec.rb +3 -3
  717. data/spec/unit/provider/service/windows_spec.rb +2 -6
  718. data/spec/unit/provider/subversion_spec.rb +0 -3
  719. data/spec/unit/provider/systemd_unit_spec.rb +29 -25
  720. data/spec/unit/provider/user/dscl_spec.rb +2 -2
  721. data/spec/unit/provider/user_spec.rb +7 -1
  722. data/spec/unit/provider/windows_env_spec.rb +22 -37
  723. data/spec/unit/provider/windows_path_spec.rb +6 -11
  724. data/spec/unit/provider/windows_task_spec.rb +7 -6
  725. data/spec/unit/provider/zypper_repository_spec.rb +60 -10
  726. data/spec/unit/provider_spec.rb +1 -0
  727. data/spec/unit/recipe_spec.rb +1 -1
  728. data/spec/unit/resource/archive_file_spec.rb +23 -2
  729. data/spec/unit/resource/batch_spec.rb +6 -6
  730. data/spec/unit/resource/breakpoint_spec.rb +1 -1
  731. data/spec/unit/resource/build_essential_spec.rb +0 -12
  732. data/spec/unit/resource/chef_client_config_spec.rb +137 -0
  733. data/spec/unit/resource/chef_client_cron_spec.rb +51 -14
  734. data/spec/unit/resource/chef_client_launchd_spec.rb +127 -0
  735. data/spec/unit/resource/chef_client_scheduled_task_spec.rb +17 -7
  736. data/spec/unit/resource/chef_client_systemd_timer_spec.rb +43 -5
  737. data/spec/unit/resource/chef_client_trusted_certificate_spec.rb +68 -0
  738. data/spec/unit/resource/cron_spec.rb +2 -2
  739. data/spec/unit/resource/execute_spec.rb +123 -118
  740. data/spec/unit/resource/file/verification_spec.rb +2 -1
  741. data/spec/unit/resource/helpers/cron_validations_spec.rb +5 -1
  742. data/spec/unit/resource/homebrew_cask_spec.rb +29 -11
  743. data/spec/unit/resource/homebrew_update_spec.rb +30 -0
  744. data/spec/unit/resource/ifconfig_spec.rb +2 -10
  745. data/spec/unit/resource/launchd_spec.rb +8 -0
  746. data/spec/unit/resource/macos_user_defaults_spec.rb +103 -2
  747. data/spec/unit/resource/mount_spec.rb +28 -5
  748. data/spec/unit/resource/osx_profile_spec.rb +299 -0
  749. data/spec/unit/resource/powershell_package_source_spec.rb +20 -20
  750. data/spec/unit/resource/powershell_script_spec.rb +15 -108
  751. data/spec/unit/resource/rhsm_register_spec.rb +56 -18
  752. data/spec/unit/resource/rhsm_subscription_spec.rb +50 -3
  753. data/spec/unit/resource/script_spec.rb +6 -1
  754. data/spec/unit/resource/service_spec.rb +2 -2
  755. data/spec/unit/resource/solaris_package_spec.rb +8 -10
  756. data/spec/unit/resource/systemd_unit_spec.rb +1 -1
  757. data/spec/unit/resource/timezone_spec.rb +64 -1
  758. data/spec/unit/{log_spec.rb → resource/user/windows_user_spec.rb} +16 -4
  759. data/spec/unit/resource/user_ulimit_spec.rb +14 -1
  760. data/spec/unit/resource/windows_audit_policy_spec.rb +64 -0
  761. data/spec/unit/resource/windows_certificate_spec.rb +12 -0
  762. data/spec/unit/resource/windows_dns_record_spec.rb +3 -3
  763. data/spec/unit/resource/windows_dns_zone_spec.rb +2 -2
  764. data/spec/unit/resource/windows_feature_powershell_spec.rb +30 -4
  765. data/spec/unit/resource/windows_firewall_profile_spec.rb +77 -0
  766. data/spec/unit/resource/windows_package_spec.rb +1 -0
  767. data/spec/unit/resource/windows_task_spec.rb +1 -1
  768. data/spec/unit/resource/windows_uac_spec.rb +3 -3
  769. data/spec/unit/resource/windows_user_privilege_spec.rb +55 -0
  770. data/spec/unit/resource/yum_repository_spec.rb +21 -21
  771. data/spec/unit/resource_inspector_spec.rb +10 -5
  772. data/spec/unit/resource_reporter_spec.rb +1 -1
  773. data/spec/unit/resource_spec.rb +137 -3
  774. data/spec/unit/role_spec.rb +30 -28
  775. data/spec/unit/run_context/cookbook_compiler_spec.rb +1 -1
  776. data/spec/unit/run_lock_spec.rb +6 -2
  777. data/spec/unit/runner_spec.rb +1 -2
  778. data/spec/unit/scan_access_control_spec.rb +1 -1
  779. data/spec/unit/server_api_spec.rb +43 -16
  780. data/spec/unit/shell/shell_ext_spec.rb +46 -3
  781. data/spec/unit/shell/shell_session_spec.rb +35 -64
  782. data/spec/unit/shell_spec.rb +18 -21
  783. data/spec/unit/train_transport_spec.rb +14 -13
  784. data/spec/unit/util/backup_spec.rb +1 -1
  785. data/spec/unit/util/diff_spec.rb +1 -15
  786. data/spec/unit/util/dsc/configuration_generator_spec.rb +80 -1
  787. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +27 -35
  788. data/spec/unit/util/powershell/ps_credential_spec.rb +2 -2
  789. data/spec/unit/util/selinux_spec.rb +4 -1
  790. data/spec/unit/util/threaded_job_queue_spec.rb +9 -0
  791. data/spec/unit/win32/security_spec.rb +4 -3
  792. data/tasks/rspec.rb +2 -4
  793. metadata +172 -104
  794. data/lib/chef/dist.rb +0 -68
  795. data/lib/chef/monkey_patches/net_http.rb +0 -22
  796. data/lib/chef/provider/osx_profile.rb +0 -255
  797. data/lib/chef/provider/windows_env.rb +0 -210
  798. data/lib/chef/provider/windows_path.rb +0 -61
  799. data/lib/chef/provider/windows_task.rb +0 -635
  800. data/lib/chef/resource/cron.rb +0 -157
  801. data/lib/chef/util/powershell/cmdlet.rb +0 -173
  802. data/lib/chef/util/powershell/cmdlet_result.rb +0 -61
  803. data/spec/data/trusted_certs_empty/.gitkeep +0 -0
  804. data/spec/data/trusted_certs_empty/README.md +0 -1
  805. data/spec/functional/assets/yumrepo/repodata/4632d67cb92636e7575d911c24f0e04d3505a944e97c483abe0c3e73a7c62d33-filelists.sqlite.bz2 +0 -0
  806. data/spec/functional/assets/yumrepo/repodata/74599b793e54d877323837d2d81a1c3c594c44e4335f9528234bb490f7b9b439-other.xml.gz +0 -0
  807. data/spec/functional/assets/yumrepo/repodata/a845d418f919d2115ab95a56b2c76f6825ad0d0bede49181a55c04f58995d057-primary.sqlite.bz2 +0 -0
  808. data/spec/functional/assets/yumrepo/repodata/af9b7cf9ef23bd7b43068d74a460f3b5d06753d638e58e4a0c9edc35bfb9cdc4-other.sqlite.bz2 +0 -0
  809. data/spec/functional/assets/yumrepo/repodata/bdb4f5f1492a3b9532f22c43110a81500dd744f23da0aec5c33b2a41317c737d-filelists.xml.gz +0 -0
  810. data/spec/functional/assets/yumrepo/repodata/c10d1d34ce99e02f12ec96ef68360543ab1bb7c3cb81a4a2bf78df7d8597e9df-primary.xml.gz +0 -0
  811. data/spec/functional/util/powershell/cmdlet_spec.rb +0 -111
  812. data/spec/integration/knife/config_get_profile_spec.rb +0 -113
  813. data/spec/integration/knife/config_get_spec.rb +0 -191
  814. data/spec/integration/knife/config_list_profiles_spec.rb +0 -190
  815. data/spec/integration/knife/config_use_profile_spec.rb +0 -101
  816. data/spec/scripts/ssl-serve.rb +0 -47
  817. data/spec/support/mock/constant.rb +0 -52
  818. data/spec/unit/provider/osx_profile_spec.rb +0 -255
  819. data/spec/unit/provider_resolver_spec.rb +0 -885
  820. data/spec/unit/resource/data/InstallHistory_with_CLT.plist +0 -92
  821. data/spec/unit/resource/data/InstallHistory_without_CLT.plist +0 -38
  822. data/spec/unit/util/powershell/cmdlet_spec.rb +0 -106
@@ -16,12 +16,18 @@
16
16
  # limitations under the License.
17
17
  #
18
18
 
19
+ require "chef-utils" unless defined?(ChefUtils::CANARY)
19
20
  require_relative "../resource"
20
- require_relative "../win32/security" if Chef::Platform.windows?
21
+ require_relative "../win32/security" if ChefUtils.windows_ruby?
22
+ autoload :ISO8601, "iso8601" if ChefUtils.windows_ruby?
23
+ require_relative "../util/path_helper"
24
+ require "win32/taskscheduler" if ChefUtils.windows_ruby?
21
25
 
22
26
  class Chef
23
27
  class Resource
24
28
  class WindowsTask < Chef::Resource
29
+ unified_mode true
30
+
25
31
  provides(:windows_task) { true }
26
32
 
27
33
  description "Use the **windows_task** resource to create, delete or run a Windows scheduled task."
@@ -69,7 +75,7 @@ class Chef
69
75
  command 'chef-client'
70
76
  run_level :highest
71
77
  frequency :once
72
- start_time "16:10"
78
+ start_time '16:10'
73
79
  end
74
80
  ```
75
81
 
@@ -109,6 +115,7 @@ class Chef
109
115
  ```
110
116
 
111
117
  **Create a scheduled task to run when computer is idle with idle duration 20 min**:
118
+
112
119
  ```ruby
113
120
  windows_task 'chef-client' do
114
121
  command 'chef-client'
@@ -144,8 +151,8 @@ class Chef
144
151
  default_action :create
145
152
 
146
153
  property :task_name, String, regex: [%r{\A[^/\:\*\?\<\>\|]+\z}],
147
- description: "An optional property to set the task name if it differs from the resource block's name. Example: `Task Name` or `/Task Name`",
148
- name_property: true
154
+ description: "An optional property to set the task name if it differs from the resource block's name. Example: `Task Name` or `/Task Name`",
155
+ name_property: true
149
156
 
150
157
  property :command, String,
151
158
  description: "The command to be executed by the windows scheduled task."
@@ -155,15 +162,15 @@ class Chef
155
162
 
156
163
  property :user, String,
157
164
  description: "The user to run the task as.",
158
- default: lazy { Chef::ReservedNames::Win32::Security::SID.LocalSystem.account_simple_name if Chef::Platform.windows? },
165
+ default: lazy { Chef::ReservedNames::Win32::Security::SID.LocalSystem.account_simple_name if ChefUtils.windows_ruby? },
159
166
  default_description: "The localized SYSTEM user for the node."
160
167
 
161
168
  property :password, String,
162
169
  description: "The user's password. The user property must be set if using this property."
163
170
 
164
171
  property :run_level, Symbol, equal_to: %i{highest limited},
165
- description: "Run with `:limited` or `:highest` privileges.",
166
- default: :limited
172
+ description: "Run with `:limited` or `:highest` privileges.",
173
+ default: :limited
167
174
 
168
175
  property :force, [TrueClass, FalseClass],
169
176
  description: "When used with create, will update the task.",
@@ -176,24 +183,15 @@ class Chef
176
183
  property :frequency_modifier, [Integer, String],
177
184
  default: 1
178
185
 
179
- property :frequency, Symbol, equal_to: %i{minute
180
- hourly
181
- daily
182
- weekly
183
- monthly
184
- once
185
- on_logon
186
- onstart
187
- on_idle
188
- none},
189
- description: "The frequency with which to run the task."
186
+ property :frequency, Symbol, equal_to: %i{minute hourly daily weekly monthly once on_logon onstart on_idle none},
187
+ description: "The frequency with which to run the task."
190
188
 
191
189
  property :start_day, String,
192
- description: "Specifies the first date on which the task runs in MM/DD/YYYY format.",
190
+ description: "Specifies the first date on which the task runs in **MM/DD/YYYY** format.",
193
191
  default_description: "The current date."
194
192
 
195
193
  property :start_time, String,
196
- description: "Specifies the start time to run the task, in HH:mm format."
194
+ description: "Specifies the start time to run the task, in **HH:mm** format."
197
195
 
198
196
  property :day, [String, Integer],
199
197
  description: "The day(s) on which the task runs."
@@ -330,7 +328,7 @@ class Chef
330
328
 
331
329
  # make sure the start_day is in MM/DD/YYYY format: http://rubular.com/r/cgjHemtWl5
332
330
  if start_day
333
- raise ArgumentError, "`start_day` property must be in the MM/DD/YYYY format." unless %r{^(0[1-9]|1[012])[- /.](0[1-9]|[12][0-9]|3[01])[- /.](19|20)\d\d$} =~ start_day
331
+ raise ArgumentError, "`start_day` property must be in the MM/DD/YYYY format." unless %r{^(0[1-9]|1[012])[- /.](0[1-9]|[12][0-9]|3[01])[- /.](19|20)\d\d$}.match?(start_day)
334
332
  end
335
333
  end
336
334
 
@@ -338,7 +336,7 @@ class Chef
338
336
  def validate_start_time(start_time, frequency)
339
337
  if start_time
340
338
  raise ArgumentError, "`start_time` property is not supported with `frequency :none`" if frequency == :none
341
- raise ArgumentError, "`start_time` property must be in the HH:mm format (e.g. 6:20pm -> 18:20)." unless /^[0-2][0-9]:[0-5][0-9]$/ =~ start_time
339
+ raise ArgumentError, "`start_time` property must be in the HH:mm format (e.g. 6:20pm -> 18:20)." unless /^[0-2][0-9]:[0-5][0-9]$/.match?(start_time)
342
340
  else
343
341
  raise ArgumentError, "`start_time` needs to be provided with `frequency :once`" if frequency == :once
344
342
  end
@@ -383,16 +381,16 @@ class Chef
383
381
  frequency_modifier = frequency_modifier.to_i
384
382
  min = 1
385
383
  max = case frequency
386
- when :minute
387
- 1439
388
- when :hourly
389
- 23
390
- when :daily
391
- 365
392
- when :weekly
393
- 52
394
- else
395
- min
384
+ when :minute
385
+ 1439
386
+ when :hourly
387
+ 23
388
+ when :daily
389
+ 365
390
+ when :weekly
391
+ 52
392
+ else
393
+ min
396
394
  end
397
395
  unless frequency_modifier.between?(min, max)
398
396
  raise ArgumentError, "frequency_modifier value #{frequency_modifier} is invalid. Valid values for :#{frequency} frequency are #{min} - #{max}."
@@ -464,6 +462,609 @@ class Chef
464
462
  def sec_to_min(seconds)
465
463
  seconds.to_i / 60
466
464
  end
465
+
466
+ action_class do
467
+ if ChefUtils.windows_ruby?
468
+ include ::Win32
469
+
470
+ MONTHS = {
471
+ JAN: ::Win32::TaskScheduler::JANUARY,
472
+ FEB: ::Win32::TaskScheduler::FEBRUARY,
473
+ MAR: ::Win32::TaskScheduler::MARCH,
474
+ APR: ::Win32::TaskScheduler::APRIL,
475
+ MAY: ::Win32::TaskScheduler::MAY,
476
+ JUN: ::Win32::TaskScheduler::JUNE,
477
+ JUL: ::Win32::TaskScheduler::JULY,
478
+ AUG: ::Win32::TaskScheduler::AUGUST,
479
+ SEP: ::Win32::TaskScheduler::SEPTEMBER,
480
+ OCT: ::Win32::TaskScheduler::OCTOBER,
481
+ NOV: ::Win32::TaskScheduler::NOVEMBER,
482
+ DEC: ::Win32::TaskScheduler::DECEMBER,
483
+ }.freeze
484
+
485
+ DAYS_OF_WEEK = { MON: ::Win32::TaskScheduler::MONDAY,
486
+ TUE: ::Win32::TaskScheduler::TUESDAY,
487
+ WED: ::Win32::TaskScheduler::WEDNESDAY,
488
+ THU: ::Win32::TaskScheduler::THURSDAY,
489
+ FRI: ::Win32::TaskScheduler::FRIDAY,
490
+ SAT: ::Win32::TaskScheduler::SATURDAY,
491
+ SUN: ::Win32::TaskScheduler::SUNDAY }.freeze
492
+
493
+ WEEKS_OF_MONTH = {
494
+ FIRST: ::Win32::TaskScheduler::FIRST_WEEK,
495
+ SECOND: ::Win32::TaskScheduler::SECOND_WEEK,
496
+ THIRD: ::Win32::TaskScheduler::THIRD_WEEK,
497
+ FOURTH: ::Win32::TaskScheduler::FOURTH_WEEK,
498
+ }.freeze
499
+
500
+ DAYS_OF_MONTH = {
501
+ 1 => ::Win32::TaskScheduler::TASK_FIRST,
502
+ 2 => ::Win32::TaskScheduler::TASK_SECOND,
503
+ 3 => ::Win32::TaskScheduler::TASK_THIRD,
504
+ 4 => ::Win32::TaskScheduler::TASK_FOURTH,
505
+ 5 => ::Win32::TaskScheduler::TASK_FIFTH,
506
+ 6 => ::Win32::TaskScheduler::TASK_SIXTH,
507
+ 7 => ::Win32::TaskScheduler::TASK_SEVENTH,
508
+ 8 => ::Win32::TaskScheduler::TASK_EIGHTH,
509
+ # cspell:disable-next-line
510
+ 9 => ::Win32::TaskScheduler::TASK_NINETH,
511
+ 10 => ::Win32::TaskScheduler::TASK_TENTH,
512
+ 11 => ::Win32::TaskScheduler::TASK_ELEVENTH,
513
+ 12 => ::Win32::TaskScheduler::TASK_TWELFTH,
514
+ 13 => ::Win32::TaskScheduler::TASK_THIRTEENTH,
515
+ 14 => ::Win32::TaskScheduler::TASK_FOURTEENTH,
516
+ 15 => ::Win32::TaskScheduler::TASK_FIFTEENTH,
517
+ 16 => ::Win32::TaskScheduler::TASK_SIXTEENTH,
518
+ 17 => ::Win32::TaskScheduler::TASK_SEVENTEENTH,
519
+ 18 => ::Win32::TaskScheduler::TASK_EIGHTEENTH,
520
+ 19 => ::Win32::TaskScheduler::TASK_NINETEENTH,
521
+ 20 => ::Win32::TaskScheduler::TASK_TWENTIETH,
522
+ 21 => ::Win32::TaskScheduler::TASK_TWENTY_FIRST,
523
+ 22 => ::Win32::TaskScheduler::TASK_TWENTY_SECOND,
524
+ 23 => ::Win32::TaskScheduler::TASK_TWENTY_THIRD,
525
+ 24 => ::Win32::TaskScheduler::TASK_TWENTY_FOURTH,
526
+ 25 => ::Win32::TaskScheduler::TASK_TWENTY_FIFTH,
527
+ 26 => ::Win32::TaskScheduler::TASK_TWENTY_SIXTH,
528
+ 27 => ::Win32::TaskScheduler::TASK_TWENTY_SEVENTH,
529
+ 28 => ::Win32::TaskScheduler::TASK_TWENTY_EIGHTH,
530
+ 29 => ::Win32::TaskScheduler::TASK_TWENTY_NINTH,
531
+ # cspell:disable-next-line
532
+ 30 => ::Win32::TaskScheduler::TASK_THIRTYETH,
533
+ 31 => ::Win32::TaskScheduler::TASK_THIRTY_FIRST,
534
+ }.freeze
535
+
536
+ PRIORITY = { "critical" => 0, "highest" => 1, "above_normal_2" => 2 , "above_normal_3" => 3, "normal_4" => 4,
537
+ "normal_5" => 5, "normal_6" => 6, "below_normal_7" => 7, "below_normal_8" => 8, "lowest" => 9, "idle" => 10 }.freeze
538
+ end
539
+
540
+ def load_current_resource
541
+ @current_resource = Chef::Resource::WindowsTask.new(new_resource.name)
542
+ task = ::Win32::TaskScheduler.new(new_resource.task_name, nil, "\\", false)
543
+ @current_resource.exists = task.exists?(new_resource.task_name)
544
+ if @current_resource.exists
545
+ task.get_task(new_resource.task_name)
546
+ @current_resource.task = task
547
+ pathed_task_name = new_resource.task_name.start_with?('\\') ? new_resource.task_name : "\\#{new_resource.task_name}"
548
+ @current_resource.task_name(pathed_task_name)
549
+ end
550
+ @current_resource
551
+ end
552
+
553
+ # separated command arguments from :command property
554
+ def set_command_and_arguments
555
+ cmd, *args = Chef::Util::PathHelper.split_args(new_resource.command)
556
+ new_resource.command = cmd
557
+ new_resource.command_arguments = args.join(" ")
558
+ end
559
+
560
+ def set_start_day_and_time
561
+ new_resource.start_day = Time.now.strftime("%m/%d/%Y") unless new_resource.start_day
562
+ new_resource.start_time = Time.now.strftime("%H:%M") unless new_resource.start_time
563
+ end
564
+
565
+ def update_task(task)
566
+ converge_by("#{new_resource} task updated") do
567
+ task.set_account_information(new_resource.user, new_resource.password, new_resource.interactive_enabled)
568
+ task.application_name = new_resource.command if new_resource.command
569
+ task.parameters = new_resource.command_arguments if new_resource.command_arguments
570
+ task.working_directory = new_resource.cwd if new_resource.cwd
571
+ task.trigger = trigger unless new_resource.frequency == :none
572
+ task.configure_settings(config_settings)
573
+ task.creator = new_resource.user
574
+ task.description = new_resource.description unless new_resource.description.nil?
575
+ task.configure_principals(principal_settings)
576
+ end
577
+ end
578
+
579
+ def trigger
580
+ start_month, start_day, start_year = new_resource.start_day.to_s.split("/")
581
+ start_hour, start_minute = new_resource.start_time.to_s.split(":")
582
+ # TODO currently end_month, end_year and end_year needs to be set to 0. If not set win32-taskscheduler throwing nil into integer error.
583
+ trigger_hash = {
584
+ start_year: start_year.to_i,
585
+ start_month: start_month.to_i,
586
+ start_day: start_day.to_i,
587
+ start_hour: start_hour.to_i,
588
+ start_minute: start_minute.to_i,
589
+ end_month: 0,
590
+ end_day: 0,
591
+ end_year: 0,
592
+ trigger_type: trigger_type,
593
+ type: type,
594
+ random_minutes_interval: new_resource.random_delay,
595
+ }
596
+
597
+ if new_resource.frequency == :minute
598
+ trigger_hash[:minutes_interval] = new_resource.frequency_modifier
599
+ end
600
+
601
+ if new_resource.frequency == :hourly
602
+ minutes = convert_hours_in_minutes(new_resource.frequency_modifier.to_i)
603
+ trigger_hash[:minutes_interval] = minutes
604
+ end
605
+
606
+ if new_resource.minutes_interval
607
+ trigger_hash[:minutes_interval] = new_resource.minutes_interval
608
+ end
609
+
610
+ if new_resource.minutes_duration
611
+ trigger_hash[:minutes_duration] = new_resource.minutes_duration
612
+ end
613
+
614
+ if trigger_type == ::Win32::TaskScheduler::MONTHLYDOW && frequency_modifier_contains_last_week?(new_resource.frequency_modifier)
615
+ trigger_hash[:run_on_last_week_of_month] = true
616
+ else
617
+ trigger_hash[:run_on_last_week_of_month] = false
618
+ end
619
+
620
+ if trigger_type == ::Win32::TaskScheduler::MONTHLYDATE && day_includes_last_or_lastday?(new_resource.day)
621
+ trigger_hash[:run_on_last_day_of_month] = true
622
+ else
623
+ trigger_hash[:run_on_last_day_of_month] = false
624
+ end
625
+ trigger_hash
626
+ end
627
+
628
+ def frequency_modifier_contains_last_week?(frequency_modifier)
629
+ frequency_modifier = frequency_modifier.to_s.split(",")
630
+ frequency_modifier.map! { |value| value.strip.upcase }
631
+ frequency_modifier.include?("LAST")
632
+ end
633
+
634
+ def day_includes_last_or_lastday?(day)
635
+ day = day.to_s.split(",")
636
+ day.map! { |value| value.strip.upcase }
637
+ day.include?("LAST") || day.include?("LASTDAY")
638
+ end
639
+
640
+ def convert_hours_in_minutes(hours)
641
+ hours.to_i * 60 if hours
642
+ end
643
+
644
+ # TODO : Try to optimize this method
645
+ # known issue : Since start_day and time is not mandatory while updating weekly frequency for which start_day is not mentioned by user idempotency
646
+ # is not getting maintained as new_resource.start_day is nil and we fetch the day of week from start_day to set and its currently coming as nil and don't match with current_task
647
+ def task_needs_update?(task)
648
+ flag = false
649
+ if new_resource.frequency == :none
650
+ flag = (task.author != new_resource.user ||
651
+ task.application_name != new_resource.command ||
652
+ description_needs_update?(task) ||
653
+ task.parameters != new_resource.command_arguments.to_s ||
654
+ task.principals[:run_level] != run_level ||
655
+ task.settings[:disallow_start_if_on_batteries] != new_resource.disallow_start_if_on_batteries ||
656
+ task.settings[:stop_if_going_on_batteries] != new_resource.stop_if_going_on_batteries ||
657
+ task.settings[:start_when_available] != new_resource.start_when_available)
658
+ else
659
+ current_task_trigger = task.trigger(0)
660
+ new_task_trigger = trigger
661
+ flag = (ISO8601::Duration.new(task.idle_settings[:idle_duration])) != (ISO8601::Duration.new(new_resource.idle_time * 60)) if new_resource.frequency == :on_idle
662
+ flag = (ISO8601::Duration.new(task.execution_time_limit)) != (ISO8601::Duration.new(new_resource.execution_time_limit * 60)) unless new_resource.execution_time_limit.nil?
663
+
664
+ # if trigger not found updating the task to add the trigger
665
+ if current_task_trigger.nil?
666
+ flag = true
667
+ else
668
+ flag = true if start_day_updated?(current_task_trigger, new_task_trigger) == true ||
669
+ start_time_updated?(current_task_trigger, new_task_trigger) == true ||
670
+ current_task_trigger[:trigger_type] != new_task_trigger[:trigger_type] ||
671
+ current_task_trigger[:type] != new_task_trigger[:type] ||
672
+ current_task_trigger[:random_minutes_interval].to_i != new_task_trigger[:random_minutes_interval].to_i ||
673
+ current_task_trigger[:minutes_interval].to_i != new_task_trigger[:minutes_interval].to_i ||
674
+ task.author.to_s.casecmp(new_resource.user.to_s) != 0 ||
675
+ task.application_name != new_resource.command ||
676
+ description_needs_update?(task) ||
677
+ task.parameters != new_resource.command_arguments.to_s ||
678
+ task.working_directory != new_resource.cwd.to_s ||
679
+ task.principals[:logon_type] != logon_type ||
680
+ task.principals[:run_level] != run_level ||
681
+ PRIORITY[task.priority] != new_resource.priority ||
682
+ task.settings[:disallow_start_if_on_batteries] != new_resource.disallow_start_if_on_batteries ||
683
+ task.settings[:stop_if_going_on_batteries] != new_resource.stop_if_going_on_batteries ||
684
+ task.settings[:start_when_available] != new_resource.start_when_available
685
+ if trigger_type == ::Win32::TaskScheduler::MONTHLYDATE
686
+ flag = true if current_task_trigger[:run_on_last_day_of_month] != new_task_trigger[:run_on_last_day_of_month]
687
+ end
688
+
689
+ if trigger_type == ::Win32::TaskScheduler::MONTHLYDOW
690
+ flag = true if current_task_trigger[:run_on_last_week_of_month] != new_task_trigger[:run_on_last_week_of_month]
691
+ end
692
+ end
693
+ end
694
+ flag
695
+ end
696
+
697
+ def start_day_updated?(current_task_trigger, new_task_trigger)
698
+ ( new_resource.start_day && (current_task_trigger[:start_year].to_i != new_task_trigger[:start_year] ||
699
+ current_task_trigger[:start_month].to_i != new_task_trigger[:start_month] ||
700
+ current_task_trigger[:start_day].to_i != new_task_trigger[:start_day]) )
701
+ end
702
+
703
+ def start_time_updated?(current_task_trigger, new_task_trigger)
704
+ ( new_resource.start_time && ( current_task_trigger[:start_hour].to_i != new_task_trigger[:start_hour] ||
705
+ current_task_trigger[:start_minute].to_i != new_task_trigger[:start_minute] ) )
706
+ end
707
+
708
+ def trigger_type
709
+ case new_resource.frequency
710
+ when :once, :minute, :hourly
711
+ ::Win32::TaskScheduler::ONCE
712
+ when :daily
713
+ ::Win32::TaskScheduler::DAILY
714
+ when :weekly
715
+ ::Win32::TaskScheduler::WEEKLY
716
+ when :monthly
717
+ # If frequency modifier is set with frequency :monthly we are setting taskscheduler as monthlydow
718
+ # Ref https://msdn.microsoft.com/en-us/library/windows/desktop/aa382061(v=vs.85).aspx
719
+ new_resource.frequency_modifier.to_i.between?(1, 12) ? ::Win32::TaskScheduler::MONTHLYDATE : ::Win32::TaskScheduler::MONTHLYDOW
720
+ when :on_idle
721
+ ::Win32::TaskScheduler::ON_IDLE
722
+ when :onstart
723
+ ::Win32::TaskScheduler::AT_SYSTEMSTART
724
+ when :on_logon
725
+ ::Win32::TaskScheduler::AT_LOGON
726
+ else
727
+ raise ArgumentError, "Please set frequency"
728
+ end
729
+ end
730
+
731
+ def type
732
+ case trigger_type
733
+ when ::Win32::TaskScheduler::ONCE
734
+ { once: nil }
735
+ when ::Win32::TaskScheduler::DAILY
736
+ { days_interval: new_resource.frequency_modifier.to_i }
737
+ when ::Win32::TaskScheduler::WEEKLY
738
+ { weeks_interval: new_resource.frequency_modifier.to_i, days_of_week: days_of_week.to_i }
739
+ when ::Win32::TaskScheduler::MONTHLYDATE
740
+ { months: months_of_year.to_i, days: days_of_month.to_i }
741
+ when ::Win32::TaskScheduler::MONTHLYDOW
742
+ { months: months_of_year.to_i, days_of_week: days_of_week.to_i, weeks_of_month: weeks_of_month.to_i }
743
+ when ::Win32::TaskScheduler::ON_IDLE
744
+ # TODO: handle option for this trigger
745
+ when ::Win32::TaskScheduler::AT_LOGON
746
+ # TODO: handle option for this trigger
747
+ when ::Win32::TaskScheduler::AT_SYSTEMSTART
748
+ # TODO: handle option for this trigger
749
+ end
750
+ end
751
+
752
+ # Deleting last from the array of weeks of month since last week is handled in :run_on_last_week_of_month parameter.
753
+ def weeks_of_month
754
+ weeks_of_month = []
755
+ if new_resource.frequency_modifier
756
+ weeks = new_resource.frequency_modifier.split(",")
757
+ weeks.map! { |week| week.to_s.strip.upcase }
758
+ weeks.delete("LAST") if weeks.include?("LAST")
759
+ weeks_of_month = get_binary_values_from_constants(weeks, WEEKS_OF_MONTH)
760
+ end
761
+ weeks_of_month
762
+ end
763
+
764
+ # Deleting the "LAST" and "LASTDAY" from days since last day is handled in :run_on_last_day_of_month parameter.
765
+ def days_of_month
766
+ days_of_month = []
767
+ if new_resource.day
768
+ days = new_resource.day.to_s.split(",")
769
+ days.map! { |day| day.to_s.strip.upcase }
770
+ days.delete("LAST") if days.include?("LAST")
771
+ days.delete("LASTDAY") if days.include?("LASTDAY")
772
+ if days - (1..31).to_a
773
+ days.each do |day|
774
+ days_of_month << DAYS_OF_MONTH[day.to_i]
775
+ end
776
+ days_of_month = days_of_month.size > 1 ? days_of_month.inject(:|) : days_of_month[0]
777
+ end
778
+ else
779
+ days_of_month = DAYS_OF_MONTH[1]
780
+ end
781
+ days_of_month
782
+ end
783
+
784
+ def days_of_week
785
+ if new_resource.day
786
+ # this line of code is just to support backward compatibility of wild card *
787
+ new_resource.day = "mon, tue, wed, thu, fri, sat, sun" if new_resource.day == "*" && new_resource.frequency == :weekly
788
+ days = new_resource.day.to_s.split(",")
789
+ days.map! { |day| day.to_s.strip.upcase }
790
+ weeks_days = get_binary_values_from_constants(days, DAYS_OF_WEEK)
791
+ else
792
+ # following condition will make the frequency :weekly idempotent if start_day is not provided by user setting day as the current_resource day
793
+ if (current_resource) && (current_resource.task) && (current_resource.task.trigger(0)[:type][:days_of_week]) && (new_resource.start_day.nil?)
794
+ weeks_days = current_resource.task.trigger(0)[:type][:days_of_week]
795
+ else
796
+ day = get_day(new_resource.start_day).to_sym if new_resource.start_day
797
+ DAYS_OF_WEEK[day]
798
+ end
799
+ end
800
+ end
801
+
802
+ def months_of_year
803
+ months_of_year = []
804
+ if new_resource.frequency_modifier.to_i.between?(1, 12) && !(new_resource.months)
805
+ new_resource.months = set_months(new_resource.frequency_modifier.to_i)
806
+ end
807
+
808
+ if new_resource.months
809
+ # this line of code is just to support backward compatibility of wild card *
810
+ new_resource.months = "jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec" if new_resource.months == "*" && new_resource.frequency == :monthly
811
+ months = new_resource.months.split(",")
812
+ months.map! { |month| month.to_s.strip.upcase }
813
+ months_of_year = get_binary_values_from_constants(months, MONTHS)
814
+ else
815
+ MONTHS.each do |key, value|
816
+ months_of_year << MONTHS[key]
817
+ end
818
+ months_of_year = months_of_year.inject(:|)
819
+ end
820
+ months_of_year
821
+ end
822
+
823
+ # This values are set for frequency_modifier set as 1-12
824
+ # This is to give backward compatibility validated this values with earlier code and running schtask.exe
825
+ # Used this as reference https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/schtasks#d-dayday--
826
+ def set_months(frequency_modifier)
827
+ case frequency_modifier
828
+ when 1
829
+ "jan, feb, mar, apr, may, jun, jul, aug, sep, oct, nov, dec"
830
+ when 2
831
+ "feb, apr, jun, aug, oct, dec"
832
+ when 3
833
+ "mar, jun, sep, dec"
834
+ when 4
835
+ "apr, aug, dec"
836
+ when 5
837
+ "may, oct"
838
+ when 6
839
+ "jun, dec"
840
+ when 7
841
+ "jul"
842
+ when 8
843
+ "aug"
844
+ when 9
845
+ "sep"
846
+ when 10
847
+ "oct"
848
+ when 11
849
+ "nov"
850
+ when 12
851
+ "dec"
852
+ end
853
+ end
854
+
855
+ def get_binary_values_from_constants(array_values, constant)
856
+ data = []
857
+ array_values.each do |value|
858
+ value = value.to_sym
859
+ data << constant[value]
860
+ end
861
+ data.size > 1 ? data.inject(:|) : data[0]
862
+ end
863
+
864
+ def run_level
865
+ case new_resource.run_level
866
+ when :highest
867
+ ::Win32::TaskScheduler::TASK_RUNLEVEL_HIGHEST
868
+ when :limited
869
+ ::Win32::TaskScheduler::TASK_RUNLEVEL_LUA
870
+ end
871
+ end
872
+
873
+ # TODO: while creating the configuration settings win32-taskscheduler it accepts execution time limit values in ISO8601 format
874
+ def config_settings
875
+ settings = {
876
+ execution_time_limit: new_resource.execution_time_limit,
877
+ enabled: true,
878
+ }
879
+ settings[:idle_duration] = new_resource.idle_time if new_resource.idle_time
880
+ settings[:run_only_if_idle] = true if new_resource.idle_time
881
+ settings[:priority] = new_resource.priority
882
+ settings[:disallow_start_if_on_batteries] = new_resource.disallow_start_if_on_batteries
883
+ settings[:stop_if_going_on_batteries] = new_resource.stop_if_going_on_batteries
884
+ settings[:start_when_available] = new_resource.start_when_available
885
+ settings
886
+ end
887
+
888
+ def principal_settings
889
+ settings = {}
890
+ settings[:run_level] = run_level
891
+ settings[:logon_type] = logon_type
892
+ settings
893
+ end
894
+
895
+ def description_needs_update?(task)
896
+ task.description != new_resource.description unless new_resource.description.nil?
897
+ end
898
+
899
+ def logon_type
900
+ # Ref: https://msdn.microsoft.com/en-us/library/windows/desktop/aa383566(v=vs.85).aspx
901
+ # if nothing is passed as logon_type the TASK_LOGON_SERVICE_ACCOUNT is getting set as default so using that for comparison.
902
+ user_id = new_resource.user.to_s
903
+ password = new_resource.password.to_s
904
+ if Chef::ReservedNames::Win32::Security::SID.service_account_user?(user_id)
905
+ ::Win32::TaskScheduler::TASK_LOGON_SERVICE_ACCOUNT
906
+ elsif Chef::ReservedNames::Win32::Security::SID.group_user?(user_id)
907
+ ::Win32::TaskScheduler::TASK_LOGON_GROUP
908
+ elsif !user_id.empty? && !password.empty?
909
+ if new_resource.interactive_enabled
910
+ ::Win32::TaskScheduler::TASK_LOGON_INTERACTIVE_TOKEN
911
+ else
912
+ ::Win32::TaskScheduler::TASK_LOGON_PASSWORD
913
+ end
914
+ else
915
+ ::Win32::TaskScheduler::TASK_LOGON_INTERACTIVE_TOKEN
916
+ end
917
+ end
918
+
919
+ # This method checks if task and command properties exist since those two are mandatory properties to create a schedules task.
920
+ def basic_validation
921
+ validate = []
922
+ validate << "Command" if new_resource.command.nil? || new_resource.command.empty?
923
+ validate << "Task Name" if new_resource.task_name.nil? || new_resource.task_name.empty?
924
+ return true if validate.empty?
925
+
926
+ raise Chef::Exceptions::ValidationFailed.new "Value for '#{validate.join(", ")}' option cannot be empty"
927
+ end
928
+
929
+ # rubocop:disable Style/StringLiteralsInInterpolation
930
+ def run_schtasks(task_action, options = {})
931
+ cmd = "schtasks /#{task_action} /TN \"#{new_resource.task_name}\" "
932
+ options.each_key do |option|
933
+ unless option == "TR"
934
+ cmd += "/#{option} "
935
+ cmd += "\"#{options[option].to_s.gsub('"', "\\\"")}\" " unless options[option] == ""
936
+ end
937
+ end
938
+ # Appending Task Run [TR] option at the end since appending causing sometimes to append other options in option["TR"] value
939
+ if options["TR"]
940
+ cmd += "/TR \"#{options["TR"]} \" " unless task_action == "DELETE"
941
+ end
942
+ logger.trace("running: ")
943
+ logger.trace(" #{cmd}")
944
+ shell_out!(cmd, returns: [0])
945
+ end
946
+ # rubocop:enable Style/StringLiteralsInInterpolation
947
+
948
+ def get_day(date)
949
+ Date.strptime(date, "%m/%d/%Y").strftime("%a").upcase
950
+ end
951
+ end
952
+
953
+ action :create do
954
+ set_command_and_arguments if new_resource.command
955
+
956
+ if current_resource.exists
957
+ logger.trace "#{new_resource} task exist."
958
+ unless (task_needs_update?(current_resource.task)) || (new_resource.force)
959
+ logger.info "#{new_resource} task does not need updating and force is not specified - nothing to do"
960
+ return
961
+ end
962
+
963
+ # if start_day and start_time is not set by user current date and time will be set while updating any property
964
+ set_start_day_and_time unless new_resource.frequency == :none
965
+ update_task(current_resource.task)
966
+ else
967
+ basic_validation
968
+ set_start_day_and_time
969
+ converge_by("#{new_resource} task created") do
970
+ task = ::Win32::TaskScheduler.new
971
+ if new_resource.frequency == :none
972
+ task.new_work_item(new_resource.task_name, {}, { user: new_resource.user, password: new_resource.password, interactive: new_resource.interactive_enabled })
973
+ task.activate(new_resource.task_name)
974
+ else
975
+ task.new_work_item(new_resource.task_name, trigger, { user: new_resource.user, password: new_resource.password, interactive: new_resource.interactive_enabled })
976
+ end
977
+ task.application_name = new_resource.command
978
+ task.parameters = new_resource.command_arguments if new_resource.command_arguments
979
+ task.working_directory = new_resource.cwd if new_resource.cwd
980
+ task.configure_settings(config_settings)
981
+ task.configure_principals(principal_settings)
982
+ task.set_account_information(new_resource.user, new_resource.password, new_resource.interactive_enabled)
983
+ task.creator = new_resource.user
984
+ task.description = new_resource.description unless new_resource.description.nil?
985
+ task.activate(new_resource.task_name)
986
+ end
987
+ end
988
+ end
989
+
990
+ action :run do
991
+ if current_resource.exists
992
+ logger.trace "#{new_resource} task exists"
993
+ if current_resource.task.status == "running"
994
+ logger.info "#{new_resource} task is currently running, skipping run"
995
+ else
996
+ converge_by("run scheduled task #{new_resource}") do
997
+ current_resource.task.run
998
+ end
999
+ end
1000
+ else
1001
+ logger.warn "#{new_resource} task does not exist - nothing to do"
1002
+ end
1003
+ end
1004
+
1005
+ action :delete do
1006
+ if current_resource.exists
1007
+ logger.trace "#{new_resource} task exists"
1008
+ converge_by("delete scheduled task #{new_resource}") do
1009
+ ts = ::Win32::TaskScheduler.new
1010
+ ts.delete(current_resource.task_name)
1011
+ end
1012
+ else
1013
+ logger.warn "#{new_resource} task does not exist - nothing to do"
1014
+ end
1015
+ end
1016
+
1017
+ action :end do
1018
+ if current_resource.exists
1019
+ logger.trace "#{new_resource} task exists"
1020
+ if current_resource.task.status != "running"
1021
+ logger.trace "#{new_resource} is not running - nothing to do"
1022
+ else
1023
+ converge_by("#{new_resource} task ended") do
1024
+ current_resource.task.stop
1025
+ end
1026
+ end
1027
+ else
1028
+ logger.warn "#{new_resource} task does not exist - nothing to do"
1029
+ end
1030
+ end
1031
+
1032
+ action :enable do
1033
+ if current_resource.exists
1034
+ logger.trace "#{new_resource} task exists"
1035
+ if current_resource.task.status == "not scheduled"
1036
+ converge_by("#{new_resource} task enabled") do
1037
+ # TODO wind32-taskscheduler currently not having any method to handle this so using schtasks.exe here
1038
+ run_schtasks "CHANGE", "ENABLE" => ""
1039
+ end
1040
+ else
1041
+ logger.trace "#{new_resource} already enabled - nothing to do"
1042
+ end
1043
+ else
1044
+ logger.fatal "#{new_resource} task does not exist - nothing to do"
1045
+ raise Errno::ENOENT, "#{new_resource}: task does not exist, cannot enable"
1046
+ end
1047
+ end
1048
+
1049
+ action :disable do
1050
+ if current_resource.exists
1051
+ logger.info "#{new_resource} task exists"
1052
+ if %w{ready running}.include?(current_resource.task.status)
1053
+ converge_by("#{new_resource} task disabled") do
1054
+ # TODO: in win32-taskscheduler there is no method which disables the task so currently calling disable with schtasks.exe
1055
+ run_schtasks "CHANGE", "DISABLE" => ""
1056
+ end
1057
+ else
1058
+ logger.warn "#{new_resource} already disabled - nothing to do"
1059
+ end
1060
+ else
1061
+ logger.warn "#{new_resource} task does not exist - nothing to do"
1062
+ end
1063
+ end
1064
+
1065
+ action_class do
1066
+ alias_method :action_change, :action_create
1067
+ end
467
1068
  end
468
1069
  end
469
1070
  end