chef 15.2.20 → 15.3.14

data/spec/unit/provider/user/dscl_spec.rb

@@ -35,6 +35,7 @@ describe Chef::Provider::User::Dscl do
   let(:node) do
     Chef::Node.new.tap do |node|
       node.automatic["os"] = "darwin"
+      node.automatic["platform_version"] = "10.13.0"
     end
   end
 

data/spec/unit/provider/user/mac_spec.rb

@@ -0,0 +1,38 @@
+#
+# Author:: Ryan Cragun (<ryan@chef.io>)
+# Copyright:: Copyright (c) 2019 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+
+describe Chef::Provider::User::MacUser do
+  before do
+    allow(ChefConfig).to receive(:windows?) { false }
+  end
+
+  let(:new_resource) { Chef::Resource::User::MacUser.new("jane") }
+
+  let(:provider) do
+    node = Chef::Node.new
+    events = Chef::EventDispatch::Dispatcher.new
+    run_context = Chef::RunContext.new(node, {}, events)
+    described_class.new(new_resource, run_context)
+  end
+
+  it "responds to load_current_resource" do
+    expect(provider).to respond_to(:load_current_resource)
+  end
+end

data/spec/unit/provider/user_spec.rb

@@ -444,35 +444,51 @@ describe Chef::Provider::User do
 
   describe "convert_group_name" do
     before do
-      @new_resource.gid("999")
       @group = EtcGrnamIsh.new("wheel", "*", 999, [])
     end
 
-    it "should lookup the group name locally" do
-      expect(Etc).to receive(:getgrnam).with("999").and_return(@group)
-      expect(@provider.convert_group_name).to eq(999)
-    end
+    context "when user passes group name in gid" do
+      before do
+        @new_resource.gid("wheel")
+      end
 
-    it "should raise an error if we can't translate the group name during resource assertions" do
-      expect(Etc).to receive(:getgrnam).and_raise(ArgumentError)
-      @provider.action = :create
-      @provider.define_resource_requirements
-      @provider.convert_group_name
-      expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::User)
-    end
+      it "should lookup the group name locally" do
+        expect(Etc).to receive(:getgrnam).with("wheel").and_return(@group)
+        expect(@provider.convert_group_name).to eq(999)
+      end
+
+      it "should raise an error if we can't translate the group name during resource assertions" do
+        expect(Etc).to receive(:getgrnam).and_raise(ArgumentError)
+        @provider.action = :create
+        @provider.define_resource_requirements
+        @provider.convert_group_name
+        expect { @provider.process_resource_requirements }.to raise_error(Chef::Exceptions::User)
+      end
 
-    it "does not raise an error if we can't translate the group name during resource assertions if we are removing the user" do
-      expect(Etc).to receive(:getgrnam).and_raise(ArgumentError)
-      @provider.action = :remove
-      @provider.define_resource_requirements
-      @provider.convert_group_name
-      expect { @provider.process_resource_requirements }.not_to raise_error
+      it "does not raise an error if we can't translate the group name during resource assertions if we are removing the user" do
+        expect(Etc).to receive(:getgrnam).and_raise(ArgumentError)
+        @provider.action = :remove
+        @provider.define_resource_requirements
+        @provider.convert_group_name
+        expect { @provider.process_resource_requirements }.not_to raise_error
+      end
+
+      it "should set the new resources gid to the integerized version if available" do
+        expect(Etc).to receive(:getgrnam).with("wheel").and_return(@group)
+        @provider.convert_group_name
+        expect(@new_resource.gid).to eq(999)
+      end
     end
 
-    it "should set the new resources gid to the integerized version if available" do
-      expect(Etc).to receive(:getgrnam).with("999").and_return(@group)
-      @provider.convert_group_name
-      expect(@new_resource.gid).to eq(999)
+    context "when user passes group id in gid" do
+      before do
+        @new_resource.gid(999)
+      end
+
+      it "should not call getgrnam" do
+        expect(Etc).not_to receive(:getgrnam)
+        @provider.convert_group_name
+      end
     end
   end
 end

data/tasks/docs.rb

@@ -156,6 +156,7 @@ namespace :docs_site do
 
         Notifications
         -----------------------------------------------------
+
         ``notifies``
           **Ruby Type:** Symbol, 'Chef::Resource[String]'
 
@@ -167,13 +168,13 @@ namespace :docs_site do
 
         .. tag resources_common_notification_timers
 
-        A timer specifies the point during the Chef Infra Client run at which a notification is run. The following timers are available:
+        A timer specifies the point during a Chef Infra Client run at which a notification is run. The following timers are available:
 
         ``:before``
            Specifies that the action on a notified resource should be run before processing the resource block in which the notification is located.
 
         ``:delayed``
-           Default. Specifies that a notification should be queued up, and then executed at the end of the Chef Infra Client run.
+           Default. Specifies that a notification should be queued up, and then executed at the end of a Chef Infra Client run.
 
         ``:immediate``, ``:immediately``
            Specifies that a notification should be run immediately, per resource notified.
@@ -216,13 +217,13 @@ namespace :docs_site do
 
         .. tag resources_common_notification_timers
 
-        A timer specifies the point during the Chef Infra Client run at which a notification is run. The following timers are available:
+        A timer specifies the point during a Chef Infra Client run at which a notification is run. The following timers are available:
 
         ``:before``
            Specifies that the action on a notified resource should be run before processing the resource block in which the notification is located.
 
         ``:delayed``
-           Default. Specifies that a notification should be queued up, and then executed at the end of the Chef Infra Client run.
+           Default. Specifies that a notification should be queued up, and then executed at the end of a Chef Infra Client run.
 
         ``:immediate``, ``:immediately``
            Specifies that a notification should be run immediately, per resource notified.
@@ -244,17 +245,20 @@ namespace :docs_site do
 
         .. tag resources_common_guards
 
-        A guard property can be used to evaluate the state of a node during the execution phase of the Chef Infra Client run. Based on the results of this evaluation, a guard property is then used to tell the Chef Infra Client if it should continue executing a resource. A guard property accepts either a string value or a Ruby block value:
+        A guard property can be used to evaluate the state of a node during the execution phase of a Chef Infra Client run. Based on the results of this evaluation, a guard property is then used to tell Chef Infra Client if it should continue executing a resource. A guard property accepts either a string value or a Ruby block value:
 
         * A string is executed as a shell command. If the command returns ``0``, the guard is applied. If the command returns any other value, then the guard property is not applied. String guards in a **powershell_script** run Windows PowerShell commands and may return ``true`` in addition to ``0``.
         * A block is executed as Ruby code that must return either ``true`` or ``false``. If the block returns ``true``, the guard property is applied. If the block returns ``false``, the guard property is not applied.
 
-        A guard property is useful for ensuring that a resource is idempotent by allowing that resource to test for the desired state as it is being executed, and then if the desired state is present, for the Chef Infra Client to do nothing.
+        A guard property is useful for ensuring that a resource is idempotent by allowing that resource to test for the desired state as it is being executed, and then if the desired state is present, for Chef Infra Client to do nothing.
 
         .. end_tag
+
+        **Properties**
+
         .. tag resources_common_guards_properties
 
-        The following properties can be used to define a guard that is evaluated during the execution phase of the Chef Infra Client run:
+        The following properties can be used to define a guard that is evaluated during the execution phase of a Chef Infra Client run:
 
         ``not_if``
           Prevent a resource from executing when the condition returns ``true``.
@@ -305,7 +309,7 @@ The <%= @name %> resource has the following actions:
 ``:nothing``
    .. tag resources_common_actions_nothing
 
-   This resource block does not act unless notified by another resource to take action. Once notified, this resource block either runs immediately or is queued up to run at the end of the Chef Infra Client run.
+   This resource block does not act unless notified by another resource to take action. Once notified, this resource block either runs immediately or is queued up to run at the end of a Chef Infra Client run.
 
    .. end_tag
 
@@ -317,8 +321,8 @@ The <%= @name %> resource has the following properties:
 ``<%= p['name'] %>``
    **Ruby Type:** <%= friendly_types_list(p['is']) %><% unless pretty_default(p['default']).nil? %> | **Default Value:** ``<%= pretty_default(p['default']) %>``<% end %><% if p['required'] %> | ``REQUIRED``<% end %><% if p['deprecated'] %> | ``DEPRECATED``<% end %><% if p['name_property'] %> | **Default Value:** ``The resource block's name``<% end %>
 
-   <%= p['description'] %>
-<% unless p['introduced'].nil? -%>\n   *New in <%= branded_chef_client_name(@introduced) %> <%= p['introduced'] -%>.*<% end -%>
+<% unless p['description'].nil? %>   <%= p['description'].strip %><% end %>
+<% unless p['introduced'].nil? -%>\n\n   *New in <%= branded_chef_client_name(p['introduced']) %> <%= p['introduced'] -%>.*\n<% end -%>
 <% end %>
 <% if @properties.empty? %>This resource does not have any properties.\n<% end -%>
 <%= boilerplate_content %>

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef
 version: !ruby/object:Gem::Version
-  version: 15.2.20
+  version: 15.3.14
 platform: ruby
 authors:
 - Adam Jacob
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-09 00:00:00.000000000 Z
+date: 2019-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef-config
@@ -16,34 +16,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 15.2.20
+        version: 15.3.14
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 15.2.20
+        version: 15.3.14
 - !ruby/object:Gem::Dependency
   name: train-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.12
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: train-winrm
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.12
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: license-acceptance
   requirement: !ruby/object:Gem::Requirement
@@ -124,7 +132,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: 3.0.3
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
@@ -134,7 +142,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: 3.0.3
     - - "<"
       - !ruby/object:Gem::Version
         version: '4.0'
@@ -505,9 +513,7 @@ files:
 - bin/knife
 - chef-universal-mingw32.gemspec
 - chef.gemspec
-- lib/.DS_Store
 - lib/chef.rb
-- lib/chef/.DS_Store
 - lib/chef/action_collection.rb
 - lib/chef/api_client.rb
 - lib/chef/api_client/registration.rb
@@ -667,7 +673,6 @@ files:
 - lib/chef/digester.rb
 - lib/chef/dist.rb
 - lib/chef/dsl.rb
-- lib/chef/dsl/.DS_Store
 - lib/chef/dsl/cheffish.rb
 - lib/chef/dsl/core.rb
 - lib/chef/dsl/data_query.rb
@@ -753,7 +758,6 @@ files:
 - lib/chef/json_compat.rb
 - lib/chef/key.rb
 - lib/chef/knife.rb
-- lib/chef/knife/.DS_Store
 - lib/chef/knife/bootstrap.rb
 - lib/chef/knife/bootstrap/chef_vault_handler.rb
 - lib/chef/knife/bootstrap/client_builder.rb
@@ -904,7 +908,6 @@ files:
 - lib/chef/log/syslog.rb
 - lib/chef/log/winevt.rb
 - lib/chef/mash.rb
-- lib/chef/mixin/.DS_Store
 - lib/chef/mixin/api_version_request_handling.rb
 - lib/chef/mixin/checksum.rb
 - lib/chef/mixin/convert_to_class_name.rb
@@ -978,7 +981,6 @@ files:
 - lib/chef/powershell.rb
 - lib/chef/property.rb
 - lib/chef/provider.rb
-- lib/chef/provider/.DS_Store
 - lib/chef/provider/apt_preference.rb
 - lib/chef/provider/apt_repository.rb
 - lib/chef/provider/apt_update.rb
@@ -1026,7 +1028,6 @@ files:
 - lib/chef/provider/ohai.rb
 - lib/chef/provider/osx_profile.rb
 - lib/chef/provider/package.rb
-- lib/chef/provider/package/.DS_Store
 - lib/chef/provider/package/apt.rb
 - lib/chef/provider/package/bff.rb
 - lib/chef/provider/package/cab.rb
@@ -1037,7 +1038,6 @@ files:
 - lib/chef/provider/package/dnf/python_helper.rb
 - lib/chef/provider/package/dnf/version.rb
 - lib/chef/provider/package/dpkg.rb
-- lib/chef/provider/package/freebsd/.DS_Store
 - lib/chef/provider/package/freebsd/base.rb
 - lib/chef/provider/package/freebsd/pkgng.rb
 - lib/chef/provider/package/freebsd/port.rb
@@ -1122,6 +1122,7 @@ files:
 - lib/chef/provider/user/aix.rb
 - lib/chef/provider/user/dscl.rb
 - lib/chef/provider/user/linux.rb
+- lib/chef/provider/user/mac.rb
 - lib/chef/provider/user/pw.rb
 - lib/chef/provider/user/solaris.rb
 - lib/chef/provider/user/windows.rb
@@ -1138,7 +1139,6 @@ files:
 - lib/chef/request_id.rb
 - lib/chef/reserved_names.rb
 - lib/chef/resource.rb
-- lib/chef/resource/.DS_Store
 - lib/chef/resource/action_class.rb
 - lib/chef/resource/apt_package.rb
 - lib/chef/resource/apt_preference.rb
@@ -1172,7 +1172,6 @@ files:
 - lib/chef/resource/dsc_script.rb
 - lib/chef/resource/execute.rb
 - lib/chef/resource/file.rb
-- lib/chef/resource/file/.DS_Store
 - lib/chef/resource/file/verification.rb
 - lib/chef/resource/file/verification/systemd_unit.rb
 - lib/chef/resource/freebsd_package.rb
@@ -1256,6 +1255,7 @@ files:
 - lib/chef/resource/user/aix_user.rb
 - lib/chef/resource/user/dscl_user.rb
 - lib/chef/resource/user/linux_user.rb
+- lib/chef/resource/user/mac_user.rb
 - lib/chef/resource/user/pw_user.rb
 - lib/chef/resource/user/solaris_user.rb
 - lib/chef/resource/user/windows_user.rb
@@ -1390,8 +1390,6 @@ files:
 - lib/chef/win32/version.rb
 - lib/chef/win32_service_constants.rb
 - lib/chef/workstation_config_loader.rb
-- spec/.DS_Store
-- spec/data/.DS_Store
 - spec/data/apt/chef-integration-test-1.0/debian/changelog
 - spec/data/apt/chef-integration-test-1.0/debian/compat
 - spec/data/apt/chef-integration-test-1.0/debian/control
@@ -1489,7 +1487,6 @@ files:
 - spec/data/client.d_01/foo/bar.rb
 - spec/data/client.d_02/foo.rb/foo.txt
 - spec/data/config.rb
-- spec/data/cookbooks/.DS_Store
 - spec/data/cookbooks/angrybash/metadata.rb
 - spec/data/cookbooks/angrybash/recipes/default.rb
 - spec/data/cookbooks/apache2/files/default/apache2_module_conf_generate.pl
@@ -1505,8 +1502,6 @@ files:
 - spec/data/cookbooks/ignorken/recipes/ignoreme.rb
 - spec/data/cookbooks/ignorken/templates/ubuntu-12.10/not_me.rb
 - spec/data/cookbooks/irssi/files/default/irssi.response
-- spec/data/cookbooks/java/.DS_Store
-- spec/data/cookbooks/java/files/.DS_Store
 - spec/data/cookbooks/java/files/default/java.response
 - spec/data/cookbooks/java/metadata.rb
 - spec/data/cookbooks/name-mismatch-versionnumber/README.md
@@ -1604,15 +1599,12 @@ files:
 - spec/data/lwrp_const_scoping/resources/conflict.rb
 - spec/data/lwrp_override/providers/buck_passer.rb
 - spec/data/lwrp_override/resources/foo.rb
-- spec/data/mac_users/.DS_Store
 - spec/data/mac_users/10.9.plist.xml
 - spec/data/mac_users/10.9.shadow.xml
 - spec/data/metadata/quick_start/metadata.rb
 - spec/data/mixin/invalid_data.rb
 - spec/data/mixin/real_data.rb
 - spec/data/nested.json
-- spec/data/nodes/Tim.local.json
-- spec/data/nodes/Tims-MBP.local.json
 - spec/data/nodes/default.rb
 - spec/data/nodes/test.example.com.rb
 - spec/data/nodes/test.rb
@@ -1649,8 +1641,6 @@ files:
 - spec/data/root_alias_cookbooks/simple/attributes.rb
 - spec/data/root_alias_cookbooks/simple/metadata.rb
 - spec/data/root_alias_cookbooks/simple/recipe.rb
-- spec/data/run_context/.DS_Store
-- spec/data/run_context/cookbooks/.DS_Store
 - spec/data/run_context/cookbooks/circular-dep1/attributes/default.rb
 - spec/data/run_context/cookbooks/circular-dep1/definitions/circular_dep1_res.rb
 - spec/data/run_context/cookbooks/circular-dep1/libraries/lib.rb
@@ -1759,7 +1749,6 @@ files:
 - spec/data/windows_certificates/test.p7b
 - spec/data/windows_certificates/test.pem
 - spec/data/windows_certificates/test.pfx
-- spec/functional/.DS_Store
 - spec/functional/application_spec.rb
 - spec/functional/assets/PkgA.1.0.0.0.bff
 - spec/functional/assets/PkgA.2.0.0.0.bff
@@ -1831,7 +1820,6 @@ files:
 - spec/functional/provider/remote_file/cache_control_data_spec.rb
 - spec/functional/provider/whyrun_safe_ruby_block_spec.rb
 - spec/functional/rebooter_spec.rb
-- spec/functional/resource/.DS_Store
 - spec/functional/resource/aix_service_spec.rb
 - spec/functional/resource/aixinit_service_spec.rb
 - spec/functional/resource/apt_package_spec.rb
@@ -1867,6 +1855,7 @@ files:
 - spec/functional/resource/template_spec.rb
 - spec/functional/resource/timezone_spec.rb
 - spec/functional/resource/user/dscl_spec.rb
+- spec/functional/resource/user/mac_user_spec.rb
 - spec/functional/resource/user/windows_spec.rb
 - spec/functional/resource/windows_certificate_spec.rb
 - spec/functional/resource/windows_env_spec.rb
@@ -1880,7 +1869,6 @@ files:
 - spec/functional/run_lock_spec.rb
 - spec/functional/shell_spec.rb
 - spec/functional/tiny_server_spec.rb
-- spec/functional/util/.DS_Store
 - spec/functional/util/path_helper_spec.rb
 - spec/functional/util/powershell/cmdlet_spec.rb
 - spec/functional/version_spec.rb
@@ -1891,7 +1879,6 @@ files:
 - spec/functional/win32/sid_spec.rb
 - spec/functional/win32/version_info_spec.rb
 - spec/functional/win32/versions_spec.rb
-- spec/integration/.DS_Store
 - spec/integration/client/client_spec.rb
 - spec/integration/client/exit_code_spec.rb
 - spec/integration/client/ipv6_spec.rb
@@ -1970,15 +1957,14 @@ files:
 - spec/integration/recipes/resource_action_spec.rb
 - spec/integration/recipes/resource_converge_if_changed_spec.rb
 - spec/integration/recipes/resource_load_spec.rb
+- spec/integration/recipes/unified_mode_spec.rb
 - spec/integration/solo/solo_spec.rb
 - spec/rcov.opts
 - spec/scripts/ssl-serve.rb
 - spec/spec_helper.rb
-- spec/stress/.DS_Store
 - spec/stress/win32/file_spec.rb
 - spec/stress/win32/memory_spec.rb
 - spec/stress/win32/security_spec.rb
-- spec/support/.DS_Store
 - spec/support/chef_helpers.rb
 - spec/support/key_helpers.rb
 - spec/support/lib/chef/provider/easy.rb
@@ -2010,7 +1996,6 @@ files:
 - spec/support/shared/functional/securable_resource_with_reporting.rb
 - spec/support/shared/functional/win32_service.rb
 - spec/support/shared/functional/windows_script.rb
-- spec/support/shared/integration/app_server_support.rb
 - spec/support/shared/integration/integration_helper.rb
 - spec/support/shared/integration/knife_support.rb
 - spec/support/shared/matchers/exit_with_code.rb
@@ -2032,7 +2017,6 @@ files:
 - spec/support/shared/unit/user_and_client_shared.rb
 - spec/support/shared/unit/windows_script_resource.rb
 - spec/tiny_server.rb
-- spec/unit/.DS_Store
 - spec/unit/action_collection_spec.rb
 - spec/unit/api_client/registration_spec.rb
 - spec/unit/api_client_spec.rb
@@ -2389,6 +2373,7 @@ files:
 - spec/unit/provider/user/aix_spec.rb
 - spec/unit/provider/user/dscl_spec.rb
 - spec/unit/provider/user/linux_spec.rb
+- spec/unit/provider/user/mac_spec.rb
 - spec/unit/provider/user/pw_spec.rb
 - spec/unit/provider/user/solaris_spec.rb
 - spec/unit/provider/user/windows_spec.rb
@@ -2594,7 +2579,6 @@ files:
 - spec/unit/win32/registry_spec.rb
 - spec/unit/win32/security_spec.rb
 - spec/unit/windows_service_spec.rb
-- tasks/.DS_Store
 - tasks/announce.rb
 - tasks/bin/run_external_test
 - tasks/dependencies.rb