chef 14.2.0 → 14.3.37

Sign up to get free protection for your applications and to get access to all the features.
Files changed (842) hide show
  1. checksums.yaml +4 -4
  2. data/CONTRIBUTING.md +13 -12
  3. data/Gemfile +15 -0
  4. data/README.md +36 -40
  5. data/Rakefile +1 -1
  6. data/VERSION +1 -1
  7. data/bin/chef-apply +0 -1
  8. data/bin/chef-client +1 -2
  9. data/bin/chef-shell +1 -6
  10. data/bin/chef-solo +1 -2
  11. data/bin/knife +1 -2
  12. data/chef-universal-mingw32.gemspec +2 -2
  13. data/chef.gemspec +1 -1
  14. data/distro/ruby_bin_folder/Chef.PowerShell.Wrapper.dll +0 -0
  15. data/distro/ruby_bin_folder/Chef.PowerShell.dll +0 -0
  16. data/distro/{powershell/chef → ruby_bin_folder}/Newtonsoft.Json.dll +0 -0
  17. data/lib/chef/api_client.rb +10 -10
  18. data/lib/chef/api_client/registration.rb +5 -5
  19. data/lib/chef/api_client_v1.rb +15 -15
  20. data/lib/chef/application.rb +1 -1
  21. data/lib/chef/application/apply.rb +56 -56
  22. data/lib/chef/application/client.rb +169 -170
  23. data/lib/chef/application/exit_code.rb +2 -2
  24. data/lib/chef/application/knife.rb +79 -78
  25. data/lib/chef/application/solo.rb +120 -120
  26. data/lib/chef/application/windows_service.rb +21 -21
  27. data/lib/chef/application/windows_service_manager.rb +39 -39
  28. data/lib/chef/audit/audit_event_proxy.rb +6 -6
  29. data/lib/chef/audit/audit_reporter.rb +2 -2
  30. data/lib/chef/audit/control_group_data.rb +15 -15
  31. data/lib/chef/audit/runner.rb +1 -1
  32. data/lib/chef/chef_class.rb +16 -8
  33. data/lib/chef/chef_fs/chef_fs_data_store.rb +8 -8
  34. data/lib/chef/chef_fs/config.rb +2 -2
  35. data/lib/chef/chef_fs/file_system/chef_server/acl_entry.rb +1 -1
  36. data/lib/chef/chef_fs/file_system/chef_server/acls_dir.rb +1 -1
  37. data/lib/chef/chef_fs/file_system/chef_server/chef_server_root_dir.rb +2 -2
  38. data/lib/chef/chef_fs/file_system/chef_server/cookbooks_dir.rb +1 -1
  39. data/lib/chef/chef_fs/file_system/chef_server/organization_invites_entry.rb +1 -1
  40. data/lib/chef/chef_fs/file_system/chef_server/organization_members_entry.rb +1 -1
  41. data/lib/chef/chef_fs/file_system/chef_server/rest_list_entry.rb +1 -1
  42. data/lib/chef/chef_fs/file_system/chef_server/versioned_cookbooks_dir.rb +1 -1
  43. data/lib/chef/chef_fs/file_system/repository/acls_dir.rb +1 -1
  44. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_cookbook_dir.rb +1 -1
  45. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_cookbook_entry.rb +3 -3
  46. data/lib/chef/chef_fs/file_system/repository/chef_repository_file_system_root_dir.rb +2 -2
  47. data/lib/chef/chef_fs/file_system/repository/directory.rb +3 -3
  48. data/lib/chef/chef_fs/file_system/repository/file_system_entry.rb +3 -3
  49. data/lib/chef/chef_fs/knife.rb +6 -6
  50. data/lib/chef/chef_fs/parallelizer.rb +1 -1
  51. data/lib/chef/client.rb +3 -0
  52. data/lib/chef/cookbook/cookbook_version_loader.rb +1 -1
  53. data/lib/chef/cookbook/file_system_file_vendor.rb +1 -1
  54. data/lib/chef/cookbook/manifest_v0.rb +1 -1
  55. data/lib/chef/cookbook/metadata.rb +61 -61
  56. data/lib/chef/cookbook/remote_file_vendor.rb +1 -1
  57. data/lib/chef/cookbook/synchronizer.rb +2 -2
  58. data/lib/chef/cookbook_loader.rb +3 -3
  59. data/lib/chef/cookbook_manifest.rb +5 -5
  60. data/lib/chef/cookbook_site_streaming_uploader.rb +5 -5
  61. data/lib/chef/cookbook_uploader.rb +2 -2
  62. data/lib/chef/cookbook_version.rb +2 -2
  63. data/lib/chef/data_bag.rb +3 -3
  64. data/lib/chef/data_bag_item.rb +2 -2
  65. data/lib/chef/deprecated.rb +110 -176
  66. data/lib/chef/dsl/audit.rb +1 -1
  67. data/lib/chef/dsl/definitions.rb +1 -1
  68. data/lib/chef/dsl/platform_introspection.rb +5 -0
  69. data/lib/chef/dsl/reboot_pending.rb +1 -1
  70. data/lib/chef/encrypted_data_bag_item.rb +2 -2
  71. data/lib/chef/encrypted_data_bag_item/check_encrypted.rb +1 -1
  72. data/lib/chef/encrypted_data_bag_item/encryptor.rb +1 -1
  73. data/lib/chef/environment.rb +10 -10
  74. data/lib/chef/event_loggers/windows_eventlog.rb +21 -21
  75. data/lib/chef/exceptions.rb +3 -3
  76. data/lib/chef/file_cache.rb +18 -16
  77. data/lib/chef/formatters/base.rb +9 -10
  78. data/lib/chef/formatters/doc.rb +12 -16
  79. data/lib/chef/formatters/error_inspectors/api_error_formatting.rb +51 -51
  80. data/lib/chef/formatters/error_inspectors/cookbook_resolve_error_inspector.rb +10 -10
  81. data/lib/chef/formatters/error_inspectors/node_load_error_inspector.rb +13 -13
  82. data/lib/chef/formatters/error_inspectors/registration_error_inspector.rb +39 -39
  83. data/lib/chef/formatters/error_inspectors/resource_failure_inspector.rb +1 -1
  84. data/lib/chef/formatters/error_inspectors/run_list_expansion_error_inspector.rb +16 -16
  85. data/lib/chef/formatters/indentable_output_stream.rb +4 -4
  86. data/lib/chef/guard_interpreter/resource_guard_interpreter.rb +3 -3
  87. data/lib/chef/handler/json_file.rb +1 -1
  88. data/lib/chef/http/auth_credentials.rb +2 -2
  89. data/lib/chef/http/authenticator.rb +6 -6
  90. data/lib/chef/http/cookie_manager.rb +1 -1
  91. data/lib/chef/http/http_request.rb +3 -3
  92. data/lib/chef/http/json_input.rb +1 -1
  93. data/lib/chef/http/json_to_model_output.rb +1 -1
  94. data/lib/chef/http/socketless_chef_zero_client.rb +1 -1
  95. data/lib/chef/json_compat.rb +1 -1
  96. data/lib/chef/key.rb +9 -9
  97. data/lib/chef/knife.rb +5 -5
  98. data/lib/chef/knife/bootstrap.rb +116 -116
  99. data/lib/chef/knife/bootstrap/client_builder.rb +1 -1
  100. data/lib/chef/knife/client_bulk_delete.rb +3 -3
  101. data/lib/chef/knife/client_create.rb +17 -17
  102. data/lib/chef/knife/client_delete.rb +3 -3
  103. data/lib/chef/knife/client_list.rb +3 -3
  104. data/lib/chef/knife/client_reregister.rb +3 -3
  105. data/lib/chef/knife/config_get.rb +126 -0
  106. data/lib/chef/knife/configure.rb +25 -25
  107. data/lib/chef/knife/cookbook_bulk_delete.rb +1 -1
  108. data/lib/chef/knife/cookbook_delete.rb +2 -2
  109. data/lib/chef/knife/cookbook_download.rb +11 -11
  110. data/lib/chef/knife/cookbook_list.rb +6 -6
  111. data/lib/chef/knife/cookbook_metadata.rb +7 -8
  112. data/lib/chef/knife/cookbook_metadata_from_file.rb +0 -1
  113. data/lib/chef/knife/cookbook_show.rb +16 -16
  114. data/lib/chef/knife/cookbook_site_download.rb +11 -10
  115. data/lib/chef/knife/cookbook_site_install.rb +24 -24
  116. data/lib/chef/knife/cookbook_site_list.rb +8 -8
  117. data/lib/chef/knife/cookbook_site_search.rb +6 -5
  118. data/lib/chef/knife/cookbook_site_share.rb +20 -19
  119. data/lib/chef/knife/cookbook_site_show.rb +6 -5
  120. data/lib/chef/knife/cookbook_site_unshare.rb +5 -5
  121. data/lib/chef/knife/cookbook_test.rb +8 -8
  122. data/lib/chef/knife/cookbook_upload.rb +32 -32
  123. data/lib/chef/knife/core/bootstrap_context.rb +7 -7
  124. data/lib/chef/knife/core/cookbook_scm_repo.rb +1 -1
  125. data/lib/chef/knife/core/generic_presenter.rb +7 -7
  126. data/lib/chef/knife/core/hashed_command_loader.rb +1 -1
  127. data/lib/chef/knife/core/node_presenter.rb +37 -37
  128. data/lib/chef/knife/core/status_presenter.rb +11 -11
  129. data/lib/chef/knife/data_bag_from_file.rb +4 -4
  130. data/lib/chef/knife/data_bag_list.rb +3 -3
  131. data/lib/chef/knife/data_bag_secret_options.rb +13 -13
  132. data/lib/chef/knife/delete.rb +29 -13
  133. data/lib/chef/knife/deps.rb +25 -9
  134. data/lib/chef/knife/diff.rb +30 -14
  135. data/lib/chef/knife/download.rb +39 -23
  136. data/lib/chef/knife/edit.rb +19 -3
  137. data/lib/chef/knife/environment_compare.rb +8 -8
  138. data/lib/chef/knife/environment_create.rb +3 -3
  139. data/lib/chef/knife/environment_from_file.rb +5 -3
  140. data/lib/chef/knife/environment_list.rb +3 -3
  141. data/lib/chef/knife/exec.rb +7 -7
  142. data/lib/chef/knife/key_create.rb +4 -4
  143. data/lib/chef/knife/key_create_base.rb +12 -12
  144. data/lib/chef/knife/key_edit.rb +5 -5
  145. data/lib/chef/knife/key_edit_base.rb +15 -15
  146. data/lib/chef/knife/key_list.rb +3 -3
  147. data/lib/chef/knife/key_list_base.rb +9 -9
  148. data/lib/chef/knife/list.rb +35 -19
  149. data/lib/chef/knife/node_edit.rb +4 -4
  150. data/lib/chef/knife/node_list.rb +3 -3
  151. data/lib/chef/knife/node_run_list_add.rb +6 -6
  152. data/lib/chef/knife/node_show.rb +6 -6
  153. data/lib/chef/knife/osc_user_create.rb +13 -13
  154. data/lib/chef/knife/osc_user_list.rb +3 -3
  155. data/lib/chef/knife/osc_user_reregister.rb +3 -3
  156. data/lib/chef/knife/raw.rb +32 -16
  157. data/lib/chef/knife/role_create.rb +3 -3
  158. data/lib/chef/knife/role_env_run_list_add.rb +4 -3
  159. data/lib/chef/knife/role_env_run_list_remove.rb +2 -2
  160. data/lib/chef/knife/role_env_run_list_replace.rb +1 -0
  161. data/lib/chef/knife/role_list.rb +3 -3
  162. data/lib/chef/knife/role_run_list_add.rb +4 -3
  163. data/lib/chef/knife/role_run_list_remove.rb +2 -2
  164. data/lib/chef/knife/role_run_list_replace.rb +1 -0
  165. data/lib/chef/knife/search.rb +23 -23
  166. data/lib/chef/knife/serve.rb +22 -6
  167. data/lib/chef/knife/show.rb +19 -3
  168. data/lib/chef/knife/ssh.rb +68 -68
  169. data/lib/chef/knife/ssl_check.rb +31 -31
  170. data/lib/chef/knife/ssl_fetch.rb +5 -5
  171. data/lib/chef/knife/status.rb +11 -11
  172. data/lib/chef/knife/upload.rb +41 -25
  173. data/lib/chef/knife/user_create.rb +28 -28
  174. data/lib/chef/knife/user_delete.rb +9 -9
  175. data/lib/chef/knife/user_edit.rb +9 -9
  176. data/lib/chef/knife/user_list.rb +3 -3
  177. data/lib/chef/knife/user_reregister.rb +12 -12
  178. data/lib/chef/knife/user_show.rb +9 -9
  179. data/lib/chef/knife/xargs.rb +52 -36
  180. data/lib/chef/log.rb +10 -8
  181. data/lib/chef/log/winevt.rb +21 -21
  182. data/lib/chef/mixin/api_version_request_handling.rb +6 -6
  183. data/lib/chef/mixin/deep_merge.rb +1 -1
  184. data/lib/chef/mixin/deprecation.rb +2 -2
  185. data/lib/chef/mixin/params_validate.rb +9 -9
  186. data/lib/chef/mixin/properties.rb +2 -2
  187. data/lib/chef/mixin/securable.rb +11 -11
  188. data/lib/chef/mixin/shell_out.rb +138 -82
  189. data/lib/chef/mixin/wide_string.rb +5 -23
  190. data/lib/chef/mixin/windows_env_helper.rb +1 -1
  191. data/lib/chef/mixin/xml_escape.rb +3 -3
  192. data/lib/chef/node.rb +15 -15
  193. data/lib/chef/node/attribute.rb +6 -6
  194. data/lib/chef/node/attribute_collections.rb +2 -2
  195. data/lib/chef/node/mixin/deep_merge_cache.rb +1 -1
  196. data/lib/chef/node/mixin/immutablize_array.rb +2 -2
  197. data/lib/chef/node/mixin/immutablize_hash.rb +2 -2
  198. data/lib/chef/node_map.rb +77 -3
  199. data/lib/chef/org.rb +8 -8
  200. data/lib/chef/policy_builder/expand_node_object.rb +1 -1
  201. data/lib/chef/powershell.rb +9 -7
  202. data/lib/chef/property.rb +14 -14
  203. data/lib/chef/provider/apt_update.rb +2 -2
  204. data/lib/chef/provider/cron.rb +3 -3
  205. data/lib/chef/provider/cron/unix.rb +2 -2
  206. data/lib/chef/provider/dsc_resource.rb +1 -1
  207. data/lib/chef/provider/dsc_script.rb +8 -8
  208. data/lib/chef/provider/execute.rb +1 -1
  209. data/lib/chef/provider/group/aix.rb +6 -6
  210. data/lib/chef/provider/group/dscl.rb +1 -1
  211. data/lib/chef/provider/group/gpasswd.rb +4 -4
  212. data/lib/chef/provider/group/groupadd.rb +3 -3
  213. data/lib/chef/provider/group/groupmod.rb +6 -6
  214. data/lib/chef/provider/group/pw.rb +4 -4
  215. data/lib/chef/provider/group/suse.rb +2 -2
  216. data/lib/chef/provider/group/usermod.rb +1 -1
  217. data/lib/chef/provider/http_request.rb +6 -6
  218. data/lib/chef/provider/ifconfig.rb +4 -4
  219. data/lib/chef/provider/ifconfig/aix.rb +1 -1
  220. data/lib/chef/provider/mdadm.rb +1 -1
  221. data/lib/chef/provider/mount/mount.rb +1 -1
  222. data/lib/chef/provider/mount/windows.rb +7 -7
  223. data/lib/chef/provider/package.rb +3 -18
  224. data/lib/chef/provider/package/apt.rb +4 -4
  225. data/lib/chef/provider/package/bff.rb +9 -9
  226. data/lib/chef/provider/package/chocolatey.rb +7 -7
  227. data/lib/chef/provider/package/dnf.rb +2 -2
  228. data/lib/chef/provider/package/dpkg.rb +6 -6
  229. data/lib/chef/provider/package/freebsd/base.rb +2 -2
  230. data/lib/chef/provider/package/freebsd/pkg.rb +6 -6
  231. data/lib/chef/provider/package/freebsd/pkgng.rb +5 -5
  232. data/lib/chef/provider/package/freebsd/port.rb +4 -4
  233. data/lib/chef/provider/package/homebrew.rb +1 -1
  234. data/lib/chef/provider/package/ips.rb +6 -6
  235. data/lib/chef/provider/package/macports.rb +6 -6
  236. data/lib/chef/provider/package/msu.rb +1 -1
  237. data/lib/chef/provider/package/openbsd.rb +5 -5
  238. data/lib/chef/provider/package/pacman.rb +4 -4
  239. data/lib/chef/provider/package/paludis.rb +3 -3
  240. data/lib/chef/provider/package/portage.rb +5 -5
  241. data/lib/chef/provider/package/powershell.rb +6 -2
  242. data/lib/chef/provider/package/rpm.rb +10 -10
  243. data/lib/chef/provider/package/rubygems.rb +4 -4
  244. data/lib/chef/provider/package/smartos.rb +4 -4
  245. data/lib/chef/provider/package/solaris.rb +9 -9
  246. data/lib/chef/provider/package/windows.rb +4 -3
  247. data/lib/chef/provider/package/yum.rb +2 -2
  248. data/lib/chef/provider/package/zypper.rb +4 -4
  249. data/lib/chef/provider/powershell_script.rb +73 -73
  250. data/lib/chef/provider/reboot.rb +4 -4
  251. data/lib/chef/provider/registry_key.rb +4 -4
  252. data/lib/chef/provider/remote_file/cache_control_data.rb +2 -2
  253. data/lib/chef/provider/remote_file/sftp.rb +1 -1
  254. data/lib/chef/provider/resource_update.rb +1 -1
  255. data/lib/chef/provider/route.rb +2 -2
  256. data/lib/chef/provider/service/openbsd.rb +3 -3
  257. data/lib/chef/provider/service/redhat.rb +1 -1
  258. data/lib/chef/provider/service/simple.rb +1 -0
  259. data/lib/chef/provider/service/solaris.rb +1 -1
  260. data/lib/chef/provider/service/systemd.rb +2 -2
  261. data/lib/chef/provider/service/windows.rb +17 -17
  262. data/lib/chef/provider/subversion.rb +3 -3
  263. data/lib/chef/provider/systemd_unit.rb +2 -2
  264. data/lib/chef/provider/template/content.rb +1 -1
  265. data/lib/chef/provider/user/aix.rb +6 -6
  266. data/lib/chef/provider/user/dscl.rb +6 -6
  267. data/lib/chef/provider/user/linux.rb +6 -6
  268. data/lib/chef/provider/user/pw.rb +5 -5
  269. data/lib/chef/provider/user/solaris.rb +6 -6
  270. data/lib/chef/provider/user/useradd.rb +7 -7
  271. data/lib/chef/provider/windows_env.rb +6 -6
  272. data/lib/chef/provider/windows_task.rb +22 -24
  273. data/lib/chef/resource.rb +26 -4
  274. data/lib/chef/resource/chef_handler.rb +2 -0
  275. data/lib/chef/resource/chocolatey_config.rb +83 -0
  276. data/lib/chef/resource/chocolatey_source.rb +95 -0
  277. data/lib/chef/resource/cron.rb +5 -5
  278. data/lib/chef/resource/dsc_script.rb +12 -11
  279. data/lib/chef/resource/execute.rb +1 -1
  280. data/lib/chef/resource/file/verification.rb +1 -1
  281. data/lib/chef/resource/freebsd_package.rb +3 -1
  282. data/lib/chef/resource/group.rb +2 -2
  283. data/lib/chef/resource/homebrew_package.rb +2 -1
  284. data/lib/chef/resource/homebrew_tap.rb +1 -1
  285. data/lib/chef/resource/hostname.rb +23 -7
  286. data/lib/chef/resource/http_request.rb +6 -3
  287. data/lib/chef/resource/ifconfig.rb +57 -17
  288. data/lib/chef/resource/ips_package.rb +3 -1
  289. data/lib/chef/resource/kernel_module.rb +129 -0
  290. data/lib/chef/resource/launchd.rb +205 -98
  291. data/lib/chef/resource/log.rb +7 -2
  292. data/lib/chef/resource/mdadm.rb +29 -8
  293. data/lib/chef/resource/ohai.rb +2 -0
  294. data/lib/chef/resource/ohai_hint.rb +5 -3
  295. data/lib/chef/resource/openssl_dhparam.rb +1 -1
  296. data/lib/chef/resource/openssl_rsa_private_key.rb +2 -0
  297. data/lib/chef/resource/paludis_package.rb +1 -1
  298. data/lib/chef/resource/portage_package.rb +2 -0
  299. data/lib/chef/resource/powershell_package.rb +2 -0
  300. data/lib/chef/resource/powershell_package_source.rb +165 -0
  301. data/lib/chef/resource/powershell_script.rb +2 -2
  302. data/lib/chef/resource/registry_key.rb +1 -1
  303. data/lib/chef/resource/remote_directory.rb +3 -3
  304. data/lib/chef/resource/remote_file.rb +2 -2
  305. data/lib/chef/resource/resource_notification.rb +16 -16
  306. data/lib/chef/resource/rhsm_errata.rb +1 -1
  307. data/lib/chef/resource/rhsm_errata_level.rb +1 -1
  308. data/lib/chef/resource/rhsm_register.rb +4 -4
  309. data/lib/chef/resource/rhsm_repo.rb +2 -2
  310. data/lib/chef/resource/rhsm_subscription.rb +2 -2
  311. data/lib/chef/resource/script.rb +1 -1
  312. data/lib/chef/resource/service.rb +18 -18
  313. data/lib/chef/resource/ssh_known_hosts_entry.rb +146 -0
  314. data/lib/chef/resource/sudo.rb +4 -4
  315. data/lib/chef/resource/support/ssh_known_hosts.erb +3 -0
  316. data/lib/chef/resource/sysctl.rb +9 -5
  317. data/lib/chef/resource/template.rb +1 -1
  318. data/lib/chef/resource/user.rb +15 -15
  319. data/lib/chef/resource/windows_feature_dism.rb +10 -9
  320. data/lib/chef/resource/windows_feature_powershell.rb +24 -13
  321. data/lib/chef/resource/windows_script.rb +1 -1
  322. data/lib/chef/resource/windows_service.rb +2 -2
  323. data/lib/chef/resource/windows_task.rb +3 -3
  324. data/lib/chef/resource_definition.rb +1 -1
  325. data/lib/chef/resource_inspector.rb +1 -0
  326. data/lib/chef/resource_reporter.rb +4 -4
  327. data/lib/chef/resources.rb +5 -0
  328. data/lib/chef/role.rb +8 -8
  329. data/lib/chef/run_context.rb +8 -8
  330. data/lib/chef/run_list/run_list_expansion.rb +6 -6
  331. data/lib/chef/run_list/run_list_item.rb +1 -1
  332. data/lib/chef/run_list/versioned_recipe_list.rb +3 -3
  333. data/lib/chef/run_status.rb +10 -10
  334. data/lib/chef/shell.rb +60 -60
  335. data/lib/chef/shell/ext.rb +151 -151
  336. data/lib/chef/shell/shell_session.rb +2 -2
  337. data/lib/chef/user.rb +11 -11
  338. data/lib/chef/user_v1.rb +26 -26
  339. data/lib/chef/util/backup.rb +2 -2
  340. data/lib/chef/util/diff.rb +1 -1
  341. data/lib/chef/util/dsc/configuration_generator.rb +11 -11
  342. data/lib/chef/util/dsc/lcm_output_parser.rb +1 -1
  343. data/lib/chef/util/file_edit.rb +14 -14
  344. data/lib/chef/util/powershell/cmdlet.rb +4 -4
  345. data/lib/chef/util/selinux.rb +2 -2
  346. data/lib/chef/util/windows/net_group.rb +1 -1
  347. data/lib/chef/util/windows/net_use.rb +3 -3
  348. data/lib/chef/util/windows/net_user.rb +12 -12
  349. data/lib/chef/util/windows/volume.rb +2 -2
  350. data/lib/chef/version.rb +3 -3
  351. data/lib/chef/version_constraint.rb +3 -3
  352. data/lib/chef/win32/api.rb +6 -6
  353. data/lib/chef/win32/api/error.rb +2 -2
  354. data/lib/chef/win32/api/file.rb +12 -12
  355. data/lib/chef/win32/api/net.rb +58 -58
  356. data/lib/chef/win32/registry.rb +8 -8
  357. data/lib/chef/win32/security.rb +6 -6
  358. data/lib/chef/win32/security/securable_object.rb +10 -10
  359. data/lib/chef/win32/unicode.rb +6 -0
  360. data/lib/chef/win32/version.rb +16 -16
  361. data/spec/functional/audit/rspec_formatter_spec.rb +1 -1
  362. data/spec/functional/audit/runner_spec.rb +1 -1
  363. data/spec/functional/dsl/reboot_pending_spec.rb +3 -3
  364. data/spec/functional/dsl/registry_helper_spec.rb +3 -3
  365. data/spec/functional/http/simple_spec.rb +1 -1
  366. data/spec/functional/knife/exec_spec.rb +1 -1
  367. data/spec/functional/knife/ssh_spec.rb +2 -2
  368. data/spec/functional/mixin/shell_out_spec.rb +8 -4
  369. data/spec/functional/rebooter_spec.rb +6 -6
  370. data/spec/functional/resource/aixinit_service_spec.rb +2 -2
  371. data/spec/functional/resource/apt_package_spec.rb +17 -17
  372. data/spec/functional/resource/bash_spec.rb +1 -1
  373. data/spec/functional/resource/bff_spec.rb +1 -1
  374. data/spec/functional/resource/cron_spec.rb +1 -1
  375. data/spec/functional/resource/dnf_package_spec.rb +7 -7
  376. data/spec/functional/resource/dsc_script_spec.rb +94 -94
  377. data/spec/functional/resource/execute_spec.rb +4 -4
  378. data/spec/functional/resource/file_spec.rb +1 -1
  379. data/spec/functional/resource/git_spec.rb +19 -19
  380. data/spec/functional/resource/ifconfig_spec.rb +5 -5
  381. data/spec/functional/resource/link_spec.rb +1 -1
  382. data/spec/functional/resource/mount_spec.rb +2 -2
  383. data/spec/functional/resource/powershell_script_spec.rb +13 -13
  384. data/spec/functional/resource/reboot_spec.rb +3 -3
  385. data/spec/functional/resource/registry_spec.rb +82 -82
  386. data/spec/functional/resource/remote_file_spec.rb +2 -2
  387. data/spec/functional/resource/rpm_spec.rb +1 -1
  388. data/spec/functional/resource/template_spec.rb +5 -5
  389. data/spec/functional/resource/user/dscl_spec.rb +3 -3
  390. data/spec/functional/resource/windows_env_spec.rb +1 -1
  391. data/spec/functional/resource/windows_service_spec.rb +1 -1
  392. data/spec/functional/resource/windows_task_spec.rb +92 -38
  393. data/spec/functional/resource/yum_package_spec.rb +8 -8
  394. data/spec/functional/run_lock_spec.rb +4 -4
  395. data/spec/functional/shell_spec.rb +1 -1
  396. data/spec/functional/util/powershell/cmdlet_spec.rb +7 -7
  397. data/spec/functional/version_spec.rb +1 -1
  398. data/spec/functional/win32/crypto_spec.rb +9 -9
  399. data/spec/functional/win32/registry_spec.rb +66 -66
  400. data/spec/integration/client/client_spec.rb +219 -219
  401. data/spec/integration/client/exit_code_spec.rb +19 -19
  402. data/spec/integration/client/ipv6_spec.rb +36 -36
  403. data/spec/integration/knife/chef_fs_data_store_spec.rb +130 -130
  404. data/spec/integration/knife/chef_repo_path_spec.rb +418 -418
  405. data/spec/integration/knife/chef_repository_file_system_spec.rb +35 -35
  406. data/spec/integration/knife/chefignore_spec.rb +88 -88
  407. data/spec/integration/knife/client_bulk_delete_spec.rb +49 -49
  408. data/spec/integration/knife/client_create_spec.rb +5 -5
  409. data/spec/integration/knife/client_delete_spec.rb +13 -13
  410. data/spec/integration/knife/client_key_delete_spec.rb +2 -2
  411. data/spec/integration/knife/client_key_list_spec.rb +4 -4
  412. data/spec/integration/knife/client_list_spec.rb +8 -8
  413. data/spec/integration/knife/common_options_spec.rb +31 -31
  414. data/spec/integration/knife/config_get_spec.rb +183 -0
  415. data/spec/integration/knife/cookbook_api_ipv6_spec.rb +38 -38
  416. data/spec/integration/knife/cookbook_bulk_delete_spec.rb +14 -14
  417. data/spec/integration/knife/cookbook_download_spec.rb +12 -12
  418. data/spec/integration/knife/cookbook_list_spec.rb +8 -8
  419. data/spec/integration/knife/cookbook_show_spec.rb +81 -81
  420. data/spec/integration/knife/cookbook_upload_spec.rb +24 -24
  421. data/spec/integration/knife/data_bag_delete_spec.rb +8 -8
  422. data/spec/integration/knife/data_bag_from_file_spec.rb +47 -47
  423. data/spec/integration/knife/data_bag_list_spec.rb +4 -4
  424. data/spec/integration/knife/data_bag_show_spec.rb +7 -7
  425. data/spec/integration/knife/delete_spec.rb +593 -593
  426. data/spec/integration/knife/deps_spec.rb +185 -185
  427. data/spec/integration/knife/diff_spec.rb +116 -116
  428. data/spec/integration/knife/download_spec.rb +510 -510
  429. data/spec/integration/knife/environment_compare_spec.rb +15 -15
  430. data/spec/integration/knife/environment_from_file_spec.rb +59 -59
  431. data/spec/integration/knife/environment_list_spec.rb +4 -4
  432. data/spec/integration/knife/environment_show_spec.rb +25 -25
  433. data/spec/integration/knife/list_spec.rb +731 -731
  434. data/spec/integration/knife/node_bulk_delete_spec.rb +8 -8
  435. data/spec/integration/knife/node_delete_spec.rb +6 -6
  436. data/spec/integration/knife/node_environment_set_spec.rb +3 -3
  437. data/spec/integration/knife/node_from_file_spec.rb +16 -16
  438. data/spec/integration/knife/node_list_spec.rb +5 -5
  439. data/spec/integration/knife/raw_spec.rb +117 -117
  440. data/spec/integration/knife/role_bulk_delete_spec.rb +8 -8
  441. data/spec/integration/knife/role_delete_spec.rb +6 -6
  442. data/spec/integration/knife/role_from_file_spec.rb +42 -42
  443. data/spec/integration/knife/role_list_spec.rb +5 -5
  444. data/spec/integration/knife/role_show_spec.rb +9 -9
  445. data/spec/integration/knife/show_spec.rb +57 -57
  446. data/spec/integration/knife/upload_spec.rb +396 -396
  447. data/spec/integration/recipes/accumulator_spec.rb +2 -2
  448. data/spec/integration/recipes/lwrp_inline_resources_spec.rb +8 -8
  449. data/spec/integration/recipes/lwrp_spec.rb +12 -12
  450. data/spec/integration/recipes/notifies_spec.rb +167 -167
  451. data/spec/integration/recipes/notifying_block_spec.rb +2 -2
  452. data/spec/integration/recipes/remote_directory.rb +1 -1
  453. data/spec/integration/recipes/resource_converge_if_changed_spec.rb +99 -99
  454. data/spec/integration/recipes/resource_load_spec.rb +8 -8
  455. data/spec/integration/solo/solo_spec.rb +40 -40
  456. data/spec/scripts/ssl-serve.rb +12 -12
  457. data/spec/spec_helper.rb +73 -73
  458. data/spec/stress/win32/file_spec.rb +2 -2
  459. data/spec/stress/win32/security_spec.rb +2 -2
  460. data/spec/support/platform_helpers.rb +1 -1
  461. data/spec/support/shared/context/client.rb +25 -25
  462. data/spec/support/shared/functional/securable_resource.rb +13 -13
  463. data/spec/support/shared/functional/securable_resource_with_reporting.rb +6 -6
  464. data/spec/support/shared/functional/win32_service.rb +5 -5
  465. data/spec/support/shared/functional/windows_script.rb +3 -3
  466. data/spec/support/shared/integration/app_server_support.rb +3 -3
  467. data/spec/support/shared/integration/integration_helper.rb +2 -2
  468. data/spec/support/shared/integration/knife_support.rb +9 -3
  469. data/spec/support/shared/unit/api_error_inspector.rb +6 -6
  470. data/spec/support/shared/unit/api_versioning.rb +2 -2
  471. data/spec/support/shared/unit/execute_resource.rb +2 -2
  472. data/spec/support/shared/unit/provider/file.rb +12 -12
  473. data/spec/support/shared/unit/provider/useradd_based_user_provider.rb +34 -34
  474. data/spec/support/shared/unit/user_and_client_shared.rb +3 -3
  475. data/spec/tiny_server.rb +8 -8
  476. data/spec/unit/api_client/registration_spec.rb +30 -30
  477. data/spec/unit/api_client_spec.rb +6 -6
  478. data/spec/unit/api_client_v1_spec.rb +6 -6
  479. data/spec/unit/application/apply_spec.rb +4 -4
  480. data/spec/unit/application/client_spec.rb +11 -11
  481. data/spec/unit/application/knife_spec.rb +3 -3
  482. data/spec/unit/application/solo_spec.rb +5 -5
  483. data/spec/unit/application_spec.rb +11 -11
  484. data/spec/unit/audit/audit_event_proxy_spec.rb +48 -48
  485. data/spec/unit/audit/audit_reporter_spec.rb +51 -55
  486. data/spec/unit/audit/control_group_data_spec.rb +20 -20
  487. data/spec/unit/audit/runner_spec.rb +2 -2
  488. data/spec/unit/chef_class_spec.rb +120 -0
  489. data/spec/unit/chef_fs/data_handler/data_bag_item_data_handler.rb +1 -1
  490. data/spec/unit/chef_fs/data_handler/data_handler_base_spec.rb +3 -3
  491. data/spec/unit/chef_fs/diff_spec.rb +45 -45
  492. data/spec/unit/chef_fs/file_pattern_spec.rb +2 -2
  493. data/spec/unit/chef_fs/file_system/repository/directory_spec.rb +2 -2
  494. data/spec/unit/chef_fs/file_system_spec.rb +8 -8
  495. data/spec/unit/chef_fs/parallelizer.rb +12 -12
  496. data/spec/unit/client_spec.rb +15 -15
  497. data/spec/unit/config_fetcher_spec.rb +23 -23
  498. data/spec/unit/config_spec.rb +2 -2
  499. data/spec/unit/cookbook/metadata_spec.rb +81 -81
  500. data/spec/unit/cookbook/synchronizer_spec.rb +171 -171
  501. data/spec/unit/cookbook_loader_spec.rb +10 -5
  502. data/spec/unit/cookbook_site_streaming_uploader_spec.rb +6 -6
  503. data/spec/unit/cookbook_uploader_spec.rb +8 -8
  504. data/spec/unit/cookbook_version_file_specificity_spec.rb +135 -135
  505. data/spec/unit/daemon_spec.rb +4 -4
  506. data/spec/unit/data_bag_item_spec.rb +3 -3
  507. data/spec/unit/data_bag_spec.rb +1 -1
  508. data/spec/unit/data_collector/resource_report_spec.rb +1 -1
  509. data/spec/unit/data_collector_spec.rb +4 -3
  510. data/spec/unit/deprecated_spec.rb +18 -12
  511. data/spec/unit/dsl/audit_spec.rb +1 -1
  512. data/spec/unit/dsl/platform_introspection_spec.rb +16 -16
  513. data/spec/unit/dsl/reboot_pending_spec.rb +1 -1
  514. data/spec/unit/environment_spec.rb +16 -16
  515. data/spec/unit/file_access_control_spec.rb +8 -8
  516. data/spec/unit/file_content_management/deploy/mv_unix_spec.rb +3 -3
  517. data/spec/unit/file_content_management/deploy/mv_windows_spec.rb +26 -26
  518. data/spec/unit/formatters/error_description_spec.rb +39 -39
  519. data/spec/unit/formatters/error_inspectors/compile_error_inspector_spec.rb +16 -16
  520. data/spec/unit/formatters/error_inspectors/cookbook_sync_error_inspector_spec.rb +1 -1
  521. data/spec/unit/formatters/error_inspectors/node_load_error_inspector_spec.rb +1 -1
  522. data/spec/unit/formatters/error_inspectors/registration_error_inspector_spec.rb +1 -1
  523. data/spec/unit/formatters/error_inspectors/resource_failure_inspector_spec.rb +1 -1
  524. data/spec/unit/formatters/error_inspectors/run_list_expansion_error_inspector_spec.rb +5 -5
  525. data/spec/unit/guard_interpreter/resource_guard_interpreter_spec.rb +4 -4
  526. data/spec/unit/handler/json_file_spec.rb +1 -1
  527. data/spec/unit/http/api_versions_spec.rb +1 -1
  528. data/spec/unit/http/authenticator_spec.rb +17 -17
  529. data/spec/unit/http/ssl_policies_spec.rb +1 -1
  530. data/spec/unit/http/validate_content_length_spec.rb +2 -2
  531. data/spec/unit/key_spec.rb +12 -12
  532. data/spec/unit/knife/bootstrap/client_builder_spec.rb +3 -3
  533. data/spec/unit/knife/client_bulk_delete_spec.rb +1 -1
  534. data/spec/unit/knife/client_delete_spec.rb +1 -1
  535. data/spec/unit/knife/client_reregister_spec.rb +1 -1
  536. data/spec/unit/knife/configure_client_spec.rb +4 -4
  537. data/spec/unit/knife/configure_spec.rb +1 -1
  538. data/spec/unit/knife/cookbook_bulk_delete_spec.rb +1 -1
  539. data/spec/unit/knife/cookbook_delete_spec.rb +4 -4
  540. data/spec/unit/knife/cookbook_download_spec.rb +21 -21
  541. data/spec/unit/knife/cookbook_list_spec.rb +7 -7
  542. data/spec/unit/knife/cookbook_show_spec.rb +24 -24
  543. data/spec/unit/knife/cookbook_site_download_spec.rb +23 -23
  544. data/spec/unit/knife/cookbook_site_install_spec.rb +4 -4
  545. data/spec/unit/knife/cookbook_site_share_spec.rb +10 -10
  546. data/spec/unit/knife/cookbook_site_unshare_spec.rb +2 -2
  547. data/spec/unit/knife/cookbook_upload_spec.rb +19 -19
  548. data/spec/unit/knife/core/bootstrap_context_spec.rb +37 -37
  549. data/spec/unit/knife/core/cookbook_scm_repo_spec.rb +20 -20
  550. data/spec/unit/knife/core/object_loader_spec.rb +1 -1
  551. data/spec/unit/knife/core/ui_spec.rb +55 -55
  552. data/spec/unit/knife/data_bag_create_spec.rb +2 -2
  553. data/spec/unit/knife/data_bag_edit_spec.rb +1 -1
  554. data/spec/unit/knife/data_bag_secret_options_spec.rb +5 -5
  555. data/spec/unit/knife/environment_from_file_spec.rb +1 -1
  556. data/spec/unit/knife/key_create_spec.rb +4 -4
  557. data/spec/unit/knife/key_delete_spec.rb +3 -3
  558. data/spec/unit/knife/key_edit_spec.rb +3 -3
  559. data/spec/unit/knife/key_list_spec.rb +3 -3
  560. data/spec/unit/knife/key_show_spec.rb +3 -3
  561. data/spec/unit/knife/node_delete_spec.rb +1 -1
  562. data/spec/unit/knife/node_edit_spec.rb +7 -7
  563. data/spec/unit/knife/node_from_file_spec.rb +1 -1
  564. data/spec/unit/knife/node_run_list_add_spec.rb +1 -1
  565. data/spec/unit/knife/osc_user_edit_spec.rb +1 -1
  566. data/spec/unit/knife/osc_user_reregister_spec.rb +1 -1
  567. data/spec/unit/knife/role_bulk_delete_spec.rb +1 -1
  568. data/spec/unit/knife/role_create_spec.rb +1 -1
  569. data/spec/unit/knife/role_delete_spec.rb +1 -1
  570. data/spec/unit/knife/role_env_run_list_add_spec.rb +4 -4
  571. data/spec/unit/knife/role_env_run_list_clear_spec.rb +1 -1
  572. data/spec/unit/knife/role_env_run_list_remove_spec.rb +1 -1
  573. data/spec/unit/knife/role_env_run_list_replace_spec.rb +1 -1
  574. data/spec/unit/knife/role_env_run_list_set_spec.rb +1 -1
  575. data/spec/unit/knife/role_from_file_spec.rb +1 -1
  576. data/spec/unit/knife/role_run_list_add_spec.rb +4 -4
  577. data/spec/unit/knife/role_run_list_clear_spec.rb +1 -1
  578. data/spec/unit/knife/role_run_list_remove_spec.rb +1 -1
  579. data/spec/unit/knife/role_run_list_replace_spec.rb +1 -1
  580. data/spec/unit/knife/role_run_list_set_spec.rb +1 -1
  581. data/spec/unit/knife/ssh_spec.rb +25 -25
  582. data/spec/unit/knife/ssl_check_spec.rb +23 -23
  583. data/spec/unit/knife/ssl_fetch_spec.rb +11 -11
  584. data/spec/unit/knife/user_delete_spec.rb +1 -1
  585. data/spec/unit/knife/user_reregister_spec.rb +1 -1
  586. data/spec/unit/knife_spec.rb +26 -26
  587. data/spec/unit/log/syslog_spec.rb +1 -1
  588. data/spec/unit/lwrp_spec.rb +4 -4
  589. data/spec/unit/mash_spec.rb +3 -3
  590. data/spec/unit/mixin/api_version_request_handling_spec.rb +16 -16
  591. data/spec/unit/mixin/checksum_spec.rb +1 -1
  592. data/spec/unit/mixin/enforce_ownership_and_permissions_spec.rb +8 -8
  593. data/spec/unit/mixin/homebrew_user_spec.rb +1 -1
  594. data/spec/unit/mixin/params_validate_spec.rb +96 -96
  595. data/spec/unit/mixin/powershell_exec_spec.rb +1 -1
  596. data/spec/unit/mixin/powershell_type_coercions_spec.rb +1 -1
  597. data/spec/unit/mixin/securable_spec.rb +27 -27
  598. data/spec/unit/mixin/shell_out_spec.rb +286 -132
  599. data/spec/unit/mixin/user_context_spec.rb +1 -1
  600. data/spec/unit/mixin/xml_escape_spec.rb +1 -1
  601. data/spec/unit/node/attribute_spec.rb +10 -10
  602. data/spec/unit/node/vivid_mash_spec.rb +3 -3
  603. data/spec/unit/node_map_spec.rb +71 -3
  604. data/spec/unit/node_spec.rb +15 -15
  605. data/spec/unit/org_spec.rb +2 -2
  606. data/spec/unit/platform/query_helpers_spec.rb +26 -26
  607. data/spec/unit/policy_builder/expand_node_object_spec.rb +4 -4
  608. data/spec/unit/policy_builder/policyfile_spec.rb +29 -29
  609. data/spec/unit/property_spec.rb +5 -5
  610. data/spec/unit/provider/apt_repository_spec.rb +19 -19
  611. data/spec/unit/provider/cookbook_file/content_spec.rb +1 -1
  612. data/spec/unit/provider/cookbook_file_spec.rb +1 -1
  613. data/spec/unit/provider/cron/unix_spec.rb +12 -12
  614. data/spec/unit/provider/cron_spec.rb +279 -279
  615. data/spec/unit/provider/dsc_resource_spec.rb +6 -6
  616. data/spec/unit/provider/execute_spec.rb +2 -2
  617. data/spec/unit/provider/file/content_spec.rb +1 -1
  618. data/spec/unit/provider/file_spec.rb +1 -1
  619. data/spec/unit/provider/git_spec.rb +123 -123
  620. data/spec/unit/provider/group/dscl_spec.rb +18 -18
  621. data/spec/unit/provider/group/gpasswd_spec.rb +7 -7
  622. data/spec/unit/provider/group/groupadd_spec.rb +7 -7
  623. data/spec/unit/provider/group/groupmod_spec.rb +13 -13
  624. data/spec/unit/provider/group/pw_spec.rb +4 -4
  625. data/spec/unit/provider/group/suse_spec.rb +2 -2
  626. data/spec/unit/provider/group/usermod_spec.rb +4 -4
  627. data/spec/unit/provider/group_spec.rb +3 -3
  628. data/spec/unit/provider/ifconfig/aix_spec.rb +17 -17
  629. data/spec/unit/provider/ifconfig/debian_spec.rb +16 -16
  630. data/spec/unit/provider/ifconfig_spec.rb +16 -16
  631. data/spec/unit/provider/launchd_spec.rb +52 -52
  632. data/spec/unit/provider/link_spec.rb +7 -7
  633. data/spec/unit/provider/mdadm_spec.rb +3 -3
  634. data/spec/unit/provider/mount/aix_spec.rb +39 -39
  635. data/spec/unit/provider/mount/mount_spec.rb +26 -26
  636. data/spec/unit/provider/mount/solaris_spec.rb +2 -2
  637. data/spec/unit/provider/mount/windows_spec.rb +6 -6
  638. data/spec/unit/provider/ohai_spec.rb +9 -9
  639. data/spec/unit/provider/osx_profile_spec.rb +1 -1
  640. data/spec/unit/provider/package/apt_spec.rb +186 -186
  641. data/spec/unit/provider/package/bff_spec.rb +36 -36
  642. data/spec/unit/provider/package/cab_spec.rb +58 -58
  643. data/spec/unit/provider/package/chocolatey_spec.rb +34 -34
  644. data/spec/unit/provider/package/dpkg_spec.rb +33 -33
  645. data/spec/unit/provider/package/freebsd/pkg_spec.rb +35 -35
  646. data/spec/unit/provider/package/freebsd/pkgng_spec.rb +22 -22
  647. data/spec/unit/provider/package/freebsd/port_spec.rb +21 -21
  648. data/spec/unit/provider/package/homebrew_spec.rb +4 -4
  649. data/spec/unit/provider/package/ips_spec.rb +94 -94
  650. data/spec/unit/provider/package/macports_spec.rb +23 -23
  651. data/spec/unit/provider/package/msu_spec.rb +44 -44
  652. data/spec/unit/provider/package/openbsd_spec.rb +19 -19
  653. data/spec/unit/provider/package/pacman_spec.rb +50 -50
  654. data/spec/unit/provider/package/paludis_spec.rb +33 -33
  655. data/spec/unit/provider/package/portage_spec.rb +25 -25
  656. data/spec/unit/provider/package/powershell_spec.rb +98 -85
  657. data/spec/unit/provider/package/rpm_spec.rb +21 -21
  658. data/spec/unit/provider/package/rubygems_spec.rb +71 -71
  659. data/spec/unit/provider/package/smartos_spec.rb +21 -21
  660. data/spec/unit/provider/package/solaris_spec.rb +38 -38
  661. data/spec/unit/provider/package/windows/exe_spec.rb +1 -1
  662. data/spec/unit/provider/package/windows/msi_spec.rb +1 -1
  663. data/spec/unit/provider/package/windows_spec.rb +11 -4
  664. data/spec/unit/provider/package/zypper_spec.rb +42 -46
  665. data/spec/unit/provider/package_spec.rb +2 -2
  666. data/spec/unit/provider/powershell_script_spec.rb +1 -1
  667. data/spec/unit/provider/registry_key_spec.rb +22 -22
  668. data/spec/unit/provider/remote_file/cache_control_data_spec.rb +7 -7
  669. data/spec/unit/provider/remote_file/content_spec.rb +4 -4
  670. data/spec/unit/provider/remote_file/fetcher_spec.rb +5 -5
  671. data/spec/unit/provider/remote_file/ftp_spec.rb +1 -1
  672. data/spec/unit/provider/remote_file/http_spec.rb +1 -1
  673. data/spec/unit/provider/remote_file/local_file_spec.rb +2 -2
  674. data/spec/unit/provider/remote_file/network_file_spec.rb +3 -3
  675. data/spec/unit/provider/remote_file/sftp_spec.rb +2 -2
  676. data/spec/unit/provider/remote_file_spec.rb +1 -1
  677. data/spec/unit/provider/script_spec.rb +1 -1
  678. data/spec/unit/provider/service/aix_service_spec.rb +8 -8
  679. data/spec/unit/provider/service/aixinit_service_spec.rb +3 -3
  680. data/spec/unit/provider/service/arch_service_spec.rb +21 -21
  681. data/spec/unit/provider/service/debian_service_spec.rb +2 -2
  682. data/spec/unit/provider/service/freebsd_service_spec.rb +30 -30
  683. data/spec/unit/provider/service/gentoo_service_spec.rb +1 -1
  684. data/spec/unit/provider/service/init_service_spec.rb +14 -14
  685. data/spec/unit/provider/service/insserv_service_spec.rb +2 -2
  686. data/spec/unit/provider/service/invokercd_service_spec.rb +17 -17
  687. data/spec/unit/provider/service/macosx_spec.rb +59 -59
  688. data/spec/unit/provider/service/openbsd_service_spec.rb +6 -6
  689. data/spec/unit/provider/service/redhat_spec.rb +27 -27
  690. data/spec/unit/provider/service/simple_service_spec.rb +14 -14
  691. data/spec/unit/provider/service/solaris_smf_service_spec.rb +19 -19
  692. data/spec/unit/provider/service/systemd_service_spec.rb +13 -13
  693. data/spec/unit/provider/service/upstart_service_spec.rb +5 -5
  694. data/spec/unit/provider/service/windows_spec.rb +38 -38
  695. data/spec/unit/provider/service_spec.rb +3 -3
  696. data/spec/unit/provider/subversion_spec.rb +13 -13
  697. data/spec/unit/provider/systemd_unit_spec.rb +10 -10
  698. data/spec/unit/provider/template/content_spec.rb +44 -44
  699. data/spec/unit/provider/template_spec.rb +2 -2
  700. data/spec/unit/provider/user/aix_spec.rb +5 -5
  701. data/spec/unit/provider/user/dscl_spec.rb +12 -12
  702. data/spec/unit/provider/user/pw_spec.rb +12 -12
  703. data/spec/unit/provider/user/solaris_spec.rb +6 -6
  704. data/spec/unit/provider/windows_env_spec.rb +2 -2
  705. data/spec/unit/provider/windows_task_spec.rb +16 -16
  706. data/spec/unit/provider/zypper_repository_spec.rb +7 -7
  707. data/spec/unit/provider_resolver_spec.rb +3 -3
  708. data/spec/unit/recipe_spec.rb +13 -13
  709. data/spec/unit/resource/chocolatey_config_spec.rb +98 -0
  710. data/spec/unit/resource/chocolatey_source_spec.rb +102 -0
  711. data/spec/unit/resource/conditional_spec.rb +1 -1
  712. data/spec/unit/resource/cookbook_file_spec.rb +3 -3
  713. data/spec/unit/resource/dnf_package_spec.rb +3 -3
  714. data/spec/unit/resource/dsc_script_spec.rb +10 -10
  715. data/spec/unit/resource/execute_spec.rb +2 -2
  716. data/spec/unit/resource/file/verification/systemd_unit_spec.rb +1 -1
  717. data/spec/unit/resource/file/verification_spec.rb +1 -1
  718. data/spec/unit/resource/file_spec.rb +3 -3
  719. data/spec/unit/resource/freebsd_package_spec.rb +5 -4
  720. data/spec/unit/resource/group_spec.rb +4 -4
  721. data/spec/unit/resource/kernel_module_spec.rb +48 -0
  722. data/spec/unit/resource/mount_spec.rb +13 -3
  723. data/spec/unit/resource/package_spec.rb +2 -2
  724. data/spec/unit/resource/powershell_package_source_spec.rb +219 -0
  725. data/spec/unit/resource/powershell_package_spec.rb +10 -1
  726. data/spec/unit/resource/powershell_script_spec.rb +8 -8
  727. data/spec/unit/resource/registry_key_spec.rb +19 -19
  728. data/spec/unit/resource/remote_file_spec.rb +2 -2
  729. data/spec/unit/resource/resource_notification_spec.rb +8 -8
  730. data/spec/unit/resource/service_spec.rb +3 -3
  731. data/spec/unit/resource/ssh_known_hosts_entry_spec.rb +55 -0
  732. data/spec/unit/resource/template_spec.rb +2 -2
  733. data/spec/unit/resource/user_spec.rb +2 -2
  734. data/spec/unit/resource/windows_feature_dism.rb +5 -5
  735. data/spec/unit/resource/windows_feature_powershell.rb +27 -6
  736. data/spec/unit/resource/yum_package_spec.rb +3 -3
  737. data/spec/unit/resource_collection/resource_set_spec.rb +6 -6
  738. data/spec/unit/resource_collection_spec.rb +5 -5
  739. data/spec/unit/resource_definition_spec.rb +2 -2
  740. data/spec/unit/resource_inspector_spec.rb +3 -3
  741. data/spec/unit/resource_reporter_spec.rb +24 -24
  742. data/spec/unit/resource_spec.rb +65 -31
  743. data/spec/unit/role_spec.rb +22 -22
  744. data/spec/unit/run_context_spec.rb +1 -1
  745. data/spec/unit/run_list/run_list_item_spec.rb +3 -3
  746. data/spec/unit/run_list/versioned_recipe_list_spec.rb +12 -12
  747. data/spec/unit/run_list_spec.rb +6 -6
  748. data/spec/unit/runner_spec.rb +4 -4
  749. data/spec/unit/scan_access_control_spec.rb +3 -3
  750. data/spec/unit/shell/model_wrapper_spec.rb +4 -4
  751. data/spec/unit/shell/shell_ext_spec.rb +4 -4
  752. data/spec/unit/shell/shell_session_spec.rb +28 -28
  753. data/spec/unit/user_spec.rb +2 -2
  754. data/spec/unit/user_v1_spec.rb +25 -25
  755. data/spec/unit/util/diff_spec.rb +1 -1
  756. data/spec/unit/util/dsc/configuration_generator_spec.rb +4 -4
  757. data/spec/unit/util/dsc/lcm_output_parser_spec.rb +105 -105
  758. data/spec/unit/util/dsc/local_configuration_manager_spec.rb +16 -16
  759. data/spec/unit/util/file_edit_spec.rb +38 -38
  760. data/spec/unit/util/powershell/cmdlet_spec.rb +1 -1
  761. data/spec/unit/util/selinux_spec.rb +10 -10
  762. data/spec/unit/win32/registry_spec.rb +3 -3
  763. data/spec/unit/windows_service_spec.rb +2 -2
  764. data/tasks/cbgb.rb +3 -3
  765. data/tasks/dependencies.rb +6 -8
  766. data/tasks/maintainers.rb +7 -7
  767. data/tasks/rspec.rb +2 -2
  768. metadata +20 -79
  769. data/acceptance/.shared/kitchen_acceptance/.kitchen.digitalocean.yml +0 -33
  770. data/acceptance/.shared/kitchen_acceptance/.kitchen.ec2.yml +0 -272
  771. data/acceptance/.shared/kitchen_acceptance/.kitchen.vagrant.yml +0 -57
  772. data/acceptance/.shared/kitchen_acceptance/libraries/kitchen.rb +0 -68
  773. data/acceptance/.shared/kitchen_acceptance/metadata.rb +0 -1
  774. data/acceptance/Gemfile +0 -19
  775. data/acceptance/Gemfile.lock +0 -266
  776. data/acceptance/README.md +0 -137
  777. data/acceptance/basics/.acceptance/acceptance-cookbook/.gitignore +0 -2
  778. data/acceptance/basics/.acceptance/acceptance-cookbook/metadata.rb +0 -3
  779. data/acceptance/basics/.acceptance/acceptance-cookbook/recipes/destroy.rb +0 -1
  780. data/acceptance/basics/.acceptance/acceptance-cookbook/recipes/provision.rb +0 -1
  781. data/acceptance/basics/.acceptance/acceptance-cookbook/recipes/verify.rb +0 -1
  782. data/acceptance/basics/.kitchen.yml +0 -4
  783. data/acceptance/basics/test/integration/chef-current-install/serverspec/chef_client_spec.rb +0 -19
  784. data/acceptance/basics/test/integration/chef-current-install/serverspec/spec_helper.rb +0 -6
  785. data/acceptance/basics/test/integration/helpers/serverspec/Gemfile +0 -8
  786. data/acceptance/data-collector/.acceptance/acceptance-cookbook/.gitignore +0 -2
  787. data/acceptance/data-collector/.acceptance/acceptance-cookbook/metadata.rb +0 -3
  788. data/acceptance/data-collector/.acceptance/acceptance-cookbook/recipes/destroy.rb +0 -2
  789. data/acceptance/data-collector/.acceptance/acceptance-cookbook/recipes/provision.rb +0 -2
  790. data/acceptance/data-collector/.acceptance/acceptance-cookbook/recipes/verify.rb +0 -2
  791. data/acceptance/data-collector/.acceptance/data-collector-test/.gitignore +0 -16
  792. data/acceptance/data-collector/.acceptance/data-collector-test/Berksfile +0 -3
  793. data/acceptance/data-collector/.acceptance/data-collector-test/files/default/api.rb +0 -101
  794. data/acceptance/data-collector/.acceptance/data-collector-test/files/default/apigemfile +0 -3
  795. data/acceptance/data-collector/.acceptance/data-collector-test/files/default/client-rb-both-mode.rb +0 -4
  796. data/acceptance/data-collector/.acceptance/data-collector-test/files/default/client-rb-client-mode.rb +0 -4
  797. data/acceptance/data-collector/.acceptance/data-collector-test/files/default/client-rb-no-endpoint.rb +0 -2
  798. data/acceptance/data-collector/.acceptance/data-collector-test/files/default/client-rb-solo-mode.rb +0 -4
  799. data/acceptance/data-collector/.acceptance/data-collector-test/files/default/config.ru +0 -2
  800. data/acceptance/data-collector/.acceptance/data-collector-test/metadata.rb +0 -7
  801. data/acceptance/data-collector/.acceptance/data-collector-test/recipes/default.rb +0 -44
  802. data/acceptance/data-collector/.kitchen.yml +0 -9
  803. data/acceptance/data-collector/Berksfile +0 -3
  804. data/acceptance/data-collector/test/integration/default/serverspec/default_spec.rb +0 -208
  805. data/acceptance/data-collector/test/integration/helpers/serverspec/Gemfile +0 -8
  806. data/acceptance/omnitruck/.acceptance/acceptance-cookbook/.gitignore +0 -2
  807. data/acceptance/omnitruck/.acceptance/acceptance-cookbook/metadata.rb +0 -1
  808. data/acceptance/omnitruck/.acceptance/acceptance-cookbook/recipes/destroy.rb +0 -1
  809. data/acceptance/omnitruck/.acceptance/acceptance-cookbook/recipes/provision.rb +0 -1
  810. data/acceptance/omnitruck/.acceptance/acceptance-cookbook/recipes/verify.rb +0 -61
  811. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/.gitignore +0 -2
  812. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/libraries/cookbook_kitchen.rb +0 -43
  813. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/libraries/top_cookbooks.rb +0 -41
  814. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/metadata.rb +0 -3
  815. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/recipes/destroy.rb +0 -1
  816. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/recipes/provision.rb +0 -1
  817. data/acceptance/top-cookbooks/.acceptance/acceptance-cookbook/recipes/verify.rb +0 -1
  818. data/acceptance/top-cookbooks/.gitignore +0 -1
  819. data/acceptance/top-cookbooks/.kitchen.chocolatey.yml +0 -6
  820. data/acceptance/top-cookbooks/.kitchen.iis.yml +0 -4
  821. data/acceptance/top-cookbooks/.kitchen.learn-the-basics-rhel.yml +0 -7
  822. data/acceptance/top-cookbooks/.kitchen.learn-the-basics-ubuntu.yml +0 -7
  823. data/acceptance/top-cookbooks/.kitchen.learn-the-basics-windows.yml +0 -7
  824. data/acceptance/top-cookbooks/.kitchen.powershell.yml +0 -4
  825. data/acceptance/top-cookbooks/.kitchen.sql_server.yml +0 -5
  826. data/acceptance/top-cookbooks/.kitchen.winbox.yml +0 -8
  827. data/acceptance/top-cookbooks/.kitchen.windows.yml +0 -38
  828. data/acceptance/trivial/.acceptance/acceptance-cookbook/.gitignore +0 -2
  829. data/acceptance/trivial/.acceptance/acceptance-cookbook/metadata.rb +0 -2
  830. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/destroy.rb +0 -1
  831. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/provision.rb +0 -1
  832. data/acceptance/trivial/.acceptance/acceptance-cookbook/recipes/verify.rb +0 -1
  833. data/acceptance/trivial/.kitchen.yml +0 -7
  834. data/acceptance/trivial/test/integration/chef-current-install/inspec/chef_client_spec.rb +0 -5
  835. data/acceptance/windows-service/.acceptance/acceptance-cookbook/.gitignore +0 -2
  836. data/acceptance/windows-service/.acceptance/acceptance-cookbook/metadata.rb +0 -2
  837. data/acceptance/windows-service/.acceptance/acceptance-cookbook/recipes/destroy.rb +0 -1
  838. data/acceptance/windows-service/.acceptance/acceptance-cookbook/recipes/provision.rb +0 -1
  839. data/acceptance/windows-service/.acceptance/acceptance-cookbook/recipes/verify.rb +0 -1
  840. data/acceptance/windows-service/.kitchen.yml +0 -7
  841. data/acceptance/windows-service/test/integration/chef-windows-service/inspec/chef_windows_service_spec.rb +0 -58
  842. data/distro/powershell/chef/Chef.PowerShell.dll +0 -0
@@ -139,7 +139,7 @@ class Chef
139
139
  end
140
140
 
141
141
  def put_data
142
- base_put_data = { :name => name, :admin => false }
142
+ base_put_data = { name: name, admin: false }
143
143
  if self_generate_keys?
144
144
  base_put_data[:public_key] = generated_public_key
145
145
  else
@@ -149,7 +149,7 @@ class Chef
149
149
  end
150
150
 
151
151
  def post_data
152
- post_data = { :name => name, :admin => false }
152
+ post_data = { name: name, admin: false }
153
153
  post_data[:public_key] = generated_public_key if self_generate_keys?
154
154
  post_data
155
155
  end
@@ -157,9 +157,9 @@ class Chef
157
157
  def http_api
158
158
  @http_api ||= Chef::ServerAPI.new(Chef::Config[:chef_server_url],
159
159
  {
160
- :api_version => "0",
161
- :client_name => Chef::Config[:validation_client_name],
162
- :signing_key_filename => Chef::Config[:validation_key],
160
+ api_version: "0",
161
+ client_name: Chef::Config[:validation_client_name],
162
+ signing_key_filename: Chef::Config[:validation_key],
163
163
  }
164
164
  )
165
165
  end
@@ -44,7 +44,7 @@ class Chef
44
44
  include Chef::Mixin::ParamsValidate
45
45
  include Chef::Mixin::ApiVersionRequestHandling
46
46
 
47
- SUPPORTED_API_VERSIONS = [0, 1]
47
+ SUPPORTED_API_VERSIONS = [0, 1].freeze
48
48
 
49
49
  # Create a new Chef::ApiClientV1 object.
50
50
  def initialize
@@ -57,15 +57,15 @@ class Chef
57
57
  end
58
58
 
59
59
  def chef_rest_v0
60
- @chef_rest_v0 ||= Chef::ServerAPI.new(Chef::Config[:chef_server_url], { :api_version => "0", :inflate_json_class => false })
60
+ @chef_rest_v0 ||= Chef::ServerAPI.new(Chef::Config[:chef_server_url], { api_version: "0", inflate_json_class: false })
61
61
  end
62
62
 
63
63
  def chef_rest_v1
64
- @chef_rest_v1 ||= Chef::ServerAPI.new(Chef::Config[:chef_server_url], { :api_version => "1", :inflate_json_class => false })
64
+ @chef_rest_v1 ||= Chef::ServerAPI.new(Chef::Config[:chef_server_url], { api_version: "1", inflate_json_class: false })
65
65
  end
66
66
 
67
67
  def self.http_api
68
- Chef::ServerAPI.new(Chef::Config[:chef_server_url], { :api_version => "1", :inflate_json_class => false })
68
+ Chef::ServerAPI.new(Chef::Config[:chef_server_url], { api_version: "1", inflate_json_class: false })
69
69
  end
70
70
 
71
71
  # Gets or sets the client name.
@@ -76,7 +76,7 @@ class Chef
76
76
  set_or_return(
77
77
  :name,
78
78
  arg,
79
- :regex => /^[\-[:alnum:]_\.]+$/
79
+ regex: /^[\-[:alnum:]_\.]+$/
80
80
  )
81
81
  end
82
82
 
@@ -88,7 +88,7 @@ class Chef
88
88
  set_or_return(
89
89
  :admin,
90
90
  arg,
91
- :kind_of => [ TrueClass, FalseClass ]
91
+ kind_of: [ TrueClass, FalseClass ]
92
92
  )
93
93
  end
94
94
 
@@ -100,7 +100,7 @@ class Chef
100
100
  set_or_return(
101
101
  :public_key,
102
102
  arg,
103
- :kind_of => String
103
+ kind_of: String
104
104
  )
105
105
  end
106
106
 
@@ -113,7 +113,7 @@ class Chef
113
113
  set_or_return(
114
114
  :validator,
115
115
  arg,
116
- :kind_of => [TrueClass, FalseClass]
116
+ kind_of: [TrueClass, FalseClass]
117
117
  )
118
118
  end
119
119
 
@@ -126,7 +126,7 @@ class Chef
126
126
  set_or_return(
127
127
  :private_key,
128
128
  arg,
129
- :kind_of => [String, TrueClass, FalseClass]
129
+ kind_of: [String, TrueClass, FalseClass]
130
130
  )
131
131
  end
132
132
 
@@ -138,7 +138,7 @@ class Chef
138
138
  set_or_return(
139
139
  :create_key,
140
140
  arg,
141
- :kind_of => [ TrueClass, FalseClass ]
141
+ kind_of: [ TrueClass, FalseClass ]
142
142
  )
143
143
  end
144
144
 
@@ -226,7 +226,7 @@ class Chef
226
226
  def reregister
227
227
  # Try API V0 and if it fails due to V0 not being supported, raise the proper error message.
228
228
  # reregister only supported in API V0 or lesser.
229
- reregistered_self = chef_rest_v0.put("clients/#{name}", { :name => name, :admin => admin, :validator => validator, :private_key => true })
229
+ reregistered_self = chef_rest_v0.put("clients/#{name}", { name: name, admin: admin, validator: validator, private_key: true })
230
230
  if reregistered_self.respond_to?(:[])
231
231
  private_key(reregistered_self["private_key"])
232
232
  else
@@ -254,7 +254,7 @@ class Chef
254
254
  # it was never implemented, we will simply ignore that functionality
255
255
  # as it is being deprecated.
256
256
  # Delete this comment after V0 support is dropped.
257
- payload = { :name => name }
257
+ payload = { name: name }
258
258
  payload[:validator] = validator unless validator.nil?
259
259
 
260
260
  # DEPRECATION
@@ -277,11 +277,11 @@ class Chef
277
277
  # Create the client via the REST API
278
278
  def create
279
279
  payload = {
280
- :name => name,
281
- :validator => validator,
280
+ name: name,
281
+ validator: validator,
282
282
  # this field is ignored in API V1, but left for backwards-compat,
283
283
  # can remove after OSC 11 support is finished?
284
- :admin => admin,
284
+ admin: admin,
285
285
  }
286
286
  begin
287
287
  # try API V1
@@ -205,7 +205,7 @@ class Chef
205
205
  # Based on config and whether or not STDOUT is a tty, should we setup a
206
206
  # secondary logger for stdout?
207
207
  def want_additional_logger?
208
- !( chef_config[:log_location].is_a?(IO) && chef_config[:log_location].tty? ) && !chef_config[:daemonize]
208
+ Chef::Config.is_default?(:log_location) && Chef::Config[:log_location].tty? && !Chef::Config[:daemonize]
209
209
  end
210
210
 
211
211
  def configure_stdout_logger
@@ -32,86 +32,86 @@ class Chef::Application::Apply < Chef::Application
32
32
  banner "Usage: chef-apply [RECIPE_FILE | -e RECIPE_TEXT | -s] [OPTIONS]"
33
33
 
34
34
  option :execute,
35
- :short => "-e RECIPE_TEXT",
36
- :long => "--execute RECIPE_TEXT",
37
- :description => "Execute resources supplied in a string",
38
- :proc => nil
35
+ short: "-e RECIPE_TEXT",
36
+ long: "--execute RECIPE_TEXT",
37
+ description: "Execute resources supplied in a string",
38
+ proc: nil
39
39
 
40
40
  option :stdin,
41
- :short => "-s",
42
- :long => "--stdin",
43
- :description => "Execute resources read from STDIN",
44
- :boolean => true
41
+ short: "-s",
42
+ long: "--stdin",
43
+ description: "Execute resources read from STDIN",
44
+ boolean: true
45
45
 
46
46
  option :json_attribs,
47
- :short => "-j JSON_ATTRIBS",
48
- :long => "--json-attributes JSON_ATTRIBS",
49
- :description => "Load attributes from a JSON file or URL",
50
- :proc => nil
47
+ short: "-j JSON_ATTRIBS",
48
+ long: "--json-attributes JSON_ATTRIBS",
49
+ description: "Load attributes from a JSON file or URL",
50
+ proc: nil
51
51
 
52
52
  option :force_logger,
53
- :long => "--force-logger",
54
- :description => "Use logger output instead of formatter output",
55
- :boolean => true,
56
- :default => false
53
+ long: "--force-logger",
54
+ description: "Use logger output instead of formatter output",
55
+ boolean: true,
56
+ default: false
57
57
 
58
58
  option :force_formatter,
59
- :long => "--force-formatter",
60
- :description => "Use formatter output instead of logger output",
61
- :boolean => true,
62
- :default => false
59
+ long: "--force-formatter",
60
+ description: "Use formatter output instead of logger output",
61
+ boolean: true,
62
+ default: false
63
63
 
64
64
  option :formatter,
65
- :short => "-F FORMATTER",
66
- :long => "--format FORMATTER",
67
- :description => "output format to use",
68
- :proc => lambda { |format| Chef::Config.add_formatter(format) }
65
+ short: "-F FORMATTER",
66
+ long: "--format FORMATTER",
67
+ description: "output format to use",
68
+ proc: lambda { |format| Chef::Config.add_formatter(format) }
69
69
 
70
70
  option :log_level,
71
- :short => "-l LEVEL",
72
- :long => "--log_level LEVEL",
73
- :description => "Set the log level (trace, debug, info, warn, error, fatal)",
74
- :proc => lambda { |l| l.to_sym }
71
+ short: "-l LEVEL",
72
+ long: "--log_level LEVEL",
73
+ description: "Set the log level (trace, debug, info, warn, error, fatal)",
74
+ proc: lambda { |l| l.to_sym }
75
75
 
76
76
  option :help,
77
- :short => "-h",
78
- :long => "--help",
79
- :description => "Show this message",
80
- :on => :tail,
81
- :boolean => true,
82
- :show_options => true,
83
- :exit => 0
77
+ short: "-h",
78
+ long: "--help",
79
+ description: "Show this message",
80
+ on: :tail,
81
+ boolean: true,
82
+ show_options: true,
83
+ exit: 0
84
84
 
85
85
  option :version,
86
- :short => "-v",
87
- :long => "--version",
88
- :description => "Show chef version",
89
- :boolean => true,
90
- :proc => lambda { |v| puts "Chef: #{::Chef::VERSION}" },
91
- :exit => 0
86
+ short: "-v",
87
+ long: "--version",
88
+ description: "Show chef version",
89
+ boolean: true,
90
+ proc: lambda { |v| puts "Chef: #{::Chef::VERSION}" },
91
+ exit: 0
92
92
 
93
93
  option :why_run,
94
- :short => "-W",
95
- :long => "--why-run",
96
- :description => "Enable whyrun mode",
97
- :boolean => true
94
+ short: "-W",
95
+ long: "--why-run",
96
+ description: "Enable whyrun mode",
97
+ boolean: true
98
98
 
99
99
  option :profile_ruby,
100
- :long => "--[no-]profile-ruby",
101
- :description => "Dump complete Ruby call graph stack of entire Chef run (expert only)",
102
- :boolean => true,
103
- :default => false
100
+ long: "--[no-]profile-ruby",
101
+ description: "Dump complete Ruby call graph stack of entire Chef run (expert only)",
102
+ boolean: true,
103
+ default: false
104
104
 
105
105
  option :color,
106
- :long => "--[no-]color",
107
- :boolean => true,
108
- :default => true,
109
- :description => "Use colored output, defaults to enabled"
106
+ long: "--[no-]color",
107
+ boolean: true,
108
+ default: true,
109
+ description: "Use colored output, defaults to enabled"
110
110
 
111
111
  option :minimal_ohai,
112
- :long => "--minimal-ohai",
113
- :description => "Only run the bare minimum ohai plugins chef needs to function",
114
- :boolean => true
112
+ long: "--minimal-ohai",
113
+ description: "Only run the bare minimum ohai plugins chef needs to function",
114
+ boolean: true
115
115
 
116
116
  attr_reader :json_attribs
117
117
 
@@ -35,175 +35,174 @@ class Chef::Application::Client < Chef::Application
35
35
  include ChefConfig::Mixin::DotD
36
36
 
37
37
  # Mimic self_pipe sleep from Unicorn to capture signals safely
38
- SELF_PIPE = []
38
+ SELF_PIPE = [] # rubocop:disable Style/MutableConstant
39
39
 
40
40
  option :config_file,
41
- :short => "-c CONFIG",
42
- :long => "--config CONFIG",
43
- :description => "The configuration file to use"
41
+ short: "-c CONFIG",
42
+ long: "--config CONFIG",
43
+ description: "The configuration file to use"
44
44
 
45
45
  option :config_option,
46
- :long => "--config-option OPTION=VALUE",
47
- :description => "Override a single configuration option",
48
- :proc => lambda { |option, existing|
46
+ long: "--config-option OPTION=VALUE",
47
+ description: "Override a single configuration option",
48
+ proc: lambda { |option, existing|
49
49
  (existing ||= []) << option
50
50
  existing
51
51
  }
52
52
 
53
53
  option :formatter,
54
- :short => "-F FORMATTER",
55
- :long => "--format FORMATTER",
56
- :description => "output format to use",
57
- :proc => lambda { |format| Chef::Config.add_formatter(format) }
54
+ short: "-F FORMATTER",
55
+ long: "--format FORMATTER",
56
+ description: "output format to use",
57
+ proc: lambda { |format| Chef::Config.add_formatter(format) }
58
58
 
59
59
  option :force_logger,
60
- :long => "--force-logger",
61
- :description => "Use logger output instead of formatter output",
62
- :boolean => true,
63
- :default => false
60
+ long: "--force-logger",
61
+ description: "Use logger output instead of formatter output",
62
+ boolean: true,
63
+ default: false
64
64
 
65
65
  option :force_formatter,
66
- :long => "--force-formatter",
67
- :description => "Use formatter output instead of logger output",
68
- :boolean => true,
69
- :default => false
66
+ long: "--force-formatter",
67
+ description: "Use formatter output instead of logger output",
68
+ boolean: true,
69
+ default: false
70
70
 
71
71
  option :profile_ruby,
72
- :long => "--[no-]profile-ruby",
73
- :description => "Dump complete Ruby call graph stack of entire Chef run (expert only)",
74
- :boolean => true,
75
- :default => false
72
+ long: "--[no-]profile-ruby",
73
+ description: "Dump complete Ruby call graph stack of entire Chef run (expert only)",
74
+ boolean: true,
75
+ default: false
76
76
 
77
77
  option :color,
78
- :long => "--[no-]color",
79
- :boolean => true,
80
- :default => true,
81
- :description => "Use colored output, defaults to enabled"
78
+ long: "--[no-]color",
79
+ boolean: true,
80
+ default: true,
81
+ description: "Use colored output, defaults to enabled"
82
82
 
83
83
  option :log_level,
84
- :short => "-l LEVEL",
85
- :long => "--log_level LEVEL",
86
- :description => "Set the log level (auto, trace, debug, info, warn, error, fatal)",
87
- :proc => lambda { |l| l.to_sym }
84
+ short: "-l LEVEL",
85
+ long: "--log_level LEVEL",
86
+ description: "Set the log level (auto, trace, debug, info, warn, error, fatal)",
87
+ proc: lambda { |l| l.to_sym }
88
88
 
89
89
  option :log_location,
90
- :short => "-L LOGLOCATION",
91
- :long => "--logfile LOGLOCATION",
92
- :description => "Set the log file location, defaults to STDOUT - recommended for daemonizing",
93
- :proc => nil
90
+ short: "-L LOGLOCATION",
91
+ long: "--logfile LOGLOCATION",
92
+ description: "Set the log file location, defaults to STDOUT - recommended for daemonizing",
93
+ proc: nil
94
94
 
95
95
  option :help,
96
- :short => "-h",
97
- :long => "--help",
98
- :description => "Show this message",
99
- :on => :tail,
100
- :boolean => true,
101
- :show_options => true,
102
- :exit => 0
96
+ short: "-h",
97
+ long: "--help",
98
+ description: "Show this message",
99
+ on: :tail,
100
+ boolean: true,
101
+ show_options: true,
102
+ exit: 0
103
103
 
104
104
  option :user,
105
- :short => "-u USER",
106
- :long => "--user USER",
107
- :description => "User to set privilege to",
108
- :proc => nil
105
+ short: "-u USER",
106
+ long: "--user USER",
107
+ description: "User to set privilege to",
108
+ proc: nil
109
109
 
110
110
  option :group,
111
- :short => "-g GROUP",
112
- :long => "--group GROUP",
113
- :description => "Group to set privilege to",
114
- :proc => nil
111
+ short: "-g GROUP",
112
+ long: "--group GROUP",
113
+ description: "Group to set privilege to",
114
+ proc: nil
115
115
 
116
116
  unless Chef::Platform.windows?
117
117
  option :daemonize,
118
- :short => "-d [WAIT]",
119
- :long => "--daemonize [WAIT]",
120
- :description =>
121
- "Daemonize the process. Accepts an optional integer which is the " \
118
+ short: "-d [WAIT]",
119
+ long: "--daemonize [WAIT]",
120
+ description: "Daemonize the process. Accepts an optional integer which is the " \
122
121
  "number of seconds to wait before the first daemonized run.",
123
- :proc => lambda { |wait| wait =~ /^\d+$/ ? wait.to_i : true }
122
+ proc: lambda { |wait| wait =~ /^\d+$/ ? wait.to_i : true }
124
123
  end
125
124
 
126
125
  option :pid_file,
127
- :short => "-P PID_FILE",
128
- :long => "--pid PIDFILE",
129
- :description => "Set the PID file location, for the chef-client daemon process. Defaults to /tmp/chef-client.pid",
130
- :proc => nil
126
+ short: "-P PID_FILE",
127
+ long: "--pid PIDFILE",
128
+ description: "Set the PID file location, for the chef-client daemon process. Defaults to /tmp/chef-client.pid",
129
+ proc: nil
131
130
 
132
131
  option :lockfile,
133
- :long => "--lockfile LOCKFILE",
134
- :description => "Set the lockfile location. Prevents multiple client processes from converging at the same time",
135
- :proc => nil
132
+ long: "--lockfile LOCKFILE",
133
+ description: "Set the lockfile location. Prevents multiple client processes from converging at the same time",
134
+ proc: nil
136
135
 
137
136
  option :interval,
138
- :short => "-i SECONDS",
139
- :long => "--interval SECONDS",
140
- :description => "Run chef-client periodically, in seconds",
141
- :proc => lambda { |s| s.to_i }
137
+ short: "-i SECONDS",
138
+ long: "--interval SECONDS",
139
+ description: "Run chef-client periodically, in seconds",
140
+ proc: lambda { |s| s.to_i }
142
141
 
143
142
  option :once,
144
- :long => "--once",
145
- :description => "Cancel any interval or splay options, run chef once and exit",
146
- :boolean => true
143
+ long: "--once",
144
+ description: "Cancel any interval or splay options, run chef once and exit",
145
+ boolean: true
147
146
 
148
147
  option :json_attribs,
149
- :short => "-j JSON_ATTRIBS",
150
- :long => "--json-attributes JSON_ATTRIBS",
151
- :description => "Load attributes from a JSON file or URL",
152
- :proc => nil
148
+ short: "-j JSON_ATTRIBS",
149
+ long: "--json-attributes JSON_ATTRIBS",
150
+ description: "Load attributes from a JSON file or URL",
151
+ proc: nil
153
152
 
154
153
  option :node_name,
155
- :short => "-N NODE_NAME",
156
- :long => "--node-name NODE_NAME",
157
- :description => "The node name for this client",
158
- :proc => nil
154
+ short: "-N NODE_NAME",
155
+ long: "--node-name NODE_NAME",
156
+ description: "The node name for this client",
157
+ proc: nil
159
158
 
160
159
  option :splay,
161
- :short => "-s SECONDS",
162
- :long => "--splay SECONDS",
163
- :description => "The splay time for running at intervals, in seconds",
164
- :proc => lambda { |s| s.to_i }
160
+ short: "-s SECONDS",
161
+ long: "--splay SECONDS",
162
+ description: "The splay time for running at intervals, in seconds",
163
+ proc: lambda { |s| s.to_i }
165
164
 
166
165
  option :chef_server_url,
167
- :short => "-S CHEFSERVERURL",
168
- :long => "--server CHEFSERVERURL",
169
- :description => "The chef server URL",
170
- :proc => nil
166
+ short: "-S CHEFSERVERURL",
167
+ long: "--server CHEFSERVERURL",
168
+ description: "The chef server URL",
169
+ proc: nil
171
170
 
172
171
  option :validation_key,
173
- :short => "-K KEY_FILE",
174
- :long => "--validation_key KEY_FILE",
175
- :description => "Set the validation key file location, used for registering new clients",
176
- :proc => nil
172
+ short: "-K KEY_FILE",
173
+ long: "--validation_key KEY_FILE",
174
+ description: "Set the validation key file location, used for registering new clients",
175
+ proc: nil
177
176
 
178
177
  option :client_key,
179
- :short => "-k KEY_FILE",
180
- :long => "--client_key KEY_FILE",
181
- :description => "Set the client key file location",
182
- :proc => nil
178
+ short: "-k KEY_FILE",
179
+ long: "--client_key KEY_FILE",
180
+ description: "Set the client key file location",
181
+ proc: nil
183
182
 
184
183
  option :named_run_list,
185
- :short => "-n NAMED_RUN_LIST",
186
- :long => "--named-run-list NAMED_RUN_LIST",
187
- :description => "Use a policyfile's named run list instead of the default run list"
184
+ short: "-n NAMED_RUN_LIST",
185
+ long: "--named-run-list NAMED_RUN_LIST",
186
+ description: "Use a policyfile's named run list instead of the default run list"
188
187
 
189
188
  option :environment,
190
- :short => "-E ENVIRONMENT",
191
- :long => "--environment ENVIRONMENT",
192
- :description => "Set the Chef Environment on the node"
189
+ short: "-E ENVIRONMENT",
190
+ long: "--environment ENVIRONMENT",
191
+ description: "Set the Chef Environment on the node"
193
192
 
194
193
  option :version,
195
- :short => "-v",
196
- :long => "--version",
197
- :description => "Show chef version",
198
- :boolean => true,
199
- :proc => lambda { |v| puts "Chef: #{::Chef::VERSION}" },
200
- :exit => 0
194
+ short: "-v",
195
+ long: "--version",
196
+ description: "Show chef version",
197
+ boolean: true,
198
+ proc: lambda { |v| puts "Chef: #{::Chef::VERSION}" },
199
+ exit: 0
201
200
 
202
201
  option :override_runlist,
203
- :short => "-o RunlistItem,RunlistItem...",
204
- :long => "--override-runlist RunlistItem,RunlistItem...",
205
- :description => "Replace current run list with specified items for a single run",
206
- :proc => lambda { |items|
202
+ short: "-o RunlistItem,RunlistItem...",
203
+ long: "--override-runlist RunlistItem,RunlistItem...",
204
+ description: "Replace current run list with specified items for a single run",
205
+ proc: lambda { |items|
207
206
  items = items.split(",")
208
207
  items.compact.map do |item|
209
208
  Chef::RunList::RunListItem.new(item)
@@ -211,97 +210,97 @@ class Chef::Application::Client < Chef::Application
211
210
  }
212
211
 
213
212
  option :runlist,
214
- :short => "-r RunlistItem,RunlistItem...",
215
- :long => "--runlist RunlistItem,RunlistItem...",
216
- :description => "Permanently replace current run list with specified items",
217
- :proc => lambda { |items|
213
+ short: "-r RunlistItem,RunlistItem...",
214
+ long: "--runlist RunlistItem,RunlistItem...",
215
+ description: "Permanently replace current run list with specified items",
216
+ proc: lambda { |items|
218
217
  items = items.split(",")
219
218
  items.compact.map do |item|
220
219
  Chef::RunList::RunListItem.new(item)
221
220
  end
222
221
  }
223
222
  option :why_run,
224
- :short => "-W",
225
- :long => "--why-run",
226
- :description => "Enable whyrun mode",
227
- :boolean => true
223
+ short: "-W",
224
+ long: "--why-run",
225
+ description: "Enable whyrun mode",
226
+ boolean: true
228
227
 
229
228
  option :client_fork,
230
- :short => "-f",
231
- :long => "--[no-]fork",
232
- :description => "Fork client"
229
+ short: "-f",
230
+ long: "--[no-]fork",
231
+ description: "Fork client"
233
232
 
234
233
  option :recipe_url,
235
- :long => "--recipe-url=RECIPE_URL",
236
- :description => "Pull down a remote archive of recipes and unpack it to the cookbook cache. Only used in local mode."
234
+ long: "--recipe-url=RECIPE_URL",
235
+ description: "Pull down a remote archive of recipes and unpack it to the cookbook cache. Only used in local mode."
237
236
 
238
237
  option :enable_reporting,
239
- :short => "-R",
240
- :long => "--enable-reporting",
241
- :description => "Enable reporting data collection for chef runs",
242
- :boolean => true
238
+ short: "-R",
239
+ long: "--enable-reporting",
240
+ description: "Enable reporting data collection for chef runs",
241
+ boolean: true
243
242
 
244
243
  option :local_mode,
245
- :short => "-z",
246
- :long => "--local-mode",
247
- :description => "Point chef-client at local repository",
248
- :boolean => true
244
+ short: "-z",
245
+ long: "--local-mode",
246
+ description: "Point chef-client at local repository",
247
+ boolean: true
249
248
 
250
249
  option :chef_zero_host,
251
- :long => "--chef-zero-host HOST",
252
- :description => "Host to start chef-zero on"
250
+ long: "--chef-zero-host HOST",
251
+ description: "Host to start chef-zero on"
253
252
 
254
253
  option :chef_zero_port,
255
- :long => "--chef-zero-port PORT",
256
- :description => "Port (or port range) to start chef-zero on. Port ranges like 1000,1010 or 8889-9999 will try all given ports until one works."
254
+ long: "--chef-zero-port PORT",
255
+ description: "Port (or port range) to start chef-zero on. Port ranges like 1000,1010 or 8889-9999 will try all given ports until one works."
257
256
 
258
257
  option :disable_config,
259
- :long => "--disable-config",
260
- :description => "Refuse to load a config file and use defaults. This is for development and not a stable API",
261
- :boolean => true
258
+ long: "--disable-config",
259
+ description: "Refuse to load a config file and use defaults. This is for development and not a stable API",
260
+ boolean: true
262
261
 
263
262
  option :run_lock_timeout,
264
- :long => "--run-lock-timeout SECONDS",
265
- :description => "Set maximum duration to wait for another client run to finish, default is indefinitely.",
266
- :proc => lambda { |s| s.to_i }
263
+ long: "--run-lock-timeout SECONDS",
264
+ description: "Set maximum duration to wait for another client run to finish, default is indefinitely.",
265
+ proc: lambda { |s| s.to_i }
267
266
 
268
267
  if Chef::Platform.windows?
269
268
  option :fatal_windows_admin_check,
270
- :short => "-A",
271
- :long => "--fatal-windows-admin-check",
272
- :description => "Fail the run when chef-client doesn't have administrator privileges on Windows",
273
- :boolean => true
269
+ short: "-A",
270
+ long: "--fatal-windows-admin-check",
271
+ description: "Fail the run when chef-client doesn't have administrator privileges on Windows",
272
+ boolean: true
274
273
  end
275
274
 
276
275
  option :audit_mode,
277
- :long => "--audit-mode MODE",
278
- :description => "Enable audit-mode with `enabled`. Disable audit-mode with `disabled`. Skip converge and only perform audits with `audit-only`",
279
- :proc => lambda { |mo| mo.tr("-", "_").to_sym }
276
+ long: "--audit-mode MODE",
277
+ description: "Enable audit-mode with `enabled`. Disable audit-mode with `disabled`. Skip converge and only perform audits with `audit-only`",
278
+ proc: lambda { |mo| mo.tr("-", "_").to_sym }
280
279
 
281
280
  option :minimal_ohai,
282
- :long => "--minimal-ohai",
283
- :description => "Only run the bare minimum ohai plugins chef needs to function",
284
- :boolean => true
281
+ long: "--minimal-ohai",
282
+ description: "Only run the bare minimum ohai plugins chef needs to function",
283
+ boolean: true
285
284
 
286
285
  option :listen,
287
- :long => "--[no-]listen",
288
- :description => "Whether a local mode (-z) server binds to a port",
289
- :boolean => false
286
+ long: "--[no-]listen",
287
+ description: "Whether a local mode (-z) server binds to a port",
288
+ boolean: false
290
289
 
291
290
  option :fips,
292
- :long => "--[no-]fips",
293
- :description => "Enable fips mode",
294
- :boolean => true
291
+ long: "--[no-]fips",
292
+ description: "Enable fips mode",
293
+ boolean: true
295
294
 
296
295
  option :delete_entire_chef_repo,
297
- :long => "--delete-entire-chef-repo",
298
- :description => "DANGEROUS: does what it says, only useful with --recipe-url",
299
- :boolean => true
296
+ long: "--delete-entire-chef-repo",
297
+ description: "DANGEROUS: does what it says, only useful with --recipe-url",
298
+ boolean: true
300
299
 
301
300
  option :skip_cookbook_sync,
302
- :long => "--[no-]skip-cookbook-sync",
303
- :description => "Use cached cookbooks without overwriting local differences from the server",
304
- :boolean => false
301
+ long: "--[no-]skip-cookbook-sync",
302
+ description: "Use cached cookbooks without overwriting local differences from the server",
303
+ boolean: false
305
304
 
306
305
  IMMEDIATE_RUN_SIGNAL = "1".freeze
307
306
  RECONFIGURE_SIGNAL = "H".freeze
@@ -317,18 +316,18 @@ class Chef::Application::Client < Chef::Application
317
316
 
318
317
  set_specific_recipes
319
318
 
320
- Chef::Config[:fips] = config[:fips] if config.has_key? :fips
319
+ Chef::Config[:fips] = config[:fips] if config.key? :fips
321
320
 
322
- Chef::Config[:chef_server_url] = config[:chef_server_url] if config.has_key? :chef_server_url
321
+ Chef::Config[:chef_server_url] = config[:chef_server_url] if config.key? :chef_server_url
323
322
 
324
- Chef::Config.local_mode = config[:local_mode] if config.has_key?(:local_mode)
323
+ Chef::Config.local_mode = config[:local_mode] if config.key?(:local_mode)
325
324
 
326
- if Chef::Config.has_key?(:chef_repo_path) && Chef::Config.chef_repo_path.nil?
325
+ if Chef::Config.key?(:chef_repo_path) && Chef::Config.chef_repo_path.nil?
327
326
  Chef::Config.delete(:chef_repo_path)
328
327
  Chef::Log.warn "chef_repo_path was set in a config file but was empty. Assuming #{Chef::Config.chef_repo_path}"
329
328
  end
330
329
 
331
- if Chef::Config.local_mode && !Chef::Config.has_key?(:cookbook_path) && !Chef::Config.has_key?(:chef_repo_path)
330
+ if Chef::Config.local_mode && !Chef::Config.key?(:cookbook_path) && !Chef::Config.key?(:chef_repo_path)
332
331
  Chef::Config.chef_repo_path = Chef::Config.find_chef_repo_path(Dir.pwd)
333
332
  end
334
333
 
@@ -338,7 +337,7 @@ class Chef::Application::Client < Chef::Application
338
337
  else
339
338
  if Chef::Config[:delete_entire_chef_repo]
340
339
  Chef::Log.trace "Cleanup path #{Chef::Config.chef_repo_path} before extract recipes into it"
341
- FileUtils.rm_rf(recipes_path, :secure => true)
340
+ FileUtils.rm_rf(recipes_path, secure: true)
342
341
  end
343
342
  Chef::Log.trace "Creating path #{Chef::Config.chef_repo_path} to extract recipes into"
344
343
  FileUtils.mkdir_p(Chef::Config.chef_repo_path)
@@ -385,7 +384,7 @@ class Chef::Application::Client < Chef::Application
385
384
  end
386
385
 
387
386
  def load_config_file
388
- if !config.has_key?(:config_file) && !config[:disable_config]
387
+ if !config.key?(:config_file) && !config[:disable_config]
389
388
  if config[:local_mode]
390
389
  config[:config_file] = Chef::WorkstationConfigLoader.new(nil, Chef::Log).config_location
391
390
  else
@@ -518,7 +517,7 @@ class Chef::Application::Client < Chef::Application
518
517
  def unforked_interval_error_message
519
518
  "Unforked chef-client interval runs are disabled in Chef 12." +
520
519
  "\nConfiguration settings:" +
521
- "#{"\n interval = #{Chef::Config[:interval]} seconds" if Chef::Config[:interval]}" +
520
+ ("\n interval = #{Chef::Config[:interval]} seconds" if Chef::Config[:interval]).to_s +
522
521
  "\nEnable chef-client interval runs by setting `:client_fork = true` in your config file or adding `--fork` to your command line options."
523
522
  end
524
523