chef 14.14.29 → 14.15.6

data/spec/unit/provider/package/apt_spec.rb

@@ -489,8 +489,8 @@ describe Chef::Provider::Package::Apt do
         allow(@provider).to receive(:shell_out_compacted!).with(
           "apt-mark", "showhold", timeout: 900
         ).and_return(instance_double(
-          Mixlib::ShellOut, stdout: "irssi")
-                    )
+          Mixlib::ShellOut, stdout: "irssi"
+        ))
         expect(logger).to receive(:trace).with("#{@provider.new_resource} is already locked")
 
         @provider.action_lock
@@ -510,8 +510,8 @@ describe Chef::Provider::Package::Apt do
         allow(@provider).to receive(:shell_out_compacted!).with(
           "apt-mark", "showhold", timeout: 900
         ).and_return(instance_double(
-          Mixlib::ShellOut, stdout: "")
-                    )
+          Mixlib::ShellOut, stdout: ""
+        ))
         expect(logger).to receive(:trace).with("#{@provider.new_resource} is already unlocked")
 
         @provider.action_unlock
@@ -564,7 +564,7 @@ describe Chef::Provider::Package::Apt do
           env: { "DEBIAN_FRONTEND" => "noninteractive" },
           timeout: @timeout
         )
-        @provider.install_package(["libmysqlclient15-dev", "irssi"], ["not_a_real_version", "0.8.12-7"])
+        @provider.install_package(%w{libmysqlclient15-dev irssi}, ["not_a_real_version", "0.8.12-7"])
       end
     end
 

data/spec/unit/provider/package/bff_spec.rb

@@ -81,7 +81,7 @@ describe Chef::Provider::Package::Bff do
       status = double("Status", stdout: info, exitstatus: 0)
       expect(@provider).to receive(:shell_out_compacted).with("installp", "-L", "-d", "/tmp/samba.base", timeout: 900).and_return(status)
       expect(@provider).to receive(:shell_out_compacted).with("lslpp", "-lcq", "samba.base", timeout: 900).and_return(@empty_status)
-      expect(logger).to receive(:warn).once.with(%r{bff package by product name})
+      expect(logger).to receive(:warn).once.with(/bff package by product name/)
       @provider.load_current_resource
 
       expect(@provider.current_resource.package_name).to eq("samba.base")

data/spec/unit/provider/package/cab_spec.rb

@@ -260,7 +260,7 @@ describe Chef::Provider::Package::Cab do
     end
 
     before do
-      new_resource.source = "#{ENV['TEMP']}/test6.1-kb2664825-v3-x64.cab"
+      new_resource.source = "#{ENV["TEMP"]}/test6.1-kb2664825-v3-x64.cab"
       installed_package_list_obj = double(stdout: installed_package_list_stdout)
       allow(provider).to receive(:dism_command).with("/Get-Packages").and_return(installed_package_list_obj)
     end

data/spec/unit/provider/package/chocolatey_spec.rb

@@ -262,8 +262,8 @@ describe Chef::Provider::Package::Chocolatey do
     end
 
     it "should do multipackage installs when given two packages without constraints" do
-      allow_remote_list(["git", "munin-node"])
-      new_resource.package_name(["git", "munin-node"])
+      allow_remote_list(%w{git munin-node})
+      new_resource.package_name(%w{git munin-node})
       provider.load_current_resource
       expect(provider).to receive(:shell_out_compacted!).with("#{choco_exe} install -y git munin-node", { returns: [0], timeout: timeout }).and_return(double)
       provider.run_action(:install)
@@ -298,8 +298,8 @@ describe Chef::Provider::Package::Chocolatey do
     end
 
     it "installing multiple packages with a package that does not exist throws an error" do
-      allow_remote_list(["git", "package-does-not-exist"])
-      new_resource.package_name(["git", "package-does-not-exist"])
+      allow_remote_list(%w{git package-does-not-exist})
+      new_resource.package_name(%w{git package-does-not-exist})
       provider.load_current_resource
       expect { provider.run_action(:install) }.to raise_error(Chef::Exceptions::Package)
     end
@@ -405,8 +405,8 @@ describe Chef::Provider::Package::Chocolatey do
     end
 
     it "upgrading multiple packages with a package that does not exist throws an error" do
-      allow_remote_list(["git", "package-does-not-exist"])
-      new_resource.package_name(["git", "package-does-not-exist"])
+      allow_remote_list(%w{git package-does-not-exist})
+      new_resource.package_name(%w{git package-does-not-exist})
       provider.load_current_resource
       expect { provider.run_action(:upgrade) }.to raise_error(Chef::Exceptions::Package)
     end
@@ -432,8 +432,8 @@ describe Chef::Provider::Package::Chocolatey do
     end
 
     it "does nothing when all the packages are already removed" do
-      allow_remote_list(["git", "package-does-not-exist"])
-      new_resource.package_name(["git", "package-does-not-exist"])
+      allow_remote_list(%w{git package-does-not-exist})
+      new_resource.package_name(%w{git package-does-not-exist})
       provider.load_current_resource
       expect(provider).not_to receive(:remove_package)
       provider.run_action(:remove)

data/spec/unit/provider/package/freebsd/pkg_spec.rb

@@ -25,7 +25,7 @@ describe Chef::Provider::Package::Freebsd::Pkg, "load_current_resource" do
     @node = Chef::Node.new
     @events = Chef::EventDispatch::Dispatcher.new
     @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource     = Chef::Resource::Package.new("zsh")
+    @new_resource = Chef::Resource::Package.new("zsh")
     @current_resource = Chef::Resource::Package.new("zsh")
 
     @provider = Chef::Provider::Package::Freebsd::Pkg.new(@new_resource, @run_context)

data/spec/unit/provider/package/ips_spec.rb

@@ -40,7 +40,7 @@ describe Chef::Provider::Package::Ips do
       installed on the system.  Try specifying -r to query remotely:
 
          crypto/gnupg
-PKG_STATUS
+    PKG_STATUS
     OpenStruct.new(stdout: stdout, stdin: stdin, stderr: stderr, status: @status, exitstatus: 1)
   end
 
@@ -56,7 +56,7 @@ PKG_STATUS
       Packaging Date: April  1, 2012 05:55:52 PM
                 Size: 2.57 MB
                 FMRI: pkg://omnios/security/sudo@1.8.4.1,5.11-0.151002:20120401T175552Z
-PKG_STATUS
+    PKG_STATUS
     stdin = StringIO.new
     stderr = ""
     OpenStruct.new(stdout: stdout, stdin: stdin, stderr: stderr, status: @status, exitstatus: 0)
@@ -106,7 +106,7 @@ PKG_STATUS
         Packaging Date: October 19, 2011 09:14:50 AM
                   Size: 8.07 MB
                   FMRI: pkg://solaris/crypto/gnupg@2.0.17,5.11-0.175.0.0.0.2.537:20111019T091450Z
-INSTALLED
+      INSTALLED
       expect(@provider).to receive(:shell_out_compacted).with("pkg", "info", @new_resource.package_name, timeout: 900).and_return(local)
       expect(@provider).to receive(:shell_out_compacted!).with("pkg", "info", "-r", @new_resource.package_name, timeout: 900).and_return(remote_output)
       @provider.load_current_resource
@@ -151,7 +151,7 @@ INSTALLED
         Packaging Date: April  1, 2012 05:55:52 PM
                   Size: 2.57 MB
                   FMRI: pkg://omnios/security/sudo@1.8.4.1,5.11-0.151002:20120401T175552Z
-PKG_STATUS
+      PKG_STATUS
       expect(@provider).to receive(:shell_out_compacted).with("pkg", "info", @new_resource.package_name, timeout: 900).and_return(local_output)
       expect(@provider).to receive(:shell_out_compacted!).with("pkg", "info", "-r", @new_resource.package_name, timeout: 900).and_return(remote)
       @provider.load_current_resource
@@ -175,7 +175,7 @@ PKG_STATUS
         Packaging Date: October 19, 2011 09:14:50 AM
                   Size: 8.07 MB
                   FMRI: pkg://solaris/crypto/gnupg@2.0.17,5.11-0.175.0.0.0.2.537:20111019T091450Z
-INSTALLED
+      INSTALLED
       remote = remote_output
       remote.stdout = <<~REMOTE
                   Name: crypto/gnupg
@@ -191,7 +191,7 @@ INSTALLED
         Packaging Date: October 19, 2011 09:14:50 AM
                   Size: 8.07 MB
                   FMRI: pkg://solaris/crypto/gnupg@2.0.18,5.11-0.175.0.0.0.2.537:20111019T091450Z
-REMOTE
+      REMOTE
 
       expect(@provider).to receive(:shell_out_compacted).with("pkg", "info", @new_resource.package_name, timeout: 900).and_return(local)
       expect(@provider).to receive(:shell_out_compacted!).with("pkg", "info", "-r", @new_resource.package_name, timeout: 900).and_return(remote)

data/spec/unit/provider/package/macports_spec.rb

@@ -73,7 +73,7 @@ describe Chef::Provider::Package::Macports do
       stdout = <<~EOF
         The following ports are currently installed:
           openssl @0.9.8k_0 (active)
-EOF
+      EOF
 
       status = double(stdout: stdout, exitstatus: 0)
       expect(@provider).to receive(:shell_out_compacted).and_return(status)

data/spec/unit/provider/package/msu_spec.rb

@@ -243,7 +243,7 @@ describe Chef::Provider::Package::Msu, :windows_only do
 
   describe "#extract_msu_contents" do
     it "extracts the msu contents by using mixlib shellout" do
-      expect(provider).to receive(:shell_out!).with("#{ENV['SYSTEMROOT']}\\system32\\expand.exe -f:* msu_file destination")
+      expect(provider).to receive(:shell_out!).with("#{ENV["SYSTEMROOT"]}\\system32\\expand.exe -f:* msu_file destination")
       provider.extract_msu_contents("msu_file", "destination")
     end
   end

data/spec/unit/provider/package/openbsd_spec.rb

@@ -45,15 +45,16 @@ describe Chef::Provider::Package::Openbsd do
 
     context "when not already installed" do
       before do
-        allow(provider).to receive(:shell_out_compacted!).with("pkg_info", "-e", "#{name}->0", anything()).and_return(instance_double("shellout", stdout: ""))
+        allow(provider).to receive(:shell_out_compacted!).with("pkg_info", "-e", "#{name}->0", anything).and_return(instance_double("shellout", stdout: ""))
       end
 
       context "when there is a single candidate" do
 
         context "when source is not provided" do
           it "should run the installation command" do
-            expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-I", name, anything()).and_return(
-              instance_double("shellout", stdout: "#{name}-#{version}\n"))
+            expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-I", name, anything).and_return(
+              instance_double("shellout", stdout: "#{name}-#{version}\n")
+            )
             expect(provider).to receive(:shell_out_compacted!).with(
               "pkg_add", "-r", "#{name}-#{version}",
               { env: { "PKG_PATH" => "http://ftp.OpenBSD.org/pub/OpenBSD/5.5/packages/amd64/" }, timeout: 900 }
@@ -69,8 +70,9 @@ describe Chef::Provider::Package::Openbsd do
 
         context "if no version is specified" do
           it "should raise an exception" do
-            expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-I", name, anything()).and_return(
-              instance_double("shellout", stdout: "#{name}-#{version}-#{flavor_a}\n#{name}-#{version}-#{flavor_b}\n"))
+            expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-I", name, anything).and_return(
+              instance_double("shellout", stdout: "#{name}-#{version}-#{flavor_a}\n#{name}-#{version}-#{flavor_b}\n")
+            )
             expect { provider.run_action(:install) }.to raise_error(Chef::Exceptions::Package, /multiple matching candidates/)
           end
         end
@@ -83,9 +85,10 @@ describe Chef::Provider::Package::Openbsd do
 
           context "if no version is specified" do
             it "should run the installation command" do
-              expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-e", "#{package_name}->0", anything()).and_return(instance_double("shellout", stdout: ""))
-              expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-I", name, anything()).and_return(
-                instance_double("shellout", stdout: "#{name}-#{version}-#{flavor}\n"))
+              expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-e", "#{package_name}->0", anything).and_return(instance_double("shellout", stdout: ""))
+              expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-I", name, anything).and_return(
+                instance_double("shellout", stdout: "#{name}-#{version}-#{flavor}\n")
+              )
               expect(provider).to receive(:shell_out_compacted!).with(
                 "pkg_add", "-r", "#{name}-#{version}-#{flavor}",
                 { env: { "PKG_PATH" => "http://ftp.OpenBSD.org/pub/OpenBSD/5.5/packages/amd64/" }, timeout: 900 }
@@ -98,8 +101,9 @@ describe Chef::Provider::Package::Openbsd do
 
         context "if a version is specified" do
           it "should use the flavor from the version" do
-            expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-I", "#{name}-#{version}-#{flavor_b}", anything()).and_return(
-              instance_double("shellout", stdout: "#{name}-#{version}-#{flavor_a}\n"))
+            expect(provider).to receive(:shell_out_compacted!).with("pkg_info", "-I", "#{name}-#{version}-#{flavor_b}", anything).and_return(
+              instance_double("shellout", stdout: "#{name}-#{version}-#{flavor_a}\n")
+            )
 
             new_resource.version("#{version}-#{flavor_b}")
             expect(provider).to receive(:shell_out_compacted!).with(
@@ -116,7 +120,7 @@ describe Chef::Provider::Package::Openbsd do
   describe "delete a package" do
     before do
       @name = "ihavetoes"
-      @new_resource     = Chef::Resource::Package.new(@name)
+      @new_resource = Chef::Resource::Package.new(@name)
       @current_resource = Chef::Resource::Package.new(@name)
       @provider = Chef::Provider::Package::Openbsd.new(@new_resource, @run_context)
       @provider.current_resource = @current_resource

data/spec/unit/provider/package/pacman_spec.rb

@@ -34,7 +34,7 @@ describe Chef::Provider::Package::Pacman do
     @stdin = StringIO.new
     @stdout = StringIO.new(<<~ERR)
       error: package "nano" not found
-ERR
+    ERR
     @stderr = StringIO.new
     @pid = 2342
   end
@@ -86,7 +86,7 @@ ERR
         Install Reason : Explicitly installed
         Install Script : Yes
         Description    : Pico editor clone with enhancements
-PACMAN
+      PACMAN
 
       status = double(stdout: stdout, exitstatus: 0)
       allow(@provider).to receive(:shell_out_compacted).and_return(status)
@@ -118,7 +118,7 @@ PACMAN
 
         [community]
         Include = /etc/pacman.d/mirrorlist
-PACMAN_CONF
+      PACMAN_CONF
 
       status = double(stdout: "customrepo nano 1.2.3-4", exitstatus: 0)
       allow(::File).to receive(:exist?).with("/etc/pacman.conf").and_return(true)

data/spec/unit/provider/package/paludis_spec.rb

@@ -40,7 +40,7 @@ describe Chef::Provider::Package::Paludis do
       user/ntp 0 accounts
       user/ntp 0 installed-accounts
       net/ntp 4.2.6_p5-r1 installed
-PKG_STATUS
+    PKG_STATUS
     @pid = 12345
     @shell_out = OpenStruct.new(stdout: @stdout, stdin: @stdin, stderr: @stderr, status: @status, exitstatus: 0)
   end
@@ -71,7 +71,7 @@ PKG_STATUS
         user/ntp 0 accounts
         user/ntp 0 installed-accounts
         net/ntp 4.2.6_p5-r1 installed
-INSTALLED
+      INSTALLED
       expect(@provider).to receive(:shell_out_compacted!).and_return(@shell_out)
       @provider.load_current_resource
       expect(@current_resource.version).to eq("4.2.6_p5-r1")
@@ -100,7 +100,7 @@ INSTALLED
       @stdout.replace(<<~PKG_STATUS)
         sys-process/lsof 4.87 arbor
         sys-process/lsof 4.87 x86_64
-PKG_STATUS
+      PKG_STATUS
       expect(@provider).to receive(:shell_out_compacted!).with("cave", "-L", "warning", "resolve", "-x", "=sys-process/lsof-4.87", { timeout: @new_resource.timeout || 900 })
       @provider.install_package("sys-process/lsof", "4.87")
     end
@@ -109,7 +109,7 @@ PKG_STATUS
       @stdout.replace(<<~PKG_STATUS)
         sys-process/lsof 4.87 arbor
         sys-process/lsof 4.87 x86_64
-PKG_STATUS
+      PKG_STATUS
       expect(@provider).to receive(:shell_out_compacted!).and_return(@shell_out)
       @provider.load_current_resource
       expect(@current_resource.version).to be_nil

data/spec/unit/provider/package/portage_spec.rb

@@ -138,7 +138,7 @@ describe Chef::Provider::Package::Portage, "load_current_resource" do
           * dev-python/sphinx
 
           Please use a more specific atom.
-EOF
+        EOF
         status = double(stdout: "", stderr: stderr_output, exitstatus: 1)
         @provider = Chef::Provider::Package::Portage.new(@new_resource_without_category, @run_context)
         expect(@provider).to receive(:shell_out_compacted).and_return(status)

data/spec/unit/provider/package/powershell_spec.rb

@@ -198,7 +198,7 @@ describe Chef::Provider::Package::Powershell do
     end
 
     it "can build a valid command from an array" do
-      expect(provider.build_powershell_package_command(["Get-Package", "posh-git"])).to eql(generated_command)
+      expect(provider.build_powershell_package_command(%w{Get-Package posh-git})).to eql(generated_command)
     end
 
     context "when source is nil" do

data/spec/unit/provider/package/smartos_spec.rb

@@ -25,7 +25,7 @@ describe Chef::Provider::Package::SmartOS, "load_current_resource" do
     @node = Chef::Node.new
     @events = Chef::EventDispatch::Dispatcher.new
     @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource     = Chef::Resource::Package.new("varnish")
+    @new_resource = Chef::Resource::Package.new("varnish")
     @current_resource = Chef::Resource::Package.new("varnish")
 
     @status = double("Status", exitstatus: 0)
@@ -75,7 +75,7 @@ describe Chef::Provider::Package::SmartOS, "load_current_resource" do
     end
 
     it "should lookup the candidate_version if the variable is not already set (pkgin separated by spaces)" do
-      search = double()
+      search = double
       expect(search).to receive(:each_line)
         .and_yield("something-varnish-1.1.1   something varnish like\n")
         .and_yield("varnish-2.3.4             actual varnish\n")
@@ -85,7 +85,7 @@ describe Chef::Provider::Package::SmartOS, "load_current_resource" do
     end
 
     it "should lookup the candidate_version if the variable is not already set (pkgin separated by semicolons)" do
-      search = double()
+      search = double
       expect(search).to receive(:each_line)
         .and_yield("something-varnish-1.1.1;;something varnish like\n")
         .and_yield("varnish-2.3.4;;actual varnish\n")

data/spec/unit/provider/package/solaris_spec.rb

@@ -44,7 +44,7 @@ describe Chef::Provider::Package::Solaris do
         PSTAMP:  sfw10-patch20070430084444
         INSTDATE:  Nov 04 2009 01:02
         HOTLINE:  Please contact your local service provider
-PKGINFO
+      PKGINFO
 
       @status = double("Status", stdout: "", exitstatus: 0)
     end

data/spec/unit/provider/package/windows/exe_spec.rb

@@ -117,7 +117,7 @@ describe Chef::Provider::Package::Windows::Exe do
     context "no version given and one package installed with unquoted uninstall string" do
       it "removes installed package and quotes uninstall string" do
         allow(::File).to receive(:exist?).with("uninst_dir/uninst_file").and_return(true)
-        expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"uninst_dir\/uninst_file\" \/S \/NCRC & exit %%%%ERRORLEVEL%%%%/, kind_of(Hash))
+        expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"uninst_dir/uninst_file\" /S /NCRC & exit %%%%ERRORLEVEL%%%%}, kind_of(Hash))
         provider.remove_package
       end
     end
@@ -126,7 +126,7 @@ describe Chef::Provider::Package::Windows::Exe do
       it "removes installed package and quotes uninstall string" do
         new_resource.timeout = 300
         allow(::File).to receive(:exist?).with("uninst_dir/uninst_file").and_return(true)
-        expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"uninst_dir\/uninst_file\" \/S \/NCRC & exit %%%%ERRORLEVEL%%%%/, timeout: 300, returns: [0])
+        expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"uninst_dir/uninst_file\" /S /NCRC & exit %%%%ERRORLEVEL%%%%}, timeout: 300, returns: [0])
         provider.remove_package
       end
     end
@@ -148,15 +148,15 @@ describe Chef::Provider::Package::Windows::Exe do
       context "version given and installed" do
         it "removes given version" do
           new_resource.version("v2")
-          expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"uninst_dir2\/uninst_file2\" \/S \/NCRC & exit %%%%ERRORLEVEL%%%%/, kind_of(Hash))
+          expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"uninst_dir2/uninst_file2\" /S /NCRC & exit %%%%ERRORLEVEL%%%%}, kind_of(Hash))
           provider.remove_package
         end
       end
 
       context "no version given" do
         it "removes both versions" do
-          expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"uninst_dir1\/uninst_file1\" \/S \/NCRC & exit %%%%ERRORLEVEL%%%%/, kind_of(Hash))
-          expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"uninst_dir2\/uninst_file2\" \/S \/NCRC & exit %%%%ERRORLEVEL%%%%/, kind_of(Hash))
+          expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"uninst_dir1/uninst_file1\" /S /NCRC & exit %%%%ERRORLEVEL%%%%}, kind_of(Hash))
+          expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"uninst_dir2/uninst_file2\" /S /NCRC & exit %%%%ERRORLEVEL%%%%}, kind_of(Hash))
           provider.remove_package
         end
       end
@@ -167,7 +167,7 @@ describe Chef::Provider::Package::Windows::Exe do
     let(:provider) { Chef::Provider::Package::Windows::Exe.new(new_resource, :nsis, uninstall_entry) }
 
     it "calls installer with the correct flags" do
-      expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"#{Regexp.quote(new_resource.source)}\" \/S \/NCRC  & exit %%%%ERRORLEVEL%%%%/, kind_of(Hash))
+      expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"#{Regexp.quote(new_resource.source)}\" /S /NCRC  & exit %%%%ERRORLEVEL%%%%}, kind_of(Hash))
       provider.install_package
     end
   end
@@ -176,7 +176,7 @@ describe Chef::Provider::Package::Windows::Exe do
     let(:provider) { Chef::Provider::Package::Windows::Exe.new(new_resource, :installshield, uninstall_entry) }
 
     it "calls installer with the correct flags" do
-      expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"#{Regexp.quote(new_resource.source)}\" \/s \/sms  & exit %%%%ERRORLEVEL%%%%/, kind_of(Hash))
+      expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"#{Regexp.quote(new_resource.source)}\" /s /sms  & exit %%%%ERRORLEVEL%%%%}, kind_of(Hash))
       provider.install_package
     end
   end
@@ -185,7 +185,7 @@ describe Chef::Provider::Package::Windows::Exe do
     let(:provider) { Chef::Provider::Package::Windows::Exe.new(new_resource, :inno, uninstall_entry) }
 
     it "calls installer with the correct flags" do
-      expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"#{Regexp.quote(new_resource.source)}\" \/VERYSILENT \/SUPPRESSMSGBOXES \/NORESTART  & exit %%%%ERRORLEVEL%%%%/, kind_of(Hash))
+      expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"#{Regexp.quote(new_resource.source)}\" /VERYSILENT /SUPPRESSMSGBOXES /NORESTART  & exit %%%%ERRORLEVEL%%%%}, kind_of(Hash))
       provider.install_package
     end
   end
@@ -194,7 +194,7 @@ describe Chef::Provider::Package::Windows::Exe do
     let(:provider) { Chef::Provider::Package::Windows::Exe.new(new_resource, :wise, uninstall_entry) }
 
     it "calls installer with the correct flags" do
-      expect(provider).to receive(:shell_out!).with(/start \"\" \/wait \"#{Regexp.quote(new_resource.source)}\" \/s  & exit %%%%ERRORLEVEL%%%%/, kind_of(Hash))
+      expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"#{Regexp.quote(new_resource.source)}\" /s  & exit %%%%ERRORLEVEL%%%%}, kind_of(Hash))
       provider.install_package
     end
   end

data/spec/unit/provider/package/windows/msi_spec.rb

@@ -104,14 +104,14 @@ describe Chef::Provider::Package::Windows::MSI do
 
   describe "install_package" do
     it "calls msiexec /qn /i" do
-      expect(provider).to receive(:shell_out!).with(/msiexec \/qn \/i \"#{Regexp.quote(new_resource.source)}\"/, kind_of(Hash))
+      expect(provider).to receive(:shell_out!).with(%r{msiexec /qn /i \"#{Regexp.quote(new_resource.source)}\"}, kind_of(Hash))
       provider.install_package
     end
   end
 
   describe "remove_package" do
     it "calls msiexec /qn /x" do
-      expect(provider).to receive(:shell_out!).with(/msiexec \/qn \/x \"#{Regexp.quote(new_resource.source)}\"/, kind_of(Hash))
+      expect(provider).to receive(:shell_out!).with(%r{msiexec /qn /x \"#{Regexp.quote(new_resource.source)}\"}, kind_of(Hash))
       provider.remove_package
     end
 
@@ -121,7 +121,7 @@ describe Chef::Provider::Package::Windows::MSI do
       end
 
       it "removes installed package" do
-        expect(provider).to receive(:shell_out!).with(/msiexec \/x {guid} \/q/, kind_of(Hash))
+        expect(provider).to receive(:shell_out!).with(%r{msiexec /x {guid} /q}, kind_of(Hash))
         provider.remove_package
       end
 
@@ -140,8 +140,8 @@ describe Chef::Provider::Package::Windows::MSI do
         end
 
         it "removes both installed package" do
-          expect(provider).to receive(:shell_out!).with(/msiexec \/x {guid} \/q/, kind_of(Hash))
-          expect(provider).to receive(:shell_out!).with(/msiexec \/x {guid2} \/q/, kind_of(Hash))
+          expect(provider).to receive(:shell_out!).with(%r{msiexec /x {guid} /q}, kind_of(Hash))
+          expect(provider).to receive(:shell_out!).with(%r{msiexec /x {guid2} /q}, kind_of(Hash))
           provider.remove_package
         end
       end
@@ -150,7 +150,7 @@ describe Chef::Provider::Package::Windows::MSI do
         before { new_resource.options("/Q") }
 
         it "does not duplicate quiet switch" do
-          expect(provider).to receive(:shell_out!).with(/msiexec \/x {guid} \/Q/, kind_of(Hash))
+          expect(provider).to receive(:shell_out!).with(%r{msiexec /x {guid} /Q}, kind_of(Hash))
           provider.remove_package
         end
       end
@@ -159,7 +159,7 @@ describe Chef::Provider::Package::Windows::MSI do
         before { new_resource.options("/qn") }
 
         it "does not duplicate quiet switch" do
-          expect(provider).to receive(:shell_out!).with(/msiexec \/x {guid} \/qn/, kind_of(Hash))
+          expect(provider).to receive(:shell_out!).with(%r{msiexec /x {guid} /qn}, kind_of(Hash))
           provider.remove_package
         end
       end