chef 12.5.1 → 12.6.0

data/spec/data/apt/chef-integration-test2-1.0/debian/chef-integration-test2.substvars

@@ -0,0 +1 @@
+misc:Depends=

data/spec/data/apt/chef-integration-test2-1.0/debian/chef-integration-test2/DEBIAN/conffiles

@@ -0,0 +1 @@
+/usr/share/doc/chef-integration-test2/copyright

data/spec/data/apt/chef-integration-test2-1.0/debian/chef-integration-test2/DEBIAN/control

@@ -0,0 +1,10 @@
+Package: chef-integration-test2
+Version: 1.0-1
+Architecture: amd64
+Maintainer: Joshua Timberman <Joshua Timberman <joshua@opscode.com>>
+Installed-Size: 36
+Section: ruby
+Priority: extra
+Homepage: http://tickets.opscode.com
+Description: Chef integration tests for APT in Cucumber
+ This package is used for cucumber integration testing in Chef.

data/spec/data/apt/chef-integration-test2-1.0/debian/chef-integration-test2/DEBIAN/md5sums

@@ -0,0 +1 @@
+8b3b9ff6cdfe7d7b2b8b8d4f7b9e381f  usr/share/doc/chef-integration-test2/changelog.Debian.gz

data/spec/data/apt/chef-integration-test2-1.0/debian/compat

@@ -0,0 +1 @@
+7

data/spec/data/apt/chef-integration-test2-1.0/debian/conffiles

@@ -0,0 +1 @@
+/usr/share/doc/chef-integration-test2/copyright

data/spec/data/apt/chef-integration-test2-1.0/debian/control

@@ -0,0 +1,13 @@
+Source: chef-integration-test2
+Section: ruby
+Priority: extra
+Maintainer: Joshua Timberman <Joshua Timberman <joshua@opscode.com>>
+Build-Depends: debhelper (>= 7.0.50~)
+Standards-Version: 3.8.4
+Homepage: http://tickets.opscode.com
+
+Package: chef-integration-test2
+Architecture: any
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: Chef integration tests for APT in Cucumber
+ This package is used for cucumber integration testing in Chef.

data/spec/data/apt/chef-integration-test2-1.0/debian/copyright

@@ -0,0 +1,34 @@
+This work was packaged by:
+
+    Joshua Timberman <Joshua Timberman <joshua@opscode.com>> on Thu, 30 Sep 2010 09:53:45 -0600
+
+Upstream Author(s):
+
+    Opscode, Inc.
+
+Copyright:
+
+    Copyright (C) 2010 Opscode, Inc
+
+License:
+
+    Licensed under the Apache License, Version 2.0 (the "License");
+    you may not use this file except in compliance with the License.
+    You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+
+The Debian packaging is:
+
+    Copyright (C) 2010 Opscode, Inc (<legal@opscode.com>)
+
+
+and is licensed under the Apache 2.0 license.
+
+See "/usr/share/common-licenses/Apache-2.0"

data/spec/data/apt/chef-integration-test2-1.0/debian/files

@@ -0,0 +1 @@
+chef-integration-test2_1.0-1_amd64.deb ruby extra

data/spec/data/apt/chef-integration-test2-1.0/debian/rules

@@ -0,0 +1,13 @@
+#!/usr/bin/make -f
+# -*- makefile -*-
+# Sample debian/rules that uses debhelper.
+# This file was originally written by Joey Hess and Craig Small.
+# As a special exception, when this file is copied by dh-make into a
+# dh-make output file, you may use that output file without restriction.
+# This special exception was added by Craig Small in version 0.37 of dh-make.
+
+# Uncomment this to turn on verbose mode.
+#export DH_VERBOSE=1
+
+%:
+	dh $@ 

data/spec/data/apt/chef-integration-test2-1.0/debian/source/format

@@ -0,0 +1 @@
+3.0 (quilt)

data/spec/data/apt/chef-integration-test2_1.0-1.dsc

@@ -0,0 +1,18 @@
+Format: 3.0 (quilt)
+Source: chef-integration-test2
+Binary: chef-integration-test2
+Architecture: any
+Version: 1.0-1
+Maintainer: Joshua Timberman <Joshua Timberman <joshua@opscode.com>>
+Homepage: http://tickets.opscode.com
+Standards-Version: 3.8.4
+Build-Depends: debhelper (>= 7.0.50~)
+Checksums-Sha1: 
+ 755c304197c6559128aed206ea70643fec2bb90d 248 chef-integration-test2_1.0.orig.tar.gz
+ 8b7df49a9e2c57b4460c2738852db1156a21a089 1369 chef-integration-test2_1.0-1.debian.tar.gz
+Checksums-Sha256: 
+ 8b206a7b3d422290bc8d82bd700cb89f1c6e3962b96be6a3955c7a0159f9031c 248 chef-integration-test2_1.0.orig.tar.gz
+ 77a7956e222c35afcddc4a5a8d338ca6e36dc1fbd720af255ce2412885f82702 1369 chef-integration-test2_1.0-1.debian.tar.gz
+Files: 
+ f1f7d7bbe63ad631d25d707f564a8d33 248 chef-integration-test2_1.0.orig.tar.gz
+ 4fab5c1cd9a7b47c4f319af776f48a1d 1369 chef-integration-test2_1.0-1.debian.tar.gz

data/spec/data/apt/chef-integration-test2_1.0-1_amd64.build

@@ -0,0 +1,91 @@
+ dpkg-buildpackage -rfakeroot -D -us -uc
+dpkg-buildpackage: warning: using a gain-root-command while being root
+dpkg-buildpackage: set CFLAGS to default value: -g -O2
+dpkg-buildpackage: set CPPFLAGS to default value: 
+dpkg-buildpackage: set LDFLAGS to default value: -Wl,-Bsymbolic-functions
+dpkg-buildpackage: set FFLAGS to default value: -g -O2
+dpkg-buildpackage: set CXXFLAGS to default value: -g -O2
+dpkg-buildpackage: source package chef-integration-test2
+dpkg-buildpackage: source version 1.0-1
+dpkg-buildpackage: source changed by Joshua Timberman <joshua@opscode.com>
+dpkg-buildpackage: host architecture amd64
+ fakeroot debian/rules clean
+dh clean 
+   dh_testdir
+   dh_auto_clean
+   dh_clean
+ dpkg-source -b chef-integration-test2-1.0
+dpkg-source: info: using source format `3.0 (quilt)'
+dpkg-source: info: building chef-integration-test2 using existing ./chef-integration-test2_1.0.orig.tar.gz
+dpkg-source: warning: ignoring deletion of directory cache
+dpkg-source: warning: ignoring deletion of directory cache/chef-integration-test2
+dpkg-source: warning: ignoring deletion of file cache/chef-integration-test2/contents
+dpkg-source: info: building chef-integration-test2 in chef-integration-test2_1.0-1.debian.tar.gz
+dpkg-source: info: building chef-integration-test2 in chef-integration-test2_1.0-1.dsc
+ debian/rules build
+dh build 
+   dh_testdir
+   dh_auto_configure
+   dh_auto_build
+   dh_auto_test
+ fakeroot debian/rules binary
+dh binary 
+   dh_testroot
+   dh_prep
+   dh_installdirs
+   dh_auto_install
+   dh_install
+   dh_installdocs
+   dh_installchangelogs
+   dh_installexamples
+   dh_installman
+   dh_installcatalogs
+   dh_installcron
+   dh_installdebconf
+   dh_installemacsen
+   dh_installifupdown
+   dh_installinfo
+   dh_pysupport
+   dh_installinit
+   dh_installmenu
+   dh_installmime
+   dh_installmodules
+   dh_installlogcheck
+   dh_installlogrotate
+   dh_installpam
+   dh_installppp
+   dh_installudev
+   dh_installwm
+   dh_installxfonts
+   dh_bugfiles
+   dh_lintian
+   dh_gconf
+   dh_icons
+   dh_perl
+   dh_usrlocal
+   dh_link
+   dh_compress
+   dh_fixperms
+   dh_strip
+   dh_makeshlibs
+   dh_shlibdeps
+   dh_installdeb
+   dh_gencontrol
+dpkg-gencontrol: warning: unknown substitution variable ${shlibs:Depends}
+   dh_md5sums
+   dh_builddeb
+dpkg-deb: building package `chef-integration-test2' in `../chef-integration-test2_1.0-1_amd64.deb'.
+ dpkg-genchanges  >../chef-integration-test2_1.0-1_amd64.changes
+dpkg-genchanges: including full source code in upload
+dpkg-buildpackage: full upload (original source is included)
+Now running lintian...
+warning: lintian's authors do not recommend running it with root privileges!
+E: chef-integration-test2 source: maintainer-address-malformed Joshua Timberman <Joshua Timberman <joshua@opscode.com>>
+W: chef-integration-test2 source: changelog-should-mention-nmu
+W: chef-integration-test2 source: source-nmu-has-incorrect-version-number 1.0-1
+W: chef-integration-test2: new-package-should-close-itp-bug
+W: chef-integration-test2: wrong-bug-number-in-closes l3:#CHEF
+E: chef-integration-test2: file-in-usr-marked-as-conffile /usr/share/doc/chef-integration-test2/copyright
+E: chef-integration-test2: maintainer-address-malformed Joshua Timberman <Joshua Timberman <joshua@opscode.com>>
+W: chef-integration-test2: empty-binary-package
+Finished running lintian.

data/spec/data/apt/chef-integration-test2_1.0-1_amd64.changes

@@ -0,0 +1,31 @@
+Format: 1.8
+Date: Thu, 30 Sep 2010 09:53:45 -0600
+Source: chef-integration-test2
+Binary: chef-integration-test2
+Architecture: source amd64
+Version: 1.0-1
+Distribution: unstable
+Urgency: low
+Maintainer: Joshua Timberman <Joshua Timberman <joshua@opscode.com>>
+Changed-By: Joshua Timberman <joshua@opscode.com>
+Description: 
+ chef-integration-test2 - Chef integration tests for APT in Cucumber
+Changes: 
+ chef-integration-test2 (1.0-1) unstable; urgency=low
+ .
+   * Initial release (Closes: #CHEF-1718)
+Checksums-Sha1: 
+ 7e065fdf71f4d798312b318a29cec43b7bc1c8e1 885 chef-integration-test2_1.0-1.dsc
+ 755c304197c6559128aed206ea70643fec2bb90d 248 chef-integration-test2_1.0.orig.tar.gz
+ 8b7df49a9e2c57b4460c2738852db1156a21a089 1369 chef-integration-test2_1.0-1.debian.tar.gz
+ f3f89c051bce36d40ef1be12d231c44b2d5be05b 1694 chef-integration-test2_1.0-1_amd64.deb
+Checksums-Sha256: 
+ 80d314349e1d978f242d05482ca81c9361739047daa4adcecc9e5e622fdc6fb4 885 chef-integration-test2_1.0-1.dsc
+ 8b206a7b3d422290bc8d82bd700cb89f1c6e3962b96be6a3955c7a0159f9031c 248 chef-integration-test2_1.0.orig.tar.gz
+ 77a7956e222c35afcddc4a5a8d338ca6e36dc1fbd720af255ce2412885f82702 1369 chef-integration-test2_1.0-1.debian.tar.gz
+ 19a767db0a947a350fb1c8492699e8a808fbe1838d4a582001106cfbe520ad8f 1694 chef-integration-test2_1.0-1_amd64.deb
+Files: 
+ 9f927b32d95b5406c696b5b0b23177e8 885 ruby extra chef-integration-test2_1.0-1.dsc
+ f1f7d7bbe63ad631d25d707f564a8d33 248 ruby extra chef-integration-test2_1.0.orig.tar.gz
+ 4fab5c1cd9a7b47c4f319af776f48a1d 1369 ruby extra chef-integration-test2_1.0-1.debian.tar.gz
+ 9914e6152e278b6828bcade3b3f5580c 1694 ruby extra chef-integration-test2_1.0-1_amd64.deb

data/spec/functional/application_spec.rb

@@ -42,7 +42,7 @@ describe Chef::Application do
       Chef::Config[:ftp_proxy] = nil
       Chef::Config[:no_proxy] = nil
 
-      @app.configure_proxy_environment_variables
+      Chef::Config.export_proxies
     end
 
     it "saves built proxy to ENV which shell_out can use" do

data/spec/functional/audit/runner_spec.rb

@@ -52,6 +52,10 @@ describe Chef::Audit::Runner do
     let(:run_context) { instance_double(Chef::RunContext, :events => events, :audits => audits) }
     let(:control_group_name) { "control_group_name" }
 
+    # Set cookbook path to include our parent, so that it will recognize this
+    # rspec file as one that should show up in the backtrace.
+    before(:each) { Chef::Config[:cookbook_path] = File.dirname(__FILE__) }
+
     shared_context "passing audit" do
       let(:audits) do
         should_pass = lambda do

data/spec/functional/knife/ssh_spec.rb

@@ -56,7 +56,7 @@ describe Chef::Knife::Ssh do
 
       it "uses the ssh_identity_file" do
         @knife.run
-        expect(@knife.config[:identity_file]).to eq("~/.ssh/aws.rsa")
+        expect(@knife.config[:ssh_identity_file]).to eq("~/.ssh/aws.rsa")
       end
     end
 
@@ -68,7 +68,7 @@ describe Chef::Knife::Ssh do
 
       it "uses the ssh_identity_file" do
         @knife.run
-        expect(@knife.config[:identity_file]).to eq("~/.ssh/aws.rsa")
+        expect(@knife.config[:ssh_identity_file]).to eq("~/.ssh/aws.rsa")
       end
     end
 
@@ -80,13 +80,13 @@ describe Chef::Knife::Ssh do
 
       it "should use the value on the command line" do
         @knife.run
-        expect(@knife.config[:identity_file]).to eq("~/.ssh/aws.rsa")
+        expect(@knife.config[:ssh_identity_file]).to eq("~/.ssh/aws.rsa")
       end
 
       it "should override what is set in knife.rb" do
         Chef::Config[:knife][:ssh_identity_file] = "~/.ssh/other.rsa"
         @knife.run
-        expect(@knife.config[:identity_file]).to eq("~/.ssh/aws.rsa")
+        expect(@knife.config[:ssh_identity_file]).to eq("~/.ssh/aws.rsa")
       end
     end
 
@@ -98,7 +98,7 @@ describe Chef::Knife::Ssh do
 
       it "uses the default" do
         @knife.run
-        expect(@knife.config[:identity_file]).to eq(nil)
+        expect(@knife.config[:ssh_identity_file]).to eq(nil)
       end
     end
   end

data/spec/functional/notifications_spec.rb

@@ -74,6 +74,76 @@ describe "Notifications" do
     runner.converge
   end
 
+  it "should notify from one resource to another before" do
+    log_resource = recipe.declare_resource(:log, "log") do
+      message "This is a log message"
+      action :write
+      notifies :install, "package[vim]", :before
+    end
+    update_action(log_resource, 2)
+
+    package_resource = recipe.declare_resource(:package, "vim") do
+      action :nothing
+    end
+
+    actions = []
+    [ log_resource, package_resource ].each do |resource|
+      allow(resource).to receive(:run_action).and_wrap_original do |m, action, notification_type, notifying_resource|
+        actions << { resource: resource.to_s, action: action }
+        actions[-1][:why_run] = Chef::Config[:why_run] if Chef::Config[:why_run]
+        actions[-1][:notification_type] = notification_type if notification_type
+        actions[-1][:notifying_resource] = notifying_resource.to_s if notifying_resource
+        m.call(action, notification_type, notifying_resource)
+      end
+    end
+
+    runner.converge
+
+    expect(actions).to eq [
+      # First it runs why-run to check if the resource would update
+      { resource: log_resource.to_s,     action: :write,   why_run: true },
+      # Then it runs the before action
+      { resource: package_resource.to_s, action: :install, notification_type: :before, notifying_resource: log_resource.to_s },
+      # Then it runs the actual action
+      { resource: log_resource.to_s,     action: :write },
+      { resource: package_resource.to_s, action: :nothing }
+    ]
+  end
+
+  it "should not notify from one resource to another before if the resource is not updated" do
+    log_resource = recipe.declare_resource(:log, "log") do
+      message "This is a log message"
+      action :write
+      notifies :install, "package[vim]", :before
+    end
+
+    package_resource = recipe.declare_resource(:package, "vim") do
+      action :nothing
+    end
+
+    actions = []
+    [ log_resource, package_resource ].each do |resource|
+      allow(resource).to receive(:run_action).and_wrap_original do |m, action, notification_type, notifying_resource|
+        actions << { resource: resource.to_s, action: action }
+        actions[-1][:why_run] = Chef::Config[:why_run] if Chef::Config[:why_run]
+        actions[-1][:notification_type] = notification_type if notification_type
+        actions[-1][:notifying_resource] = notifying_resource.to_s if notifying_resource
+        m.call(action, notification_type, notifying_resource)
+      end
+    end
+
+    runner.converge
+
+    expect(actions).to eq [
+      # First it runs why-run to check if the resource would update
+      { resource: log_resource.to_s,     action: :write,   why_run: true },
+      # Then it does NOT run the before action
+      # Then it runs the actual action
+      { resource: log_resource.to_s,     action: :write },
+      { resource: package_resource.to_s, action: :nothing }
+    ]
+  end
+
   it "should notify from one resource to another delayed" do
     log_resource = recipe.declare_resource(:log, "log") do
       message "This is a log message"
@@ -94,7 +164,7 @@ describe "Notifications" do
 
     runner.converge
   end
-  
+
   describe "when one resource is defined lazily" do
 
     it "subscribes to a resource defined in a ruby block" do
@@ -158,10 +228,10 @@ describe "Notifications" do
   end
 
   # Mocks having the provider run successfully and update the resource
-  def update_action(resource)
+  def update_action(resource, times=1)
     p = Chef::Provider.new(resource, run_context)
-    expect(resource).to receive(:provider_for_action).and_return(p)
-    expect(p).to receive(:run_action) {
+    expect(resource).to receive(:provider_for_action).exactly(times).times.and_return(p)
+    expect(p).to receive(:run_action).exactly(times).times {
       resource.updated_by_last_action(true)
     }
   end

data/spec/functional/resource/aix_service_spec.rb

@@ -108,8 +108,8 @@ describe Chef::Resource::Service, :requires_root, :aix_only do
     it_behaves_like "src service"
   end
 
-
-  describe "When service is a group" do
+  # Cannot run this test on a WPAR
+  describe "When service is a group", :not_wpar do
     before(:all) do
       script_dir = File.join(File.dirname(__FILE__), "/../assets/")
       shell_out!("mkssys -s ctestsys -p #{script_dir}/testchefsubsys -u #{get_user_id} -S -n 15 -f 9 -R -Q -G ctestgrp")

data/spec/functional/resource/dpkg_package_spec.rb

@@ -0,0 +1,339 @@
+#
+# Copyright:: Copyright (c) 2014-2015 Chef Software, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef/mixin/shell_out'
+
+describe Chef::Resource::DpkgPackage, :requires_root, :debian_family_only, arch: "x86_64" do
+  include Chef::Mixin::ShellOut
+
+  let(:apt_data) { File.join(CHEF_SPEC_DATA, "apt") }
+
+  let(:test1_0) { File.join(apt_data, "chef-integration-test_1.0-1_amd64.deb") }
+  let(:test1_1) { File.join(apt_data, "chef-integration-test_1.1-1_amd64.deb") }
+  let(:test2_0) { File.join(apt_data, "chef-integration-test2_1.0-1_amd64.deb") }
+
+  let(:run_context) {
+    node = TEST_NODE.dup
+    events = Chef::EventDispatch::Dispatcher.new
+    Chef::RunContext.new(node, {}, events)
+  }
+
+  let(:dpkg_package) { Chef::Resource::DpkgPackage.new(test1_0, run_context)}
+
+  before(:each) do
+    shell_out("dpkg -P chef-integration-test chef-integration-test2")
+  end
+
+  # handles setting the name property after the initializer runs
+  def set_dpkg_package_name(name)
+    dpkg_package.name name
+    dpkg_package.package_name name
+  end
+
+  def should_be_purged_or_removed(package, action=nil)
+    status = shell_out("dpkg -s #{package}")
+    output = status.stdout + status.stderr
+    if action.nil? || action == :purge
+      expect(output).to match(/no info|not-installed|not installed/)
+    elsif action == :remove
+      expect(output).to match(/deinstall ok config-files/)
+    else
+      raise "Unknown action"
+    end
+  end
+
+  shared_examples_for "common behavior for upgrade or install" do
+    it "installs a package when given only the filename as a name argument (no source)" do
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+    end
+
+    it "installs a package when given the name and a source argument" do
+      set_dpkg_package_name "chef-integration-test"
+      dpkg_package.source test1_0
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+    end
+
+    it "installs a package when given a different name and a source argument" do
+      set_dpkg_package_name "some other name"
+      dpkg_package.source test1_0
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+    end
+
+    it "installs a package when given a path as a package_name and no source" do
+      set_dpkg_package_name "chef-integration-test"
+      dpkg_package.package_name test1_0
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+    end
+
+    it "raises an error when the name is not a path and the source is not given" do
+      set_dpkg_package_name "chef-integration-test"
+      dpkg_package.package_name "chef-integration-test"
+      expect { dpkg_package.run_action(action) }.to raise_error(Chef::Exceptions::Package)
+    end
+
+    it "raises an error when passed a package_name that does not exist" do
+      set_dpkg_package_name File.join(test1_0, "make.it.fail")
+      expect { dpkg_package.run_action(action) }.to raise_error(Chef::Exceptions::Package)
+    end
+
+    it "raises an error when passed a source that does not exist" do
+      set_dpkg_package_name "chef-integration-test"
+      dpkg_package.source File.join(test1_0, "make.it.fail")
+      expect { dpkg_package.run_action(action) }.to raise_error(Chef::Exceptions::Package)
+    end
+
+    it "should not install an already installed package" do
+      shell_out!("dpkg -i #{test1_0}")
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+    end
+
+    it "should handle a multipackage install" do
+      set_dpkg_package_name [ test1_0, test2_0 ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+      shell_out!('dpkg -s chef-integration-test2')
+    end
+
+    it "should not update multipackages that are up-to-date" do
+      shell_out!("dpkg -i #{test1_0} #{test2_0}")
+      set_dpkg_package_name [ test1_0, test2_0 ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+      shell_out!('dpkg -s chef-integration-test2')
+    end
+
+    it "should install the second if the first is installed" do
+      shell_out!("dpkg -i #{test1_0}")
+      set_dpkg_package_name [ test1_0, test2_0 ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+      shell_out!('dpkg -s chef-integration-test2')
+    end
+
+    it "should install the first if the second is installed" do
+      shell_out!("dpkg -i #{test2_0}")
+      set_dpkg_package_name [ test1_0, test2_0 ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test')
+      shell_out!('dpkg -s chef-integration-test2')
+    end
+  end
+
+  context "action :install" do
+    let(:action) { :install }
+    it_behaves_like "common behavior for upgrade or install"
+
+    it "should not upgrade a package" do
+      shell_out!("dpkg -i #{test1_0}")
+      set_dpkg_package_name test1_1
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+    end
+
+    it "should not upgrade on a multipackage install" do
+      shell_out!("dpkg -i #{test1_0} #{test2_0}")
+      set_dpkg_package_name [ test1_1, test2_0 ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+    end
+  end
+
+  context "action :upgrade" do
+    let(:action) { :upgrade }
+    it_behaves_like "common behavior for upgrade or install"
+
+    it "should upgrade a package" do
+      shell_out!("dpkg -i #{test1_0}")
+      set_dpkg_package_name test1_1
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+    end
+
+    it "should upgrade on a multipackage install" do
+      shell_out!("dpkg -i #{test1_0} #{test2_0}")
+      set_dpkg_package_name [ test1_1, test2_0 ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+    end
+  end
+
+  shared_examples_for "common behavior for remove or purge" do
+    it "should remove a package that is installed when the name is a source" do
+      shell_out!("dpkg -i #{test1_0}")
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should do nothing if the package is not installed when the name is a source" do
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should remove a package that is installed when the name is the package name and source is nil" do
+      shell_out!("dpkg -i #{test1_0}")
+      set_dpkg_package_name "chef-integration-test"
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should do nothing if the package is not installed when the name is the package name and the source is nil" do
+      set_dpkg_package_name "chef-integration-test"
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should remove a package that is installed when the name is changed but the source is a package" do
+      shell_out!("dpkg -i #{test1_0}")
+      set_dpkg_package_name "some other name"
+      dpkg_package.source test1_0
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should do nothing if the package is not installed when the name is changed but the source is a package" do
+      set_dpkg_package_name "some other name"
+      dpkg_package.source test1_0
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should remove a package if the name is a file that does not exist, but the source exists" do
+      shell_out!("dpkg -i #{test1_0}")
+      dpkg_package.name "whatever"
+      dpkg_package.package_name File.join(test1_0, "make.it.fail")
+      dpkg_package.source test1_0
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should do nothing if the package is not installed when the name is a file that does not exist, but the source exists" do
+      set_dpkg_package_name "some other name"
+      dpkg_package.name "whatever"
+      dpkg_package.package_name File.join(test1_0, "make.it.fail")
+      dpkg_package.source test1_0
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should remove a package if the package_name is correct, but the source does not exist" do
+      shell_out!("dpkg -i #{test1_0}")
+      dpkg_package.name "whatever"
+      dpkg_package.package_name "chef-integration-test"
+      dpkg_package.source File.join(test1_0, "make.it.fail")
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should do nothing if the package_name is correct, but the source does not exist, and the package is not installed" do
+      dpkg_package.name "whatever"
+      dpkg_package.package_name "chef-integration-test"
+      dpkg_package.source File.join(test1_0, "make.it.fail")
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+    end
+
+    it "should remove both packages when called with two" do
+      shell_out!("dpkg -i #{test1_0} #{test2_0}")
+      set_dpkg_package_name [ "chef-integration-test", "chef-integration-test2" ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+      should_be_purged_or_removed('chef-integration-test2', action)
+    end
+
+    it "should remove a package when only the first one is installed" do
+      shell_out!("dpkg -i #{test1_0}")
+      set_dpkg_package_name [ "chef-integration-test", "chef-integration-test2" ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+      should_be_purged_or_removed('chef-integration-test2')
+    end
+
+    it "should remove a package when only the second one is installed" do
+      shell_out!("dpkg -i #{test2_0}")
+      set_dpkg_package_name [ "chef-integration-test", "chef-integration-test2" ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+      should_be_purged_or_removed('chef-integration-test2', action)
+    end
+
+    it "should do nothing when both packages are not installed" do
+      set_dpkg_package_name [ "chef-integration-test", "chef-integration-test2" ]
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test')
+      should_be_purged_or_removed('chef-integration-test2')
+    end
+  end
+
+  context "action :remove" do
+    let(:action) { :remove }
+    it_behaves_like "common behavior for remove or purge"
+
+    it "should not remove a removed package when the name is a source" do
+      # the "test2" file has a conffile declared in it
+      shell_out!("dpkg -i #{test2_0}")
+      shell_out!("dpkg -r chef-integration-test2")
+      set_dpkg_package_name "chef-integration-test2"
+      dpkg_package.run_action(action)
+      expect(dpkg_package).not_to be_updated_by_last_action
+      shell_out!('dpkg -s chef-integration-test2')  # its still 'installed'
+    end
+  end
+
+  context "action :purge" do
+    let(:action) { :purge }
+    it_behaves_like "common behavior for remove or purge"
+
+    it "should purge a removed package when the name is a source" do
+      # the "test2" file has a conffile declared in it
+      shell_out!("dpkg -i #{test2_0}")
+      shell_out!("dpkg -r chef-integration-test2")
+      set_dpkg_package_name "chef-integration-test2"
+      dpkg_package.run_action(action)
+      expect(dpkg_package).to be_updated_by_last_action
+      should_be_purged_or_removed('chef-integration-test2', action)
+    end
+  end
+end