chef 12.19.36 → 14.14.25

data/lib/chef/resource/windows_share.rb

@@ -0,0 +1,324 @@
+#
+# Author:: Sölvi Páll Ásgeirsson (<solvip@gmail.com>)
+# Author:: Richard Lavey (richard.lavey@calastone.com)
+# Author:: Tim Smith (tsmith@chef.io)
+#
+# Copyright:: 2014-2017, Sölvi Páll Ásgeirsson.
+# Copyright:: 2018, Chef Software, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "chef/resource"
+require "chef/json_compat"
+require "chef/util/path_helper"
+
+class Chef
+  class Resource
+    class WindowsShare < Chef::Resource
+      preview_resource true
+      resource_name :windows_share
+
+      description "Use the windows_share resource to create, modify and remove Windows shares."
+      introduced "14.7"
+
+      # Specifies a name for the SMB share. The name may be composed of any valid file name characters, but must be less than 80 characters long. The names pipe and mailslot are reserved for use by the computer.
+      property :share_name, String,
+               description: "An optional property to set the share name if it differs from the resource block's name.",
+               name_property: true
+
+      # Specifies the path of the location of the folder to share. The path must be fully qualified. Relative paths or paths that contain wildcard characters are not permitted.
+      property :path, String,
+               description: "The path of the folder to share. Required when creating. If the share already exists on a different path then it is deleted and re-created."
+
+      # Specifies an optional description of the SMB share. A description of the share is displayed by running the Get-SmbShare cmdlet. The description may not contain more than 256 characters.
+      property :description, String,
+               description: "The description to be applied to the share.",
+               default: ""
+
+      # Specifies which accounts are granted full permission to access the share. Use a comma-separated list to specify multiple accounts. An account may not be specified more than once in the FullAccess, ChangeAccess, or ReadAccess parameter lists, but may be specified once in the FullAccess, ChangeAccess, or ReadAccess parameter list and once in the NoAccess parameter list.
+      property :full_users, Array,
+               description: "The users that should have 'Full control' permissions on the share in domain\\username format.",
+               default: lazy { [] }, coerce: proc { |u| u.sort }
+
+      # Specifies which users are granted modify permission to access the share
+      property :change_users, Array,
+               description: "The users that should have 'modify' permission on the share in domain\\username format.",
+               default: lazy { [] }, coerce: proc { |u| u.sort }
+
+      # Specifies which users are granted read permission to access the share. Multiple users can be specified by supplying a comma-separated list.
+      property :read_users, Array,
+               description: "The users that should have 'read' permission on the share in domain\\username format.",
+               default: lazy { [] }, coerce: proc { |u| u.sort }
+
+      # Specifies the lifetime of the new SMB share. A temporary share does not persist beyond the next restart of the computer. By default, new SMB shares are persistent, and non-temporary.
+      property :temporary, [TrueClass, FalseClass],
+               description: "The lifetime of the new SMB share. A temporary share does not persist beyond the next restart of the computer.",
+               default: false
+
+      # Specifies the scope name of the share.
+      property :scope_name, String,
+               description: "The scope name of the share.",
+               default: "*"
+
+      # Specifies the continuous availability time-out for the share.
+      property :ca_timeout, Integer,
+               description: "The continuous availability time-out for the share.",
+               default: 0
+
+      # Indicates that the share is continuously available.
+      property :continuously_available, [TrueClass, FalseClass],
+               description: "Indicates that the share is continuously available.",
+               default: false
+
+      # Specifies the caching mode of the offline files for the SMB share.
+      # property :caching_mode, String, equal_to: %w(None Manual Documents Programs BranchCache)
+
+      # Specifies the maximum number of concurrently connected users that the new SMB share may accommodate. If this parameter is set to zero (0), then the number of users is unlimited.
+      property :concurrent_user_limit, Integer,
+               description: "The maximum number of concurrently connected users the share can accommodate.",
+               default: 0
+
+      # Indicates that the share is encrypted.
+      property :encrypt_data, [TrueClass, FalseClass],
+               description: "Indicates that the share is encrypted.",
+               default: false
+
+      # Specifies which files and folders in the SMB share are visible to users. AccessBased: SMB does not the display the files and folders for a share to a user unless that user has rights to access the files and folders. By default, access-based enumeration is disabled for new SMB shares. Unrestricted: SMB displays files and folders to a user even when the user does not have permission to access the items.
+      # property :folder_enumeration_mode, String, equal_to: %(AccessBased Unrestricted)
+
+      include Chef::Mixin::PowershellOut
+
+      load_current_value do |desired|
+        # this command selects individual objects because EncryptData & CachingMode have underlying
+        # types that get converted to their Integer values by ConvertTo-Json & we need to make sure
+        # those get written out as strings
+        share_state_cmd = "Get-SmbShare -Name '#{desired.share_name}' | Select-Object Name,Path, Description, Temporary, CATimeout, ContinuouslyAvailable, ConcurrentUserLimit, EncryptData | ConvertTo-Json -Compress"
+
+        Chef::Log.debug("Running '#{share_state_cmd}' to determine share state'")
+        ps_results = powershell_out(share_state_cmd)
+
+        # detect a failure without raising and then set current_resource to nil
+        if ps_results.error?
+          Chef::Log.debug("Error fetching share state: #{ps_results.stderr}")
+          current_value_does_not_exist!
+        end
+
+        Chef::Log.debug("The Get-SmbShare results were #{ps_results.stdout}")
+        results = Chef::JSONCompat.from_json(ps_results.stdout)
+
+        path results["Path"]
+        description results["Description"]
+        temporary results["Temporary"]
+        ca_timeout results["CATimeout"]
+        continuously_available results["ContinuouslyAvailable"]
+        # caching_mode results['CachingMode']
+        concurrent_user_limit results["ConcurrentUserLimit"]
+        encrypt_data results["EncryptData"]
+        # folder_enumeration_mode results['FolderEnumerationMode']
+
+        perm_state_cmd = %{Get-SmbShareAccess -Name "#{desired.share_name}" | Select-Object AccountName,AccessControlType,AccessRight | ConvertTo-Json -Compress}
+
+        Chef::Log.debug("Running '#{perm_state_cmd}' to determine share permissions state'")
+        ps_perm_results = powershell_out(perm_state_cmd)
+
+        # we raise here instead of warning like above because we'd only get here if the above Get-SmbShare
+        # command was successful and that continuing would leave us with 1/2 known state
+        raise "Could not determine #{desired.share_name} share permissions by running '#{perm_state_cmd}'" if ps_perm_results.error?
+
+        Chef::Log.debug("The Get-SmbShareAccess results were #{ps_perm_results.stdout}")
+
+        f_users, c_users, r_users = parse_permissions(ps_perm_results.stdout)
+
+        full_users f_users
+        change_users c_users
+        read_users r_users
+      end
+
+      def after_created
+        raise "The windows_share resource relies on PowerShell cmdlets not present in Windows releases prior to 8/2012. Cannot continue!" if node["platform_version"].to_f < 6.3
+      end
+
+# given the string output of Get-SmbShareAccess parse out
+# arrays of full access users, change users, and read only users
+      def parse_permissions(results_string)
+        json_results = Chef::JSONCompat.from_json(results_string)
+        json_results = [json_results] unless json_results.is_a?(Array) # single result is not an array
+
+        f_users = []
+        c_users = []
+        r_users = []
+
+        json_results.each do |perm|
+          next unless perm["AccessControlType"] == 0 # allow
+          case perm["AccessRight"]
+          when 0 then f_users << stripped_account(perm["AccountName"]) # 0 full control
+          when 1 then c_users << stripped_account(perm["AccountName"]) # 1 == change
+          when 2 then r_users << stripped_account(perm["AccountName"]) # 2 == read
+          end
+        end
+        [f_users, c_users, r_users]
+      end
+
+# local names are returned from Get-SmbShareAccess in the full format MACHINE\\NAME
+# but users of this resource would simply say NAME so we need to strip the values for comparison
+      def stripped_account(name)
+        name.slice!("#{node['hostname']}\\")
+        name
+      end
+
+      action :create do
+        description "Create and modify Windows shares."
+
+        # we do this here instead of requiring the property because :delete doesn't need path set
+        raise "No path property set" unless new_resource.path
+
+        converge_if_changed do
+          # you can't actually change the path so you have to delete the old share first
+          if different_path?
+            Chef::Log.debug("The path has changed so we will delete and recreate share")
+            delete_share
+            create_share
+          elsif current_resource.nil?
+            # powershell cmdlet for create is different than updates
+            Chef::Log.debug("The current resource is nil so we will create a new share")
+            create_share
+          else
+            Chef::Log.debug("The current resource was not nil so we will update an existing share")
+            update_share
+          end
+
+          # creating the share does not set permissions so we need to update
+          update_permissions
+        end
+      end
+
+      action :delete do
+        description "Delete an existing Windows share."
+
+        if current_resource.nil?
+          Chef::Log.debug("#{new_resource.share_name} does not exist - nothing to do")
+        else
+          converge_by("delete #{new_resource.share_name}") do
+            delete_share
+          end
+        end
+      end
+
+      action_class do
+        def different_path?
+          return false if current_resource.nil? # going from nil to something isn't different for our concerns
+          return false if current_resource.path == Chef::Util::PathHelper.cleanpath(new_resource.path)
+          true
+        end
+
+        def delete_share
+          delete_command = "Remove-SmbShare -Name '#{new_resource.share_name}' -Force"
+
+          Chef::Log.debug("Running '#{delete_command}' to remove the share")
+          powershell_out!(delete_command)
+        end
+
+        def update_share
+          update_command = "Set-SmbShare -Name '#{new_resource.share_name}' -Description '#{new_resource.description}' -Force"
+
+          Chef::Log.debug("Running '#{update_command}' to update the share")
+          powershell_out!(update_command)
+        end
+
+        def create_share
+          raise "#{new_resource.path} is missing or not a directory. Shares cannot be created if the path doesn't first exist." unless ::File.directory? new_resource.path
+
+          share_cmd = "New-SmbShare -Name '#{new_resource.share_name}' -Path '#{Chef::Util::PathHelper.cleanpath(new_resource.path)}' -Description '#{new_resource.description}' -ConcurrentUserLimit #{new_resource.concurrent_user_limit} -CATimeout #{new_resource.ca_timeout} -EncryptData:#{bool_string(new_resource.encrypt_data)} -ContinuouslyAvailable:#{bool_string(new_resource.continuously_available)}"
+          share_cmd << " -ScopeName #{new_resource.scope_name}" unless new_resource.scope_name == "*" # passing * causes the command to fail
+          share_cmd << " -Temporary:#{bool_string(new_resource.temporary)}" if new_resource.temporary # only set true
+
+          Chef::Log.debug("Running '#{share_cmd}' to create the share")
+          powershell_out!(share_cmd)
+
+          # New-SmbShare adds the "Everyone" user with read access no matter what so we need to remove it
+          # before we add our permissions
+          revoke_user_permissions(["Everyone"])
+        end
+
+        # determine what users in the current state don't exist in the desired state
+        # users/groups will have their permissions updated with the same command that
+        # sets it, but removes must be performed with Revoke-SmbShareAccess
+        def users_to_revoke
+          @users_to_revoke ||= begin
+            # if the resource doesn't exist then nothing needs to be revoked
+            if current_resource.nil?
+              []
+            else # if it exists then calculate the current to new resource diffs
+              (current_resource.full_users + current_resource.change_users + current_resource.read_users) - (new_resource.full_users + new_resource.change_users + new_resource.read_users)
+            end
+          end
+        end
+
+        # update existing permissions on a share
+        def update_permissions
+          # revoke any users that had something, but now has nothing
+          revoke_user_permissions(users_to_revoke) unless users_to_revoke.empty?
+
+          # set permissions for each of the permission types
+          %w{full read change}.each do |perm_type|
+            # set permissions for a brand new share OR
+            # update permissions if the current state and desired state differ
+            next unless permissions_need_update?(perm_type)
+            grant_command = "Grant-SmbShareAccess -Name '#{new_resource.share_name}' -AccountName \"#{new_resource.send("#{perm_type}_users").join('","')}\" -Force -AccessRight #{perm_type}"
+
+            Chef::Log.debug("Running '#{grant_command}' to update the share permissions")
+            powershell_out!(grant_command)
+          end
+        end
+
+        # determine if permissions need to be updated.
+        # Brand new share with no permissions defined: no
+        # Brand new share with permissions defined: yes
+        # Existing share with differing permissions: yes
+        #
+        # @param [String] type the permissions type (Full, Read, or Change)
+        def permissions_need_update?(type)
+          property_name = "#{type}_users"
+
+          # brand new share, but nothing to set
+          return false if current_resource.nil? && new_resource.send(property_name).empty?
+
+          # brand new share with new permissions to set
+          return true if current_resource.nil? && !new_resource.send(property_name).empty?
+
+          # there's a difference between the current and desired state
+          return true unless (new_resource.send(property_name) - current_resource.send(property_name)).empty?
+
+          # anything else
+          false
+        end
+
+        # revoke user permissions from a share
+        # @param [Array] users
+        def revoke_user_permissions(users)
+          revoke_command = "Revoke-SmbShareAccess -Name '#{new_resource.share_name}' -AccountName \"#{users.join('","')}\" -Force"
+          Chef::Log.debug("Running '#{revoke_command}' to revoke share permissions")
+          powershell_out!(revoke_command)
+        end
+
+        # convert True/False into "$True" & "$False"
+        def bool_string(bool)
+          # bool ? 1 : 0
+          bool ? "$true" : "$false"
+        end
+      end
+
+    end
+  end
+end

data/lib/chef/resource/windows_shortcut.rb

@@ -0,0 +1,79 @@
+#
+# Author:: Doug MacEachern <dougm@vmware.com>
+# Copyright:: 2010-2018, VMware, Inc.
+# Copyright:: 2017-2018, Chef Software, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "chef/resource"
+
+class Chef
+  class Resource
+    class WindowsShortcut < Chef::Resource
+      resource_name :windows_shortcut
+      provides(:windows_shortcut) { true }
+
+      description "Use the windows_shortcut resource to create shortcut files on Windows."
+      introduced "14.0"
+
+      property :shortcut_name, String,
+               description: "An optional property to set the shortcut name if it differs from the resource block's name.",
+               name_property: true
+
+      property :target, String,
+               description: "The destination that the shortcut links to."
+
+      property :arguments, String,
+               description: "Arguments to pass to the target when the shortcut is executed."
+
+      property :description, String,
+               description: "The description of the shortcut"
+
+      property :cwd, String,
+               description: "Working directory to use when the target is executed."
+
+      property :iconlocation, String,
+               description: "Icon to use for the shortcut. Accepts the format of 'path, index', where index is the icon file to use. See https://msdn.microsoft.com/en-us/library/3s9bx7at.aspx for details"
+
+      load_current_value do |desired|
+        require "win32ole" if RUBY_PLATFORM =~ /mswin|mingw32|windows/
+
+        link = WIN32OLE.new("WScript.Shell").CreateShortcut(desired.shortcut_name)
+        name desired.shortcut_name
+        target(link.TargetPath)
+        arguments(link.Arguments)
+        description(link.Description)
+        cwd(link.WorkingDirectory)
+        iconlocation(link.IconLocation)
+      end
+
+      action :create do
+        description "Create or modify a Windows shortcut."
+
+        converge_if_changed do
+          converge_by "creating shortcut #{new_resource.shortcut_name}" do
+            link = WIN32OLE.new("WScript.Shell").CreateShortcut(new_resource.shortcut_name)
+            link.TargetPath = new_resource.target unless new_resource.target.nil?
+            link.Arguments = new_resource.arguments unless new_resource.arguments.nil?
+            link.Description = new_resource.description unless new_resource.description.nil?
+            link.WorkingDirectory = new_resource.cwd unless new_resource.cwd.nil?
+            link.IconLocation = new_resource.iconlocation unless new_resource.iconlocation.nil?
+            # ignoring: WindowStyle, Hotkey
+            link.Save
+          end
+        end
+      end
+    end
+  end
+end

data/lib/chef/resource/windows_task.rb

@@ -0,0 +1,349 @@
+#
+# Author:: Nimisha Sharad (<nimisha.sharad@msystechnologies.com>)
+# Copyright:: Copyright 2008-2016, Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "chef/resource"
+require "chef/win32/security" if Chef::Platform.windows?
+
+class Chef
+  class Resource
+    class WindowsTask < Chef::Resource
+      resource_name :windows_task
+      provides(:windows_task) { true }
+
+      description "Use the windows_task resource to create, delete or run a Windows scheduled task. Requires Windows Server 2008 or later due to API usage."
+      introduced "13.0"
+
+      allowed_actions :create, :delete, :run, :end, :enable, :disable, :change
+      default_action :create
+
+      property :task_name, String, regex: [/\A[^\/\:\*\?\<\>\|]+\z/],
+               description: "An optional property to set the task name if it differs from the resource block's name. Example: 'Task Name' or '/Task Name'",
+               name_property: true
+
+      property :command, String,
+               description: "The command to be executed by the windows scheduled task."
+
+      property :cwd, String,
+               description: "The directory the task will be run from."
+
+      property :user, String,
+               description: "The user to run the task as.",
+               default: lazy { Chef::ReservedNames::Win32::Security::SID.LocalSystem.account_simple_name if Chef::Platform.windows? },
+               default_description: "The localized SYSTEM user for the node."
+
+      property :password, String,
+               description: "The user’s password. The user property must be set if using this property."
+
+      property :run_level, Symbol, equal_to: [:highest, :limited],
+               description: "Run with ':limited' or ':highest' privileges.",
+               default: :limited
+
+      property :force, [TrueClass, FalseClass],
+               description: "When used with create, will update the task.",
+               default: false
+
+      property :interactive_enabled, [TrueClass, FalseClass],
+               description: "Allow task to run interactively or non-interactively. Requires user and password to also be set.",
+               default: false
+
+      property :frequency_modifier, [Integer, String],
+               default: 1
+
+      property :frequency, Symbol, equal_to: [:minute,
+                                              :hourly,
+                                              :daily,
+                                              :weekly,
+                                              :monthly,
+                                              :once,
+                                              :on_logon,
+                                              :onstart,
+                                              :on_idle,
+                                              :none],
+               description: "The frequency with which to run the task."
+
+      property :start_day, String,
+               description: "Specifies the first date on which the task runs in MM/DD/YYYY format."
+
+      property :start_time, String,
+               description: "Specifies the start time to run the task, in HH:mm format."
+
+      property :day, [String, Integer],
+               description: "The day(s) on which the task runs."
+
+      property :months, String,
+               description: "The Months of the year on which the task runs, such as: 'JAN, FEB' or '\*'. Multiple months should be comma delimited. e.g. 'Jan, Feb, Mar, Dec'."
+
+      property :idle_time, Integer,
+               description: "For :on_idle frequency, the time (in minutes) without user activity that must pass to trigger the task, from 1 - 999."
+
+      property :random_delay, [String, Integer],
+               description: "Delays the task up to a given time (in seconds)."
+
+      property :execution_time_limit, [String, Integer],
+               description: "The maximum time (in seconds) the task will run.",
+               default: "PT72H" # 72 hours in ISO8601 duration format
+
+      property :minutes_duration, [String, Integer],
+               description: ""
+
+      property :minutes_interval, [String, Integer],
+               description: ""
+
+      property :priority, Integer,
+               description: "Use to set Priority Levels range from 0 to 10.",
+               default: 7, callbacks: { "should be in range of 0 to 10" => proc { |v| v >= 0 && v <= 10 } }
+
+      property :disallow_start_if_on_batteries, [TrueClass, FalseClass],
+               introduced: "14.4", default: false,
+               description: "Disallow start of the task if the system is running on battery power."
+
+      property :stop_if_going_on_batteries, [TrueClass, FalseClass],
+               introduced: "14.4", default: false,
+               description: "Scheduled task option when system is switching on battery."
+
+      property :description, String,
+               introduced: "14.7",
+               description: "The task description."
+
+      attr_accessor :exists, :task, :command_arguments
+
+      VALID_WEEK_DAYS = %w{ mon tue wed thu fri sat sun * }.freeze
+      VALID_DAYS_OF_MONTH = ("1".."31").to_a << "last" << "lastday"
+      VALID_MONTHS = %w{JAN FEB MAR APR MAY JUN JUL AUG SEP OCT NOV DEC *}.freeze
+      VALID_WEEKS = %w{FIRST SECOND THIRD FOURTH LAST LASTDAY}.freeze
+
+      def after_created
+        if random_delay
+          validate_random_delay(random_delay, frequency)
+          random_delay(sec_to_min(random_delay))
+        end
+
+        if execution_time_limit
+          execution_time_limit(259200) if execution_time_limit == "PT72H"
+          raise ArgumentError, "Invalid value passed for `execution_time_limit`. Please pass seconds as an Integer (e.g. 60) or a String with numeric values only (e.g. '60')." unless numeric_value_in_string?(execution_time_limit)
+          execution_time_limit(sec_to_min(execution_time_limit))
+        end
+
+        validate_frequency(frequency) if action.include?(:create) || action.include?(:change)
+        validate_start_time(start_time, frequency)
+        validate_start_day(start_day, frequency) if start_day
+        validate_user_and_password(user, password)
+        validate_create_frequency_modifier(frequency, frequency_modifier) if frequency_modifier
+        validate_create_day(day, frequency, frequency_modifier) if day
+        validate_create_months(months, frequency) if months
+        validate_frequency_monthly(frequency_modifier, months, day) if frequency == :monthly
+        validate_idle_time(idle_time, frequency)
+        idempotency_warning_for_frequency_weekly(day, start_day) if frequency == :weekly
+      end
+
+      private
+
+        ## Resource is not idempotent when day, start_day is not provided with frequency :weekly
+        ## we set start_day when not given by user as current date based on which we set the day property for current current date day is monday ..
+        ## we set the monday as the day so at next run when  new_resource.day is nil and current_resource day is monday due to which udpate gets called
+      def idempotency_warning_for_frequency_weekly(day, start_day)
+        if start_day.nil? && day.nil?
+          logger.warn "To maintain idempotency for frequency :weekly provide start_day, start_time and day."
+        end
+      end
+
+        # Validate the passed value is numeric values only if it is a string
+      def numeric_value_in_string?(val)
+        return true if Integer(val)
+      rescue ArgumentError
+        false
+      end
+
+      def validate_frequency(frequency)
+        if frequency.nil? || !([:minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none].include?(frequency))
+          raise ArgumentError, "Frequency needs to be provided. Valid frequencies are :minute, :hourly, :daily, :weekly, :monthly, :once, :on_logon, :onstart, :on_idle, :none."
+        end
+      end
+
+      def validate_frequency_monthly(frequency_modifier, months, day)
+        # validates the frequency :monthly and raises error if frequency_modifier is first, second, thrid etc and day is not provided
+        if (frequency_modifier != 1) && (frequency_modifier_includes_days_of_weeks?(frequency_modifier)) && !(day)
+          raise ArgumentError, "Please select day on which you want to run the task e.g. 'Mon, Tue'. Multiple values must be seprated by comma."
+        end
+
+        # frequency_modifer 2-12 is used to set every (n) months, so using :months propety with frequency_modifer is not valid since they both used to set months.
+        # Not checking value 1 here for frequecy_modifier since we are setting that as default value it won't break anything since preference is given to months property
+        if (frequency_modifier.to_i.between?(2, 12)) && !(months.nil?)
+          raise ArgumentError, "For frequency :monthly either use property months or frequency_modifier to set months."
+        end
+      end
+
+        # returns true if frequency_modifer has values First, second, third, fourth, last, lastday
+      def frequency_modifier_includes_days_of_weeks?(frequency_modifier)
+        frequency_modifier = frequency_modifier.to_s.split(",")
+        frequency_modifier.map! { |value| value.strip.upcase }
+        (frequency_modifier - VALID_WEEKS).empty?
+      end
+
+      def validate_random_delay(random_delay, frequency)
+        if [:on_logon, :onstart, :on_idle, :none].include? frequency
+          raise ArgumentError, "`random_delay` property is supported only for frequency :once, :minute, :hourly, :daily, :weekly and :monthly"
+        end
+
+        raise ArgumentError, "Invalid value passed for `random_delay`. Please pass seconds as an Integer (e.g. 60) or a String with numeric values only (e.g. '60')." unless numeric_value_in_string?(random_delay)
+      end
+
+        # @todo when we drop ruby 2.3 support this should be converted to .match?() instead of =~f
+      def validate_start_day(start_day, frequency)
+        if start_day && frequency == :none
+          raise ArgumentError, "`start_day` property is not supported with frequency: #{frequency}"
+        end
+
+        # make sure the start_day is in MM/DD/YYYY format: http://rubular.com/r/cgjHemtWl5
+        if start_day
+          raise ArgumentError, "`start_day` property must be in the MM/DD/YYYY format." unless /^(0[1-9]|1[012])[- \/.](0[1-9]|[12][0-9]|3[01])[- \/.](19|20)\d\d$/ =~ start_day
+        end
+      end
+
+        # @todo when we drop ruby 2.3 support this should be converted to .match?() instead of =~
+      def validate_start_time(start_time, frequency)
+        if start_time
+          raise ArgumentError, "`start_time` property is not supported with `frequency :none`" if frequency == :none
+          raise ArgumentError, "`start_time` property must be in the HH:mm format (e.g. 6:20pm -> 18:20)." unless /^[0-2][0-9]:[0-5][0-9]$/ =~ start_time
+        else
+          raise ArgumentError, "`start_time` needs to be provided with `frequency :once`" if frequency == :once
+        end
+      end
+
+      # System users will not require a password
+      # Other users will require a password if the task is non-interactive.
+      #
+      # @param [String] user
+      # @param [String] password
+      #
+      def validate_user_and_password(user, password)
+        if non_system_user?(user)
+          if password.nil? && !interactive_enabled
+            raise ArgumentError, "Please provide a password or check if this task needs to be interactive! Valid passwordless users are: '#{Chef::ReservedNames::Win32::Security::SID::SYSTEM_USER.join("', '")}'"
+          end
+        else
+          unless password.nil?
+            raise ArgumentError, "Password is not required for system users."
+          end
+        end
+      end
+
+      # Password is not required for system user and required for non-system user.
+      def password_required?(user)
+        @password_required ||= (!user.nil? && !Chef::ReservedNames::Win32::Security::SID.system_user?(user))
+      end
+
+      alias non_system_user? password_required?
+
+      def validate_create_frequency_modifier(frequency, frequency_modifier)
+        if ([:on_logon, :onstart, :on_idle, :none].include?(frequency)) && ( frequency_modifier != 1)
+          raise ArgumentError, "frequency_modifier property not supported with frequency :#{frequency}"
+        end
+
+        if frequency == :monthly
+          unless (1..12).cover?(frequency_modifier.to_i) || frequency_modifier_includes_days_of_weeks?(frequency_modifier)
+            raise ArgumentError, "frequency_modifier value #{frequency_modifier} is invalid. Valid values for :monthly frequency are 1 - 12, 'FIRST', 'SECOND', 'THIRD', 'FOURTH', 'LAST'."
+          end
+        else
+          unless frequency.nil? || frequency_modifier.nil?
+            frequency_modifier = frequency_modifier.to_i
+            min = 1
+            max = case frequency
+                    when :minute
+                      1439
+                    when :hourly
+                      23
+                    when :daily
+                      365
+                    when :weekly
+                      52
+                    else
+                      min
+                  end
+            unless frequency_modifier.between?(min, max)
+              raise ArgumentError, "frequency_modifier value #{frequency_modifier} is invalid. Valid values for :#{frequency} frequency are #{min} - #{max}."
+            end
+          end
+        end
+      end
+
+      def validate_create_day(day, frequency, frequency_modifier)
+        raise ArgumentError, "day property is only valid for tasks that run monthly or weekly" unless [:weekly, :monthly].include?(frequency)
+
+        # This has been verified with schtask.exe https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/schtasks#d-dayday--
+        # verified with earlier code if day "*" is given with frequency it raised exception Invalid value for /D option
+        raise ArgumentError, "day wild card (*) is only valid with frequency :weekly" if frequency == :monthly && day == "*"
+
+        if day.is_a?(String) && day.to_i.to_s != day
+          days = day.split(",")
+          if days_includes_days_of_months?(days)
+            # Following error will be raise if day is set as 1-31 and frequency is selected as :weekly since those values are valid with only frequency :monthly
+            raise ArgumentError, "day values 1-31 or last is only valid with frequency :monthly" if frequency == :weekly
+          else
+            days.map! { |day| day.to_s.strip.downcase }
+            unless (days - VALID_WEEK_DAYS).empty?
+              raise ArgumentError, "day property invalid. Only valid values are: #{VALID_WEEK_DAYS.map(&:upcase).join(', ')}. Multiple values must be separated by a comma."
+            end
+          end
+        end
+      end
+
+      def validate_create_months(months, frequency)
+        raise ArgumentError, "months property is only valid for tasks that run monthly" if frequency != :monthly
+        if months.is_a?(String)
+          months = months.split(",")
+          months.map! { |month| month.strip.upcase }
+          unless (months - VALID_MONTHS).empty?
+            raise ArgumentError, "months property invalid. Only valid values are: #{VALID_MONTHS.join(', ')}. Multiple values must be separated by a comma."
+          end
+        end
+      end
+
+        # This method returns true if day has values from 1-31 which is a days of moths and used with frequency :monthly
+      def days_includes_days_of_months?(days)
+        days.map! { |day| day.to_s.strip.downcase }
+        (days - VALID_DAYS_OF_MONTH).empty?
+      end
+
+      def validate_idle_time(idle_time, frequency)
+        if !idle_time.nil? && frequency != :on_idle
+          raise ArgumentError, "idle_time property is only valid for tasks that run on_idle"
+        end
+        if idle_time.nil? && frequency == :on_idle
+          raise ArgumentError, "idle_time value should be set for :on_idle frequency."
+        end
+        unless idle_time.nil? || idle_time > 0 && idle_time <= 999
+          raise ArgumentError, "idle_time value #{idle_time} is invalid. Valid values for :on_idle frequency are 1 - 999."
+        end
+      end
+
+        # Converts the number of seconds to an ISO8601 duration format and returns it.
+        # Ref : https://github.com/arnau/ISO8601/blob/master/lib/iso8601/duration.rb#L18-L23
+        # e.g.
+        # ISO8601::Duration.new(65707200).to_s
+        # returns 'PT65707200S'
+      def sec_to_dur(seconds)
+        ISO8601::Duration.new(seconds.to_i).to_s
+      end
+
+      def sec_to_min(seconds)
+        seconds.to_i / 60
+      end
+    end
+  end
+end