chef 12.0.1 → 12.0.3

data/spec/unit/mixin/shell_out_spec.rb

@@ -23,10 +23,10 @@
 require 'spec_helper'
 
 describe Chef::Mixin::ShellOut do
-  include Chef::Mixin::ShellOut
-
+  let(:shell_out_class) { Class.new { include Chef::Mixin::ShellOut } }
+  subject(:shell_out_obj) { shell_out_class.new }
   describe '#run_command_compatible_options' do
-    subject { run_command_compatible_options(command_args) }
+    subject { shell_out_obj.run_command_compatible_options(command_args) }
     let(:command_args) { [ cmd, options ] }
     let(:cmd) { "echo '#{rand(1000)}'" }
 
@@ -117,7 +117,6 @@ describe Chef::Mixin::ShellOut do
       ENV.update(@original_env)
     end
 
-    let(:shell_out) { Chef::Mixin::ShellOut }
     let(:cmd) { "echo '#{rand(1000)}'" }
 
     describe "#shell_out" do
@@ -126,30 +125,30 @@ describe Chef::Mixin::ShellOut do
         describe "and environment is an option" do
           it "should not change environment['LC_ALL'] when set to nil" do
             options = { :environment => { 'LC_ALL' => nil } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out(cmd, options)
           end
 
           it "should not change environment['LC_ALL'] when set to non-nil" do
             options = { :environment => { 'LC_ALL' => 'en_US.UTF-8' } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out(cmd, options)
           end
 
           it "should set environment['LC_ALL'] to 'en_US.UTF-8' when 'LC_ALL' not present" do
             options = { :environment => { 'HOME' => '/Users/morty' } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, {
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, {
               :environment => { 'HOME' => '/Users/morty', 'LC_ALL' => Chef::Config[:internal_locale] },
             }).and_return(true)
-            shell_out.shell_out(cmd, options)
+            shell_out_obj.shell_out(cmd, options)
           end
 
           it "should not mutate the options hash when it adds LC_ALL" do
             options = { :environment => { 'HOME' => '/Users/morty' } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, {
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, {
               :environment => { 'HOME' => '/Users/morty', 'LC_ALL' => Chef::Config[:internal_locale] },
             }).and_return(true)
-            shell_out.shell_out(cmd, options)
+            shell_out_obj.shell_out(cmd, options)
             expect(options[:environment].has_key?('LC_ALL')).to be false
           end
         end
@@ -157,30 +156,30 @@ describe Chef::Mixin::ShellOut do
         describe "and env is an option" do
           it "should not change env when set to nil" do
             options = { :env => { 'LC_ALL' => nil } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out(cmd, options)
           end
 
           it "should not change env when set to non-nil" do
             options = { :env => { 'LC_ALL' => 'de_DE.UTF-8'}}
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out(cmd, options)
           end
 
           it "should set env['LC_ALL'] to 'en_US.UTF-8' when 'LC_ALL' not present" do
             options = { :env => { 'HOME' => '/Users/morty' } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, {
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, {
               :env => { 'HOME' => '/Users/morty', 'LC_ALL' => Chef::Config[:internal_locale] },
             }).and_return(true)
-            shell_out.shell_out(cmd, options)
+            shell_out_obj.shell_out(cmd, options)
           end
 
           it "should not mutate the options hash when it adds LC_ALL" do
             options = { :env => { 'HOME' => '/Users/morty' } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, {
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, {
               :env => { 'HOME' => '/Users/morty', 'LC_ALL' => Chef::Config[:internal_locale] },
             }).and_return(true)
-            shell_out.shell_out(cmd, options)
+            shell_out_obj.shell_out(cmd, options)
             expect(options[:env].has_key?('LC_ALL')).to be false
           end
         end
@@ -188,20 +187,20 @@ describe Chef::Mixin::ShellOut do
         describe "and no env/environment option is present" do
           it "should add environment option and set environment['LC_ALL'] to 'en_US.UTF_8'" do
             options = { :user => 'morty' }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, {
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, {
               :user => 'morty', :environment => { 'LC_ALL' => Chef::Config[:internal_locale] },
             }).and_return(true)
-            shell_out.shell_out(cmd, options)
+            shell_out_obj.shell_out(cmd, options)
           end
         end
       end
 
       describe "when the last argument is not a Hash" do
         it "should add environment options and set environment['LC_ALL'] to 'en_US.UTF-8'" do
-          expect(shell_out).to receive(:shell_out_command).with(cmd, {
+          expect(shell_out_obj).to receive(:shell_out_command).with(cmd, {
             :environment => { 'LC_ALL' => Chef::Config[:internal_locale] },
           }).and_return(true)
-          shell_out.shell_out(cmd)
+          shell_out_obj.shell_out(cmd)
         end
       end
 
@@ -213,56 +212,56 @@ describe Chef::Mixin::ShellOut do
         describe "and environment is an option" do
           it "should not change environment['LC_ALL'] when set to nil" do
             options = { :environment => { 'LC_ALL' => nil } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out_with_systems_locale(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out_with_systems_locale(cmd, options)
           end
 
           it "should not change environment['LC_ALL'] when set to non-nil" do
             options = { :environment => { 'LC_ALL' => 'en_US.UTF-8' } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out_with_systems_locale(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out_with_systems_locale(cmd, options)
           end
 
           it "should no longer set environment['LC_ALL'] to nil when 'LC_ALL' not present" do
             options = { :environment => { 'HOME' => '/Users/morty' } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out_with_systems_locale(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out_with_systems_locale(cmd, options)
           end
         end
 
         describe "and env is an option" do
           it "should not change env when set to nil" do
             options = { :env => { 'LC_ALL' => nil } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out_with_systems_locale(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out_with_systems_locale(cmd, options)
           end
 
           it "should not change env when set to non-nil" do
             options = { :env => { 'LC_ALL' => 'en_US.UTF-8'}}
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out_with_systems_locale(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out_with_systems_locale(cmd, options)
           end
 
           it "should no longer set env['LC_ALL'] to nil when 'LC_ALL' not present" do
             options = { :env => { 'HOME' => '/Users/morty' } }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out_with_systems_locale(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out_with_systems_locale(cmd, options)
           end
         end
 
         describe "and no env/environment option is present" do
           it "should no longer add environment option and set environment['LC_ALL'] to nil" do
             options = { :user => 'morty' }
-            expect(shell_out).to receive(:shell_out_command).with(cmd, options).and_return(true)
-            shell_out.shell_out_with_systems_locale(cmd, options)
+            expect(shell_out_obj).to receive(:shell_out_command).with(cmd, options).and_return(true)
+            shell_out_obj.shell_out_with_systems_locale(cmd, options)
           end
         end
       end
 
       describe "when the last argument is not a Hash" do
         it "should no longer add environment options and set environment['LC_ALL'] to nil" do
-          expect(shell_out).to receive(:shell_out_command).with(cmd).and_return(true)
-          shell_out.shell_out_with_systems_locale(cmd)
+          expect(shell_out_obj).to receive(:shell_out_command).with(cmd).and_return(true)
+          shell_out_obj.shell_out_with_systems_locale(cmd)
         end
       end
     end

data/spec/unit/node_spec.rb

@@ -1213,6 +1213,40 @@ describe Chef::Node do
           node.save
         end
 
+        it "should save false-y whitelisted attributes" do
+          Chef::Config[:default_attribute_whitelist] = [
+            "foo/bar/baz"
+          ]
+
+          data = {
+            "default" => {
+              "foo" => {
+                "bar" => {
+                  "baz" => false,
+                },
+                "other" => {
+                  "stuff" => true,
+                }
+              }
+            }
+          }
+
+          selected_data = {
+            "default" => {
+              "foo" => {
+                "bar" => {
+                  "baz" => false,
+                }
+              }
+            }
+          }
+
+          node.name("falsey-monkey")
+          allow(node).to receive(:for_json).and_return(data)
+          expect(@rest).to receive(:put_rest).with("nodes/falsey-monkey", selected_data).and_return("foo")
+          node.save
+        end
+
         it "should not save any attributes if the whitelist is empty" do
           Chef::Config[:automatic_attribute_whitelist] = []
 

data/spec/unit/provider/link_spec.rb

@@ -38,8 +38,8 @@ describe Chef::Resource::Link, :not_supported_on_win2k3 do
     result
   end
 
-  def paths_eql?(path1, path2)
-    Chef::Util::PathHelper.paths_eql?(path1, path2)
+  def canonicalize(path)
+    Chef::Platform.windows? ? path.gsub('/', '\\') : path
   end
 
   describe "when the target is a symlink" do
@@ -68,7 +68,7 @@ describe Chef::Resource::Link, :not_supported_on_win2k3 do
         expect(provider.current_resource.link_type).to eq(:symbolic)
       end
       it "should update the source of the existing link with the links target" do
-        expect(paths_eql?(provider.current_resource.to, "#{CHEF_SPEC_DATA}/fofile")).to be_true
+        expect(provider.current_resource.to).to  eq(canonicalize("#{CHEF_SPEC_DATA}/fofile"))
       end
       it "should set the owner" do
         expect(provider.current_resource.owner).to eq(501)
@@ -110,7 +110,7 @@ describe Chef::Resource::Link, :not_supported_on_win2k3 do
         expect(provider.current_resource.link_type).to eq(:symbolic)
       end
       it "should update the source of the existing link to the link's target" do
-        expect(paths_eql?(provider.current_resource.to, "#{CHEF_SPEC_DATA}/fofile")).to be_true
+        expect(provider.current_resource.to).to eq(canonicalize("#{CHEF_SPEC_DATA}/fofile"))
       end
       it "should not set the owner" do
         expect(provider.current_resource.owner).to be_nil
@@ -221,7 +221,7 @@ describe Chef::Resource::Link, :not_supported_on_win2k3 do
         expect(provider.current_resource.link_type).to eq(:hard)
       end
       it "should update the source of the existing link to the link's target" do
-        expect(paths_eql?(provider.current_resource.to, "#{CHEF_SPEC_DATA}/fofile")).to be_true
+        expect(provider.current_resource.to).to eq(canonicalize("#{CHEF_SPEC_DATA}/fofile"))
       end
       it "should not set the owner" do
         expect(provider.current_resource.owner).to eq(nil)

data/spec/unit/provider/package/apt_spec.rb

@@ -20,46 +20,51 @@ require 'spec_helper'
 require 'ostruct'
 
 describe Chef::Provider::Package::Apt do
-  before(:each) do
-    @node = Chef::Node.new
-    @events = Chef::EventDispatch::Dispatcher.new
-    @run_context = Chef::RunContext.new(@node, {}, @events)
-    @new_resource = Chef::Resource::Package.new("irssi", @run_context)
-
-    @status = double("Status", :exitstatus => 0)
-    @provider = Chef::Provider::Package::Apt.new(@new_resource, @run_context)
-    @stdin = StringIO.new
-    @stdout =<<-PKG_STATUS
+  # XXX: sorry this is ugly and was done quickly to get 12.0.2 out, this file needs a rewrite to use
+  # let blocks and shared examples
+  [ Chef::Resource::Package, Chef::Resource::AptPackage ].each do |resource_klass|
+    describe "when the new_resource is a #{resource_klass}" do
+
+      before(:each) do
+        @node = Chef::Node.new
+        @events = Chef::EventDispatch::Dispatcher.new
+        @run_context = Chef::RunContext.new(@node, {}, @events)
+        @new_resource = resource_klass.new("irssi", @run_context)
+
+        @status = double("Status", :exitstatus => 0)
+        @provider = Chef::Provider::Package::Apt.new(@new_resource, @run_context)
+        @stdin = StringIO.new
+        @stdout =<<-PKG_STATUS
 irssi:
   Installed: (none)
   Candidate: 0.8.14-1ubuntu4
   Version table:
      0.8.14-1ubuntu4 0
         500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages
-PKG_STATUS
-    @stderr = ""
-    @shell_out = OpenStruct.new(:stdout => @stdout,:stdin => @stdin,:stderr => @stderr,:status => @status,:exitstatus => 0)
-    @timeout = 900
-  end
-
-  describe "when loading current resource" do
-
-    it "should create a current resource with the name of the new_resource" do
-      expect(@provider).to receive(:shell_out!).with(
-        "apt-cache policy #{@new_resource.package_name}",
-        :timeout => @timeout
-      ).and_return(@shell_out)
-      @provider.load_current_resource
+        PKG_STATUS
+        @stderr = ""
+        @shell_out = OpenStruct.new(:stdout => @stdout,:stdin => @stdin,:stderr => @stderr,:status => @status,:exitstatus => 0)
+        @timeout = 900
+      end
 
-      current_resource = @provider.current_resource
-      expect(current_resource).to be_a(Chef::Resource::Package)
-      expect(current_resource.name).to eq("irssi")
-      expect(current_resource.package_name).to eq("irssi")
-      expect(current_resource.version).to be_nil
-    end
+      describe "when loading current resource" do
 
-    it "should set the installed version if package has one" do
-      @stdout.replace(<<-INSTALLED)
+        it "should create a current resource with the name of the new_resource" do
+          expect(@provider).to receive(:shell_out!).with(
+            "apt-cache policy #{@new_resource.package_name}",
+            :timeout => @timeout
+          ).and_return(@shell_out)
+          @provider.load_current_resource
+
+          current_resource = @provider.current_resource
+          expect(current_resource).to be_a(Chef::Resource::Package)
+          expect(current_resource.name).to eq("irssi")
+          expect(current_resource.package_name).to eq("irssi")
+          expect(current_resource.version).to be_nil
+        end
+
+        it "should set the installed version if package has one" do
+          @stdout.replace(<<-INSTALLED)
 sudo:
   Installed: 1.7.2p1-1ubuntu5.3
   Candidate: 1.7.2p1-1ubuntu5.3
@@ -70,29 +75,29 @@ sudo:
         100 /var/lib/dpkg/status
      1.7.2p1-1ubuntu5 0
         500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages
-INSTALLED
-      expect(@provider).to receive(:shell_out!).and_return(@shell_out)
-      @provider.load_current_resource
-      expect(@provider.current_resource.version).to eq("1.7.2p1-1ubuntu5.3")
-      expect(@provider.candidate_version).to eql("1.7.2p1-1ubuntu5.3")
-    end
-
-    # libmysqlclient-dev is a real package in newer versions of debian + ubuntu
-    # list of virtual packages: http://www.debian.org/doc/packaging-manuals/virtual-package-names-list.txt
-    it "should not install the virtual package there is a single provider package and it is installed" do
-      @new_resource.package_name("libmysqlclient15-dev")
-      virtual_package_out=<<-VPKG_STDOUT
+          INSTALLED
+          expect(@provider).to receive(:shell_out!).and_return(@shell_out)
+          @provider.load_current_resource
+          expect(@provider.current_resource.version).to eq("1.7.2p1-1ubuntu5.3")
+          expect(@provider.candidate_version).to eql("1.7.2p1-1ubuntu5.3")
+        end
+
+        # libmysqlclient-dev is a real package in newer versions of debian + ubuntu
+        # list of virtual packages: http://www.debian.org/doc/packaging-manuals/virtual-package-names-list.txt
+        it "should not install the virtual package there is a single provider package and it is installed" do
+          @new_resource.package_name("libmysqlclient15-dev")
+          virtual_package_out=<<-VPKG_STDOUT
 libmysqlclient15-dev:
   Installed: (none)
   Candidate: (none)
   Version table:
-VPKG_STDOUT
-      virtual_package = double(:stdout => virtual_package_out,:exitstatus => 0)
-      expect(@provider).to receive(:shell_out!).with(
-        "apt-cache policy libmysqlclient15-dev",
-        :timeout => @timeout
-      ).and_return(virtual_package)
-      showpkg_out =<<-SHOWPKG_STDOUT
+          VPKG_STDOUT
+          virtual_package = double(:stdout => virtual_package_out,:exitstatus => 0)
+          expect(@provider).to receive(:shell_out!).with(
+            "apt-cache policy libmysqlclient15-dev",
+            :timeout => @timeout
+          ).and_return(virtual_package)
+          showpkg_out =<<-SHOWPKG_STDOUT
 Package: libmysqlclient15-dev
 Versions:
 
@@ -109,13 +114,13 @@ Reverse Provides:
 libmysqlclient-dev 5.1.41-3ubuntu12.7
 libmysqlclient-dev 5.1.41-3ubuntu12.10
 libmysqlclient-dev 5.1.41-3ubuntu12
-SHOWPKG_STDOUT
-      showpkg = double(:stdout => showpkg_out,:exitstatus => 0)
-      expect(@provider).to receive(:shell_out!).with(
-        "apt-cache showpkg libmysqlclient15-dev",
-        :timeout => @timeout
-      ).and_return(showpkg)
-      real_package_out=<<-RPKG_STDOUT
+          SHOWPKG_STDOUT
+          showpkg = double(:stdout => showpkg_out,:exitstatus => 0)
+          expect(@provider).to receive(:shell_out!).with(
+            "apt-cache showpkg libmysqlclient15-dev",
+            :timeout => @timeout
+          ).and_return(showpkg)
+          real_package_out=<<-RPKG_STDOUT
 libmysqlclient-dev:
   Installed: 5.1.41-3ubuntu12.10
   Candidate: 5.1.41-3ubuntu12.10
@@ -127,29 +132,29 @@ libmysqlclient-dev:
         500 http://security.ubuntu.com/ubuntu/ lucid-security/main Packages
      5.1.41-3ubuntu12 0
         500 http://us.archive.ubuntu.com/ubuntu/ lucid/main Packages
-RPKG_STDOUT
-      real_package = double(:stdout => real_package_out,:exitstatus => 0)
-      expect(@provider).to receive(:shell_out!).with(
-        "apt-cache policy libmysqlclient-dev",
-        :timeout => @timeout
-      ).and_return(real_package)
-      @provider.load_current_resource
-    end
+          RPKG_STDOUT
+          real_package = double(:stdout => real_package_out,:exitstatus => 0)
+          expect(@provider).to receive(:shell_out!).with(
+            "apt-cache policy libmysqlclient-dev",
+            :timeout => @timeout
+          ).and_return(real_package)
+          @provider.load_current_resource
+        end
 
-    it "should raise an exception if you specify a virtual package with multiple provider packages" do
-      @new_resource.package_name("mp3-decoder")
-      virtual_package_out=<<-VPKG_STDOUT
+        it "should raise an exception if you specify a virtual package with multiple provider packages" do
+          @new_resource.package_name("mp3-decoder")
+          virtual_package_out=<<-VPKG_STDOUT
 mp3-decoder:
   Installed: (none)
   Candidate: (none)
   Version table:
-VPKG_STDOUT
-      virtual_package = double(:stdout => virtual_package_out,:exitstatus => 0)
-      expect(@provider).to receive(:shell_out!).with(
-        "apt-cache policy mp3-decoder",
-        :timeout => @timeout
-      ).and_return(virtual_package)
-      showpkg_out=<<-SHOWPKG_STDOUT
+          VPKG_STDOUT
+          virtual_package = double(:stdout => virtual_package_out,:exitstatus => 0)
+          expect(@provider).to receive(:shell_out!).with(
+            "apt-cache policy mp3-decoder",
+            :timeout => @timeout
+          ).and_return(virtual_package)
+          showpkg_out=<<-SHOWPKG_STDOUT
 Package: mp3-decoder
 Versions:
 
@@ -169,191 +174,193 @@ vlc 1.0.6-1ubuntu1
 opencubicplayer 1:0.1.17-2
 mpg321 0.2.10.6
 mpg123 1.12.1-0ubuntu1
-SHOWPKG_STDOUT
-      showpkg = double(:stdout => showpkg_out,:exitstatus => 0)
-      expect(@provider).to receive(:shell_out!).with(
-        "apt-cache showpkg mp3-decoder",
-        :timeout => @timeout
-      ).and_return(showpkg)
-      expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::Package)
-    end
-
-    it "should run apt-cache policy with the default_release option, if there is one and provider is explicitly defined" do
-      @new_resource = Chef::Resource::AptPackage.new("irssi", @run_context)
-      @provider = Chef::Provider::Package::Apt.new(@new_resource, @run_context)
-
-      allow(@new_resource).to receive(:default_release).and_return("lenny-backports")
-      allow(@new_resource).to receive(:provider).and_return("Chef::Provider::Package::Apt")
-      expect(@provider).to receive(:shell_out!).with(
-        "apt-cache -o APT::Default-Release=lenny-backports policy irssi",
-        :timeout => @timeout
-      ).and_return(@shell_out)
-      @provider.load_current_resource
-    end
-
-    it "raises an exception if a source is specified (CHEF-5113)" do
-      @new_resource.source "pluto"
-      @provider.define_resource_requirements
-      expect(@provider).to receive(:shell_out!).with("apt-cache policy irssi", {:timeout=>900}).and_return(@shell_out)
-      expect { @provider.run_action(:install) }.to raise_error(Chef::Exceptions::Package)
-    end
-  end
-
-  context "after loading the current resource" do
-    before do
-      @current_resource = Chef::Resource::Package.new("irssi", @run_context)
-      @provider.current_resource = @current_resource
-    end
-
-    describe "install_package" do
-      it "should run apt-get install with the package name and version" do
-        expect(@provider).to receive(:shell_out!). with(
-          "apt-get -q -y install irssi=0.8.12-7",
-          :env => { "DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil},
-          :timeout => @timeout
-        )
-        @provider.install_package("irssi", "0.8.12-7")
-      end
-
-      it "should run apt-get install with the package name and version and options if specified" do
-        expect(@provider).to receive(:shell_out!).with(
-          "apt-get -q -y --force-yes install irssi=0.8.12-7",
-          :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
-          :timeout => @timeout
-        )
-        @new_resource.options("--force-yes")
-        @provider.install_package("irssi", "0.8.12-7")
-      end
-
-      it "should run apt-get install with the package name and version and default_release if there is one and provider is explicitly defined" do
-        @new_resource = nil
-        @new_resource = Chef::Resource::AptPackage.new("irssi", @run_context)
-        @new_resource.default_release("lenny-backports")
-        @new_resource.provider = @provider
-        @provider.new_resource = @new_resource
-
-        expect(@provider).to receive(:shell_out!).with(
-          "apt-get -q -y -o APT::Default-Release=lenny-backports install irssi=0.8.12-7",
-          :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
-          :timeout => @timeout
-        )
-
-        @provider.install_package("irssi", "0.8.12-7")
-      end
-    end
-
-    describe Chef::Provider::Package::Apt, "upgrade_package" do
-
-      it "should run install_package with the name and version" do
-        expect(@provider).to receive(:install_package).with("irssi", "0.8.12-7")
-        @provider.upgrade_package("irssi", "0.8.12-7")
-      end
-    end
-
-    describe Chef::Provider::Package::Apt, "remove_package" do
-
-      it "should run apt-get remove with the package name" do
-        expect(@provider).to receive(:shell_out!).with(
-          "apt-get -q -y remove irssi",
-          :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil},
-          :timeout => @timeout
-        )
-        @provider.remove_package("irssi", "0.8.12-7")
-      end
-
-      it "should run apt-get remove with the package name and options if specified" do
-        expect(@provider).to receive(:shell_out!).with(
-          "apt-get -q -y --force-yes remove irssi",
-          :env => { "DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
-          :timeout => @timeout
-        )
-        @new_resource.options("--force-yes")
-
-        @provider.remove_package("irssi", "0.8.12-7")
-      end
-    end
-
-    describe "when purging a package" do
-
-      it "should run apt-get purge with the package name" do
-        expect(@provider).to receive(:shell_out!).with(
-          "apt-get -q -y purge irssi",
-          :env => { "DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
-          :timeout => @timeout
-        )
-        @provider.purge_package("irssi", "0.8.12-7")
-      end
-
-      it "should run apt-get purge with the package name and options if specified" do
-        expect(@provider).to receive(:shell_out!).with(
-          "apt-get -q -y --force-yes purge irssi",
-          :env => { "DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
-          :timeout => @timeout
-        )
-        @new_resource.options("--force-yes")
-
-        @provider.purge_package("irssi", "0.8.12-7")
-      end
-    end
-
-    describe "when preseeding a package" do
-      before(:each) do
-        allow(@provider).to receive(:get_preseed_file).and_return("/tmp/irssi-0.8.12-7.seed")
-      end
-
-      it "should get the full path to the preseed response file" do
-        expect(@provider).to receive(:get_preseed_file).with("irssi", "0.8.12-7").and_return("/tmp/irssi-0.8.12-7.seed")
-        file = @provider.get_preseed_file("irssi", "0.8.12-7")
-
-        expect(@provider).to receive(:shell_out!).with(
-          "debconf-set-selections /tmp/irssi-0.8.12-7.seed",
-          :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil},
-          :timeout => @timeout
-        )
-
-        @provider.preseed_package(file)
-      end
-
-      it "should run debconf-set-selections on the preseed file if it has changed" do
-        expect(@provider).to receive(:shell_out!).with(
-          "debconf-set-selections /tmp/irssi-0.8.12-7.seed",
-          :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil},
-          :timeout => @timeout
-        )
-        file = @provider.get_preseed_file("irssi", "0.8.12-7")
-        @provider.preseed_package(file)
-      end
+          SHOWPKG_STDOUT
+          showpkg = double(:stdout => showpkg_out,:exitstatus => 0)
+          expect(@provider).to receive(:shell_out!).with(
+            "apt-cache showpkg mp3-decoder",
+            :timeout => @timeout
+          ).and_return(showpkg)
+          expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::Package)
+        end
 
-      it "should not run debconf-set-selections if the preseed file has not changed" do
-        allow(@provider).to receive(:check_package_state)
-        @current_resource.version "0.8.11"
-        @new_resource.response_file "/tmp/file"
-        allow(@provider).to receive(:get_preseed_file).and_return(false)
-        expect(@provider).not_to receive(:shell_out!)
-        @provider.run_action(:reconfig)
-      end
-    end
+        it "should run apt-cache policy with the default_release option, if there is one on the resource" do
+          @new_resource = Chef::Resource::AptPackage.new("irssi", @run_context)
+          @provider = Chef::Provider::Package::Apt.new(@new_resource, @run_context)
 
-    describe "when reconfiguring a package" do
-      it "should run dpkg-reconfigure package" do
-        expect(@provider).to receive(:shell_out!).with(
-          "dpkg-reconfigure irssi",
-          :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
-          :timeout => @timeout
-        )
-        @provider.reconfig_package("irssi", "0.8.12-7")
-      end
-    end
-
-    describe "when installing a virtual package" do
-      it "should install the package without specifying a version" do
-          @provider.is_virtual_package = true
+          allow(@new_resource).to receive(:default_release).and_return("lenny-backports")
+          allow(@new_resource).to receive(:provider).and_return(nil)
           expect(@provider).to receive(:shell_out!).with(
-            "apt-get -q -y install libmysqlclient-dev",
-            :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
+            "apt-cache -o APT::Default-Release=lenny-backports policy irssi",
             :timeout => @timeout
-          )
-          @provider.install_package("libmysqlclient-dev", "not_a_real_version")
+          ).and_return(@shell_out)
+          @provider.load_current_resource
+        end
+
+        it "raises an exception if a source is specified (CHEF-5113)" do
+          @new_resource.source "pluto"
+          @provider.define_resource_requirements
+          expect(@provider).to receive(:shell_out!).with("apt-cache policy irssi", {:timeout=>900}).and_return(@shell_out)
+          expect { @provider.run_action(:install) }.to raise_error(Chef::Exceptions::Package)
+        end
+      end
+
+      context "after loading the current resource" do
+        before do
+          @current_resource = resource_klass.new("irssi", @run_context)
+          @provider.current_resource = @current_resource
+        end
+
+        describe "install_package" do
+          it "should run apt-get install with the package name and version" do
+            expect(@provider).to receive(:shell_out!). with(
+              "apt-get -q -y install irssi=0.8.12-7",
+              :env => { "DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil},
+              :timeout => @timeout
+            )
+            @provider.install_package("irssi", "0.8.12-7")
+          end
+
+          it "should run apt-get install with the package name and version and options if specified" do
+            expect(@provider).to receive(:shell_out!).with(
+              "apt-get -q -y --force-yes install irssi=0.8.12-7",
+              :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
+              :timeout => @timeout
+            )
+            @new_resource.options("--force-yes")
+            @provider.install_package("irssi", "0.8.12-7")
+          end
+
+          it "should run apt-get install with the package name and version and default_release if there is one and provider is explicitly defined" do
+            @new_resource = nil
+            @new_resource = Chef::Resource::AptPackage.new("irssi", @run_context)
+            @new_resource.default_release("lenny-backports")
+            @new_resource.provider = nil
+            @provider.new_resource = @new_resource
+
+            expect(@provider).to receive(:shell_out!).with(
+              "apt-get -q -y -o APT::Default-Release=lenny-backports install irssi=0.8.12-7",
+              :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
+              :timeout => @timeout
+            )
+
+            @provider.install_package("irssi", "0.8.12-7")
+          end
+        end
+
+        describe resource_klass, "upgrade_package" do
+
+          it "should run install_package with the name and version" do
+            expect(@provider).to receive(:install_package).with("irssi", "0.8.12-7")
+            @provider.upgrade_package("irssi", "0.8.12-7")
+          end
+        end
+
+        describe resource_klass, "remove_package" do
+
+          it "should run apt-get remove with the package name" do
+            expect(@provider).to receive(:shell_out!).with(
+              "apt-get -q -y remove irssi",
+              :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil},
+              :timeout => @timeout
+            )
+            @provider.remove_package("irssi", "0.8.12-7")
+          end
+
+          it "should run apt-get remove with the package name and options if specified" do
+            expect(@provider).to receive(:shell_out!).with(
+              "apt-get -q -y --force-yes remove irssi",
+              :env => { "DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
+              :timeout => @timeout
+            )
+            @new_resource.options("--force-yes")
+
+            @provider.remove_package("irssi", "0.8.12-7")
+          end
+        end
+
+        describe "when purging a package" do
+
+          it "should run apt-get purge with the package name" do
+            expect(@provider).to receive(:shell_out!).with(
+              "apt-get -q -y purge irssi",
+              :env => { "DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
+              :timeout => @timeout
+            )
+            @provider.purge_package("irssi", "0.8.12-7")
+          end
+
+          it "should run apt-get purge with the package name and options if specified" do
+            expect(@provider).to receive(:shell_out!).with(
+              "apt-get -q -y --force-yes purge irssi",
+              :env => { "DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
+              :timeout => @timeout
+            )
+            @new_resource.options("--force-yes")
+
+            @provider.purge_package("irssi", "0.8.12-7")
+          end
+        end
+
+        describe "when preseeding a package" do
+          before(:each) do
+            allow(@provider).to receive(:get_preseed_file).and_return("/tmp/irssi-0.8.12-7.seed")
+          end
+
+          it "should get the full path to the preseed response file" do
+            expect(@provider).to receive(:get_preseed_file).with("irssi", "0.8.12-7").and_return("/tmp/irssi-0.8.12-7.seed")
+            file = @provider.get_preseed_file("irssi", "0.8.12-7")
+
+            expect(@provider).to receive(:shell_out!).with(
+              "debconf-set-selections /tmp/irssi-0.8.12-7.seed",
+              :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil},
+              :timeout => @timeout
+            )
+
+            @provider.preseed_package(file)
+          end
+
+          it "should run debconf-set-selections on the preseed file if it has changed" do
+            expect(@provider).to receive(:shell_out!).with(
+              "debconf-set-selections /tmp/irssi-0.8.12-7.seed",
+              :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil},
+              :timeout => @timeout
+            )
+            file = @provider.get_preseed_file("irssi", "0.8.12-7")
+            @provider.preseed_package(file)
+          end
+
+          it "should not run debconf-set-selections if the preseed file has not changed" do
+            allow(@provider).to receive(:check_package_state)
+            @current_resource.version "0.8.11"
+            @new_resource.response_file "/tmp/file"
+            allow(@provider).to receive(:get_preseed_file).and_return(false)
+            expect(@provider).not_to receive(:shell_out!)
+            @provider.run_action(:reconfig)
+          end
+        end
+
+        describe "when reconfiguring a package" do
+          it "should run dpkg-reconfigure package" do
+            expect(@provider).to receive(:shell_out!).with(
+              "dpkg-reconfigure irssi",
+              :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
+              :timeout => @timeout
+            )
+            @provider.reconfig_package("irssi", "0.8.12-7")
+          end
+        end
+
+        describe "when installing a virtual package" do
+          it "should install the package without specifying a version" do
+            @provider.is_virtual_package = true
+            expect(@provider).to receive(:shell_out!).with(
+              "apt-get -q -y install libmysqlclient-dev",
+              :env => {"DEBIAN_FRONTEND" => "noninteractive", "LC_ALL" => nil },
+              :timeout => @timeout
+            )
+            @provider.install_package("libmysqlclient-dev", "not_a_real_version")
+          end
+        end
       end
     end
   end