chef 12.0.0.alpha.2 → 12.0.0.rc.0

data/spec/unit/provider/package/zypper_spec.rb

@@ -30,84 +30,84 @@ describe Chef::Provider::Package::Zypper do
     @status = double("Status", :exitstatus => 0)
 
     @provider = Chef::Provider::Package::Zypper.new(@new_resource, @run_context)
-    Chef::Resource::Package.stub(:new).and_return(@current_resource)
-    @provider.stub(:popen4).and_return(@status)
+    allow(Chef::Resource::Package).to receive(:new).and_return(@current_resource)
+    allow(@provider).to receive(:popen4).and_return(@status)
     @stderr = StringIO.new
     @stdout = StringIO.new
     @pid = double("PID")
-    @provider.stub(:`).and_return("2.0")
+    allow(@provider).to receive(:`).and_return("2.0")
   end
 
   describe "when loading the current package state" do
     it "should create a current resource with the name of the new_resource" do
-      Chef::Resource::Package.should_receive(:new).and_return(@current_resource)
+      expect(Chef::Resource::Package).to receive(:new).and_return(@current_resource)
       @provider.load_current_resource
     end
 
     it "should set the current resources package name to the new resources package name" do
-      @current_resource.should_receive(:package_name).with(@new_resource.package_name)
+      expect(@current_resource).to receive(:package_name).with(@new_resource.package_name)
       @provider.load_current_resource
     end
 
     it "should run zypper info with the package name" do
-      @provider.should_receive(:popen4).with("zypper --non-interactive info #{@new_resource.package_name}").and_return(@status)
+      expect(@provider).to receive(:popen4).with("zypper --non-interactive info #{@new_resource.package_name}").and_return(@status)
       @provider.load_current_resource
     end
 
     it "should set the installed version to nil on the current resource if zypper info installed version is (none)" do
-      @provider.stub(:popen4).and_yield(@pid, @stdin, @stdout, @stderr).and_return(@status)
-      @current_resource.should_receive(:version).with(nil).and_return(true)
+      allow(@provider).to receive(:popen4).and_yield(@pid, @stdin, @stdout, @stderr).and_return(@status)
+      expect(@current_resource).to receive(:version).with(nil).and_return(true)
       @provider.load_current_resource
     end
 
     it "should set the installed version if zypper info has one" do
       @stdout = StringIO.new("Version: 1.0\nInstalled: Yes\n")
-      @provider.stub(:popen4).and_yield(@pid, @stdin, @stdout, @stderr).and_return(@status)
-      @current_resource.should_receive(:version).with("1.0").and_return(true)
+      allow(@provider).to receive(:popen4).and_yield(@pid, @stdin, @stdout, @stderr).and_return(@status)
+      expect(@current_resource).to receive(:version).with("1.0").and_return(true)
       @provider.load_current_resource
     end
 
     it "should set the candidate version if zypper info has one" do
       @stdout = StringIO.new("Version: 1.0\nInstalled: No\nStatus: out-of-date (version 0.9 installed)")
 
-      @provider.stub(:popen4).and_yield(@pid, @stdin, @stdout, @stderr).and_return(@status)
+      allow(@provider).to receive(:popen4).and_yield(@pid, @stdin, @stdout, @stderr).and_return(@status)
       @provider.load_current_resource
-      @provider.candidate_version.should eql("1.0")
+      expect(@provider.candidate_version).to eql("1.0")
     end
 
     it "should raise an exception if zypper info fails" do
-      @status.should_receive(:exitstatus).and_return(1)
-      lambda { @provider.load_current_resource }.should raise_error(Chef::Exceptions::Package)
+      expect(@status).to receive(:exitstatus).and_return(1)
+      expect { @provider.load_current_resource }.to raise_error(Chef::Exceptions::Package)
     end
 
     it "should not raise an exception if zypper info succeeds" do
-      @status.should_receive(:exitstatus).and_return(0)
-      lambda { @provider.load_current_resource }.should_not raise_error
+      expect(@status).to receive(:exitstatus).and_return(0)
+      expect { @provider.load_current_resource }.not_to raise_error
     end
 
     it "should return the current resouce" do
-      @provider.load_current_resource.should eql(@current_resource)
+      expect(@provider.load_current_resource).to eql(@current_resource)
     end
   end
 
   describe "install_package" do
     it "should run zypper install with the package name and version" do
-      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(true)
-      @provider.should_receive(:shell_out!).with(
+      allow(Chef::Config).to receive(:[]).with(:zypper_check_gpg).and_return(true)
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive install --auto-agree-with-licenses emacs=1.0")
       @provider.install_package("emacs", "1.0")
     end
     it "should run zypper install without gpg checks" do
-      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(false)
-      @provider.should_receive(:shell_out!).with(
+      allow(Chef::Config).to receive(:[]).with(:zypper_check_gpg).and_return(false)
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive --no-gpg-checks install "+
         "--auto-agree-with-licenses emacs=1.0")
       @provider.install_package("emacs", "1.0")
     end
     it "should warn about gpg checks on zypper install" do
-      Chef::Log.should_receive(:warn).with(
+      expect(Chef::Log).to receive(:warn).with(
         /All packages will be installed without gpg signature checks/)
-      @provider.should_receive(:shell_out!).with(
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive --no-gpg-checks install "+
         "--auto-agree-with-licenses emacs=1.0")
       @provider.install_package("emacs", "1.0")
@@ -116,28 +116,28 @@ describe Chef::Provider::Package::Zypper do
 
   describe "upgrade_package" do
     it "should run zypper update with the package name and version" do
-      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(true)
-      @provider.should_receive(:shell_out!).with(
+      allow(Chef::Config).to receive(:[]).with(:zypper_check_gpg).and_return(true)
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive install --auto-agree-with-licenses emacs=1.0")
       @provider.upgrade_package("emacs", "1.0")
     end
     it "should run zypper update without gpg checks" do
-      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(false)
-      @provider.should_receive(:shell_out!).with(
+      allow(Chef::Config).to receive(:[]).with(:zypper_check_gpg).and_return(false)
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive --no-gpg-checks install "+
         "--auto-agree-with-licenses emacs=1.0")
       @provider.upgrade_package("emacs", "1.0")
     end
     it "should warn about gpg checks on zypper upgrade" do
-      Chef::Log.should_receive(:warn).with(
+      expect(Chef::Log).to receive(:warn).with(
         /All packages will be installed without gpg signature checks/)
-      @provider.should_receive(:shell_out!).with(
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive --no-gpg-checks install "+
         "--auto-agree-with-licenses emacs=1.0")
       @provider.upgrade_package("emacs", "1.0")
     end
     it "should run zypper upgrade without gpg checks" do
-      @provider.should_receive(:shell_out!).with(
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive --no-gpg-checks install "+
         "--auto-agree-with-licenses emacs=1.0")
 
@@ -149,8 +149,8 @@ describe Chef::Provider::Package::Zypper do
 
     context "when package version is not explicitly specified" do
       it "should run zypper remove with the package name" do
-        Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(true)
-        @provider.should_receive(:shell_out!).with(
+        allow(Chef::Config).to receive(:[]).with(:zypper_check_gpg).and_return(true)
+        expect(@provider).to receive(:shell_out!).with(
             "zypper --non-interactive remove emacs")
         @provider.remove_package("emacs", nil)
       end
@@ -158,21 +158,21 @@ describe Chef::Provider::Package::Zypper do
 
     context "when package version is explicitly specified" do
       it "should run zypper remove with the package name" do
-        Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(true)
-        @provider.should_receive(:shell_out!).with(
+        allow(Chef::Config).to receive(:[]).with(:zypper_check_gpg).and_return(true)
+        expect(@provider).to receive(:shell_out!).with(
           "zypper --non-interactive remove emacs=1.0")
         @provider.remove_package("emacs", "1.0")
       end
       it "should run zypper remove without gpg checks" do
-        Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(false)
-        @provider.should_receive(:shell_out!).with(
+        allow(Chef::Config).to receive(:[]).with(:zypper_check_gpg).and_return(false)
+        expect(@provider).to receive(:shell_out!).with(
             "zypper --non-interactive --no-gpg-checks remove emacs=1.0")
         @provider.remove_package("emacs", "1.0")
       end
       it "should warn about gpg checks on zypper remove" do
-        Chef::Log.should_receive(:warn).with(
+        expect(Chef::Log).to receive(:warn).with(
           /All packages will be installed without gpg signature checks/)
-        @provider.should_receive(:shell_out!).with(
+        expect(@provider).to receive(:shell_out!).with(
           "zypper --non-interactive --no-gpg-checks remove emacs=1.0")
 
         @provider.remove_package("emacs", "1.0")
@@ -182,20 +182,20 @@ describe Chef::Provider::Package::Zypper do
 
   describe "purge_package" do
     it "should run remove_package with the name and version" do
-      @provider.should_receive(:shell_out!).with(
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive --no-gpg-checks remove --clean-deps emacs=1.0")
       @provider.purge_package("emacs", "1.0")
     end
     it "should run zypper purge without gpg checks" do
-      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(false)
-      @provider.should_receive(:shell_out!).with(
+      allow(Chef::Config).to receive(:[]).with(:zypper_check_gpg).and_return(false)
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive --no-gpg-checks remove --clean-deps emacs=1.0")
       @provider.purge_package("emacs", "1.0")
     end
     it "should warn about gpg checks on zypper purge" do
-      Chef::Log.should_receive(:warn).with(
+      expect(Chef::Log).to receive(:warn).with(
         /All packages will be installed without gpg signature checks/)
-      @provider.should_receive(:shell_out!).with(
+      expect(@provider).to receive(:shell_out!).with(
         "zypper --non-interactive --no-gpg-checks remove --clean-deps emacs=1.0")
       @provider.purge_package("emacs", "1.0")
     end
@@ -203,12 +203,12 @@ describe Chef::Provider::Package::Zypper do
 
   describe "on an older zypper" do
     before(:each) do
-      @provider.stub(:`).and_return("0.11.6")
+      allow(@provider).to receive(:`).and_return("0.11.6")
     end
 
     describe "install_package" do
       it "should run zypper install with the package name and version" do
-        @provider.should_receive(:shell_out!).with(
+        expect(@provider).to receive(:shell_out!).with(
           "zypper --no-gpg-checks install --auto-agree-with-licenses -y emacs")
         @provider.install_package("emacs", "1.0")
       end
@@ -216,7 +216,7 @@ describe Chef::Provider::Package::Zypper do
 
     describe "upgrade_package" do
       it "should run zypper update with the package name and version" do
-        @provider.should_receive(:shell_out!).with(
+        expect(@provider).to receive(:shell_out!).with(
           "zypper --no-gpg-checks install --auto-agree-with-licenses -y emacs")
         @provider.upgrade_package("emacs", "1.0")
       end
@@ -224,7 +224,7 @@ describe Chef::Provider::Package::Zypper do
 
     describe "remove_package" do
       it "should run zypper remove with the package name" do
-        @provider.should_receive(:shell_out!).with(
+        expect(@provider).to receive(:shell_out!).with(
            "zypper --no-gpg-checks remove -y emacs")
         @provider.remove_package("emacs", "1.0")
       end

data/spec/unit/provider/package_spec.rb

@@ -34,80 +34,80 @@ describe Chef::Provider::Package do
   describe "when installing a package" do
     before(:each) do
       @provider.current_resource = @current_resource
-      @provider.stub(:install_package).and_return(true)
+      allow(@provider).to receive(:install_package).and_return(true)
     end
 
     it "should raise a Chef::Exceptions::Package if no version is specified, and no candidate is available" do
       @provider.candidate_version = nil
-      lambda { @provider.run_action(:install) }.should raise_error(Chef::Exceptions::Package)
+      expect { @provider.run_action(:install) }.to raise_error(Chef::Exceptions::Package)
     end
 
     it "should call preseed_package if a response_file is given" do
       @new_resource.response_file("foo")
-      @provider.should_receive(:get_preseed_file).with(
+      expect(@provider).to receive(:get_preseed_file).with(
         @new_resource.name,
         @provider.candidate_version
       ).and_return("/var/cache/preseed-test")
 
-      @provider.should_receive(:preseed_package).with(
+      expect(@provider).to receive(:preseed_package).with(
         "/var/cache/preseed-test"
       ).and_return(true)
       @provider.run_action(:install)
     end
 
     it "should not call preseed_package if a response_file is not given" do
-      @provider.should_not_receive(:preseed_package)
+      expect(@provider).not_to receive(:preseed_package)
       @provider.run_action(:install)
     end
 
     it "should install the package at the candidate_version if it is not already installed" do
-      @provider.should_receive(:install_package).with(
+      expect(@provider).to receive(:install_package).with(
         @new_resource.name,
         @provider.candidate_version
       ).and_return(true)
       @provider.run_action(:install)
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should install the package at the version specified if it is not already installed" do
       @new_resource.version("1.0")
-      @provider.should_receive(:install_package).with(
+      expect(@provider).to receive(:install_package).with(
         @new_resource.name,
         @new_resource.version
       ).and_return(true)
       @provider.run_action(:install)
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should install the package at the version specified if a different version is installed" do
       @new_resource.version("1.0")
-      @current_resource.stub(:version).and_return("0.99")
-      @provider.should_receive(:install_package).with(
+      allow(@current_resource).to receive(:version).and_return("0.99")
+      expect(@provider).to receive(:install_package).with(
         @new_resource.name,
         @new_resource.version
       ).and_return(true)
       @provider.run_action(:install)
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should not install the package if it is already installed and no version is specified" do
       @current_resource.version("1.0")
-      @provider.should_not_receive(:install_package)
+      expect(@provider).not_to receive(:install_package)
       @provider.run_action(:install)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should not install the package if it is already installed at the version specified" do
       @current_resource.version("1.0")
       @new_resource.version("1.0")
-      @provider.should_not_receive(:install_package)
+      expect(@provider).not_to receive(:install_package)
       @provider.run_action(:install)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should call the candidate_version accessor only once if the package is already installed and no version is specified" do
       @current_resource.version("1.0")
-      @provider.stub(:candidate_version).and_return("1.0")
+      allow(@provider).to receive(:candidate_version).and_return("1.0")
       @provider.run_action(:install)
     end
 
@@ -119,220 +119,220 @@ describe Chef::Provider::Package do
 
     it "should set the resource to updated if it installs the package" do
       @provider.run_action(:install)
-      @new_resource.should be_updated
+      expect(@new_resource).to be_updated
     end
 
   end
 
   describe "when upgrading the package" do
     before(:each) do
-      @provider.stub(:upgrade_package).and_return(true)
+      allow(@provider).to receive(:upgrade_package).and_return(true)
     end
 
     it "should upgrade the package if the current version is not the candidate version" do
-      @provider.should_receive(:upgrade_package).with(
+      expect(@provider).to receive(:upgrade_package).with(
         @new_resource.name,
         @provider.candidate_version
       ).and_return(true)
       @provider.run_action(:upgrade)
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should set the resource to updated if it installs the package" do
       @provider.run_action(:upgrade)
-      @new_resource.should be_updated
+      expect(@new_resource).to be_updated
     end
 
     it "should not install the package if the current version is the candidate version" do
       @current_resource.version "1.0"
-      @provider.should_not_receive(:upgrade_package)
+      expect(@provider).not_to receive(:upgrade_package)
       @provider.run_action(:upgrade)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should print the word 'uninstalled' if there was no original version" do
-      @current_resource.stub(:version).and_return(nil)
-      Chef::Log.should_receive(:info).with("package[emacs] upgraded from uninstalled to 1.0")
+      allow(@current_resource).to receive(:version).and_return(nil)
+      expect(Chef::Log).to receive(:info).with("package[emacs] upgraded from uninstalled to 1.0")
       @provider.run_action(:upgrade)
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should raise a Chef::Exceptions::Package if current version and candidate are nil" do
-      @current_resource.stub(:version).and_return(nil)
+      allow(@current_resource).to receive(:version).and_return(nil)
       @provider.candidate_version = nil
-      lambda { @provider.run_action(:upgrade) }.should raise_error(Chef::Exceptions::Package)
+      expect { @provider.run_action(:upgrade) }.to raise_error(Chef::Exceptions::Package)
     end
 
     it "should not install the package if candidate version is nil" do
       @current_resource.version "1.0"
       @provider.candidate_version = nil
-      @provider.should_not_receive(:upgrade_package)
+      expect(@provider).not_to receive(:upgrade_package)
       @provider.run_action(:upgrade)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
   end
 
   describe "When removing the package" do
     before(:each) do
-      @provider.stub(:remove_package).and_return(true)
+      allow(@provider).to receive(:remove_package).and_return(true)
       @current_resource.version '1.4.2'
     end
 
     it "should remove the package if it is installed" do
-      @provider.should be_removing_package
-      @provider.should_receive(:remove_package).with('emacs', nil)
+      expect(@provider).to be_removing_package
+      expect(@provider).to receive(:remove_package).with('emacs', nil)
       @provider.run_action(:remove)
-      @new_resource.should be_updated
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should remove the package at a specific version if it is installed at that version" do
       @new_resource.version "1.4.2"
-      @provider.should be_removing_package
-      @provider.should_receive(:remove_package).with('emacs', '1.4.2')
+      expect(@provider).to be_removing_package
+      expect(@provider).to receive(:remove_package).with('emacs', '1.4.2')
       @provider.run_action(:remove)
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should not remove the package at a specific version if it is not installed at that version" do
       @new_resource.version "1.0"
-      @provider.should_not be_removing_package
-      @provider.should_not_receive(:remove_package)
+      expect(@provider).not_to be_removing_package
+      expect(@provider).not_to receive(:remove_package)
       @provider.run_action(:remove)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should not remove the package if it is not installed" do
-      @provider.should_not_receive(:remove_package)
-      @current_resource.stub(:version).and_return(nil)
+      expect(@provider).not_to receive(:remove_package)
+      allow(@current_resource).to receive(:version).and_return(nil)
       @provider.run_action(:remove)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should set the resource to updated if it removes the package" do
       @provider.run_action(:remove)
-      @new_resource.should be_updated
+      expect(@new_resource).to be_updated
     end
 
   end
 
   describe "When purging the package" do
     before(:each) do
-      @provider.stub(:purge_package).and_return(true)
+      allow(@provider).to receive(:purge_package).and_return(true)
       @current_resource.version '1.4.2'
     end
 
     it "should purge the package if it is installed" do
-      @provider.should be_removing_package
-      @provider.should_receive(:purge_package).with('emacs', nil)
+      expect(@provider).to be_removing_package
+      expect(@provider).to receive(:purge_package).with('emacs', nil)
       @provider.run_action(:purge)
-      @new_resource.should be_updated
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should purge the package at a specific version if it is installed at that version" do
       @new_resource.version "1.4.2"
-      @provider.should be_removing_package
-      @provider.should_receive(:purge_package).with('emacs', '1.4.2')
+      expect(@provider).to be_removing_package
+      expect(@provider).to receive(:purge_package).with('emacs', '1.4.2')
       @provider.run_action(:purge)
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should not purge the package at a specific version if it is not installed at that version" do
       @new_resource.version "1.0"
-      @provider.should_not be_removing_package
-      @provider.should_not_receive(:purge_package)
+      expect(@provider).not_to be_removing_package
+      expect(@provider).not_to receive(:purge_package)
       @provider.run_action(:purge)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should not purge the package if it is not installed" do
       @current_resource.instance_variable_set(:@version, nil)
-      @provider.should_not be_removing_package
+      expect(@provider).not_to be_removing_package
 
-      @provider.should_not_receive(:purge_package)
+      expect(@provider).not_to receive(:purge_package)
       @provider.run_action(:purge)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should set the resource to updated if it purges the package" do
       @provider.run_action(:purge)
-      @new_resource.should be_updated
+      expect(@new_resource).to be_updated
     end
 
   end
 
   describe "when reconfiguring the package" do
     before(:each) do
-      @provider.stub(:reconfig_package).and_return(true)
+      allow(@provider).to receive(:reconfig_package).and_return(true)
     end
 
     it "should info log, reconfigure the package and update the resource" do
-      @current_resource.stub(:version).and_return('1.0')
-      @new_resource.stub(:response_file).and_return(true)
-      @provider.should_receive(:get_preseed_file).and_return('/var/cache/preseed-test')
-      @provider.stub(:preseed_package).and_return(true)
-      @provider.stub(:reconfig_package).and_return(true)
-      Chef::Log.should_receive(:info).with("package[emacs] reconfigured")
-      @provider.should_receive(:reconfig_package)
+      allow(@current_resource).to receive(:version).and_return('1.0')
+      allow(@new_resource).to receive(:response_file).and_return(true)
+      expect(@provider).to receive(:get_preseed_file).and_return('/var/cache/preseed-test')
+      allow(@provider).to receive(:preseed_package).and_return(true)
+      allow(@provider).to receive(:reconfig_package).and_return(true)
+      expect(Chef::Log).to receive(:info).with("package[emacs] reconfigured")
+      expect(@provider).to receive(:reconfig_package)
       @provider.run_action(:reconfig)
-      @new_resource.should be_updated
-      @new_resource.should be_updated_by_last_action
+      expect(@new_resource).to be_updated
+      expect(@new_resource).to be_updated_by_last_action
     end
 
     it "should debug log and not reconfigure the package if the package is not installed" do
-      @current_resource.stub(:version).and_return(nil)
-      Chef::Log.should_receive(:debug).with("package[emacs] is NOT installed - nothing to do")
-      @provider.should_not_receive(:reconfig_package)
+      allow(@current_resource).to receive(:version).and_return(nil)
+      expect(Chef::Log).to receive(:debug).with("package[emacs] is NOT installed - nothing to do")
+      expect(@provider).not_to receive(:reconfig_package)
       @provider.run_action(:reconfig)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should debug log and not reconfigure the package if no response_file is given" do
-      @current_resource.stub(:version).and_return('1.0')
-      @new_resource.stub(:response_file).and_return(nil)
-      Chef::Log.should_receive(:debug).with("package[emacs] no response_file provided - nothing to do")
-      @provider.should_not_receive(:reconfig_package)
+      allow(@current_resource).to receive(:version).and_return('1.0')
+      allow(@new_resource).to receive(:response_file).and_return(nil)
+      expect(Chef::Log).to receive(:debug).with("package[emacs] no response_file provided - nothing to do")
+      expect(@provider).not_to receive(:reconfig_package)
       @provider.run_action(:reconfig)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
 
     it "should debug log and not reconfigure the package if the response_file has not changed" do
-      @current_resource.stub(:version).and_return('1.0')
-      @new_resource.stub(:response_file).and_return(true)
-      @provider.should_receive(:get_preseed_file).and_return(false)
-      @provider.stub(:preseed_package).and_return(false)
-      Chef::Log.should_receive(:debug).with("package[emacs] preseeding has not changed - nothing to do")
-      @provider.should_not_receive(:reconfig_package)
+      allow(@current_resource).to receive(:version).and_return('1.0')
+      allow(@new_resource).to receive(:response_file).and_return(true)
+      expect(@provider).to receive(:get_preseed_file).and_return(false)
+      allow(@provider).to receive(:preseed_package).and_return(false)
+      expect(Chef::Log).to receive(:debug).with("package[emacs] preseeding has not changed - nothing to do")
+      expect(@provider).not_to receive(:reconfig_package)
       @provider.run_action(:reconfig)
-      @new_resource.should_not be_updated_by_last_action
+      expect(@new_resource).not_to be_updated_by_last_action
     end
   end
 
   describe "when running commands to be implemented by subclasses" do
     it "should raises UnsupportedAction for install" do
-      lambda { @provider.install_package('emacs', '1.4.2') }.should raise_error(Chef::Exceptions::UnsupportedAction)
+      expect { @provider.install_package('emacs', '1.4.2') }.to raise_error(Chef::Exceptions::UnsupportedAction)
     end
 
     it "should raises UnsupportedAction for upgrade" do
-      lambda { @provider.upgrade_package('emacs', '1.4.2') }.should raise_error(Chef::Exceptions::UnsupportedAction)
+      expect { @provider.upgrade_package('emacs', '1.4.2') }.to raise_error(Chef::Exceptions::UnsupportedAction)
     end
 
     it "should raises UnsupportedAction for remove" do
-      lambda { @provider.remove_package('emacs', '1.4.2') }.should raise_error(Chef::Exceptions::UnsupportedAction)
+      expect { @provider.remove_package('emacs', '1.4.2') }.to raise_error(Chef::Exceptions::UnsupportedAction)
     end
 
     it "should raises UnsupportedAction for purge" do
-      lambda { @provider.purge_package('emacs', '1.4.2') }.should raise_error(Chef::Exceptions::UnsupportedAction)
+      expect { @provider.purge_package('emacs', '1.4.2') }.to raise_error(Chef::Exceptions::UnsupportedAction)
     end
 
     it "should raise UnsupportedAction for preseed_package" do
       preseed_file = "/tmp/sun-jdk-package-preseed-file.seed"
-      lambda { @provider.preseed_package(preseed_file) }.should raise_error(Chef::Exceptions::UnsupportedAction)
+      expect { @provider.preseed_package(preseed_file) }.to raise_error(Chef::Exceptions::UnsupportedAction)
     end
 
     it "should raise UnsupportedAction for reconfig" do
-      lambda { @provider.reconfig_package('emacs', '1.4.2') }.should raise_error(Chef::Exceptions::UnsupportedAction)
+      expect { @provider.reconfig_package('emacs', '1.4.2') }.to raise_error(Chef::Exceptions::UnsupportedAction)
     end
   end
 
@@ -358,29 +358,29 @@ describe Chef::Provider::Package do
 
     describe "creating the cookbook file resource to fetch the response file" do
       before do
-        Chef::FileCache.should_receive(:create_cache_path).with('preseed/java').and_return("/tmp/preseed/java")
+        expect(Chef::FileCache).to receive(:create_cache_path).with('preseed/java').and_return("/tmp/preseed/java")
       end
 
       it "sets the preseed resource's runcontext to its own run context" do
-        Chef::FileCache.stub(:create_cache_path).and_return("/tmp/preseed/java")
-        @provider.preseed_resource('java', '6').run_context.should_not be_nil
-        @provider.preseed_resource('java', '6').run_context.should equal(@provider.run_context)
+        allow(Chef::FileCache).to receive(:create_cache_path).and_return("/tmp/preseed/java")
+        expect(@provider.preseed_resource('java', '6').run_context).not_to be_nil
+        expect(@provider.preseed_resource('java', '6').run_context).to equal(@provider.run_context)
       end
 
       it "should set the cookbook name of the remote file to the new resources cookbook name" do
-        @provider.preseed_resource('java', '6').cookbook_name.should == 'java'
+        expect(@provider.preseed_resource('java', '6').cookbook_name).to eq('java')
       end
 
       it "should set remote files source to the new resources response file" do
-        @provider.preseed_resource('java', '6').source.should == 'java.response'
+        expect(@provider.preseed_resource('java', '6').source).to eq('java.response')
       end
 
       it "should never back up the cached response file" do
-        @provider.preseed_resource('java', '6').backup.should be_false
+        expect(@provider.preseed_resource('java', '6').backup).to be_false
       end
 
       it "sets the install path of the resource to $file_cache/$cookbook/$pkg_name-$pkg_version.seed" do
-        @provider.preseed_resource('java', '6').path.should == '/tmp/preseed/java/java-6.seed'
+        expect(@provider.preseed_resource('java', '6').path).to eq('/tmp/preseed/java/java-6.seed')
       end
     end
 
@@ -397,7 +397,7 @@ describe Chef::Provider::Package do
         @response_file_resource.source('java.response')
 
 
-        @provider.should_receive(:preseed_resource).with('java', '6').and_return(@response_file_resource)
+        expect(@provider).to receive(:preseed_resource).with('java', '6').and_return(@response_file_resource)
       end
 
       after do
@@ -405,20 +405,20 @@ describe Chef::Provider::Package do
       end
 
       it "creates the preseed file in the cache" do
-        @response_file_resource.should_receive(:run_action).with(:create)
+        expect(@response_file_resource).to receive(:run_action).with(:create)
         @provider.get_preseed_file("java", "6")
       end
 
       it "returns the path to the response file if the response file was updated" do
-        @provider.get_preseed_file("java", "6").should == @response_file_destination
+        expect(@provider.get_preseed_file("java", "6")).to eq(@response_file_destination)
       end
 
       it "should return false if the response file has not been updated" do
         @response_file_resource.updated_by_last_action(false)
-        @response_file_resource.should_not be_updated_by_last_action
+        expect(@response_file_resource).not_to be_updated_by_last_action
         # don't let the response_file_resource set updated to true
-        @response_file_resource.should_receive(:run_action).with(:create)
-        @provider.get_preseed_file("java", "6").should be(false)
+        expect(@response_file_resource).to receive(:run_action).with(:create)
+        expect(@provider.get_preseed_file("java", "6")).to be(false)
       end
 
     end