chef 11.4.4 → 11.6.0.hotfix.1

data/spec/unit/provider/package/zypper_spec.rb

@@ -50,7 +50,7 @@ describe Chef::Provider::Package::Zypper do
     end
 
     it "should run zypper info with the package name" do
-      @provider.should_receive(:popen4).with("zypper info #{@new_resource.package_name}").and_return(@status)
+      @provider.should_receive(:popen4).with("zypper --non-interactive info #{@new_resource.package_name}").and_return(@status)
       @provider.load_current_resource
     end
 
@@ -92,34 +92,99 @@ describe Chef::Provider::Package::Zypper do
 
   describe "install_package" do
     it "should run zypper install with the package name and version" do
-      @provider.should_receive(:run_command).with({
-          :command => "zypper -n --no-gpg-checks install -l  emacs=1.0",
-        })
+      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(true)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive install --auto-agree-with-licenses emacs=1.0")
+      @provider.install_package("emacs", "1.0")
+    end
+    it "should run zypper install without gpg checks" do
+      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(false)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks install "+
+        "--auto-agree-with-licenses emacs=1.0")
+      @provider.install_package("emacs", "1.0")
+    end
+    it "should warn about gpg checks on zypper install" do
+      Chef::Log.should_receive(:warn).with(
+        /All packages will be installed without gpg signature checks/)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks install "+
+        "--auto-agree-with-licenses emacs=1.0")
       @provider.install_package("emacs", "1.0")
     end
   end
 
   describe "upgrade_package" do
     it "should run zypper update with the package name and version" do
-      @provider.should_receive(:run_command).with({
-          :command => "zypper -n --no-gpg-checks install -l emacs=1.0",
-        })
+      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(true)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive install --auto-agree-with-licenses emacs=1.0")
+      @provider.upgrade_package("emacs", "1.0")
+    end
+    it "should run zypper update without gpg checks" do
+      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(false)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks install "+
+        "--auto-agree-with-licenses emacs=1.0")
+      @provider.upgrade_package("emacs", "1.0")
+    end
+    it "should warn about gpg checks on zypper upgrade" do
+      Chef::Log.should_receive(:warn).with(
+        /All packages will be installed without gpg signature checks/)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks install "+
+        "--auto-agree-with-licenses emacs=1.0")
+      @provider.upgrade_package("emacs", "1.0")
+    end
+    it "should run zypper upgrade without gpg checks" do
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks install "+
+        "--auto-agree-with-licenses emacs=1.0")
+
       @provider.upgrade_package("emacs", "1.0")
     end
   end
 
   describe "remove_package" do
     it "should run zypper remove with the package name" do
-      @provider.should_receive(:run_command).with({
-          :command => "zypper -n --no-gpg-checks remove  emacs=1.0",
-        })
+      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(true)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive remove emacs=1.0")
+      @provider.remove_package("emacs", "1.0")
+    end
+    it "should run zypper remove without gpg checks" do
+      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(false)
+      @provider.should_receive(:shell_out!).with(
+          "zypper --non-interactive --no-gpg-checks remove emacs=1.0")
+      @provider.remove_package("emacs", "1.0")
+    end
+    it "should warn about gpg checks on zypper remove" do
+      Chef::Log.should_receive(:warn).with(
+        /All packages will be installed without gpg signature checks/)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks remove emacs=1.0")
+
       @provider.remove_package("emacs", "1.0")
     end
   end
 
   describe "purge_package" do
     it "should run remove_package with the name and version" do
-      @provider.should_receive(:remove_package).with("emacs", "1.0")
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks remove --clean-deps emacs=1.0")
+      @provider.purge_package("emacs", "1.0")
+    end
+    it "should run zypper purge without gpg checks" do
+      Chef::Config.stub(:[]).with(:zypper_check_gpg).and_return(false)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks remove --clean-deps emacs=1.0")
+      @provider.purge_package("emacs", "1.0")
+    end
+    it "should warn about gpg checks on zypper purge" do
+      Chef::Log.should_receive(:warn).with(
+        /All packages will be installed without gpg signature checks/)
+      @provider.should_receive(:shell_out!).with(
+        "zypper --non-interactive --no-gpg-checks remove --clean-deps emacs=1.0")
       @provider.purge_package("emacs", "1.0")
     end
   end
@@ -131,27 +196,24 @@ describe Chef::Provider::Package::Zypper do
 
     describe "install_package" do
       it "should run zypper install with the package name and version" do
-        @provider.should_receive(:run_command).with({
-            :command => "zypper install -y emacs"
-          })
+        @provider.should_receive(:shell_out!).with(
+          "zypper --no-gpg-checks install --auto-agree-with-licenses -y emacs")
         @provider.install_package("emacs", "1.0")
       end
     end
-  
+
     describe "upgrade_package" do
       it "should run zypper update with the package name and version" do
-        @provider.should_receive(:run_command).with({
-            :command => "zypper install -y emacs"
-          })
+        @provider.should_receive(:shell_out!).with(
+          "zypper --no-gpg-checks install --auto-agree-with-licenses -y emacs")
         @provider.upgrade_package("emacs", "1.0")
       end
     end
-  
+
     describe "remove_package" do
       it "should run zypper remove with the package name" do
-        @provider.should_receive(:run_command).with({
-            :command => "zypper remove -y emacs"
-          })
+        @provider.should_receive(:shell_out!).with(
+           "zypper --no-gpg-checks remove -y emacs")
         @provider.remove_package("emacs", "1.0")
       end
     end

data/spec/unit/provider/package_spec.rb

@@ -20,10 +20,6 @@ require 'spec_helper'
 
 describe Chef::Provider::Package do
   before do
-    #Terrible, but we need to implement a pseduo-filesystem for testing
-    #to not have this line. Only affects updating state fields.
-    Chef::Provider::CookbookFile.any_instance.stub(:update_new_file_state)
-
     @node = Chef::Node.new
     @events = Chef::EventDispatch::Dispatcher.new
     @run_context = Chef::RunContext.new(@node, {}, @events)

data/spec/unit/provider/powershell_spec.rb

@@ -0,0 +1,38 @@
+#
+# Author:: Adam Edwards (<adamed@opscode.com>)
+# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+# 
+#     http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+describe Chef::Provider::PowershellScript, "action_run" do
+
+  before(:each) do
+    @node = Chef::Node.new
+
+    @node.default["kernel"] = Hash.new
+    @node.default["kernel"][:machine] = :x86_64.to_s
+    
+    @run_context = Chef::RunContext.new(@node, {}, @events)
+    @new_resource = Chef::Resource::PowershellScript.new('run some powershell code', @run_context)
+
+    @provider = Chef::Provider::PowershellScript.new(@new_resource, @run_context)
+  end
+
+  it "should set the -File flag as the last flag" do
+    @provider.flags.split(' ').pop.should == "-File"
+  end
+
+end

data/spec/unit/provider/remote_directory_spec.rb

@@ -28,9 +28,6 @@ end
 describe Chef::Provider::RemoteDirectory do
   before do
     Chef::FileAccessControl.any_instance.stub(:set_all)
-    #Terrible, but we need to implement a pseduo-filesystem for testing
-    #to not have this line. Only affects updating state fields.
-    Chef::Provider::CookbookFile.any_instance.stub(:update_new_file_state)
 
     @resource = Chef::Resource::RemoteDirectory.new(File.join(Dir.tmpdir, "tafty"))
     # in CHEF_SPEC_DATA/cookbooks/openldap/files/default/remotedir
@@ -214,7 +211,6 @@ describe Chef::Provider::RemoteDirectory do
         ::File.open(@destination_dir + '/remotesubdir/remote_subdir_file1.txt', 'a') {|f| f.puts "blah blah blah" }
         file1md5 = Digest::MD5.hexdigest(::File.read(@destination_dir + '/remote_dir_file1.txt'))
         subdirfile1md5 = Digest::MD5.hexdigest(::File.read(@destination_dir + '/remotesubdir/remote_subdir_file1.txt'))
-        @provider.stub!(:update_new_file_state)
         @provider.run_action(:create)
         file1md5.eql?(Digest::MD5.hexdigest(::File.read(@destination_dir + '/remote_dir_file1.txt'))).should be_true
         subdirfile1md5.eql?(Digest::MD5.hexdigest(::File.read(@destination_dir + '/remotesubdir/remote_subdir_file1.txt'))).should be_true

data/spec/unit/provider/remote_file/cache_control_data_spec.rb

@@ -0,0 +1,211 @@
+#
+# Author:: Daniel DeLeo (<dan@opscode.com>)
+# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'uri'
+
+CACHE_FILE_TRUNCATED_FRIENDLY_FILE_NAME_LENGTH = 64
+CACHE_FILE_MD5_HEX_LENGTH = 32
+CACHE_FILE_JSON_FILE_EXTENSION_LENGTH = 5
+CACHE_FILE_PATH_LIMIT =
+  CACHE_FILE_TRUNCATED_FRIENDLY_FILE_NAME_LENGTH +
+  1 +
+  CACHE_FILE_MD5_HEX_LENGTH +
+  CACHE_FILE_JSON_FILE_EXTENSION_LENGTH # {friendly}-{md5hex}.json == 102
+
+describe Chef::Provider::RemoteFile::CacheControlData do
+
+  let(:uri) { URI.parse("http://www.google.com/robots.txt") }
+
+  subject(:cache_control_data) do
+    Chef::Provider::RemoteFile::CacheControlData.load_and_validate(uri, current_file_checksum)
+  end
+
+  let(:cache_path) { "remote_file/http___www_google_com_robots_txt-9839677abeeadf0691026e0cabca2339.json" }
+
+  # the checksum of the file we have on disk already
+  let(:current_file_checksum) { "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855" }
+
+  context "when loading data for an unknown URI" do
+
+    before do
+      Chef::FileCache.should_receive(:load).with(cache_path).and_raise(Chef::Exceptions::FileNotFound, "nope")
+    end
+
+    context "and there is no current copy of the file" do
+      let(:current_file_checksum) { nil }
+
+      it "returns empty cache control data" do
+        cache_control_data.etag.should be_nil
+        cache_control_data.mtime.should be_nil
+      end
+    end
+
+    it "returns empty cache control data" do
+      cache_control_data.etag.should be_nil
+      cache_control_data.mtime.should be_nil
+    end
+
+    context "and the URI contains a password" do
+
+      let(:uri) { URI.parse("http://bob:password@example.org/") }
+      let(:cache_path) { "remote_file/http___bob_XXXX_example_org_-f121caacb74c05a35bcefdf578ed5fc9.json" }
+
+      it "loads the cache data from a path based on a sanitized URI" do
+        Chef::Provider::RemoteFile::CacheControlData.load_and_validate(uri, current_file_checksum)
+      end
+    end
+  end
+
+  describe "when loading data for a known URI" do
+
+    # the checksum of the file last we fetched it.
+    let(:last_fetched_checksum) { "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855" }
+
+    let(:etag) { "\"a-strong-identifier\"" }
+    let(:mtime) { "Tue, 21 May 2013 19:19:23 GMT" }
+
+    let(:cache_json_data) do
+      cache = {}
+      cache["etag"] = etag
+      cache["mtime"] = mtime
+      cache["checksum"] = last_fetched_checksum
+      cache.to_json
+    end
+
+    before do
+      Chef::FileCache.should_receive(:load).with(cache_path).and_return(cache_json_data)
+    end
+
+    context "and there is no on-disk copy of the file" do
+      let(:current_file_checksum) { nil }
+
+      it "returns empty cache control data" do
+        cache_control_data.etag.should be_nil
+        cache_control_data.mtime.should be_nil
+      end
+    end
+
+    context "and the cached checksum does not match the on-disk copy" do
+      let(:current_file_checksum) { "e2a8938cc31754f6c067b35aab1d0d4864272e9bf8504536ef3e79ebf8432305" }
+
+      it "returns empty cache control data" do
+        cache_control_data.etag.should be_nil
+        cache_control_data.mtime.should be_nil
+      end
+    end
+
+    context "and the cached checksum matches the on-disk copy" do
+
+      it "populates the cache control data" do
+        cache_control_data.etag.should == etag
+        cache_control_data.mtime.should == mtime
+      end
+    end
+
+    context "and the cached checksum data is corrupted" do
+      let(:cache_json_data) { '{"foo",,"bar" []}' }
+
+      it "returns empty cache control data" do
+        cache_control_data.etag.should be_nil
+        cache_control_data.mtime.should be_nil
+      end
+    end
+  end
+
+  describe "when saving to disk" do
+
+    let(:etag) { "\"a-strong-identifier\"" }
+    let(:mtime) { "Tue, 21 May 2013 19:19:23 GMT" }
+    let(:fetched_file_checksum) { "e2a8938cc31754f6c067b35aab1d0d4864272e9bf8504536ef3e79ebf8432305" }
+
+    let(:expected_serialization_data) do
+      data = {}
+      data["etag"] = etag
+      data["mtime"] = mtime
+      data["checksum"] = fetched_file_checksum
+      data
+    end
+
+    before do
+      cache_control_data.etag = etag
+      cache_control_data.mtime = mtime
+      cache_control_data.checksum = fetched_file_checksum
+    end
+
+    it "serializes its attributes to JSON" do
+      # we have to test this separately because ruby 1.8 hash order is unstable
+      # so we can't count on the order of the keys in the json format.
+
+      json_data = cache_control_data.json_data
+      Chef::JSONCompat.from_json(json_data).should == expected_serialization_data
+    end
+
+    it "writes data to the cache" do
+      json_data = cache_control_data.json_data
+      Chef::FileCache.should_receive(:store).with(cache_path, json_data)
+      cache_control_data.save
+    end
+
+    context "and the URI contains a password" do
+
+      let(:uri) { URI.parse("http://bob:password@example.org/") }
+      let(:cache_path) { "remote_file/http___bob_XXXX_example_org_-f121caacb74c05a35bcefdf578ed5fc9.json" }
+
+      it "writes the data to the cache with a sanitized path name" do
+        json_data = cache_control_data.json_data
+        Chef::FileCache.should_receive(:store).with(cache_path, json_data)
+        cache_control_data.save
+      end
+    end
+
+    # Cover the very long remote file path case -- see CHEF-4422 where
+    # local cache file names generated from the long uri exceeded
+    # local file system path limits resulting in exceptions from
+    # file system API's on both Windows and Unix systems.
+    context "and the URI results in a file cache path that exceeds #{CACHE_FILE_PATH_LIMIT} characters in length" do
+      let(:long_remote_path) { "http://www.bing.com/" +  ('0' * (CACHE_FILE_TRUNCATED_FRIENDLY_FILE_NAME_LENGTH * 2 )) }
+      let(:uri) { URI.parse(long_remote_path) }
+      let(:truncated_remote_uri) { URI.parse(long_remote_path[0...CACHE_FILE_TRUNCATED_FRIENDLY_FILE_NAME_LENGTH]) }
+      let(:truncated_file_cache_path) do
+        cache_control_data_truncated = Chef::Provider::RemoteFile::CacheControlData.load_and_validate(truncated_remote_uri, current_file_checksum)
+        cache_control_data_truncated.send('sanitized_cache_file_basename')[0...CACHE_FILE_TRUNCATED_FRIENDLY_FILE_NAME_LENGTH]
+      end
+
+      it "truncates the file cache path to 102 characters" do
+        normalized_cache_path = cache_control_data.send('sanitized_cache_file_basename')
+
+        Chef::FileCache.should_receive(:store).with("remote_file/" + normalized_cache_path, cache_control_data.json_data)              
+
+        cache_control_data.save
+
+        normalized_cache_path.length.should == CACHE_FILE_PATH_LIMIT
+      end
+
+      it "uses a file cache path that starts with the first #{CACHE_FILE_TRUNCATED_FRIENDLY_FILE_NAME_LENGTH} characters of the URI" do
+        normalized_cache_path = cache_control_data.send('sanitized_cache_file_basename')
+
+        truncated_file_cache_path.length.should == CACHE_FILE_TRUNCATED_FRIENDLY_FILE_NAME_LENGTH
+        normalized_cache_path.start_with?(truncated_file_cache_path).should == true
+      end
+    end
+
+  end
+
+end
+

data/spec/unit/provider/remote_file/content_spec.rb

@@ -0,0 +1,230 @@
+#
+# Author:: Lamont Granquist (<lamont@opscode.com>)
+# Copyright:: Copyright (c) 2013 Opscode, Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Chef::Provider::RemoteFile::Content do
+
+  #
+  # mock setup
+  #
+
+  let(:current_resource) do
+    Chef::Resource::RemoteFile.new("remote-file-content-spec (current resource)")
+  end
+
+  let(:source) { [ "http://opscode.com/seattle.txt" ] }
+
+  let(:new_resource) do
+    r = Chef::Resource::RemoteFile.new("remote-file-content-spec (current resource)")
+    r.source(source)
+    r
+  end
+
+  let(:run_context) { mock("Chef::RunContext") }
+
+  #
+  # subject
+  #
+  let(:content) do
+    Chef::Provider::RemoteFile::Content.new(new_resource, current_resource, run_context)
+  end
+
+  describe "when the checksum of the current_resource matches the checksum set on the resource" do
+    before do
+      new_resource.stub!(:checksum).and_return("0fd012fdc96e96f8f7cf2046522a54aed0ce470224513e45da6bc1a17a4924aa")
+      current_resource.stub!(:checksum).and_return("0fd012fdc96e96f8f7cf2046522a54aed0ce470224513e45da6bc1a17a4924aa")
+    end
+
+    it "should return nil for the tempfile" do
+      content.tempfile.should be_nil
+    end
+
+    it "should not call any fetcher" do
+      Chef::Provider::RemoteFile::Fetcher.should_not_receive(:for_resource)
+    end
+  end
+
+  describe "when the checksum of the current_resource is a partial match for the checksum set on the resource" do
+    before do
+      new_resource.stub!(:checksum).and_return("0fd012fd")
+      current_resource.stub!(:checksum).and_return("0fd012fdc96e96f8f7cf2046522a54aed0ce470224513e45da6bc1a17a4924aa")
+    end
+
+    it "should return nil for the tempfile" do
+      content.tempfile.should be_nil
+    end
+
+    it "should not call any fetcher" do
+      Chef::Provider::RemoteFile::Fetcher.should_not_receive(:for_resource)
+    end
+  end
+
+  shared_examples_for "the resource needs fetching" do
+    before do
+      # FIXME: test one or the other nil, test both not nil and not equal, abuse the regexp a little
+      @uri = mock("URI")
+      URI.should_receive(:parse).with(new_resource.source[0]).and_return(@uri)
+    end
+
+    describe "when the fetcher returns nil for the tempfile" do
+      before do
+        http_fetcher = mock("Chef::Provider::RemoteFile::HTTP", :fetch => nil)
+        Chef::Provider::RemoteFile::Fetcher.should_receive(:for_resource).with(@uri, new_resource, current_resource).and_return(http_fetcher)
+      end
+
+      it "should return nil for the tempfile" do
+        content.tempfile.should be_nil
+      end
+    end
+
+    describe "when the fetcher returns a valid tempfile" do
+
+      let(:mtime) { Time.now }
+      let(:tempfile) { mock("Tempfile") }
+      let(:http_fetcher) { mock("Chef::Provider::RemoteFile::HTTP", :fetch => tempfile) }
+
+      before do
+        Chef::Provider::RemoteFile::Fetcher.should_receive(:for_resource).with(@uri, new_resource, current_resource).and_return(http_fetcher)
+      end
+
+      it "should return the tempfile object to the caller" do
+        content.tempfile.should == tempfile
+      end
+
+    end
+  end
+  describe "when the checksum are both nil" do
+    before do
+      new_resource.checksum.should be_nil
+      current_resource.checksum.should be_nil
+    end
+    it_behaves_like "the resource needs fetching"
+  end
+
+  describe "when the current_resource checksum is nil" do
+    before do
+      new_resource.stub!(:checksum).and_return("fd012fd")
+      current_resource.stub!(:checksum).and_return(nil)
+    end
+    it_behaves_like "the resource needs fetching"
+  end
+
+  describe "when the new_resource checksum is nil" do
+    before do
+      new_resource.stub!(:checksum).and_return(nil)
+      current_resource.stub!(:checksum).and_return("0fd012fdc96e96f8f7cf2046522a54aed0ce470224513e45da6bc1a17a4924aa")
+    end
+    it_behaves_like "the resource needs fetching"
+  end
+
+  describe "when the checksums are a partial match, but not to the leading portion" do
+    before do
+      new_resource.stub!(:checksum).and_return("fd012fd")
+      current_resource.stub!(:checksum).and_return("0fd012fdc96e96f8f7cf2046522a54aed0ce470224513e45da6bc1a17a4924aa")
+    end
+    it_behaves_like "the resource needs fetching"
+  end
+
+
+  describe "when the fetcher throws an exception" do
+    before do
+      new_resource.stub!(:checksum).and_return(nil)
+      current_resource.stub!(:checksum).and_return(nil)
+      @uri = mock("URI")
+      URI.should_receive(:parse).with(new_resource.source[0]).and_return(@uri)
+      http_fetcher = mock("Chef::Provider::RemoteFile::HTTP")
+      http_fetcher.should_receive(:fetch).and_raise(Errno::ECONNREFUSED)
+      Chef::Provider::RemoteFile::Fetcher.should_receive(:for_resource).with(@uri, new_resource, current_resource).and_return(http_fetcher)
+    end
+
+    it "should propagate the error back to the caller" do
+      lambda { content.tempfile }.should raise_error(Errno::ECONNREFUSED)
+    end
+  end
+
+  describe "when there is an array of sources and the first fails" do
+
+    let(:source) { [ "http://opscode.com/seattle.txt", "http://opscode.com/nyc.txt" ] }
+    before do
+      new_resource.stub!(:checksum).and_return(nil)
+      current_resource.stub!(:checksum).and_return(nil)
+      @uri0 = mock("URI0")
+      @uri1 = mock("URI1")
+      URI.should_receive(:parse).with(new_resource.source[0]).and_return(@uri0)
+      URI.should_receive(:parse).with(new_resource.source[1]).and_return(@uri1)
+      @http_fetcher_throws_exception = mock("Chef::Provider::RemoteFile::HTTP")
+      @http_fetcher_throws_exception.should_receive(:fetch).at_least(:once).and_raise(Errno::ECONNREFUSED)
+      Chef::Provider::RemoteFile::Fetcher.should_receive(:for_resource).with(@uri0, new_resource, current_resource).and_return(@http_fetcher_throws_exception)
+    end
+
+    describe "when the second url succeeds" do
+      before do
+        @tempfile = mock("Tempfile")
+        mtime = Time.now
+        http_fetcher_works = mock("Chef::Provider::RemoteFile::HTTP", :fetch => @tempfile)
+        Chef::Provider::RemoteFile::Fetcher.should_receive(:for_resource).with(@uri1, new_resource, current_resource).and_return(http_fetcher_works)
+      end
+
+      it "should return a valid tempfile" do
+        content.tempfile.should == @tempfile
+      end
+
+      it "should not mutate the new_resource" do
+        content.tempfile
+        new_resource.source.length.should == 2
+      end
+    end
+
+    describe "when both urls fail" do
+      before do
+        Chef::Provider::RemoteFile::Fetcher.should_receive(:for_resource).with(@uri1, new_resource, current_resource).and_return(@http_fetcher_throws_exception)
+      end
+
+      it "should propagate the error back to the caller" do
+        lambda { content.tempfile }.should raise_error(Errno::ECONNREFUSED)
+      end
+    end
+  end
+
+  describe "when there is an array of sources and the first succeeds" do
+    let(:source) { [ "http://opscode.com/seattle.txt", "http://opscode.com/nyc.txt" ] }
+    before do
+      new_resource.stub!(:checksum).and_return(nil)
+      current_resource.stub!(:checksum).and_return(nil)
+      @uri0 = mock("URI0")
+      URI.should_receive(:parse).with(new_resource.source[0]).and_return(@uri0)
+      URI.should_not_receive(:parse).with(new_resource.source[1])
+      @tempfile = mock("Tempfile")
+      mtime = Time.now
+      http_fetcher_works = mock("Chef::Provider::RemoteFile::HTTP", :fetch => @tempfile)
+      Chef::Provider::RemoteFile::Fetcher.should_receive(:for_resource).with(@uri0, new_resource, current_resource).and_return(http_fetcher_works)
+    end
+
+    it "should return a valid tempfile" do
+      content.tempfile.should == @tempfile
+    end
+
+    it "should not mutate the new_resource" do
+      content.tempfile
+      new_resource.source.length.should == 2
+    end
+  end
+
+end
+