chef 10.16.0.rc.0 → 10.16.0.rc.1

data/lib/chef/application/windows_service.rb

@@ -88,14 +88,7 @@ class Chef
               # If we've stopped, then bail out now, instead of going on to run Chef
               next if state != RUNNING
 
-              @chef_client = Chef::Client.new(
-                @chef_client_json, 
-                :override_runlist => config[:override_runlist]
-              )
-              @chef_client_json = nil
-
-              @chef_client.run
-              @chef_client = nil
+              run_chef_client
 
               Chef::Log.debug("Sleeping for #{Chef::Config[:interval]} seconds")
               client_sleep Chef::Config[:interval]
@@ -225,7 +218,7 @@ class Chef
           sleep chunk_length
         end
       end
-
+      
     end
   end
 end

data/lib/chef/config.rb

@@ -303,6 +303,9 @@ class Chef
     cache_type "BasicFile"
     cache_options({ :path => platform_specific_path("/var/chef/cache/checksums"), :skip_expires => true })
 
+    # Set to false to silence Chef 11 deprecation warnings:
+    chef11_deprecation_warnings true
+
     # Arbitrary knife configuration data
     knife Hash.new
 

data/lib/chef/node.rb

@@ -397,7 +397,7 @@ class Chef
 
     # Lazy initializer for tags attribute
     def tags
-      self[:tags] = [] unless attribute?(:tags)
+      self.set[:tags] = [] unless attribute?(:tags)
       self[:tags]
     end
 

data/lib/chef/node/attribute.rb

@@ -318,7 +318,24 @@ class Chef
 
       def []=(key, value)
         # If we don't have one, then we'll pretend we're normal
-        @set_type ||= :normal
+        if @set_type.nil?
+          @set_type = :normal
+          warning=<<-W
+Setting attributes without specifying a precedence is deprecated and will be
+removed in Chef 11.0. To set attributes at normal precedence, change code like:
+`node["key"] = "value"` # Not this
+to:
+`node.set["key"] = "value"` # This
+
+Called from:
+W
+
+          warning_with_line_nrs = caller[0...3].inject(warning) do |msg, source_line|
+            msg << "  #{source_line}\n"
+          end
+
+          Chef::Log.warn(warning_with_line_nrs) if Chef::Config[:chef11_deprecation_warnings]
+        end
 
         if set_unless_value_present
           if get_value(set_type_hash, key) != nil

data/lib/chef/version.rb

@@ -17,7 +17,7 @@
 
 class Chef
   CHEF_ROOT = File.dirname(File.expand_path(File.dirname(__FILE__)))
-  VERSION = '10.16.0.rc.0'
+  VERSION = '10.16.0.rc.1'
 end
 
 # NOTE: the Chef::Version class is defined in version_class.rb

data/spec/unit/application/solo_spec.rb

@@ -71,7 +71,7 @@ describe Chef::Application::Solo do
 
         it "should perform a RESTful GET on the supplied URL" do
           @app.reconfigure
-          @app.chef_solo_json.should == {"a" => "b"}
+          @app.instance_variable_get(:@chef_client_json).should == {"a" => "b"}
         end
       end
 
@@ -84,7 +84,7 @@ describe Chef::Application::Solo do
 
         it "should parse the json out of the file" do
           @app.reconfigure
-          @app.chef_solo_json.should == {"a" => "b"}
+          @app.instance_variable_get(:@chef_client_json).should == {"a" => "b"}
         end
       end
 

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: chef
 version: !ruby/object:Gem::Version 
-  hash: -1571179094
+  hash: 1801040005
   prerelease: 8
   segments: 
   - 10
   - 16
   - 0
   - rc
-  - 0
-  version: 10.16.0.rc.0
+  - 1
+  version: 10.16.0.rc.1
 platform: ruby
 authors: 
 - Adam Jacob
@@ -17,7 +17,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-10-11 00:00:00 Z
+date: 2012-10-17 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: mixlib-config