chef-umami 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 332bd1c06e4c1ef37879026cb156036d17c0ab9f
-  data.tar.gz: 0af958230fbe4ba6ee6ad8bc548a4cd724b6b23f
+  metadata.gz: 782fcbb03ba84bce326bfc8d8c3e51b4a36f4c1e
+  data.tar.gz: c7fa44a081c7462509665637bcf1414249f35975
 SHA512:
-  metadata.gz: 9bb516181d9d2fc958e79827fe1cf9fc60c8b122aacaa03404239d6b4bd2e97a1f6cd3a22f9f7cc175297ae815d0428a42bcdd56b2636b3014c8155b43860fa1
-  data.tar.gz: 38ef2f48e5172497dd44c76dbab69fe437dc6dc54db8420e16fed2ca1b497ae1aa14157371d38533d90549f03d7499d81a9482db1e1f8efd93b474fcac798eba
+  metadata.gz: f6f76421bb97b53f93b3fedac539aa4d805d556cde66a36d78fb0acc3e55299df479d7285e696cdeca4597a0aabd7e95eac098d0c41539820cb78478a93d17ff
+  data.tar.gz: f17e6d3eaf84166fbb2a96578ec5274b97bfeedc815b2db512a6bce12b3e7edb17a9852319be574325d51c009eb53980f53f92dc64ce672cf372dd37567754d9

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## [0.0.5]
+- Adds support for parsing options.
+- Minor typo fixes.
+
 ## [0.0.4]
 - Fixes a bug where two methods have the same name. Thanks @HarryYC.
 - Adds `spec_helper.rb` for unit tests, cutting down on boilerplate in each unit test.

data/README.md

@@ -7,6 +7,26 @@ Let's see it in action!
 
 [![asciicast](https://asciinema.org/a/138816.png)](https://asciinema.org/a/138816)
 
+## Running `umami`
+
+A number of options maybe specified on the command line:
+
+```bash
+Usage: umami [options]
+
+A taste you won't forget!
+
+    -h, --help                       Prints this help message
+    -i, --[no-]integration-tests     Write integration tests (DEFAULT: true)
+    -p, --policyfile POLICYFILE_PATH Specify the path to a policy (DEFAULT: Policyfile.rb)
+    -r, --recipes RECIPE1,RECIPE2    Specify one or more recipes for which we'll write tests (DEFAULT: All recipes)
+    -t, --test-root TEST_ROOT_PATH   Specify the path into which we'll write tests (DEFAULT: spec)
+    -u, --[no-]unit-tests            Write unit tests (DEFAULT: true)
+    -v, --version                    Show version and exit
+```
+
+If not options are specified, a reasonable set of defaults are defined.
+
 ## How does it Work?
 
 `umami` loads up one or more cookbooks in a `chef-zero` instance, executes the
@@ -160,11 +180,11 @@ can build on. **Do NOT depend solely on `umami` to provide test coverage!**
 
 This project came to be largely out of fear of having to write a lot of test
 code from scratch where none had previously existed. The idea of starting from
-nothing seemed so daunting that it's likely no on would ever get started. I
+nothing seemed so daunting that it's likely no one would ever get started. I
 wanted to give Chef developers a means to expedite writing tests. After all,
 it's much easier to modify code than it is to write it in the first place.
 
-`umami` is the product of reearch into various projects' code, such as
+`umami` is the product of research into various projects' code, such as
 Chef, ChefDK, and Test Kitchen. I am grateful to everyone that has contributed
 to those projects. `umami` borrows some patterns from those projects and, in
 some cases, bits of code.

data/bin/umami

@@ -1,7 +1,7 @@
 #!/opt/chefdk/embedded/bin/ruby
 
-chef_umami_lib = File.expand_path(File.join(File.dirname(__FILE__), "..", "lib"))
-$:.unshift(chef_umami_lib)
-require "chef-umami/runner"
+chef_umami_lib = File.expand_path(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(chef_umami_lib)
+require 'chef-umami/runner'
 
 Umami::Runner.new.run

data/lib/chef-umami/client.rb

@@ -16,8 +16,6 @@ require 'chef'
 
 module Umami
   class Client
-
-    attr_reader :client
     def initialize
       @client = client
     end
@@ -45,6 +43,5 @@ module Umami
     def resource_collection
       client.run_status.run_context.resource_collection
     end
-
   end
 end

data/lib/chef-umami/exceptions.rb

@@ -13,8 +13,6 @@
 #   limitations under the License.
 
 module Umami
-
   class InvalidPolicyfileLockFilename < StandardError
   end
-
 end

data/lib/chef-umami/helpers/filetools.rb

@@ -15,32 +15,30 @@
 module Umami
   module Helper
     module FileTools
+      require 'fileutils'
+      require 'rubocop'
 
-    require 'fileutils'
-    require 'rubocop'
-
-    def write_file(path = nil, content = '')
-      parent_dir = File.dirname(path)
-      FileUtils.mkdir_p(parent_dir) unless ::File.exist?(parent_dir)
-      f = File.open(path, 'w') # Write with prejudice.
-      f.write(content)
-      f.close
-    end
-
-    # Call Rubocop to ensure proper indentation and thus legibility.
-    def enforce_styling(path = 'spec/umami/')
-      puts "Running Rubocop over '#{path}' to enforce styling..."
-      r = RuboCop::CLI.new
-      # Don't output to STDOUT.
-      args = [
-        '--only', 'Style/IndentationWidth,Style/IndentationConsistency',
-        '--auto-correct',
-        '--out', '/dev/null',
-        path
-      ]
-      r.run(args)
-    end
+      def write_file(path = nil, content = '')
+        parent_dir = File.dirname(path)
+        FileUtils.mkdir_p(parent_dir) unless ::File.exist?(parent_dir)
+        f = File.open(path, 'w') # Write with prejudice.
+        f.write(content)
+        f.close
+      end
 
+      # Call Rubocop to ensure proper indentation and thus legibility.
+      def enforce_styling(path = 'spec/umami/')
+        puts "Running Rubocop over '#{path}' to enforce styling..."
+        r = RuboCop::CLI.new
+        # Don't output to STDOUT.
+        args = [
+          '--only', 'Style/IndentationWidth,Style/IndentationConsistency',
+          '--auto-correct',
+          '--out', '/dev/null',
+          path
+        ]
+        r.run(args)
+      end
     end
   end
 end

data/lib/chef-umami/helpers/inspec.rb

@@ -15,14 +15,14 @@
 module Umami
   module Helper
     module InSpec
-
       # Call on a resource's #identity method to help describe the resource.
       # This saves us from having to know/code the identity attribute for each
       # resource (i.e. File is :path, User is :username, etc).
       def desciption(resource)
-        identity = resource.identity
         if identity.is_a? Hash # #identity could return a Hash. Take the first value.
           identity = identity.values.first
+        else
+          identity = resource.identity
         end
         "describe #{resource.declared_type}('#{identity}') do"
       end
@@ -34,17 +34,17 @@ module Umami
       #  (i.e. testing a directory resource requires defining a file test).
       #  2. The method should should return a string joined by newlines.
       #
-      #def test_wutang(resource)
-      #  test = [desciption(resource)]
-      #  test << "it { should be_financially_sound }"
-      #  test << "it { should be_diverisified }"
-      #  test.join("\n")
-      #end
+      # def test_wutang(resource)
+      #   test = [desciption(resource)]
+      #   test << "it { should be_financially_sound }"
+      #   test << "it { should be_diverisified }"
+      #   test.join("\n")
+      # end
 
       # InSpec can evaluate if a gem is installed via the system `gem` (default)
       # or via some other `gem` binary, defined by either the path to the gem
       # binary of a symbol representing that context.
-      def test_gem_package(resource, gem_binary=nil)
+      def test_gem_package(resource, gem_binary = nil)
         package_name = resource.package_name
         if gem_binary
           if gem_binary.is_a? Symbol
@@ -76,35 +76,35 @@ module Umami
                      "#{resource.weekday} " \
                      "#{resource.command}"
         test << "it { should have_entry('#{cron_entry}').with_user('#{resource.user}') }"
-        test << "end"
+        test << 'end'
         test.join("\n")
       end
 
       def test_file(resource)
         test = ["describe file('#{resource.path}') do"]
         if resource.declared_type =~ /directory/
-          test << "it { should be_directory }"
+          test << 'it { should be_directory }'
         else
-          test << "it { should be_file }"
+          test << 'it { should be_file }'
         end
         # Sometimes we see GIDs instead of group names.
-        if !resource.group.nil?
+        unless resource.group.nil?
           unless resource.group.is_a?(String) && resource.group.empty?
             test << "it { should be_grouped_into '#{resource.group}' }"
           end
         end
         # Guard for UIDs versus usernames as well.
-        if !resource.owner.nil?
+        unless resource.owner.nil?
           unless resource.owner.is_a?(String) && resource.owner.empty?
             test << "it { should be_owned_by '#{resource.owner}' }"
           end
         end
-        if !resource.mode.nil?
+        unless resource.mode.nil?
           unless resource.mode.is_a?(String) && !resource.mode.empty?
             test << "it { should be_mode '#{resource.mode}' }"
           end
         end
-        test << "end"
+        test << 'end'
         test.join("\n")
       end
       alias_method :test_cookbook_file, :test_file
@@ -115,8 +115,8 @@ module Umami
 
       def test_group(resource)
         test = [desciption(resource)]
-        test << "it { should exist }"
-        test << "end"
+        test << 'it { should exist }'
+        test << 'end'
         test.join("\n")
       end
 
@@ -125,18 +125,18 @@ module Umami
         if !resource.version.nil? && !resource.version.empty?
           test << "it { should be_installed.with_version('#{resource.version}') }"
         else
-          test << "it { should be_installed }"
+          test << 'it { should be_installed }'
         end
-        test << "end"
+        test << 'end'
         test.join("\n")
       end
 
       def test_user(resource)
         test = [desciption(resource)]
-        test << "it { should exist }"
+        test << 'it { should exist }'
         # Guard for GIDs rather than strings. Chef aliases the #group method
         # to the #gid method.
-        if !resource.gid.nil?
+        unless resource.gid.nil?
           unless resource.gid.is_a?(String) && !resource.gid.empty?
             test << "it { should belong_to_primary_group '#{resource.gid}' }"
           end
@@ -144,10 +144,9 @@ module Umami
         if !resource.home.nil? && !resource.home.empty?
           test << "it { should have_home_directory '#{resource.home}' }"
         end
-        test << "end"
+        test << 'end'
         test.join("\n")
       end
-
     end
   end
 end

data/lib/chef-umami/helpers/os.rb

@@ -27,27 +27,27 @@ module Umami
           when /aix/
             # `oslevel` => '7.1.0.0'
             version = `oslevel`[0..2]
-            {platform: 'aix', version: version}
+            { platform: 'aix', version: version }
           when /darwin|mac os/
             version = `sw_vers -productVersion`.chomp
-            {platform: 'mac_os_x', version: version}
+            { platform: 'mac_os_x', version: version }
           when /linux/
             # Perform very basic tests to determine distribution.
             if File.exist?('/etc/centos-release')
               version = File.read('/etc/redhat-release').split[2]
-              {platform: 'centos', version: version}
+              { platform: 'centos', version: version }
             elsif File.exist?('/etc/redhat-release') # True for CentOS too...
               version = File.read('/etc/redhat-release').split[6]
-              {platform: 'redhat', version: version}
+              { platform: 'redhat', version: version }
             else
-              {platform: 'centos', version: '7.3.1611'} # Default to something reasonably sane.
+              { platform: 'centos', version: '7.3.1611' } # Default to something reasonably sane.
             end
           when /solaris/
             version = `uname -r`.chomp # Release level (i.e. 5.11).
-            {platform: 'solaris', version: version}
+            { platform: 'solaris', version: version }
           when /mswin|msys|mingw|cygwin|bccwin|wince|emc/
             # Refer to https://en.wikipedia.org/wiki/Ver_(command)
-            win_version = `ver`.chomp.split("Version ")[1].gsub(/]/, '')
+            win_version = `ver`.chomp.split('Version ')[1].gsub(/]/, '')
             case win_version
             when /^6.1.7/
               version = '2008R2' # Also Win 7
@@ -58,14 +58,13 @@ module Umami
             when /^(6.4|10)/
               version = '10'
             end
-            {platform: 'windows', version: version}
+            { platform: 'windows', version: version }
           else
             # Default to something reasonably sane.
-            {platform: 'centos', version: '7.3.1611'}
+            { platform: 'centos', version: '7.3.1611' }
           end
         )
       end
-
     end
   end
 end

data/lib/chef-umami/logger.rb

@@ -14,7 +14,6 @@
 
 module Umami
   module Logger
-
     # Print messages.
     # TODO: Flesh this out so it supports different levels (i.e. info, warn).
     def log(msg = '', level = nil)

data/lib/chef-umami/options.rb

@@ -0,0 +1,72 @@
+#   Copyright 2017 Bloomberg Finance, L.P.
+#
+#   Licensed under the Apache License, Version 2.0 (the "License");
+#   you may not use this file except in compliance with the License.
+#   You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#   Unless required by applicable law or agreed to in writing, software
+#   distributed under the License is distributed on an "AS IS" BASIS,
+#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#   See the License for the specific language governing permissions and
+#   limitations under the License.
+
+require 'chef-umami/version'
+
+module Umami
+  module Options
+    # Parse command line options. Returns hash of options.
+    def parse_options
+      options = {}
+      # Default options
+      options[:integration_tests] = true
+      options[:policyfile] = 'Policyfile.rb'
+      options[:test_root] = 'spec'
+      options[:unit_tests] = true
+
+      parser = OptionParser.new do |opts|
+        opts.banner = opts.banner + "\n\nA taste you won't forget!\n\n"
+        opts.on('-h', '--help', 'Prints this help message') {
+          puts opts
+          exit
+        }
+        opts.on('-i', '--[no-]integration-tests', 'Write integration tests' \
+                " (DEFAULT: #{options[:integration_tests]})") do |integration_tests|
+          options[:integration_tests] = integration_tests
+        end
+        opts.on('-p', '--policyfile POLICYFILE_PATH', 'Specify the path to a policy' \
+                " (DEFAULT: #{options[:policyfile]})") do |policyfile|
+          options[:policyfile] = policyfile
+        end
+        opts.on('-r', '--recipes RECIPE1,RECIPE2', Array,
+                "Specify one or more recipes for which we'll write tests" \
+                ' (DEFAULT: All recipes)') do |recipes|
+          options[:recipes] = recipes
+        end
+        opts.on('-t', '--test-root TEST_ROOT_PATH', "Specify the path into which we'll write tests" \
+                " (DEFAULT: #{options[:test_root]})") do |test_root|
+          options[:test_root] = test_root
+        end
+        opts.on('-u', '--[no-]unit-tests', 'Write unit tests' \
+                " (DEFAULT: #{options[:unit_tests]})") do |unit_tests|
+          options[:unit_tests] = unit_tests
+        end
+        opts.on('-v', '--version', 'Show version and exit') {
+          puts "chef-umami v#{Umami::VERSION}"
+          exit
+        }
+      end
+      begin
+        parser.parse!
+      rescue OptionParser::InvalidOption => e
+        puts "Warning: #{e.message}"
+        if e.message =~ /--pattern/
+          puts 'Ah, this is likely parsed from `rspec` options. We can safely ignore this.'
+        end
+        puts 'Ignoring the option.'
+      end
+      options
+    end
+  end
+end

data/lib/chef-umami/policyfile/exporter.rb

@@ -20,13 +20,12 @@ require 'tmpdir' # Extends Dir
 module Umami
   class Policyfile
     class Exporter
-
       attr_reader   :chef_config_file
       attr_reader   :cookbook_dir
       attr_reader   :export_root
       attr_reader   :export_path
-      attr_accessor :policyfile_lock_file
       attr_reader   :policyfile
+      attr_accessor :policyfile_lock_file
 
       def initialize(policyfile_lock_file = nil, cookbook_dir = nil, policyfile = nil)
         @policyfile = policyfile
@@ -39,10 +38,6 @@ module Umami
         @chef_config_file = "#{export_path}/.chef/config.rb"
       end
 
-      def policyfile
-        @policyfile
-      end
-
       def ui
         @ui ||= ChefDK::UI.new
       end
@@ -92,7 +87,7 @@ module Umami
         rescue ChefDK::PolicyfileExportRepoError => e
           puts "\nFAILED TO EXPORT POLICYFILE: #{e.message} (#{e.class})"
           puts "CAUSE: #{e.cause}"
-          puts "BACKTRACE:"
+          puts 'BACKTRACE:'
           e.backtrace.each do |line|
             puts "\t#{line}"
           end
@@ -101,7 +96,6 @@ module Umami
         cp_fake_client_key
         update_chef_config
       end
-
     end
   end
 end

data/lib/chef-umami/policyfile/uploader.rb

@@ -21,21 +21,15 @@ require 'chef-dk/ui'
 module Umami
   class Policyfile
     class Uploader
-
-      attr_reader :http_client
-      attr_reader :policyfile_lock
       attr_reader :policyfile_lock_file
-      attr_reader :policyfile_uploader
-      attr_reader :storage_config
-      attr_reader :ui
-		  def initialize(policyfile_lock_file = nil)
+      def initialize(policyfile_lock_file = nil)
         @http_client = http_client
         @policyfile_lock_file = policyfile_lock_file
         @policyfile_lock = policyfile_lock
         @policyfile_uploader = policyfile_uploader
         @storage_config = storage_config
         @ui = ui
-		  end
+      end
 
       def storage_config
         @storage_config ||= ChefDK::Policyfile::StorageConfig.new.use_policyfile(policyfile_lock_file)
@@ -86,7 +80,6 @@ module Umami
       def upload
         policyfile_uploader.upload
       end
-
     end
   end
 end

data/lib/chef-umami/runner.rb

@@ -16,6 +16,7 @@ require 'chef'
 require 'chef-umami/exceptions'
 require 'chef-umami/client'
 require 'chef-umami/logger'
+require 'chef-umami/options'
 require 'chef-umami/server'
 require 'chef-umami/policyfile/exporter'
 require 'chef-umami/policyfile/uploader'
@@ -24,17 +25,13 @@ require 'chef-umami/test/integration'
 
 module Umami
   class Runner
-
     include Umami::Logger
+    include Umami::Options
 
     attr_reader :cookbook_dir
-    attr_reader :policyfile_lock_file
-    attr_reader :policyfile
-    # TODO: Build the ability to specify a custom policy lock file name.
-    def initialize(policyfile_lock_file = nil, policyfile = nil)
+    def initialize
+      @config = config
       @cookbook_dir = Dir.pwd
-      @policyfile_lock_file = 'Policyfile.lock.json'
-      @policyfile = policyfile || 'Policyfile.rb'
       @exporter = exporter
       @chef_zero_server = chef_zero_server
       # If we load the uploader or client now, they won't see the updated
@@ -43,8 +40,23 @@ module Umami
       @chef_client = nil
     end
 
+    # A hash of values describing the config. Comprised of command line
+    # options. May (in the future) contain options read from a config file.
+    def config
+      @config ||= parse_options
+    end
+
+    def policyfile
+      config[:policyfile]
+    end
+
+    # Return the computed policyfile lock name.
+    def policyfile_lock_file
+      policyfile.gsub(/\.rb$/, '.lock.json')
+    end
+
     def validate_lock_file!
-      unless policyfile_lock_file.end_with?("lock.json")
+      unless policyfile_lock_file.end_with?('lock.json')
         raise InvalidPolicyfileLockFilename, "Policyfile lock files must end in '.lock.json'. I received '#{policyfile_lock_file}'."
       end
 
@@ -73,7 +85,7 @@ module Umami
       validate_lock_file!
       puts "\nExporting the policy, related cookbooks, and a valid client configuration..."
       exporter.export
-      Chef::Config.from_file("#{exporter.chef_config_file}")
+      Chef::Config.from_file(exporter.chef_config_file)
       chef_zero_server.start
       puts "\nUploading the policy and related cookbooks..."
       uploader.upload
@@ -86,6 +98,12 @@ module Umami
       recipe_resources = {}
       chef_client.resource_collection.each do |resource|
         canonical_recipe = "#{resource.cookbook_name}::#{resource.recipe_name}"
+        unless config[:recipes].empty?
+          # The user has explicitly requested that one or more recipes have
+          # tests written, to the exclusion of others.
+          # ONLY include the recipe if it matches the list.
+          next unless config[:recipes].include?(canonical_recipe)
+        end
         if recipe_resources.key?(canonical_recipe)
           recipe_resources[canonical_recipe] << resource
         else
@@ -98,15 +116,17 @@ module Umami
       re_export_path = Regexp.new('/tmp/umami')
       FileUtils.rm_rf(exporter.export_root) if exporter.export_root.match(re_export_path)
 
-      puts "\nGenerating a set of unit tests..."
-      unit_tester = Umami::Test::Unit.new
-      unit_tester.generate(recipe_resources)
-
-      puts "\nGenerating a set of integration tests..."
-      integration_tester = Umami::Test::Integration.new
-      integration_tester.generate(recipe_resources)
+      if config[:unit_tests]
+        puts "\nGenerating a set of unit tests..."
+        unit_tester = Umami::Test::Unit.new(config[:test_root])
+        unit_tester.generate(recipe_resources)
+      end
 
+      if config[:integration_tests]
+        puts "\nGenerating a set of integration tests..."
+        integration_tester = Umami::Test::Integration.new(config[:test_root])
+        integration_tester.generate(recipe_resources)
+      end
     end
-
   end
 end

data/lib/chef-umami/server.rb

@@ -31,6 +31,5 @@ module Umami
     def stop
       server.stop
     end
-
   end
 end

data/lib/chef-umami/test.rb

@@ -14,10 +14,9 @@
 
 module Umami
   class Test
-
     attr_reader :root_dir
-    def initialize
-      @root_dir = 'spec'
+    def initialize(root_dir)
+      @root_dir = root_dir
     end
 
     # All subclasses should implement the following methods.
@@ -58,6 +57,5 @@ module Umami
     def generate
       raise NoMethodError, "#{self.class} needs to implement the ##{__method__} method! Refer to Umami::Test."
     end
-
   end
 end

data/lib/chef-umami/test/integration.rb

@@ -19,12 +19,11 @@ require 'chef-umami/helpers/filetools'
 module Umami
   class Test
     class Integration < Umami::Test
-
       include Umami::Helper::InSpec
       include Umami::Helper::FileTools
 
       attr_reader :test_root
-      def initialize
+      def initialize(root_dir)
         super
         @test_root = File.join(self.root_dir, 'umami', 'integration')
       end
@@ -32,7 +31,7 @@ module Umami
       # InSpec doesn't need a require statement to use its tests.
       # We define #framework here for completeness.
       def framework
-        "inspec"
+        'inspec'
       end
 
       def test_file_path(cookbook = '', recipe = '')
@@ -58,10 +57,10 @@ module Umami
       # Raise NoMethodError for any other failed calls.
       def method_missing(m, *args, &block)
         case m
-          when /^test_/
-            "# #{m} is not currently defined. Stay tuned for updates."
-          else
-            raise NoMethodError
+        when /^test_/
+          "# #{m} is not currently defined. Stay tuned for updates."
+        else
+          raise NoMethodError
         end
       end
 
@@ -82,14 +81,12 @@ module Umami
         enforce_styling(test_root)
 
         unless test_files_written.empty?
-          puts "Wrote the following integration tests:"
+          puts 'Wrote the following integration tests:'
           test_files_written.each do |f|
             puts "\t#{f}"
           end
         end
-
       end
-
     end
   end
 end

data/lib/chef-umami/test/unit.rb

@@ -19,20 +19,19 @@ require 'chef-umami/helpers/filetools'
 module Umami
   class Test
     class Unit < Umami::Test
-
       include Umami::Helper::OS
       include Umami::Helper::FileTools
 
       attr_reader :test_root
       attr_reader :tested_cookbook # This cookbook.
-      def initialize
+      def initialize(root_dir)
         super
         @test_root = File.join(self.root_dir, 'umami', 'unit', 'recipes')
         @tested_cookbook = File.basename(Dir.pwd)
       end
 
       def framework
-        "chefspec"
+        'chefspec'
       end
 
       def test_file(recipe = '')
@@ -62,7 +61,7 @@ module Umami
       def write_test(resource = nil)
         state_attrs = [] # Attribute hash to be used with #with()
         resource.state.each do |attr, value|
-          next if value.nil? or (value.respond_to?(:empty) and value.empty?)
+          next if value.nil? || (value.respond_to?(:empty) && value.empty?)
           if value.is_a? String
             value = value.gsub("'", "\\\\'") # Escape any single quotes in the value.
           end
@@ -95,7 +94,7 @@ module Umami
           resources.each do |resource|
             content << write_test(resource)
           end
-          content << "end"
+          content << 'end'
           test_file_name = test_file(recipe)
           test_file_content = content.join("\n") + "\n"
           write_file(test_file_name, test_file_content)
@@ -107,14 +106,12 @@ module Umami
         test_files_written << spec_helper_path
 
         unless test_files_written.empty?
-          puts "Wrote the following unit test files:"
+          puts 'Wrote the following unit test files:'
           test_files_written.each do |f|
             puts "\t#{f}"
           end
         end
-
       end
-
     end
   end
 end

data/lib/chef-umami/version.rb

@@ -13,5 +13,5 @@
 #   limitations under the License.
 
 module Umami
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'.freeze
 end

data/spec/runner_spec.rb

@@ -12,10 +12,10 @@
 #   See the License for the specific language governing permissions and
 #   limitations under the License.
 
-require "chef-umami/runner"
+require 'chef-umami/runner'
 
 RSpec.describe Umami::Runner do
-  it "initiates a Umami::Runner object" do
+  it 'initiates a Umami::Runner object' do
     runner = Umami::Runner.new
     expect(runner).to be_an_instance_of(Umami::Runner)
   end

data/spec/spec_helper.rb

@@ -1,103 +0,0 @@
-# This file was generated by the `rspec --init` command. Conventionally, all
-# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
-# The generated `.rspec` file contains `--require spec_helper` which will cause
-# this file to always be loaded, without a need to explicitly require it in any
-# files.
-#
-# Given that it is always loaded, you are encouraged to keep this file as
-# light-weight as possible. Requiring heavyweight dependencies from this file
-# will add to the boot time of your test suite on EVERY test run, even for an
-# individual file that may not need all of that loaded. Instead, consider making
-# a separate helper file that requires the additional dependencies and performs
-# the additional setup, and require it from the spec files that actually need
-# it.
-#
-# The `.rspec` file also contains a few flags that are not defaults but that
-# users commonly want.
-#
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
-RSpec.configure do |config|
-  # rspec-expectations config goes here. You can use an alternate
-  # assertion/expectation library such as wrong or the stdlib/minitest
-  # assertions if you prefer.
-  config.expect_with :rspec do |expectations|
-    # This option will default to `true` in RSpec 4. It makes the `description`
-    # and `failure_message` of custom matchers include text for helper methods
-    # defined using `chain`, e.g.:
-    #     be_bigger_than(2).and_smaller_than(4).description
-    #     # => "be bigger than 2 and smaller than 4"
-    # ...rather than:
-    #     # => "be bigger than 2"
-    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
-  end
-
-  # rspec-mocks config goes here. You can use an alternate test double
-  # library (such as bogus or mocha) by changing the `mock_with` option here.
-  config.mock_with :rspec do |mocks|
-    # Prevents you from mocking or stubbing a method that does not exist on
-    # a real object. This is generally recommended, and will default to
-    # `true` in RSpec 4.
-    mocks.verify_partial_doubles = true
-  end
-
-  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
-  # have no way to turn it off -- the option exists only for backwards
-  # compatibility in RSpec 3). It causes shared context metadata to be
-  # inherited by the metadata hash of host groups and examples, rather than
-  # triggering implicit auto-inclusion in groups with matching metadata.
-  config.shared_context_metadata_behavior = :apply_to_host_groups
-
-# The settings below are suggested to provide a good initial experience
-# with RSpec, but feel free to customize to your heart's content.
-=begin
-  # This allows you to limit a spec run to individual examples or groups
-  # you care about by tagging them with `:focus` metadata. When nothing
-  # is tagged with `:focus`, all examples get run. RSpec also provides
-  # aliases for `it`, `describe`, and `context` that include `:focus`
-  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
-  config.filter_run_when_matching :focus
-
-  # Allows RSpec to persist some state between runs in order to support
-  # the `--only-failures` and `--next-failure` CLI options. We recommend
-  # you configure your source control system to ignore this file.
-  config.example_status_persistence_file_path = "spec/examples.txt"
-
-  # Limits the available syntax to the non-monkey patched syntax that is
-  # recommended. For more details, see:
-  #   - http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
-  #   - http://www.teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
-  #   - http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#zero-monkey-patching-mode
-  config.disable_monkey_patching!
-
-  # This setting enables warnings. It's recommended, but in some cases may
-  # be too noisy due to issues in dependencies.
-  config.warnings = true
-
-  # Many RSpec users commonly either run the entire suite or an individual
-  # file, and it's useful to allow more verbose output when running an
-  # individual spec file.
-  if config.files_to_run.one?
-    # Use the documentation formatter for detailed output,
-    # unless a formatter has already been configured
-    # (e.g. via a command-line flag).
-    config.default_formatter = 'doc'
-  end
-
-  # Print the 10 slowest examples and example groups at the
-  # end of the spec run, to help surface which specs are running
-  # particularly slow.
-  config.profile_examples = 10
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  config.order = :random
-
-  # Seed global randomization in this process using the `--seed` CLI option.
-  # Setting this allows you to use `--seed` to deterministically reproduce
-  # test failures related to randomization by passing the same `--seed` value
-  # as the one that triggered the failure.
-  Kernel.srand config.seed
-=end
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef-umami
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Ryan Frantz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-28 00:00:00.000000000 Z
+date: 2017-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: chef
@@ -74,6 +74,7 @@ files:
 - lib/chef-umami/helpers/inspec.rb
 - lib/chef-umami/helpers/os.rb
 - lib/chef-umami/logger.rb
+- lib/chef-umami/options.rb
 - lib/chef-umami/policyfile.rb
 - lib/chef-umami/policyfile/exporter.rb
 - lib/chef-umami/policyfile/uploader.rb