chef-ruby-lvm 0.4.0 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c6e301ce4adb07645a893d2252dbf09afa4a48e0c499009fd05f6b2986af4a6
-  data.tar.gz: d583993d1b468e641e309cdb3588df42aa2180b7201d1d92f9f061baa28e9169
+  metadata.gz: ad3c076640b333f12d077631f973569347733b5260cbe1a48abb31a9b6985b9e
+  data.tar.gz: 0e7d3eff156cdf9586a0cd2142f995e07086484dea4b809c6d2f154c0967ad7b
 SHA512:
-  metadata.gz: 5143a086558cbc283dbb1a191bfd06550c9b4993e2430918537d6b4651101563526f9d0bbb89949a19f547df49d229e77aca8c47540b5fe764404dce247c5252
-  data.tar.gz: bc4dcb8a345d1de6dd4b86eac506118d418663ba75ebb1769199130e70fce32f821248b3d211ceeffbddabc78f51982fabff6d8e3e2e50a75ff6fc51cdd17bee
+  metadata.gz: 5c71a54a7f072489dc7d9618483dc819ebb04b058ac7697380b10270f6e0bcac7fc6a6382bf7a00dc5532122356ad977bcf99cca71adf96098676c78a426648a
+  data.tar.gz: d909f5d2d9c07d307c0c6fca2c07497145a27fc0ebd412b2489f82b0f4e1d95f421753e03af41cc20cd40219cc379c47bdbc96d16879ce69c983090d5a34a297

data/.github/CODEOWNERS

@@ -0,0 +1 @@
+@sous-chefs/maintainers

data/.github/ISSUE_TEMPLATE/BUG_TEMPLATE.md

@@ -0,0 +1,29 @@
+---
+name: � Bug Report
+about: If something isn't working as expected �.
+labels: "Status: Untriaged"
+---
+
+# Version:
+
+[Version of the project installed]
+
+# Environment:
+
+[Details about the environment such as the Operating System, cookbook details, etc...]
+
+# Scenario:
+
+[What you are trying to achieve and you can't?]
+
+# Steps to Reproduce:
+
+[If you are filing an issue what are the things we need to do in order to repro your problem?]
+
+# Expected Result:
+
+[What are you expecting to happen as the consequence of above reproduction steps?]
+
+# Actual Result:
+
+[What actually happens after the reproduction steps?]

data/.github/ISSUE_TEMPLATE/DESIGN_PROPOSAL.md

@@ -0,0 +1,40 @@
+---
+name: Design Proposal
+about: I have a significant change I would like to propose and discuss before starting
+labels: "Status: Untriaged"
+---
+
+### When a Change Needs a Design Proposal
+
+A design proposal should be opened any time a change meets one of the following qualifications:
+
+- Significantly changes the user experience of a project in a way that impacts users.
+- Significantly changes the underlying architecture of the project in a way that impacts other developers.
+- Changes the development or testing process of the project such as a change of CI systems or test frameworks.
+
+### Why We Use This Process
+
+- Allows all interested parties (including any community member) to discuss large impact changes to a project.
+- Serves as a durable paper trail for discussions regarding project architecture.
+- Forces design discussions to occur before PRs are created.
+- Reduces PR refactoring and rejected PRs.
+
+---
+
+<!---  Proposal description and rationale.  -->
+
+## Motivation
+
+<!---
+    As a <<user_profile>>,
+    I want to <<functionality>>,
+    so that <<benefit>>.
+ -->
+
+## Specification
+
+<!---  A detailed description of the planned implementation. -->
+
+## Downstream Impact
+
+<!---  Which other tools will be impacted by this work?  -->

data/.github/ISSUE_TEMPLATE/ENHANCEMENT_REQUEST_TEMPLATE.md

@@ -0,0 +1,17 @@
+---
+name: 🚀 Enhancement Request
+about: I have a suggestion (and may want to implement it 🙂)!
+labels: "Status: Untriaged"
+---
+
+### Describe the Enhancement:
+<!---  What you are trying to achieve that you can't? -->
+
+### Describe the Need:
+<!---  What kind of user do you believe would utilize this enhancement, and how many users might want this functionality -->
+
+### Current Alternative
+<!--- Is there a current alternative that you can utilize to workaround the lack of this enhancement -->
+
+### Can We Help You Implement This?:
+<!---  The best way to ensure your enhancement is built is to help implement the enhancement yourself. If you're interested in helping out we'd love to give you a hand to make this possible. Let us know if there's something you need. -->

data/.github/ISSUE_TEMPLATE/SUPPORT_QUESTION.md

@@ -0,0 +1,12 @@
+---
+name: 🤗 Support Question
+about: If you have a question 💬, please check out our Slack!
+---
+
+We use GitHub issues to track bugs and feature requests. If you need help please post to our Mailing List or join the Chef Community Slack.
+
+ * Chef Community Slack at http://community-slack.chef.io/.
+ * Chef Mailing List https://discourse.chef.io/
+
+
+ Support issues opened here will be closed and redirected to Slack or Discourse.

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,15 @@
+### Description
+
+[Please describe what this change achieves]
+
+### Issues Resolved
+
+[List any existing issues this PR resolves, or any Discourse or
+StackOverflow discussions that are relevant]
+
+### Check List
+
+- [ ] New functionality includes tests
+- [ ] All tests pass
+- [ ] All commits have been signed-off for the Developer Certificate of Origin. See <https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco>
+- [ ] PR title is a worthy inclusion in the CHANGELOG

data/.github/dependabot.yml

@@ -0,0 +1,9 @@
+version: 2
+updates:
+- package-ecosystem: bundler
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "06:00"
+    timezone: America/Los_Angeles
+  open-pull-requests-limit: 10

data/CHANGELOG.md

@@ -1,38 +1,50 @@
-# 0.4.0 (2018-07-23)
+# Change log
+
+## 0.4.3
+
+- Update open4 requirement
+
+## 0.4.2
+
+- Fix undefined variable error in `LVM::External::Module`
+
+## 0.4.1 (2022-04-25)
+
+- Use new minor version of chef-ruby-lvm-attrib
+- Chefstyle fixes
+- Optimize requires with require_relative & use __dir__ not __FILE__
+
+## 0.4.0 (2018-07-23)
 
 - Added additional_arguments option that allows passing options to commands
 
-# 0.3.0 (2016-06-21)
+## 0.3.0 (2017-06-21)
 
 - Depend on di-ruby-lvm-attrib ~0.2 to bring in the last few years of releases
 
-# 0.2.2 (2016-12-12)
+## 0.2.2 (2016-12-13)
 
 - Fork di-ruby-lvm as chef-ruby-lvm in order to unblock the Chef lvm cookbook support for the latest Linux distros
 - Convert the readme to markdown and reword portions
 - Resolve all chefstyle warnings
 - Added a Gemfile/Rakefile for chefstyle linting
 
-# 0.2.1 (2015-12-04)
+## 0.2.1 (2015-12-04)
 
 - Fix failures calling the calling physical_volumes list method
 
-# 0.2.0 (2015-12-01)
+## 0.2.0 (2015-12-01)
 
 - Minor code refactoring
 - Improve runtime with multiple VGs
 - Use just a gemspec instead of hoe
 - Require a newer di-ruby-lvm-attrib gem
 
-....
-
-# 0.1.1 (2008-07-21)
-
-- 1 major enhancement
+## 0.1.1 (2008-07-21)
 
-  - A complete rewrite! We won't bother attempting to wrap complex lvm operations, but instead provide LVM.raw() command. The wrapper now focuses purely on translating lvm lv/vg/pv data into the most useful ruby objects possible. The arguments passed to the underlying binaries have been broken out into a ruby-lvm-attributes package.
+- A complete rewrite! We won't bother attempting to wrap complex lvm operations, but instead provide LVM.raw() command. The wrapper now focuses purely on translating lvm lv/vg/pv data into the most useful ruby objects possible. The arguments passed to the underlying binaries have been broken out into a ruby-lvm-attributes package.
 
-# 0.0.1 (2008-05-28)
+## 0.0.1 (2008-05-28)
 
 - 1 major enhancement
 

data/CODE_OF_CONDUCT.md

@@ -0,0 +1 @@
+Please refer to the Chef Community Code of Conduct at https://www.chef.io/code-of-conduct/

data/CONTRIBUTING.md

@@ -0,0 +1,3 @@
+# Contributing
+
+Please refer to <https://github.com/chef/chef/blob/main/CONTRIBUTING.md>

data/Gemfile

@@ -4,4 +4,5 @@ gemspec
 
 group :development do
   gem "chefstyle"
+  gem "rake"
 end

data/README.md

@@ -1,8 +1,10 @@
 # chef-ruby-lvm
 
-This is a fork of the chef-ruby-lvm gem found at <https://github.com/gregsymons/chef-ruby-lvm>. The primary difference from upstream is that it depends on chef-ruby-lvm-attrib instead of chef-ruby-lvm-attrib. This adds support for lvm version 2.02.66(2) and later.
+[![Gem Version](https://badge.fury.io/rb/chef-ruby-lvm.svg)](https://badge.fury.io/rb/chef-ruby-lvm)
 
-This is a wrapper for the LVM2 administration utility, lvm. Its primary function it to convert physical volumes, logical volumes and volume groups into easy to use ruby objects. It also provides a simple wrapper for typical create/delete/etc operations.
+This is a fork of the chef-ruby-lvm gem found at <https://github.com/gregsymons/di-ruby-lvm>. The primary difference from upstream is that it depends on chef-ruby-lvm-attrib instead of di-ruby-lvm-attrib. It was in turn forked from ruby-lvm. This adds support for lvm version 2.02.66(2) and later.
+
+This is a wrapper for the LVM2 administration utility, lvm. Its primary function is to convert physical volumes, logical volumes and volume groups into easy-to-use ruby objects. It also provides a simple wrapper for typical create/delete/etc operations.
 
 Due to a lack of LVM2 api this is a best effort attempt at ruby integration but subject to complete replacement in the future.
 

data/Rakefile

@@ -1,6 +1,6 @@
 require "bundler/gem_tasks"
 
-task :default => :style
+task default: :style
 
 require "chefstyle"
 require "rubocop/rake_task"

data/chef-ruby-lvm.gemspec

@@ -1,11 +1,6 @@
-$:.unshift(File.expand_path("../lib/", __FILE__))
+$:.unshift(File.expand_path("lib", __dir__))
 require "lvm/version"
 
-deps = {
-  "open4" => ["~> 0.9", ">= 0.9.6"],
-  "chef-ruby-lvm-attrib" => ["~> 0.2"],
-}
-
 Gem::Specification.new do |gem|
   gem.authors       = ["Tim Smith", "Greg Symons", "Matthew Kent"]
   gem.email         = ["tsmith@chef.io", "mkent@magoazul.com", "gsymons@gsconsulting.biz"]
@@ -19,7 +14,6 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = LVM::VERSION
 
-  deps.each do |dep, constraints|
-    gem.add_runtime_dependency dep, *constraints
-  end
+  gem.add_runtime_dependency "chef-ruby-lvm-attrib", "~> 0.3"
+  gem.add_runtime_dependency "open4", ">= 0.9.6", "< 2.0"
 end

data/examples/additional_arguments.rb

@@ -2,12 +2,12 @@
 
 # Demonstration of passing additional arguments to the LVM object
 
-$: << File.dirname(__FILE__) + "/../lib"
+$: << __dir__ + "/../lib"
 
 require "lvm"
 
 # List out volume groups with the --ignoreskippedcluster argument appended to the base argument list
-lvm = LVM::LVM.new(:command => "/usr/bin/sudo /sbin/lvm", :additional_arguments => "--ignoreskippedcluster")
+lvm = LVM::LVM.new(command: "/usr/bin/sudo /sbin/lvm", additional_arguments: "--ignoreskippedcluster")
 
 volume_groups = lvm.volume_groups
-puts volume_groups.map { |vg| vg.name }
+puts volume_groups.map(&:name)

data/examples/create_snapshot.rb

@@ -3,14 +3,14 @@
 # Demonstration of the creation of an lvm snapshot, using sudo, and reading its
 # attributes.
 
-$: << File.dirname(__FILE__) + "/../lib"
+$: << __dir__ + "/../lib"
 
 require "lvm"
 
 vol = "sys.vg/tmp.lv"
 snap = "demo_snap"
 
-lvm = LVM::LVM.new(:command => "/usr/bin/sudo /sbin/lvm")
+lvm = LVM::LVM.new(command: "/usr/bin/sudo /sbin/lvm")
 
 if lvm.logical_volumes[snap]
   puts "#{snap} exists! Remove it"
@@ -20,9 +20,9 @@ end
 lvm.raw("lvcreate --snapshot --size 10M --name #{snap} #{vol}")
 lv = lvm.logical_volumes[snap]
 
-out = <<msg
+out = <<MSG
 snapshot of #{vol}, #{snap}, created
 - uuid: #{lv.uuid}
 - major,minor: #{lv.kernel_major},#{lv.kernel_minor}
-msg
+MSG
 puts out

data/examples/error_handling.rb

@@ -2,11 +2,11 @@
 
 # Demonstration of the exception handling with raw commands.
 
-$: << File.dirname(__FILE__) + "/../lib"
+$: << __dir__ + "/../lib"
 
 require "lvm"
 
-lvm = LVM::LVM.new(:command => "/usr/bin/sudo /sbin/lvm")
+lvm = LVM::LVM.new(command: "/usr/bin/sudo /sbin/lvm")
 
 begin
   lvm.raw("--blah blah")

data/examples/show_lvm_config.rb

@@ -3,11 +3,11 @@
 # A more advanced demonstration displaying a complete overview of the current
 # lvm configuration.
 
-$: << File.dirname(__FILE__) + "/../lib"
+$: << __dir__ + "/../lib"
 
 require "lvm"
 
-LVM::LVM.new({ :command => "/usr/bin/sudo /sbin/lvm" }) do |lvm|
+LVM::LVM.new({ command: "/usr/bin/sudo /sbin/lvm" }) do |lvm|
   puts "lvm version: #{lvm.version}\n"
 
   puts "\nlogical view"

data/lib/lvm/external.rb

@@ -1,4 +1,4 @@
-require "rubygems"
+require "rubygems" unless defined?(Gem)
 require "open4"
 
 module LVM
@@ -9,7 +9,7 @@ module LVM
       output = []
       error = nil
       stat = Open4.popen4(cmd) do |pid, stdin, stdout, stderr|
-        while line = stdout.gets
+        while (line = stdout.gets)
           output << line
         end
         error = stderr.read.strip
@@ -25,9 +25,9 @@ module LVM
       end
 
       if block_given?
-        return output.each { |l| yield l }
+        output.each { |l| yield l }
       else
-        return output.join
+        output.join
       end
     end
     module_function :cmd

data/lib/lvm/logical_volume.rb

@@ -1,4 +1,4 @@
-require "ostruct"
+require "ostruct" unless defined?(OpenStruct)
 
 module LVM
   class LogicalVolume < OpenStruct

data/lib/lvm/logical_volume_segment.rb

@@ -1,4 +1,4 @@
-require "ostruct"
+require "ostruct" unless defined?(OpenStruct)
 
 module LVM
   class LogicalVolumeSegment < OpenStruct; end

data/lib/lvm/logical_volumes.rb

@@ -1,6 +1,6 @@
-require "lvm/volumes"
-require "lvm/wrapper/lvs"
-require "lvm/wrapper/lvsseg"
+require_relative "volumes"
+require_relative "wrapper/lvs"
+require_relative "wrapper/lvsseg"
 
 module LVM
   class LogicalVolumes
@@ -28,7 +28,7 @@ module LVM
     end
 
     def list
-      self.each {}
+      each {}
     end
   end
 end

data/lib/lvm/physical_volume.rb

@@ -1,4 +1,4 @@
-require "ostruct"
+require "ostruct" unless defined?(OpenStruct)
 
 module LVM
   class PhysicalVolume < OpenStruct; end

data/lib/lvm/physical_volume_segment.rb

@@ -1,4 +1,4 @@
-require "ostruct"
+require "ostruct" unless defined?(OpenStruct)
 
 module LVM
   class PhysicalVolumeSegment < OpenStruct; end

data/lib/lvm/physical_volumes.rb

@@ -1,6 +1,6 @@
-require "lvm/volumes"
-require "lvm/wrapper/pvs"
-require "lvm/wrapper/pvsseg"
+require_relative "volumes"
+require_relative "wrapper/pvs"
+require_relative "wrapper/pvsseg"
 
 module LVM
   class PhysicalVolumes
@@ -28,7 +28,7 @@ module LVM
     end
 
     def list
-      self.each {}
+      each {}
     end
   end
 end

data/lib/lvm/userland.rb

@@ -1,4 +1,4 @@
-require "ostruct"
+require "ostruct" unless defined?(OpenStruct)
 
 module LVM
   class UserLand < OpenStruct; end

data/lib/lvm/version.rb

@@ -1,3 +1,3 @@
 module LVM
-  VERSION = "0.4.0"
+  VERSION = "0.4.3".freeze
 end

data/lib/lvm/volume_group.rb

@@ -1,4 +1,4 @@
-require "ostruct"
+require "ostruct" unless defined?(OpenStruct)
 
 module LVM
   class VolumeGroup < OpenStruct; end

data/lib/lvm/volume_groups.rb

@@ -1,7 +1,7 @@
-require "lvm/volumes"
-require "lvm/logical_volumes"
-require "lvm/physical_volumes"
-require "lvm/wrapper/vgs"
+require_relative "volumes"
+require_relative "logical_volumes"
+require_relative "physical_volumes"
+require_relative "wrapper/vgs"
 
 module LVM
   class VolumeGroups
@@ -33,7 +33,7 @@ module LVM
     end
 
     def list
-      self.each {}
+      each {}
     end
   end
 end

data/lib/lvm/volumes.rb

@@ -2,13 +2,13 @@ module LVM
   module Volumes
     def [](name)
       each { |o| return o if o.name == name }
-      return nil
+      nil
     end
 
     def to_s
       x = []
       each { |o| x << o.name }
-      return x.join(" ")
+      x.join(" ")
     end
   end
 end

data/lib/lvm/wrapper/constants.rb

@@ -2,9 +2,9 @@ module LVM
   module Wrapper
     module Reporting
       module Constants
-        SEPERATOR = "^"
-        BASE_ARGUMENTS = "--verbose --separator=#{SEPERATOR} --noheadings --nosuffix --units=b --unbuffered --options %s"
-        EMPTY = "-"
+        SEPERATOR = "^".freeze
+        BASE_ARGUMENTS = "--verbose --separator=#{SEPERATOR} --noheadings --nosuffix --units=b --unbuffered --options %s".freeze
+        EMPTY = "-".freeze
       end
     end
   end

data/lib/lvm/wrapper/lvs.rb

@@ -1,5 +1,5 @@
-require "lvm/wrapper"
-require "lvm/logical_volume"
+require_relative "../wrapper"
+require_relative "../logical_volume"
 
 module LVM
   module Wrapper
@@ -14,8 +14,8 @@ module LVM
         @command = "#{options[:command]} #{Reporting.build_command(attributes, BASE_COMMAND, options[:additional_arguments])}"
       end
 
-      BASE_COMMAND = "lvs #{Reporting::BASE_ARGUMENTS}"
-      ATTRIBUTES_FILE = "lvs.yaml"
+      BASE_COMMAND = "lvs #{Reporting::BASE_ARGUMENTS}".freeze
+      ATTRIBUTES_FILE = "lvs.yaml".freeze
 
       # lv_attr attribute handling constants
       # roughly by order referenced in lib/report/report.c:292 (_lvstatus_disp)
@@ -34,13 +34,13 @@ module LVM
         "S" => :invalid_snapshot,
         # custom, empty is a standard volume
         "-" => :normal,
-      }
+      }.freeze
       PERMISSIONS = {
         "w" => :writeable,
         "r" => :readonly,
         # custom, from reading source
         "-" => :locked_by_pvmove,
-      }
+      }.freeze
       ALLOCATION_POLICY = {
         "c" => :contiguous,
         "l" => :cling,
@@ -52,11 +52,11 @@ module LVM
         "N" => :normal_locked,
         "A" => :anywhere_locked,
         "I" => :inherited_locked,
-      }
+      }.freeze
       FIXED_MINOR = {
         # code says its a boolean
         "m" => true,
-      }
+      }.freeze
       STATE = {
         "s" => :suspended,
         "a" => :active,
@@ -64,25 +64,25 @@ module LVM
         "d" => :inactive_without_table,
         "S" => :suspended_snapshot,
         "I" => :invalid_snapshot,
-      }
+      }.freeze
       DEVICE_OPEN = {
         # code says its a boolean
         "o" => true,
-      }
+      }.freeze
 
       def list
         output = External.cmd(@command)
         data = parse(output)
         if block_given?
-          return data.each { |obj| yield obj }
+          data.each { |obj| yield obj }
         else
-          return data
+          data
         end
       end
 
       private
 
-      def parse_lv_attr(lv_attr) #:nodoc:
+      def parse_lv_attr(lv_attr) # :nodoc:
         translated = {}
         # translate them into nice symbols and a couple booleans
         translated[:volume_type] = VOLUME_TYPE[lv_attr[0].chr]
@@ -92,11 +92,11 @@ module LVM
         translated[:state] = STATE[lv_attr[4].chr]
         translated[:device_open] = DEVICE_OPEN[lv_attr[5].chr] ? true : false
 
-        return translated
+        translated
       end
 
-        # Parses the output of self.command
-      def parse(output) #:nodoc:
+      # Parses the output of self.command
+      def parse(output) # :nodoc:
         volumes = []
 
         output.split("\n").each do |line|
@@ -119,7 +119,7 @@ module LVM
           end
         end
 
-        return volumes
+        volumes
       end # parse
     end # class LVS
   end # module Wrapper

data/lib/lvm/wrapper/lvsseg.rb

@@ -1,5 +1,5 @@
-require "lvm/wrapper"
-require "lvm/logical_volume_segment"
+require_relative "../wrapper"
+require_relative "../logical_volume_segment"
 
 module LVM
   module Wrapper
@@ -15,22 +15,22 @@ module LVM
         @command = "#{options[:command]} #{Reporting.build_command(attributes, BASE_COMMAND, options[:additional_arguments])}"
       end
 
-      BASE_COMMAND = "lvs #{Reporting::BASE_ARGUMENTS}"
-      ATTRIBUTES_FILE = "lvsseg.yaml"
+      BASE_COMMAND = "lvs #{Reporting::BASE_ARGUMENTS}".freeze
+      ATTRIBUTES_FILE = "lvsseg.yaml".freeze
 
       def list
         output = External.cmd(@command)
         data = parse(output)
         if block_given?
-          return data.each { |obj| yield obj }
+          data.each { |obj| yield obj }
         else
-          return data
+          data
         end
       end
 
       private
 
-        # Parses the output of self.command
+      # Parses the output of self.command
       def parse(output)
         volumes = []
 
@@ -49,7 +49,7 @@ module LVM
           end
         end
 
-        return volumes
+        volumes
       end # parse
     end # class LVSSEG
   end # module Wrapper

data/lib/lvm/wrapper/pvs.rb

@@ -1,5 +1,5 @@
-require "lvm/wrapper"
-require "lvm/physical_volume"
+require_relative "../wrapper"
+require_relative "../physical_volume"
 
 module LVM
   module Wrapper
@@ -14,8 +14,8 @@ module LVM
         @command = "#{options[:command]} #{Reporting.build_command(attributes, BASE_COMMAND, options[:additional_arguments])}"
       end
 
-      BASE_COMMAND = "pvs #{Reporting::BASE_ARGUMENTS}"
-      ATTRIBUTES_FILE = "pvs.yaml"
+      BASE_COMMAND = "pvs #{Reporting::BASE_ARGUMENTS}".freeze
+      ATTRIBUTES_FILE = "pvs.yaml".freeze
 
       # pv_attr attribute handling constants
       # roughly by order referenced in lib/report/report.c:360 (_pvstatus_disp)
@@ -23,34 +23,34 @@ module LVM
       ALLOCATABLE = {
         # code says its a boolean
         "a" => true,
-      }
+      }.freeze
       EXPORTED = {
         # code says its a boolean
         "x" => true,
-      }
+      }.freeze
 
       def list
         output = External.cmd(@command)
         data = parse(output)
         if block_given?
-          return data.each { |obj| yield obj }
+          data.each { |obj| yield obj }
         else
-          return data
+          data
         end
       end
 
       private
 
-      def parse_pv_attr(pv_attr) #:nodoc:
+      def parse_pv_attr(pv_attr) # :nodoc:
         translated = {}
-          # translate them into nice symbols and a couple booleans
+        # translate them into nice symbols and a couple booleans
         translated[:allocatable] = ALLOCATABLE[pv_attr[0].chr] ? true : false
         translated[:exported] = EXPORTED[pv_attr[1].chr] ? true : false
 
-        return translated
+        translated
       end
 
-        # Parses the output of self.command
+      # Parses the output of self.command
       def parse(output)
         volumes = []
 
@@ -74,7 +74,7 @@ module LVM
           end
         end
 
-        return volumes
+        volumes
       end # parse
     end # class PVS
   end # module Wrapper

data/lib/lvm/wrapper/pvsseg.rb

@@ -1,5 +1,5 @@
-require "lvm/wrapper"
-require "lvm/physical_volume_segment"
+require_relative "../wrapper"
+require_relative "../physical_volume_segment"
 
 module LVM
   module Wrapper
@@ -15,22 +15,22 @@ module LVM
         @command = "#{options[:command]} #{Reporting.build_command(attributes, BASE_COMMAND, options[:additional_arguments])}"
       end
 
-      BASE_COMMAND = "pvs #{Reporting::BASE_ARGUMENTS}"
-      ATTRIBUTES_FILE = "pvsseg.yaml"
+      BASE_COMMAND = "pvs #{Reporting::BASE_ARGUMENTS}".freeze
+      ATTRIBUTES_FILE = "pvsseg.yaml".freeze
 
       def list
         output = External.cmd(@command)
         data = parse(output)
         if block_given?
-          return data.each { |obj| yield obj }
+          data.each { |obj| yield obj }
         else
-          return data
+          data
         end
       end
 
       private
 
-        # Parses the output of self.command
+      # Parses the output of self.command
       def parse(output)
         volumes = []
 
@@ -49,7 +49,7 @@ module LVM
           end
         end
 
-        return volumes
+        volumes
       end # parse
     end # class PVSSEG
   end # module Wrapper

data/lib/lvm/wrapper/vgs.rb

@@ -1,5 +1,5 @@
-require "lvm/wrapper"
-require "lvm/volume_group"
+require_relative "../wrapper"
+require_relative "../volume_group"
 
 module LVM
   module Wrapper
@@ -14,8 +14,8 @@ module LVM
         @command = "#{options[:command]} #{Reporting.build_command(attributes, BASE_COMMAND, options[:additional_arguments])}"
       end
 
-      BASE_COMMAND = "vgs #{Reporting::BASE_ARGUMENTS}"
-      ATTRIBUTES_FILE = "vgs.yaml"
+      BASE_COMMAND = "vgs #{Reporting::BASE_ARGUMENTS}".freeze
+      ATTRIBUTES_FILE = "vgs.yaml".freeze
 
       # vg_attr attribute handling constants
       # roughly by order referenced in lib/report/report.c:360 (_vgstatus_disp)
@@ -23,19 +23,19 @@ module LVM
       PERMISSIONS = {
         "w" => :writeable,
         "r" => :readonly,
-      }
+      }.freeze
       RESIZEABLE = {
         # code says its a boolean
         "z" => true,
-      }
+      }.freeze
       EXPORTED = {
         # code says its a boolean
         "x" => true,
-      }
+      }.freeze
       PARTIAL = {
         # code says its a boolean
         "p" => true,
-      }
+      }.freeze
       ALLOCATION_POLICY = {
         "c" => :contiguous,
         "l" => :cling,
@@ -47,25 +47,25 @@ module LVM
         "N" => :normal_locked,
         "A" => :anywhere_locked,
         "I" => :inherited_locked,
-      }
+      }.freeze
       CLUSTERED = {
         # code says its a boolean
         "c" => true,
-      }
+      }.freeze
 
       def list
         output = External.cmd(@command)
         data = parse(output)
         if block_given?
-          return data.each { |obj| yield obj }
+          data.each { |obj| yield obj }
         else
-          return data
+          data
         end
       end
 
       private
 
-      def parse_vg_attr(vg_attr) #:nodoc:
+      def parse_vg_attr(vg_attr) # :nodoc:
         translated = {}
         # translate them into nice symbols and a couple booleans
         translated[:permissions] = PERMISSIONS[vg_attr[0].chr]
@@ -75,11 +75,11 @@ module LVM
         translated[:allocation_policy] = ALLOCATION_POLICY[vg_attr[4].chr]
         translated[:clustered] = CLUSTERED[vg_attr[5].chr] ? true : false
 
-        return translated
+        translated
       end
 
-        # Parses the output of self.command
-      def parse(output) #:nodoc:
+      # Parses the output of self.command
+      def parse(output) # :nodoc:
         volumes = []
 
         output.split("\n").each do |line|
@@ -102,7 +102,7 @@ module LVM
           end
         end
 
-        return volumes
+        volumes
       end # parse
     end # class VGS
   end # module Wrapper

data/lib/lvm/wrapper.rb

@@ -1,6 +1,6 @@
 require "lvm/attributes"
-require "lvm/external"
-require "lvm/wrapper/constants"
+require_relative "external"
+require_relative "wrapper/constants"
 
 module LVM
   module Wrapper
@@ -9,7 +9,7 @@ module LVM
 
       # Breakdown return values into attribute => value hash suitable for
       # OpenStruct
-      def process_line(expected_attributes, line) #:nodoc:
+      def process_line(expected_attributes, line) # :nodoc:
         line.strip!
         values = line.split(SEPERATOR)
         # nil is easier
@@ -26,6 +26,7 @@ module LVM
           # use hints for type conversion
           case attribute[:type_hint]
           when "String"
+            value = value.to_s
           when "Integer"
             value = value.to_i
           when "Float"
@@ -34,7 +35,7 @@ module LVM
           attributes[name] = value
         end
 
-        return attributes
+        attributes
       end
       module_function :process_line
 
@@ -47,7 +48,7 @@ module LVM
         additional_arguments = [] if additional_arguments.nil?
         additional_arguments = [additional_arguments] if additional_arguments.is_a?(String)
 
-        return base % opts.join(",") + "#{additional_arguments.empty? ? '' : ' '}#{additional_arguments.join(' ')}"
+        base % opts.join(",") + "#{additional_arguments.empty? ? "" : " "}#{additional_arguments.join(" ")}"
       end
       module_function :build_command
     end # module Reporting

data/lib/lvm.rb

@@ -1,9 +1,9 @@
-require "lvm/external"
-require "lvm/userland"
-require "lvm/logical_volumes"
-require "lvm/volume_groups"
-require "lvm/physical_volumes"
-require "lvm/version"
+require_relative "lvm/external"
+require_relative "lvm/userland"
+require_relative "lvm/logical_volumes"
+require_relative "lvm/volume_groups"
+require_relative "lvm/physical_volumes"
+require_relative "lvm/version"
 
 module LVM
   class LVM
@@ -13,20 +13,20 @@ module LVM
     attr_reader :physical_volumes
     attr_reader :additional_arguments
 
-    VALID_OPTIONS = [
-      :command,
-      :version,
-      :debug,
-      :additional_arguments,
-    ]
+    VALID_OPTIONS = %i{
+      command
+      version
+      debug
+      additional_arguments
+    }.freeze
 
-    DEFAULT_COMMAND = "/sbin/lvm"
+    DEFAULT_COMMAND = "/sbin/lvm".freeze
 
     def initialize(options = {})
       # handy, thanks net-ssh!
       invalid_options = options.keys - VALID_OPTIONS
       if invalid_options.any?
-        raise ArgumentError, "invalid option(s): #{invalid_options.join(', ')}"
+        raise ArgumentError, "invalid option(s): #{invalid_options.join(", ")}"
       end
 
       @command = options[:command] || DEFAULT_COMMAND
@@ -42,7 +42,7 @@ module LVM
       if block_given?
         yield self
       else
-        return self
+        self
       end
     end
 
@@ -52,14 +52,14 @@ module LVM
         output << line
       end
       if block_given?
-        return output.each { |l| yield l }
+        output.each { |l| yield l }
       else
-        return output.join
+        output.join
       end
     end
 
     def version
-      %r{^(.*?)(-| )}.match(userland.lvm_version)[1]
+      /^(.*?)(-| )/.match(userland.lvm_version)[1]
     end
 
     # helper methods
@@ -67,16 +67,16 @@ module LVM
       userland = UserLand.new
       raw("version") do |line|
         case line
-        when %r{^\s+LVM version:\s+([0-9].*)$}
+        when /^\s+LVM version:\s+([0-9].*)$/
           userland.lvm_version = $1
-        when %r{^\s+Library version:\s+([0-9].*)$}
+        when /^\s+Library version:\s+([0-9].*)$/
           userland.library_version = $1
-        when %r{^\s+Driver version:\s+([0-9].*)$}
+        when /^\s+Driver version:\s+([0-9].*)$/
           userland.driver_version = $1
         end
       end
 
-      return userland
+      userland
     end
   end
 end

metadata

@@ -1,51 +1,51 @@
 --- !ruby/object:Gem::Specification
 name: chef-ruby-lvm
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.3
 platform: ruby
 authors:
 - Tim Smith
 - Greg Symons
 - Matthew Kent
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-07-24 00:00:00.000000000 Z
+date: 2022-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: open4
+  name: chef-ruby-lvm-attrib
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.6
+        version: '0.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.9.6
+        version: '0.3'
 - !ruby/object:Gem::Dependency
-  name: chef-ruby-lvm-attrib
+  name: open4
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.9.6
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.9.6
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '2.0'
 description: A wrapper for the LVM2 administration utility, lvm.
 email:
 - tsmith@chef.io
@@ -55,8 +55,17 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/CODEOWNERS"
+- ".github/ISSUE_TEMPLATE/BUG_TEMPLATE.md"
+- ".github/ISSUE_TEMPLATE/DESIGN_PROPOSAL.md"
+- ".github/ISSUE_TEMPLATE/ENHANCEMENT_REQUEST_TEMPLATE.md"
+- ".github/ISSUE_TEMPLATE/SUPPORT_QUESTION.md"
+- ".github/PULL_REQUEST_TEMPLATE.md"
+- ".github/dependabot.yml"
 - ".gitignore"
 - CHANGELOG.md
+- CODE_OF_CONDUCT.md
+- CONTRIBUTING.md
 - Gemfile
 - README.md
 - Rakefile
@@ -90,7 +99,7 @@ homepage: https://github.com/chef/chef-ruby-lvm
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -105,9 +114,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.5
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: A wrapper for the LVM2 administration utility, lvm.
 test_files: