chef-provisioning-vsphere 2.2.2 → 2.3.0

data/lib/chef/provisioning/vsphere_driver/version.rb

@@ -3,5 +3,5 @@
 # Provisions machines in vSphere.
 module ChefProvisioningVsphere
   # The version of this awesome Gem. BOOM.
-  VERSION = '2.2.2'.freeze
+  VERSION = "2.3.0".freeze
 end

data/lib/chef/provisioning/vsphere_driver/vm_helper.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'chef/provisioning/driver'
+require "chef/provisioning/driver"
 
 # Provisions machines in vSphere.
 module ChefProvisioningVsphere
@@ -31,16 +31,16 @@ module ChefProvisioningVsphere
     def find_port?(vm, options)
       @port = options[:ssh][:port]
       customization_spec = options[:customization_spec]
-      if vm.config.guestId.start_with?('win')
+      if vm.config.guestId.start_with?("win")
         if customization_spec.is_a?(Hash)
           winrm_transport =
             customization_spec[:winrm_transport].nil? ? :negotiate : customization_spec[:winrm_transport].to_sym
         end
         winrm_transport ||= :negotiate
-        default_win_port = winrm_transport == :ssl ? '5986' : '5985'
+        default_win_port = winrm_transport == :ssl ? "5986" : "5985"
         @port = default_win_port if @port.nil?
       elsif port.nil?
-        @port = '22'
+        @port = "22"
       end
       true
     end

data/lib/chef/provisioning/vsphere_driver/vsphere_helpers.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-require 'rbvmomi'
-require 'uri'
-require 'net/http'
+require "rbvmomi"
+require "uri"
+require "net/http"
 
 # Provisions machines in vSphere.
 module ChefProvisioningVsphere
@@ -58,7 +58,7 @@ module ChefProvisioningVsphere
     #
     # @param [String] uuid the UUID of the machine
     def find_vm_by_id(uuid)
-      vm = vim.searchIndex.FindByUuid(
+      vm = vim.searchIndex.FindByUuid( # rubocop:disable Naming/VariableName, Lint/UselessAssignment
         uuid: uuid,
         vmSearch: true,
         instanceUuid: true
@@ -71,7 +71,7 @@ module ChefProvisioningVsphere
     # @param [Object] _wait_on_port Defaults to port 22, to connect and verify it's up.
     def start_vm(vm, _wait_on_port = 22)
       state = vm.runtime.powerState
-      vm.PowerOnVM_Task.wait_for_completion unless state == 'poweredOn'
+      vm.PowerOnVM_Task.wait_for_completion unless state == "poweredOn"
     end
 
     # Stops the VM
@@ -80,12 +80,12 @@ module ChefProvisioningVsphere
     # @param [Object] timeout Defaults to 600 seconds or 10 mins before giving up.
     def stop_vm(vm, timeout = 600)
       start = Time.now.utc
-      return if vm.runtime.powerState == 'poweredOff'
+      return if vm.runtime.powerState == "poweredOff"
       begin
         vm.ShutdownGuest
         until (Time.now.utc - start) > timeout ||
-              vm.runtime.powerState == 'poweredOff'
-          print '.'
+            vm.runtime.powerState == "poweredOff"
+          print "."
           sleep 2
         end
       rescue
@@ -100,9 +100,9 @@ module ChefProvisioningVsphere
     def find_folder(folder_name)
       base = datacenter.vmFolder
       unless folder_name.nil?
-        folder_name.split('/').reject(&:empty?).each do |item|
+        folder_name.split("/").reject(&:empty?).each do |item|
           base = base.find(item, RbVmomi::VIM::Folder) ||
-                 raise("vSphere Folder not found [#{folder_name}]")
+            raise("vSphere Folder not found [#{folder_name}]")
         end
       end
       base
@@ -132,8 +132,8 @@ module ChefProvisioningVsphere
     def datacenter
       vim # ensure connection is valid
       @datacenter ||= begin
-        rootFolder = vim.serviceInstance.content.rootFolder
-        dc = traverse_folders_for_dc(vim.rootFolder, datacenter_name) || abort("vSphere Datacenter not found [#{datacenter_name}]")
+        rootFolder = vim.serviceInstance.content.rootFolder # rubocop:disable Naming/VariableName, Lint/UselessAssignment
+        dc = traverse_folders_for_dc(vim.rootFolder, datacenter_name) || abort("vSphere Datacenter not found [#{datacenter_name}]") # rubocop:disable Naming/VariableName, Lint/UselessAssignment
       end
     end
 
@@ -152,7 +152,7 @@ module ChefProvisioningVsphere
       )
       device = RbVmomi::VIM::VirtualVmxnet3(
         backing: backing_info,
-        deviceInfo: RbVmomi::VIM::Description(label: network_label, summary: network_name.split('/').last),
+        deviceInfo: RbVmomi::VIM::Description(label: network_label, summary: network_name.split("/").last),
         key: device_key,
         connectable: connectable
       )
@@ -176,14 +176,14 @@ module ChefProvisioningVsphere
     # @param [Object] options the options from Chef Provisioning to help configure the VM.
     # @param [Object] vm the actual VM object to connect the VM to.
     def add_extra_nic(action_handler, vm_template, options, vm)
-      deviceAdditions, changes = network_device_changes(action_handler, vm_template, options)
+      deviceAdditions, changes = network_device_changes(action_handler, vm_template, options) # rubocop:disable Naming/VariableName, Lint/UselessAssignment
 
-      if deviceAdditions.count.positive?
+      if deviceAdditions.count > 0
         current_networks = find_ethernet_cards_for(vm).map { |card| network_id_for(card.backing) }
         new_devices = deviceAdditions.reject { |device| current_networks.include?(network_id_for(device.device.backing)) }
 
-        if new_devices.count.positive?
-          action_handler.report_progress 'Adding extra NICs'
+        if new_devices.count > 0
+          action_handler.report_progress "Adding extra NICs"
           task = vm.ReconfigVM_Task(spec: RbVmomi::VIM.VirtualMachineConfigSpec(deviceChange: new_devices))
           task.wait_for_completion
           new_devices
@@ -212,7 +212,7 @@ module ChefProvisioningVsphere
           deviceChange: [
             {
               operation: :remove,
-              device: disk
+              device: disk,
             },
             {
               operation: :add,
@@ -221,9 +221,9 @@ module ChefProvisioningVsphere
                 new_disk.backing = new_disk.backing.dup
                 new_disk.backing.fileName = "[#{disk.backing.datastore.name}]"
                 new_disk.backing.parent = disk.backing
-              end
-            }
-          ]
+              end,
+            },
+          ],
         }
         vm_template.ReconfigVM_Task(spec: spec).wait_for_completion
       end
@@ -243,7 +243,7 @@ module ChefProvisioningVsphere
           key: idx,
           backing: RbVmomi::VIM.VirtualDiskFlatVer2BackingInfo(
             fileName: "[#{datastore}]",
-            diskMode: 'persistent',
+            diskMode: "persistent",
             thinProvisioned: true
           ),
           capacityInKB: size_gb * 1024 * 1024,
@@ -259,7 +259,7 @@ module ChefProvisioningVsphere
     # @param [Subject] datastore the datastore the disk will be created on.
     # @param [Subject] size_gb the size of the disk.
     def set_additional_disks_for(vm, datastore, additional_disk_size_gb)
-      raise ':datastore must be specified when adding a disk to a cloned vm' if datastore.to_s.empty? && additional_disk_size_gb
+      raise ":datastore must be specified when adding a disk to a cloned vm" if datastore.to_s.empty? && additional_disk_size_gb
 
       Array(additional_disk_size_gb).each do |size|
         size = size.to_i
@@ -272,7 +272,7 @@ module ChefProvisioningVsphere
                 vm,
                 datastore,
                 size
-              )
+              ),
             ]
           )
         )
@@ -304,7 +304,7 @@ module ChefProvisioningVsphere
 
                 allowGuestControl: true
               )
-            )
+            ),
           ]
         )
       )
@@ -333,8 +333,8 @@ module ChefProvisioningVsphere
           deviceChange: [
             {
               operation: :edit,
-              device: disk
-            }
+              device: disk,
+            },
           ]
         )
       ).wait_for_completion
@@ -357,16 +357,16 @@ module ChefProvisioningVsphere
       networks.each_index do |i|
         label = "Ethernet #{i + 1}"
         backing_info = backing_info_for(action_handler, networks[i])
-        if card = cards.shift
+        if card = cards.shift # rubocop:disable Lint/AssignmentInCondition
           key = card.key
-          operation = RbVmomi::VIM::VirtualDeviceConfigSpecOperation('edit')
+          operation = RbVmomi::VIM::VirtualDeviceConfigSpecOperation("edit")
           action_handler.report_progress "changing template nic for #{networks[i]}"
           changes.push(
             network_adapter_for(operation, networks[i], label, key, backing_info)
           )
         else
           key += 1
-          operation = RbVmomi::VIM::VirtualDeviceConfigSpecOperation('add')
+          operation = RbVmomi::VIM::VirtualDeviceConfigSpecOperation("add")
           action_handler.report_progress "will be adding nic for #{networks[i]}"
           additions.push(
             network_adapter_for(operation, networks[i], label, key, backing_info)
@@ -381,7 +381,7 @@ module ChefProvisioningVsphere
     # @param [Object] action_handler TODO
     # @param [String] network_name The network name to attach to
     def backing_info_for(action_handler, network_name)
-      action_handler.report_progress('finding networks...')
+      action_handler.report_progress("finding networks...")
       network = find_network(network_name)
       action_handler.report_progress(
         "network: #{network_name} is a #{network.class}"
@@ -396,7 +396,7 @@ module ChefProvisioningVsphere
         )
       else
         RbVmomi::VIM::VirtualEthernetCardNetworkBackingInfo(
-          deviceName: network_name.split('/').last
+          deviceName: network_name.split("/").last
         )
       end
     end
@@ -413,11 +413,11 @@ module ChefProvisioningVsphere
     # @param [String] name The name of the "thing."
     # @param [String] parent_folder The name of the folder to start from.
     def find_entity(name, parent_folder)
-      parts = name.split('/').reject(&:empty?)
+      parts = name.split("/").reject(&:empty?)
       parts.each do |item|
         Chef::Log.debug("Identifying entity part: #{item} in folder type: #{parent_folder.class}")
         if parent_folder.is_a? RbVmomi::VIM::Folder
-          Chef::Log.debug('Parent folder is a folder')
+          Chef::Log.debug("Parent folder is a folder")
           parent_folder = parent_folder.childEntity.find { |f| f.name == item }
         else
           parent_folder = yield(parent_folder, item)
@@ -481,7 +481,7 @@ module ChefProvisioningVsphere
     # @param [String] name Name of the Network.
     def find_network(name)
       base = datacenter.networkFolder
-      entity_array = name.split('/').reject(&:empty?)
+      entity_array = name.split("/").reject(&:empty?)
       entity_array.each do |item|
         base = traverse_folders_for_network(base, item)
       end
@@ -548,8 +548,8 @@ module ChefProvisioningVsphere
 
       req = Net::HTTP::Put.new("#{uri.path}?#{uri.query}")
       req.body_stream = File.open(local)
-      req['Content-Type'] = 'application/octet-stream'
-      req['Content-Length'] = size
+      req["Content-Type"] = "application/octet-stream"
+      req["Content-Length"] = size
       res = http.request(req)
       unless res.is_a?(Net::HTTPSuccess)
         raise "Error: #{res.inspect} :: #{res.body} :: sending #{local} to #{remote} at #{vm.name} via #{endpoint} with a size of #{size}"

data/lib/chef/provisioning/vsphere_driver/vsphere_url.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: false
 
-require 'uri'
+require "uri"
 
 # The main URI Module
 module URI
@@ -9,20 +9,20 @@ module URI
     # Default port for connecting to the vSphere cluster Webserver
     DEFAULT_PORT = 443
     # Default path for connecting to the vSphere cluster URL
-    DEFAULT_PATH = '/sdk'.freeze
+    DEFAULT_PATH = "/sdk".freeze
 
     # Creates the URL from options that are decided
     #
     def self.from_config(options)
       parts = []
-      parts << 'vsphere://'
+      parts << "vsphere://"
       parts << options[:host]
-      parts << ':'
+      parts << ":"
       parts << (options[:port] || DEFAULT_PORT)
       parts << (options[:path] || DEFAULT_PATH)
-      parts << '?use_ssl='
+      parts << "?use_ssl="
       parts << (options[:use_ssl] == false ? false : true)
-      parts << '&insecure='
+      parts << "&insecure="
       parts << (options[:insecure] || false)
       URI parts.join
     end
@@ -31,10 +31,10 @@ module URI
     #
     def use_ssl
       if query
-        ssl_query = query.split('&').each.select do |q|
-          q.start_with?('use_ssl=')
+        ssl_query = query.split("&").each.select do |q|
+          q.start_with?("use_ssl=")
         end.first
-        ssl_query == 'use_ssl=true'
+        ssl_query == "use_ssl=true"
       else
         true
       end
@@ -44,14 +44,14 @@ module URI
     #
     def insecure
       if query
-        insecure_query = query.split('&').each.select do |q|
-          q.start_with?('insecure=')
+        insecure_query = query.split("&").each.select do |q|
+          q.start_with?("insecure=")
         end.first
-        insecure_query == 'insecure=true'
+        insecure_query == "insecure=true"
       else
         false
       end
     end
   end
-  @@schemes['VSPHERE'] = VsphereUrl
+  @@schemes["VSPHERE"] = VsphereUrl
 end

data/lib/kitchen/driver/vsphere.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
-require 'json'
-require 'kitchen'
-require 'chef/provisioning/vsphere_driver'
-require 'chef/provisioning/machine_spec'
+require "json"
+require "kitchen"
+require "chef/provisioning/vsphere_driver"
+require "chef/provisioning/machine_spec"
 
 # Main Kitchen Module
 module Kitchen
@@ -21,14 +21,14 @@ module Kitchen
                      bootstrap_options: {
                        use_linked_clone: true,
                        ssh: {
-                         user: 'root',
+                         user: "root",
                          paranoid: false,
-                         port: 22
+                         port: 22,
                        },
                        convergence_options: {},
                        customization_spec: {
-                         domain: 'local'
-                       }
+                         domain: "local",
+                       },
                      }
 
       default_config(:vsphere_name) do |driver|
@@ -53,8 +53,8 @@ module Kitchen
           ensure
             if machine_spec
               if machine_spec.location
-                state[:server_id] = machine_spec.location['server_id']
-                state[:hostname] = machine_spec.location['ipaddress']
+                state[:server_id] = machine_spec.location["server_id"]
+                state[:hostname] = machine_spec.location["ipaddress"]
               end
               machine_spec.save(action_handler)
             end
@@ -69,8 +69,8 @@ module Kitchen
         return if state[:server_id].nil?
 
         with_provisioning_driver(state) do |action_handler, driver, machine_spec|
-          machine_spec.location = { 'driver_url' => driver.driver_url,
-                                    'server_id' => state[:server_id] }
+          machine_spec.location = { "driver_url" => driver.driver_url,
+                                    "server_id" => state[:server_id] }
           driver.destroy_machine(action_handler, machine_spec, config[:machine_options])
         end
 
@@ -103,7 +103,7 @@ module Kitchen
             unless @@chef_zero_server
               Chef::Config.local_mode = true
               Chef::Config.chef_repo_path = Chef::Config.find_chef_repo_path(Dir.pwd)
-              require 'chef/local_mode'
+              require "chef/local_mode"
               Chef::LocalMode.setup_server_connectivity
               @@chef_zero_server = true
             end

data/spec/integration_tests/vsphere_driver_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
-require 'chef/provisioning/vsphere_driver'
-require 'chef/provisioning/machine_spec'
+require "chef/provisioning/vsphere_driver"
+require "chef/provisioning/machine_spec"
 
 # A file named config.rb in the same directory as this spec file
 # must exist containing the driver options to use for the test.
@@ -34,12 +34,12 @@ require 'chef/provisioning/machine_spec'
 #   }
 # }
 
-describe 'vsphere_driver' do
+describe "vsphere_driver" do
   before :all do
-    skip("driver options do not exist") unless File.exist?(File.expand_path('../config.rb', __FILE__))
+    skip("driver options do not exist") unless File.exist?(File.expand_path("../config.rb", __FILE__))
 
     @vm_name = "cmvd-test-#{SecureRandom.hex}"
-    @metal_config = eval File.read(File.expand_path('../config.rb', __FILE__))
+    @metal_config = eval File.read(File.expand_path("../config.rb", __FILE__)) # rubocop:disable Security/Eval
     Cheffish.honor_local_mode do
       Chef::Log.level = :debug
       chef_server = Cheffish.default_chef_server
@@ -49,8 +49,8 @@ describe 'vsphere_driver' do
       action_handler = Chef::Provisioning::ActionHandler.new
       @driver.allocate_machine(action_handler, @machine_spec, @metal_config[:machine_options])
       @metal_config[:machine_options][:convergence_options] = { chef_server: chef_server }
-      machine = @driver.ready_machine(action_handler, @machine_spec, @metal_config[:machine_options])
-      @server_id = @machine_spec.location['server_id']
+      machine = @driver.ready_machine(action_handler, @machine_spec, @metal_config[:machine_options]) # rubocop:disable Lint/UselessAssignment
+      @server_id = @machine_spec.location["server_id"]
       @vsphere_helper = ChefProvisioningVsphere::VsphereHelper.new(
         @metal_config[:driver_options],
         @metal_config[:machine_options][:bootstrap_options][:datacenter]
@@ -59,88 +59,88 @@ describe 'vsphere_driver' do
     end
   end
 
-  context 'when allocating a machine' do
-    it 'adds machine to the correct folder' do
+  context "when allocating a machine" do
+    it "adds machine to the correct folder" do
       expect(@vm.parent.name).to eq(@metal_config[:machine_options][:bootstrap_options][:vm_folder])
     end
-    it 'has a matching id with the machine_spec' do
-      expect(@vm.config.instanceUuid).to eq(@machine_spec.location['server_id'])
+    it "has a matching id with the machine_spec" do
+      expect(@vm.config.instanceUuid).to eq(@machine_spec.location["server_id"])
     end
-    it 'has the correct name' do
+    it "has the correct name" do
       custom_name = @metal_config[:machine_options][:bootstrap_options][:customization_spec][:hostname]
       now = Time.now.utc
       trimmed_name = if custom_name
-                       @vm.config.guestId.start_with?('win') ? custom_name.to_s.byteslice(0, 15) : custom_name
+                       @vm.config.guestId.start_with?("win") ? custom_name.to_s.byteslice(0, 15) : custom_name
                      else
-                       @vm.config.guestId.start_with?('win') ? @vm_name.byteslice(0, 15) : @vm_name
+                       @vm.config.guestId.start_with?("win") ? @vm_name.byteslice(0, 15) : @vm_name
                      end
       expected_name = "#{trimmed_name}.#{@metal_config[:machine_options][:bootstrap_options][:customization_spec][:domain]}"
-      if @vm.config.guestId.start_with?('win')
+      if @vm.config.guestId.start_with?("win")
         until (Time.now.utc - now) > 30 || expected_name.to_s.include?(@vm.guest.hostName)
-          print '.'
+          print "."
           sleep 5
         end
         expect(expected_name).to include(@vm.guest.hostName)
       else
         until (Time.now.utc - now) > 30 || (@vm.guest.hostName == expected_name)
-          print '.'
+          print "."
           sleep 5
         end
         expect(@vm.guest.hostName).to eq(expected_name) # For linux Systems
       end
     end
-    it 'is on the correct networks' do
-      expect(@vm.network.map(&:name)).to include(@metal_config[:machine_options][:bootstrap_options][:network_name][0]) unless @vm.config.guestId.start_with?('win')
-      expect(@vm.network.map(&:name)).to include(@metal_config[:machine_options][:bootstrap_options][:network_name][1]) unless @vm.config.guestId.start_with?('win')
+    it "is on the correct networks" do
+      expect(@vm.network.map(&:name)).to include(@metal_config[:machine_options][:bootstrap_options][:network_name][0]) unless @vm.config.guestId.start_with?("win")
+      expect(@vm.network.map(&:name)).to include(@metal_config[:machine_options][:bootstrap_options][:network_name][1]) unless @vm.config.guestId.start_with?("win")
     end
-    it 'is on the correct datastore' do
-      expect(@vm.datastore[0].name).to eq(@metal_config[:machine_options][:bootstrap_options][:datastore]) unless @vm.config.guestId.start_with?('win')
+    it "is on the correct datastore" do
+      expect(@vm.datastore[0].name).to eq(@metal_config[:machine_options][:bootstrap_options][:datastore]) unless @vm.config.guestId.start_with?("win")
     end
-    it 'is in the correct datacenter' do
-      expect(@vsphere_helper.vim.serviceInstance.find_datacenter(@metal_config[:machine_options][:bootstrap_options][:datacenter]).find_vm("#{@vm.parent.name}/#{@vm_name}")).not_to eq(nil) unless @vm.config.guestId.start_with?('win')
+    it "is in the correct datacenter" do
+      expect(@vsphere_helper.vim.serviceInstance.find_datacenter(@metal_config[:machine_options][:bootstrap_options][:datacenter]).find_vm("#{@vm.parent.name}/#{@vm_name}")).not_to eq(nil) unless @vm.config.guestId.start_with?("win")
     end
-    it 'has an added disk of the correct size' do
+    it "has an added disk of the correct size" do
       disk_count = @vm.disks.count
-      expect(@vm.disks[disk_count - 1].capacityInKB).to eq(@metal_config[:machine_options][:bootstrap_options][:additional_disk_size_gb][1] * 1024 * 1024) unless @vm.config.guestId.start_with?('win')
+      expect(@vm.disks[disk_count - 1].capacityInKB).to eq(@metal_config[:machine_options][:bootstrap_options][:additional_disk_size_gb][1] * 1024 * 1024) unless @vm.config.guestId.start_with?("win")
     end
-    it 'has the correct number of CPUs' do
+    it "has the correct number of CPUs" do
       expect(@vm.config.hardware.numCPU).to eq(@metal_config[:machine_options][:bootstrap_options][:num_cpus])
     end
-    it 'has the correct amount of memory' do
+    it "has the correct amount of memory" do
       expect(@vm.config.hardware.memoryMB).to eq(@metal_config[:machine_options][:bootstrap_options][:memory_mb])
     end
-    it 'is in the correct resource pool' do
+    it "is in the correct resource pool" do
       if @metal_config[:machine_options][:bootstrap_options].key?(:resource_pool)
-        expect(@vm.resourcePool.name).to eq(@metal_config[:machine_options][:bootstrap_options][:resource_pool].split('/')[1])
+        expect(@vm.resourcePool.name).to eq(@metal_config[:machine_options][:bootstrap_options][:resource_pool].split("/")[1])
       end
     end
-    it 'is in the correct host' do
+    it "is in the correct host" do
       if @metal_config[:machine_options][:bootstrap_options].key?(:host)
-        expect(@vm.runtime.host.name).to eq(@metal_config[:machine_options][:bootstrap_options][:host].split('/').last)
+        expect(@vm.runtime.host.name).to eq(@metal_config[:machine_options][:bootstrap_options][:host].split("/").last)
       end
     end
-    it 'is in the correct cluster' do
+    it "is in the correct cluster" do
       if @metal_config[:machine_options][:bootstrap_options].key?(:resource_pool)
-        expect(@vm.resourcePool.owner.name).to eq(@metal_config[:machine_options][:bootstrap_options][:resource_pool].split('/')[0])
+        expect(@vm.resourcePool.owner.name).to eq(@metal_config[:machine_options][:bootstrap_options][:resource_pool].split("/")[0])
       end
     end
-    it 'has the correct number of disks' do
-      expect(@vm.disks.count).to eq(3) unless @vm.config.guestId.start_with?('win')
+    it "has the correct number of disks" do
+      expect(@vm.disks.count).to eq(3) unless @vm.config.guestId.start_with?("win")
     end
-    it 'has hot add cpu enabled' do
+    it "has hot add cpu enabled" do
       expect(@vm.config.cpuHotAddEnabled).to eq(true)
     end
-    it 'has hot remove cpu enabled' do
+    it "has hot remove cpu enabled" do
       expect(@vm.config.cpuHotRemoveEnabled).to eq(true)
     end
-    it 'has hot add memory enabled' do
+    it "has hot add memory enabled" do
       expect(@vm.config.memoryHotAddEnabled).to eq(true)
     end
-    it 'has the correct static IP address' do
+    it "has the correct static IP address" do
       if @metal_config[:machine_options][:bootstrap_options][:customization_spec][:ipsettings][:ip]
         now = Time.now.utc
-        until (Time.now.utc - now) > 30 || (@vm.guest.toolsRunningStatus == 'guestToolsRunning' && @vm.guest.net.count == 2 && @vm.guest.net[1].ipAddress[1] == @metal_config[:machine_options][:bootstrap_options][:customization_spec][:ipsettings][:ip])
-          print '.'
+        until (Time.now.utc - now) > 30 || (@vm.guest.toolsRunningStatus == "guestToolsRunning" && @vm.guest.net.count == 2 && @vm.guest.net[1].ipAddress[1] == @metal_config[:machine_options][:bootstrap_options][:customization_spec][:ipsettings][:ip])
+          print "."
           sleep 5
         end
         expect(@vm.guest.net.map(&:ipAddress).flatten).to include(@metal_config[:machine_options][:bootstrap_options][:customization_spec][:ipsettings][:ip])
@@ -148,8 +148,8 @@ describe 'vsphere_driver' do
     end
   end
 
-  context 'destroy_machine' do
-    it 'removes the machine' do
+  context "destroy_machine" do
+    it "removes the machine" do
       Cheffish.honor_local_mode do
         chef_server = Cheffish.default_chef_server
         url = URI::VsphereUrl.from_config(@metal_config[:driver_options]).to_s
@@ -158,8 +158,8 @@ describe 'vsphere_driver' do
         machine_spec = Chef::Provisioning.chef_managed_entry_store(chef_server)
                                          .new_entry(:machine, @vm_name)
         machine_spec.location = {
-          'driver_url' => driver.driver_url,
-          'server_id' => @server_id
+          "driver_url" => driver.driver_url,
+          "server_id" => @server_id,
         }
         driver.destroy_machine(
           action_handler,