chef-provisioning-vsphere 0.8.1 → 0.8.2

data/spec/unit_tests/VsphereDriver_spec.rb

@@ -1,132 +1,132 @@
-require 'chef/provisioning/vsphere_driver'
-
-describe ChefProvisioningVsphere::VsphereDriver do
-  subject do
-    Chef::Provisioning.driver_for_url(
-      'vsphere://3.3.3.3:999/crazyapi?use_ssl=false&insecure=true',
-      metal_config
-    )
-  end
-
-  context "when config does not include the properties included in the url" do
-    let(:metal_config) do
-      {
-        :driver_options => {
-          :user => 'vmapi',
-          :password => '<password>'
-        },
-        :machine_options => { 
-          :ssh => {
-            :password => '<password>',
-            :paranoid => false
-          },
-          :bootstrap_options => {
-            :datacenter => 'QA1',
-            :template_name => 'UBUNTU-12-64-TEMPLATE',
-            :vm_folder => 'DLAB',
-            :num_cpus => 2,
-            :memory_mb => 4096,
-            :resource_pool => 'CLSTR02/DLAB'
-          }
-        },
-        :log_level => :debug
-      }
-    end
-
-    it "populates the connect options with correct host from the driver url" do
-      expect(subject.connect_options[:host]).to eq('3.3.3.3')
-    end
-    it "populates the connect options with correct port from the driver url" do
-      expect(subject.connect_options[:port]).to eq(999)
-    end
-    it "populates the connect options with correct path from the driver url" do
-      expect(subject.connect_options[:path]).to eq('/crazyapi')
-    end
-    it "populates the connect options with correct use_ssl setting from the driver url" do
-      expect(subject.connect_options[:use_ssl]).to eq(false)
-    end
-    it "populates the connect options with correct insecure setting from the driver url" do
-      expect(subject.connect_options[:insecure]).to eq(true)
-    end
-  end
-
-  context "when config keys are stringified" do
-    let(:metal_config) do
-      {
-        'driver_options' => {
-          'user' => 'vmapi',
-          'password' => '<driver_password>'
-        },
-        'bootstrap_options' => {
-          'machine_options' => {
-            'datacenter' => 'QA1',
-            'ssh' => {
-              'password' => '<machine_password>'
-            }
-          }
-        }
-      }
-    end
-
-    it "will symbolize user" do
-      expect(subject.connect_options[:user]).to eq('vmapi')
-    end
-    it "will symbolize password" do
-      expect(subject.connect_options[:password]).to eq('<driver_password>')
-    end
-    it "will symbolize ssh password" do
-      expect(subject.config[:bootstrap_options][:machine_options][:ssh][:password]).to eq('<machine_password>')
-    end
-    it "will symbolize ssh bootstrap options" do
-      expect(subject.config[:bootstrap_options][:machine_options][:datacenter]).to eq('QA1')
-    end
-  end
-
-  describe 'canonicalize_url' do
-    context "when no url is in the config" do
-      let(:metal_config) do
-        {
-          :user => 'vmapi',
-          :password => '<password>',
-          :host => '4.4.4.4',
-          :port => 888,
-          :path => '/yoda',
-          :use_ssl => false,
-          :insecure => true
-        }
-      end
-
-      subject do
-        ChefProvisioningVsphere::VsphereDriver.canonicalize_url(
-          nil, 
-          metal_config
-        )
-      end
-
-      it "creates the correct driver url from config settings" do
-        expect(subject[0]).to eq('vsphere://4.4.4.4:888/yoda?use_ssl=false&insecure=true')
-      end
-    end
-
-    context "when no url is in the config and config is missing defaulted values" do
-      let(:metal_config) do
-        {
-          :user => 'vmapi',
-          :password => '<password>',
-          :host => '4.4.4.4'
-        }
-      end
-
-      subject do
-        ChefProvisioningVsphere::VsphereDriver.canonicalize_url(
-          nil,
-          metal_config
-        )
-      end
-
-      it "creates the correct driver url from default settings" do
-        expect(subject[0]).to eq('vsphere://4.4.4.4/sdk?use_ssl=true&insecure=false')
-      end
-    end
-  end
-end
+require 'chef/provisioning/vsphere_driver'
+
+describe ChefProvisioningVsphere::VsphereDriver do
+  subject do
+    Chef::Provisioning.driver_for_url(
+      'vsphere://3.3.3.3:999/crazyapi?use_ssl=false&insecure=true',
+      metal_config
+    )
+  end
+
+  context "when config does not include the properties included in the url" do
+    let(:metal_config) do
+      {
+        :driver_options => {
+          :user => 'vmapi',
+          :password => '<password>'
+        },
+        :machine_options => { 
+          :ssh => {
+            :password => '<password>',
+            :paranoid => false
+          },
+          :bootstrap_options => {
+            :datacenter => 'QA1',
+            :template_name => 'UBUNTU-12-64-TEMPLATE',
+            :vm_folder => 'DLAB',
+            :num_cpus => 2,
+            :memory_mb => 4096,
+            :resource_pool => 'CLSTR02/DLAB'
+          }
+        },
+        :log_level => :debug
+      }
+    end
+
+    it "populates the connect options with correct host from the driver url" do
+      expect(subject.connect_options[:host]).to eq('3.3.3.3')
+    end
+    it "populates the connect options with correct port from the driver url" do
+      expect(subject.connect_options[:port]).to eq(999)
+    end
+    it "populates the connect options with correct path from the driver url" do
+      expect(subject.connect_options[:path]).to eq('/crazyapi')
+    end
+    it "populates the connect options with correct use_ssl setting from the driver url" do
+      expect(subject.connect_options[:use_ssl]).to eq(false)
+    end
+    it "populates the connect options with correct insecure setting from the driver url" do
+      expect(subject.connect_options[:insecure]).to eq(true)
+    end
+  end
+
+  context "when config keys are stringified" do
+    let(:metal_config) do
+      {
+        'driver_options' => {
+          'user' => 'vmapi',
+          'password' => '<driver_password>'
+        },
+        'bootstrap_options' => {
+          'machine_options' => {
+            'datacenter' => 'QA1',
+            'ssh' => {
+              'password' => '<machine_password>'
+            }
+          }
+        }
+      }
+    end
+
+    it "will symbolize user" do
+      expect(subject.connect_options[:user]).to eq('vmapi')
+    end
+    it "will symbolize password" do
+      expect(subject.connect_options[:password]).to eq('<driver_password>')
+    end
+    it "will symbolize ssh password" do
+      expect(subject.config[:bootstrap_options][:machine_options][:ssh][:password]).to eq('<machine_password>')
+    end
+    it "will symbolize ssh bootstrap options" do
+      expect(subject.config[:bootstrap_options][:machine_options][:datacenter]).to eq('QA1')
+    end
+  end
+
+  describe 'canonicalize_url' do
+    context "when no url is in the config" do
+      let(:metal_config) do
+        {
+          :user => 'vmapi',
+          :password => '<password>',
+          :host => '4.4.4.4',
+          :port => 888,
+          :path => '/yoda',
+          :use_ssl => false,
+          :insecure => true
+        }
+      end
+
+      subject do
+        ChefProvisioningVsphere::VsphereDriver.canonicalize_url(
+          nil, 
+          metal_config
+        )
+      end
+
+      it "creates the correct driver url from config settings" do
+        expect(subject[0]).to eq('vsphere://4.4.4.4:888/yoda?use_ssl=false&insecure=true')
+      end
+    end
+
+    context "when no url is in the config and config is missing defaulted values" do
+      let(:metal_config) do
+        {
+          :user => 'vmapi',
+          :password => '<password>',
+          :host => '4.4.4.4'
+        }
+      end
+
+      subject do
+        ChefProvisioningVsphere::VsphereDriver.canonicalize_url(
+          nil,
+          metal_config
+        )
+      end
+
+      it "creates the correct driver url from default settings" do
+        expect(subject[0]).to eq('vsphere://4.4.4.4/sdk?use_ssl=true&insecure=false')
+      end
+    end
+  end
+end

data/spec/unit_tests/VsphereUrl_spec.rb

@@ -1,66 +1,66 @@
-require_relative '../../lib/chef/provisioning/vsphere_driver/vsphere_url.rb'
-
-describe 'VsphereUrl' do
-	expected_host='1.1.1.1'
-	expected_port=1818
-	expected_path='/path'
-
-	let(:url) {URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}")}
-
-	it "has the vsphere scheme" do
-		expect(url.scheme).to eq('vsphere')
-	end
-	it "has the expected host" do
-		expect(url.host).to eq(expected_host)
-	end
-	it "has the expected port" do
-		expect(url.port).to eq(expected_port)
-	end
-	it "has the expected path" do
-		expect(url.path).to eq(expected_path)
-	end
-	it "has the the default ssl setting" do
-		expect(url.use_ssl).to eq(true)
-	end
-	it "has the the default insecure setting" do
-		expect(url.insecure).to eq(false)
-	end
-
-	context "when setting from a hash" do
-		let(:url) { URI::VsphereUrl.from_config({
-			:host => '2.2.2.2',
-			:port => 2345,
-			:path => "/hoooo",
-			:use_ssl => false,
-			:insecure => true
-		}) }
-
-		it "asigns the correct url" do
-			expect(url.to_s).to eq('vsphere://2.2.2.2:2345/hoooo?use_ssl=false&insecure=true')
-		end
-	end
-	context "when ssl is enabled" do
-		it "retuns an ssl value of true" do
-			url = URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}?use_ssl=true")
-			expect(url.use_ssl).to eq(true)
-		end
-	end
-	context "when ssl is disabled" do
-		it "retuns an ssl value of true" do
-			url = URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}?use_ssl=false")
-			expect(url.use_ssl).to eq(false)
-		end
-	end
-	context "when insecure is enabled" do
-		it "retuns an insecure value of true" do
-			url = URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}?insecure=true")
-			expect(url.insecure).to eq(true)
-		end
-	end
-	context "when insecure is disabled" do
-		it "retuns an insecure value of true" do
-			url = URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}?insecure=false")
-			expect(url.insecure).to eq(false)
-		end
-	end
+require_relative '../../lib/chef/provisioning/vsphere_driver/vsphere_url.rb'
+
+describe 'VsphereUrl' do
+	expected_host='1.1.1.1'
+	expected_port=1818
+	expected_path='/path'
+
+	let(:url) {URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}")}
+
+	it "has the vsphere scheme" do
+		expect(url.scheme).to eq('vsphere')
+	end
+	it "has the expected host" do
+		expect(url.host).to eq(expected_host)
+	end
+	it "has the expected port" do
+		expect(url.port).to eq(expected_port)
+	end
+	it "has the expected path" do
+		expect(url.path).to eq(expected_path)
+	end
+	it "has the the default ssl setting" do
+		expect(url.use_ssl).to eq(true)
+	end
+	it "has the the default insecure setting" do
+		expect(url.insecure).to eq(false)
+	end
+
+	context "when setting from a hash" do
+		let(:url) { URI::VsphereUrl.from_config({
+			:host => '2.2.2.2',
+			:port => 2345,
+			:path => "/hoooo",
+			:use_ssl => false,
+			:insecure => true
+		}) }
+
+		it "asigns the correct url" do
+			expect(url.to_s).to eq('vsphere://2.2.2.2:2345/hoooo?use_ssl=false&insecure=true')
+		end
+	end
+	context "when ssl is enabled" do
+		it "retuns an ssl value of true" do
+			url = URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}?use_ssl=true")
+			expect(url.use_ssl).to eq(true)
+		end
+	end
+	context "when ssl is disabled" do
+		it "retuns an ssl value of true" do
+			url = URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}?use_ssl=false")
+			expect(url.use_ssl).to eq(false)
+		end
+	end
+	context "when insecure is enabled" do
+		it "retuns an insecure value of true" do
+			url = URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}?insecure=true")
+			expect(url.insecure).to eq(true)
+		end
+	end
+	context "when insecure is disabled" do
+		it "retuns an insecure value of true" do
+			url = URI("vsphere://#{expected_host}:#{expected_port}#{expected_path}?insecure=false")
+			expect(url.insecure).to eq(false)
+		end
+	end
 end

data/spec/unit_tests/clone_spec_builder_spec.rb

@@ -1,161 +1,161 @@
-require 'chef/provisioning/vsphere_driver'
-require_relative 'support/fake_action_handler'
-require_relative 'support/vsphere_helper_stub'
-
-describe ChefProvisioningVsphere::CloneSpecBuilder do
-  let(:options) { Hash.new }
-  let(:vm_template) { double('template') }
-
-  before do
-    allow(vm_template).to receive_message_chain(:config, :guestId)
-      .and_return('guest')
-    allow(vm_template).to receive_message_chain(:config, :template)
-      .and_return(false)
-  end
-
-  subject do
-    builder = ChefProvisioningVsphere::CloneSpecBuilder.new(
-      ChefProvisioningVsphereStubs::VsphereHelperStub.new,
-      ChefProvisioningVsphereStubs::FakeActionHandler.new
-    )
-    builder.build(vm_template, 'machine_name', options)
-  end
-
-  context 'using linked clones' do
-    before { options[:use_linked_clone] = true }
-
-    it 'sets the disk move type of the relocation spec' do
-      expect(subject.location.diskMoveType).to be :moveChildMostDiskBacking
-    end
-  end
-
-  context 'using linked clone on a template source' do
-    before do
-      options[:use_linked_clone] = true
-      options[:host] = 'host'
-      allow(vm_template).to receive_message_chain(:config, :template)
-        .and_return(true)
-    end
-
-    it 'does not set the disk move type of the relocation spec' do
-      expect(subject.location.diskMoveType).to be nil
-    end
-  end
-
-  context 'not using linked clones' do
-    before { options[:use_linked_clone] = false }
-
-    it 'does not set the disk move type of the relocation spec' do
-      expect(subject.location.diskMoveType).to be nil
-    end
-  end
-
-  context 'specifying a host' do
-    before { options[:host] = 'host' }
-
-    it 'sets the host' do
-      expect(subject.location.host).to_not be nil
-    end
-  end
-
-  context 'not specifying a host' do
-    it 'does not set the host' do
-      expect(subject.location.host).to be nil
-    end
-  end
-
-  context 'specifying a pool' do
-    before { options[:resource_pool] = 'pool' }
-
-    it 'sets the pool' do
-      expect(subject.location.pool).to_not be nil
-    end
-  end
-
-  context 'not specifying a pool' do
-    it 'does not set the pool' do
-      expect(subject.location.pool).to be nil
-    end
-  end
-
-  context 'not specifying a pool but specifying a host on a template' do
-    before do 
-      options[:host] = 'host'
-      allow(vm_template).to receive_message_chain(:config, :template)
-        .and_return(true)
-    end
-
-    it 'sets the pool to the hosts parent root pool' do
-      expect(subject.location.pool).to be subject.location.host.parent.resourcePool
-    end
-  end
-
-  context 'not specifying a pool or host when cloning from a template' do
-    before do
-      allow(vm_template).to receive_message_chain(:config, :template)
-        .and_return(true)
-    end
-
-    it 'raises an error' do
-      expect { subject }.to raise_error
-    end
-  end
-
-  context 'specifying a hostname' do
-    before do
-      options[:customization_spec] = { 
-        ipsettings: {},
-        hostname: hostname,
-        domain: 'local' 
-      }
-    end
-
-    context 'alpha characters only' do
-      let(:hostname) { 'myhost' }
-
-      it 'sets the spec hostname' do
-        expect(subject.customization.identity.hostName.name).to eq hostname
-      end
-    end
-
-    context 'alpha numeric characters only' do
-      let(:hostname) { 'myhost01' }
-
-      it 'sets the spec hostname' do
-        expect(subject.customization.identity.hostName.name).to eq hostname
-      end
-    end
-
-    context 'containing a dash' do
-      let(:hostname) { 'my-host01' }
-
-      it 'sets the spec hostname' do
-        expect(subject.customization.identity.hostName.name).to eq hostname
-      end
-    end
-
-    context 'containing an underscore' do
-      let(:hostname) { 'my_host' }
-
-      it 'raises an error' do
-        expect { subject }.to raise_error
-      end
-    end
-
-    context 'starting with a dash' do
-      let(:hostname) { '-myhost' }
-
-      it 'raises an error' do
-        expect { subject }.to raise_error
-      end
-    end
-
-    context 'ending with a dash' do
-      let(:hostname) { 'myhost-' }
-
-      it 'raises an error' do
-        expect { subject }.to raise_error
-      end
-    end    
-  end
-end
+require 'chef/provisioning/vsphere_driver'
+require_relative 'support/fake_action_handler'
+require_relative 'support/vsphere_helper_stub'
+
+describe ChefProvisioningVsphere::CloneSpecBuilder do
+  let(:options) { Hash.new }
+  let(:vm_template) { double('template') }
+
+  before do
+    allow(vm_template).to receive_message_chain(:config, :guestId)
+      .and_return('guest')
+    allow(vm_template).to receive_message_chain(:config, :template)
+      .and_return(false)
+  end
+
+  subject do
+    builder = ChefProvisioningVsphere::CloneSpecBuilder.new(
+      ChefProvisioningVsphereStubs::VsphereHelperStub.new,
+      ChefProvisioningVsphereStubs::FakeActionHandler.new
+    )
+    builder.build(vm_template, 'machine_name', options)
+  end
+
+  context 'using linked clones' do
+    before { options[:use_linked_clone] = true }
+
+    it 'sets the disk move type of the relocation spec' do
+      expect(subject.location.diskMoveType).to be :moveChildMostDiskBacking
+    end
+  end
+
+  context 'using linked clone on a template source' do
+    before do
+      options[:use_linked_clone] = true
+      options[:host] = 'host'
+      allow(vm_template).to receive_message_chain(:config, :template)
+        .and_return(true)
+    end
+
+    it 'does not set the disk move type of the relocation spec' do
+      expect(subject.location.diskMoveType).to be nil
+    end
+  end
+
+  context 'not using linked clones' do
+    before { options[:use_linked_clone] = false }
+
+    it 'does not set the disk move type of the relocation spec' do
+      expect(subject.location.diskMoveType).to be nil
+    end
+  end
+
+  context 'specifying a host' do
+    before { options[:host] = 'host' }
+
+    it 'sets the host' do
+      expect(subject.location.host).to_not be nil
+    end
+  end
+
+  context 'not specifying a host' do
+    it 'does not set the host' do
+      expect(subject.location.host).to be nil
+    end
+  end
+
+  context 'specifying a pool' do
+    before { options[:resource_pool] = 'pool' }
+
+    it 'sets the pool' do
+      expect(subject.location.pool).to_not be nil
+    end
+  end
+
+  context 'not specifying a pool' do
+    it 'does not set the pool' do
+      expect(subject.location.pool).to be nil
+    end
+  end
+
+  context 'not specifying a pool but specifying a host on a template' do
+    before do 
+      options[:host] = 'host'
+      allow(vm_template).to receive_message_chain(:config, :template)
+        .and_return(true)
+    end
+
+    it 'sets the pool to the hosts parent root pool' do
+      expect(subject.location.pool).to be subject.location.host.parent.resourcePool
+    end
+  end
+
+  context 'not specifying a pool or host when cloning from a template' do
+    before do
+      allow(vm_template).to receive_message_chain(:config, :template)
+        .and_return(true)
+    end
+
+    it 'raises an error' do
+      expect { subject }.to raise_error
+    end
+  end
+
+  context 'specifying a hostname' do
+    before do
+      options[:customization_spec] = { 
+        ipsettings: {},
+        hostname: hostname,
+        domain: 'local' 
+      }
+    end
+
+    context 'alpha characters only' do
+      let(:hostname) { 'myhost' }
+
+      it 'sets the spec hostname' do
+        expect(subject.customization.identity.hostName.name).to eq hostname
+      end
+    end
+
+    context 'alpha numeric characters only' do
+      let(:hostname) { 'myhost01' }
+
+      it 'sets the spec hostname' do
+        expect(subject.customization.identity.hostName.name).to eq hostname
+      end
+    end
+
+    context 'containing a dash' do
+      let(:hostname) { 'my-host01' }
+
+      it 'sets the spec hostname' do
+        expect(subject.customization.identity.hostName.name).to eq hostname
+      end
+    end
+
+    context 'containing an underscore' do
+      let(:hostname) { 'my_host' }
+
+      it 'raises an error' do
+        expect { subject }.to raise_error
+      end
+    end
+
+    context 'starting with a dash' do
+      let(:hostname) { '-myhost' }
+
+      it 'raises an error' do
+        expect { subject }.to raise_error
+      end
+    end
+
+    context 'ending with a dash' do
+      let(:hostname) { 'myhost-' }
+
+      it 'raises an error' do
+        expect { subject }.to raise_error
+      end
+    end    
+  end
+end