chef-provisioning-aws 1.3.1 → 1.4.0

data/spec/integration/aws_dhcp_options_spec.rb

@@ -0,0 +1,73 @@
+describe "AwsDhcpOptions" do
+  extend AWSSupport
+
+  when_the_chef_12_server "exists", organization: 'foo', server_scope: :context do
+    with_aws "when connected to AWS" do
+
+      it "creates an aws_dhcp_options resource with maximum attributes" do
+        expect_recipe {
+          aws_dhcp_options 'test-dhcp-options' do
+            domain_name          'example.com'
+            domain_name_servers  %w(8.8.8.8 8.8.4.4)
+            ntp_servers          %w(8.8.8.8 8.8.4.4)
+            netbios_name_servers %w(8.8.8.8 8.8.4.4)
+            netbios_node_type    2
+          end
+        }.to create_an_aws_dhcp_options('test-dhcp-options', configuration: {
+          domain_name: 'example.com',
+          domain_name_servers: %w(8.8.8.8 8.8.4.4),
+          ntp_servers: %w(8.8.8.8 8.8.4.4),
+          netbios_name_servers: %w(8.8.8.8 8.8.4.4),
+          netbios_node_type: 2
+        }).and be_idempotent
+      end
+
+      it "creates aws_dhcp_options tags" do
+        expect_recipe {
+          aws_dhcp_options 'test-dhcp-options' do
+            aws_tags key1: "value"
+          end
+        }.to create_an_aws_dhcp_options('test-dhcp-options')
+        .and have_aws_dhcp_options_tags('test-dhcp-options',
+          {
+            'Name' => 'test-dhcp-options',
+            'key1' => 'value'
+          }
+        ).and be_idempotent
+      end
+
+      context "with existing tags" do
+        aws_dhcp_options 'test-dhcp-options' do
+          aws_tags key1: "value"
+        end
+
+        it "updates aws_dhcp_options tags" do
+          expect_recipe {
+            aws_dhcp_options 'test-dhcp-options' do
+              aws_tags key1: "value2", key2: nil
+            end
+          }.to have_aws_dhcp_options_tags('test-dhcp-options',
+            {
+              'Name' => 'test-dhcp-options',
+              'key1' => 'value2',
+              'key2' => ''
+            }
+          ).and be_idempotent
+        end
+
+        it "removes all aws_dhcp_options tags except Name" do
+          expect_recipe {
+            aws_dhcp_options 'test-dhcp-options' do
+              aws_tags Hash.new
+            end
+          }.to have_aws_dhcp_options_tags('test-dhcp-options',
+            {
+              'Name' => 'test-dhcp-options'
+            }
+          ).and be_idempotent
+        end
+      end
+
+    end
+  end
+end

data/spec/integration/aws_ebs_volume_spec.rb

@@ -44,6 +44,103 @@ describe Chef::Resource::AwsEbsVolume do
          .and be_idempotent
       end
 
+      # These tests are testing the tagging functionality - they use some example resources rather
+      # because these are integration tests so we cannot make a mock resource.
+      it "aws_ebs_volume 'test_volume' created with default Name tag" do
+        expect_recipe {
+          aws_ebs_volume "test_volume"
+        }.to create_an_aws_ebs_volume('test_volume'
+        ).and have_aws_ebs_volume_tags('test_volume',
+                       { 'Name' => 'test_volume' }
+        ).and be_idempotent
+      end
+
+      it "allows users to specify a unique Name tag" do
+        expect_recipe {
+          aws_ebs_volume "test_volume_2" do
+            aws_tags :Name => 'test_volume_new'
+          end
+        }.to create_an_aws_ebs_volume('test_volume_2'
+        ).and have_aws_ebs_volume_tags('test_volume_2',
+                                      { 'Name' => 'test_volume_new' }
+        ).and be_idempotent
+      end
+
+      it "allows tags to be specified as strings or symbols" do
+        expect_recipe {
+          aws_ebs_volume "test_volume" do
+            aws_tags({
+              :key1 => :symbol,
+              'key2' => :symbol,
+              :key3 => 'string',
+              'key4' => 'string'
+            })
+          end
+        }.to create_an_aws_ebs_volume('test_volume'
+        ).and have_aws_ebs_volume_tags('test_volume',
+                       {
+                         'key1' => 'symbol',
+                         'key2' => 'symbol',
+                         'key3' => 'string',
+                         'key4' => 'string'
+                       }
+        ).and be_idempotent
+      end
+
+      context "when there are existing tags" do
+        before(:each) do
+          converge {
+            aws_ebs_volume "test_volume_a" do
+              aws_tags :byebye => 'true'
+            end
+          }
+        end
+
+        after(:each) do
+          converge {
+            aws_ebs_volume "test_volume_a" do
+              action :purge
+            end
+          }
+        end
+
+        it "updates the tags" do
+          expect_recipe {
+            aws_ebs_volume "test_volume_a" do
+              aws_tags 'Name' => 'test_volume_b', :project => 'X'
+            end
+          }.to have_aws_ebs_volume_tags('test_volume_a',
+                                        {
+                                          'Name' => 'test_volume_b',
+                                          'project' => 'X'
+                                        }
+          ).and be_idempotent
+        end
+
+        it "deletes the tags" do
+          expect_recipe {
+            aws_ebs_volume "test_volume_a" do
+              aws_tags {}
+            end
+          }.to have_aws_ebs_volume_tags('test_volume_a',
+                                        {
+                                          'Name' => 'test_volume_a',
+                                        }
+          ).and be_idempotent
+        end
+
+        it "aws_ebs_volume 'test_volume' tags are not changed when not updated" do
+          expect_recipe {
+            #aws_ebs_volume "test_volume_a"
+          }.to have_aws_ebs_volume_tags('test_volume_a',
+                                        {
+                                          'Name' => 'test_volume_a',
+                                          'byebye' => 'true'
+                                        }
+          )
+        end
+      end
+
     end
   end
 end

data/spec/integration/aws_network_acl_spec.rb

@@ -102,6 +102,57 @@ describe Chef::Resource::AwsNetworkAcl do
           ).and be_idempotent
         end
       end
+
+      it "creates aws_network_acl tags" do
+        expect_recipe {
+          aws_network_acl 'test_network_acl' do
+            vpc 'test_vpc'
+            aws_tags key1: "value"
+          end
+        }.to create_an_aws_network_acl('test_network_acl')
+        .and have_aws_network_acl_tags('test_network_acl',
+          {
+            'Name' => 'test_network_acl',
+            'key1' => 'value'
+          }
+        ).and be_idempotent
+      end
+
+      context "with existing tags" do
+        aws_network_acl 'test_network_acl' do
+          vpc 'test_vpc'
+          aws_tags key1: "value"
+        end
+
+        it "updates aws_network_acl tags" do
+          expect_recipe {
+            aws_network_acl 'test_network_acl' do
+              vpc 'test_vpc'
+              aws_tags key1: "value2", key2: nil
+            end
+          }.to have_aws_network_acl_tags('test_network_acl',
+            {
+              'Name' => 'test_network_acl',
+              'key1' => 'value2',
+              'key2' => ''
+            }
+          ).and be_idempotent
+        end
+
+        it "removes all aws_network_acl tags except Name" do
+          expect_recipe {
+            aws_network_acl 'test_network_acl' do
+              vpc 'test_vpc'
+              aws_tags {}
+            end
+          }.to have_aws_network_acl_tags('test_network_acl',
+            {
+              'Name' => 'test_network_acl'
+            }
+          ).and be_idempotent
+        end
+      end
+
     end
   end
 end

data/spec/integration/aws_network_interface_spec.rb

@@ -0,0 +1,89 @@
+describe "AwsNetworkInterface" do
+  extend AWSSupport
+
+  when_the_chef_12_server "exists", organization: 'foo', server_scope: :context do
+    with_aws "when connected to AWS" do
+
+      context "setting up public VPC", :super_slow do
+
+        # Putting this in its own context so it doesn't slow down other tests
+        setup_public_vpc
+
+        it "creates an aws_network_interface resource with maximum attributes" do
+          expect_recipe {
+            machine "test_machine" do
+              machine_options bootstrap_options: {
+                subnet_id: 'test_public_subnet',
+                security_group_ids: ['test_security_group']
+              }
+              action :allocate
+            end
+
+            aws_network_interface 'test_network_interface' do
+              subnet 'test_public_subnet'
+              private_ip_address '10.0.0.25'
+              description "test_network_interface"
+              security_groups ['test_security_group']
+              machine "test_machine"
+              device_index 1
+            end
+          }.to create_an_aws_instance('test_machine'
+          ).and create_an_aws_network_interface('test_network_interface'
+          ).and be_idempotent
+        end
+
+        it "creates aws_network_interface tags" do
+          expect_recipe {
+            aws_network_interface 'test_network_interface' do
+              subnet 'test_public_subnet'
+              aws_tags key1: "value"
+            end
+          }.to create_an_aws_network_interface('test_network_interface')
+          .and have_aws_network_interface_tags('test_network_interface',
+            {
+              'Name' => 'test_network_interface',
+              'key1' => 'value'
+            }
+          ).and be_idempotent
+        end
+
+        context "with existing tags" do
+          aws_network_interface 'test_network_interface' do
+            subnet 'test_public_subnet'
+            aws_tags key1: "value"
+          end
+
+          it "updates aws_network_interface tags" do
+            expect_recipe {
+              aws_network_interface 'test_network_interface' do
+                subnet 'test_public_subnet'
+                aws_tags key1: "value2", key2: nil
+              end
+            }.to have_aws_network_interface_tags('test_network_interface',
+              {
+                'Name' => 'test_network_interface',
+                'key1' => 'value2',
+                'key2' => ''
+              }
+            ).and be_idempotent
+          end
+
+          it "removes all aws_network_interface tags except Name" do
+            expect_recipe {
+              aws_network_interface 'test_network_interface' do
+                subnet 'test_public_subnet'
+                aws_tags {}
+              end
+            }.to have_aws_network_interface_tags('test_network_interface',
+              {
+                'Name' => 'test_network_interface'
+              }
+            ).and be_idempotent
+          end
+        end
+
+      end
+
+    end
+  end
+end

data/spec/integration/aws_rds_instance_spec.rb

@@ -0,0 +1,150 @@
+require 'spec_helper'
+
+describe Chef::Resource::AwsRdsInstance do
+  extend AWSSupport
+
+  when_the_chef_12_server "exists", organization: 'foo', server_scope: :context do
+    with_aws "with a connection to AWS, a VPC, two subnets, and a db subnet group" do
+
+      azs = []
+      driver.ec2.availability_zones.each do |az|
+        azs << az
+      end
+      az_1 = azs[0].name
+      az_2 = azs[1].name
+
+      aws_vpc "test_vpc" do
+        cidr_block '10.0.5.0/24'
+        internet_gateway true
+      end
+
+      aws_subnet "test_subnet" do
+        vpc 'test_vpc'
+        cidr_block "10.0.5.0/26"
+        availability_zone az_1
+      end
+
+      aws_subnet "test_subnet_2" do
+        vpc 'test_vpc'
+        cidr_block "10.0.5.64/26"
+        availability_zone az_2
+      end
+
+      aws_rds_subnet_group "test-db-subnet-group" do
+        description "some_description"
+        subnets ["test_subnet", test_subnet_2.aws_object.id]
+      end
+
+      it "aws_rds_instance 'test-rds-instance' creates an rds instance that can parse the aws_rds_subnet_group" do
+        expect_recipe {
+          aws_rds_instance "test-rds-instance" do
+            engine "postgres"
+            publicly_accessible false
+            db_instance_class "db.t1.micro"
+            master_username "thechief"
+            master_user_password "securesecure" # 2x security
+            multi_az false
+            allocated_storage 5
+            db_subnet_group_name "test-db-subnet-group"
+          end
+        }.to create_an_aws_rds_instance('test-rds-instance',
+                                        engine: 'postgres',
+                                        multi_az: false,
+                                        db_instance_class: "db.t1.micro",
+                                        master_username: "thechief",
+                                       ).and be_idempotent
+        i = driver.rds.client.describe_db_instances(:db_instance_identifier => "test-rds-instance")[:db_instances].first
+        expect(i[:db_subnet_group][:db_subnet_group_name]).to eq("test-db-subnet-group")
+        expect(i[:publicly_accessible]).to eq(false)
+      end
+
+      it "aws_rds_instance prefers explicit options" do
+        expect_recipe {
+          aws_rds_instance "test-rds-instance2" do
+            engine "postgres"
+            publicly_accessible false
+            db_instance_class "db.t1.micro"
+            master_username "thechief"
+            master_user_password "securesecure"
+            multi_az false
+            allocated_storage 5
+            additional_options(multi_az: true, backup_retention_period: 2)
+          end
+        }.to create_an_aws_rds_instance('test-rds-instance2',
+                                        engine: 'postgres',
+                                        multi_az: false,
+                                        db_instance_class: "db.t1.micro",
+                                        master_username: "thechief",
+                                        backup_retention_period: 2)
+
+      end
+
+      tagging_id = Random.rand(1000)
+
+      it "creates aws_rds_instance tags" do
+        expect_recipe {
+          aws_rds_instance "test-rds-instance-tagging-#{tagging_id}" do
+            aws_tags key1: "value"
+            allocated_storage 5
+            db_instance_class "db.t1.micro"
+            engine "postgres"
+            master_username "thechief"
+            master_user_password "securesecure"
+          end
+        }.to create_an_aws_rds_instance("test-rds-instance-tagging-#{tagging_id}")
+        .and have_aws_rds_instance_tags("test-rds-instance-tagging-#{tagging_id}",
+          {
+            'key1' => 'value'
+          }
+        ).and be_idempotent
+      end
+
+      # if we use let, the tagging_id method is not available in the context block
+      tagging_id = Random.rand(1000)
+
+      context "with existing tags" do
+        aws_rds_instance "test-rds-instance-tagging-#{tagging_id}" do
+          aws_tags key1: "value"
+          allocated_storage 5
+          db_instance_class "db.t1.micro"
+          engine "postgres"
+          master_username "thechief"
+          master_user_password "securesecure"
+        end
+
+        it "updates aws_rds_instance tags" do
+          expect_recipe {
+            aws_rds_instance "test-rds-instance-tagging-#{tagging_id}" do
+              aws_tags key1: "value2", key2: nil
+              allocated_storage 5
+              db_instance_class "db.t1.micro"
+              engine "postgres"
+              master_username "thechief"
+              master_user_password "securesecure"
+            end
+          }.to have_aws_rds_instance_tags("test-rds-instance-tagging-#{tagging_id}",
+            {
+              'key1' => 'value2',
+              'key2' => nil
+            }
+          ).and be_idempotent
+        end
+
+        it "removes all aws_rds_instance tags" do
+          expect_recipe {
+            aws_rds_instance "test-rds-instance-tagging-#{tagging_id}" do
+              aws_tags {}
+              allocated_storage 5
+              db_instance_class "db.t1.micro"
+              engine "postgres"
+              master_username "thechief"
+              master_user_password "securesecure"
+            end
+          }.to have_aws_rds_instance_tags("test-rds-instance-tagging-#{tagging_id}", {}
+          ).and be_idempotent
+        end
+      end
+
+    end
+  end
+end