chef-infra-api 0.10.0 → 0.10.2

data/lib/chef-api/error_collection.rb

@@ -34,7 +34,7 @@ module ChefAPI
     # @return [Array<String>]
     #
     def full_messages
-      self.map do |key, errors|
+      map do |key, errors|
         errors.map do |error|
           "`#{key}' #{error}"
         end

data/lib/chef-api/errors.rb

@@ -1,4 +1,4 @@
-require 'erb'
+require "erb"
 
 module ChefAPI
   module Error
@@ -31,9 +31,9 @@ module ChefAPI
       private
 
       def template
-        class_name = self.class.to_s.split('::').last
+        class_name = self.class.to_s.split("::").last
         filename   = @filename || Util.underscore(class_name)
-        ChefAPI.root.join('templates', 'errors', "#{filename}.erb")
+        ChefAPI.root.join("templates", "errors", "#{filename}.erb")
       end
     end
 

data/lib/chef-api/multipart.rb

@@ -1,9 +1,9 @@
-require 'cgi'
-require 'mime/types'
+require "cgi"
+require "mime/types"
 
 module ChefAPI
   module Multipart
-    BOUNDARY = '------ChefAPIMultipartBoundary'.freeze
+    BOUNDARY = "------ChefAPIMultipartBoundary".freeze
 
     class Body
       def initialize(params = {})
@@ -48,12 +48,12 @@ module ChefAPI
       # Read from IOs in order until `length` bytes have been received.
       def read(length = nil, outbuf = nil)
         got_result = false
-        outbuf = outbuf ? outbuf.replace('') : ''
+        outbuf = outbuf ? outbuf.replace("") : ""
 
         while io = current_io
           if result = io.read(length)
             got_result ||= !result.nil?
-            result.force_encoding('BINARY') if result.respond_to?(:force_encoding)
+            result.force_encoding("BINARY") if result.respond_to?(:force_encoding)
             outbuf << result
             length -= result.length if length
             break if length == 0
@@ -65,7 +65,7 @@ module ChefAPI
       end
 
       def rewind
-        @ios.each { |io| io.rewind }
+        @ios.each(&:rewind)
         @index = 0
       end
 
@@ -99,9 +99,9 @@ module ChefAPI
       private
 
       def build(name, value)
-        part =  %|--#{BOUNDARY}\r\n|
-        part << %|Content-Disposition: form-data; name="#{CGI.escape(name)}"\r\n\r\n|
-        part << %|#{value}\r\n|
+        part =  %{--#{BOUNDARY}\r\n}
+        part << %{Content-Disposition: form-data; name="#{CGI.escape(name)}"\r\n\r\n}
+        part << %{#{value}\r\n}
         part
       end
     end
@@ -132,14 +132,14 @@ module ChefAPI
 
       def build(name, file)
         filename  = File.basename(file.path)
-        mime_type = MIME::Types.type_for(filename)[0] || MIME::Types['application/octet-stream'][0]
-
-        part =  %|--#{BOUNDARY}\r\n|
-        part << %|Content-Disposition: form-data; name="#{CGI.escape(name)}"; filename="#{filename}"\r\n|
-        part << %|Content-Length: #{file.size}\r\n|
-        part << %|Content-Type: #{mime_type.simplified}\r\n|
-        part << %|Content-Transfer-Encoding: binary\r\n|
-        part << %|\r\n|
+        mime_type = MIME::Types.type_for(filename)[0] || MIME::Types["application/octet-stream"][0]
+
+        part =  %{--#{BOUNDARY}\r\n}
+        part << %{Content-Disposition: form-data; name="#{CGI.escape(name)}"; filename="#{filename}"\r\n}
+        part << %{Content-Length: #{file.size}\r\n}
+        part << %{Content-Type: #{mime_type.simplified}\r\n}
+        part << %{Content-Transfer-Encoding: binary\r\n}
+        part << %{\r\n}
         part
       end
     end

data/lib/chef-api/resource.rb

@@ -1,21 +1,21 @@
-require "chef-api/aclable"
+require_relative "aclable"
 module ChefAPI
   module Resource
-    autoload :Base,            'chef-api/resources/base'
-    autoload :Client,          'chef-api/resources/client'
-    autoload :CollectionProxy, 'chef-api/resources/collection_proxy'
-    autoload :Cookbook,        'chef-api/resources/cookbook'
-    autoload :CookbookVersion, 'chef-api/resources/cookbook_version'
-    autoload :DataBag,         'chef-api/resources/data_bag'
-    autoload :DataBagItem,     'chef-api/resources/data_bag_item'
-    autoload :Environment,     'chef-api/resources/environment'
-    autoload :Group,           'chef-api/resources/group'
-    autoload :Node,            'chef-api/resources/node'
-    autoload :Organization,    'chef-api/resources/organization'
-    autoload :PartialSearch,   'chef-api/resources/partial_search'
-    autoload :Principal,       'chef-api/resources/principal'
-    autoload :Role,            'chef-api/resources/role'
-    autoload :Search,          'chef-api/resources/search'
-    autoload :User,            'chef-api/resources/user'
+    autoload :Base,            "chef-api/resources/base"
+    autoload :Client,          "chef-api/resources/client"
+    autoload :CollectionProxy, "chef-api/resources/collection_proxy"
+    autoload :Cookbook,        "chef-api/resources/cookbook"
+    autoload :CookbookVersion, "chef-api/resources/cookbook_version"
+    autoload :DataBag,         "chef-api/resources/data_bag"
+    autoload :DataBagItem,     "chef-api/resources/data_bag_item"
+    autoload :Environment,     "chef-api/resources/environment"
+    autoload :Group,           "chef-api/resources/group"
+    autoload :Node,            "chef-api/resources/node"
+    autoload :Organization,    "chef-api/resources/organization"
+    autoload :PartialSearch,   "chef-api/resources/partial_search"
+    autoload :Principal,       "chef-api/resources/principal"
+    autoload :Role,            "chef-api/resources/role"
+    autoload :Search,          "chef-api/resources/search"
+    autoload :User,            "chef-api/resources/user"
   end
 end

data/lib/chef-api/resources/base.rb

@@ -13,7 +13,7 @@ module ChefAPI
       #   the path to the file on disk
       #
       def from_file(path)
-        raise Error::AbstractMethod.new(method: 'Resource::Base#from_file')
+        raise Error::AbstractMethod.new(method: "Resource::Base#from_file")
       end
 
       #
@@ -78,7 +78,7 @@ module ChefAPI
       #   has_many :environments, class_name: 'Environment'
       #
       def has_many(method, options = {})
-        class_name    = options[:class_name] || "Resource::#{Util.camelize(method).sub(/s$/, '')}"
+        class_name    = options[:class_name] || "Resource::#{Util.camelize(method).sub(/s$/, "")}"
         rest_endpoint = options[:rest_endpoint] || method
 
         class_eval <<-EOH, __FILE__, __LINE__ + 1
@@ -227,7 +227,7 @@ module ChefAPI
       #   an array containing the list of resources that were deleted
       #
       def destroy_all(prefix = {})
-        map { |resource| resource.destroy }
+        map(&:destroy)
       end
 
       #
@@ -404,8 +404,8 @@ module ChefAPI
       #   an instance of the resource represented by this JSON
       #
       def from_json(response, prefix = {})
-        response.delete('json_class')
-        response.delete('chef_type')
+        response.delete("json_class")
+        response.delete("chef_type")
 
         new(response, prefix)
       end
@@ -432,7 +432,7 @@ module ChefAPI
       # @return [String]
       #
       def inspect
-        "#{classname}(#{schema.attributes.keys.join(', ')})"
+        "#{classname}(#{schema.attributes.keys.join(", ")})"
       end
 
       #
@@ -444,7 +444,7 @@ module ChefAPI
       # @return [String]
       #
       def classname
-        name.split('::')[1..-1].join('::')
+        name.split("::")[1..-1].join("::")
       end
 
       #
@@ -456,7 +456,7 @@ module ChefAPI
       # @return [String]
       #
       def type
-        Util.underscore(name.split('::').last).gsub('_', ' ')
+        Util.underscore(name.split("::").last).gsub("_", " ")
       end
 
       #
@@ -482,7 +482,7 @@ module ChefAPI
       #   the path to the resource
       #
       def resource_path(id, prefix = {})
-        [expanded_collection_path(prefix), id].join('/')
+        [expanded_collection_path(prefix), id].join("/")
       end
 
       #
@@ -505,7 +505,7 @@ module ChefAPI
       #
       def expanded_collection_path(prefix = {})
         collection_path.gsub(/:\w+/) do |param|
-          key = param.delete(':')
+          key = param.delete(":")
           value = prefix[key] || prefix[key.to_sym]
 
           if value.nil?
@@ -513,7 +513,7 @@ module ChefAPI
           end
 
           URI.escape(value)
-        end.sub(/^\//, '') # Remove leading slash
+        end.sub(%r{^/}, "") # Remove leading slash
       end
 
       #
@@ -522,7 +522,7 @@ module ChefAPI
       # @return [ChefAPI::Connection]
       #
       def connection
-        Thread.current['chefapi.connection'] || ChefAPI.connection
+        Thread.current["chefapi.connection"] || ChefAPI.connection
       end
     end
 
@@ -620,7 +620,7 @@ module ChefAPI
     #   true if the attribute exists, false otherwise
     #
     def attribute?(key)
-      _attributes.has_key?(key.to_sym)
+      _attributes.key?(key.to_sym)
     end
 
     #
@@ -633,12 +633,12 @@ module ChefAPI
     #
     def protected?
       @protected ||= self.class.protected_resources.any? do |thing|
-                       if thing.is_a?(Proc)
-                         thing.call(self)
-                       else
-                         id == thing
-                       end
-                     end
+        if thing.is_a?(Proc)
+          thing.call(self)
+        else
+          id == thing
+        end
+      end
     end
 
     #
@@ -775,7 +775,7 @@ module ChefAPI
     #
     def validate!
       unless valid?
-        sentence = errors.full_messages.join(', ')
+        sentence = errors.full_messages.join(", ")
         raise Error::InvalidResource.new(errors: sentence)
       end
 
@@ -896,7 +896,7 @@ module ChefAPI
     # @return [Boolean]
     #
     def ignore_attribute?(key)
-      @schema.ignored_attributes.has_key?(key.to_sym)
+      @schema.ignored_attributes.key?(key.to_sym)
     end
 
     #
@@ -954,7 +954,7 @@ module ChefAPI
         end
       end
 
-      "#<#{self.class.classname} #{attrs.join(', ')}>"
+      "#<#{self.class.classname} #{attrs.join(", ")}>"
     end
   end
 end

data/lib/chef-api/resources/client.rb

@@ -1,7 +1,7 @@
 module ChefAPI
   class Resource::Client < Resource::Base
     include ChefAPI::AclAble
-    collection_path '/clients'
+    collection_path "/clients"
 
     schema do
       attribute :name,        type: String,  primary: true, required: true
@@ -14,7 +14,7 @@ module ChefAPI
     end
 
     # @todo implement
-    protect 'chef-webui', 'chef-validator'
+    protect "chef-webui", "chef-validator"
 
     class << self
       #
@@ -49,7 +49,7 @@ module ChefAPI
     #
     def initialize(attributes = {}, prefix = {})
       if certificate = attributes.delete(:certificate) ||
-                       attributes.delete('certificate')
+          attributes.delete("certificate")
         x509 = OpenSSL::X509::Certificate.new(certificate)
         attributes[:public_key] = x509.public_key.to_pem
       end
@@ -77,6 +77,7 @@ module ChefAPI
     #
     def regenerate_keys
       raise Error::CannotRegenerateKey if new_resource?
+
       update(private_key: true).save!
       self
     end

data/lib/chef-api/resources/collection_proxy.rb

@@ -59,6 +59,7 @@ module ChefAPI
     #
     def fetch(id)
       return nil unless exists?(id)
+
       cached(id) { klass.from_url(get(id), prefix) }
     end
 
@@ -76,7 +77,7 @@ module ChefAPI
     #   true if the resource exists, false otherwise
     #
     def exists?(id)
-      collection.has_key?(id.to_s)
+      collection.key?(id.to_s)
     end
 
     #
@@ -131,9 +132,9 @@ module ChefAPI
     def inspect
       objects = collection
         .map { |id, _| cached(id) || klass.new(klass.schema.primary_key => id) }
-        .map { |object| object.to_s }
+        .map(&:to_s)
 
-      "#<#{self.class.name} [#{objects.join(', ')}]>"
+      "#<#{self.class.name} [#{objects.join(", ")}]>"
     end
 
     private

data/lib/chef-api/resources/cookbook.rb

@@ -5,7 +5,7 @@ module ChefAPI
   # of +cookbook_version+ objects that fully detail the layout of a cookbook.
   #
   class Resource::Cookbook < Resource::Base
-    collection_path '/cookbooks'
+    collection_path "/cookbooks"
 
     schema do
       attribute :name, type: String, primary: true, required: true
@@ -13,7 +13,7 @@ module ChefAPI
 
     has_many :versions,
       class_name: CookbookVersion,
-      rest_endpoint: '/?num_versions=all'
+      rest_endpoint: "/?num_versions=all"
 
     class << self
       def from_json(response, prefix = {})

data/lib/chef-api/resources/cookbook_version.rb

@@ -1,6 +1,6 @@
 module ChefAPI
   class Resource::CookbookVersion < Resource::Base
-    collection_path '/cookbooks/:cookbook'
+    collection_path "/cookbooks/:cookbook"
 
     schema do
       attribute :name,          type: String,  primary: true, required: true

data/lib/chef-api/resources/data_bag.rb

@@ -1,6 +1,6 @@
 module ChefAPI
   class Resource::DataBag < Resource::Base
-    collection_path '/data'
+    collection_path "/data"
 
     schema do
       attribute :name, type: String, primary: true, required: true
@@ -26,9 +26,9 @@ module ChefAPI
       # @return [Array<DataBagItem>]
       #
       def from_file(path, name = File.basename(path))
-        path  = File.expand_path(path)
+        path = File.expand_path(path)
 
-        raise Error::FileNotFound.new(path: path)  unless File.exists?(path)
+        raise Error::FileNotFound.new(path: path)  unless File.exist?(path)
         raise Error::NotADirectory.new(path: path) unless File.directory?(path)
 
         raise ArgumentError unless File.directory?(path)

data/lib/chef-api/resources/data_bag_item.rb

@@ -1,6 +1,6 @@
 module ChefAPI
   class Resource::DataBagItem < Resource::Base
-    collection_path '/data/:bag'
+    collection_path "/data/:bag"
 
     schema do
       attribute :id,   type: String, primary: true, required: true
@@ -28,11 +28,10 @@ module ChefAPI
     def initialize(attributes = {}, prefix = {}, bag = nil)
       @bag = bag || Resource::DataBag.fetch(prefix[:bag])
 
-      id = attributes.delete(:id) || attributes.delete('id')
+      id = attributes.delete(:id) || attributes.delete("id")
       super({ id: id, data: attributes }, prefix)
     end
 
-
     #
     # Override the to_hash method to move data to the upper scope.
     #

data/lib/chef-api/resources/environment.rb

@@ -1,6 +1,6 @@
 module ChefAPI
   class Resource::Environment < Resource::Base
-    collection_path '/environments'
+    collection_path "/environments"
 
     schema do
       attribute :name,                type: String, primary: true, required: true

data/lib/chef-api/resources/group.rb

@@ -1,6 +1,6 @@
 module ChefAPI
   class Resource::Group < Resource::Base
-    collection_path '/groups'
+    collection_path "/groups"
 
     schema do
       attribute :groupname, type: String, primary: true, required: true
@@ -13,4 +13,3 @@ module ChefAPI
     end
   end
 end
-

data/lib/chef-api/resources/node.rb

@@ -1,7 +1,7 @@
 module ChefAPI
   class Resource::Node < Resource::Base
     include ChefAPI::AclAble
-    collection_path '/nodes'
+    collection_path "/nodes"
 
     schema do
       attribute :name,         type: String, primary: true, required: true
@@ -14,7 +14,7 @@ module ChefAPI
       attribute :policy_group, type: String
 
       # Enterprise Chef attributes
-      attribute :chef_environment, type: String, default: '_default'
+      attribute :chef_environment, type: String, default: "_default"
     end
   end
 end