chef-dk 2.3.4 → 2.4.17

data/spec/unit/policyfile/cookbook_location_specification_spec.rb

@@ -278,6 +278,16 @@ describe ChefDK::Policyfile::CookbookLocationSpecification do
 
     let(:source_options) { { chef_server: "https://api.opscode.com/organizations/chef-oss-dev/cookbooks/my_cookbook/versions/2.0.0/download" } }
 
+    let(:http_client) { instance_double("ChefDK::ChefServerAPIMulti") }
+
+    before do
+      CookbookOmnifetch.integration.default_chef_server_http_client = http_client
+    end
+
+    after do
+      CookbookOmnifetch.integration.default_chef_server_http_client = nil
+    end
+
     it "has a chef_server installer" do
       expect(cookbook_location_spec.installer).to be_a_kind_of(CookbookOmnifetch::ChefServerLocation)
     end
@@ -296,4 +306,42 @@ describe ChefDK::Policyfile::CookbookLocationSpecification do
     end
 
   end
+
+  describe "when created with a chef_server_artifact source" do
+
+    let(:source_options) do
+      {
+        chef_server_artifact: "https://api.opscode.com/organizations/chef-oss-dev/",
+        identifier: "09d43fad354b3efcc5b5836fef5137131f60f974",
+      }
+    end
+
+    let(:http_client) { instance_double("ChefDK::ChefServerAPIMulti") }
+
+    before do
+      CookbookOmnifetch.integration.default_chef_server_http_client = http_client
+    end
+
+    after do
+      CookbookOmnifetch.integration.default_chef_server_http_client = nil
+    end
+
+    it "has a chef_server_artifact installer" do
+      expect(cookbook_location_spec.installer).to be_a_kind_of(CookbookOmnifetch::ChefServerArtifactLocation)
+    end
+
+    it "does has a fixed version" do
+      expect(cookbook_location_spec.version_fixed?).to be(true)
+    end
+
+    it "is a mirror of a canonical upstream" do
+      expect(cookbook_location_spec.mirrors_canonical_upstream?).to be(true)
+    end
+
+    it "is valid" do
+      expect(cookbook_location_spec.errors.size).to eq(0)
+      expect(cookbook_location_spec).to be_valid
+    end
+
+  end
 end

data/spec/unit/policyfile/included_policies_cookbook_source_spec.rb

@@ -0,0 +1,242 @@
+#
+# Copyright:: Copyright (c) 2017 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "chef-dk/policyfile/included_policies_cookbook_source"
+require "chef-dk/policyfile/policyfile_location_specification"
+
+describe ChefDK::Policyfile::IncludedPoliciesCookbookSource do
+
+  let(:external_cookbook_universe) do
+    {
+      "cookbookA" => {
+        "1.0.0" => [ ],
+        "2.0.0" => [ ["cookbookB", "= 1.0.0" ] ],
+      },
+      "cookbookB" => {
+        "1.0.0" => [ ],
+      },
+      "cookbookC" => {
+        "1.0.0" => [ ],
+        "2.0.0" => [ ],
+      },
+    }
+  end
+
+  let(:policy1_cookbooks) do
+    [
+      {
+        name: "cookbookA",
+        version: "2.0.0",
+      },
+      # cookbookB because cookbookA depends on it
+      {
+        name: "cookbookB",
+        version: "1.0.0",
+      },
+    ]
+  end
+
+  let(:randomize_sources) { false }
+  let(:add_random_cookbook) { false }
+
+  def build_lockdata(cookbooks)
+    nonce = if randomize_sources
+              Random.rand
+            else
+              nil
+            end
+
+    cookbook_locks = cookbooks.inject({}) do |acc, cookbook_info|
+      acc[cookbook_info[:name]] = {
+        "version" => cookbook_info[:version],
+        "identifier" => "identifier",
+        "dotted_decimal_identifier" => "dotted_decimal_identifier",
+        "cache_key" => "#{cookbook_info[:name]}-#{cookbook_info[:version]}",
+        "origin" => "uri",
+        "source_options" => { "version" => cookbook_info[:version] }.tap do |so|
+          so["nonce"] = nonce if !nonce.nil?
+        end,
+      }
+      acc
+    end
+
+    solution_dependencies_lock = cookbooks.map do |cookbook_info|
+      [cookbook_info[:name], cookbook_info[:version]]
+    end
+
+    solution_dependencies_cookbooks = cookbooks.inject({}) do |acc, cookbook_info|
+      acc["#{cookbook_info[:name]} (#{cookbook_info[:version]})"] = external_cookbook_universe[cookbook_info[:name]][cookbook_info[:version]]
+      acc
+    end
+
+    {
+      "name" => "included_policyfile",
+      "revision_id" => "myrevisionid",
+      "run_list" => ["recipe[myrunlist::default]"],
+      "cookbook_locks" => cookbook_locks,
+      "default_attributes" => {},
+      "override_attributes" => {},
+      "solution_dependencies" => {
+        "Policyfile" => solution_dependencies_lock,
+        ## We dont use dependencies, no need to fill it out
+        "dependencies" => solution_dependencies_cookbooks,
+      },
+    }
+  end
+
+  let(:policy1_lockdata) do
+    build_lockdata(policy1_cookbooks)
+  end
+
+  let(:policy2_lockdata) do
+    build_lockdata(policy2_cookbooks)
+  end
+
+  let(:policy1_fetcher) do
+    instance_double("ChefDK::Policyfile::LocalLockFetcher").tap do |double|
+      allow(double).to receive(:lock_data).and_return(policy1_lockdata)
+      allow(double).to receive(:valid?).and_return(true)
+      allow(double).to receive(:errors).and_return([])
+    end
+  end
+
+  let(:policy2_fetcher) do
+    instance_double("ChefDK::Policyfile::LocalLockFetcher").tap do |double|
+      allow(double).to receive(:lock_data).and_return(policy2_lockdata)
+      allow(double).to receive(:valid?).and_return(true)
+      allow(double).to receive(:errors).and_return([])
+    end
+  end
+
+  let(:policy1_location_spec) do
+    ChefDK::Policyfile::PolicyfileLocationSpecification.new("policy1", { :path => "somelocation" }, nil).tap do |spec|
+      allow(spec).to receive(:valid?).and_return(true)
+      allow(spec).to receive(:fetcher).and_return(policy1_fetcher)
+    end
+  end
+
+  let(:policy2_location_spec) do
+    ChefDK::Policyfile::PolicyfileLocationSpecification.new("policy2", { :path => "somelocation" }, nil).tap do |spec|
+      allow(spec).to receive(:valid?).and_return(true)
+      allow(spec).to receive(:fetcher).and_return(policy2_fetcher)
+    end
+  end
+
+  let(:policies) { [] }
+
+  let(:cookbook_source) { ChefDK::Policyfile::IncludedPoliciesCookbookSource.new(policies) }
+
+  context "when no policies are included" do
+    it "returns false for preferred_source_for" do
+      expect(cookbook_source.preferred_source_for?("foo")).to eq(false)
+    end
+
+    it "has an empty universe" do
+      expect(cookbook_source.universe_graph).to eq({})
+    end
+  end
+
+  context "when a single policy is to be included" do
+    let(:policies) { [policy1_location_spec] }
+
+    it "does not have a preferred source for unlocked cookbooks" do
+      expect(cookbook_source.preferred_source_for?("cookbookC")).to eq(false)
+    end
+
+    it "has a preferred source for the included cookbooks" do
+      expect(cookbook_source.preferred_source_for?("cookbookA")).to eq(true)
+      expect(cookbook_source.preferred_source_for?("cookbookB")).to eq(true)
+    end
+
+    it "returns nil for the source options versions not included" do
+      expect(cookbook_source.source_options_for("cookbookA", "1.0.0")).to eq(nil)
+    end
+
+    it "returns the correct source options when the cookbook is included" do
+      expect(cookbook_source.source_options_for("cookbookA", "2.0.0")).to eq({ :version => "2.0.0" })
+      expect(cookbook_source.source_options_for("cookbookB", "1.0.0")).to eq({ :version => "1.0.0" })
+    end
+
+    it "has a universe with the used cookbooks" do
+      expect(cookbook_source.universe_graph).to eq({
+        "cookbookA" => {
+          "2.0.0" => external_cookbook_universe["cookbookA"]["2.0.0"],
+        },
+        "cookbookB" => {
+          "1.0.0" => external_cookbook_universe["cookbookB"]["1.0.0"],
+        },
+      })
+    end
+  end
+
+  context "when multiple policies are to be included" do
+    let(:policies) { [policy1_location_spec, policy2_location_spec] }
+
+    context "when the policies use the same cookbooks with the same versions and sources" do
+      let(:policy2_cookbooks) { policy1_cookbooks + [{ name: "cookbookC", version: "2.0.0" }] }
+
+      it "has a preferred source for the included cookbooks" do
+        expect(cookbook_source.preferred_source_for?("cookbookA")).to eq(true)
+        expect(cookbook_source.preferred_source_for?("cookbookB")).to eq(true)
+        expect(cookbook_source.preferred_source_for?("cookbookC")).to eq(true)
+      end
+
+      it "returns the correct source options when the cookbook is included" do
+        expect(cookbook_source.source_options_for("cookbookA", "2.0.0")).to eq({ :version => "2.0.0" })
+        expect(cookbook_source.source_options_for("cookbookB", "1.0.0")).to eq({ :version => "1.0.0" })
+      end
+
+      it "has a universe with the used cookbooks" do
+        expect(cookbook_source.universe_graph).to eq({
+          "cookbookA" => {
+            "2.0.0" => external_cookbook_universe["cookbookA"]["2.0.0"],
+          },
+          "cookbookB" => {
+            "1.0.0" => external_cookbook_universe["cookbookB"]["1.0.0"],
+          },
+          "cookbookC" => {
+            "2.0.0" => external_cookbook_universe["cookbookC"]["2.0.0"],
+          },
+        })
+      end
+    end
+
+    context "when the policies have the same versions with conflicting sources" do
+      let(:randomize_sources) { true }
+      let(:policy2_cookbooks) { policy1_cookbooks }
+
+      it "raises an error when check_for_conflicts! is called" do
+        expect { cookbook_source.check_for_conflicts! }.to raise_error(
+          ChefDK::Policyfile::IncludedPoliciesCookbookSource::ConflictingCookbookSources)
+      end
+    end
+
+    context "when the policies have conflicting versions" do
+      let(:policy2_cookbooks) { [{ name: "cookbookA", version: "1.0.0" }] }
+
+      it "raises an error when check_for_conflicts! is called" do
+        expect { cookbook_source.check_for_conflicts! }.to raise_error(
+          ChefDK::Policyfile::IncludedPoliciesCookbookSource::ConflictingCookbookVersions)
+      end
+    end
+
+    context "when the policies have conflicting dependencies" do
+      it "raises an error when check_for_conflicts! is called"
+    end
+  end
+end

data/spec/unit/policyfile/local_lock_fetcher_spec.rb

@@ -0,0 +1,161 @@
+#
+# Copyright:: Copyright (c) 2017 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "chef-dk/policyfile/local_lock_fetcher"
+
+describe ChefDK::Policyfile::LocalLockFetcher do
+
+  let(:minimal_lockfile_json) do
+    <<-E
+{
+  "revision_id": "6fe753184c8946052d3231bb4212116df28d89a3a5f7ae52832ad408419dd5eb",
+  "name": "install-example",
+  "run_list": [
+    "recipe[local-cookbook::default]"
+  ],
+  "cookbook_locks": {
+    "local-cookbook": {
+      "version": "2.3.4",
+      "identifier": "fab501cfaf747901bd82c1bc706beae7dc3a350c",
+      "dotted_decimal_identifier": "70567763561641081.489844270461035.258281553147148",
+      "source": "cookbooks/local-cookbook",
+      "cache_key": null,
+      "scm_info": null,
+      "source_options": {
+        "path": "../cookbooks/local-cookbook"
+      }
+    }
+  },
+  "default_attributes": {},
+  "override_attributes": {},
+  "solution_dependencies": {
+    "Policyfile": [
+      [
+        "local-cookbook",
+        ">= 0.0.0"
+      ]
+    ],
+    "dependencies": {
+      "local-cookbook (2.3.4)": [
+
+      ]
+    }
+  }
+}
+E
+  end
+
+  let(:lock_file_path) { "#{tempdir}/foo/bar/baz/foo.lock.json" }
+  let(:storage_config) { ChefDK::Policyfile::StorageConfig.new.use_policyfile("#{tempdir}/Policyfile.rb") }
+
+  before do
+    reset_tempdir
+    FileUtils.mkdir_p(Pathname.new(lock_file_path).dirname)
+    File.open(lock_file_path, "w") { |file| file.write(minimal_lockfile_json) }
+  end
+
+  after do
+    reset_tempdir
+  end
+
+  def minimal_lockfile
+    FFI_Yajl::Parser.parse(minimal_lockfile_json)
+  end
+
+  let(:minimal_lockfile_modified) do
+    minimal_lockfile.tap do |lockfile|
+      lockfile["cookbook_locks"]["local-cookbook"]["source_options"] = { "path" => "foo/bar/cookbooks/local-cookbook" }
+    end
+  end
+
+  subject(:fetcher) { described_class.new("foo", source_options, storage_config) }
+
+  context "when the path is a file" do
+    context "and the file exists" do
+      let(:source_options) do
+        {
+          path: lock_file_path,
+        }
+      end
+
+      let(:source_options_for_lock) { source_options }
+
+      it "loads the policy from disk" do
+        expect(fetcher.lock_data).to eq(minimal_lockfile_modified)
+      end
+
+      it "returns source_options_for_lock" do
+        expect(fetcher.source_options).to eq(source_options)
+      end
+
+      it "applies can apply source options from the lock" do
+        fetcher.apply_locked_source_options(source_options_for_lock)
+        expect(fetcher.lock_data).to eq(minimal_lockfile_modified)
+      end
+    end
+
+    context "and the file does not exist" do
+      let(:source_options) do
+        {
+          path: Pathname.new(lock_file_path).dirname.join("dne.json.lock").to_s,
+        }
+      end
+
+      it "raises an error" do
+        expect { fetcher.lock_data }.to raise_error(ChefDK::LocalPolicyfileLockNotFound)
+      end
+    end
+  end
+
+  context "when the path is a directory" do
+    context "and the file exists" do
+      let(:source_options) do
+        {
+          path: Pathname.new(lock_file_path).dirname.to_s,
+        }
+      end
+
+      let(:source_options_for_lock) { source_options }
+
+      it "loads the policy from disk" do
+        expect(fetcher.lock_data).to eq(minimal_lockfile_modified)
+      end
+
+      it "returns source_options_for_lock" do
+        expect(fetcher.source_options).to eq(source_options)
+      end
+
+      it "applies can apply source options from the lock" do
+        fetcher.apply_locked_source_options(source_options_for_lock)
+        expect(fetcher.lock_data).to eq(minimal_lockfile_modified)
+      end
+    end
+
+    context "and the file does not exist" do
+      let(:source_options) do
+        {
+          path: Pathname.new(lock_file_path).dirname.parent.to_s,
+        }
+      end
+
+      it "raises an error" do
+        expect { fetcher.lock_data }.to raise_error(ChefDK::LocalPolicyfileLockNotFound, /provide the file name as part of the path/)
+      end
+    end
+  end
+end