chef-dk 1.2.22 → 1.3.40

data/spec/unit/command/clean_policy_revisions_spec.rb

@@ -15,9 +15,9 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'shared/command_with_ui_object'
-require 'chef-dk/command/clean_policy_revisions'
+require "spec_helper"
+require "shared/command_with_ui_object"
+require "chef-dk/command/clean_policy_revisions"
 
 describe ChefDK::Command::CleanPolicyRevisions do
 
@@ -50,7 +50,7 @@ describe ChefDK::Command::CleanPolicyRevisions do
 
     context "when given a path to the config" do
 
-      let(:params) { %w[ -c ~/otherstuff/config.rb ] }
+      let(:params) { %w{ -c ~/otherstuff/config.rb } }
 
       let(:config_arg) { "~/otherstuff/config.rb" }
 
@@ -105,7 +105,7 @@ describe ChefDK::Command::CleanPolicyRevisions do
 
     context "when given too many arguments" do
 
-      let(:params) { %w[ wut-is-this ] }
+      let(:params) { %w{ wut-is-this } }
 
       it "shows usage and exits" do
         expect(command.run(params)).to eq(1)
@@ -134,7 +134,7 @@ describe ChefDK::Command::CleanPolicyRevisions do
       it "prints a debugging message and exits non-zero" do
         expect(command.run([])).to eq(1)
 
-        expected_output=<<-E
+        expected_output = <<-E
 Error: Failed to delete some policy revisions.
 Reason: (StandardError) some operation failed
 
@@ -147,9 +147,9 @@ E
 
         it "includes the backtrace in the error" do
 
-          command.run(%w[ -D ])
+          command.run(%w{ -D })
 
-          expected_output=<<-E
+          expected_output = <<-E
 Error: Failed to delete some policy revisions.
 Reason: (StandardError) some operation failed
 
@@ -178,4 +178,3 @@ E
 
   end
 end
-

data/spec/unit/command/delete_policy_group_spec.rb

@@ -15,9 +15,9 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'shared/command_with_ui_object'
-require 'chef-dk/command/delete_policy_group'
+require "spec_helper"
+require "shared/command_with_ui_object"
+require "chef-dk/command/delete_policy_group"
 
 describe ChefDK::Command::DeletePolicyGroup do
 
@@ -67,7 +67,7 @@ describe ChefDK::Command::DeletePolicyGroup do
 
     context "when given a path to the config" do
 
-      let(:params) { base_params + %w[ -c ~/otherstuff/config.rb ] }
+      let(:params) { base_params + %w{ -c ~/otherstuff/config.rb } }
 
       let(:config_arg) { "~/otherstuff/config.rb" }
 
@@ -122,7 +122,7 @@ describe ChefDK::Command::DeletePolicyGroup do
 
     context "when given too few arguments" do
 
-      let(:params) { %w[ ] }
+      let(:params) { %w{ } }
 
       it "shows usage and exits" do
         expect(command.run(params)).to eq(1)
@@ -132,7 +132,7 @@ describe ChefDK::Command::DeletePolicyGroup do
 
     context "when given too many arguments" do
 
-      let(:params) { %w[ policygroup wut-is-this ] }
+      let(:params) { %w{ policygroup wut-is-this } }
 
       it "shows usage and exits" do
         expect(command.run(params)).to eq(1)
@@ -159,9 +159,9 @@ describe ChefDK::Command::DeletePolicyGroup do
       end
 
       it "prints a debugging message and exits non-zero" do
-        expect(command.run(%w[example-policy-group])).to eq(1)
+        expect(command.run(%w{example-policy-group})).to eq(1)
 
-        expected_output=<<-E
+        expected_output = <<-E
 Error: Failed to delete policy group
 Reason: (StandardError) some operation failed
 
@@ -173,9 +173,9 @@ E
       context "when debug is enabled" do
 
         it "includes the backtrace in the error" do
-          command.run(%w[ example-policy-group -D ])
+          command.run(%w{ example-policy-group -D })
 
-          expected_output=<<-E
+          expected_output = <<-E
 Error: Failed to delete policy group
 Reason: (StandardError) some operation failed
 
@@ -197,11 +197,10 @@ E
       end
 
       it "exits 0" do
-        expect(command.run(%w[example-policy-group])).to eq(0)
+        expect(command.run(%w{example-policy-group})).to eq(0)
       end
 
     end
 
   end
 end
-

data/spec/unit/command/delete_policy_spec.rb

@@ -15,9 +15,9 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'shared/command_with_ui_object'
-require 'chef-dk/command/delete_policy'
+require "spec_helper"
+require "shared/command_with_ui_object"
+require "chef-dk/command/delete_policy"
 
 describe ChefDK::Command::DeletePolicy do
 
@@ -67,7 +67,7 @@ describe ChefDK::Command::DeletePolicy do
 
     context "when given a path to the config" do
 
-      let(:params) { base_params + %w[ -c ~/otherstuff/config.rb ] }
+      let(:params) { base_params + %w{ -c ~/otherstuff/config.rb } }
 
       let(:config_arg) { "~/otherstuff/config.rb" }
 
@@ -122,7 +122,7 @@ describe ChefDK::Command::DeletePolicy do
 
     context "when given too few arguments" do
 
-      let(:params) { %w[ ] }
+      let(:params) { %w{ } }
 
       it "shows usage and exits" do
         expect(command.run(params)).to eq(1)
@@ -132,7 +132,7 @@ describe ChefDK::Command::DeletePolicy do
 
     context "when given too many arguments" do
 
-      let(:params) { %w[ a-policy-name wut-is-this ] }
+      let(:params) { %w{ a-policy-name wut-is-this } }
 
       it "shows usage and exits" do
         expect(command.run(params)).to eq(1)
@@ -159,9 +159,9 @@ describe ChefDK::Command::DeletePolicy do
       end
 
       it "prints a debugging message and exits non-zero" do
-        expect(command.run(%w[example-policy])).to eq(1)
+        expect(command.run(%w{example-policy})).to eq(1)
 
-        expected_output=<<-E
+        expected_output = <<-E
 Error: Failed to delete policy.
 Reason: (StandardError) some operation failed
 
@@ -173,9 +173,9 @@ E
       context "when debug is enabled" do
 
         it "includes the backtrace in the error" do
-          command.run(%w[ example-policy -D ])
+          command.run(%w{ example-policy -D })
 
-          expected_output=<<-E
+          expected_output = <<-E
 Error: Failed to delete policy.
 Reason: (StandardError) some operation failed
 
@@ -197,11 +197,10 @@ E
       end
 
       it "exits 0" do
-        expect(command.run(%w[example-policy])).to eq(0)
+        expect(command.run(%w{example-policy})).to eq(0)
       end
 
     end
 
   end
 end
-

data/spec/unit/command/diff_spec.rb

@@ -15,10 +15,10 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'shared/command_with_ui_object'
-require 'chef-dk/command/diff'
-require 'chef-dk/service_exceptions'
+require "spec_helper"
+require "shared/command_with_ui_object"
+require "chef-dk/command/diff"
+require "chef-dk/service_exceptions"
 
 describe ChefDK::Command::Diff do
 
@@ -239,7 +239,7 @@ describe ChefDK::Command::Diff do
 
       context "when the local lockfile can be read and parsed" do
         before do
-          allow(local_lock_comparison_base).to receive(:lock).and_return({"name" => "example-policy"})
+          allow(local_lock_comparison_base).to receive(:lock).and_return({ "name" => "example-policy" })
           allow(command).to receive(:differ).and_return(differ)
           command.ui = ui
         end
@@ -309,4 +309,3 @@ describe ChefDK::Command::Diff do
     end
   end
 end
-

data/spec/unit/command/env_spec.rb

@@ -15,9 +15,9 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'yaml'
-require 'chef-dk/command/env'
+require "spec_helper"
+require "yaml"
+require "chef-dk/command/env"
 
 describe ChefDK::Command::Env do
   let(:ui) { TestHelpers::TestUI.new }
@@ -25,7 +25,7 @@ describe ChefDK::Command::Env do
 
   let(:command_options) { [] }
 
-  let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, 'bin')) }
+  let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, "bin")) }
   let(:omnibus_embedded_bin_dir) { "/foo/embedded/bin" }
   let(:omnibus_bin_dir) { "/foo/bin" }
 
@@ -46,7 +46,7 @@ describe ChefDK::Command::Env do
   describe "when running env command" do
     it "should return valid yaml" do
       run_command
-      expect{ YAML.load(ui.output) }.not_to raise_error
+      expect { YAML.load(ui.output) }.not_to raise_error
     end
   end
 end

data/spec/unit/command/exec_spec.rb

@@ -15,8 +15,8 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'chef-dk/command/exec'
+require "spec_helper"
+require "chef-dk/command/exec"
 
 describe ChefDK::Command::Exec do
   let(:command_instance) { ChefDK::Command::Exec.new() }
@@ -43,13 +43,13 @@ describe ChefDK::Command::Exec do
     end
 
     it "should raise OmnibusInstallNotFound if directory is not looking like omnibus" do
-      allow(Gem).to receive(:ruby).and_return(File.join(fixtures_path,".rbenv/versions/2.1.1/bin/ruby"))
-      expect{command_instance.omnibus_bin_dir}.to raise_error(ChefDK::OmnibusInstallNotFound)
+      allow(Gem).to receive(:ruby).and_return(File.join(fixtures_path, ".rbenv/versions/2.1.1/bin/ruby"))
+      expect { command_instance.omnibus_bin_dir }.to raise_error(ChefDK::OmnibusInstallNotFound)
     end
 
     it "should raise OmnibusInstallNotFound if directory is not looking like omnibus" do
-      allow(Gem).to receive(:ruby).and_return(File.join(fixtures_path,".rbenv/versions/2.1.1/bin/ruby"))
-      expect{command_instance.omnibus_embedded_bin_dir}.to raise_error(ChefDK::OmnibusInstallNotFound)
+      allow(Gem).to receive(:ruby).and_return(File.join(fixtures_path, ".rbenv/versions/2.1.1/bin/ruby"))
+      expect { command_instance.omnibus_embedded_bin_dir }.to raise_error(ChefDK::OmnibusInstallNotFound)
     end
   end
 
@@ -62,19 +62,19 @@ describe ChefDK::Command::Exec do
       # Using a fake path separator to keep to prevent people from accidently
       # getting things correct on their system. This enforces that, in general,
       # you should use the path separator ruby is telling you to use.
-      stub_const("File::PATH_SEPARATOR", '<>')
+      stub_const("File::PATH_SEPARATOR", "<>")
     end
 
     context "when running exec env" do
       let(:command_options) { %w{gem list} }
 
-      let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, 'bin')) }
+      let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, "bin")) }
 
       let(:omnibus_embedded_bin_dir) { "/foo/embedded/bin" }
 
       let(:omnibus_bin_dir) { "/foo/bin" }
 
-      let(:expected_PATH) { [omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV['PATH']].join(File::PATH_SEPARATOR) }
+      let(:expected_PATH) { [omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV["PATH"]].join(File::PATH_SEPARATOR) }
 
       let(:expected_GEM_ROOT) { Gem.default_dir }
 
@@ -94,12 +94,12 @@ describe ChefDK::Command::Exec do
         expect(ENV).to receive(:[]=).with("GEM_PATH", expected_GEM_PATH)
 
         expect(command_instance).to receive(:exec).with(*command_options)
-        expect{ run_command }.to raise_error(RuntimeError) # XXX: this isn't a test we just need to swallow the exception
+        expect { run_command }.to raise_error(RuntimeError) # XXX: this isn't a test we just need to swallow the exception
       end
 
-      ['-v', '--version', '-h', '--help'].each do |switch|
+      ["-v", "--version", "-h", "--help"].each do |switch|
         context "when running a command with #{switch}" do
-          let(:command_options) { %W[gem list #{switch}] }
+          let(:command_options) { %W{gem list #{switch}} }
 
           it "should call exec to fire off the command with the correct environment" do
             expect(ENV).to receive(:[]=).with("PATH", expected_PATH)
@@ -108,14 +108,14 @@ describe ChefDK::Command::Exec do
             expect(ENV).to receive(:[]=).with("GEM_PATH", expected_GEM_PATH)
 
             expect(command_instance).to receive(:exec).with(*command_options)
-            expect{ run_command }.to raise_error(RuntimeError) # XXX: this isn't a test we just need to swallow the exception
+            expect { run_command }.to raise_error(RuntimeError) # XXX: this isn't a test we just need to swallow the exception
           end
         end
       end
 
-      ['-h', '--help'].each do |switch|
+      ["-h", "--help"].each do |switch|
         context "when running a exec with #{switch} and things after it" do
-          let(:command_options) { %W[#{switch} gem] }
+          let(:command_options) { %W{#{switch} gem} }
 
           it "should call not call exec, but it should print the banner" do
             allow(command_instance).to receive(:msg)
@@ -143,13 +143,13 @@ describe ChefDK::Command::Exec do
     context "when running command that does not exist" do
       let(:command_options) { %w{chef_rules_everything_aroundme} }
 
-      let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, 'bin')) }
+      let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, "bin")) }
 
       let(:omnibus_bin_dir) { "/foo/bin" }
 
       let(:omnibus_embedded_bin_dir) { "/foo/embedded/bin" }
 
-      let(:expected_PATH) { [omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV['PATH']].join(File::PATH_SEPARATOR) }
+      let(:expected_PATH) { [omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV["PATH"]].join(File::PATH_SEPARATOR) }
 
       let(:expected_GEM_ROOT) { Gem.default_dir }
 
@@ -157,7 +157,6 @@ describe ChefDK::Command::Exec do
 
       let(:expected_GEM_PATH) { Gem.path.join(File::PATH_SEPARATOR) }
 
-
       before do
         allow(command_instance).to receive(:omnibus_embedded_bin_dir).and_return(omnibus_embedded_bin_dir)
         allow(command_instance).to receive(:omnibus_bin_dir).and_return(omnibus_bin_dir)
@@ -171,7 +170,7 @@ describe ChefDK::Command::Exec do
 
         # XXX: this doesn't really test much, but really calling exec will never return to rspec
         expect(command_instance).to receive(:exec).with(*command_options).and_raise(Errno::ENOENT)
-        expect{ run_command }.to raise_error(Errno::ENOENT)
+        expect { run_command }.to raise_error(Errno::ENOENT)
       end
     end
   end

data/spec/unit/command/export_spec.rb

@@ -15,9 +15,9 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
-require 'shared/command_with_ui_object'
-require 'chef-dk/command/export'
+require "spec_helper"
+require "shared/command_with_ui_object"
+require "chef-dk/command/export"
 
 describe ChefDK::Command::Export do
 
@@ -164,7 +164,7 @@ MESSAGE
       end
 
       it "displays the exception and cause" do
-        expected_error_text=<<-E
+        expected_error_text = <<-E
 Error: export failed
 Reason: (StandardError) some operation failed
 
@@ -179,7 +179,7 @@ E
         let(:params) { [ "path/to/export", "-D"] }
 
         it "displays the exception and cause with backtrace" do
-          expected_error_text=<<-E
+          expected_error_text = <<-E
 Error: export failed
 Reason: (StandardError) some operation failed
 
@@ -197,4 +197,3 @@ E
 
   end
 end
-

data/spec/unit/command/generate_spec.rb

@@ -15,9 +15,9 @@
 # limitations under the License.
 #
 
-require 'spec_helper'
+require "spec_helper"
 require "stringio"
-require 'chef-dk/command/generate'
+require "chef-dk/command/generate"
 
 class ChefDK::Command::GeneratorCommands::Example < ChefDK::Command::GeneratorCommands::Base
 
@@ -41,7 +41,7 @@ class ChefDK::Command::GeneratorCommands::Example < ChefDK::Command::GeneratorCo
 
   def run
     parse_options(@argv)
-    {:argv => @argv, :ran_cmd => "example"}
+    { :argv => @argv, :ran_cmd => "example" }
   end
 end
 
@@ -99,29 +99,29 @@ E
     end
 
     it "prints usage when running an unknown generator" do
-      generate.run(%w[ancient-aliens])
+      generate.run(%w{ancient-aliens})
       expect(stdout).to include(expected_help_message)
     end
 
     it "runs the generator sub-command" do
-      result = generate.run(%w[example])
+      result = generate.run(%w{example})
       expect(result[:ran_cmd]).to eq("example")
     end
 
     it "removes the subcommand name from argv" do
-      result = generate.run(%w[example])
+      result = generate.run(%w{example})
       expect(result[:argv]).to eq([])
     end
 
     it "passes extra arguments and options to the subcommand" do
-      result = generate.run(%w[example argument_one argument_two --option-one --option-two])
-      expect(result[:argv]).to eq(%w[argument_one argument_two --option-one --option-two])
+      result = generate.run(%w{example argument_one argument_two --option-one --option-two})
+      expect(result[:argv]).to eq(%w{argument_one argument_two --option-one --option-two})
     end
 
     describe "when an invalid option is passed to the subcommand" do
 
       it "prints usage and returns non-zero" do
-        result = generate.run(%w[example --nope])
+        result = generate.run(%w{example --nope})
         expect(result).to eq(1)
         expect(stderr).to eq("ERROR: invalid option: --nope\n\n")
       end
@@ -131,7 +131,7 @@ E
     describe "when an option requires an argument but none is given" do
 
       it "prints usage and returns non-zero" do
-        result = generate.run(%w[example --arg])
+        result = generate.run(%w{example --arg})
         expect(result).to eq(1)
         expect(stderr).to eq("ERROR: missing argument: --arg\n\n")
       end