chef-dk 0.9.0 → 0.10.0

data/spec/unit/policyfile/chef_server_cookbook_source_spec.rb

@@ -1,34 +1,34 @@
-#
-# Copyright:: Copyright (c) 2014 Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require 'spec_helper'
-
-require 'chef-dk/policyfile/chef_server_cookbook_source'
-
-describe ChefDK::Policyfile::ChefServerCookbookSource do
-
-  let(:cookbook_source) { ChefDK::Policyfile::ChefServerCookbookSource.new("https://chef.example.com") }
-
-  it "emits a not supported error when attempting to fetch universe" do
-    expect { cookbook_source.universe_graph }.to raise_error(ChefDK::UnsupportedFeature)
-  end
-
-  it "emits a not supported error when attempting to get source options for a cookbook" do
-    expect { cookbook_source.source_options_for("foo", "1.2.3") }.to raise_error(ChefDK::UnsupportedFeature)
-  end
-
-end
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+require 'chef-dk/policyfile/chef_server_cookbook_source'
+
+describe ChefDK::Policyfile::ChefServerCookbookSource do
+
+  let(:cookbook_source) { ChefDK::Policyfile::ChefServerCookbookSource.new("https://chef.example.com") }
+
+  it "emits a not supported error when attempting to fetch universe" do
+    expect { cookbook_source.universe_graph }.to raise_error(ChefDK::UnsupportedFeature)
+  end
+
+  it "emits a not supported error when attempting to get source options for a cookbook" do
+    expect { cookbook_source.source_options_for("foo", "1.2.3") }.to raise_error(ChefDK::UnsupportedFeature)
+  end
+
+end

data/spec/unit/policyfile/community_cookbook_source_spec.rb

@@ -1,51 +1,84 @@
-#
-# Copyright:: Copyright (c) 2014 Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require 'spec_helper'
-require 'chef-dk/policyfile/community_cookbook_source'
-
-describe ChefDK::Policyfile::CommunityCookbookSource do
-
-  let(:cookbook_source) { ChefDK::Policyfile::CommunityCookbookSource.new }
-
-  let(:default_community_uri) { "https://supermarket.chef.io" }
-
-  let(:http_connection) { double("Chef::HTTP::Simple") }
-
-  let(:universe_response_encoded) { IO.read(File.join(fixtures_path, "cookbooks_api/small_universe.json")) }
-
-  let(:pruned_universe) { JSON.parse(IO.read(File.join(fixtures_path, "cookbooks_api/pruned_small_universe.json"))) }
-
-  before do
-    expect(Chef::HTTP::Simple).to receive(:new).with(default_community_uri).and_return(http_connection)
-    expect(http_connection).to receive(:get).with("/universe").and_return(universe_response_encoded)
-  end
-
-  it "fetches the universe graph" do
-    actual_universe = cookbook_source.universe_graph
-    expect(actual_universe).to have_key("apt")
-    expect(actual_universe["apt"]).to eq(pruned_universe["apt"])
-    expect(cookbook_source.universe_graph).to eq(pruned_universe)
-  end
-
-  it "generates location options for a cookbook from the given graph" do
-    expected_opts = { artifactserver: "https://supermarket.chef.io/api/v1/cookbooks/apache2/versions/1.10.4/download", version: "1.10.4" }
-    expect(cookbook_source.source_options_for("apache2", "1.10.4")).to eq(expected_opts)
-  end
-
-end
-
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef-dk/policyfile/community_cookbook_source'
+
+describe ChefDK::Policyfile::CommunityCookbookSource do
+
+  subject(:cookbook_source) { ChefDK::Policyfile::CommunityCookbookSource.new }
+
+  let(:default_community_uri) { "https://supermarket.chef.io" }
+
+  let(:http_connection) { double("Chef::HTTP::Simple") }
+
+  let(:universe_response_encoded) { IO.read(File.join(fixtures_path, "cookbooks_api/small_universe.json")) }
+
+  let(:pruned_universe) { JSON.parse(IO.read(File.join(fixtures_path, "cookbooks_api/pruned_small_universe.json"))) }
+
+  it "defaults to using the public supermarket over HTTPS" do
+    expect(cookbook_source.uri).to eq(default_community_uri)
+  end
+
+  it "gives the set of arguments to `default_source` used to create it" do
+    expect(cookbook_source.default_source_args).to eq([:supermarket, default_community_uri])
+  end
+
+  describe "fetching the Universe graph over HTTP" do
+
+    before do
+      expect(Chef::HTTP::Simple).to receive(:new).with(default_community_uri).and_return(http_connection)
+      expect(http_connection).to receive(:get).with("/universe").and_return(universe_response_encoded)
+    end
+
+    it "fetches the universe graph" do
+      actual_universe = cookbook_source.universe_graph
+      expect(actual_universe).to have_key("apt")
+      expect(actual_universe["apt"]).to eq(pruned_universe["apt"])
+      expect(cookbook_source.universe_graph).to eq(pruned_universe)
+    end
+
+    it "generates location options for a cookbook from the given graph" do
+      expected_opts = { artifactserver: "https://supermarket.chef.io/api/v1/cookbooks/apache2/versions/1.10.4/download", version: "1.10.4" }
+      expect(cookbook_source.source_options_for("apache2", "1.10.4")).to eq(expected_opts)
+    end
+
+  end
+
+  context "when created with a block to set source preferences" do
+
+    subject(:cookbook_source) do
+      ChefDK::Policyfile::CommunityCookbookSource.new do |s|
+        s.preferred_for "foo", "bar", "baz"
+      end
+    end
+
+    it "sets the source preferences as given" do
+      expect(cookbook_source.preferred_cookbooks).to eq( %w[ foo bar baz ] )
+    end
+
+    it "is the preferred source for the requested cookbooks" do
+      expect(cookbook_source.preferred_source_for?("foo")).to be(true)
+      expect(cookbook_source.preferred_source_for?("bar")).to be(true)
+      expect(cookbook_source.preferred_source_for?("baz")).to be(true)
+      expect(cookbook_source.preferred_source_for?("razzledazzle")).to be(false)
+    end
+
+  end
+
+end
+

data/spec/unit/policyfile/comparison_base_spec.rb

@@ -1,343 +1,343 @@
-#
-# Copyright:: Copyright (c) 2015 Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require 'spec_helper'
-require 'chef-dk/policyfile/comparison_base'
-
-describe "Policyfile Comparison Bases" do
-
-  let(:minimal_lockfile_json) do
-        <<-E
-{
-  "revision_id": "6fe753184c8946052d3231bb4212116df28d89a3a5f7ae52832ad408419dd5eb",
-  "name": "install-example",
-  "run_list": [
-    "recipe[local-cookbook::default]"
-  ],
-  "cookbook_locks": {
-    "local-cookbook": {
-      "version": "2.3.4",
-      "identifier": "fab501cfaf747901bd82c1bc706beae7dc3a350c",
-      "dotted_decimal_identifier": "70567763561641081.489844270461035.258281553147148",
-      "source": "cookbooks/local-cookbook",
-      "cache_key": null,
-      "scm_info": null,
-      "source_options": {
-        "path": "cookbooks/local-cookbook"
-      }
-    }
-  },
-  "default_attributes": {},
-  "override_attributes": {},
-  "solution_dependencies": {
-    "Policyfile": [
-      [
-        "local-cookbook",
-        ">= 0.0.0"
-      ]
-    ],
-    "dependencies": {
-      "local-cookbook (2.3.4)": [
-
-      ]
-    }
-  }
-}
-E
-  end
-
-  let(:minimal_lockfile) { FFI_Yajl::Parser.parse(minimal_lockfile_json) }
-
-  describe ChefDK::Policyfile::ComparisonBase::Local do
-
-    let(:policyfile_lock_relpath) { "Policyfile.lock.json" }
-
-    subject(:comparison_base) { described_class.new(policyfile_lock_relpath) }
-
-    before do
-      reset_tempdir
-    end
-
-    after do
-      reset_tempdir
-    end
-
-    it "has the lockfile relative path" do
-      expect(comparison_base.policyfile_lock_relpath).to eq(policyfile_lock_relpath)
-    end
-
-    it "is named local:RELATIVE_PATH" do
-      expect(comparison_base.name).to eq("local:#{policyfile_lock_relpath}")
-    end
-
-    context "when the local lock doesn't exist" do
-
-      it "raises an exception when reading the lockfile" do
-        Dir.chdir(tempdir) do
-          expect { comparison_base.lock }.to raise_error(ChefDK::LockfileNotFound)
-        end
-      end
-
-    end
-
-    context "when the local policyfile lock is not readable", :skip_on_windows do
-
-      before do
-        Dir.chdir(tempdir) do
-          FileUtils.touch(policyfile_lock_relpath)
-          allow(File).to receive(:readable?).with(policyfile_lock_relpath).and_return(false)
-        end
-      end
-
-      it "raises an exception" do
-        Dir.chdir(tempdir) do
-          expect { comparison_base.lock }.to raise_error(ChefDK::LockfileNotFound)
-        end
-      end
-
-    end
-
-    context "when the local policyfile lock is malformed" do
-
-      before do
-        Dir.chdir(tempdir) do
-          File.open(policyfile_lock_relpath, "w+") { |f| f.print("}}}}}}") }
-        end
-      end
-
-      it "raises an exception" do
-        Dir.chdir(tempdir) do
-          expect { comparison_base.lock }.to raise_error(ChefDK::MalformedLockfile)
-        end
-      end
-
-    end
-
-    context "when the local lock exists and is valid JSON" do
-
-      before do
-        Dir.chdir(tempdir) do
-          File.open(policyfile_lock_relpath, "w+") { |f| f.print(minimal_lockfile_json) }
-        end
-      end
-
-      it "reads the local lock and parses the JSON" do
-        Dir.chdir(tempdir) do
-          expect(comparison_base.lock).to eq(minimal_lockfile)
-        end
-      end
-
-    end
-
-  end
-
-  describe ChefDK::Policyfile::ComparisonBase::Git do
-
-    let(:ref) { "master" }
-
-    let(:policyfile_lock_relpath) { "policies/MyPolicy.lock.json" }
-
-    subject(:comparison_base) { described_class.new(ref, policyfile_lock_relpath) }
-
-    it "has the policyfile lock relative path it was created with" do
-      expect(comparison_base.policyfile_lock_relpath).to eq(policyfile_lock_relpath)
-    end
-
-    it "has the ref it was created with" do
-      expect(comparison_base.ref).to eq(ref)
-    end
-
-    it "is named git:REF" do
-      expect(comparison_base.name).to eq("git:master")
-    end
-
-    it "creates a `git show` command for the policyfile lock and ref" do
-      expect(comparison_base.git_cmd_string).to eq("git show master:./policies/MyPolicy.lock.json")
-      expect(comparison_base.git_cmd.command).to eq("git show master:./policies/MyPolicy.lock.json")
-    end
-
-    context "when the git command fails" do
-
-      before do
-        allow(comparison_base.git_cmd).to receive(:run_command)
-        allow(comparison_base.git_cmd).to receive(:error!).and_raise(Mixlib::ShellOut::ShellCommandFailed)
-        allow(comparison_base.git_cmd).to receive(:stderr).and_return("fatal: Not a git repository (or any of the parent directories): .git\n")
-      end
-
-      it "raises an exception when reading the lockfile" do
-        expect { comparison_base.lock }.to raise_error(ChefDK::GitError)
-      end
-
-    end
-
-    context "when the git command succeeds" do
-
-      before do
-        allow(comparison_base.git_cmd).to receive(:run_command)
-        allow(comparison_base.git_cmd).to receive(:error!).and_return(nil)
-      end
-
-      context "and the JSON is malformed" do
-
-        before do
-          allow(comparison_base.git_cmd).to receive(:stdout).and_return("}}}}}")
-        end
-
-        it "raises an exception" do
-          expect { comparison_base.lock }.to raise_error(ChefDK::MalformedLockfile)
-        end
-
-      end
-
-      context "and the JSON is well-formed" do
-
-        before do
-          allow(comparison_base.git_cmd).to receive(:stdout).and_return(minimal_lockfile_json)
-        end
-
-        it "reads the lockfile and parses the JSON" do
-          expect(comparison_base.lock).to eq(minimal_lockfile)
-        end
-      end
-
-    end
-
-  end
-
-  describe ChefDK::Policyfile::ComparisonBase::PolicyGroup do
-
-    let(:group) { "acceptance" }
-    let(:policy_name) { "chatserver" }
-    let(:http_client) { instance_double("ChefDK::AuthenticatedHTTP", url: "https://chef.example/organizations/monkeynews") }
-
-    subject(:comparison_base) { described_class.new(group, policy_name, http_client) }
-
-    it "has the group it was created with" do
-      expect(comparison_base.group).to eq(group)
-    end
-
-    it "has the policy_name it was created with" do
-      expect(comparison_base.policy_name).to eq(policy_name)
-    end
-
-    it "has the HTTP client it was created with" do
-      expect(comparison_base.http_client).to eq(http_client)
-    end
-
-    it "is named policy_group:GROUP" do
-      expect(comparison_base.name).to eq("policy_group:#{group}")
-    end
-
-    context "when there is a non-404 HTTP error fetching the policyfile lock" do
-
-      let(:response) do
-        Net::HTTPResponse.send(:response_class, "500").new("1.0", "500", "Internal Server Error").tap do |r|
-          r.instance_variable_set(:@body, "oops")
-        end
-      end
-
-      let(:http_exception) do
-        begin
-          response.error!
-        rescue => e
-          e
-        end
-      end
-
-      before do
-        allow(http_client).to receive(:get).and_raise(http_exception)
-      end
-
-      it "raises an exception" do
-        exception = nil
-        begin
-          comparison_base.lock
-        rescue => exception
-          expect(exception).to be_a_kind_of(ChefDK::PolicyfileDownloadError)
-          expect(exception.message).to eq("HTTP error attempting to fetch policyfile lock from https://chef.example/organizations/monkeynews")
-          expect(exception.cause).to eq(http_exception)
-        end
-        expect(exception).to_not be_nil
-      end
-
-    end
-
-    context "when the server returns 404 fetching the policyfile lock" do
-
-      let(:response) do
-        Net::HTTPResponse.send(:response_class, "404").new("1.0", "404", "Not Found").tap do |r|
-          r.instance_variable_set(:@body, "nothin' here, chief")
-        end
-      end
-
-      let(:http_exception) do
-        begin
-          response.error!
-        rescue => e
-          e
-        end
-      end
-
-      before do
-        allow(http_client).to receive(:get).and_raise(http_exception)
-      end
-
-      it "raises an exception" do
-        exception = nil
-        begin
-          comparison_base.lock
-        rescue => exception
-          expect(exception).to be_a_kind_of(ChefDK::PolicyfileDownloadError)
-          expect(exception.message).to eq("No policyfile lock named 'chatserver' found in policy_group 'acceptance' at https://chef.example/organizations/monkeynews")
-          expect(exception.cause).to eq(http_exception)
-        end
-        expect(exception).to_not be_nil
-      end
-
-
-    end
-
-
-    context "when a non-HTTP error occurs fetching the policyfile lock" do
-
-      before do
-        allow(http_client).to receive(:get).and_raise(Errno::ECONNREFUSED)
-      end
-
-      it "raises an exception" do
-        expect { comparison_base.lock }.to raise_error(ChefDK::PolicyfileDownloadError)
-      end
-
-    end
-
-    context "when the policyfile lock is fetched from the server" do
-
-      before do
-        expect(http_client).to receive(:get).
-          with("policy_groups/acceptance/policies/chatserver").
-          and_return(minimal_lockfile)
-      end
-
-      it "returns the policyfile lock data" do
-        expect(comparison_base.lock).to eq(minimal_lockfile)
-      end
-
-    end
-
-  end
-end
-
+#
+# Copyright:: Copyright (c) 2015 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef-dk/policyfile/comparison_base'
+
+describe "Policyfile Comparison Bases" do
+
+  let(:minimal_lockfile_json) do
+        <<-E
+{
+  "revision_id": "6fe753184c8946052d3231bb4212116df28d89a3a5f7ae52832ad408419dd5eb",
+  "name": "install-example",
+  "run_list": [
+    "recipe[local-cookbook::default]"
+  ],
+  "cookbook_locks": {
+    "local-cookbook": {
+      "version": "2.3.4",
+      "identifier": "fab501cfaf747901bd82c1bc706beae7dc3a350c",
+      "dotted_decimal_identifier": "70567763561641081.489844270461035.258281553147148",
+      "source": "cookbooks/local-cookbook",
+      "cache_key": null,
+      "scm_info": null,
+      "source_options": {
+        "path": "cookbooks/local-cookbook"
+      }
+    }
+  },
+  "default_attributes": {},
+  "override_attributes": {},
+  "solution_dependencies": {
+    "Policyfile": [
+      [
+        "local-cookbook",
+        ">= 0.0.0"
+      ]
+    ],
+    "dependencies": {
+      "local-cookbook (2.3.4)": [
+
+      ]
+    }
+  }
+}
+E
+  end
+
+  let(:minimal_lockfile) { FFI_Yajl::Parser.parse(minimal_lockfile_json) }
+
+  describe ChefDK::Policyfile::ComparisonBase::Local do
+
+    let(:policyfile_lock_relpath) { "Policyfile.lock.json" }
+
+    subject(:comparison_base) { described_class.new(policyfile_lock_relpath) }
+
+    before do
+      reset_tempdir
+    end
+
+    after do
+      reset_tempdir
+    end
+
+    it "has the lockfile relative path" do
+      expect(comparison_base.policyfile_lock_relpath).to eq(policyfile_lock_relpath)
+    end
+
+    it "is named local:RELATIVE_PATH" do
+      expect(comparison_base.name).to eq("local:#{policyfile_lock_relpath}")
+    end
+
+    context "when the local lock doesn't exist" do
+
+      it "raises an exception when reading the lockfile" do
+        Dir.chdir(tempdir) do
+          expect { comparison_base.lock }.to raise_error(ChefDK::LockfileNotFound)
+        end
+      end
+
+    end
+
+    context "when the local policyfile lock is not readable", :skip_on_windows do
+
+      before do
+        Dir.chdir(tempdir) do
+          FileUtils.touch(policyfile_lock_relpath)
+          allow(File).to receive(:readable?).with(policyfile_lock_relpath).and_return(false)
+        end
+      end
+
+      it "raises an exception" do
+        Dir.chdir(tempdir) do
+          expect { comparison_base.lock }.to raise_error(ChefDK::LockfileNotFound)
+        end
+      end
+
+    end
+
+    context "when the local policyfile lock is malformed" do
+
+      before do
+        Dir.chdir(tempdir) do
+          File.open(policyfile_lock_relpath, "w+") { |f| f.print("}}}}}}") }
+        end
+      end
+
+      it "raises an exception" do
+        Dir.chdir(tempdir) do
+          expect { comparison_base.lock }.to raise_error(ChefDK::MalformedLockfile)
+        end
+      end
+
+    end
+
+    context "when the local lock exists and is valid JSON" do
+
+      before do
+        Dir.chdir(tempdir) do
+          File.open(policyfile_lock_relpath, "w+") { |f| f.print(minimal_lockfile_json) }
+        end
+      end
+
+      it "reads the local lock and parses the JSON" do
+        Dir.chdir(tempdir) do
+          expect(comparison_base.lock).to eq(minimal_lockfile)
+        end
+      end
+
+    end
+
+  end
+
+  describe ChefDK::Policyfile::ComparisonBase::Git do
+
+    let(:ref) { "master" }
+
+    let(:policyfile_lock_relpath) { "policies/MyPolicy.lock.json" }
+
+    subject(:comparison_base) { described_class.new(ref, policyfile_lock_relpath) }
+
+    it "has the policyfile lock relative path it was created with" do
+      expect(comparison_base.policyfile_lock_relpath).to eq(policyfile_lock_relpath)
+    end
+
+    it "has the ref it was created with" do
+      expect(comparison_base.ref).to eq(ref)
+    end
+
+    it "is named git:REF" do
+      expect(comparison_base.name).to eq("git:master")
+    end
+
+    it "creates a `git show` command for the policyfile lock and ref" do
+      expect(comparison_base.git_cmd_string).to eq("git show master:./policies/MyPolicy.lock.json")
+      expect(comparison_base.git_cmd.command).to eq("git show master:./policies/MyPolicy.lock.json")
+    end
+
+    context "when the git command fails" do
+
+      before do
+        allow(comparison_base.git_cmd).to receive(:run_command)
+        allow(comparison_base.git_cmd).to receive(:error!).and_raise(Mixlib::ShellOut::ShellCommandFailed)
+        allow(comparison_base.git_cmd).to receive(:stderr).and_return("fatal: Not a git repository (or any of the parent directories): .git\n")
+      end
+
+      it "raises an exception when reading the lockfile" do
+        expect { comparison_base.lock }.to raise_error(ChefDK::GitError)
+      end
+
+    end
+
+    context "when the git command succeeds" do
+
+      before do
+        allow(comparison_base.git_cmd).to receive(:run_command)
+        allow(comparison_base.git_cmd).to receive(:error!).and_return(nil)
+      end
+
+      context "and the JSON is malformed" do
+
+        before do
+          allow(comparison_base.git_cmd).to receive(:stdout).and_return("}}}}}")
+        end
+
+        it "raises an exception" do
+          expect { comparison_base.lock }.to raise_error(ChefDK::MalformedLockfile)
+        end
+
+      end
+
+      context "and the JSON is well-formed" do
+
+        before do
+          allow(comparison_base.git_cmd).to receive(:stdout).and_return(minimal_lockfile_json)
+        end
+
+        it "reads the lockfile and parses the JSON" do
+          expect(comparison_base.lock).to eq(minimal_lockfile)
+        end
+      end
+
+    end
+
+  end
+
+  describe ChefDK::Policyfile::ComparisonBase::PolicyGroup do
+
+    let(:group) { "acceptance" }
+    let(:policy_name) { "chatserver" }
+    let(:http_client) { instance_double("ChefDK::AuthenticatedHTTP", url: "https://chef.example/organizations/monkeynews") }
+
+    subject(:comparison_base) { described_class.new(group, policy_name, http_client) }
+
+    it "has the group it was created with" do
+      expect(comparison_base.group).to eq(group)
+    end
+
+    it "has the policy_name it was created with" do
+      expect(comparison_base.policy_name).to eq(policy_name)
+    end
+
+    it "has the HTTP client it was created with" do
+      expect(comparison_base.http_client).to eq(http_client)
+    end
+
+    it "is named policy_group:GROUP" do
+      expect(comparison_base.name).to eq("policy_group:#{group}")
+    end
+
+    context "when there is a non-404 HTTP error fetching the policyfile lock" do
+
+      let(:response) do
+        Net::HTTPResponse.send(:response_class, "500").new("1.0", "500", "Internal Server Error").tap do |r|
+          r.instance_variable_set(:@body, "oops")
+        end
+      end
+
+      let(:http_exception) do
+        begin
+          response.error!
+        rescue => e
+          e
+        end
+      end
+
+      before do
+        allow(http_client).to receive(:get).and_raise(http_exception)
+      end
+
+      it "raises an exception" do
+        exception = nil
+        begin
+          comparison_base.lock
+        rescue => exception
+          expect(exception).to be_a_kind_of(ChefDK::PolicyfileDownloadError)
+          expect(exception.message).to eq("HTTP error attempting to fetch policyfile lock from https://chef.example/organizations/monkeynews")
+          expect(exception.cause).to eq(http_exception)
+        end
+        expect(exception).to_not be_nil
+      end
+
+    end
+
+    context "when the server returns 404 fetching the policyfile lock" do
+
+      let(:response) do
+        Net::HTTPResponse.send(:response_class, "404").new("1.0", "404", "Not Found").tap do |r|
+          r.instance_variable_set(:@body, "nothin' here, chief")
+        end
+      end
+
+      let(:http_exception) do
+        begin
+          response.error!
+        rescue => e
+          e
+        end
+      end
+
+      before do
+        allow(http_client).to receive(:get).and_raise(http_exception)
+      end
+
+      it "raises an exception" do
+        exception = nil
+        begin
+          comparison_base.lock
+        rescue => exception
+          expect(exception).to be_a_kind_of(ChefDK::PolicyfileDownloadError)
+          expect(exception.message).to eq("No policyfile lock named 'chatserver' found in policy_group 'acceptance' at https://chef.example/organizations/monkeynews")
+          expect(exception.cause).to eq(http_exception)
+        end
+        expect(exception).to_not be_nil
+      end
+
+
+    end
+
+
+    context "when a non-HTTP error occurs fetching the policyfile lock" do
+
+      before do
+        allow(http_client).to receive(:get).and_raise(Errno::ECONNREFUSED)
+      end
+
+      it "raises an exception" do
+        expect { comparison_base.lock }.to raise_error(ChefDK::PolicyfileDownloadError)
+      end
+
+    end
+
+    context "when the policyfile lock is fetched from the server" do
+
+      before do
+        expect(http_client).to receive(:get).
+          with("policy_groups/acceptance/policies/chatserver").
+          and_return(minimal_lockfile)
+      end
+
+      it "returns the policyfile lock data" do
+        expect(comparison_base.lock).to eq(minimal_lockfile)
+      end
+
+    end
+
+  end
+end
+