chef-dk 0.5.0.rc.1 → 0.5.0

data/spec/unit/command/shell_init_spec.rb

@@ -20,6 +20,7 @@ require 'chef-dk/command/shell_init'
 
 describe ChefDK::Command::ShellInit do
 
+  let(:expected_path) { [omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV['PATH']].join(File::PATH_SEPARATOR) }
   let(:stdout_io) { StringIO.new }
   let(:stderr_io) { StringIO.new }
 
@@ -32,7 +33,6 @@ describe ChefDK::Command::ShellInit do
 
   shared_context "shell init script" do |shell|
     let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, 'bin')) }
-    let(:expected_path) { [omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV['PATH']].join(File::PATH_SEPARATOR) }
     let(:expected_gem_root) { Gem.default_dir.to_s }
     let(:expected_gem_home) { Gem.user_dir }
     let(:expected_gem_path) { Gem.path.join(File::PATH_SEPARATOR) }
@@ -107,6 +107,23 @@ EOH
     end
   end
 
+  context 'for fish' do
+    before do
+      stub_const('File::PATH_SEPARATOR', ':')
+    end
+    let(:expected_path) { [omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV['PATH']].join(':').split(':').join('" "') }
+    let(:expected_environment_commands) do
+      <<-EOH
+set -gx PATH "#{expected_path}" 2>/dev/null;
+set -gx GEM_ROOT "#{expected_gem_root}";
+set -gx GEM_HOME "#{expected_gem_home}";
+set -gx GEM_PATH "#{expected_gem_path}";
+EOH
+    end
+
+    include_context 'shell init script', 'fish'
+  end
+
   ['powershell', 'posh'].each do |shell|
     context "for #{shell}" do
       it_behaves_like "a powershell script", shell
@@ -131,7 +148,7 @@ EOH
     it "exits with an error message" do
       expect(command_instance.run(argv)).to eq(1)
       expect(stderr_io.string).to include("Shell `nosuchsh' is not currently supported")
-      expect(stderr_io.string).to include("Supported shells are: bash zsh sh powershell posh")
+      expect(stderr_io.string).to include("Supported shells are: bash fish zsh sh powershell posh")
     end
 
   end

data/spec/unit/command/update_spec.rb

@@ -33,6 +33,8 @@ describe ChefDK::Command::Update do
 
   let(:install_service) { instance_double(ChefDK::PolicyfileServices::Install) }
 
+  let(:update_attrs_service) { instance_double(ChefDK::PolicyfileServices::UpdateAttributes) }
+
   it "disables debug by default" do
     expect(command.debug?).to be(false)
   end
@@ -46,6 +48,22 @@ describe ChefDK::Command::Update do
     end
   end
 
+  context "when attributes update mode is set" do
+
+    let(:params) { ["-a"] }
+
+    it "enables attributes update mode" do
+      expect(command.update_attributes?).to be(true)
+    end
+
+    it "creates an attributes update service object" do
+      expect(ChefDK::PolicyfileServices::UpdateAttributes).to receive(:new).
+        with(policyfile: nil, ui: command.ui, root_dir: Dir.pwd).
+        and_return(update_attrs_service)
+      expect(command.attributes_updater).to eq(update_attrs_service)
+    end
+  end
+
   context "with no arguments" do
 
     it "does not specify a policyfile relative path" do
@@ -140,6 +158,84 @@ Error: install failed
 Reason: (StandardError) some operation failed
 
 
+E
+
+          expected_error_text << backtrace.join("\n") << "\n"
+
+          command.run
+          expect(ui.output).to eq(expected_error_text)
+        end
+      end
+
+    end
+
+  end
+
+  describe "running attributes update" do
+
+    let(:params) { ["-a"] }
+
+    let(:ui) { TestHelpers::TestUI.new }
+
+    before do
+      command.ui = ui
+      allow(command).to receive(:attributes_updater).and_return(update_attrs_service)
+    end
+
+    context "when the command runs successfully" do
+
+      before do
+        expect(update_attrs_service).to receive(:run)
+      end
+
+      it "exits with success" do
+        expect(command.run).to eq(0)
+      end
+    end
+
+    context "when the command fails" do
+
+      let(:backtrace) { caller[0...3] }
+
+      let(:cause) do
+        e = StandardError.new("some operation failed")
+        e.set_backtrace(backtrace)
+        e
+      end
+
+      let(:exception) do
+        ChefDK::PolicyfileUpdateError.new("Failed to update Policyfile lock", cause)
+      end
+
+      before do
+        expect(update_attrs_service).to receive(:run).and_raise(exception)
+      end
+
+      it "exits 1" do
+        expect(command.run).to eq(1)
+      end
+
+      it "displays the exception and cause" do
+        expected_error_text=<<-E
+Error: Failed to update Policyfile lock
+Reason: (StandardError) some operation failed
+
+E
+
+        command.run
+        expect(ui.output).to eq(expected_error_text)
+      end
+
+      context "and debug is enabled" do
+
+        let(:params) { ["-a", "-D"] }
+
+        it "displays the exception and cause with backtrace" do
+          expected_error_text=<<-E
+Error: Failed to update Policyfile lock
+Reason: (StandardError) some operation failed
+
+
 E
 
           expected_error_text << backtrace.join("\n") << "\n"

data/spec/unit/command/verify_spec.rb

@@ -280,12 +280,6 @@ describe ChefDK::Command::Verify do
           expect(stdout).to include("my friend everything is good...")
         end
 
-        it "should report the output of the first verification first" do
-          index_first = stdout.index("you are good to go...")
-          index_second = stdout.index("my friend everything is good...")
-          expect(index_second > index_first).to be true
-        end
-
         context "and components are filtered by CLI args" do
 
           let(:command_options) { [ "successful_comp_2" ] }

data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/Berksfile

@@ -0,0 +1,3 @@
+source "https://supermarket.getchef.com"
+
+metadata

data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/README.md

@@ -0,0 +1,4 @@
+# local-cookbook
+
+TODO: Enter the cookbook description here.
+

data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/chefignore

@@ -0,0 +1,96 @@
+# Put files/directories that should be ignored in this file when uploading
+# or sharing to the community site.
+# Lines that start with '# ' are comments.
+
+# OS generated files #
+######################
+.DS_Store
+Icon?
+nohup.out
+ehthumbs.db
+Thumbs.db
+
+# SASS #
+########
+.sass-cache
+
+# EDITORS #
+###########
+\#*
+.#*
+*~
+*.sw[a-z]
+*.bak
+REVISION
+TAGS*
+tmtags
+*_flymake.*
+*_flymake
+*.tmproj
+.project
+.settings
+mkmf.log
+
+## COMPILED ##
+##############
+a.out
+*.o
+*.pyc
+*.so
+*.com
+*.class
+*.dll
+*.exe
+*/rdoc/
+
+# Testing #
+###########
+.watchr
+.rspec
+spec/*
+spec/fixtures/*
+test/*
+features/*
+Guardfile
+Procfile
+
+# SCM #
+#######
+.git
+*/.git
+.gitignore
+.gitmodules
+.gitconfig
+.gitattributes
+.svn
+*/.bzr/*
+*/.hg/*
+*/.svn/*
+
+# Berkshelf #
+#############
+Berksfile
+Berksfile.lock
+cookbooks/*
+tmp
+
+# Cookbooks #
+#############
+CONTRIBUTING
+CHANGELOG*
+
+# Strainer #
+############
+Colanderfile
+Strainerfile
+.colander
+.strainer
+
+# Vagrant #
+###########
+.vagrant
+Vagrantfile
+
+# Travis #
+##########
+.travis.yml

data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/metadata.rb

@@ -0,0 +1,9 @@
+name             'cookbook-with-a-dep'
+maintainer       ''
+maintainer_email ''
+license          ''
+description      'Installs/Configures local-cookbook'
+long_description 'Installs/Configures local-cookbook'
+version          '9.9.9'
+
+depends 'another-local-cookbook', '~> 0.1'

data/spec/unit/fixtures/local_path_cookbooks/cookbook-with-a-dep/recipes/default.rb

@@ -0,0 +1,8 @@
+#
+# Cookbook Name:: local-cookbook
+# Recipe:: default
+#
+# Copyright (C) 2014 
+#
+# 
+#

data/spec/unit/pager_spec.rb

@@ -0,0 +1,119 @@
+#
+# Copyright:: Copyright (c) 2015 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef-dk/pager'
+
+describe ChefDK::Pager do
+
+  context "with default options" do
+
+    subject(:pager) { ChefDK::Pager.new }
+
+    it "gives ENV for env" do
+      expect(pager.env).to eq(ENV)
+    end
+
+    it "checks stdout for TTY" do
+      expect($stdout).to receive(:tty?).twice.and_call_original
+      expect(pager.have_tty?).to eq($stdout.tty?)
+    end
+
+    it "enables paging" do
+      expect(pager).to receive(:env).and_return({"PAGER" => "less"})
+      expect(pager).to receive(:have_tty?).and_return(true)
+      expect(pager.pager_enabled?).to be(true)
+    end
+  end
+
+  context "with paging enabled" do
+
+    subject(:pager) do
+      ChefDK::Pager.new(enable_pager: true).tap do |p|
+        allow(p).to receive(:env).and_return({"PAGER" => "less"})
+        allow(p).to receive(:have_tty?).and_return(true)
+      end
+    end
+
+    let(:pipe_read) { instance_double("IO") }
+    let(:pipe_write) { instance_double("IO") }
+
+    let(:pager_env) { { "LESS" => "-FRX", "LV" => "-c" } }
+
+    before do
+      allow(IO).to receive(:pipe).and_return([pipe_read, pipe_write])
+    end
+
+    it "provides a UI object with stdout set to a pipe" do
+      expect(pager.ui.out_stream).to eq(pipe_write)
+    end
+
+    it "starts the pager" do
+      expect(Kernel).to receive(:trap).with(:INT, "IGNORE")
+      expect(Process).to receive(:spawn).with(pager_env, "less", in: pipe_read).and_return(12345)
+      expect(pipe_read).to receive(:close)
+      pager.start
+    end
+
+    it "waits for the pager to exit" do
+      expect(Kernel).to receive(:trap).with(:INT, "IGNORE")
+      expect(Process).to receive(:spawn).with(pager_env, "less", in: pipe_read).and_return(12345)
+      expect(pipe_read).to receive(:close)
+      pager.start
+
+      expect(pipe_write).to receive(:close)
+      expect(Process).to receive(:waitpid).with(12345)
+      pager.wait
+    end
+  end
+
+  context "with paging disabled" do
+
+    subject(:pager) do
+      ChefDK::Pager.new(enable_pager: false).tap do |p|
+        allow(p).to receive(:env).and_return({"PAGER" => "less"})
+        allow(p).to receive(:have_tty?).and_return(true)
+      end
+    end
+
+    before do
+      expect(IO).to_not receive(:pipe)
+    end
+
+
+    it "provides a UI with stdout set to stdout" do
+      expect(pager.ui.out_stream).to eq($stdout)
+    end
+
+    it "no-ops on pager start" do
+      expect(Kernel).to_not receive(:trap)
+      expect(Process).to_not receive(:spawn)
+      pager.start
+    end
+
+    it "no-ops on pager wait" do
+      expect(Kernel).to_not receive(:trap)
+      expect(Process).to_not receive(:spawn)
+      pager.start
+
+      expect(Process).to_not receive(:waitpid)
+      pager.wait
+    end
+
+  end
+end
+

data/spec/unit/policyfile/chef_repo_cookbook_source_spec.rb

@@ -0,0 +1,66 @@
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef-dk/policyfile/chef_repo_cookbook_source'
+
+describe ChefDK::Policyfile::ChefRepoCookbookSource do
+
+  let(:repo_path) {
+    File.expand_path("spec/unit/fixtures/local_path_cookbooks", project_root)
+  }
+
+  let(:cookbook_source) { ChefDK::Policyfile::ChefRepoCookbookSource.new(repo_path) }
+
+  let(:local_repo_universe) {
+    {
+      "another-local-cookbook"=>{
+        "0.1.0"=>[],
+      },
+      "local-cookbook"=>{
+        "2.3.4"=>[],
+      },
+      "cookbook-with-a-dep"=>{
+        "9.9.9"=>[["another-local-cookbook", "~> 0.1"]],
+      },
+      "noignore"=>{
+        "0.1.0"=>[],
+      },
+    }
+  }
+  it "fetches the universe graph" do
+    actual_universe = cookbook_source.universe_graph
+    expect(actual_universe).to eql(local_repo_universe)
+  end
+
+  it "generates location options for a cookbook from the given graph" do
+    expected_opts = { path: File.join(repo_path, "local-cookbook"), version: "2.3.4" }
+    expect(cookbook_source.source_options_for("local-cookbook", "2.3.4")).to eq(expected_opts)
+  end
+
+  it "will append a cookbooks directory to the path if it finds it" do
+    expect(Dir).to receive(:exist?).with("#{repo_path}/cookbooks").and_return(true)
+    expect(cookbook_source.path).to eql("#{repo_path}/cookbooks")
+  end
+
+  it "the private setter will append a cookbooks directory to the path if finds it" do
+    expect(cookbook_source.path).to eql(repo_path)
+    expect(Dir).to receive(:exist?).with("#{repo_path}/cookbooks").and_return(true)
+    cookbook_source.send(:path=, repo_path)
+    expect(cookbook_source.path).to eql("#{repo_path}/cookbooks")
+  end
+end