chef-dk 0.2.1 → 0.3.0

data/spec/unit/command/push_spec.rb

@@ -0,0 +1,203 @@
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef-dk/command/push'
+
+describe ChefDK::Command::Push do
+
+  let(:policy_group) { "dev" }
+
+  let(:params) { [policy_group] }
+
+  let(:command) do
+    described_class.new
+  end
+
+  let(:push_service) { instance_double(ChefDK::PolicyfileServices::Push) }
+
+  let(:chef_config_loader) { instance_double("Chef::WorkstationConfigLoader") }
+
+  let(:chef_config) { double("Chef::Config") }
+
+  let(:config_arg) { nil }
+
+  before do
+    stub_const("Chef::Config", chef_config)
+    allow(Chef::WorkstationConfigLoader).to receive(:new).with(config_arg).and_return(chef_config_loader)
+  end
+
+  context "after evaluating params" do
+
+    before do
+      command.apply_params!(params)
+    end
+
+    it "disables debug by default" do
+      expect(command.debug?).to be(false)
+    end
+
+    it "configures a default UI component" do
+      ui = command.ui
+      expect(ui.out_stream).to eq($stdout)
+      expect(ui.err_stream).to eq($stderr)
+    end
+
+    describe "when configuring components that depend on chef config" do
+
+      before do
+        expect(chef_config_loader).to receive(:load)
+      end
+
+      it "reads the chef/knife config" do
+        expect(command.chef_config).to eq(chef_config)
+      end
+
+      it "configures the Push service" do
+        expect(ChefDK::PolicyfileServices::Push).to receive(:new).
+          with(policyfile: nil, ui: command.ui, policy_group: policy_group, config: chef_config, root_dir: Dir.pwd).
+          and_return(push_service)
+        expect(command.push).to eq(push_service)
+      end
+
+      context "and an explicit Policyfile is given" do
+
+        let(:params) { [policy_group, "MyPolicy.rb"] }
+
+        it "configures the Push service with the given Policyfile" do
+          expect(ChefDK::PolicyfileServices::Push).to receive(:new).
+            with(policyfile: "MyPolicy.rb", ui: command.ui, policy_group: policy_group, config: chef_config, root_dir: Dir.pwd).
+            and_return(push_service)
+          expect(command.push).to eq(push_service)
+        end
+
+      end
+    end
+
+    context "when debug mode is set" do
+
+      let(:params) { [ policy_group, "-D" ] }
+
+      it "enables debug" do
+        expect(command.debug?).to be(true)
+      end
+
+    end
+
+  end
+
+  describe "running the push operation" do
+
+    let(:ui) { TestHelpers::TestUI.new }
+
+    before do
+      command.ui = ui
+    end
+
+    context "when invoked without arguments" do
+
+      let(:params) { [] }
+
+      it "prints the banner and returns 1" do
+        expect(command.run).to eq(1)
+      end
+
+    end
+
+    context "with valid arguments" do
+
+      before do
+        expect(command).to receive(:push).and_return(push_service)
+      end
+
+      context "when the push is successful" do
+
+        before do
+          expect(push_service).to receive(:run)
+        end
+
+        it "returns 0" do
+          expect(command.run(params)).to eq(0)
+        end
+
+      end
+
+      context "when the push operation raises an exception" do
+
+        let(:backtrace) { caller[0...3] }
+
+        let(:cause) do
+          e = StandardError.new("some operation failed")
+          e.set_backtrace(backtrace)
+          e
+        end
+
+        let(:exception) do
+          ChefDK::PolicyfilePushError.new("install failed", cause)
+        end
+
+        before do
+          expect(push_service).to receive(:run).and_raise(exception)
+        end
+
+        it "exits 1" do
+          expect(command.run(params)).to eq(1)
+        end
+
+        it "describes the error" do
+          command.run(params)
+
+          expected_output=<<-E
+Error: install failed
+Reason: StandardError
+
+some operation failed
+E
+
+          expect(ui.output).to eq(expected_output)
+        end
+
+        context "when debug is enabled" do
+
+          before do
+            params << "-D"
+          end
+
+          it "includes the backtrace in the error" do
+
+            command.run(params)
+
+            expected_output=<<-E
+Error: install failed
+Reason: StandardError
+
+some operation failed
+E
+            expected_output << backtrace.join("\n") << "\n"
+
+            expect(ui.output).to eq(expected_output)
+          end
+
+        end
+
+      end
+    end
+
+  end
+
+end
+

data/spec/unit/command/shell_init_spec.rb

@@ -38,7 +38,7 @@ describe ChefDK::Command::ShellInit do
 
   let(:expected_gem_root) { Gem.default_dir.to_s }
 
-  let(:expected_gem_home) { ENV['GEM_HOME'] }
+  let(:expected_gem_home) { Gem.user_dir }
 
   let(:expected_gem_path) { Gem.path.join(':') }
 

data/spec/unit/policyfile/cookbook_location_specification_spec.rb

@@ -87,6 +87,13 @@ describe ChefDK::Policyfile::CookbookLocationSpecification do
       expect(cookbook_location_spec.installer).to eq(installer)
     end
 
+    it "delegates #installed? to the installer" do
+      expect(installer).to receive(:installed?).and_return(false)
+      expect(cookbook_location_spec).to_not be_installed
+      expect(installer).to receive(:installed?).and_return(true)
+      expect(cookbook_location_spec).to be_installed
+    end
+
     it "delegates installation to the installer" do
       expect(installer).to receive(:installed?).and_return(false)
       expect(installer).to receive(:install)

data/spec/unit/policyfile/cookbook_locks_spec.rb

@@ -106,6 +106,14 @@ shared_examples_for "Cookbook Lock" do
       expect(cookbook_lock.dependencies).to eq(deps)
     end
 
+    it "delegates #installed? to the CookbookLocationSpecification" do
+      location_spec = cookbook_lock.cookbook_location_spec
+      expect(location_spec).to receive(:installed?).and_return(true)
+      expect(cookbook_lock).to be_installed
+      expect(location_spec).to receive(:installed?).and_return(false)
+      expect(cookbook_lock).to_not be_installed
+    end
+
   end
 
   context "when created from lock data" do
@@ -115,7 +123,9 @@ shared_examples_for "Cookbook Lock" do
         "identifier" => "my-opaque-id",
         "dotted_decimal_identifier" => "123.456.789",
         "version" => "1.2.3",
-        "source_options" => { "sourcekey" => "location info" }
+        "source_options" => { "sourcekey" => "location info" },
+        "cache_key" => nil,
+        "source" => "cookbooks_local_path"
       }
     end
 
@@ -244,7 +254,8 @@ describe ChefDK::Policyfile::LocalCookbook do
         "source" => "../my_repo/nginx",
         "source_options" => {
           "path" => "../my_repo/nginx"
-        }
+        },
+        "cache_key" => nil
       }
     end
 

data/spec/unit/policyfile/reports/install_spec.rb

@@ -0,0 +1,115 @@
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef-dk/policyfile/reports/install'
+
+# Used for verifying doubles
+require 'chef-dk/policyfile_compiler'
+require 'chef-dk/policyfile/cookbook_location_specification'
+
+describe ChefDK::Policyfile::Reports::Install do
+
+  let(:ui) { TestHelpers::TestUI.new }
+
+  let(:policyfile_compiler) { instance_double("ChefDK::PolicyfileCompiler") }
+
+  subject(:install_report) { described_class.new(ui: ui, policyfile_compiler: policyfile_compiler ) }
+
+  it "has a UI object" do
+    expect(install_report.ui).to eq(ui)
+  end
+
+  it "has a policyfile compiler" do
+    expect(install_report.policyfile_compiler).to eq(policyfile_compiler)
+  end
+
+  describe "when printing an installation report for fixed version cookbooks" do
+
+    let(:fixed_version_cookbook_one) do
+      instance_double("ChefDK::Policyfile::CookbookLocationSpecification",
+                      installed?: false,
+                      name: "short-name",
+                      version_constraint: ">= 0.0.0",
+                      source_type: :git)
+    end
+
+    let(:fixed_version_cookbook_two) do
+      instance_double("ChefDK::Policyfile::CookbookLocationSpecification",
+                      installed?: true,
+                      name: "this-name-is-longer",
+                      version_constraint: "~> 10.0.0",
+                      source_type: :path)
+    end
+
+    let(:fixed_version_cookbooks) do
+      { "short-name" => fixed_version_cookbook_one, "this-name-is-longer" => fixed_version_cookbook_two }
+    end
+
+    before do
+      allow(policyfile_compiler).to receive(:fixed_version_cookbooks_specs).and_return(fixed_version_cookbooks)
+    end
+
+    it "prints a table-ized message for cookbooks being installed" do
+      install_report.installing_fixed_version_cookbook(fixed_version_cookbook_one)
+      expect(ui.output).to eq("Installing short-name          >= 0.0.0 from git\n")
+    end
+
+    it "prints a table-ized message for cookbooks in the cache that are reused" do
+      install_report.installing_fixed_version_cookbook(fixed_version_cookbook_two)
+      expect(ui.output).to eq("Using      this-name-is-longer ~> 10.0.0 from path\n")
+    end
+
+  end
+
+  describe "when printing an installation report for normal dependencies" do
+
+    let(:cookbook_one) do
+      instance_double("ChefDK::Policyfile::CookbookLocationSpecification",
+                      installed?: false,
+                      name: "short-name",
+                      version_constraint: Semverse::Constraint.new("= 10.0.4"))
+    end
+
+    let(:cookbook_two) do
+      instance_double("ChefDK::Policyfile::CookbookLocationSpecification",
+                      installed?: true,
+                      name: "this-name-is-longer",
+                      version_constraint: Semverse::Constraint.new("= 1.2.3"))
+    end
+
+    let(:graph_solution_cookbooks) do
+      { "short-name" => "10.0.4", "this-name-is-longer" => "1.2.3" }
+    end
+
+    before do
+      allow(policyfile_compiler).to receive(:graph_solution).and_return(graph_solution_cookbooks)
+    end
+
+    it "prints a table-ized message for cookbooks being installed" do
+      install_report.installing_cookbook(cookbook_one)
+      expect(ui.output).to eq("Installing short-name          10.0.4\n")
+    end
+
+    it "prints a table-ized message for cookbooks in the cache that are reused" do
+      install_report.installing_cookbook(cookbook_two)
+      expect(ui.output).to eq("Using      this-name-is-longer 1.2.3\n")
+    end
+
+  end
+end
+

data/spec/unit/policyfile/reports/upload_spec.rb

@@ -0,0 +1,96 @@
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'chef-dk/policyfile/reports/upload'
+
+# For the LockedCookbookForUpload class:
+require 'chef-dk/policyfile/uploader'
+
+# Used for verifying doubles
+require 'chef-dk/policyfile/cookbook_locks'
+
+describe ChefDK::Policyfile::Reports::Upload do
+
+  let(:ui) { TestHelpers::TestUI.new }
+
+  let(:reused_cookbooks) { [] }
+
+  let(:uploaded_cookbooks) { [] }
+
+  subject(:upload_report) { described_class.new(ui: ui, reused_cbs: reused_cookbooks, uploaded_cbs: uploaded_cookbooks) }
+
+  it "has a ui object" do
+    expect(upload_report.ui).to eq(ui)
+  end
+
+  it "has a list of cookbooks that are being uploaded" do
+    expect(upload_report.uploaded_cbs).to equal(uploaded_cookbooks)
+  end
+
+  it "has a list of cookbooks that would be uploaded but are already on the server" do
+    expect(upload_report.reused_cbs).to equal(reused_cookbooks)
+  end
+
+  describe "reporting uploaded and reused cookbooks" do
+
+    def cb_with_lock(name, version, identifier)
+      lock = instance_double("ChefDK::Policyfile::CookbookLock",
+                             name: name,
+                             version: version,
+                             identifier: identifier)
+
+      ChefDK::Policyfile::Uploader::LockedCookbookForUpload.new(nil, lock)
+    end
+
+    let(:cookbook_one) do
+      cb_with_lock("short-name", "10.11.12", "49582c3db4e3b54674ecfb57fe82157720350274")
+    end
+
+    let(:cookbook_two) do
+      cb_with_lock("a-longer-named-cookbook", "1.0.0", "e4ac353bebdc949cd2cd8ce69983a56b96917dfa")
+    end
+
+    let(:reused_cookbooks) { [ cookbook_one, cookbook_two ] }
+
+    let(:cookbook_three) do
+      cb_with_lock("foo", "1.2.42", "cb61daebfb0d255cae928ca1a92db29b055755cf")
+    end
+
+    let(:cookbook_four) do
+      cb_with_lock("barbazqux", "12.34.5678", "1241ea6f9866d0e61d11129bb32e5fc96cd2bac0")
+    end
+
+    let(:uploaded_cookbooks) { [ cookbook_three, cookbook_four ] }
+
+    it "prints a table showing the re-used and uploaded cookbooks" do
+      upload_report.show
+
+      expected_output = <<-E
+Using    short-name              10.11.12   (49582c3d)
+Using    a-longer-named-cookbook 1.0.0      (e4ac353b)
+Uploaded foo                     1.2.42     (cb61daeb)
+Uploaded barbazqux               12.34.5678 (1241ea6f)
+E
+      expect(ui.output).to eq(expected_output)
+    end
+
+  end
+
+end
+
+