chef-dk 0.2.0 → 0.2.1

data/spec/unit/command/generator_commands/recipe_spec.rb

@@ -0,0 +1,32 @@
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'shared/a_file_generator'
+require 'chef-dk/command/generator_commands/recipe'
+
+describe ChefDK::Command::GeneratorCommands::Recipe do
+
+  include_examples "a file generator" do
+
+    let(:generator_name) { "recipe" }
+    let(:generated_files) { [ "recipes/new_recipe.rb" ] }
+    let(:new_file_name) { "new_recipe" }
+
+  end
+end
+

data/spec/unit/command/generator_commands/repo_spec.rb

@@ -0,0 +1,287 @@
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'shared/a_generated_file'
+require 'chef-dk/command/generator_commands/repo'
+
+describe ChefDK::Command::GeneratorCommands::Repo do
+
+  let(:argv) { %w[new_repo] }
+
+  let(:stdout_io) { StringIO.new }
+  let(:stderr_io) { StringIO.new }
+
+  let(:expected_cookbook_file_relpaths) do
+    %w[
+      LICENSE
+    ]
+  end
+
+  let(:file) { "" }
+  let(:file_path) { File.join(repo_path, file) }
+  let(:file_contents) { File.read(file_path) }
+  let(:repo_path) { File.join(tempdir, "new_repo") }
+
+  let(:expected_cookbook_files) do
+    expected_cookbook_file_relpaths.map do |relpath|
+      File.join(tempdir, "new_repo", relpath)
+    end
+  end
+
+  subject(:generator) { described_class.new(argv) }
+
+  def generator_context
+    ChefDK::Generator.context
+  end
+
+  before do
+    ChefDK::Generator.reset
+  end
+
+  context "when given the name of the repo to generate" do
+
+    before do
+      reset_tempdir
+    end
+
+    it "configures the generator context" do
+      generator.read_and_validate_params
+      generator.setup_context
+      expect(generator_context.repo_root).to eq(Dir.pwd)
+      expect(generator_context.repo_name).to eq("new_repo")
+    end
+
+    it "creates a new repo" do
+      Dir.chdir(tempdir) do
+        allow(generator.chef_runner).to receive(:stdout).and_return(stdout_io)
+        generator.run
+      end
+      generated_files = Dir.glob(File.join(tempdir, "new_repo", "**", "*"), File::FNM_DOTMATCH)
+      expected_cookbook_files.each do |expected_file|
+        expect(generated_files).to include(expected_file)
+      end
+    end
+
+    describe "generated files" do
+      before do
+        Dir.chdir(tempdir) do
+          allow(generator.chef_runner).to receive(:stdout).and_return(stdout_io)
+          generator.run
+        end
+      end
+
+      describe "LICENSE" do
+        let(:file) { "LICENSE" }
+
+        context "all_rights" do
+          it "is the default" do
+            expect(file_contents).to match(/Copyright \d\d\d\d/)
+            expect(file_contents).to match(/All rights reserved, do not redistribute/)
+          end
+
+          context "with copyright_holder" do
+            let(:argv) { ["new_repo", "-C", "Adam Jacob"] }
+            it "includes the name" do
+              expect(file_contents).to match(/Copyright \d\d\d\d Adam Jacob/)
+            end
+          end
+        end
+
+        context "apache2" do
+          let(:argv) { ["new_repo", "-I", "apache2" ] }
+
+          it "is the apache license" do
+            expect(file_contents).to match(/Apache License/)
+            expect(file_contents).to match(/Version 2.0/)
+          end
+        end
+
+        context "mit" do
+          let(:argv) { ["new_repo", "-I", "mit" ] }
+
+          it "is the mit license" do
+            expect(file_contents).to match(/The MIT License \(MIT\)/)
+          end
+
+          context "with copyright_holder" do
+            let(:argv) { ["new_repo", "-I", "mit", "-C", "Adam Jacob"] }
+            it "includes the name" do
+              expect(file_contents).to match(/Copyright \(c\) \d\d\d\d Adam Jacob/)
+            end
+          end
+        end
+
+        context "gplv2" do
+          let(:argv) { ["new_repo", "-I", "gplv2" ] }
+
+          it "is the GPL version 2 license" do
+            expect(file_contents).to match(/GNU GENERAL PUBLIC LICENSE/)
+            expect(file_contents).to match(/Version 2, June 1991/)
+          end
+        end
+
+        context "gplv3" do
+          let(:argv) { ["new_repo", "-I", "gplv3" ] }
+
+          it "is the GPL version 2 license" do
+            expect(file_contents).to match(/GNU GENERAL PUBLIC LICENSE/)
+            expect(file_contents).to match(/Version 3, 29 June 2007/)
+          end
+        end
+      end
+
+      describe "README.md" do
+        let(:file) { "README.md" }
+
+        it "is the standard readme" do
+          expect(file_contents).to match(/Every Chef installation needs a Chef Repository/)
+        end
+      end
+
+      describe "Rakefile" do
+        let(:file) { "Rakefile" }
+
+        it "loads the common tasks" do
+          expect(file_contents).to match(/load 'chef\/tasks\/chef_repo\.rake'/)
+        end
+      end
+
+      describe "chefignore" do
+        let(:file) { "chefignore" }
+
+        it "has the preamble" do
+          expect(file_contents).to match(/Put files\/directories that should be ignored in this file when uploading/)
+        end
+      end
+
+      describe ".gitignore" do
+        let(:file) { ".gitignore" }
+
+        it "has the right contents" do
+          expect(file_contents).to match(/\.rake_test_cache/)
+          expect(file_contents).to match(/\.chef\/\*\.pem/)
+          expect(file_contents).to match(/\.chef\/encrypted_data_bag_secret/)
+          expect(file_contents).to_not match(/cookbooks\/\*\*/)
+        end
+
+        context "with --policy-only" do
+          let(:argv) { ["new_repo", "--policy-only" ] }
+
+          it "blocks cookbooks" do
+            expect(file_contents).to match(/cookbooks\/\*\*/)
+            expect(file_contents).to match(/cookbooks\/README\.md/)
+          end
+        end
+      end
+
+      describe "certificates" do
+        describe "README.md" do
+          let(:file) { "certificates/README.md" }
+
+          it "has the right contents" do
+            expect(file_contents).to match(/rake ssl_cert FQDN=monitoring.example.com/)
+          end
+        end
+      end
+
+      describe "cookbooks" do
+        describe "README.md" do
+          let(:file) { "cookbooks/README.md" }
+
+          it "has the right contents" do
+            expect(file_contents).to match(/This directory contains the cookbooks/)
+          end
+
+          context "with --policy-only" do
+            let(:argv) { ["new_repo", "--policy-only" ] }
+
+            it "tells you whats up" do
+              expect(file_contents).to match(/This directory typically contains Chef cookbooks/)
+            end
+          end
+        end
+      end
+
+      describe "data_bags" do
+        describe "README.md" do
+          let(:file) { "data_bags/README.md" }
+
+          it "has the right contents" do
+            expect(file_contents).to match(/This directory contains directories of the various data bags/)
+          end
+        end
+      end
+
+      describe "environments" do
+        describe "README.md" do
+          let(:file) { "environments/README.md" }
+
+          it "has the right contents" do
+            expect(file_contents).to match(/This directory is for Ruby DSL and JSON files for environments\./)
+          end
+        end
+      end
+
+      describe "roles" do
+        describe "README.md" do
+          let(:file) { "roles/README.md" }
+
+          it "has the right contents" do
+            expect(file_contents).to match(/Create roles here/)
+          end
+        end
+      end
+
+      describe "config" do
+        describe "rake.rb" do
+          let(:file) { "config/rake.rb" }
+
+          it "has the preamble" do
+            expect(file_contents).to match(/Configure the Rakefile's tasks\./)
+          end
+
+          it "defaults the copyright to The Authors" do
+            expect(file_contents).to match(/COMPANY_NAME = "The Authors"/)
+          end
+
+          it "defaults the license to all_rights" do
+            expect(file_contents).to match(/NEW_COOKBOOK_LICENSE = :all_rights/)
+          end
+
+          context "with a license" do
+            let(:argv) { ["new_repo", "-I", "gplv3" ] }
+
+            it "uses the license" do
+              expect(file_contents).to match(/NEW_COOKBOOK_LICENSE = :gplv3/)
+            end
+          end
+
+          context "with a copyright holder" do
+            let(:argv) { ["new_repo", "-C", "GiantCo, Inc." ] }
+
+            it "uses the copyright holder" do
+              expect(file_contents).to match(/COMPANY_NAME = "GiantCo, Inc\."/)
+            end
+          end
+        end
+      end
+    end
+  end
+end
+
+

data/spec/unit/command/generator_commands/template_spec.rb

@@ -0,0 +1,32 @@
+#
+# Copyright:: Copyright (c) 2014 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'shared/a_file_generator'
+require 'chef-dk/command/generator_commands/template'
+
+describe ChefDK::Command::GeneratorCommands::Template do
+
+  include_examples "a file generator" do
+
+    let(:generator_name) { "template" }
+    let(:generated_files) { [ "templates/default/new_template.txt.erb" ] }
+    let(:new_file_name) { "new_template.txt" }
+
+  end
+end
+

data/spec/unit/command/shell_init_spec.rb

@@ -25,8 +25,8 @@ describe ChefDK::Command::ShellInit do
 
   let(:command_instance) do
     ChefDK::Command::ShellInit.new.tap do |c|
-      c.stub(:stdout).and_return(stdout_io)
-      c.stub(:stderr).and_return(stderr_io)
+      allow(c).to receive(:stdout).and_return(stdout_io)
+      allow(c).to receive(:stderr).and_return(stderr_io)
     end
   end
 
@@ -57,8 +57,8 @@ EOH
     let(:omnibus_embedded_bin_dir) { "/foo/embedded/bin" }
 
     before do
-      command_instance.stub(:omnibus_embedded_bin_dir).and_return(omnibus_embedded_bin_dir)
-      command_instance.stub(:omnibus_bin_dir).and_return(omnibus_bin_dir)
+      allow(command_instance).to receive(:omnibus_embedded_bin_dir).and_return(omnibus_embedded_bin_dir)
+      allow(command_instance).to receive(:omnibus_bin_dir).and_return(omnibus_bin_dir)
     end
 
     it "emits a script to add ChefDK's ruby to the shell environment" do

data/spec/unit/command/verify_spec.rb

@@ -40,7 +40,7 @@ describe ChefDK::Command::Verify do
 
   it "defines berks, tk, chef and chef-dk components by default" do
     expect(command_instance.components).not_to be_empty
-    expect(command_instance.components.map(&:name)).to match_array(%w{berkshelf test-kitchen chef-client chef-dk})
+    expect(command_instance.components.map(&:name)).to match_array(%w{berkshelf test-kitchen chef-client chef-dk chefspec})
   end
 
   it "has a usage banner" do
@@ -49,22 +49,22 @@ describe ChefDK::Command::Verify do
 
   describe "when locating omnibus directory" do
     it "should find omnibus app directory from ruby path" do
-      Gem.stub(:ruby).and_return(File.join(fixtures_path, "eg_omnibus_dir/valid/embedded/bin/ruby"))
+      allow(Gem).to receive(:ruby).and_return(File.join(fixtures_path, "eg_omnibus_dir/valid/embedded/bin/ruby"))
       expect(command_instance.omnibus_apps_dir).to include("eg_omnibus_dir/valid/embedded")
     end
 
     it "should raise OmnibusInstallNotFound if directory is not looking like omnibus" do
-      Gem.stub(:ruby).and_return(File.join(fixtures_path,".rbenv/versions/2.1.1/bin/ruby"))
+      allow(Gem).to receive(:ruby).and_return(File.join(fixtures_path,".rbenv/versions/2.1.1/bin/ruby"))
       expect{command_instance.omnibus_apps_dir}.to raise_error(ChefDK::OmnibusInstallNotFound)
     end
 
     it "raises OmnibusInstallNotFound if omnibus directory doesn't exist" do
-      Gem.stub(:ruby).and_return(File.join(fixtures_path,"eg_omnibus_dir/missing_apps/embedded/bin/ruby"))
+      allow(Gem).to receive(:ruby).and_return(File.join(fixtures_path,"eg_omnibus_dir/missing_apps/embedded/bin/ruby"))
       expect{command_instance.omnibus_apps_dir}.to raise_error(ChefDK::OmnibusInstallNotFound)
     end
 
     it "raises MissingComponentError when a component doesn't exist" do
-      Gem.stub(:ruby).and_return(File.join(fixtures_path,"eg_omnibus_dir/missing_component/embedded/bin/ruby"))
+      allow(Gem).to receive(:ruby).and_return(File.join(fixtures_path,"eg_omnibus_dir/missing_component/embedded/bin/ruby"))
       expect{command_instance.validate_components!}.to raise_error(ChefDK::MissingComponentError)
     end
   end
@@ -133,9 +133,9 @@ describe ChefDK::Command::Verify do
     end
 
     before do
-      Gem.stub(:ruby).and_return(ruby_path)
-      command_instance.stub(:stdout).and_return(stdout_io)
-      command_instance.stub(:components).and_return(components)
+      allow(Gem).to receive(:ruby).and_return(ruby_path)
+      allow(command_instance).to receive(:stdout).and_return(stdout_io)
+      allow(command_instance).to receive(:components).and_return(components)
     end
 
     context "when running smoke tests only" do
@@ -268,7 +268,7 @@ describe ChefDK::Command::Verify do
         it "should report the output of the first verification first" do
           index_first = stdout.index("you are good to go...")
           index_second = stdout.index("my friend everything is good...")
-          expect(index_second > index_first).to be_true
+          expect(index_second > index_first).to be true
         end
 
         context "and components are filtered by CLI args" do

data/spec/unit/commands_map_spec.rb

@@ -31,7 +31,7 @@ describe ChefDK::CommandsMap do
   end
 
   it "defines a subcommand mapping" do
-    expect(mapping.have_command?("example")).to be_true
+    expect(mapping.have_command?("example")).to be true
   end
 
   it "infers a non-hypenated command's require path" do

data/spec/unit/component_test_spec.rb

@@ -69,17 +69,17 @@ describe ChefDK::ComponentTest do
 
     it "defines a unit test block" do
       component.run_unit_test
-      expect(result[:unit_test]).to be_true
+      expect(result[:unit_test]).to be true
     end
 
     it "defines an integration test block" do
       component.run_integration_test
-      expect(result[:integration_test]).to be_true
+      expect(result[:integration_test]).to be true
     end
 
     it "defines a smoke test block" do
       component.run_smoke_test
-      expect(result[:smoke_test]).to be_true
+      expect(result[:smoke_test]).to be true
     end
 
   end