chef-cli 5.6.18 → 5.6.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fbbeb4dc40f0845a31ea81d5272fbaec1ea1ef3d7ac8c1d5c60aa859819f53c
-  data.tar.gz: 51b13e0cf48bfd7e5786a3a8ed5cd94f99275b01d7d54e8cbd4c2df97b1af038
+  metadata.gz: f219b019dc29d8ccf36df3de27450d1353ce9afc04b88c99c1700b9f828725ab
+  data.tar.gz: a0230c8cde5ba86ce76b8d347bd700cf24b75faf42517b1c1bb7f09a854e9dda
 SHA512:
-  metadata.gz: 2e7487d02d583a1c61214cfe26cfeaeef7e39ecb3a312d2ff0cbff429f2c7e40cfe316fb364822c828d5d8fa27f0d6627f16e66d5d1d43b8be08c01b43845241
-  data.tar.gz: 9ad0ff08c0060f3420a77a1fd1b7d06cd748507475338213b809adb10dea7e445ace9d0b7508d74b97045f37bf8a837ca699acbf39d59d70fed5d77d656f5705
+  metadata.gz: fc9e29b56a5ad7904ffc6fc802fbb4bc87a0ddb19c2e51a7fd3abc491e53112769dda9e00370a970a6a220bde816cd0d17a0f4b7cafc4616ea14770173d6d7ac
+  data.tar.gz: d0774dde0d1ac8c48d55a90c6ee7b658467b3ed97f451c1f2e21a966f1c6d68305a923d6259dd0ccaee684f3a529b080fbcc77c2fddcbc2950035d54c1bd81da

data/lib/chef-cli/policyfile/comparison_base.rb

@@ -43,7 +43,7 @@ module ChefCLI
           raise LockfileNotFound, "Expected lockfile at #{policyfile_lock_relpath} does not exist" unless File.exist?(policyfile_lock_relpath)
           raise LockfileNotFound, "Expected lockfile at #{policyfile_lock_relpath} cannot be read" unless File.readable?(policyfile_lock_relpath)
 
-          FFI_Yajl::Parser.parse(IO.read(policyfile_lock_relpath))
+          FFI_Yajl::Parser.parse(File.read(policyfile_lock_relpath))
         rescue FFI_Yajl::ParseError => e
           raise MalformedLockfile, "Invalid JSON in lockfile at #{policyfile_lock_relpath}:\n  #{e.message}"
         end

data/lib/chef-cli/policyfile/local_lock_fetcher.rb

@@ -102,7 +102,7 @@ module ChefCLI
       end
 
       def content
-        IO.read(path)
+        File.read(path)
       end
 
       def path

data/lib/chef-cli/policyfile/undo_stack.rb

@@ -109,7 +109,7 @@ module ChefCLI
       end
 
       def load_undo_record(file)
-        data = FFI_Yajl::Parser.parse(IO.read(file))
+        data = FFI_Yajl::Parser.parse(File.read(file))
         UndoRecord.new.load(data)
       end
 

data/lib/chef-cli/policyfile_lock.rb

@@ -64,7 +64,7 @@ module ChefCLI
       end
     end
 
-    RUN_LIST_ITEM_FORMAT = /\Arecipe\[[^\s]+::[^\s]+\]\Z/
+    RUN_LIST_ITEM_FORMAT = /\Arecipe\[([^:\s][^:\s]{0,254})::([^:\s][^:\s]{0,254})\]\Z/
 
     def self.build(storage_config)
       lock = new(storage_config)

data/lib/chef-cli/policyfile_services/export_repo.rb

@@ -78,7 +78,7 @@ module ChefCLI
       end
 
       def policy_data
-        @policy_data ||= FFI_Yajl::Parser.parse(IO.read(policyfile_lock_expanded_path))
+        @policy_data ||= FFI_Yajl::Parser.parse(File.read(policyfile_lock_expanded_path))
       rescue => error
         raise PolicyfileExportRepoError.new("Error reading lockfile #{policyfile_lock_expanded_path}", error)
       end

data/lib/chef-cli/policyfile_services/install.rb

@@ -69,7 +69,7 @@ module ChefCLI
       end
 
       def policyfile_content
-        @policyfile_content ||= IO.read(policyfile_expanded_path)
+        @policyfile_content ||= File.read(policyfile_expanded_path)
       end
 
       def policyfile_compiler
@@ -81,7 +81,7 @@ module ChefCLI
       end
 
       def policyfile_lock_content
-        @policyfile_lock_content ||= IO.read(policyfile_lock_expanded_path) if File.exist?(policyfile_lock_expanded_path)
+        @policyfile_lock_content ||= File.read(policyfile_lock_expanded_path) if File.exist?(policyfile_lock_expanded_path)
       end
 
       def policyfile_lock

data/lib/chef-cli/policyfile_services/push.rb

@@ -57,7 +57,7 @@ module ChefCLI
       end
 
       def policy_data
-        @policy_data ||= FFI_Yajl::Parser.parse(IO.read(policyfile_lock_expanded_path))
+        @policy_data ||= FFI_Yajl::Parser.parse(File.read(policyfile_lock_expanded_path))
       rescue => error
         raise PolicyfilePushError.new("Error reading lockfile #{policyfile_lock_expanded_path}", error)
       end

data/lib/chef-cli/policyfile_services/push_archive.rb

@@ -120,7 +120,7 @@ module ChefCLI
       end
 
       def load_policy_data(policyfile_lock_path)
-        FFI_Yajl::Parser.parse(IO.read(policyfile_lock_path))
+        FFI_Yajl::Parser.parse(File.read(policyfile_lock_path))
       end
 
       def stage_unpacked_archive

data/lib/chef-cli/policyfile_services/update_attributes.rb

@@ -74,7 +74,7 @@ module ChefCLI
       end
 
       def policyfile_content
-        @policyfile_content ||= IO.read(policyfile_expanded_path)
+        @policyfile_content ||= File.read(policyfile_expanded_path)
       end
 
       def policyfile_compiler
@@ -82,7 +82,7 @@ module ChefCLI
       end
 
       def policyfile_lock_content
-        @policyfile_lock_content ||= IO.read(policyfile_lock_expanded_path)
+        @policyfile_lock_content ||= File.read(policyfile_lock_expanded_path)
       end
 
       def policyfile_lock

data/lib/chef-cli/skeletons/code_generator/recipes/cookbook_file.rb

@@ -13,7 +13,7 @@ end
 if context.content_source
 
   file cookbook_file_path do
-    content(IO.read(context.content_source))
+    content(File.read(context.content_source))
   end
 
 else

data/lib/chef-cli/skeletons/code_generator/recipes/template.rb

@@ -18,7 +18,7 @@ end
 if context.content_source
 
   file template_path do
-    content(IO.read(context.content_source))
+    content(File.read(context.content_source))
   end
 
 else

data/lib/chef-cli/skeletons/code_generator/templates/default/kitchen.yml.erb

@@ -30,7 +30,6 @@ platforms:
   - name: centos-stream-9
   - name: debian-12
   - name: fedora-latest
-  - name: freebsd-14
   - name: opensuse-leap-15
   - name: oraclelinux-9
   - name: rockylinux-9

data/lib/chef-cli/skeletons/code_generator/templates/default/kitchen_policyfile.yml.erb

@@ -26,7 +26,6 @@ platforms:
   - name: centos-stream-9
   - name: debian-12
   - name: fedora-latest
-  - name: freebsd-14
   - name: opensuse-leap-15
   - name: oraclelinux-9
   - name: rockylinux-9

data/lib/chef-cli/version.rb

@@ -16,5 +16,5 @@
 #
 
 module ChefCLI
-  VERSION = "5.6.18".freeze
+  VERSION = "5.6.20".freeze
 end

data/spec/shared/custom_generator_cookbook.rb

@@ -107,7 +107,7 @@ shared_examples_for "custom generator cookbook" do
         FileUtils.cp_r(default_generator_cookbook_path, generator_cookbook_path)
 
         # have to update metadata with the correct name
-        IO.binwrite(metadata_file, "name 'a_generator_cookbook'")
+        File.binwrite(metadata_file, "name 'a_generator_cookbook'")
       end
 
       it "creates the new files" do

data/spec/unit/command/generator_commands/cookbook_spec.rb

@@ -292,7 +292,7 @@ describe ChefCLI::Command::GeneratorCommands::Cookbook do
           let(:file) { File.join(tempdir, "new_cookbook", "kitchen.yml") }
 
           it "creates a kitchen.yml with the expected content" do
-            expect(IO.read(file)).to eq(expected_kitchen_yml_content)
+            expect(File.read(file)).to eq(expected_kitchen_yml_content)
           end
 
         end
@@ -323,7 +323,7 @@ describe ChefCLI::Command::GeneratorCommands::Cookbook do
         let(:file) { File.join(tempdir, "new_cookbook", "spec", "spec_helper.rb") }
 
         it "creates a spec/spec_helper.rb for ChefSpec with the expected content" do
-          expect(IO.read(file)).to eq(expected_chefspec_spec_helper_content)
+          expect(File.read(file)).to eq(expected_chefspec_spec_helper_content)
         end
 
       end
@@ -367,7 +367,7 @@ describe ChefCLI::Command::GeneratorCommands::Cookbook do
         end
 
         it "has a run_list and cookbook path that will work out of the box" do
-          expect(IO.read(file)).to eq(expected_content)
+          expect(File.read(file)).to eq(expected_content)
         end
 
       end
@@ -404,7 +404,6 @@ describe ChefCLI::Command::GeneratorCommands::Cookbook do
               - name: centos-stream-9
               - name: debian-12
               - name: fedora-latest
-              - name: freebsd-14
               - name: opensuse-leap-15
               - name: oraclelinux-9
               - name: rockylinux-9
@@ -475,8 +474,8 @@ describe ChefCLI::Command::GeneratorCommands::Cookbook do
         end
 
         it "has a default.yml file with template contents" do
-          expect(IO.read(file)).to match(expected_content_header)
-          expect(IO.read(file)).to match(expected_content)
+          expect(File.read(file)).to match(expected_content_header)
+          expect(File.read(file)).to match(expected_content)
         end
 
       end
@@ -507,7 +506,7 @@ describe ChefCLI::Command::GeneratorCommands::Cookbook do
         end
 
         it "pulls deps from metadata" do
-          expect(IO.read(file)).to eq(expected_content)
+          expect(File.read(file)).to eq(expected_content)
         end
 
       end
@@ -548,7 +547,6 @@ describe ChefCLI::Command::GeneratorCommands::Cookbook do
               - name: centos-stream-9
               - name: debian-12
               - name: fedora-latest
-              - name: freebsd-14
               - name: opensuse-leap-15
               - name: oraclelinux-9
               - name: rockylinux-9

data/spec/unit/command/generator_commands/generator_generator_spec.rb

@@ -179,7 +179,7 @@ describe ChefCLI::Command::GeneratorCommands::GeneratorGenerator do
         generator_generator.run
 
         metadata_path = File.join(target_dir, "metadata.rb")
-        metadata_content = IO.read(metadata_path)
+        metadata_content = File.read(metadata_path)
         expected_metadata = <<~METADATA
           name             File.basename(File.dirname(__FILE__))
           description      'Custom code generator cookbook for use with #{ChefCLI::Dist::PRODUCT}'

data/spec/unit/command/generator_commands/policyfile_spec.rb

@@ -174,7 +174,7 @@ describe ChefCLI::Command::GeneratorCommands::Policyfile do
       end
 
       it "adds chef_repo as a default source and uses argv for the policy name" do
-        expect(IO.read(expected_policyfile_path)).to eq(expected_policyfile_content)
+        expect(File.read(expected_policyfile_path)).to eq(expected_policyfile_content)
       end
 
     end
@@ -200,7 +200,7 @@ describe ChefCLI::Command::GeneratorCommands::Policyfile do
       end
 
       it "adds chef_repo as a default source" do
-        expect(IO.read(expected_policyfile_path)).to eq(expected_policyfile_content)
+        expect(File.read(expected_policyfile_path)).to eq(expected_policyfile_content)
       end
 
     end

data/spec/unit/policyfile/artifactory_cookbook_source_spec.rb

@@ -27,9 +27,9 @@ describe ChefCLI::Policyfile::ArtifactoryCookbookSource do
 
   let(:http_connection) { double("Chef::HTTP::Simple") }
 
-  let(:universe_response_encoded) { IO.read(File.join(fixtures_path, "cookbooks_api/small_universe.json")) }
+  let(:universe_response_encoded) { File.read(File.join(fixtures_path, "cookbooks_api/small_universe.json")) }
 
-  let(:pruned_universe) { JSON.parse(IO.read(File.join(fixtures_path, "cookbooks_api/pruned_small_universe.json"))) }
+  let(:pruned_universe) { JSON.parse(File.read(File.join(fixtures_path, "cookbooks_api/pruned_small_universe.json"))) }
 
   describe "fetching the Universe graph" do
 

data/spec/unit/policyfile/chef_server_cookbook_source_spec.rb

@@ -25,9 +25,9 @@ describe ChefCLI::Policyfile::ChefServerCookbookSource do
 
   let(:http_connection) { double("Chef::ServerAPI") }
 
-  let(:universe_response_encoded) { JSON.parse(IO.read(File.join(fixtures_path, "cookbooks_api/chef_server_universe.json"))) }
+  let(:universe_response_encoded) { JSON.parse(File.read(File.join(fixtures_path, "cookbooks_api/chef_server_universe.json"))) }
 
-  let(:pruned_universe) { JSON.parse(IO.read(File.join(fixtures_path, "cookbooks_api/pruned_chef_server_universe.json"))) }
+  let(:pruned_universe) { JSON.parse(File.read(File.join(fixtures_path, "cookbooks_api/pruned_chef_server_universe.json"))) }
 
   describe "fetching the Universe graph" do
 

data/spec/unit/policyfile/community_cookbook_source_spec.rb

@@ -26,9 +26,9 @@ describe ChefCLI::Policyfile::CommunityCookbookSource do
 
   let(:http_connection) { double("Chef::HTTP::Simple") }
 
-  let(:universe_response_encoded) { IO.read(File.join(fixtures_path, "cookbooks_api/small_universe.json")) }
+  let(:universe_response_encoded) { File.read(File.join(fixtures_path, "cookbooks_api/small_universe.json")) }
 
-  let(:pruned_universe) { JSON.parse(IO.read(File.join(fixtures_path, "cookbooks_api/pruned_small_universe.json"))) }
+  let(:pruned_universe) { JSON.parse(File.read(File.join(fixtures_path, "cookbooks_api/pruned_small_universe.json"))) }
 
   it "defaults to using the public supermarket over HTTPS" do
     expect(cookbook_source.uri).to eq(default_community_uri)

data/spec/unit/policyfile/delivery_supermarket_source_spec.rb

@@ -26,7 +26,7 @@ describe ChefCLI::Policyfile::DeliverySupermarketSource do
 
   let(:http_connection) { double("Chef::HTTP::Simple") }
 
-  let(:universe_response_encoded) { IO.read(File.join(fixtures_path, "cookbooks_api/small_universe.json")) }
+  let(:universe_response_encoded) { File.read(File.join(fixtures_path, "cookbooks_api/small_universe.json")) }
 
   let(:truncated_universe) do
     {

data/spec/unit/policyfile/undo_stack_spec.rb

@@ -97,7 +97,7 @@ describe ChefCLI::Policyfile::UndoStack do
       it "creates the undo record" do
         expect(undo_stack_files.size).to eq(1)
 
-        undo_record_json = IO.read(undo_stack_files.first)
+        undo_record_json = File.read(undo_stack_files.first)
         undo_record_data = FFI_Yajl::Parser.parse(undo_record_json)
         expect(undo_record_data).to eq(undo_record.for_serialization)
       end

data/spec/unit/policyfile_lock_build_spec.rb

@@ -867,6 +867,24 @@ describe ChefCLI::PolicyfileLock, "building a lockfile", :skip_on_windows do
 
   end
 
+  context "with invalid run list items" do
+    it "detects invalid format in run list items with extra colons" do
+      expect("recipe[cookbook:default::invalid]").not_to match(ChefCLI::PolicyfileLock::RUN_LIST_ITEM_FORMAT)
+    end
+
+    it "detects invalid format when a run list item has no cookbook name" do
+      expect("recipe[::recipe_name]").not_to match(ChefCLI::PolicyfileLock::RUN_LIST_ITEM_FORMAT)
+    end
+
+    it "detects invalid format when a run list item has no recipe name" do
+      expect("recipe[cookbook::]").not_to match(ChefCLI::PolicyfileLock::RUN_LIST_ITEM_FORMAT)
+    end
+
+    it "validates proper recipe format correctly" do
+      expect("recipe[cookbook::recipe_name]").to match(ChefCLI::PolicyfileLock::RUN_LIST_ITEM_FORMAT)
+    end
+  end
+
   describe "building a policyfile lock from a policyfile compiler" do
 
     include_context "setup git cookbooks"

data/spec/unit/policyfile_lock_validation_spec.rb

@@ -124,7 +124,7 @@ describe ChefCLI::PolicyfileLock, "validating locked cookbooks" do
         version          '2.3.4'
 
       E
-      expect(IO.read(metadata_path)).to eq(expected_metadata_rb)
+      expect(File.read(metadata_path)).to eq(expected_metadata_rb)
     end
 
     context "when the cookbook is missing" do
@@ -551,7 +551,7 @@ describe ChefCLI::PolicyfileLock, "validating locked cookbooks" do
         version          '1.0.0'
 
       E
-      expect(IO.read(metadata_path)).to eq(expected_metadata_rb)
+      expect(File.read(metadata_path)).to eq(expected_metadata_rb)
     end
 
     context "when the cookbook missing" do

data/spec/unit/policyfile_services/export_repo_spec.rb

@@ -239,19 +239,19 @@ describe ChefCLI::PolicyfileServices::ExportRepo do
           # shell out to git for the version number, etc.
           it "writes metadata.json in the exported cookbook, removing metadata.rb" do
             metadata_json_path = File.join(exported_cookbook_root, "metadata.json")
-            metadata_json = FFI_Yajl::Parser.parse(IO.read(metadata_json_path))
+            metadata_json = FFI_Yajl::Parser.parse(File.read(metadata_json_path))
             expect(metadata_json["version"]).to eq("2.3.4")
           end
 
           it "copies the policyfile lock to policies/POLICY_NAME.json" do
             exported_policy_path = File.join(export_dir, "policies", "install-example-#{revision_id}.json")
-            exported_policy_json = IO.read(exported_policy_path)
+            exported_policy_json = File.read(exported_policy_path)
             expect(exported_policy_json).to eq(FFI_Yajl::Encoder.encode(export_service.policyfile_lock.to_lock, pretty: true))
           end
 
           it "creates a policy_group file for the local policy group with the revision id of the exported policy" do
             exported_policy_group_path = File.join(export_dir, "policy_groups", "local.json")
-            exported_policy_group_data = FFI_Yajl::Parser.parse(IO.read(exported_policy_group_path))
+            exported_policy_group_data = FFI_Yajl::Parser.parse(File.read(exported_policy_group_path))
 
             expected_data = { "policies" => { "install-example" => { "revision_id" => revision_id } } }
 
@@ -260,7 +260,7 @@ describe ChefCLI::PolicyfileServices::ExportRepo do
 
           it "copies the policyfile lock in standard format to Policyfile.lock.json" do
             policyfile_lock_path = File.join(export_dir, "Policyfile.lock.json")
-            policyfile_lock_data = FFI_Yajl::Parser.parse(IO.read(policyfile_lock_path))
+            policyfile_lock_data = FFI_Yajl::Parser.parse(File.read(policyfile_lock_path))
             expected_lock_data = export_service.policyfile_lock.to_lock
 
             # stringify keys in source_options
@@ -301,7 +301,7 @@ describe ChefCLI::PolicyfileServices::ExportRepo do
             CONFIG
             config_path = File.join(export_dir, ".chef", "config.rb")
             expect(File).to exist(config_path)
-            expect(IO.read(config_path)).to eq(expected_config_text)
+            expect(File.read(config_path)).to eq(expected_config_text)
           end
 
           it "generates a README.md in the exported repo" do
@@ -313,7 +313,7 @@ describe ChefCLI::PolicyfileServices::ExportRepo do
             let(:policy_group) { "production" }
             it "creates a policy_group file for a specified policy group with the revision id of the exported policy" do
               exported_policy_group_path = File.join(export_dir, "policy_groups", "production.json")
-              exported_policy_group_data = FFI_Yajl::Parser.parse(IO.read(exported_policy_group_path))
+              exported_policy_group_data = FFI_Yajl::Parser.parse(File.read(exported_policy_group_path))
 
               expected_data = { "policies" => { "install-example" => { "revision_id" => revision_id } } }
 
@@ -351,7 +351,7 @@ describe ChefCLI::PolicyfileServices::ExportRepo do
               CONFIG
               config_path = File.join(export_dir, ".chef", "config.rb")
               expect(File).to exist(config_path)
-              expect(IO.read(config_path)).to eq(expected_config_text)
+              expect(File.read(config_path)).to eq(expected_config_text)
             end
           end
 

data/spec/unit/policyfile_services/install_spec.rb

@@ -68,7 +68,7 @@ describe ChefCLI::PolicyfileServices::Install do
 
   def result_policyfile_lock
     expect(File).to exist(policyfile_lock_path)
-    content = IO.read(policyfile_lock_path)
+    content = File.read(policyfile_lock_path)
     lock_data = FFI_Yajl::Parser.parse(content)
     ChefCLI::PolicyfileLock.new(storage_config).build_from_lock_data(lock_data)
   end

data/spec/unit/policyfile_services/update_attributes_spec.rb

@@ -151,7 +151,7 @@ describe ChefCLI::PolicyfileServices::UpdateAttributes do
 
     def result_policyfile_lock_data
       expect(File).to exist(policyfile_lock_path)
-      content = IO.read(policyfile_lock_path)
+      content = File.read(policyfile_lock_path)
       FFI_Yajl::Parser.parse(content)
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef-cli
 version: !ruby/object:Gem::Version
-  version: 5.6.18
+  version: 5.6.20
 platform: ruby
 authors:
 - Chef Software, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2025-03-28 00:00:00.000000000 Z
+date: 2025-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mixlib-cli
@@ -620,7 +620,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.3.27
 signing_key: 
 specification_version: 4
 summary: A streamlined development and deployment workflow for Chef platform.