chef-cli 3.1.3 → 5.1.0

data/spec/unit/helpers_spec.rb

@@ -0,0 +1,111 @@
+# Copyright:: Copyright (c) 2014-2018 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "chef-cli/helpers"
+
+describe ChefCLI::Helpers do
+  context "path_check!" do
+
+    before do
+      allow(Gem).to receive(:ruby).and_return(ruby_path)
+    end
+
+    context "when installed via omnibus" do
+      before do
+        allow(ChefCLI::Helpers).to receive(:omnibus_install?).and_return true
+      end
+
+      context "on unix" do
+
+        let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, "bin")) }
+        let(:omnibus_embedded_bin_dir) { "/opt/chef-workstation/embedded/bin" }
+        let(:omnibus_bin_dir) { "/opt/chef-workstation/bin" }
+        let(:expected_PATH) { [ omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV["PATH"].split(File::PATH_SEPARATOR) ] }
+        let(:expected_GEM_ROOT) { Gem.default_dir }
+        let(:expected_GEM_HOME) { Gem.user_dir }
+        let(:expected_GEM_PATH) { Gem.path.join(File::PATH_SEPARATOR) }
+        let(:ruby_path) { "/opt/chef-workstation/embedded/bin/ruby" }
+
+        it "#omnibus_env path" do
+          allow(ChefCLI::Helpers).to receive(:omnibus_bin_dir).and_return("/opt/chef-workstation/bin")
+          allow(ChefCLI::Helpers).to receive(:omnibus_embedded_bin_dir).and_return("/opt/chef-workstation/embedded/bin")
+          allow(ChefCLI::Helpers).to receive(:omnibus_env).and_return(
+            "PATH" => expected_PATH.flatten.uniq.join(File::PATH_SEPARATOR),
+            "GEM_ROOT" => expected_GEM_ROOT,
+            "GEM_HOME" => expected_GEM_HOME,
+            "GEM_PATH" => expected_GEM_PATH
+          )
+        end
+      end
+
+      context "on windows" do
+        let(:ruby_path) { "c:/opscode/chef-workstation/embedded/bin/ruby.exe" }
+        let(:user_bin_dir) { File.expand_path(File.join(Gem.user_dir, "bin")) }
+        let(:omnibus_embedded_bin_dir) { "c:/opscode/chef-workstation/embedded/bin" }
+        let(:omnibus_bin_dir) { "c:/opscode/chef-workstation/bin" }
+        let(:expected_GEM_ROOT) { Gem.default_dir }
+        let(:expected_GEM_HOME) { Gem.user_dir }
+        let(:expected_GEM_PATH) { Gem.path.join(File::PATH_SEPARATOR) }
+        let(:omnibus_root) { "c:/opscode/chef-workstation" }
+        let(:expected_PATH) { [ omnibus_bin_dir, user_bin_dir, omnibus_embedded_bin_dir, ENV["PATH"].split(File::PATH_SEPARATOR) ] }
+
+        before do
+          allow(ChefCLI::Helpers).to receive(:expected_omnibus_root).and_return(ruby_path)
+          allow(ChefCLI::Helpers).to receive(:omnibus_install?).and_return(true)
+          allow(Chef::Platform).to receive(:windows?).and_return(true)
+        end
+
+        it "#omnibus_env path" do
+          allow(ChefCLI::Helpers).to receive(:omnibus_bin_dir).and_return("c:/opscode/chef-workstation/bin")
+          allow(ChefCLI::Helpers).to receive(:omnibus_embedded_bin_dir).and_return("c:/opscode/chef-workstation/embedded/bin")
+          allow(ChefCLI::Helpers).to receive(:omnibus_env).and_return(
+            "PATH" => expected_PATH.flatten.uniq.join(File::PATH_SEPARATOR),
+            "GEM_ROOT" => expected_GEM_ROOT,
+            "GEM_HOME" => expected_GEM_HOME,
+            "GEM_PATH" => expected_GEM_PATH
+          )
+        end
+      end
+    end
+
+    context "when not installed via omnibus" do
+
+      before do
+        allow(ChefCLI::Helpers).to receive(:omnibus_install?).and_return false
+      end
+      let(:ruby_path) { "/Users/bog/.lots_o_rubies/2.1.2/bin/ruby" }
+      let(:expected_root_path) { "/Users/bog/.lots_o_rubies" }
+
+      before do
+        allow(File).to receive(:exist?).with(expected_root_path).and_return(false)
+
+        %i{
+          omnibus_root
+          omnibus_bin_dir
+          omnibus_embedded_bin_dir
+        }.each do |method_name|
+          allow(ChefCLI::Helpers).to receive(method_name).and_raise(ChefCLI::OmnibusInstallNotFound.new)
+        end
+      end
+
+      it "skips the sanity check without error" do
+
+      end
+
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef-cli
 version: !ruby/object:Gem::Version
-  version: 3.1.3
+  version: 5.1.0
 platform: ruby
 authors:
 - Chef Software, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-02 00:00:00.000000000 Z
+date: 2021-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mixlib-cli
@@ -240,7 +240,6 @@ files:
 - lib/chef-cli/command/generator_commands.rb
 - lib/chef-cli/command/generator_commands/attribute.rb
 - lib/chef-cli/command/generator_commands/base.rb
-- lib/chef-cli/command/generator_commands/build_cookbook.rb
 - lib/chef-cli/command/generator_commands/chef_exts/generator_desc_resource.rb
 - lib/chef-cli/command/generator_commands/chef_exts/quieter_doc_formatter.rb
 - lib/chef-cli/command/generator_commands/chef_exts/recipe_dsl_ext.rb
@@ -328,13 +327,9 @@ files:
 - lib/chef-cli/service_exceptions.rb
 - lib/chef-cli/shell_out.rb
 - lib/chef-cli/skeletons/code_generator/files/default/Berksfile
-- lib/chef-cli/skeletons/code_generator/files/default/build_cookbook/README.md
-- lib/chef-cli/skeletons/code_generator/files/default/build_cookbook/kitchen.yml
-- lib/chef-cli/skeletons/code_generator/files/default/build_cookbook/test-fixture-recipe.rb
 - lib/chef-cli/skeletons/code_generator/files/default/chefignore
 - lib/chef-cli/skeletons/code_generator/files/default/cookbook_readmes/README-policy.md
 - lib/chef-cli/skeletons/code_generator/files/default/cookbook_readmes/README.md
-- lib/chef-cli/skeletons/code_generator/files/default/delivery-config.json
 - lib/chef-cli/skeletons/code_generator/files/default/delivery-project.toml
 - lib/chef-cli/skeletons/code_generator/files/default/gitignore
 - lib/chef-cli/skeletons/code_generator/files/default/repo/README.md
@@ -354,7 +349,6 @@ files:
 - lib/chef-cli/skeletons/code_generator/files/default/spec_helper_policyfile.rb
 - lib/chef-cli/skeletons/code_generator/metadata.rb
 - lib/chef-cli/skeletons/code_generator/recipes/attribute.rb
-- lib/chef-cli/skeletons/code_generator/recipes/build_cookbook.rb
 - lib/chef-cli/skeletons/code_generator/recipes/cookbook.rb
 - lib/chef-cli/skeletons/code_generator/recipes/cookbook_file.rb
 - lib/chef-cli/skeletons/code_generator/recipes/helpers.rb
@@ -372,10 +366,8 @@ files:
 - lib/chef-cli/skeletons/code_generator/templates/default/Policyfile.rb.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/README.md.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/attribute.rb.erb
-- lib/chef-cli/skeletons/code_generator/templates/default/build_cookbook/Berksfile.erb
-- lib/chef-cli/skeletons/code_generator/templates/default/build_cookbook/metadata.rb.erb
-- lib/chef-cli/skeletons/code_generator/templates/default/build_cookbook/recipe.rb.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/cookbook_file.erb
+- lib/chef-cli/skeletons/code_generator/templates/default/delivery-project.toml.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/helpers.rb.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/inspec_default_test.rb.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/kitchen.yml.erb
@@ -383,6 +375,7 @@ files:
 - lib/chef-cli/skeletons/code_generator/templates/default/kitchen_policyfile.yml.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/metadata.rb.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/recipe.rb.erb
+- lib/chef-cli/skeletons/code_generator/templates/default/recipe.yml.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/recipe_spec.rb.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/repo/gitignore.erb
 - lib/chef-cli/skeletons/code_generator/templates/default/resource.rb.erb
@@ -415,7 +408,6 @@ files:
 - spec/unit/command/generate_spec.rb
 - spec/unit/command/generator_commands/attribute_spec.rb
 - spec/unit/command/generator_commands/base_spec.rb
-- spec/unit/command/generator_commands/build_cookbook_spec.rb
 - spec/unit/command/generator_commands/chef_exts/generator_desc_resource_spec.rb
 - spec/unit/command/generator_commands/chef_exts/recipe_dsl_ext_spec.rb
 - spec/unit/command/generator_commands/cookbook_file_spec.rb
@@ -528,6 +520,7 @@ files:
 - spec/unit/fixtures/local_path_cookbooks/noignore-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/metadata.rb
 - spec/unit/fixtures/local_path_cookbooks/noignore-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/recipes/default.rb
 - spec/unit/generator_spec.rb
+- spec/unit/helpers_spec.rb
 - spec/unit/kitchen/provisioner/chef_zero_capture_spec.rb
 - spec/unit/pager_spec.rb
 - spec/unit/policyfile/artifactory_cookbook_source_spec.rb
@@ -594,7 +587,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -630,7 +623,6 @@ test_files:
 - spec/unit/command/generate_spec.rb
 - spec/unit/command/generator_commands/attribute_spec.rb
 - spec/unit/command/generator_commands/base_spec.rb
-- spec/unit/command/generator_commands/build_cookbook_spec.rb
 - spec/unit/command/generator_commands/chef_exts/generator_desc_resource_spec.rb
 - spec/unit/command/generator_commands/chef_exts/recipe_dsl_ext_spec.rb
 - spec/unit/command/generator_commands/cookbook_file_spec.rb
@@ -743,6 +735,7 @@ test_files:
 - spec/unit/fixtures/local_path_cookbooks/noignore-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/metadata.rb
 - spec/unit/fixtures/local_path_cookbooks/noignore-f59ee7a5bca6a4e606b67f7f856b768d847c39bb/recipes/default.rb
 - spec/unit/generator_spec.rb
+- spec/unit/helpers_spec.rb
 - spec/unit/kitchen/provisioner/chef_zero_capture_spec.rb
 - spec/unit/pager_spec.rb
 - spec/unit/policyfile/artifactory_cookbook_source_spec.rb

data/lib/chef-cli/command/generator_commands/build_cookbook.rb

@@ -1,126 +0,0 @@
-#
-# Copyright:: Copyright (c) 2016-2019 Chef Software Inc.
-# License:: Apache License, Version 2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-require_relative "base"
-require_relative "../../dist"
-
-module ChefCLI
-  module Command
-    module GeneratorCommands
-
-      class BuildCookbook < Base
-
-        banner "Usage: #{ChefCLI::Dist::EXEC} generate build-cookbook NAME [options]"
-
-        attr_reader :errors
-
-        attr_reader :cookbook_name_or_path
-
-        option :pipeline,
-          long: "--pipeline PIPELINE",
-          description: "Use PIPELINE to set target branch to something other than master for the build_cookbook",
-          default: "master"
-
-        options.merge!(SharedGeneratorOptions.options)
-
-        def initialize(params)
-          @params_valid = true
-          @cookbook_name = nil
-          super
-        end
-
-        def run
-          read_and_validate_params
-          if params_valid?
-            setup_context
-            chef_runner.converge
-            0
-          else
-            err(opt_parser)
-            1
-          end
-        rescue ChefCLI::ChefRunnerError => e
-          err("ERROR: #{e}")
-          1
-        end
-
-        def setup_context
-          super
-          Generator.add_attr_to_context(:workflow_project_dir, workflow_project_dir)
-
-          Generator.add_attr_to_context(:workflow_project_git_initialized, workflow_project_git_initialized?)
-          Generator.add_attr_to_context(:build_cookbook_parent_is_cookbook, build_cookbook_parent_is_cookbook?)
-
-          Generator.add_attr_to_context(:pipeline, pipeline)
-        end
-
-        def pipeline
-          config[:pipeline]
-        end
-
-        def recipe
-          "build_cookbook"
-        end
-
-        def build_cookbook_parent_is_cookbook?
-          metadata_json_path = File.join(workflow_project_dir, "metadata.json")
-          metadata_rb_path = File.join(workflow_project_dir, "metadata.rb")
-
-          File.exist?(metadata_json_path) || File.exist?(metadata_rb_path)
-        end
-
-        def workflow_project_dir
-          project_dir = File.expand_path(cookbook_name_or_path, Dir.pwd)
-          # Detect if we were invoked with arguments like
-          #
-          #     chef generate build-cookbook project/.delivery/build_cookbook
-          #
-          # If so, normalize paths so we don't make a directory structure like
-          # `.delivery/.delivery/build_cookbook`.
-          #
-          # Note that we don't check the name of the build cookbook the user
-          # asked for and we hard-code to naming it "build_cookbook". We also
-          # don't catch the case that the user requested something like
-          # `project/.delivery/build_cookbook/extra-thing-that-shouldn't-be-here`
-          Pathname.new(project_dir).ascend do |dir|
-            if File.basename(dir) == ".delivery"
-              project_dir = File.dirname(dir)
-            end
-          end
-          project_dir
-        end
-
-        def workflow_project_git_initialized?
-          File.exist?(File.join(workflow_project_dir, ".git"))
-        end
-
-        def read_and_validate_params
-          arguments = parse_options(params)
-          @cookbook_name_or_path = arguments[0]
-          unless @cookbook_name_or_path
-            @params_valid = false
-          end
-        end
-
-        def params_valid?
-          @params_valid
-        end
-
-      end
-    end
-  end
-end

data/lib/chef-cli/skeletons/code_generator/files/default/build_cookbook/README.md

@@ -1,146 +0,0 @@
-# build_cookbook
-
-A build cookbook for running the parent project through Chef Workflow
-
-This build cookbook should be customized to suit the needs of the parent project. Using this cookbook can be done outside of Chef Workflow, too. If the parent project is a Chef cookbook, we've detected that and "wrapped" [delivery-truck](https://github.com/chef-cookbooks/delivery-truck). That means it is a dependency, and each of its pipeline phase recipes is included in the appropriate phase recipes in this cookbook. If the parent project is not a cookbook, it's left as an exercise to the reader to customize the recipes as needed for each phase in the pipeline.
-
-## .delivery/config.json
-
-In the parent directory to this build_cookbook, the `config.json` can be modified as necessary. For example, phases can be skipped, publishing information can be added, and so on. Refer to customer support or the Chef Workflow documentation for assistance on what options are available for this configuration.
-
-## Test Kitchen - Local Verify Testing
-
-This cookbook also has a `kitchen.yml` which can be used to create local build nodes with Test Kitchen to perform the verification phases, `unit`, `syntax`, and `lint`. When running `kitchen converge`, the instances will be set up like Chef Workflow "build nodes" with the [delivery_build cookbook](https://github.com/chef-cookbooks/delivery_build). The reason for this is to make sure that the same exact kind of nodes are used by this build cookbook are run on the local workstation as would run Workflow. It will run `delivery job verify PHASE` for the parent project.
-
-Modify the `kitchen.yml` if necessary to change the platforms or other configuration to run the verify phases. After making changes in the parent project, `cd` into this directory (`.delivery/build_cookbook`), and run:
-
-```
-kitchen test
-```
-
-## Recipes
-
-Each of the recipes in this build_cookbook are run in the named phase during the Chef Workflow pipeline. The `unit`, `syntax`, and `lint` recipes are additionally run when using Test Kitchen for local testing as noted in the above section.
-
-## Making Changes - Cookbook Example
-
-When making changes in the parent project (that which lives in `../..` from this directory), or in the recipes in this build cookbook, there is a bespoke workflow for Chef Workflow. As an example, we'll discuss a Chef Cookbook as the parent.
-
-First, create a new branch for the changes.
-
-```
-git checkout -b testing-build-cookbook
-```
-
-Next, increment the version in the metadata.rb. This should be in the _parent_, not in this, the build_cookbook. If this is not done, the verify phase will fail.
-
-```
-% git diff
-<SNIP>
--version '0.1.0'
-+version '0.1.1'
-```
-
-The change we'll use for an example is to install the `zsh` package. Write a failing ChefSpec in the cookbook project's `spec/unit/recipes/default_spec.rb`.
-
-```ruby
-require 'spec_helper'
-
-describe 'godzilla::default' do
-  context 'When all attributes are default, on Ubuntu 18.04' do
-    let(:chef_run) do
-      runner = ChefSpec::ServerRunner.new(platform: 'ubuntu', version: '18.04')
-      runner.converge(described_recipe)
-    end
-
-    it 'installs zsh' do
-      expect(chef_run).to install_package('zsh')
-    end
-  end
-end
-```
-
-Commit the local changes as work in progress. The `delivery job` expects to use a clean git repository.
-
-```
-git add ../..
-git commit -m 'WIP: Testing changes'
-```
-
-From _this_ directory (`.delivery/build_cookbook`, relative to the parent cookbook project), run
-
-```
-cd .delivery/build_cookbook
-kitchen converge
-```
-
-This will take some time at first, because the VMs need to be created, Chef Infra Client installed, the Delivery CLI installed, etc. Later runs will be faster until they are destroyed. It will also fail on the first VM, as expected, because we wrote the test first. Now edit the parent cookbook project's default recipe to install `zsh`.
-
-```
-cd ../../
-$EDITOR/recipes/default.rb
-```
-
-It should look like this:
-
-```
-package 'zsh'
-```
-
-Create another commit.
-
-```
-git add .
-git commit -m 'WIP: Install zsh in default recipe'
-```
-
-Now rerun kitchen from the build_cookbook.
-
-```
-cd .delivery/build_cookbook
-kitchen converge
-```
-
-This will take a while because it will now pass on the first VM and then create the second VM. We should have warned you this was a good time for a coffee break.
-
-```
-Recipe: test::default
-
-- execute HOME=/home/vagrant delivery job verify unit --server localhost --ent test --org kitchen
-  * execute[HOME=/home/vagrant delivery job verify lint --server localhost --ent test --org kitchen] action run
-    - execute HOME=/home/vagrant delivery job verify lint --server localhost --ent test --org kitchen
-
-    - execute HOME=/home/vagrant delivery job verify syntax --server localhost --ent test --org kitchen
-
-Running handlers:
-Running handlers complete
-Chef Infra Client finished, 3/32 resources updated in 54.665445968 seconds
-Finished converging <default-centos-8> (1m26.83s).
-```
-
-Victory is ours! Our verify phase passed on the build nodes.
-
-We are ready to run this through our Workflow pipeline. Simply run `delivery review` on the local system from the parent project, and it will open a browser window up to the change we just added.
-
-```
-cd ../..
-delivery review
-```
-
-## FAQ
-
-### Why don't I just run rspec and cookstyle on my local system?
-
-An objection to the Test Kitchen approach is that it is much faster to run the unit, lint, and syntax commands for the project on the local system. That is totally true, and also totally valid. Do that for the really fast feedback loop. However, the dance we do with Test Kitchen brings a much higher degree of confidence in the changes we're making, that everything will run on the build nodes in Chef Workflow. We strongly encourage this approach before actually pushing the changes to Workflow.
-
-### Why do I have to make a commit every time?
-
-When running `delivery job`, it expects to merge the commit for the changeset against the clean master branch. If we don't save our progress by making a commit, our local changes aren't run through `delivery job` in the Test Kitchen build instances. We can always perform an interactive rebase, and modify the original changeset message in Workflow with `delivery review --edit`. The latter won't modify the git commits, only the changeset in Workflow.
-
-### What do I do next?
-
-Make changes in the cookbook project as required for organizational goals and needs. Modify the `build_cookbook` as necessary for the pipeline phases that the cookbook should go through.
-
-### What if I get stuck?
-
-Contact Chef Support, or your Chef Customer Success team and they will help you get unstuck.