chef-cli 3.0.23 → 3.0.32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c339cf60e573bfcc494ea18c6b641186a8c755c935be0283a8406387540c0134
-  data.tar.gz: b774a1dd9c5d085d2d0b307febb9f9882ab5da6ca1517f8b0e6c1dea207b6404
+  metadata.gz: 3f1cc14b62507710161304d60579a50eedb0125347d29e5600d4ba4240d6eec9
+  data.tar.gz: a25398db16aa457dfcf8a59fa6ffbaf582469299ff0cdfa8427db5a1277e6b88
 SHA512:
-  metadata.gz: 4737f6de6472e79359cd79694edcf5b0a87973b1ddb3757aed33a59aac968687aa99b5fa94056142cb82c1fa76ba220d2d2e38116004d1328b25ef628dfdaf4f
-  data.tar.gz: e616b2608aeb4891dc879c689b2b187885b79d62aa3ed6c9a7a8afb7b02610a4dd100b8eef243945baead2f4d460ce0b205d7d93314b44313e7661302e6ce79b
+  metadata.gz: 5f0aaf0135f5f2034c7b7925f7fae7c5940dd4971531478dfd19be577739bfc4cd570381b4fa4e9c2f8b4ce4b3f7bb7108165d74aa36276023199e55a9094390
+  data.tar.gz: e5ac2dc8430803d5f9a7d56e898466778bb2d4c9a4ebbd69580d045089048e905648e41f0c4b6a10d9b5d588489aa0caa2c37a7f9e4d24b0dfed8a5f5075c885

data/Gemfile

@@ -28,3 +28,9 @@ group :development do
   gem "pry-stack_explorer", "~> 0.4.0"
   gem "rb-readline"
 end
+
+group :profile do
+  gem "stackprof"
+  gem "stackprof-webnav"
+  gem "memory_profiler"
+end

data/bin/chef-cli

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 #
-# Copyright:: Copyright (c) 2014-2018 Chef Software Inc.
+# Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -19,7 +19,7 @@
 # Set a trap for ctrl-C right away so we don't surface interrupt exceptions inside of rubygems or whatever.
 Kernel.trap(:INT) { print("\n"); exit 1 }
 
-$:.unshift(File.expand_path(File.join(File.dirname(__FILE__), "..", "lib")))
+$:.unshift(File.expand_path(File.join(__dir__, "..", "lib")))
 require "chef-cli/cli"
 
 ChefCLI::CLI.new(ARGV.clone).run(enforce_license: true)

data/chef-cli.gemspec

@@ -49,5 +49,5 @@ Gem::Specification.new do |gem|
   gem.add_dependency "cookbook-omnifetch", "~> 0.5"
   gem.add_dependency "diff-lcs", ">= 1.0", "< 1.4" # 1.4 changes the output
   gem.add_dependency "pastel", "~> 0.7" # used for policyfile differ
-  gem.add_dependency "license-acceptance", "~> 1.0", ">= 1.0.11"
+  gem.add_dependency "license-acceptance", ">= 1.0.11", "< 3"
 end

data/lib/chef-cli/cli.rb

@@ -33,6 +33,10 @@ module ChefCLI
     include Chef::Mixin::ShellOut
 
     banner(<<~BANNER)
+      #{ChefCLI::Dist::WORKSTATION_HEADER}
+      Docs: #{ChefCLI::Dist::WORKSTATION_DOCS}
+      Patents: #{ChefCLI::Dist::PATENTS}
+
       Usage:
           #{ChefCLI::Dist::EXEC} -h/--help
           #{ChefCLI::Dist::EXEC} -v/--version
@@ -119,13 +123,13 @@ module ChefCLI
 
     def show_help
       msg(banner)
-      msg("\nAvailable Commands:")
+      msg("Available Commands:")
 
       justify_length = subcommands.map(&:length).max + 2
       subcommand_specs.each do |name, spec|
         next if spec.hidden
 
-        msg("    #{"#{name}".ljust(justify_length)}#{spec.description}")
+        msg("    #{name.to_s.ljust(justify_length)}#{spec.description}")
       end
     end
 

data/lib/chef-cli/command/env.rb

@@ -20,8 +20,11 @@ require_relative "../cookbook_omnifetch"
 require_relative "../ui"
 require_relative "../version"
 require_relative "../dist"
-require "mixlib/shellout" unless defined?(Mixlib::ShellOut)
-require "yaml" unless defined?(YAML)
+
+module Mixlib
+  autoload :ShellOut, "mixlib/shellout"
+end
+autoload :YAML, "yaml"
 
 module ChefCLI
   module Command
@@ -37,10 +40,10 @@ module ChefCLI
 
       def run(params)
         info = {}
-        info["#{ChefCLI::Dist::PRODUCT}"] = workstation_info
+        info[ChefCLI::Dist::PRODUCT] = workstation_info
         info["Ruby"] = ruby_info
         info["Path"] = paths
-        ui.msg info.to_yaml
+        ui.msg YAML.dump(info)
       end
 
       def workstation_info

data/lib/chef-cli/command/exec.rb

@@ -17,7 +17,10 @@
 
 require_relative "base"
 require_relative "../dist"
-require "mixlib/shellout" unless defined?(Mixlib::ShellOut)
+
+module Mixlib
+  autoload :ShellOut, "mixlib/shellout"
+end
 
 module ChefCLI
   module Command

data/lib/chef-cli/command/generator_commands.rb

@@ -16,7 +16,7 @@
 #
 
 require "mixlib/cli" unless defined?(Mixlib::CLI)
-require "pathname" unless defined?(Pathname)
+autoload :Pathname, "pathname"
 require_relative "base"
 require_relative "../chef_runner"
 require_relative "../generator"

data/lib/chef-cli/command/generator_commands/cookbook.rb

@@ -197,20 +197,7 @@ module ChefCLI
           # .delivery/cli.toml starting from pwd:
           # https://github.com/chef/delivery-cli/blob/22cbef3987ebd0aee98405b7e161a100edc87e49/src/delivery/config/mod.rs#L225-L247
 
-          Pathname.new(Dir.pwd).ascend do |path|
-            return true if contains_delivery_cli_toml?(path)
-          end
-
-          false # nothing was found
-        end
-
-        #
-        # @param [Pathname] path a directory
-        #
-        # @return [Boolean] delivery cli.toml exists
-        #
-        def contains_delivery_cli_toml?(path)
-          path.join(".delivery/cli.toml").exist?
+          Pathname.pwd.ascend.any? { |path| path.join(".delivery/cli.toml").exist? }
         end
 
         def read_and_validate_params

data/lib/chef-cli/command/shell_init.rb

@@ -15,13 +15,16 @@
 # limitations under the License.
 #
 
-require "erb" unless defined?(ERB)
+autoload :ERB, "erb"
 
 require_relative "../commands_map"
 require_relative "../builtin_commands"
 require_relative "base"
 require_relative "../dist"
-require "mixlib/shellout" unless defined?(Mixlib::ShellOut)
+
+module Mixlib
+  autoload :ShellOut, "mixlib/shellout"
+end
 
 module ChefCLI
 

data/lib/chef-cli/cookbook_profiler/identifiers.rb

@@ -18,7 +18,7 @@
 # TODO: Chef should require its dependency correctly.
 require "singleton" unless defined?(Singleton)
 require "chef/cookbook/cookbook_version_loader"
-require "digest/sha1"
+require "digest/sha1" unless defined?(Digest::SHA1)
 
 require "chef/digester"
 

data/lib/chef-cli/dist.rb

@@ -27,7 +27,6 @@ module ChefCLI
 
     # The name of the server product
     SERVER_PRODUCT = "Chef Infra Server".freeze
-
     WORKFLOW = "Chef Workflow (Delivery)".freeze
 
     # The chef executable, as in `chef gem install` or `chef generate cookbook`
@@ -38,7 +37,13 @@ module ChefCLI
 
     HAB_PRODUCT = "Chef Habitat".freeze
     HAB_SOFTWARE_NAME = "habitat".freeze
-
     HAB_CLI = "hab".freeze
+
+    # product patents page
+    PATENTS = "https://www.chef.io/patents".freeze
+
+    # Workstation banner/help text
+    WORKSTATION_DOCS = "https://docs.chef.io/workstation/".freeze
+    WORKSTATION_HEADER = "The Chef command line tool for managing your infrastructure from your workstation.".freeze
   end
 end

data/lib/chef-cli/generator.rb

@@ -154,7 +154,7 @@ module ChefCLI
         end
         if comment
           # Ensure there's no trailing whitespace
-          result.gsub(/^(.+)$/, "#{comment} \\1").gsub(/^$/, "#{comment}").strip
+          result.gsub(/^(.+)$/, "#{comment} \\1").gsub(/^$/, comment).strip
         else
           result
         end

data/lib/chef-cli/helpers.rb

@@ -15,7 +15,10 @@
 # limitations under the License.
 #
 
-require "mixlib/shellout" unless defined?(Mixlib::ShellOut)
+module Mixlib
+  autoload :ShellOut, "mixlib/shellout"
+end
+
 require_relative "exceptions"
 
 module ChefCLI
@@ -141,7 +144,7 @@ module ChefCLI
 
     def default_package_home
       if Chef::Platform.windows?
-        File.join(ENV["LOCALAPPDATA"], "#{ChefCLI::Dist::PRODUCT_PKG_HOME}")
+        File.join(ENV["LOCALAPPDATA"], ChefCLI::Dist::PRODUCT_PKG_HOME)
       else
         File.expand_path("~/.#{ChefCLI::Dist::PRODUCT_PKG_HOME}")
       end

data/lib/chef-cli/policyfile/chef_server_cookbook_source.rb

@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-require "ffi_yajl" unless defined?(FFI_Yajl)
+autoload :FFI_Yajl, "ffi_yajl"
 require_relative "../exceptions"
 require_relative "source_uri"
 require_relative "../chef_server_api_multi"

data/lib/chef-cli/policyfile/comparison_base.rb

@@ -15,8 +15,11 @@
 # limitations under the License.
 #
 
-require "ffi_yajl" unless defined?(FFI_Yajl)
-require "mixlib/shellout" unless defined?(Mixlib::ShellOut)
+module Mixlib
+  autoload :ShellOut, "mixlib/shellout"
+end
+
+autoload :FFI_Yajl, "ffi_yajl"
 require_relative "../service_exceptions"
 
 module ChefCLI

data/lib/chef-cli/policyfile/differ.rb

@@ -18,7 +18,7 @@
 require "diff/lcs"
 require "diff/lcs/hunk"
 require "pastel"
-require "ffi_yajl" unless defined?(FFI_Yajl)
+autoload :FFI_Yajl, "ffi_yajl"
 
 module ChefCLI
   module Policyfile

data/lib/chef-cli/policyfile/git_lock_fetcher.rb

@@ -15,10 +15,13 @@
 # limitations under the License.
 #
 
+module Mixlib
+  autoload :ShellOut, "mixlib/shellout"
+end
+
 require_relative "../policyfile_lock"
 require_relative "../exceptions"
 require_relative "../helpers"
-require "mixlib/shellout" unless defined?(Mixlib::ShellOut)
 require "tmpdir" unless defined?(Dir.mktmpdir)
 
 module ChefCLI

data/lib/chef-cli/policyfile/lister.rb

@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-require "set" unless defined?(Set)
+autoload :Set, "set"
 
 require "chef/server_api"
 require_relative "../service_exceptions"

data/lib/chef-cli/policyfile/solution_dependencies.rb

@@ -16,7 +16,7 @@
 #
 
 require "semverse"
-require "set" unless defined?(Set)
+autoload :Set, "set"
 require_relative "../exceptions"
 
 module ChefCLI

data/lib/chef-cli/policyfile/source_uri.rb

@@ -15,7 +15,10 @@
 # limitations under the License.
 #
 
-require "addressable/uri" unless defined?(Addressable::URI)
+module Addressable
+  autoload :URI, "addressable/uri"
+end
+
 require_relative "../exceptions"
 
 module ChefCLI

data/lib/chef-cli/policyfile/storage_config.rb

@@ -52,7 +52,7 @@ module ChefCLI
           return use_policyfile_lock(policyfile_filename)
         end
         unless policyfile_filename.end_with?(".rb")
-          raise InvalidPolicyfileFilename, "Policyfile filenames must end with `.rb' extension (you gave: `#{policyfile_filename}')"
+          raise InvalidPolicyfileFilename, "Policyfile filenames must end with an `.rb' or `.lock.json' extension (you gave: `#{policyfile_filename}')"
         end
 
         @policyfile_filename = policyfile_filename

data/lib/chef-cli/policyfile/undo_stack.rb

@@ -17,7 +17,7 @@
 
 require "fileutils" unless defined?(FileUtils)
 
-require "ffi_yajl" unless defined?(FFI_Yajl)
+autoload :FFI_Yajl, "ffi_yajl"
 
 require_relative "../helpers"
 require_relative "undo_record"

data/lib/chef-cli/policyfile_compiler.rb

@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-require "set" unless defined?(Set)
+autoload :Set, "set"
 require "forwardable" unless defined?(Forwardable)
 
 require "solve"

data/lib/chef-cli/policyfile_services/clean_policy_cookbooks.rb

@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-require "set" unless defined?(Set)
+autoload :Set, "set"
 
 require "chef/server_api"
 require_relative "../service_exceptions"

data/lib/chef-cli/policyfile_services/export_repo.rb

@@ -18,7 +18,7 @@
 require "pathname" unless defined?(Pathname)
 require "fileutils" unless defined?(FileUtils)
 require "tmpdir" unless defined?(Dir.mktmpdir)
-require "zlib"
+require "zlib" unless defined?(Zlib)
 
 require "archive/tar/minitar"
 

data/lib/chef-cli/policyfile_services/install.rb

@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-require "ffi_yajl" unless defined?(FFI_Yajl)
+autoload :FFI_Yajl, "ffi_yajl"
 
 require_relative "../helpers"
 require_relative "../service_exceptions"
@@ -42,8 +42,8 @@ module ChefCLI
         @overwrite = overwrite
         @chef_config = config
 
-        policyfile_rel_path = policyfile || "Policyfile.rb"
-        policyfile_full_path = File.expand_path(policyfile_rel_path, root_dir)
+        @policyfile_rel_path = policyfile || "Policyfile.rb"
+        policyfile_full_path = File.expand_path(@policyfile_rel_path, root_dir)
         @storage_config = Policyfile::StorageConfig.new.use_policyfile(policyfile_full_path)
 
         @policyfile_content = nil
@@ -51,9 +51,11 @@ module ChefCLI
       end
 
       def run(cookbooks_to_update = [], exclude_deps = false)
-        unless File.exist?(policyfile_expanded_path)
-          # TODO: suggest next step. Add a generator/init command? Specify path to Policyfile.rb?
-          # See card CC-232
+        # TODO: suggest next step. Add a generator/init command? Specify path to Policyfile.rb?
+        # See card CC-232
+        if @policyfile_rel_path.end_with?(".lock.json") && !File.exist?(policyfile_lock_expanded_path)
+          raise PolicyfileNotFound, "Policyfile lock not found at path #{policyfile_lock_expanded_path}"
+        elsif @policyfile_rel_path.end_with?(".rb") && !File.exist?(policyfile_expanded_path)
           raise PolicyfileNotFound, "Policyfile not found at path #{policyfile_expanded_path}"
         end
 

data/lib/chef-cli/policyfile_services/push.rb

@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-require "ffi_yajl" unless defined?(FFI_Yajl)
+autoload :FFI_Yajl, "ffi_yajl"
 
 require_relative "../service_exceptions"
 require "chef/server_api"

data/lib/chef-cli/policyfile_services/push_archive.rb

@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-require "zlib"
+require "zlib" unless defined?(Zlib)
 require "archive/tar/minitar"
 
 require_relative "../service_exceptions"

data/lib/chef-cli/service_exception_inspectors/http.rb

@@ -15,7 +15,7 @@
 # limitations under the License.
 #
 
-require "ffi_yajl" unless defined?(FFI_Yajl)
+autoload :FFI_Yajl, "ffi_yajl"
 
 module ChefCLI
   module ServiceExceptionInspectors

data/lib/chef-cli/shell_out.rb

@@ -15,7 +15,9 @@
 # limitations under the License.
 #
 
-require "mixlib/shellout" unless defined?(Mixlib::ShellOut)
+module Mixlib
+  autoload :ShellOut, "mixlib/shellout"
+end
 
 module ChefCLI
 

data/lib/chef-cli/version.rb

@@ -16,5 +16,5 @@
 #
 
 module ChefCLI
-  VERSION = "3.0.23".freeze
+  VERSION = "3.0.32".freeze
 end

data/lib/kitchen/provisioner/chef_zero_capture.rb

@@ -15,7 +15,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-require "json" unless defined?(JSON)
 require "kitchen"
 require "kitchen/provisioner/base"
 require "kitchen/provisioner/chef_zero"

data/spec/test_helpers.rb

@@ -1,5 +1,5 @@
 #
-# Copyright:: Copyright (c) 2014-2018 Chef Software Inc.
+# Copyright:: Copyright (c) Chef Software Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -35,7 +35,7 @@ module TestHelpers
   end
 
   def fixtures_path
-    File.expand_path(File.dirname(__FILE__) + "/unit/fixtures/")
+    File.expand_path(__dir__ + "/unit/fixtures/")
   end
 
   def project_root

data/spec/unit/cli_spec.rb

@@ -41,12 +41,15 @@ describe ChefCLI::CLI do
 
   let(:base_help_message) do
     <<~E
+      #{ChefCLI::Dist::WORKSTATION_HEADER}
+      Docs: #{ChefCLI::Dist::WORKSTATION_DOCS}
+      Patents: #{ChefCLI::Dist::PATENTS}
+
       Usage:
           chef -h/--help
           chef -v/--version
           chef command [arguments...] [options...]
 
-
       Available Commands:
           gem      Runs the `gem` command in context of the embedded ruby
           example  Example subcommand for testing

data/spec/unit/command/env_spec.rb

@@ -16,7 +16,7 @@
 #
 
 require "spec_helper"
-require "yaml" unless defined?(YAML)
+autoload :YAML, "yaml"
 require "chef-cli/command/env"
 
 describe ChefCLI::Command::Env do

data/spec/unit/command/exec_spec.rb

@@ -127,7 +127,7 @@ describe ChefCLI::Command::Exec do
         end
 
         context "when running a exec with #{switch}" do
-          let(:command_options) { ["#{switch}"] }
+          let(:command_options) { [switch] }
 
           it "should call not call exec, but it should print the banner" do
             allow(command_instance).to receive(:msg)

data/spec/unit/fixtures/cookbooks_api/update_fixtures.rb

@@ -1,14 +1,11 @@
 require "openssl"
-require "net/https"
+require "net/http" unless defined?(Net::HTTP)
 require "json" unless defined?(JSON)
-require "pp"
 require "uri"
 
-THIS_DIR = File.expand_path(File.dirname(__FILE__))
-
-UNIVERSE_JSON_PATH = File.join(THIS_DIR, "universe.json")
-SMALL_UNIVERSE_JSON_PATH = File.join(THIS_DIR, "small_universe.json")
-PRUNED_UNIVERSE_PATH = File.join(THIS_DIR, "pruned_small_universe.json")
+UNIVERSE_JSON_PATH = File.join(__dir__, "universe.json")
+SMALL_UNIVERSE_JSON_PATH = File.join(__dir__, "small_universe.json")
+PRUNED_UNIVERSE_PATH = File.join(__dir__, "pruned_small_universe.json")
 
 COOKBOOKS_IN_SMALL_UNIVERSE = %w{apache2 application apt database mysql nginx postgresql yum}.freeze
 

data/spec/unit/policyfile/storage_config_spec.rb

@@ -106,10 +106,10 @@ describe ChefCLI::Policyfile::StorageConfig do
 
     end
 
-    context "when the policyfile file name doesn't have a .rb extension" do
+    context "when the policyfile file name doesn't have an .rb or .lock.json extension" do
 
       it "raises an error" do
-        err_string = %q{Policyfile filenames must end with `.rb' extension (you gave: `Policyfile')}
+        err_string = %q{Policyfile filenames must end with an `.rb' or `.lock.json' extension (you gave: `Policyfile')}
         expect { storage_config.use_policyfile("Policyfile") }.to raise_error(ChefCLI::InvalidPolicyfileFilename, err_string)
       end
 

data/spec/unit/policyfile_services/install_spec.rb

@@ -77,6 +77,26 @@ describe ChefCLI::PolicyfileServices::Install do
 
   end
 
+  context "When an explicit Policfyfile lock name is given and does not exist" do
+
+    let(:policyfile_rb_explicit_name) { "i_do_not_exist.lock.json" }
+
+    it "errors out" do
+      expect { install_service.run }.to raise_error(ChefCLI::PolicyfileNotFound, "Policyfile lock not found at path #{policyfile_rb_path}")
+    end
+
+  end
+
+  context "When an explicit Policfyfile name is given and does not exist" do
+
+    let(:policyfile_rb_explicit_name) { "i_do_not_exist.rb" }
+
+    it "errors out" do
+      expect { install_service.run }.to raise_error(ChefCLI::PolicyfileNotFound, "Policyfile not found at path #{policyfile_rb_path}")
+    end
+
+  end
+
   context "when a Policyfile exists" do
 
     before do

data/spec/unit/service_exception_inspectors/http_spec.rb

@@ -16,7 +16,7 @@
 #
 
 require "spec_helper"
-require "net/http"
+require "net/http" unless defined?(Net::HTTP)
 require "chef/monkey_patches/net_http"
 require "chef-cli/service_exception_inspectors/http"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: chef-cli
 version: !ruby/object:Gem::Version
-  version: 3.0.23
+  version: 3.0.32
 platform: ruby
 authors:
 - Chef Software, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-12 00:00:00.000000000 Z
+date: 2020-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mixlib-cli
@@ -190,22 +190,22 @@ dependencies:
   name: license-acceptance
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.11
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.11
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 description: A streamlined development and deployment workflow for Chef platform.
 email:
 - info@chef.io