chef-cli 1.0.3

data/spec/unit/policyfile/remote_lock_fetcher_spec.rb

@@ -0,0 +1,129 @@
+#
+# Copyright:: Copyright (c) 2017 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "chef-cli/policyfile/remote_lock_fetcher"
+
+describe ChefCLI::Policyfile::RemoteLockFetcher do
+
+  let(:minimal_lockfile_json) do
+    <<~E
+      {
+        "revision_id": "6fe753184c8946052d3231bb4212116df28d89a3a5f7ae52832ad408419dd5eb",
+        "name": "install-example",
+        "run_list": [
+          "recipe[remote-cookbook::default]"
+        ],
+        "cookbook_locks": {
+          "remote-cookbook": {
+            "version": "2.3.4",
+            "identifier": "fab501cfaf747901bd82c1bc706beae7dc3a350c",
+            "dotted_decimal_identifier": "70567763561641081.489844270461035.258281553147148",
+            "cache_key": null,
+            "origin": "http://my.chef.server/remote-cookbook/download",
+            "source_options": {
+              "artifactserver": "http://my.chef.server/remote-cookbook/download",
+              "version": "2.3.4"
+            }
+          }
+        },
+        "default_attributes": {},
+        "override_attributes": {},
+        "solution_dependencies": {
+          "Policyfile": [
+            [
+              "remote-cookbook",
+              ">= 0.0.0"
+            ]
+          ],
+          "dependencies": {
+            "remote-cookbook (2.3.4)": [
+
+            ]
+          }
+        }
+      }
+    E
+  end
+
+  let(:minimal_lockfile) do
+    FFI_Yajl::Parser.parse(minimal_lockfile_json)
+  end
+
+  describe "#lock_data" do
+    let(:http) { instance_double(Chef::HTTP, url: "http://my.chef.server/policy.lock.json") }
+    let(:storage_config) { ChefCLI::Policyfile::StorageConfig.new.use_policyfile("#{tempdir}/Policyfile.rb") }
+    let(:source_options) { { remote: "http://my.chef.server/policy.lock.json" } }
+
+    before do
+      expect(Chef::HTTP).to receive(:new).with(source_options[:remote]).and_return(http)
+    end
+
+    subject(:fetcher) { described_class.new("foo", source_options) }
+
+    context "when the http.get returns valid json" do
+      context "source_options does not include 'path'" do
+        it "returns the parsed json" do
+          expect(http).to receive(:get).with("").and_return(minimal_lockfile_json)
+          expect(fetcher.lock_data).to eq(minimal_lockfile)
+        end
+      end
+
+      context "source_options includes 'path'" do
+        let(:minimal_lockfile_json_w_path) do
+          FFI_Yajl::Encoder.encode(
+            minimal_lockfile.tap do |lockfile|
+              lockfile["cookbook_locks"]["remote-cookbook"]["source_options"] = {
+                "path" => "../remote-cookbook",
+              }
+            end
+          )
+        end
+
+        it "raises ChefCLI::InvalidLockfile" do
+          expect(http).to receive(:get).with("").and_return(minimal_lockfile_json_w_path)
+          expect { fetcher.lock_data } .to raise_error(ChefCLI::InvalidLockfile, /Invalid cookbook path/)
+        end
+      end
+    end
+
+    context "when the http.get returns a 404" do
+      let(:err) { Net::HTTPNotFound.new(1, 404, "msg") }
+      let(:err_re) { /No remote policyfile lock/ }
+      it "raises a PolicyfileLockDownloadError" do
+        expect(http).to receive(:get).with("").and_raise(Net::HTTPError.new("msg", err))
+        expect { fetcher.lock_data }.to raise_error(ChefCLI::PolicyfileLockDownloadError, err_re)
+      end
+    end
+
+    context "when the http.get returns a non-404" do
+      let(:err) { Net::HTTPServerError.new(1, 500, "msg") }
+      let(:err_re) { /HTTP error attempting to fetch policyfile lock/ }
+      it "raises a PolicyfileLockDownloadError" do
+        expect(http).to receive(:get).with("").and_raise(Net::HTTPError.new("msg", err))
+        expect { fetcher.lock_data }.to raise_error(ChefCLI::PolicyfileLockDownloadError, err_re)
+      end
+    end
+
+    context "when the http.get returns a RuntimeError" do
+      it "reraises" do
+        expect(http).to receive(:get).with("").and_raise("foo")
+        expect { fetcher.lock_data }.to raise_error("foo")
+      end
+    end
+  end
+end

data/spec/unit/policyfile/reports/install_spec.rb

@@ -0,0 +1,114 @@
+#
+# Copyright:: Copyright (c) 2014-2018 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "chef-cli/policyfile/reports/install"
+
+# Used for verifying doubles
+require "chef-cli/policyfile_compiler"
+require "chef-cli/policyfile/cookbook_location_specification"
+
+describe ChefCLI::Policyfile::Reports::Install do
+
+  let(:ui) { TestHelpers::TestUI.new }
+
+  let(:policyfile_compiler) { instance_double("ChefCLI::PolicyfileCompiler") }
+
+  subject(:install_report) { described_class.new(ui: ui, policyfile_compiler: policyfile_compiler ) }
+
+  it "has a UI object" do
+    expect(install_report.ui).to eq(ui)
+  end
+
+  it "has a policyfile compiler" do
+    expect(install_report.policyfile_compiler).to eq(policyfile_compiler)
+  end
+
+  describe "when printing an installation report for fixed version cookbooks" do
+
+    let(:fixed_version_cookbook_one) do
+      instance_double("ChefCLI::Policyfile::CookbookLocationSpecification",
+                      installed?: false,
+                      name: "short-name",
+                      version_constraint: ">= 0.0.0",
+                      source_type: :git)
+    end
+
+    let(:fixed_version_cookbook_two) do
+      instance_double("ChefCLI::Policyfile::CookbookLocationSpecification",
+                      installed?: true,
+                      name: "this-name-is-longer",
+                      version_constraint: "~> 10.0.0",
+                      source_type: :path)
+    end
+
+    let(:fixed_version_cookbooks) do
+      { "short-name" => fixed_version_cookbook_one, "this-name-is-longer" => fixed_version_cookbook_two }
+    end
+
+    before do
+      allow(policyfile_compiler).to receive(:fixed_version_cookbooks_specs).and_return(fixed_version_cookbooks)
+    end
+
+    it "prints a table-ized message for cookbooks being installed" do
+      install_report.installing_fixed_version_cookbook(fixed_version_cookbook_one)
+      expect(ui.output).to eq("Installing short-name          >= 0.0.0 from git\n")
+    end
+
+    it "prints a table-ized message for cookbooks in the cache that are reused" do
+      install_report.installing_fixed_version_cookbook(fixed_version_cookbook_two)
+      expect(ui.output).to eq("Using      this-name-is-longer ~> 10.0.0 from path\n")
+    end
+
+  end
+
+  describe "when printing an installation report for normal dependencies" do
+
+    let(:cookbook_one) do
+      instance_double("ChefCLI::Policyfile::CookbookLocationSpecification",
+                      installed?: false,
+                      name: "short-name",
+                      version_constraint: Semverse::Constraint.new("= 10.0.4"))
+    end
+
+    let(:cookbook_two) do
+      instance_double("ChefCLI::Policyfile::CookbookLocationSpecification",
+                      installed?: true,
+                      name: "this-name-is-longer",
+                      version_constraint: Semverse::Constraint.new("= 1.2.3"))
+    end
+
+    let(:graph_solution_cookbooks) do
+      { "short-name" => "10.0.4", "this-name-is-longer" => "1.2.3" }
+    end
+
+    before do
+      allow(policyfile_compiler).to receive(:graph_solution).and_return(graph_solution_cookbooks)
+    end
+
+    it "prints a table-ized message for cookbooks being installed" do
+      install_report.installing_cookbook(cookbook_one)
+      expect(ui.output).to eq("Installing short-name          10.0.4\n")
+    end
+
+    it "prints a table-ized message for cookbooks in the cache that are reused" do
+      install_report.installing_cookbook(cookbook_two)
+      expect(ui.output).to eq("Using      this-name-is-longer 1.2.3\n")
+    end
+
+  end
+end

data/spec/unit/policyfile/reports/upload_spec.rb

@@ -0,0 +1,94 @@
+#
+# Copyright:: Copyright (c) 2014-2018 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "chef-cli/policyfile/reports/upload"
+
+# For the LockedCookbookForUpload class:
+require "chef-cli/policyfile/uploader"
+
+# Used for verifying doubles
+require "chef-cli/policyfile/cookbook_locks"
+
+describe ChefCLI::Policyfile::Reports::Upload do
+
+  let(:ui) { TestHelpers::TestUI.new }
+
+  let(:reused_cookbooks) { [] }
+
+  let(:uploaded_cookbooks) { [] }
+
+  subject(:upload_report) { described_class.new(ui: ui, reused_cbs: reused_cookbooks, uploaded_cbs: uploaded_cookbooks) }
+
+  it "has a ui object" do
+    expect(upload_report.ui).to eq(ui)
+  end
+
+  it "has a list of cookbooks that are being uploaded" do
+    expect(upload_report.uploaded_cbs).to equal(uploaded_cookbooks)
+  end
+
+  it "has a list of cookbooks that would be uploaded but are already on the server" do
+    expect(upload_report.reused_cbs).to equal(reused_cookbooks)
+  end
+
+  describe "reporting uploaded and reused cookbooks" do
+
+    def cb_with_lock(name, version, identifier)
+      lock = instance_double("ChefCLI::Policyfile::CookbookLock",
+                             name: name,
+                             version: version,
+                             identifier: identifier)
+
+      ChefCLI::Policyfile::Uploader::LockedCookbookForUpload.new(nil, lock)
+    end
+
+    let(:cookbook_one) do
+      cb_with_lock("short-name", "10.11.12", "49582c3db4e3b54674ecfb57fe82157720350274")
+    end
+
+    let(:cookbook_two) do
+      cb_with_lock("a-longer-named-cookbook", "1.0.0", "e4ac353bebdc949cd2cd8ce69983a56b96917dfa")
+    end
+
+    let(:reused_cookbooks) { [ cookbook_one, cookbook_two ] }
+
+    let(:cookbook_three) do
+      cb_with_lock("foo", "1.2.42", "cb61daebfb0d255cae928ca1a92db29b055755cf")
+    end
+
+    let(:cookbook_four) do
+      cb_with_lock("barbazqux", "12.34.5678", "1241ea6f9866d0e61d11129bb32e5fc96cd2bac0")
+    end
+
+    let(:uploaded_cookbooks) { [ cookbook_three, cookbook_four ] }
+
+    it "prints a table showing the re-used and uploaded cookbooks" do
+      upload_report.show
+
+      expected_output = <<~E
+        Using    short-name              10.11.12   (49582c3d)
+        Using    a-longer-named-cookbook 1.0.0      (e4ac353b)
+        Uploaded foo                     1.2.42     (cb61daeb)
+        Uploaded barbazqux               12.34.5678 (1241ea6f)
+      E
+      expect(ui.output).to eq(expected_output)
+    end
+
+  end
+
+end

data/spec/unit/policyfile/solution_dependencies_spec.rb

@@ -0,0 +1,170 @@
+#
+# Copyright:: Copyright (c) 2014-2018 Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require "spec_helper"
+require "chef-cli/policyfile/solution_dependencies"
+
+describe ChefCLI::Policyfile::SolutionDependencies do
+
+  let(:dependency_data) { { "Policyfile" => [], "dependencies" => {} } }
+
+  let(:solution_dependencies) do
+    s = described_class.new
+    s.consume_lock_data(dependency_data)
+    s
+  end
+
+  it "has a list of dependencies declared in the Policyfile" do
+    expect(solution_dependencies.policyfile_dependencies).to eq([])
+  end
+
+  it "has a map of dependencies declared by cookbooks" do
+    expect(solution_dependencies.cookbook_dependencies).to eq({})
+  end
+
+  context "when populated with dependency data from a lockfile" do
+
+    let(:dependency_data) do
+      {
+        "Policyfile" => [
+          [ "nginx", "~> 1.0"], ["postgresql", ">= 0.0.0" ]
+        ],
+        "dependencies" => {
+          "nginx (1.2.3)" => [ ["apt", "~> 2.3"], ["yum", "~>3.4"] ],
+          "apt (2.5.6)" => [],
+          "yum (3.4.1)" => [],
+          "postgresql (5.0.0)" => [],
+        },
+      }
+    end
+
+    it "has a list of dependencies from the policyfile" do
+      expected = [ "nginx", "~> 1.0"], ["postgresql", ">= 0.0.0" ]
+      expect(solution_dependencies.policyfile_dependencies_for_lock).to eq(expected)
+    end
+
+    it "has a list of dependencies from cookbooks" do
+      expected = {
+        "nginx (1.2.3)" => [ ["apt", "~> 2.3"], ["yum", "~> 3.4"] ],
+        "apt (2.5.6)" => [],
+        "yum (3.4.1)" => [],
+        "postgresql (5.0.0)" => [],
+      }
+      expect(solution_dependencies.cookbook_deps_for_lock).to eq(expected)
+    end
+
+  end
+
+  context "when populated with dependency data from a complex lockfile" do
+    let(:dependency_data) do
+      {
+        "Policyfile" => [
+          [ "a", ">= 0.0.0"], ["b", ">= 0.0.0" ]
+        ],
+        "dependencies" => {
+          "a (0.1.0)" => [ ["c", "~> 1.0.0"], ["d", "~> 0.0.0"] ],
+          "b (1.0.0)" => [ ["f", ">= 0.0.1"] ],
+          "c (1.0.1)" => [ ["e", ">= 0.0.1"] ],
+          "d (0.0.1)" => [],
+          "e (0.0.1)" => [],
+          "f (0.0.1)" => [],
+        },
+      }
+    end
+    it "can compute list of transitive dependencies" do
+
+      expect(solution_dependencies.transitive_deps(["e"])).to eq(["e"])
+      expect(solution_dependencies.transitive_deps(["c"])).to eq(%w{c e})
+      expect(solution_dependencies.transitive_deps(%w{c d})).to eq(%w{c d e})
+      expect(solution_dependencies.transitive_deps(["a"])).to eq(%w{a c d e})
+    end
+  end
+
+  context "when populated with dependency data" do
+
+    let(:expected_deps_for_lock) do
+      {
+        "nginx (1.2.3)" => [ ["apt", "~> 2.3"], ["yum", "~> 3.4"] ],
+        "apt (2.5.6)" => [],
+        "yum (3.4.1)" => [],
+        "postgresql (5.0.0)" => [],
+      }
+    end
+
+    let(:expected_policyfile_deps_for_lock) do
+      [ [ "nginx", "~> 1.0"], ["postgresql", ">= 0.0.0" ] ]
+    end
+
+    before do
+      solution_dependencies.add_policyfile_dep("nginx", "~> 1.0")
+      solution_dependencies.add_policyfile_dep("postgresql", ">= 0.0.0")
+      solution_dependencies.add_cookbook_dep("nginx", "1.2.3", [ ["apt", "~> 2.3"], ["yum", "~>3.4"] ])
+      solution_dependencies.add_cookbook_dep("apt", "2.5.6", [])
+      solution_dependencies.add_cookbook_dep("yum", "3.4.1", [])
+      solution_dependencies.add_cookbook_dep("postgresql", "5.0.0", [])
+    end
+
+    it "has a list of dependencies from the Policyfile" do
+      expect(solution_dependencies.policyfile_dependencies_for_lock).to eq(expected_policyfile_deps_for_lock)
+    end
+
+    it "has a list of dependencies from cookbooks" do
+      expect(solution_dependencies.cookbook_deps_for_lock).to eq(expected_deps_for_lock)
+    end
+
+    it "generates lock info containing both policyfile and cookbook dependencies" do
+      expected = { "Policyfile" => expected_policyfile_deps_for_lock, "dependencies" => expected_deps_for_lock }
+      expect(solution_dependencies.to_lock).to eq(expected)
+    end
+
+    describe "checking for dependency conflicts" do
+
+      it "does not raise if a cookbook that's in the dependency set with a different version doesn't conflict" do
+        solution_dependencies.update_cookbook_dep("yum", "3.5.0", [ ])
+        expect(solution_dependencies.test_conflict!("yum", "3.5.0")).to be(false)
+      end
+
+      it "raises if a cookbook is not in the current solution set" do
+        expected_message = "Cookbook foo (1.0.0) not in the working set, cannot test for conflicts"
+        expect { solution_dependencies.test_conflict!("foo", "1.0.0") }.to raise_error(ChefCLI::CookbookNotInWorkingSet, expected_message)
+      end
+
+      it "raises when a cookbook conflicts with a Policyfile constraint" do
+        solution_dependencies.update_cookbook_dep("nginx", "2.0.0", [])
+
+        expected_message = "Cookbook nginx (2.0.0) conflicts with other dependencies:\nPolicyfile depends on nginx ~> 1.0"
+        expect { solution_dependencies.test_conflict!("nginx", "2.0.0") }.to raise_error(ChefCLI::DependencyConflict, expected_message)
+      end
+
+      it "raises when a cookbook conflicts with another cookbook's dependency constraint" do
+        solution_dependencies.update_cookbook_dep("apt", "3.0.0", [])
+
+        expected_message = "Cookbook apt (3.0.0) conflicts with other dependencies:\nnginx (1.2.3) depends on apt ~> 2.3"
+        expect { solution_dependencies.test_conflict!("apt", "3.0.0") }.to raise_error(ChefCLI::DependencyConflict, expected_message)
+      end
+
+      it "raises when a cookbook's dependencies are no longer satisfiable" do
+        solution_dependencies.update_cookbook_dep("nginx", "1.2.3", [ [ "apt", "~> 3.0" ] ])
+        expected_message = "Cookbook nginx (1.2.3) has dependency constraints that cannot be met by the existing cookbook set:\n" +
+          "Dependency on apt ~> 3.0 conflicts with existing version apt (2.5.6)"
+        expect { solution_dependencies.test_conflict!("nginx", "1.2.3") }.to raise_error(ChefCLI::DependencyConflict, expected_message)
+      end
+
+    end
+  end
+
+end