checkoff 0.93.0 → 0.94.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 49531006387df986e746c99973d425917777230710978cad819951ca8d696d7b
-  data.tar.gz: ef9ea84d3a708b8a47425c77a63f83241f310d2b9b0fd71e01f15ec00d5eb4d7
+  metadata.gz: 3728a0da90fb49dedd232b05722fbb87f03789d3bf9bc15513e4fa4b88f9e6fc
+  data.tar.gz: 16ce81c8b51905620414ff21f9469ce83c100a61985f355b8a27de20b7234b3c
 SHA512:
-  metadata.gz: 7d5e93cea9b3b00bb6d7622e7aa4aa93229820683118f72414ac60dd7b3fafd36fac60e1a79a16fc6091b4ba051ae3cc818b0e2f8c5a354ae57b4b849b562af0
-  data.tar.gz: e4f24e5b32dfce8459a3c04fc89ba0b831f0d50f61dcc780864f441b1e119f29f774f2b47503ef6653b285b60c58273bb0bca8a80aa7feacea517019ce8139c1
+  metadata.gz: d73466d69b7b116eb8c58c0053b7cf13cedf288477e7cc8862de091fdd183e5a84355e19841e09df003da9b44d2b87ac90a459845c9186737069002f5312e455
+  data.tar.gz: 207d7d34ecdc3435892afe3b96860df2373e36067f8c75866f7b87d5a6f0aac0ebe89b0889b45d6a31ddec1ac6211f592fce4b657aa70ffad5e5c504deeea773

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.93.0)
+    checkoff (0.94.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/internal/task_timing.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module Checkoff
+  module Internal
+    # Utility methods for working with task dates and times
+    class TaskTiming
+      # @param time_class [Class<Time>]
+      def initialize(time_class: Time)
+        @time_class = time_class
+      end
+
+      # @param task [Asana::Resources::Task]
+      # @return [Time, nil]
+      def start_time(task)
+        return @time_class.parse(task.start_at) if task.start_at
+        return @time_class.parse(task.start_on) if task.start_on
+
+        nil
+      end
+
+      # @param task [Asana::Resources::Task]
+      # @return [Time, nil]
+      def due_time(task)
+        return @time_class.parse(task.due_at) if task.due_at
+        return @time_class.parse(task.due_on) if task.due_on
+
+        nil
+      end
+    end
+  end
+end

data/lib/checkoff/tasks.rb

@@ -5,6 +5,7 @@
 require_relative 'sections'
 require_relative 'workspaces'
 require_relative 'internal/config_loader'
+require_relative 'internal/task_timing'
 require 'asana'
 
 module Checkoff
@@ -57,8 +58,8 @@ module Checkoff
     def task_ready?(task, ignore_dependencies: false)
       return false if !ignore_dependencies && incomplete_dependencies?(task)
 
-      start = start_time(task)
-      due = due_time(task)
+      start = task_timing.start_time(task)
+      due = task_timing.due_time(task)
 
       return true if start.nil? && due.nil?
 
@@ -79,12 +80,12 @@ module Checkoff
              only_uncompleted: true,
              extra_fields: [])
       # @sg-ignore
-      tasks = tasks_from_section(workspace_name,
-                                 project_name,
-                                 section_name: section_name,
-                                 only_uncompleted: only_uncompleted,
-                                 extra_fields: extra_fields)
-      tasks.find { |task| task.name == task_name }
+      t = tasks(workspace_name,
+                project_name,
+                section_name: section_name,
+                only_uncompleted: only_uncompleted,
+                extra_fields: extra_fields)
+      t.find { |task| task.name == task_name }
     end
     cache_method :task, SHORT_CACHE_TIME
 
@@ -146,16 +147,20 @@ module Checkoff
 
     private
 
+    # @return [Checkoff::Internal::TaskTiming]
+    def task_timing
+      @task_timing ||= Checkoff::Internal::TaskTiming.new(time_class: @time_class)
+    end
+
     # @param workspace_name [String]
     # @param project_name [String, Symbol]
-    # @param section_name [String, nil, :unspecified]
+    # @param section_name [String, nil, Symbol<:unspecified>]
     # @param only_uncompleted [Boolean]
     # @param extra_fields [Array<String>]
+    #
     # @return [Enumerable<Asana::Resources::Task>]
-    def tasks_from_section(workspace_name, project_name,
-                           section_name:,
-                           only_uncompleted:,
-                           extra_fields:)
+    def tasks(workspace_name, project_name,
+              only_uncompleted:, extra_fields:, section_name: :unspecified)
       if section_name == :unspecified
         project = projects.project_or_raise(workspace_name, project_name)
         projects.tasks_from_project(project,
@@ -182,23 +187,5 @@ module Checkoff
     def default_assignee_gid
       @config.fetch(:default_assignee_gid)
     end
-
-    # @param task [Asana::Resources::Task]
-    # @return [Time, nil]
-    def start_time(task)
-      return @time_class.parse(task.start_at) if task.start_at
-      return @time_class.parse(task.start_on) if task.start_on
-
-      nil
-    end
-
-    # @param task [Asana::Resources::Task]
-    # @return [Time, nil]
-    def due_time(task)
-      return @time_class.parse(task.due_at) if task.due_at
-      return @time_class.parse(task.due_on) if task.due_on
-
-      nil
-    end
   end
 end

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.93.0'
+  VERSION = '0.94.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.93.0
+  version: 0.94.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-10-22 00:00:00.000000000 Z
+date: 2023-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -153,6 +153,7 @@ files:
 - lib/checkoff/internal/selector_classes/task/function_evaluator.rb
 - lib/checkoff/internal/selector_evaluator.rb
 - lib/checkoff/internal/task_selector_evaluator.rb
+- lib/checkoff/internal/task_timing.rb
 - lib/checkoff/my_tasks.rb
 - lib/checkoff/portfolios.rb
 - lib/checkoff/project_selectors.rb