checkoff 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4602a0a2276fa337153e3394f009fa99a8a22603003baf9e99fb9da65c9b9107
-  data.tar.gz: e1a006d0debc96dbf11fd5e63d4930446bf35a3ae7f261bbbfca79a9d9bbad02
+  metadata.gz: 834d9600b69c5f79ba30cbf22a79c66d0a277d517cafe6c2aee32de1c63bb533
+  data.tar.gz: 5cb97edadfd9aca288f6f1e5d95400c0e291306ffd2f3a76ad003560539b88cb
 SHA512:
-  metadata.gz: 9c998ad14b388dd17a118536b1abacd2e2dc0195fd42f847090c142cb17636f9bd8fe17e2ee4202d2784d7d907ea6aad59381639a5fa71af32babd70bd229229
-  data.tar.gz: b47bb6ce0899ad62c683fefb67596cc5ca371dc0b67d1cacec881060c19d2cb796175b781530231d2cb320b7662dd4929b5a6eac21b8ae9accfd1c138d344d10
+  metadata.gz: 83050b84c4cc44b0c5992174cfe8f837f985dd361627ed60e81466f9cb14713b87d14508c9d46d997e9887c8944557252a64bd79f3354c04285c852758fd5021
+  data.tar.gz: '083875c0f26f4309170d036ccec8dc3bb970ddf276916f1744ac0bd1285055de662ac7b29054bceba10fe82baba0ef319731ab32de522fb773a3af824ba687c1'

data/.envrc

@@ -0,0 +1,2 @@
+PATH_add bin
+eval $(with-op op-env sh)

data/.overcommit.yml

@@ -31,3 +31,10 @@ PreCommit:
 #
 #  IndexTags:
 #    enabled: true # Generate a tags file with `ctags` each time HEAD changes
+
+PrePush:
+  Minitest:
+    command: ['ruby', '-Ilib:test/unit:lib/checkoff', '-rbundler/setup', '-rminitest', "-e 'exit! Minitest.run'"]
+    include:
+      - 'test/unit/**/test*.rb'
+    enabled: true

data/.rubocop.yml

@@ -195,6 +195,8 @@ RSpec/StubbedMock: # (new in 1.44)
 
 AllCops:
   TargetRubyVersion: 2.5
+  Exclude:
+    - 'bin/*'
 
 require:
   - rubocop-rspec

data/bin/checkoff

@@ -0,0 +1,29 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'checkoff' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+require "pathname"
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
+  Pathname.new(__FILE__).realpath)
+
+bundle_binstub = File.expand_path("../bundle", __FILE__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("checkoff", "checkoff")

data/coverage/.last_run.json

@@ -1,5 +1,5 @@
 {
   "result": {
-    "covered_percent": 85.38
+    "covered_percent": 89.61
   }
 }

data/lib/checkoff/cli.rb

@@ -110,6 +110,10 @@ module Checkoff
     end
 
     def view(workspace_name, project_name, section_name)
+      if project_name.nil?
+        stderr.puts 'Please specify a project name'
+        exit(1)
+      end
       project_name = project_name[1..-1].to_sym if project_name.start_with? ':'
       if section_name.nil?
         run_on_project(workspace_name, project_name)

data/lib/checkoff/sections.rb

@@ -11,12 +11,14 @@ module Checkoff
 
     extend Forwardable
 
-    attr_reader :projects, :time
+    attr_reader :projects, :workspaces, :time
 
     def initialize(config: Checkoff::ConfigLoader.load(:asana),
                    projects: Checkoff::Projects.new(config: config),
+                   workspaces: Checkoff::Workspaces.new(config: config),
                    time: Time)
       @projects = projects
+      @workspaces = workspaces
       @time = time
     end
 
@@ -41,6 +43,12 @@ module Checkoff
     end
     cache_method :by_section, LONG_CACHE_TIME
 
+    def legacy_tasks_by_section_for_project(project)
+      raw_tasks = projects.tasks_from_project(project)
+      active_tasks = projects.active_tasks(raw_tasks)
+      legacy_by_section(active_tasks)
+    end
+
     def tasks_by_section_for_project(project)
       raw_tasks = projects.tasks_from_project(project)
       active_tasks = projects.active_tasks(raw_tasks)
@@ -68,8 +76,8 @@ module Checkoff
       by_section
     end
 
-    def tasks_by_section_for_project_and_assignee_status(project,
-                                                         assignee_status)
+    def legacy_tasks_by_section_for_project_and_assignee_status(project,
+                                                                assignee_status)
       raw_tasks = projects.tasks_from_project(project)
       by_assignee_status =
         projects.active_tasks(raw_tasks)
@@ -87,15 +95,40 @@ module Checkoff
       project
     end
 
+    def verify_legacy_user_task_list!(workspace_name)
+      return unless user_task_list_migrated_to_real_sections?(workspace_name)
+
+      raise NotImplementedError, 'Section-based user task lists not yet supported'
+    end
+
+    ASSIGNEE_STATUS_BY_PROJECT_NAME = {
+      my_tasks_new: 'inbox',
+      my_tasks_today: 'today',
+      my_tasks_upcoming: 'upcoming',
+    }.freeze
+
+    def user_task_list_by_section(workspace_name, project_name)
+      verify_legacy_user_task_list!(workspace_name)
+
+      if project_name == :my_tasks
+        legacy_tasks_by_section_for_project(project_name)
+      else
+        legacy_tasks_by_section_for_project_and_assignee_status(project_name,
+                                                                ASSIGNEE_STATUS_BY_PROJECT_NAME.fetch(project_name))
+      end
+    end
+
     def tasks_by_section(workspace_name, project_name)
       project = project_or_raise(workspace_name, project_name)
       case project_name
+      when :my_tasks
+        user_task_list_by_section(workspace_name, project_name)
       when :my_tasks_new
-        tasks_by_section_for_project_and_assignee_status(project, 'inbox')
+        user_task_list_by_section(workspace_name, project_name)
       when :my_tasks_today
-        tasks_by_section_for_project_and_assignee_status(project, 'today')
+        user_task_list_by_section(workspace_name, project_name)
       when :my_tasks_upcoming
-        tasks_by_section_for_project_and_assignee_status(project, 'upcoming')
+        user_task_list_by_section(workspace_name, project_name)
       else
         tasks_by_section_for_project(project)
       end
@@ -120,6 +153,13 @@ module Checkoff
     end
     cache_method :section_task_names, SHORT_CACHE_TIME
 
+    def user_task_list_migrated_to_real_sections?(workspace_name)
+      workspace = workspaces.workspace_by_name(workspace_name)
+      result = client.user_task_lists.get_user_task_list_for_user(user_gid: 'me',
+                                                                  workspace: workspace.gid)
+      result.migration_status != 'not_migrated'
+    end
+
     def task_due?(task)
       if task.due_at
         Time.parse(task.due_at) <= time.now

data/lib/checkoff/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Checkoff
-  VERSION = '0.7.0'
+  VERSION = '0.8.0'
 end

data/lib/checkoff/workspaces.rb

@@ -13,6 +13,7 @@ module Checkoff
       @client ||= @asana_client.new do |c|
         c.authentication :access_token, @config.fetch(:personal_access_token)
         c.default_headers 'asana-enable' => 'string_ids,new_sections'
+        c.default_headers 'asana-disable' => 'new_user_task_lists'
       end
     end
 
@@ -23,7 +24,7 @@ module Checkoff
     def workspace_by_name(workspace_name)
       client.workspaces.find_all.find do |workspace|
         workspace.name == workspace_name
-      end || raise("Could not find workspace #{workspace_name}")
+      end || raise("Could not find workspace named [#{workspace_name}]")
     end
   end
 end

data/metrics/bigfiles_high_water_mark

@@ -1 +1 @@
-416
+488

data/metrics/rubocop_high_water_mark

@@ -1 +1 @@
-4
+6

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-02-04 00:00:00.000000000 Z
+date: 2021-03-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -187,6 +187,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".envrc"
 - ".gitignore"
 - ".overcommit.yml"
 - ".rubocop.yml"
@@ -198,6 +199,7 @@ files:
 - Makefile
 - README.md
 - Rakefile
+- bin/checkoff
 - bin/console
 - bin/setup
 - checkoff.gemspec