checkoff 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ed54aed7a0c5a533627bc50c187c1a0d0a289a0132d63549914b9e024dde68e
-  data.tar.gz: 531ed220ec4d4fcbfc20413d1571ada5074fe745ba81df81dd66cea81e1da5ed
+  metadata.gz: 4602a0a2276fa337153e3394f009fa99a8a22603003baf9e99fb9da65c9b9107
+  data.tar.gz: e1a006d0debc96dbf11fd5e63d4930446bf35a3ae7f261bbbfca79a9d9bbad02
 SHA512:
-  metadata.gz: e2a700a5ca4b8ea76977b0d8fdcd1e1b72dd50dbcfc8020d5a8d6193cf809c6c0d7be1011f21d15389163aec348f85d8c73b01295c01fd91b3e12a75e40183f6
-  data.tar.gz: 7c263678ca6533ed555cd69655f66eac149124b932c63c10320ab87b4546c57de0cf9728f5b8d166eedea3d36cfab6e3d0f85f408626c768b304afa9ca0da7ac
+  metadata.gz: 9c998ad14b388dd17a118536b1abacd2e2dc0195fd42f847090c142cb17636f9bd8fe17e2ee4202d2784d7d907ea6aad59381639a5fa71af32babd70bd229229
+  data.tar.gz: b47bb6ce0899ad62c683fefb67596cc5ca371dc0b67d1cacec881060c19d2cb796175b781530231d2cb320b7662dd4929b5a6eac21b8ae9accfd1c138d344d10

data/.overcommit.yml

@@ -0,0 +1,33 @@
+# Use this file to configure the Overcommit hooks you wish to use. This will
+# extend the default configuration defined in:
+# https://github.com/sds/overcommit/blob/master/config/default.yml
+#
+# At the topmost level of this YAML file is a key representing type of hook
+# being run (e.g. pre-commit, commit-msg, etc.). Within each type you can
+# customize each hook, such as whether to only run it on certain files (via
+# `include`), whether to only display output if it fails (via `quiet`), etc.
+#
+# For a complete list of hooks, see:
+# https://github.com/sds/overcommit/tree/master/lib/overcommit/hook
+#
+# For a complete list of options that you can use to customize hooks, see:
+# https://github.com/sds/overcommit#configuration
+#
+# Uncomment the following lines to make the configuration take effect.
+
+PreCommit:
+  RuboCop:
+    enabled: true
+    on_warn: fail # Treat all warnings as failures
+#
+#  TrailingWhitespace:
+#    enabled: true
+#    exclude:
+#      - '**/db/structure.sql' # Ignore trailing whitespace in generated files
+#
+#PostCheckout:
+#  ALL: # Special hook name that customizes all hooks of this type
+#    quiet: true # Change all post-checkout hooks to only display output on failure
+#
+#  IndexTags:
+#    enabled: true # Generate a tags file with `ctags` each time HEAD changes

data/README.md

@@ -126,6 +126,8 @@ my_tasks:
 personal_access_token: 'some_big_long_string_from_asana.com_here'
 ```
 
+Alternately you can set environment variables to match - e.g., `ASANA__PERSONAL_ACCESS_TOKEN`
+
 ## Developing
 
 ```bash

data/checkoff.gemspec

@@ -30,6 +30,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'minitest-profile'
   spec.add_development_dependency 'mocha'
+  spec.add_development_dependency 'overcommit'
   spec.add_development_dependency 'quality', '~> 38'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '>=3.4'

data/coverage/.last_run.json

@@ -1,5 +1,5 @@
 {
   "result": {
-    "covered_percent": 83.74
+    "covered_percent": 85.38
   }
 }

data/lib/checkoff/config_loader.rb

@@ -4,12 +4,52 @@ require 'yaml'
 require 'active_support/core_ext/hash'
 
 module Checkoff
+  # Use the provided config from a YAML file, and fall back to env
+  # variable if it's not populated for a key'
+  class EnvFallbackConfigLoader
+    def initialize(config, sym, yaml_filename)
+      @config = config
+      @envvar_prefix = sym.upcase
+      @yaml_filename = yaml_filename
+    end
+
+    def envvar_name(key)
+      "#{@envvar_prefix}__#{key.upcase}"
+    end
+
+    def [](key)
+      config_value = @config[key]
+      return config_value unless config_value.nil?
+
+      ENV[envvar_name(key)]
+    end
+
+    def fetch(key)
+      out = self[key]
+      return out unless out.nil?
+
+      raise KeyError,
+            "Please configure either the #{key} key in #{@yaml_filename} or set #{envvar_name(key)}"
+    end
+  end
+
   # Load configuration file
   class ConfigLoader
-    def self.load(sym)
+    def self.yaml_filename(sym)
       file = "#{sym}.yml"
-      YAML.load_file(File.expand_path("~/.#{file}"))
-          .with_indifferent_access
+      File.expand_path("~/.#{file}")
+    end
+
+    def self.load_yaml_file(sym)
+      filename = yaml_filename(sym)
+      return {} unless File.exist?(filename)
+
+      YAML.load_file(filename).with_indifferent_access
+    end
+
+    def self.load(sym)
+      yaml_result = load_yaml_file(sym)
+      EnvFallbackConfigLoader.new(yaml_result, sym, yaml_filename(sym))
     end
   end
 end

data/lib/checkoff/projects.rb

@@ -49,8 +49,8 @@ module Checkoff
     end
 
     def my_tasks(workspace_name)
-      my_tasks = @config[:my_tasks]
-      gid = @config[:my_tasks][workspace_name] unless my_tasks.nil?
+      my_tasks = @config.fetch(:my_tasks)
+      gid = my_tasks[workspace_name] unless my_tasks.nil?
       raise "Please define [:my_tasks][#{workspace_name}] in config file" if my_tasks.nil? || gid.nil?
 
       projects.find_by_id(gid)

data/lib/checkoff/tasks.rb

@@ -50,7 +50,7 @@ module Checkoff
     end
 
     def default_assignee_gid
-      @config[:default_assignee_gid]
+      @config.fetch(:default_assignee_gid)
     end
   end
 end

data/lib/checkoff/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Checkoff
-  VERSION = '0.6.0'
+  VERSION = '0.7.0'
 end

data/lib/checkoff/workspaces.rb

@@ -11,13 +11,13 @@ module Checkoff
 
     def client
       @client ||= @asana_client.new do |c|
-        c.authentication :access_token, @config[:personal_access_token]
+        c.authentication :access_token, @config.fetch(:personal_access_token)
         c.default_headers 'asana-enable' => 'string_ids,new_sections'
       end
     end
 
     def default_workspace_gid
-      @config[:default_workspace_gid]
+      @config.fetch(:default_workspace_gid)
     end
 
     def workspace_by_name(workspace_name)

data/metrics/bigfiles_high_water_mark

@@ -1 +1 @@
-414
+416

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-22 00:00:00.000000000 Z
+date: 2021-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: overcommit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: quality
   requirement: !ruby/object:Gem::Requirement
@@ -174,6 +188,7 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".gitignore"
+- ".overcommit.yml"
 - ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"