checkoff 0.6.0 → 0.11.0

data/lib/checkoff/subtasks.rb

@@ -11,17 +11,7 @@ module Checkoff
 
     extend Forwardable
 
-    def file_task_by_section(current_section, by_section, task)
-      if task.name =~ /:$/
-        current_section = task.name
-        by_section[current_section] = []
-      else
-        by_section[current_section] ||= []
-        by_section[current_section] << task
-      end
-      [current_section, by_section]
-    end
-
+    # pulls a Hash of subtasks broken out by section
     def by_section(tasks)
       current_section = nil
       by_section = {}
@@ -37,5 +27,18 @@ module Checkoff
       task.subtasks(projects.task_options)
     end
     cache_method :raw_subtasks, LONG_CACHE_TIME
+
+    private
+
+    def file_task_by_section(current_section, by_section, task)
+      if task.name =~ /:$/
+        current_section = task.name
+        by_section[current_section] = []
+      else
+        by_section[current_section] ||= []
+        by_section[current_section] << task
+      end
+      [current_section, by_section]
+    end
   end
 end

data/lib/checkoff/tasks.rb

@@ -5,7 +5,7 @@
 require_relative 'sections'
 
 module Checkoff
-  # Pull things from 'my tasks' in Asana
+  # Pull tasks from Asana
   class Tasks
     MINUTE = 60
     HOUR = MINUTE * 60
@@ -22,6 +22,22 @@ module Checkoff
       @asana_task = asana_task
     end
 
+    # Pull a specific task by name
+    def task(workspace_name, project_name, task_name,
+             section_name: :unspecified,
+             only_uncompleted: true)
+      project = projects.project(workspace_name, project_name)
+      tasks = if section_name == :unspecified
+                projects.tasks_from_project(project,
+                                            only_uncompleted: only_uncompleted)
+              else
+                @sections.tasks(workspace_name, project_name, section_name)
+              end
+      tasks.find { |task| task.name == task_name }
+    end
+
+    private
+
     def client
       @sections.client
     end
@@ -30,13 +46,6 @@ module Checkoff
       @projects ||= @sections.projects
     end
 
-    def task(workspace_name, project_name, task_name, only_uncompleted: true)
-      project = projects.project(workspace_name, project_name)
-      tasks = projects.tasks_from_project(project,
-                                          only_uncompleted: only_uncompleted)
-      tasks.find { |task| task.name == task_name }
-    end
-
     def tasks_minus_sections(tasks)
       @sections.by_section(tasks).values.flatten
     end
@@ -50,7 +59,7 @@ module Checkoff
     end
 
     def default_assignee_gid
-      @config[:default_assignee_gid]
+      @config.fetch(:default_assignee_gid)
     end
   end
 end

data/lib/checkoff/version.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
 module Checkoff
-  VERSION = '0.6.0'
+  # Version of library
+  VERSION = '0.11.0'
 end

data/lib/checkoff/workspaces.rb

@@ -9,21 +9,26 @@ module Checkoff
       @asana_client = asana_client
     end
 
+    # Returns Asana Ruby API Client object
     def client
       @client ||= @asana_client.new do |c|
-        c.authentication :access_token, @config[:personal_access_token]
+        c.authentication :access_token, @config.fetch(:personal_access_token)
         c.default_headers 'asana-enable' => 'string_ids,new_sections'
+        c.default_headers 'asana-disable' => 'new_user_task_lists'
       end
     end
 
-    def default_workspace_gid
-      @config[:default_workspace_gid]
-    end
-
+    # Pulls an Asana workspace object
     def workspace_by_name(workspace_name)
       client.workspaces.find_all.find do |workspace|
         workspace.name == workspace_name
-      end || raise("Could not find workspace #{workspace_name}")
+      end || raise("Could not find workspace named [#{workspace_name}]")
+    end
+
+    private
+
+    def default_workspace_gid
+      @config.fetch(:default_workspace_gid)
     end
   end
 end

data/metrics/bigfiles_high_water_mark

@@ -1 +1 @@
-414
+488

data/metrics/rubocop_high_water_mark

@@ -1 +1 @@
-4
+6

data/{lib/tasks/ci.rake → rakelib/citest.rake}

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 
 desc 'Run tasks to be done during a continuous integration (CI) build'
-task ci: :localtest
+task citest: %i[clear_metrics test undercover]

data/rakelib/clear_metrics.rake

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+desc 'Ensure that any locally ratcheted coverage metrics are cleared back ' \
+     'to git baseline'
+task :clear_metrics do |_t|
+  ret =
+    system('git checkout coverage/.last_run.json')
+  raise unless ret
+
+  # Without this old lines which are removed are still counted,
+  # leading to inconsistent coverage percentages between runs.
+  #
+  # need to save coverage/.last_run.json
+  ret =
+    system('rm -fr coverage/assets coverage/.*.json.lock coverage/lcov/* coverage/index.html coverage/.resultset.json')
+  raise unless ret
+end

data/rakelib/gem_tasks.rake

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'

data/{lib/tasks → rakelib}/localtest.rake

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 
 desc 'Standard build when running on a workstation'
-task localtest: %i[clear_metrics test quality]
+task localtest: %i[clear_metrics test undercover quality]

data/rakelib/overcommit.rake

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+desc 'Run overcommit on current code'
+task :overcommit do
+  sh 'overcommit --run'
+end

data/rakelib/quality.rake

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+desc 'Run quality checks'
+task quality: :overcommit

data/rakelib/undercover.rake

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+desc 'Ensure PR changes are fully covered by tests'
+task :undercover do |_t|
+  ret =
+    system('undercover --compare origin/main')
+  raise unless ret
+end

data/requirements_dev.txt

@@ -0,0 +1,2 @@
+pip==21.0.1
+yamllint==1.26.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-01-22 00:00:00.000000000 Z
+date: 2021-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -66,6 +66,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: gli
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bump
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -109,19 +137,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: quality
+  name: overcommit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '38'
+        version: 0.58.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '38'
+        version: 0.58.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -137,19 +165,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '13.0'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -164,6 +220,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov-lcov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: undercover
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description:
 email:
 - vince@broz.cc
@@ -173,22 +257,32 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".envrc"
+- ".git-hooks/pre_commit/circle_ci.rb"
 - ".gitignore"
+- ".overcommit.yml"
 - ".rubocop.yml"
-- ".ruby-version"
-- ".travis.yml"
+- ".yamllint.yml"
 - CODE_OF_CONDUCT.md
+- DEVELOPMENT.md
 - Gemfile
-- LICENSE.txt
+- Gemfile.lock
+- LICENSE
 - Makefile
 - README.md
 - Rakefile
+- bin/bump
+- bin/checkoff
 - bin/console
+- bin/overcommit
+- bin/rake
 - bin/setup
 - checkoff.gemspec
 - coverage/.last_run.json
+- docs/cookiecutter_input.json
 - docs/example_project.png
 - exe/checkoff
+- fix.sh
 - lib/checkoff.rb
 - lib/checkoff/cli.rb
 - lib/checkoff/config_loader.rb
@@ -198,14 +292,6 @@ files:
 - lib/checkoff/tasks.rb
 - lib/checkoff/version.rb
 - lib/checkoff/workspaces.rb
-- lib/tasks/ci.rake
-- lib/tasks/clear_metrics.rake
-- lib/tasks/default.rake
-- lib/tasks/feature.rake
-- lib/tasks/localtest.rake
-- lib/tasks/quality.rake
-- lib/tasks/spec.rake
-- lib/tasks/test.rake
 - metrics/bigfiles_high_water_mark
 - metrics/brakeman_high_water_mark
 - metrics/bundle-audit_high_water_mark
@@ -223,9 +309,19 @@ files:
 - metrics/rubocop_high_water_mark
 - metrics/scalastyle_high_water_mark
 - metrics/shellcheck_high_water_mark
-homepage: http://github.com/apiology/checkoff
+- rakelib/citest.rake
+- rakelib/clear_metrics.rake
+- rakelib/default.rake
+- rakelib/gem_tasks.rake
+- rakelib/localtest.rake
+- rakelib/overcommit.rake
+- rakelib/quality.rake
+- rakelib/test.rake
+- rakelib/undercover.rake
+- requirements_dev.txt
+homepage: https://github.com/apiology/checkoff
 licenses:
-- MIT
+- MIT license
 metadata: {}
 post_install_message:
 rdoc_options: []
@@ -235,14 +331,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.3.1
 signing_key:
 specification_version: 4
 summary: Command-line and gem client for Asana (unofficial)