checkoff 0.5.2 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf801216d45c8e3b9c09e80e8d5f05d097dec4361f076f3d70efafd10a628ec5
-  data.tar.gz: 19e168d38d597f1ca0962f22d14d2e4326975b847334672337c879edf19d74bb
+  metadata.gz: 4602a0a2276fa337153e3394f009fa99a8a22603003baf9e99fb9da65c9b9107
+  data.tar.gz: e1a006d0debc96dbf11fd5e63d4930446bf35a3ae7f261bbbfca79a9d9bbad02
 SHA512:
-  metadata.gz: 11b63053e7902dad783ccc000990f211a0184a90a016f938fa354871bec3c101ff8fff4743e798998844405710b34e686cc18def737fd44b7956f179bdeb83df
-  data.tar.gz: 80577a035c94855fbdcb2ee0abbca795c41a426d8d1737c33f7c9250a86dc52e7699dc64b39c895930bd581fcebe8b90fafc50fb2671c3cfb1729c4074ba8487
+  metadata.gz: 9c998ad14b388dd17a118536b1abacd2e2dc0195fd42f847090c142cb17636f9bd8fe17e2ee4202d2784d7d907ea6aad59381639a5fa71af32babd70bd229229
+  data.tar.gz: b47bb6ce0899ad62c683fefb67596cc5ca371dc0b67d1cacec881060c19d2cb796175b781530231d2cb320b7662dd4929b5a6eac21b8ae9accfd1c138d344d10

data/.overcommit.yml

@@ -0,0 +1,33 @@
+# Use this file to configure the Overcommit hooks you wish to use. This will
+# extend the default configuration defined in:
+# https://github.com/sds/overcommit/blob/master/config/default.yml
+#
+# At the topmost level of this YAML file is a key representing type of hook
+# being run (e.g. pre-commit, commit-msg, etc.). Within each type you can
+# customize each hook, such as whether to only run it on certain files (via
+# `include`), whether to only display output if it fails (via `quiet`), etc.
+#
+# For a complete list of hooks, see:
+# https://github.com/sds/overcommit/tree/master/lib/overcommit/hook
+#
+# For a complete list of options that you can use to customize hooks, see:
+# https://github.com/sds/overcommit#configuration
+#
+# Uncomment the following lines to make the configuration take effect.
+
+PreCommit:
+  RuboCop:
+    enabled: true
+    on_warn: fail # Treat all warnings as failures
+#
+#  TrailingWhitespace:
+#    enabled: true
+#    exclude:
+#      - '**/db/structure.sql' # Ignore trailing whitespace in generated files
+#
+#PostCheckout:
+#  ALL: # Special hook name that customizes all hooks of this type
+#    quiet: true # Change all post-checkout hooks to only display output on failure
+#
+#  IndexTags:
+#    enabled: true # Generate a tags file with `ctags` each time HEAD changes

data/.rubocop.yml

@@ -67,9 +67,134 @@ Style/StringLiterals:
       - double_quotes
     ConsistentQuotesInMultiline: true
 
-AllCops:
-  TargetRubyVersion: 2.4
+Layout/BeginEndAlignment: # (new in 0.91)
+  Enabled: true
+Layout/EmptyLinesAroundAttributeAccessor: # (new in 0.83)
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator: # (new in 0.82)
+  Enabled: true
+Lint/BinaryOperatorWithIdenticalOperands: # (new in 0.89)
+  Enabled: true
+Lint/ConstantDefinitionInBlock: # (new in 0.91)
+  Enabled: true
+Lint/DeprecatedOpenSSLConstant: # (new in 0.84)
+  Enabled: true
+Lint/DuplicateElsifCondition: # (new in 0.88)
+  Enabled: true
+Lint/DuplicateRequire: # (new in 0.90)
+  Enabled: true
+Lint/DuplicateRescueException: # (new in 0.89)
+  Enabled: true
+Lint/EmptyConditionalBody: # (new in 0.89)
+  Enabled: true
+Lint/EmptyFile: # (new in 0.90)
+  Enabled: true
+Lint/FloatComparison: # (new in 0.89)
+  Enabled: true
+Lint/IdentityComparison: # (new in 0.91)
+  Enabled: true
+Lint/MissingSuper: # (new in 0.89)
+  Enabled: true
+Lint/MixedRegexpCaptureTypes: # (new in 0.85)
+  Enabled: true
+Lint/OutOfRangeRegexpRef: # (new in 0.89)
+  Enabled: true
+Lint/RaiseException: # (new in 0.81)
+  Enabled: true
+Lint/SelfAssignment: # (new in 0.89)
+  Enabled: true
+Lint/StructNewOverride: # (new in 0.81)
+  Enabled: true
+Lint/TopLevelReturnWithArgument: # (new in 0.89)
+  Enabled: true
+Lint/TrailingCommaInAttributeDeclaration: # (new in 0.90)
+  Enabled: true
+Lint/UnreachableLoop: # (new in 0.89)
+  Enabled: true
+Lint/UselessMethodDefinition: # (new in 0.90)
+  Enabled: true
+Lint/UselessTimes: # (new in 0.91)
+  Enabled: true
+Style/AccessorGrouping: # (new in 0.87)
+  Enabled: true
+Style/BisectedAttrAccessor: # (new in 0.87)
+  Enabled: true
+Style/CaseLikeIf: # (new in 0.88)
+  Enabled: true
+Style/CombinableLoops: # (new in 0.90)
+  Enabled: true
+Style/ExplicitBlockArgument: # (new in 0.89)
+  Enabled: true
+Style/ExponentialNotation: # (new in 0.82)
+  Enabled: true
+Style/GlobalStdStream: # (new in 0.89)
+  Enabled: true
+Style/HashAsLastArrayItem: # (new in 0.88)
+  Enabled: true
+Style/HashEachMethods: # (new in 0.80)
+  Enabled: true
+Style/HashLikeCase: # (new in 0.88)
+  Enabled: true
+Style/HashTransformKeys: # (new in 0.80)
+  Enabled: true
+Style/HashTransformValues: # (new in 0.80)
+  Enabled: true
+Style/KeywordParametersOrder: # (new in 0.90)
+  Enabled: true
+Style/OptionalBooleanParameter: # (new in 0.89)
+  Enabled: true
+Style/RedundantAssignment: # (new in 0.87)
+  Enabled: true
+Style/RedundantFetchBlock: # (new in 0.86)
+  Enabled: true
+Style/RedundantFileExtensionInRequire: # (new in 0.88)
+  Enabled: true
+Style/RedundantRegexpCharacterClass: # (new in 0.85)
+  Enabled: true
+Style/RedundantRegexpEscape: # (new in 0.85)
+  Enabled: true
+Style/RedundantSelfAssignment: # (new in 0.90)
+  Enabled: true
+Style/SingleArgumentDig: # (new in 0.89)
+  Enabled: true
+Style/SlicingWithRange: # (new in 0.83)
+  Enabled: true
+Style/SoleNestedConditional: # (new in 0.89)
+  Enabled: true
+Style/StringConcatenation: # (new in 0.89)
+  Enabled: true
+Minitest/AssertInDelta: # (new in 0.10)
+  Enabled: true
+Minitest/AssertionInLifecycleHook: # (new in 0.10)
+  Enabled: true
+Minitest/AssertKindOf: # (new in 0.10)
+  Enabled: true
+Minitest/AssertOutput: # (new in 0.10)
+  Enabled: true
+Minitest/AssertPathExists: # (new in 0.10)
+  Enabled: true
+Minitest/AssertSilent: # (new in 0.10)
+  Enabled: true
+Minitest/LiteralAsActualArgument: # (new in 0.10)
+  Enabled: true
+Minitest/MultipleAssertions: # (new in 0.10)
+  Enabled: true
+Minitest/RefuteInDelta: # (new in 0.10)
+  Enabled: true
+Minitest/RefuteKindOf: # (new in 0.10)
+  Enabled: true
+Minitest/RefutePathExists: # (new in 0.10)
+  Enabled: true
+Minitest/TestMethodName: # (new in 0.10)
+  # This gives false positives when non-test methods exist...
+  Enabled: false
+Minitest/UnspecifiedException: # (new in 0.10)
+  Enabled: true
+RSpec/StubbedMock: # (new in 1.44)
+  Enabled: true
 
+AllCops:
+  TargetRubyVersion: 2.5
 
 require:
   - rubocop-rspec

data/.travis.yml

@@ -10,8 +10,13 @@ rvm:
   # checking for main() in -lstdc++... RuntimeError: The compiler failed to generate
   # https://travis-ci.com/apiology/pronto-punchlist/jobs/264907931
   # - jruby-head
-  - ruby-head
+
+  # These are currently pending ruby-asana fixes:
+  #
+  # https://github.com/Asana/ruby-asana/pull/99
+  #
+  # - ruby-head
+  # - ruby-3.0
   - ruby-2.7
   - ruby-2.6
   - ruby-2.5
-  - ruby-2.4

data/README.md

@@ -126,6 +126,8 @@ my_tasks:
 personal_access_token: 'some_big_long_string_from_asana.com_here'
 ```
 
+Alternately you can set environment variables to match - e.g., `ASANA__PERSONAL_ACCESS_TOKEN`
+
 ## Developing
 
 ```bash

data/checkoff.gemspec

@@ -10,12 +10,12 @@ Gem::Specification.new do |spec|
   spec.version       = Checkoff::VERSION
   spec.authors       = ['Vince Broz']
   spec.email         = ['vince@broz.cc']
-
   spec.summary       = 'Command-line and gem client for Asana (unofficial)'
   spec.homepage      = 'http://github.com/apiology/checkoff'
   spec.license       = 'MIT'
+  spec.required_ruby_version = '>= 2.5'
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
   spec.bindir        = 'exe'
@@ -23,14 +23,15 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'activesupport'
-  spec.add_runtime_dependency 'asana'
+  spec.add_runtime_dependency 'asana', '>0.10.0'
   spec.add_runtime_dependency 'cache_method'
   spec.add_runtime_dependency 'dalli'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'minitest-profile'
   spec.add_development_dependency 'mocha'
-  spec.add_development_dependency 'quality', '~> 37'
+  spec.add_development_dependency 'overcommit'
+  spec.add_development_dependency 'quality', '~> 38'
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '>=3.4'
   spec.add_development_dependency 'simplecov'

data/coverage/.last_run.json

@@ -1,5 +1,5 @@
 {
   "result": {
-    "covered_percent": 83.74
+    "covered_percent": 85.38
   }
 }

data/lib/checkoff/cli.rb

@@ -15,11 +15,13 @@ module Checkoff
   class CLI
     attr_reader :sections, :stderr
 
-    def initialize(workspaces: Checkoff::Workspaces.new,
-                   projects: Checkoff::Projects.new,
-                   sections: Checkoff::Sections.new(projects: projects),
-                   tasks: Checkoff::Tasks.new,
-                   stderr: STDERR,
+    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+                   workspaces: Checkoff::Workspaces.new(config: config),
+                   projects: Checkoff::Projects.new(config: config),
+                   sections: Checkoff::Sections.new(config: config,
+                                                    projects: projects),
+                   tasks: Checkoff::Tasks.new(config: config),
+                   stderr: $stderr,
                    kernel: Kernel)
       @workspaces = workspaces
       @projects = projects
@@ -87,9 +89,10 @@ module Checkoff
     def parse_args(args)
       mode = args[0]
       subargs = OpenStruct.new
-      if mode == 'view'
+      case mode
+      when 'view'
         parse_view_args(subargs, args)
-      elsif mode == 'quickadd'
+      when 'quickadd'
         parse_quickadd_args(subargs, args)
       else
         raise
@@ -118,9 +121,10 @@ module Checkoff
     def run(args)
       validate_args!(args)
       command, subargs = parse_args(args)
-      if command == 'view'
+      case command
+      when 'view'
         view(subargs.workspace, subargs.project, subargs.section)
-      elsif command == 'quickadd'
+      when 'quickadd'
         quickadd(subargs.workspace, subargs.task_name)
       else
         raise

data/lib/checkoff/config_loader.rb

@@ -3,14 +3,53 @@
 require 'yaml'
 require 'active_support/core_ext/hash'
 
-# frozen_string_literal: true
 module Checkoff
+  # Use the provided config from a YAML file, and fall back to env
+  # variable if it's not populated for a key'
+  class EnvFallbackConfigLoader
+    def initialize(config, sym, yaml_filename)
+      @config = config
+      @envvar_prefix = sym.upcase
+      @yaml_filename = yaml_filename
+    end
+
+    def envvar_name(key)
+      "#{@envvar_prefix}__#{key.upcase}"
+    end
+
+    def [](key)
+      config_value = @config[key]
+      return config_value unless config_value.nil?
+
+      ENV[envvar_name(key)]
+    end
+
+    def fetch(key)
+      out = self[key]
+      return out unless out.nil?
+
+      raise KeyError,
+            "Please configure either the #{key} key in #{@yaml_filename} or set #{envvar_name(key)}"
+    end
+  end
+
   # Load configuration file
   class ConfigLoader
-    def self.load(sym)
+    def self.yaml_filename(sym)
       file = "#{sym}.yml"
-      YAML.load_file(File.expand_path("~/.#{file}"))
-          .with_indifferent_access
+      File.expand_path("~/.#{file}")
+    end
+
+    def self.load_yaml_file(sym)
+      filename = yaml_filename(sym)
+      return {} unless File.exist?(filename)
+
+      YAML.load_file(filename).with_indifferent_access
+    end
+
+    def self.load(sym)
+      yaml_result = load_yaml_file(sym)
+      EnvFallbackConfigLoader.new(yaml_result, sym, yaml_filename(sym))
     end
   end
 end

data/lib/checkoff/projects.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 require_relative 'config_loader'
 
-# frozen_string_literal: true
 require 'cache_method'
 require 'asana'
 
@@ -25,7 +26,7 @@ module Checkoff
 
     def initialize(config: Checkoff::ConfigLoader.load(:asana),
                    asana_client: Asana::Client,
-                   workspaces: Checkoff::Workspaces.new)
+                   workspaces: Checkoff::Workspaces.new(config: config))
       @config = config
       @asana_client = asana_client
       @workspaces = workspaces
@@ -48,11 +49,9 @@ module Checkoff
     end
 
     def my_tasks(workspace_name)
-      my_tasks = @config[:my_tasks]
-      gid = @config[:my_tasks][workspace_name] unless my_tasks.nil?
-      if my_tasks.nil? || gid.nil?
-        raise "Please define [:my_tasks][#{workspace_name}] in config file"
-      end
+      my_tasks = @config.fetch(:my_tasks)
+      gid = my_tasks[workspace_name] unless my_tasks.nil?
+      raise "Please define [:my_tasks][#{workspace_name}] in config file" if my_tasks.nil? || gid.nil?
 
       projects.find_by_id(gid)
     end
@@ -78,7 +77,7 @@ module Checkoff
         per_page: 100,
         options: {
           fields: %w[name completed_at due_at due_on assignee_status tags
-                     memberships.project.gid memberships.section.name],
+                     memberships.project.gid memberships.section.name dependencies],
         },
       }
     end

data/lib/checkoff/sections.rb

@@ -13,7 +13,8 @@ module Checkoff
 
     attr_reader :projects, :time
 
-    def initialize(projects: Checkoff::Projects.new,
+    def initialize(config: Checkoff::ConfigLoader.load(:asana),
+                   projects: Checkoff::Projects.new(config: config),
                    time: Time)
       @projects = projects
       @time = time
@@ -22,12 +23,10 @@ module Checkoff
     def_delegators :@projects, :client
 
     def file_task_by_section(by_section, task, project_gid)
-      membership = task.memberships.find { |m| m.project.gid == project_gid }
-      if membership.nil?
-        raise "Could not find task in project_gid #{project_gid}: #{task}"
-      end
+      membership = task.memberships.find { |m| m['project']['gid'] == project_gid }
+      raise "Could not find task in project_gid #{project_gid}: #{task}" if membership.nil?
 
-      current_section = membership.section.name
+      current_section = membership['section']['name']
       current_section = nil if current_section == '(no section)'
       by_section[current_section] ||= []
       by_section[current_section] << task
@@ -90,11 +89,12 @@ module Checkoff
 
     def tasks_by_section(workspace_name, project_name)
       project = project_or_raise(workspace_name, project_name)
-      if project_name == :my_tasks_new
+      case project_name
+      when :my_tasks_new
         tasks_by_section_for_project_and_assignee_status(project, 'inbox')
-      elsif project_name == :my_tasks_today
+      when :my_tasks_today
         tasks_by_section_for_project_and_assignee_status(project, 'today')
-      elsif project_name == :my_tasks_upcoming
+      when :my_tasks_upcoming
         tasks_by_section_for_project_and_assignee_status(project, 'upcoming')
       else
         tasks_by_section_for_project(project)

data/lib/checkoff/tasks.rb

@@ -15,7 +15,7 @@ module Checkoff
     SHORT_CACHE_TIME = MINUTE * 5
 
     def initialize(config: Checkoff::ConfigLoader.load(:asana),
-                   sections: Checkoff::Sections.new,
+                   sections: Checkoff::Sections.new(config: config),
                    asana_task: Asana::Resources::Task)
       @config = config
       @sections = sections
@@ -50,7 +50,7 @@ module Checkoff
     end
 
     def default_assignee_gid
-      @config[:default_assignee_gid]
+      @config.fetch(:default_assignee_gid)
     end
   end
 end

data/lib/checkoff/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Checkoff
-  VERSION = '0.5.2'
+  VERSION = '0.7.0'
 end

data/lib/checkoff/workspaces.rb

@@ -11,13 +11,13 @@ module Checkoff
 
     def client
       @client ||= @asana_client.new do |c|
-        c.authentication :access_token, @config[:personal_access_token]
+        c.authentication :access_token, @config.fetch(:personal_access_token)
         c.default_headers 'asana-enable' => 'string_ids,new_sections'
       end
     end
 
     def default_workspace_gid
-      @config[:default_workspace_gid]
+      @config.fetch(:default_workspace_gid)
     end
 
     def workspace_by_name(workspace_name)

data/lib/tasks/quality.rake

@@ -3,7 +3,7 @@
 require 'quality/rake/task'
 
 Quality::Rake::Task.new do |task|
-  task.skip_tools = ['reek']
+  task.skip_tools = %w[reek cane eslint jscs pycodestyle rails_best_practices flake8]
   task.output_dir = 'metrics'
-  task.exclude_files = ['docs/example_project.png']
+  task.exclude_files = ['docs/example_project.png', '.rubocop.yml']
 end

data/metrics/bigfiles_high_water_mark

@@ -1 +1 @@
-410
+416

data/metrics/rubocop_high_water_mark

@@ -1 +1 @@
-1
+4

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.7.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-10-17 00:00:00.000000000 Z
+date: 2021-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -28,16 +28,16 @@ dependencies:
   name: asana
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.10.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - ">"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.10.0
 - !ruby/object:Gem::Dependency
   name: cache_method
   requirement: !ruby/object:Gem::Requirement
@@ -108,20 +108,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: overcommit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: quality
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '37'
+        version: '38'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '37'
+        version: '38'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -174,6 +188,7 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".gitignore"
+- ".overcommit.yml"
 - ".rubocop.yml"
 - ".ruby-version"
 - ".travis.yml"
@@ -235,7 +250,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="