checkoff 0.39.4 → 0.40.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4157afdaf7db7bbf6334a968a5d06f1a5ce0f248d62aa854192b85c0514232ff
-  data.tar.gz: be6032a66aa14f3ddad56293d5728508f1540304f28c6acd59d1677097d26a0c
+  metadata.gz: 42f156ed0a4b85a8fa1b0887a74c3df016d8245293c547ea6b2ed49be7254b18
+  data.tar.gz: 55e6d2c6c560e4c74c18c8db95f079a36637912973e849154f1f2e2bcb724f97
 SHA512:
-  metadata.gz: 6d6b3bcae0366a5da00d6735d7f2cb5a96d29cdf08b85ac8a9571dd2c13bce8553e2083d3760895ae02a1a3b1f354c07ab50b589d4bf9e55799faefa899150ca
-  data.tar.gz: a58eb7f567d9d70af6b0a60eac27fc918ce0fddccf6773bcc7e969c260269d114618d6042042331015f9c6e095ddc40cd3c9fa77ebd2cf99f3a17b8f1e30edd7
+  metadata.gz: 8e200395f12114df856c15c030dcbf4d2a8a7a77333cd431881352975655fa7d6a559626dafb15d9f93c9fbcec47e6c1d1be5afc6f7ee6e5d816d315b4566d20
+  data.tar.gz: 6ce670c2ce1e0b783ca3d044b1e957004dc460cc0b207cda9f7ce12898021c32c94efa44bd4e1a652f76f2986c3a4d9873afbe1fe9e3eeec32df8ab4b9e40072

data/.git-hooks/pre_commit/circle_ci.rb

@@ -8,6 +8,7 @@ module Overcommit
     module PreCommit
       # CircleCI plugin for Overcommit to validate config file (.circleci/config.yml)
       class CircleCi < Base
+        # @return [Symbol, Array<[Symbol, String]>]
         def run
           result = execute(command)
           return :pass if result.success?

data/.git-hooks/pre_commit/punchlist.rb

@@ -10,7 +10,7 @@ module Overcommit
       # Runs `punchlist` against any modified Ruby files.
       class Punchlist < Base
         # @param stdout [String]
-        # @return [Array<Overcommit::Hook::Message]
+        # @return [Array<Overcommit::Hook::Message>]
         def parse_output(stdout)
           stdout.split("\n").map do |line|
             # @sg-ignore
@@ -19,12 +19,14 @@ module Overcommit
           end
         end
 
+        # @return [String]
         def files_glob
           "{" \
             "#{applicable_files.join(',')}" \
             "}"
         end
 
+        # @return [Symbol, Array<Overcommit::Hook::Message>]
         def run
           # @sg-ignore
           # @type [Overcommit::Subprocess::Result]

data/.git-hooks/pre_commit/solargraph_typecheck.rb

@@ -11,6 +11,7 @@ module Overcommit
     module PreCommit
       # Runs `solargraph typecheck` against any modified Ruby files.
       class SolargraphTypecheck < Base
+        # @return [Array<String>]
         def run
           errors = []
 
@@ -24,8 +25,11 @@ module Overcommit
 
         private
 
+        # @param file [String]
+        # @param errors [Array<String>]
+        # @return [void]
         def generate_errors_for_file(file, errors)
-          result = execute(['bundle', 'exec', 'solargraph', 'typecheck', '--level', 'strict', file])
+          result = execute(['bundle', 'exec', 'solargraph', 'typecheck', '--level', 'strong', file])
           return if result.success?
 
           # @type [String]
@@ -37,6 +41,9 @@ module Overcommit
           end
         end
 
+        # @param file [String]
+        # @param error [String]
+        # @return [Overcommit::Hook::Message, nil]
         def parse_error(file, error)
           # Parse the result for the line number                # @type [MatchData]
           match = error.match(/^(.+?):(\d+)/)

data/.solargraph.yml

@@ -4,6 +4,7 @@ include:
   - ".git-hooks/**/*.rb"
 exclude:
   - spec/**/*
+  - feature/**/*
   - test/**/*
   - vendor/**/*
   - ".bundle/**/*"
@@ -12,7 +13,7 @@ domains: []
 reporters:
   - rubocop
   - require_not_found
-  - typecheck:strict
+  - typecheck:strong
   - update_errors
 formatter:
   rubocop:

data/Gemfile

@@ -19,15 +19,14 @@ gem 'overcommit', ['>=0.60.0', '<0.61.0']
 gem 'pry'
 gem 'punchlist'
 gem 'rake', '~> 13.0'
-# ensure recent definitions
-gem 'rbs', ['>3.0.3']
+gem 'rbs'
 gem 'rubocop', ['~> 1.52']
 gem 'rubocop-minitest'
 gem 'rubocop-rake'
 # ensure version with branch coverage
 gem 'simplecov', ['>=0.18.0']
 gem 'simplecov-lcov'
-gem 'solargraph'
+gem 'solargraph', ['>=0.49.0']
 gem 'undercover'
 gem 'webmock'
 

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.39.4)
+    checkoff (0.40.0)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -79,7 +79,7 @@ GEM
     imagen (0.1.8)
       parser (>= 2.5, != 2.5.1.1)
     iniparse (1.5.0)
-    jaro_winkler (1.5.4)
+    jaro_winkler (1.5.6)
     json (2.6.3)
     jwt (2.2.3)
     kramdown (2.4.0)
@@ -110,12 +110,12 @@ GEM
     multi_json (1.15.0)
     multi_xml (0.6.0)
     multipart-post (2.1.1)
-    nokogiri (1.14.3)
-      mini_portile2 (~> 2.8.0)
+    nokogiri (1.15.2)
+      mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
-    nokogiri (1.14.3-x86_64-darwin)
+    nokogiri (1.15.2-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.14.3-x86_64-linux)
+    nokogiri (1.15.2-x86_64-linux)
       racc (~> 1.4)
     oauth2 (1.4.11)
       faraday (>= 0.17.3, < 3.0)
@@ -136,11 +136,11 @@ GEM
     public_suffix (5.0.0)
     punchlist (1.3.0)
       source_finder (>= 2)
-    racc (1.6.2)
+    racc (1.7.1)
     rack (3.0.6.1)
     rainbow (3.1.1)
     rake (13.0.3)
-    rbs (3.1.0)
+    rbs (2.8.4)
     regexp_parser (2.8.0)
     reverse_markdown (2.1.1)
       nokogiri
@@ -171,24 +171,25 @@ GEM
     simplecov-html (0.12.3)
     simplecov-lcov (0.8.0)
     simplecov_json_formatter (0.1.3)
-    solargraph (0.48.0)
+    solargraph (0.49.0)
       backport (~> 1.2)
       benchmark
-      bundler (>= 1.17.2)
+      bundler (~> 2.0)
       diff-lcs (~> 1.4)
       e2mmap
       jaro_winkler (~> 1.5)
       kramdown (~> 2.3)
       kramdown-parser-gfm (~> 1.1)
       parser (~> 3.0)
-      reverse_markdown (>= 1.0.5, < 3)
-      rubocop (>= 0.52)
+      rbs (~> 2.0)
+      reverse_markdown (~> 2.0)
+      rubocop (~> 1.38)
       thor (~> 1.0)
       tilt (~> 2.0)
       yard (~> 0.9, >= 0.9.24)
     source_finder (3.2.1)
-    thor (1.2.1)
-    tilt (2.1.0)
+    thor (1.2.2)
+    tilt (2.2.0)
     tomlrb (2.0.3)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
@@ -225,13 +226,13 @@ DEPENDENCIES
   pry
   punchlist
   rake (~> 13.0)
-  rbs (> 3.0.3)
+  rbs
   rubocop (~> 1.52)
   rubocop-minitest
   rubocop-rake
   simplecov (>= 0.18.0)
   simplecov-lcov
-  solargraph
+  solargraph (>= 0.49.0)
   undercover
   webmock
 

data/lib/checkoff/internal/search_url/simple_param_converter.rb

@@ -31,12 +31,20 @@ module Checkoff
             end
           end
 
-          attr_reader :key, :values
+          # @return [String]
+          attr_reader :key
+
+          # @return [Array<String>]
+          attr_reader :values
 
           # Inputs:
           #   123_column_456 means "abc" project, "def" section
           #   123 means "abc" project
           #   123~456 means "abc" and "def" projects
+          #
+          # @param projects [Array<String>]
+          # @param sections [Array<String>]
+          # @return [void]
           def parse_projects_and_sections(projects, sections)
             single_value.split('~').each do |project_section_pair|
               # @sg-ignore
@@ -49,6 +57,8 @@ module Checkoff
             end
           end
 
+          # @param verb [String]
+          # @return [Array<String>]
           def convert_from_projects_and_sections(verb)
             projects = []
             sections = []
@@ -62,6 +72,7 @@ module Checkoff
 
         # Handle 'any_projects.ids' search url param
         class AnyProjectsIds < SimpleParam
+          # @return [Array<String>]
           def convert
             convert_from_projects_and_sections('any')
           end
@@ -69,6 +80,7 @@ module Checkoff
 
         # Handle 'not_projects.ids' search url param
         class NotProjectsIds < SimpleParam
+          # @return [Array<String>]
           def convert
             convert_from_projects_and_sections('not')
           end
@@ -76,6 +88,7 @@ module Checkoff
 
         # Handle 'completion' search url param
         class Completion < SimpleParam
+          # @return [Array<String>]
           def convert
             case single_value
             when 'incomplete'
@@ -90,6 +103,7 @@ module Checkoff
 
         # Handle 'not_tags.ids' search url param
         class NotTagsIds < SimpleParam
+          # @return [Array<String>]
           def convert
             tag_ids = single_value.split('~')
             ['tags.not', tag_ids.join(',')]
@@ -98,6 +112,7 @@ module Checkoff
 
         # handle 'subtask' search url param
         class Subtask < SimpleParam
+          # @return [Array<[String, Boolean]>]
           def convert
             case single_value
             when 'is_not_subtask'
@@ -112,6 +127,7 @@ module Checkoff
 
         # Handle 'any_tags.ids' search url param
         class AnyTagsIds < SimpleParam
+          # @return [Array<String>]
           def convert
             tag_ids = single_value.split('~')
             ['tags.any', tag_ids.join(',')]
@@ -120,6 +136,7 @@ module Checkoff
 
         # Handle 'sort' search url param
         class Sort < SimpleParam
+          # @return [Array<String>]
           def convert
             # https://developers.asana.com/reference/searchtasksforworkspace
             conversion = {
@@ -132,6 +149,16 @@ module Checkoff
             ['sort_by', conversion.fetch(single_value)]
           end
         end
+
+        # Handle 'milestone' search url param
+        class Milestone < SimpleParam
+          # @return [Array<String>]
+          def convert
+            return %w[resource_subtype milestone] if single_value == 'is_milestone'
+
+            raise "Teach me how to handle #{key} = #{values}"
+          end
+        end
       end
 
       # Convert simple parameters - ones where the param name itself
@@ -160,6 +187,7 @@ module Checkoff
           'any_tags.ids' => SimpleParam::AnyTagsIds,
           'subtask' => SimpleParam::Subtask,
           'sort' => SimpleParam::Sort,
+          'milestone' => SimpleParam::Milestone,
         }.freeze
 
         # https://developers.asana.com/docs/search-tasks-in-a-workspace
@@ -170,12 +198,14 @@ module Checkoff
         def convert_arg(key, values)
           # @type [Class<SimpleParam::SimpleParam>]
           clazz = ARGS.fetch(key)
+          # @sg-ignore
           # @type [SimpleParam::SimpleParam]
           obj = clazz.new(key: key, values: values)
           # @sg-ignore
           obj.convert
         end
 
+        # @return [Hash<String, Array<String>>]
         attr_reader :simple_url_params
       end
     end

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.39.4'
+  VERSION = '0.40.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.39.4
+  version: 0.40.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-16 00:00:00.000000000 Z
+date: 2023-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport