checkoff 0.39.2 → 0.39.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e76d0cf72eb0426c6c69b27837d486f9cbe6de2f0782b10acc157f1b305941b1
-  data.tar.gz: effbabaaccae53bf8e3e843f509bba7477a24a34be44542906bf33e39a6a1f91
+  metadata.gz: 4157afdaf7db7bbf6334a968a5d06f1a5ce0f248d62aa854192b85c0514232ff
+  data.tar.gz: be6032a66aa14f3ddad56293d5728508f1540304f28c6acd59d1677097d26a0c
 SHA512:
-  metadata.gz: a0d0e684e7811ab1ba2637117969e114b1c2c01e8e495f5dd2aa42255ff9d8ee1b67cf6368dcb2908ce1e70000b51c537492a5e812632b2c134ff0b632602510
-  data.tar.gz: b24402a8cbf03684397dddea78ba3d778cd96fbb9408a828853e737c65b787b7bb1170f14ff5f28d1efb7b599766e944df8f1e2ce27eff93f03e5b02736ccd86
+  metadata.gz: 6d6b3bcae0366a5da00d6735d7f2cb5a96d29cdf08b85ac8a9571dd2c13bce8553e2083d3760895ae02a1a3b1f354c07ab50b589d4bf9e55799faefa899150ca
+  data.tar.gz: a58eb7f567d9d70af6b0a60eac27fc918ce0fddccf6773bcc7e969c260269d114618d6042042331015f9c6e095ddc40cd3c9fa77ebd2cf99f3a17b8f1e30edd7

data/.git-hooks/pre_commit/punchlist.rb

@@ -15,7 +15,7 @@ module Overcommit
           stdout.split("\n").map do |line|
             # @sg-ignore
             file, line_no, _message = line.split(':', 3)
-            Overcommit::Hook::Message.new(:warning, file, line_no.to_i, line)
+            Overcommit::Hook::Message.new(:error, file, line_no.to_i, line)
           end
         end
 

data/.overcommit.yml

@@ -64,14 +64,20 @@ PreCommit:
     include:
       - '**/*.rb'
   Punchlist:
-    on_warn: fail
     command: ['bundle', 'exec', 'punchlist']
     enabled: true
+    problem_on_unmodified_line: warn
 
 PrePush:
-  Minitest:
-    command: ['ruby', '-Ilib:test/unit:lib/checkoff', '-rbundler/setup', '-rminitest', "-e 'exit! Minitest.run'"]
+  RakeTarget:
     enabled: true
+    command: ['bundle', 'exec', 'rake']
+    include:
+      - 'Rakefile'
+    targets:
+      - 'clear_metrics'
+      - 'test'
+      - 'undercover'
 
 #PostCheckout:
 #  ALL: # Special hook name that customizes all hooks of this type

data/Gemfile

@@ -5,6 +5,32 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in checkoff.gemspec
 gemspec
 
+gem 'bump'
+gem 'bundler'
+gem 'fakeweb'
+gem 'mdl'
+gem 'minitest-profile'
+gem 'minitest-reporters'
+gem 'mocha', ['~> 2.0.0.alpha.1']
+# 0.58.0 and 0.57.0 don't seem super compatible with signatures, and
+# magit doesn't seem to want to use the bundled version at the moment,
+# so let's favor the more recent version...
+gem 'overcommit', ['>=0.60.0', '<0.61.0']
+gem 'pry'
+gem 'punchlist'
+gem 'rake', '~> 13.0'
+# ensure recent definitions
+gem 'rbs', ['>3.0.3']
+gem 'rubocop', ['~> 1.52']
+gem 'rubocop-minitest'
+gem 'rubocop-rake'
+# ensure version with branch coverage
+gem 'simplecov', ['>=0.18.0']
+gem 'simplecov-lcov'
+gem 'solargraph'
+gem 'undercover'
+gem 'webmock'
+
 # ruby-asana gem is pending key bugfixes for checkoff as of
 # 2021-07-29:
 #

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.39.2)
+    checkoff (0.39.4)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -45,7 +45,7 @@ GEM
     concurrent-ruby (1.2.2)
     crack (0.4.5)
       rexml
-    dalli (3.2.4)
+    dalli (3.2.5)
     diff-lcs (1.5.0)
     docile (1.4.0)
     e2mmap (0.1.0)
@@ -80,7 +80,7 @@ GEM
       parser (>= 2.5, != 2.5.1.1)
     iniparse (1.5.0)
     jaro_winkler (1.5.4)
-    json (2.6.2)
+    json (2.6.3)
     jwt (2.2.3)
     kramdown (2.4.0)
       rexml
@@ -127,8 +127,8 @@ GEM
       childprocess (>= 0.6.3, < 5)
       iniparse (~> 1.4)
       rexml (~> 3.2)
-    parallel (1.22.1)
-    parser (3.1.2.1)
+    parallel (1.23.0)
+    parser (3.2.2.1)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
@@ -141,22 +141,22 @@ GEM
     rainbow (3.1.1)
     rake (13.0.3)
     rbs (3.1.0)
-    regexp_parser (2.6.0)
+    regexp_parser (2.8.0)
     reverse_markdown (2.1.1)
       nokogiri
     rexml (3.2.5)
-    rubocop (1.36.0)
+    rubocop (1.52.0)
       json (~> 2.3)
       parallel (~> 1.10)
-      parser (>= 3.1.2.1)
+      parser (>= 3.2.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.20.1, < 2.0)
+      rubocop-ast (>= 1.28.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.22.0)
-      parser (>= 3.1.1.0)
+      unicode-display_width (>= 2.4.0, < 3.0)
+    rubocop-ast (1.29.0)
+      parser (>= 3.2.1.0)
     rubocop-minitest (0.12.1)
       rubocop (>= 0.90, < 2.0)
     rubocop-rake (0.5.1)
@@ -196,7 +196,7 @@ GEM
       imagen (>= 0.1.8)
       rainbow (>= 2.1, < 4.0)
       rugged (>= 0.27, < 1.6)
-    unicode-display_width (2.3.0)
+    unicode-display_width (2.4.2)
     webmock (3.18.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
@@ -226,7 +226,7 @@ DEPENDENCIES
   punchlist
   rake (~> 13.0)
   rbs (> 3.0.3)
-  rubocop (~> 1.36, < 1.44)
+  rubocop (~> 1.52)
   rubocop-minitest
   rubocop-rake
   simplecov (>= 0.18.0)

data/checkoff.gemspec

@@ -30,33 +30,6 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'dalli'
   spec.add_runtime_dependency 'gli'
 
-  spec.add_development_dependency 'bump'
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'fakeweb'
-  spec.add_development_dependency 'mdl'
-  spec.add_development_dependency 'minitest-profile'
-  spec.add_development_dependency 'minitest-reporters'
-  spec.add_development_dependency 'mocha', ['~> 2.0.0.alpha.1']
-  # 0.58.0 and 0.57.0 don't seem super compatible with signatures, and
-  # magit doesn't seem to want to use the bundled version at the moment,
-  # so let's favor the more recent version...
-  spec.add_development_dependency 'overcommit', ['>=0.60.0', '<0.61.0']
-  spec.add_development_dependency 'pry'
-  spec.add_development_dependency 'punchlist'
-  spec.add_development_dependency 'rake', '~> 13.0'
-  # ensure recent definitions
-  spec.add_development_dependency 'rbs', ['>3.0.3']
-  # I haven't adapted things to Gemspec/DevelopmentDependencies yet,
-  # which arrives in 1.44
-  spec.add_development_dependency 'rubocop', ['~> 1.36', '<1.44']
-  spec.add_development_dependency 'rubocop-minitest'
-  spec.add_development_dependency 'rubocop-rake'
-  # ensure version with branch coverage
-  spec.add_development_dependency 'simplecov', ['>=0.18.0']
-  spec.add_development_dependency 'simplecov-lcov'
-  spec.add_development_dependency 'solargraph'
-  spec.add_development_dependency 'undercover'
-  spec.add_development_dependency 'webmock'
   spec.metadata = {
     'rubygems_mfa_required' => 'true',
   }

data/lib/checkoff/create-entity.sh

@@ -75,7 +75,7 @@ end
 
 # :nocov:
 abs_program_name = File.expand_path(\$PROGRAM_NAME)
-Checkoff::${class_name}.run if abs_program_name == __FILE__
+Checkoff::${class_name}.run if abs_program_name == File.expand_path(__FILE__)
 # :nocov:
 EOF
 

data/lib/checkoff/internal/search_url/custom_field_variant.rb

@@ -17,7 +17,7 @@ module Checkoff
           attr_reader :gid, :remaining_params
 
           def ensure_no_remaining_params!
-            return if remaining_params.length.zero?
+            return if remaining_params.empty?
 
             raise "Teach me how to handle these remaining keys: #{remaining_params}"
           end
@@ -62,7 +62,8 @@ module Checkoff
           def convert
             selected_options = fetch_solo_param("custom_field_#{gid}.selected_options").split('~')
 
-            [{ "custom_fields.#{gid}.is_set" => 'true' },
+            # note: task does not need to contain this custom field
+            [{},
              ['not',
               ['custom_field_gid_value_contains_any_gid',
                gid,

data/lib/checkoff/sections.rb

@@ -58,6 +58,9 @@ module Checkoff
     # @param extra_fields [Array<String>]
     # @return [Hash{[String, nil] => Array<Asana::Resources::Task>}]
     def tasks_by_section(workspace_name, project_name, extra_fields: [])
+      raise ArgumentError, 'Provided nil workspace name' if workspace_name.nil?
+      raise ArgumentError, 'Provided nil project name' if project_name.nil?
+
       project = project_or_raise(workspace_name, project_name)
       if project_name == :my_tasks
         my_tasks.tasks_by_section_for_my_tasks(project, extra_fields: extra_fields)
@@ -175,6 +178,8 @@ module Checkoff
     # @param project_name [String, Symbol]
     # @return [Asana::Resources::Project]
     def project_or_raise(workspace_name, project_name)
+      raise ArgumentError, 'Provide nil project_name' if project_name.nil?
+
       project = projects.project(workspace_name, project_name)
       if project.nil?
         raise "Could not find project #{project_name} " \
@@ -185,7 +190,7 @@ module Checkoff
 
     def section(workspace_name, project_name, section_name)
       sections = sections_or_raise(workspace_name, project_name)
-      sections.find { |section| section.name.chomp(':') == section_name.chomp(':') }
+      sections.find { |section| section_key(section.name)&.chomp(':') == section_name&.chomp(':') }
     end
   end
 end

data/lib/checkoff/task_searches.rb

@@ -100,5 +100,5 @@ end
 
 # :nocov:
 abs_program_name = File.expand_path($PROGRAM_NAME)
-Checkoff::TaskSearches.run if abs_program_name == __FILE__
+Checkoff::TaskSearches.run if abs_program_name == File.expand_path(__FILE__)
 # :nocov:

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.39.2'
+  VERSION = '0.39.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.39.2
+  version: 0.39.4
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-05 00:00:00.000000000 Z
+date: 2023-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -80,298 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: bump
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: fakeweb
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mdl
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest-profile
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest-reporters
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mocha
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.0.0.alpha.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.0.0.alpha.1
-- !ruby/object:Gem::Dependency
-  name: overcommit
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.60.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 0.61.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.60.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 0.61.0
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: punchlist
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: rbs
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: 3.0.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">"
-      - !ruby/object:Gem::Version
-        version: 3.0.3
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.36'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '1.44'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.36'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '1.44'
-- !ruby/object:Gem::Dependency
-  name: rubocop-minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.18.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.18.0
-- !ruby/object:Gem::Dependency
-  name: simplecov-lcov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: solargraph
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: undercover
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description:
 email:
 - vince@broz.cc