checkoff 0.39.1 → 0.39.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dde98e951a53086231de929b8eab46e11ab7056e853879da48363a17e36c9404
-  data.tar.gz: c3e8bd5a59452d1e3cbaa5776b1b36b9ea9097062cee836dbc54b42c2b400e36
+  metadata.gz: aa2ffaa601bf3d945584d0a6980995e752540b8360b881b5b43a11687f850580
+  data.tar.gz: a3b1cec57d8681bacbda6846c7b2e6687c5c82ed9686b9f8923b724a186c1ed1
 SHA512:
-  metadata.gz: 9c673008ef9a2985c5ffa0b22bbda49199c4b072bd6c90c2642bf318d5a1fa455b85677016e046cd0f10aada9cff0507f1ba4b53317d5407a13c746e8a625247
-  data.tar.gz: f1eba99cad086db81ba4b69a28cefd754ac4c98d3a9016ed191e065481011b5971194be2c80a303d55daa48c195ef4506d7ae3c364719cc707faab05c259e1b5
+  metadata.gz: '0829ec340d5422c372e8d30fd2e2558bcebf4064efe9204c8976ac7356fc89eade3729b501bcc6b4094869654eaad19bba912b08943ee7b8c3d2e91d0c6bb80b'
+  data.tar.gz: 2ec581cea785506d3cf52d4776de02dea6ae260b24a15ade128350a353b50fd41e641ac80a8cdf5de99b51c800b10a86f68efc0a744ca3236bd0261e6ee107e5

data/.git-hooks/pre_commit/punchlist.rb

@@ -15,7 +15,7 @@ module Overcommit
           stdout.split("\n").map do |line|
             # @sg-ignore
             file, line_no, _message = line.split(':', 3)
-            Overcommit::Hook::Message.new(:warning, file, line_no.to_i, line)
+            Overcommit::Hook::Message.new(:error, file, line_no.to_i, line)
           end
         end
 

data/.overcommit.yml

@@ -64,14 +64,20 @@ PreCommit:
     include:
       - '**/*.rb'
   Punchlist:
-    on_warn: fail
     command: ['bundle', 'exec', 'punchlist']
     enabled: true
+    problem_on_unmodified_line: warn
 
 PrePush:
-  Minitest:
-    command: ['ruby', '-Ilib:test/unit:lib/checkoff', '-rbundler/setup', '-rminitest', "-e 'exit! Minitest.run'"]
+  RakeTarget:
     enabled: true
+    command: ['bundle', 'exec', 'rake']
+    include:
+      - 'Rakefile'
+    targets:
+      - 'clear_metrics'
+      - 'test'
+      - 'undercover'
 
 #PostCheckout:
 #  ALL: # Special hook name that customizes all hooks of this type

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.39.1)
+    checkoff (0.39.3)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -74,7 +74,7 @@ GEM
       multi_json
     gli (2.21.0)
     hashdiff (1.0.1)
-    i18n (1.14.0)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     imagen (0.1.8)
       parser (>= 2.5, != 2.5.1.1)

data/config/definitions.rb

@@ -14,6 +14,8 @@
 #       def tasks; end
 #       # @return [Asana::ProxiedResourceClasses::Workspace]
 #       def workspaces; end
+#       # @return [Asana::ProxiedResourceClasses::Section]
+#       def sections; end
 #     end
 #     module Resources
 #       class Task
@@ -43,10 +45,26 @@
 #         # @param options [Hash] the request I/O options.
 #         # @return [Asana::Resources::Task]
 #         def find_by_id(id, options: {}); end
+#         # @param section [Asana::Resources::section]
+#         # @param options [Hash] the request I/O options.
+#         # @return [Array<Asana::Resources::Task>]
+#         def get_tasks(assignee: nil,
+#                       project: nil,
+#                       section: nil,
+#                       workspace: nil,
+#                       completed_since: nil,
+#                       per_page: 20,
+#                       modified_since: nil,
+#                       options: {}); end
 #       end
 #       class Workspace
 #         # @return [Array<Asana::Resources::Workspace>]
 #         def find_all; end
 #       end
+#       class Section
+#         # @param project_gid [String]
+#         # @return [Array<Asana::Resources::Section>]
+#         def get_sections_for_project(client, project_gid:, options: {}); end
+#       end
 #     end
 #   end

data/lib/checkoff/sections.rb

@@ -9,14 +9,23 @@ require_relative 'my_tasks'
 module Checkoff
   # Query different sections of Asana projects
   class Sections
+    # @!parse
+    #   extend CacheMethod::ClassMethods
+
     MINUTE = 60
+    # @sg-ignore
     LONG_CACHE_TIME = MINUTE * 15
+    # @sg-ignore
     SHORT_CACHE_TIME = MINUTE * 5
 
     extend Forwardable
 
     attr_reader :projects, :workspaces, :time, :my_tasks
 
+    # @param client [Asana::Client]
+    # @param projects [Checkoff::Projects]
+    # @param workspaces [Checkoff::Workspaces]
+    # @param time [Class<Time>]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
                    client: Checkoff::Clients.new(config: config).client,
                    projects: Checkoff::Projects.new(config: config,
@@ -32,8 +41,13 @@ module Checkoff
     end
 
     # Returns a list of Asana API section objects for a given project
+    # @param workspace_name [String]
+    # @param project_name [String, Symbol]
+    #
+    # @return [Array<Asana::Resources::Section>]
     def sections_or_raise(workspace_name, project_name)
       project = project_or_raise(workspace_name, project_name)
+      # @sg-ignore
       client.sections.get_sections_for_project(project_gid: project.gid)
     end
 
@@ -55,6 +69,14 @@ module Checkoff
     # XXX: Rename to section_tasks
     #
     # Pulls task objects from a specified section
+    #
+    # @param workspace_name [String]
+    # @param project_name [String, Symbol]
+    # @param section_name [String, nil]
+    # @param only_uncompleted [Boolean]
+    # @param extra_fields [Array<String>]
+    #
+    # @return [Array<Asana::Resources::Task>]
     def tasks(workspace_name, project_name, section_name,
               only_uncompleted: true,
               extra_fields: [])
@@ -71,27 +93,35 @@ module Checkoff
     # @param workspace_name [String]
     # @param project_name [String, Symbol]
     # @param section_name [String, nil]
+    #
     # @return [Array<String>]
     def section_task_names(workspace_name, project_name, section_name)
-      tasks = tasks(workspace_name, project_name, section_name)
-      tasks.map(&:name)
+      task_array = tasks(workspace_name, project_name, section_name)
+      task_array.map(&:name)
     end
     cache_method :section_task_names, SHORT_CACHE_TIME
 
+    # @param workspace_name [String]
+    # @param project_name [String, Symbol]
+    # @param section_name [String, nil]
+    #
+    # @return [Asana::Resources::Section]
     def section_or_raise(workspace_name, project_name, section_name)
-      section = section(workspace_name, project_name, section_name)
-      if section.nil?
+      s = section(workspace_name, project_name, section_name)
+      if s.nil?
         valid_sections = sections_or_raise(workspace_name, project_name).map(&:name)
 
         raise "Could not find section #{section_name} under project #{project_name} " \
               "under workspace #{workspace_name}.  Valid sections: #{valid_sections}"
       end
-      section
+      s
     end
     cache_method :section_or_raise, LONG_CACHE_TIME
 
     private
 
+    # @!attribute [r] client
+    #   @return [Asana::Client]
     attr_reader :client
 
     # Given a project object, pull all tasks, then provide a Hash of
@@ -117,6 +147,7 @@ module Checkoff
     # @return [Hash<[String,nil], Array<Asana::Resources::Task>>]
     def by_section(tasks, project_gid)
       by_section = {}
+      # @sg-ignore
       sections = client.sections.get_sections_for_project(project_gid: project_gid)
       sections.each { |section| by_section[section_key(section.name)] = [] }
       tasks.each { |task| file_task_by_section(by_section, task, project_gid) }
@@ -124,15 +155,25 @@ module Checkoff
     end
     cache_method :by_section, LONG_CACHE_TIME
 
+    # @param by_section [Hash{[String, nil] => Array<Asana::Resources::Task>}]
+    # @param task [Asana::Resources::Task]
+    # @param project_gid [String]
+    # @return [void]
     def file_task_by_section(by_section, task, project_gid)
+      # @type [Array<Hash>]
       membership = task.memberships.find { |m| m['project']['gid'] == project_gid }
       raise "Could not find task in project_gid #{project_gid}: #{task}" if membership.nil?
 
+      # @type [String, nil]
       current_section = section_key(membership['section']['name'])
 
+      # @sg-ignore
       by_section.fetch(current_section) << task
     end
 
+    # @param workspace_name [String]
+    # @param project_name [String, Symbol]
+    # @return [Asana::Resources::Project]
     def project_or_raise(workspace_name, project_name)
       project = projects.project(workspace_name, project_name)
       if project.nil?
@@ -144,7 +185,7 @@ module Checkoff
 
     def section(workspace_name, project_name, section_name)
       sections = sections_or_raise(workspace_name, project_name)
-      sections.find { |section| section.name.chomp(':') == section_name.chomp(':') }
+      sections.find { |section| section_key(section.name)&.chomp(':') == section_name&.chomp(':') }
     end
   end
 end

data/lib/checkoff/tasks.rb

@@ -64,13 +64,13 @@ module Checkoff
     end
 
     # Pull a specific task by name
+    # @param task_gid [String]
+    # @param extra_fields [Array<String>]
     # @return [Asana::Resources::Task, nil]
     def task_by_gid(task_gid,
-                    only_uncompleted: true,
                     extra_fields: [])
-      options = projects.task_options
-      options[:options][:fields] += extra_fields
-      options[:completed_since] = '9999-12-01' if only_uncompleted
+      options = projects.task_options.fetch(:options, {})
+      options[:fields] += extra_fields
       client.tasks.find_by_id(task_gid, options: options)
     end
 

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.39.1'
+  VERSION = '0.39.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.39.1
+  version: 0.39.3
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-04 00:00:00.000000000 Z
+date: 2023-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport