checkoff 0.38.0 → 0.39.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb28394467995eb9df10b9fa896614dca20ef97b0759c2945bb3baaf98ba0d56
-  data.tar.gz: 3b565699736d8956d83a94e8c93d910ecfac4f7f65280e27303d0da8dd3fd6ff
+  metadata.gz: dde98e951a53086231de929b8eab46e11ab7056e853879da48363a17e36c9404
+  data.tar.gz: c3e8bd5a59452d1e3cbaa5776b1b36b9ea9097062cee836dbc54b42c2b400e36
 SHA512:
-  metadata.gz: 3cfeaa16ebe32cda3959dfce64b72382e743d5dcf40a2d1771c2b2d725594f8d505f094139163bca7e6059908b02d5811260c75b7670126a1bcdf22fb306c9f6
-  data.tar.gz: 9066df52dadb002a5b8bd34a7a1fc852d1e45b4543202e21995dee9e491703357ba305b612c5772d5c9c0153e5c7245c9304988e0f5751b608bfbe03e420d214
+  metadata.gz: 9c673008ef9a2985c5ffa0b22bbda49199c4b072bd6c90c2642bf318d5a1fa455b85677016e046cd0f10aada9cff0507f1ba4b53317d5407a13c746e8a625247
+  data.tar.gz: f1eba99cad086db81ba4b69a28cefd754ac4c98d3a9016ed191e065481011b5971194be2c80a303d55daa48c195ef4506d7ae3c364719cc707faab05c259e1b5

data/.git-hooks/pre_commit/solargraph_typecheck.rb

@@ -49,7 +49,7 @@ module Overcommit
           message = error.sub("#{file_path}:#{lineno} - ",
                               "#{file_path}:#{lineno}: ")
           # Emit the errors in the specified format
-          Overcommit::Hook::Message.new(:error, file, lineno, message)
+          Overcommit::Hook::Message.new(:error, file, lineno.to_i, message)
         end
       end
     end

data/.overcommit.yml

@@ -25,7 +25,6 @@ PreCommit:
     quiet: true
   RuboCop:
     enabled: true
-    on_warn: fail # Treat all warnings as failures
     command: ['bundle', 'exec', 'rubocop']
     include:
       - '**/*.gemspec'
@@ -36,6 +35,7 @@ PreCommit:
       - '**/Rakefile'
       - 'bin/*'
       - 'exe/*'
+    problem_on_unmodified_line: warn
     exclude:
       - db/migrate/*.rb
       - db/schema.rb
@@ -60,7 +60,7 @@ PreCommit:
     enabled: true
   SolargraphTypecheck:
     enabled: true
-    on_warn: fail
+    problem_on_unmodified_line: warn
     include:
       - '**/*.rb'
   Punchlist:

data/.rubocop.yml

@@ -5,6 +5,10 @@ Layout/LineLength:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
+Lint/EmptyClass:
+  # some workarounds for circular dependencies require empty classes
+  AllowComments: true
+
 Lint/UnusedMethodArgument:
   AllowUnusedKeywordArguments: true
 
@@ -79,6 +83,11 @@ Style/StringLiterals:
     - double_quotes
   ConsistentQuotesInMultiline: true
 
+# Solargraph needs to see a class inherited from Struct to recognize
+# what's going on
+Style/StructInheritance:
+  Enabled: false
+
 # I like trailing commas in arrays and hashes.  They let me insert new
 # elements and see them as one line in a diff, not two.
 Style/TrailingCommaInArrayLiteral:

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.38.0)
+    checkoff (0.39.1)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -74,7 +74,7 @@ GEM
       multi_json
     gli (2.21.0)
     hashdiff (1.0.1)
-    i18n (1.13.0)
+    i18n (1.14.0)
       concurrent-ruby (~> 1.0)
     imagen (0.1.8)
       parser (>= 2.5, != 2.5.1.1)

data/lib/checkoff/internal/search_url/simple_param_converter.rb

@@ -99,9 +99,14 @@ module Checkoff
         # handle 'subtask' search url param
         class Subtask < SimpleParam
           def convert
-            return ['is_subtask', false] if single_value == 'is_not_subtask'
-
-            raise "Teach me how to handle #{key} = #{values}"
+            case single_value
+            when 'is_not_subtask'
+              ['is_subtask', false]
+            when 'is_subtask'
+              ['is_subtask', true]
+            else
+              raise "Teach me how to handle #{key} = #{values}"
+            end
           end
         end
 

data/lib/checkoff/sections.rb

@@ -39,6 +39,10 @@ module Checkoff
 
     # Given a workspace name and project name, then provide a Hash of
     # tasks with section name -> task list of the uncompleted tasks
+    # @param workspace_name [String]
+    # @param project_name [String, Symbol]
+    # @param extra_fields [Array<String>]
+    # @return [Hash{[String, nil] => Array<Asana::Resources::Task>}]
     def tasks_by_section(workspace_name, project_name, extra_fields: [])
       project = project_or_raise(workspace_name, project_name)
       if project_name == :my_tasks
@@ -64,6 +68,10 @@ module Checkoff
     cache_method :tasks, SHORT_CACHE_TIME
 
     # Pulls just names of tasks from a given section.
+    # @param workspace_name [String]
+    # @param project_name [String, Symbol]
+    # @param section_name [String, nil]
+    # @return [Array<String>]
     def section_task_names(workspace_name, project_name, section_name)
       tasks = tasks(workspace_name, project_name, section_name)
       tasks.map(&:name)
@@ -88,6 +96,8 @@ module Checkoff
 
     # Given a project object, pull all tasks, then provide a Hash of
     # tasks with section name -> task list of the uncompleted tasks
+    # @param project [Asana::Resources::Project]
+    # @return [Hash<[String,nil], Array<Asana::Resources::Task>>]
     def tasks_by_section_for_project(project, extra_fields: [])
       raw_tasks = projects.tasks_from_project(project, extra_fields: extra_fields)
       active_tasks = projects.active_tasks(raw_tasks)
@@ -102,6 +112,9 @@ module Checkoff
     end
 
     # Given a list of tasks, pull a Hash of tasks with section name -> task list
+    # @param tasks [Array<Asana::Resources::Task>]
+    # @param project_gid [String]
+    # @return [Hash<[String,nil], Array<Asana::Resources::Task>>]
     def by_section(tasks, project_gid)
       by_section = {}
       sections = client.sections.get_sections_for_project(project_gid: project_gid)

data/lib/checkoff/subtasks.rb

@@ -27,6 +27,8 @@ module Checkoff
     end
 
     # pulls a Hash of subtasks broken out by section
+    # @param tasks [Array<Asana::Resources::Task>]
+    # @return [Hash<[nil,String], Array<Asana::Resources::Task>>]
     def by_section(tasks)
       current_section = nil
       by_section = { nil => [] }

data/lib/checkoff/task_selectors.rb

@@ -14,7 +14,6 @@ require_relative 'tasks'
 module Checkoff
   # Filter lists of tasks using declarative selectors.
   class TaskSelectors
-    # @type [Integer]
     MINUTE = 60
     HOUR = MINUTE * 60
     DAY = 24 * HOUR
@@ -30,8 +29,10 @@ module Checkoff
       @tasks = tasks
     end
 
+    # @param [Asana::Resources::Task] task
     # @param [Hash<Symbol, Object>] task_selector Filter based on
     #        description.  Examples: {tag: 'foo'} {:not {tag: 'foo'} (:tag 'foo')
+    # @return [Boolean]
     def filter_via_task_selector(task, task_selector)
       evaluator = TaskSelectorEvaluator.new(task: task, tasks: tasks)
       evaluator.evaluate(task_selector)

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.38.0'
+  VERSION = '0.39.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.38.0
+  version: 0.39.1
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-05-29 00:00:00.000000000 Z
+date: 2023-06-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport