checkoff 0.26.1 → 0.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 10a2b886559bd9a77cdf03a309825250a99c4e03c251f0c1699b9941aef09e30
-  data.tar.gz: cab6c6505b28ee63b79c8b6765efc2401d10f4d4ec53b6b86791283a87f5a065
+  metadata.gz: bc77ff8291abdf8396b00f06b6a264aced462d4017962f22b12be600ca0838e7
+  data.tar.gz: 04cd04ace148582a064b9eb52fa46e738e8621effe5316f8e9dc75909564d3b2
 SHA512:
-  metadata.gz: e170ab3b7c20cdf9ccb0f6fc89df6277c5bebecaa1da242f58ddeab3dbedc955e097307ad23c11b88d368ae8aeb5fa73e6c0584a05aeaa335232ec753b7235b7
-  data.tar.gz: 6ff4dcbeeaa90e46fa67578c44ce68f790de5569b5a3a19c6d7ebf3a9181aa566921b31f4a9afb0504292a274ce4e51c0b5cb0a8480d0be75b435493f4a687dc
+  metadata.gz: 1aa7f83850fd0b422d1c9d2e9f0634da82bc16bfd9a84a0116b839921c64448de06b49a7c8af009bfce2c282d5c7b6f65b2cf7e5dc4fdef31724613984010c31
+  data.tar.gz: 9317f20ab81c07d64ae5c955ffe345a2849ba966d5faf9de03d73e8712ddac3ad0d1d90ac70dc7af3af54dcf6a12ae48bb80aa8e4ec43eed4368942fae206b32

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.26.1)
+    checkoff (0.28.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/internal/search_url/custom_field_param_converter.rb

@@ -49,6 +49,7 @@ module Checkoff
         VARIANTS = {
           'is' => CustomFieldVariant::Is,
           'no_value' => CustomFieldVariant::NoValue,
+          'any_value' => CustomFieldVariant::AnyValue,
           'is_not' => CustomFieldVariant::IsNot,
           'less_than' => CustomFieldVariant::LessThan,
           'greater_than' => CustomFieldVariant::GreaterThan,

data/lib/checkoff/internal/search_url/custom_field_variant.rb

@@ -16,6 +16,12 @@ module Checkoff
 
           attr_reader :gid, :remaining_params
 
+          def ensure_no_remaining_params!
+            return if remaining_params.length.zero?
+
+            raise "Teach me how to handle these remaining keys: #{remaining_params}"
+          end
+
           def fetch_solo_param(param_name)
             case remaining_params.keys
             when [param_name]
@@ -96,9 +102,7 @@ module Checkoff
         # custom_field_#{gid}.variant = 'no_value'
         class NoValue < CustomFieldVariant
           def convert
-            unless remaining_params.length.zero?
-              raise "Teach me how to handle these remaining keys for #{variant_key}: #{remaining_params}"
-            end
+            ensure_no_remaining_params!
 
             api_params = { "custom_fields.#{gid}.is_set" => 'false' }
             # As of 2023-02, the 'is_set' => 'false' seems to not do
@@ -112,30 +116,38 @@ module Checkoff
           end
         end
 
-        # custom_field_#{gid}.variant = 'is'
-        class Is < CustomFieldVariant
+        # custom_field_#{gid}.variant = 'any_value'
+        #
+        # Not used for multi-select fields
+        class AnyValue < CustomFieldVariant
           def convert
-            unless remaining_params.length == 1
-              raise "Teach me how to handle these remaining keys for #{variant_key}: #{remaining_params}"
-            end
+            ensure_no_remaining_params!
 
-            key, values = remaining_params.to_a[0]
-            convert_custom_field_is_arg(key, values)
+            api_params = { "custom_fields.#{gid}.is_set" => 'true' }
+            task_selector = []
+            [api_params, task_selector]
           end
+        end
 
-          private
+        # custom_field_#{gid}.variant = 'is'
+        class Is < CustomFieldVariant
+          def convert
+            selected_options = fetch_solo_param("custom_field_#{gid}.selected_options").split('~')
 
-          def convert_custom_field_is_arg(key, values)
             empty_task_selector = []
-
-            if key.end_with? '.selected_options'
-              raise "Too many values found for #{key}: #{values}" if values.length != 1
-
-              return [{ "custom_fields.#{gid}.value" => values[0] },
-                      empty_task_selector]
+            if selected_options.length == 1
+              [{ "custom_fields.#{gid}.value" => selected_options[0] },
+               empty_task_selector]
+            else
+              # As of 2023-01,
+              # https://developers.asana.com/reference/searchtasksforworkspace
+              # says "Not Supported: searching for multiple exact
+              # matches of a custom field".  So I guess we have to
+              # search this manually.
+              api_params = { "custom_fields.#{gid}.is_set" => 'true' }
+              task_selector = [:custom_field_gid_value_contains_any_gid, gid, selected_options]
+              [api_params, task_selector]
             end
-
-            raise "Teach me how to handle #{key} = #{values}"
           end
         end
       end

data/lib/checkoff/internal/search_url/simple_param_converter.rb

@@ -71,9 +71,14 @@ module Checkoff
         # Handle 'completion' search url param
         class Completion < SimpleParam
           def convert
-            raise "Teach me how to handle #{key} = #{values}" if single_value != 'incomplete'
-
-            ['completed', false]
+            case single_value
+            when 'incomplete'
+              ['completed', false]
+            when 'complete'
+              ['completed', true]
+            else
+              raise "Teach me how to handle #{key} = #{values}"
+            end
           end
         end
 

data/lib/checkoff/internal/task_selector_evaluator.rb

@@ -135,7 +135,9 @@ module Checkoff
     def evaluate(task, custom_field_gid, custom_field_values_gids)
       actual_custom_field_values_gids = pull_custom_field_values_gids(task, custom_field_gid)
 
-      (custom_field_values_gids - actual_custom_field_values_gids).empty?
+      actual_custom_field_values_gids.any? do |custom_field_value|
+        custom_field_values_gids.include?(custom_field_value)
+      end
     end
 
     private

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.26.1'
+  VERSION = '0.28.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.26.1
+  version: 0.28.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-02-02 00:00:00.000000000 Z
+date: 2023-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport