checkoff 0.258.0 → 0.261.0

data/lib/checkoff/internal/selector_classes/common/function_evaluator.rb

@@ -8,7 +8,7 @@ module Checkoff
     module Common
       # Base class to evaluate a project selector function given fully evaluated arguments
       class FunctionEvaluator < ::Checkoff::SelectorClasses::FunctionEvaluator
-        # @param selector [Array(Symbol, Array), String]
+        # @param selector [Array<Symbol, Array>, Symbol]
         # @param custom_fields [Checkoff::CustomFields]
         # @param _kwargs [Hash]
         def initialize(selector:, custom_fields:, **_kwargs)
@@ -22,7 +22,7 @@ module Checkoff
 
         private
 
-        # @return [Array(Symbol, Array), String]
+        # @return [Array<Symbol, Array>, Symbol]
         attr_reader :selector
       end
     end

data/lib/checkoff/internal/selector_classes/common.rb

@@ -223,8 +223,6 @@ module Checkoff
         # @param resource [Asana::Resources::Task, Asana::Resources::Project]
         # @param prefix [String]
         # @return [boolish]
-        # @sg-ignore Checkoff::SelectorClasses::Common::NameStartsWithPFunctionEvaluator#evaluate
-        #   return type could not be inferred
         def evaluate(resource, prefix)
           resource.name&.start_with?(prefix)
         end
@@ -238,8 +236,9 @@ module Checkoff
 
         # @param _resource [Asana::Resources::Task,Asana::Resources::Project]
         # @return [String]
-        # @sg-ignore selector is only String here per matches?'s is_a?(String) check, in another method
         def evaluate(_resource)
+          raise "Expected a String selector, got #{selector.inspect}" unless selector.is_a?(String)
+
           selector
         end
       end

data/lib/checkoff/internal/selector_classes/function_evaluator.rb

@@ -26,7 +26,6 @@ module Checkoff
       end
 
       # @return [Boolean]
-      # @sg-ignore return type could not be inferred — abstract method body is only `raise`
       def matches?
         raise 'Override me!'
       end
@@ -34,17 +33,23 @@ module Checkoff
       # @param _task [Asana::Resources::Task]
       # @param _args [Array<Object>]
       # @return [Object]
-      # @sg-ignore return type could not be inferred — abstract method body is only `raise`
       def evaluate(_task, *_args)
         raise 'Implement me!'
       end
 
       private
 
-      # @param object [Object]
+      # @param object [Array<Symbol, Array>, Symbol]
       # @param fn_name [Symbol]
+      # @return [Boolean]
       def fn?(object, fn_name)
-        object.is_a?(Array) && !object.empty? && [fn_name, fn_name.to_s].include?(object[0])
+        if object.is_a?(Array) && !object.empty?
+          # @type [Array<Symbol, Array>]
+          array = object
+          [fn_name, fn_name.to_s].include?(array[0])
+        else
+          false
+        end
       end
     end
   end

data/lib/checkoff/internal/selector_classes/project/function_evaluator.rb

@@ -8,7 +8,7 @@ module Checkoff
     module Project
       # Base class to evaluate a project selector function given fully evaluated arguments
       class FunctionEvaluator < ::Checkoff::SelectorClasses::FunctionEvaluator
-        # @param selector [Array(Symbol, Array), String]
+        # @param selector [Array<Symbol, Array>, Symbol]
         # @param projects [Checkoff::Projects]
         # @param portfolios [Checkoff::Portfolios]
         # @param workspaces [Checkoff::Workspaces]
@@ -36,7 +36,7 @@ module Checkoff
 
         private
 
-        # @return [Array(Symbol, Array)]
+        # @return [Array<Symbol, Array>, Symbol]
         attr_reader :selector
       end
     end

data/lib/checkoff/internal/selector_classes/project.rb

@@ -17,7 +17,6 @@ module Checkoff
 
         # @param resource [Asana::Resources::Project]
         # @return [String, nil]
-        # @sg-ignore nilable return from an @!parse-declared method isn't inferred
         def evaluate(resource)
           resource.due_date
         end

data/lib/checkoff/internal/selector_classes/section/function_evaluator.rb

@@ -8,7 +8,7 @@ module Checkoff
     module Section
       # Base class to evaluate a project selector function given fully evaluated arguments
       class FunctionEvaluator < ::Checkoff::SelectorClasses::FunctionEvaluator
-        # @param selector [Array(Symbol, Array), String]
+        # @param selector [Array<Symbol, Array>, Symbol]
         # @param client [Asana::Client]
         # @param sections [Checkoff::Sections]
         # @param kwargs [Hash]
@@ -30,7 +30,7 @@ module Checkoff
 
         private
 
-        # @return [Array(Symbol, Array)]
+        # @return [Array<Symbol, Array>, Symbol]
         attr_reader :selector
       end
     end

data/lib/checkoff/internal/selector_classes/section.rb

@@ -18,12 +18,11 @@ module Checkoff
         # @param section [Asana::Resources::Section]
         #
         # @return [Boolean]
-        # @sg-ignore String, nil safe-nav chain isn't inferred as returning Boolean
         def evaluate(section)
           tasks = client.tasks.get_tasks(section: section.gid,
                                          per_page: 100,
                                          options: { fields: ['resource_subtype'] })
-          T.unsafe(tasks).last&.resource_subtype == 'milestone'
+          tasks.last&.resource_subtype == 'milestone'
         end
       end
 

data/lib/checkoff/internal/selector_classes/task/function_evaluator.rb

@@ -8,7 +8,7 @@ module Checkoff
     module Task
       # Base class to evaluate a task selector function given fully evaluated arguments
       class FunctionEvaluator < ::Checkoff::SelectorClasses::FunctionEvaluator
-        # @param selector [Array(Symbol, Array), String]
+        # @param selector [Array<Symbol, Array>, Symbol]
         # @param tasks [Checkoff::Tasks]
         # @param timelines [Checkoff::Timelines]
         # @param custom_fields [Checkoff::CustomFields]
@@ -36,7 +36,7 @@ module Checkoff
 
         private
 
-        # @return [Array(Symbol, Array)]
+        # @return [Array<Symbol, Array>, Symbol]
         attr_reader :selector
       end
     end

data/lib/checkoff/internal/selector_classes/task.rb

@@ -24,12 +24,8 @@ module Checkoff
           # @type [Hash{'unwrapped' => Hash}]
           task_data = tasks.task_to_h(task)
           # @type [Hash{'membership_by_project_name' => Hash}]
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           unwrapped = task_data.fetch('unwrapped')
           # @type [Array]
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           projects = unwrapped.fetch('membership_by_project_name').keys
           !(projects - [:my_tasks]).empty?
         end
@@ -53,12 +49,8 @@ module Checkoff
           # @type [Hash{'unwrapped' => Hash}]
           task_data = tasks.task_to_h(task)
           # @type [Hash{'membership_by_section_name' => Hash}]
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           unwrapped = task_data.fetch('unwrapped')
           # @type [Array]
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           section_names = unwrapped.fetch('membership_by_section_name').keys
           section_names.any? do |section_name|
             String(section_name).start_with?(section_name_prefix)
@@ -84,12 +76,8 @@ module Checkoff
           # @type [Hash{'unwrapped' => Hash}]
           task_data = tasks.task_to_h(task)
           # @type [Hash{'membership_by_section_name' => Hash}]
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           unwrapped = task_data.fetch('unwrapped')
           # @type [Array]
-          # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-          # https://github.com/castwide/solargraph/pull/1228
           section_names = unwrapped.fetch('membership_by_section_name').keys
           section_names.any?(section_name)
         end
@@ -109,12 +97,8 @@ module Checkoff
         # @param task [Asana::Resources::Task]
         # @param project_name [String]
         # @return [Boolean]
-        # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-        # https://github.com/castwide/solargraph/pull/1228
         def evaluate(task, project_name)
           project_names = task.memberships.map do |membership|
-            # @sg-ignore Hash#fetch generic<X> leak on rbs >= 4.1.0, fix in progress upstream
-            # https://github.com/castwide/solargraph/pull/1228
             membership.fetch('project').fetch('name')
           end
           project_names.include?(project_name)
@@ -214,10 +198,8 @@ module Checkoff
 
         # @param task [Asana::Resources::Task]
         # @return [Boolean]
-        # @sg-ignore Checkoff::SelectorClasses::Task::UnassignedPFunctionEvaluator#evaluate
-        #   return type could not be inferred
         def evaluate(task)
-          T.cast(task.assignee.nil? == true, T::Boolean)
+          task.assignee.nil?
         end
       end
 
@@ -231,10 +213,8 @@ module Checkoff
 
         # @param task [Asana::Resources::Task]
         # @return [Boolean]
-        # @sg-ignore Checkoff::SelectorClasses::Task::DueDateSetPFunctionEvaluator#evaluate
-        #   return type could not be inferred
         def evaluate(task)
-          T.cast(!(task.due_at.nil? && task.due_on.nil?), T::Boolean)
+          !(task.due_at.nil? && task.due_on.nil?)
         end
       end
 
@@ -259,8 +239,6 @@ module Checkoff
 
           # @type [Array<Asana::Resources::Story>]
           stories = task.stories(per_page: 100).to_a.reject do |story|
-            # @sg-ignore story's inferred block param type regressed on rbs >= 4.1.0, fix in progress upstream
-            # https://github.com/castwide/solargraph/pull/1228
             excluding_resource_subtypes.include? story.resource_subtype
           end
           return true if stories.empty? # no stories == infinitely old!
@@ -386,8 +364,6 @@ module Checkoff
         # @param task [Asana::Resources::Task]
         #
         # @return [Boolean]
-        # @sg-ignore Checkoff::SelectorClasses::Task::MilestonePFunctionEvaluator#evaluate
-        #   return type could not be inferred
         def evaluate(task)
           resource_subtype = task.resource_subtype
           raise 'Please add resource_subtype to extra_fields' if resource_subtype.nil?

data/lib/checkoff/internal/selector_evaluator.rb

@@ -1,10 +1,10 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 module Checkoff
   # Base class to evaluate Asana resource selectors against an Asana resource
   class SelectorEvaluator
-    # @param selector [Symbol, Array<Symbol, Integer, Array>]
+    # @param selector [Symbol, Array<Symbol, String, Integer, Array>]
     # @return [Boolean, Object, Array, nil]
     def evaluate(selector)
       return true if selector.empty?
@@ -30,7 +30,6 @@ module Checkoff
     end
 
     # @return [Array<Class<Checkoff::SelectorClasses::FunctionEvaluator>>]
-    # @sg-ignore abstract method always raises; declared type documents the override contract, not this body
     def function_evaluators
       raise 'Implement me!'
     end
@@ -41,8 +40,10 @@ module Checkoff
     def evaluate_args(selector, evaluator)
       return [] unless selector.is_a?(Array)
 
-      # @sg-ignore Array#[] with an open-ended range is inferred as nilable even though it never is here
-      selector[1..].map.with_index do |item, index|
+      rest = selector[1..]
+      return [] unless rest
+
+      rest.map.with_index do |item, index|
         if evaluator.evaluate_arg?(index)
           evaluate(item)
         else

data/lib/checkoff/internal/task_hashes.rb

@@ -9,7 +9,7 @@ module Checkoff
       # @param task [Asana::Resources::Task]
       # @return [Hash]
       def task_to_h(task)
-        # @type [Hash]
+        # @type [Hash{String => Object}]
         task_hash = task.to_h
         task_hash['unwrapped'] = {}
         unwrap_custom_fields(task_hash)
@@ -18,7 +18,7 @@ module Checkoff
         task_hash
       end
 
-      # @param task_data [Hash]
+      # @param task_data [Hash{String => Object}]
       # @param client [Asana::Client]
       #
       # @return [Asana::Resources::Task]
@@ -34,7 +34,7 @@ module Checkoff
       # @param task_hash [Hash]
       # @return [void]
       def unwrap_custom_fields(task_hash)
-        # @type [Array<Hash>,nil]
+        # @type [Array<Hash{String => Object}>,nil]
         custom_fields = task_hash.fetch('custom_fields', nil)
 
         return if custom_fields.nil?
@@ -53,8 +53,7 @@ module Checkoff
         return unless task_hash.key? 'assignee_section'
 
         assignee_section = task_hash.fetch('assignee_section')
-        # @type [Hash{String => String}]
-        assignee = T.cast(task_hash.fetch('assignee'), T::Hash[String, String])
+        assignee = assignee_hash(task_hash)
         memberships << {
           'section' => assignee_section.dup,
           'project' => {
@@ -64,24 +63,33 @@ module Checkoff
         }
       end
 
-      # @param task_hash [Hash]
+      # @param task_hash [Hash{String => String, Hash, Array}]
+      # @return [Hash{String => Object}]
+      def assignee_hash(task_hash)
+        assignee = task_hash.fetch('assignee')
+        raise "Expected assignee to be a Hash, got #{assignee.class}" unless assignee.is_a?(Hash)
+
+        assignee
+      end
+
+      # @param task_hash [Hash{String => Object}]
       # @param resource [String]
       # @param memberships [Array<Hash>]
       # @param key [String]
       #
       # @return [void]
       def unwrap_memberships(task_hash, memberships, resource, key)
-        # @type [Hash]
+        # @type [Hash{String => Object}]
         unwrapped = task_hash.fetch('unwrapped')
         unwrapped["membership_by_#{resource}_#{key}"] = memberships.group_by do |membership|
           membership[resource][key]
         end.transform_values(&:first)
       end
 
-      # @param task_hash [Hash]
+      # @param task_hash [Hash{String => Object}]
       # @return [void]
       def unwrap_all_memberships(task_hash)
-        # @type [Array<Hash>]
+        # @type [Array<Hash{String => Object}>]
         memberships = task_hash.fetch('memberships', []).dup
         add_user_task_list(task_hash, memberships)
         unwrap_memberships(task_hash, memberships, 'section', 'gid')

data/lib/checkoff/internal/task_timing.rb

@@ -19,16 +19,12 @@ module Checkoff
 
       # @param task [Asana::Resources::Task]
       # @return [Time, nil]
-      # @sg-ignore return type could not be inferred — #to_time called via &. on a Date|Time
-      #   union receiver
       def start_time(task)
         date_or_time_field_by_name(task, :start)&.to_time
       end
 
       # @param task [Asana::Resources::Task]
       # @return [Time, nil]
-      # @sg-ignore return type could not be inferred — #to_time called via &. on a Date|Time
-      #   union receiver
       def due_time(task)
         date_or_time_field_by_name(task, :due)&.to_time
       end

data/lib/checkoff/internal/thread_local.rb

@@ -10,8 +10,6 @@ module Checkoff
       # @param value [Object,Boolean]
       # @yieldreturn [generic<T>]
       # @return [generic<T>]
-      # @sg-ignore return type could not be inferred — Solargraph's generic/yield-return
-      #   inference gap for #with_thread_local_variable
       def with_thread_local_variable(name, value, &block)
         old_value = Thread.current[name]
         Thread.current[name] = value

data/lib/checkoff/monkeypatches/resource_marshalling.rb

@@ -20,19 +20,19 @@ module Asana
     # Public: The base resource class which provides some sugar over common
     # resource functionality.
     class Resource
-      # @return [Hash]
+      # @return [Hash{String => Object}]
       def marshal_dump
         { 'data' => @_data,
           'client' => @_client }
       end
 
-      # @param data [Hash]
+      # @param data [Hash{String => Object}]
       #
       # @return [void]
       def marshal_load(data)
         # @type [Asana::Client]
         @_client = data.fetch('client')
-        # @type [Hash]
+        # @type [Hash{String => Object}]
         @_data = data.fetch('data')
         @_data.each do |k, v|
           if respond_to?(k)

data/lib/checkoff/my_tasks.rb

@@ -67,10 +67,7 @@ module Checkoff
       sections.each_entry { |section| by_section[section_key(section.name)] = [] }
       tasks.each do |task|
         assignee_section = task.assignee_section
-        # @sg-ignore assignee_section can be nil (task has no My Tasks section) but is
-        #   dereferenced without a nil guard — looks like a real gap, flagging for the
-        #   follow-up code PR
-        current_section = section_key(assignee_section.name)
+        current_section = section_key(assignee_section&.name)
         by_section[current_section] ||= []
         by_section[current_section] << task
       end

data/lib/checkoff/portfolios.rb

@@ -47,7 +47,6 @@ module Checkoff
     # @param portfolio_name [String]
     #
     # @return [Asana::Resources::Portfolio]
-    # @sg-ignore nil check above is not flow-sensitive
     def portfolio_or_raise(workspace_name, portfolio_name)
       portfolio_obj = portfolio(workspace_name, portfolio_name)
       raise "Could not find portfolio #{portfolio_name} under workspace #{workspace_name}." if portfolio_obj.nil?

data/lib/checkoff/project_selectors.rb

@@ -42,7 +42,7 @@ module Checkoff
     end
 
     # @param [Asana::Resources::Project] project
-    # @param [Array(Symbol, Array)] project_selector Filter based on
+    # @param [Array<Symbol, String, Array>] project_selector Filter based on
     #        project details.  Examples: [:tag, 'foo'] [:not, [:tag, 'foo']] [:tag, 'foo']
     # @return [Boolean]
     def filter_via_project_selector(project, project_selector)

data/lib/checkoff/projects.rb

@@ -22,12 +22,19 @@ require 'asana'
 module Checkoff
   # Work with projects in Asana
   class Projects
+    # @return [Integer]
     MINUTE = 60
+    # @return [Integer]
     HOUR = MINUTE * 60
+    # @return [Integer]
     DAY = 24 * HOUR
+    # @return [Integer]
     REALLY_LONG_CACHE_TIME = MINUTE * 30
+    # @return [Integer]
     LONG_CACHE_TIME = MINUTE * 15
+    # @return [Integer]
     MEDIUM_CACHE_TIME = MINUTE * 5
+    # @return [Integer]
     SHORT_CACHE_TIME = MINUTE
 
     # @!parse
@@ -65,6 +72,12 @@ module Checkoff
 
     # Default options used in Asana API to pull tasks
     #
+    # Keys are :per_page (Integer), :options (a Hash whose :fields is an
+    # Array<String>) and, when only_uncompleted is set, :completed_since
+    # (String). The value type is genuinely per-key, which a single YARD
+    # Hash value type cannot express.
+    # Callers who want the field list should call #task_fields directly.
+    #
     # @param extra_fields [Array<String>]
     # @param [Boolean] only_uncompleted
     #
@@ -109,9 +122,7 @@ module Checkoff
         # @type [Enumerable<Asana::Resources::Project>]
         ps = projects_by_workspace_name(workspace_name, extra_fields:)
         # @type [Asana::Resources::Project,nil]
-        # @sg-ignore Variable type could not be inferred / Unresolved call to _1 — Solargraph
-        #   doesn't fully support numbered block parameters
-        project = ps.find { _1.name == project_name }
+        project = ps.find { |p| p.name == project_name }
         project_by_gid(project.gid, extra_fields:) unless project.nil?
       end
     end
@@ -122,7 +133,6 @@ module Checkoff
     # @param [Array<String>] extra_fields
     #
     # @return [Asana::Resources::Project]
-    # @sg-ignore nil check above is not flow-sensitive
     def project_or_raise(workspace_name, project_name, extra_fields: [])
       p = project(workspace_name, project_name, extra_fields:)
       raise "Could not find project #{project_name.inspect} under workspace #{workspace_name}." if p.nil?
@@ -199,9 +209,10 @@ module Checkoff
     cache_method :projects_by_workspace_name, REALLY_LONG_CACHE_TIME
 
     # @param project_obj [Asana::Resources::Project]
-    # @param project [String, Symbol] - :not_specified, :my_tasks or a project name
+    # @param project [String, :not_specified, :my_tasks, nil] - a String is a
+    #   project name
     #
-    # @return [Hash]
+    # @return (see Checkoff::Internal::ProjectHashes#project_to_h)
     def project_to_h(project_obj, project: :not_specified)
       project_hashes.project_to_h(project_obj, project:)
     end
@@ -214,14 +225,14 @@ module Checkoff
     # date is today or in the past.
     #
     # @param project [Asana::Resources::Project]
-    # @param period [Symbol, Array(Symbol, Integer)] See Checkoff::Timing#in_period? - :now_or_before,:this_week
+    # @param period [Symbol, Array<Symbol, Integer>] See Checkoff::Timing#in_period? - :now_or_before,:this_week
     def project_ready?(project, period: :now_or_before)
       in_period?(project, :ready, period)
     end
 
     # @param project [Asana::Resources::Project]
     # @param field_name [Symbol,Array]
-    # @param period [Symbol, Array(Symbol,Integer)] See Checkoff::Timing#in_period? - :now_or_before,:this_week
+    # @param period [Symbol, Array<Symbol, Integer>] See Checkoff::Timing#in_period? - :now_or_before,:this_week
     def in_period?(project, field_name, period)
       # @type [Date,Time,nil]
       project_date = project_timing.date_or_time_field_by_name(project, field_name)

data/lib/checkoff/resources.rb

@@ -62,9 +62,7 @@ module Checkoff
       %w[task section project].each do |resource_type_to_try|
         next unless [resource_type_to_try, nil].include?(resource_type)
 
-        # @type [Asana::Resources::Resource, nil]
-        resource = T.cast(method(:"fetch_#{resource_type_to_try}_gid").call(gid),
-                          T.nilable(Asana::Resources::Resource))
+        resource = fetch_gid_by_type(resource_type_to_try, gid)
         return [resource, resource_type_to_try] if resource
       end
       [nil, nil]
@@ -72,6 +70,19 @@ module Checkoff
 
     private
 
+    # @param resource_type [String]
+    # @param gid [String]
+    #
+    # @return [Asana::Resources::Resource, nil]
+    def fetch_gid_by_type(resource_type, gid)
+      case resource_type
+      when 'task' then fetch_task_gid(gid)
+      when 'section' then fetch_section_gid(gid)
+      when 'project' then fetch_project_gid(gid)
+      else raise "Unexpected resource_type: #{resource_type}"
+      end
+    end
+
     # @param gid [String]
     #
     # @return [Asana::Resources::Task, nil]

data/lib/checkoff/sections.rb

@@ -14,10 +14,15 @@ module Checkoff
     # @!parse
     #   extend CacheMethod::ClassMethods
 
+    # @return [Integer]
     MINUTE = 60
+    # @return [Integer]
     HOUR = MINUTE * 60
+    # @return [Integer]
     REALLY_LONG_CACHE_TIME = MINUTE * 30
+    # @return [Integer]
     LONG_CACHE_TIME = MINUTE * 15
+    # @return [Integer]
     SHORT_CACHE_TIME = MINUTE * 5
 
     extend Forwardable
@@ -142,10 +147,9 @@ module Checkoff
     # @param section_name [String, nil]
     #
     # @return [Array<String>]
-    # @sg-ignore Task#name is nilable; task names are assumed present here
     def section_task_names(workspace_name, project_name, section_name)
       task_array = tasks(workspace_name, project_name, section_name)
-      T.cast(task_array.map(&:name), Array)
+      task_array.filter_map(&:name)
     end
     cache_method :section_task_names, SHORT_CACHE_TIME
 
@@ -155,7 +159,6 @@ module Checkoff
     # @param extra_section_fields [Array<String>]
     #
     # @return [Asana::Resources::Section]
-    # @sg-ignore section() is nil-checked below
     def section_or_raise(workspace_name, project_name, section_name, extra_section_fields: [])
       s = section(workspace_name, project_name, section_name,
                   extra_section_fields:)
@@ -280,14 +283,12 @@ module Checkoff
     # @return [void]
     def file_task_by_section(by_section, task, project_gid)
       membership = task.memberships.find do |m|
-        membership_hash = T.unsafe(m)
-        T.cast(membership_hash['project'], T::Hash[String, T.untyped])['gid'] == project_gid
+        m.fetch('project')['gid'] == project_gid
       end
       raise "Could not find task in project_gid #{project_gid}: #{task}" if membership.nil?
 
-      membership_data = T.unsafe(membership)
-      section = T.cast(membership_data['section'], T::Hash[String, T.untyped])
-      section_name = T.cast(section['name'], String)
+      section = membership.fetch('section')
+      section_name = section.fetch('name')
 
       # @type [String, nil]
       current_section = section_key(section_name)
@@ -298,7 +299,6 @@ module Checkoff
     # @param workspace_name [String, Symbol]
     # @param project_name [String, Symbol]
     # @return [Asana::Resources::Project]
-    # @sg-ignore projects.project may be nil but is raised below
     def project_or_raise(workspace_name, project_name)
       raise ArgumentError, 'Provide nil project_name' if T.unsafe(project_name).nil?
 

data/lib/checkoff/subtasks.rb

@@ -72,7 +72,7 @@ module Checkoff
     def subtasks_by_gid(task_gid,
                         extra_fields: [],
                         only_uncompleted: true)
-      # @type [Hash]
+      # @type [Hash{Symbol => undefined}]
       all_options = projects.task_options(extra_fields: extra_fields + %w[is_rendered_as_separator],
                                           only_uncompleted:)
       options = all_options.fetch(:options, {})
@@ -90,7 +90,6 @@ module Checkoff
     #
     # @param subtask [Asana::Resources::Task]
     # @return [Boolean, nil]
-    # @sg-ignore Checkoff::Subtasks#subtask_section? return type could not be inferred
     def subtask_section?(subtask)
       subtask.is_rendered_as_separator
     end

data/lib/checkoff/tags.rb

@@ -79,7 +79,6 @@ module Checkoff
     # @param tag_name [String]
     #
     # @return [Asana::Resources::Tag]
-    # @sg-ignore nil check above is not flow-sensitive
     def tag_or_raise(workspace_name, tag_name)
       t = tag(workspace_name, tag_name)
 
@@ -113,9 +112,9 @@ module Checkoff
     #
     # @return [Hash{Symbol => Object}]
     def build_params(options)
-      { limit: options[:per_page], completed_since: options[:completed_since] }.reject do |_, v|
-        # @sg-ignore Unresolved call to nil? on Object — Solargraph doesn't treat a Hash's
-        #   declared `Object` value type as full Object here
+      # @type [Hash{Symbol => Object}]
+      params = { limit: options[:per_page], completed_since: options[:completed_since] }
+      params.reject do |_, v|
         v.nil? || Array(v).empty?
       end
     end