checkoff 0.246.0 → 0.248.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e525b82b6ae1ea09510316f53b1087da97f218de3ffc16c71571ac30306720b7
-  data.tar.gz: '034090171c0a8c076a33aa7a415ac60a4852e1bb7480df8e779c59826dd2275a'
+  metadata.gz: cf2ef1bb397eb6f71c13c2b0b80a07bcce2768bf949f7306552f42196ff2ee2f
+  data.tar.gz: e13e1ddd086c25666513f065d6d1d0efcb3498117207bd2db2be0832a3369a97
 SHA512:
-  metadata.gz: 4d4bc576a9785e658c818efe8bd6b11925fa8e530c72054bf432ab509b174eb135cbabc9a52f5d6f5c27e933749814e643d99ba73863a2967ee4f47f7e8e02df
-  data.tar.gz: 4285735d4121093dc6363eae28101d9330e12beac46c592ec723f2ebecff77acad0f7c1dd139121499ed313adefd1685b212df6dc8b147a42c49f11be595fd22
+  metadata.gz: 5b1e83d10cc864255f05003342919ff7c1c4171821232a6d702672c395bda000ef923e4da9084a5d86398e0107bdffa813e40bb6a78fd7a656f65f342c32bc09
+  data.tar.gz: f79ec8061cd3b0a3180f4f94370c468e57c8731e873486a912f280ed2a860751047433a7660068ac57283f7f8e608925b8e615a7224c3f8b41cea0bb58e0702c

data/lib/checkoff/internal/selector_classes/task.rb

@@ -190,9 +190,12 @@ module Checkoff
 
         # @param task [Asana::Resources::Task]
         # @return [Boolean]
+        # CI quality (pipeline 1902): "return type could not be inferred" on modified lines
+        # after 7eeb5b1 removed @sg-ignore. Local overcommit may report "Unneeded @sg-ignore";
+        # `== true` alone did not satisfy the CI overcommit Solargraph hook.
         # @sg-ignore
         def evaluate(task)
-          task.assignee.nil?
+          task.assignee.nil? == true
         end
       end
 
@@ -206,9 +209,10 @@ module Checkoff
 
         # @param task [Asana::Resources::Task]
         # @return [Boolean]
+        # Same CI/local Solargraph drift as UnassignedPFunctionEvaluator#evaluate (pipeline 1902).
         # @sg-ignore
         def evaluate(task)
-          !task.due_at.nil? || !task.due_on.nil?
+          !(task.due_at.nil? && task.due_on.nil?)
         end
       end
 

data/lib/checkoff/tasks.rb

@@ -292,6 +292,7 @@ module Checkoff
     # @param portfolio_name [String]
     # @param workspace_name [String]
     # @return [Boolean]
+    # CI quality (pipeline 1902): "in_portfolio_named? return type could not be inferred".
     # @sg-ignore
     def in_portfolio_named?(task,
                             portfolio_name,
@@ -300,10 +301,8 @@ module Checkoff
       task.memberships.any? do |membership|
         m = T.cast(membership, T::Hash[String, T.untyped])
         project_gid = T.cast(m.fetch('project'), T::Hash[String, T.untyped]).fetch('gid')
-        portfolio_projects.any? do |portfolio_project|
-          portfolio_project.gid == project_gid
-        end
-      end
+        portfolio_projects.any? { |portfolio_project| portfolio_project.gid == project_gid }
+      end == true
     end
 
     # True if the task is in a project which is in the given portfolio

data/lib/checkoff/version.rb

@@ -4,5 +4,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.246.0'
+  VERSION = '0.248.0'
 end

data/rbi/checkoff.rbi

@@ -75,7 +75,7 @@ module Overcommit
 end
 
 module Checkoff
-  VERSION = '0.246.0'
+  VERSION = '0.248.0'
 
   class Attachments
     include Logging
@@ -2442,7 +2442,7 @@ end
 # typed: ignore
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
-  VERSION = T.let('0.246.0', T.untyped)
+  VERSION = T.let('0.248.0', T.untyped)
 
   # Move tasks from one place to another
   class MvSubcommand
@@ -3027,6 +3027,7 @@ module Checkoff
     # sord warn - Asana::Resources::Task wasn't able to be resolved to a constant in this project
     # True if the task is in a project which is in the given portfolio
     # 
+    # CI quality (pipeline 1902): "in_portfolio_named? return type could not be inferred".
     # @sg-ignore
     # 
     # _@param_ `task`
@@ -5961,6 +5962,9 @@ module Checkoff
         def matches?; end
 
         # sord warn - Asana::Resources::Task wasn't able to be resolved to a constant in this project
+        # CI quality (pipeline 1902): "return type could not be inferred" on modified lines
+        # after 7eeb5b1 removed @sg-ignore. Local overcommit may report "Unneeded @sg-ignore";
+        # `== true` alone did not satisfy the CI overcommit Solargraph hook.
         # @sg-ignore
         # 
         # _@param_ `task`
@@ -5976,6 +5980,7 @@ module Checkoff
         def matches?; end
 
         # sord warn - Asana::Resources::Task wasn't able to be resolved to a constant in this project
+        # Same CI/local Solargraph drift as UnassignedPFunctionEvaluator#evaluate (pipeline 1902).
         # @sg-ignore
         # 
         # _@param_ `task`
@@ -6755,6 +6760,23 @@ end - [Checkoff::SelectorClasses::Section::FunctionEvaluator]).freeze, T.untyped
     sig { returns(Asana::Client) }
     attr_reader :client
   end
+
+  # Remove TIME_BY_PERIOD redeclarations Sord emits on BaseAsana test subclasses.
+  module PruneRbiTestConstants
+    SUBCLASSES = T.let(%w[TestTasks TestProjects TestSections TestWorkspaces].freeze, T.untyped)
+
+    # _@param_ `klass`
+    sig { params(klass: String).returns(Regexp) }
+    def self.pattern_for(klass); end
+
+    # _@param_ `path`
+    sig { params(path: String).void }
+    def self.call(path); end
+
+    # _@param_ `content`
+    sig { params(content: String).returns(String) }
+    def self.prune_subclasses(content); end
+  end
 end
 
 # include this to add ability to log at different levels
@@ -6971,214 +6993,6 @@ end
 # Test the Checkoff::Tasks class
 class TestTasks < BaseAsana
   extend Forwardable
-  TIME_BY_PERIOD = T.let({
-  two_am: '02:00:20',
-  morning_during_breakfast: '07:30:20',
-  morning: '07:33:20',
-  eight_thirty_am: '8:30:00',
-  ten_am: '10:00:20',
-  mid_morning: '10:33:20',
-  eleven_thirty_am: '11:30:00',
-  afternoon: '14:33:20',
-  three_forty_five_pm: '15:45:20',
-  four_fifteen_pm: '16:15:20',
-  four_forty_five_pm: '16:45:20',
-  five_forty_five_pm: '17:45:20',
-  six_fifteen_pm: '18:15:00',
-  six_forty_five_pm: '18:45:00',
-  night: '19:00:20',
-  evening: '19:01:20',
-  late_evening: '21:33:20',
-  late_late_evening: '22:33:20',
-}.freeze, T.untyped)
-
-  sig { void }
-  def expect_now_pulled; end
-
-  sig { params(less_than_now: T.untyped).void }
-  def expect_due_on_parsed(less_than_now:); end
-
-  sig { params(less_than_now: T.untyped).void }
-  def expect_start_on_parsed(less_than_now:); end
-
-  sig { params(less_than_now: T.untyped).void }
-  def expect_start_at_parsed(less_than_now:); end
-
-  sig { void }
-  def mock_task_ready_false_due_in_future_on_date; end
-
-  sig { void }
-  def test_task_ready_false_due_in_future_on_date; end
-
-  sig { returns(T.untyped) }
-  def mock_task_ready_true_start_in_past; end
-
-  sig { void }
-  def test_task_ready_true_start_in_past; end
-
-  sig { void }
-  def mock_task_ready_true_start_in_past_time; end
-
-  sig { void }
-  def test_task_ready_true_start_in_past_time; end
-
-  sig { params(less_than_now: T.untyped).void }
-  def expect_due_at_parsed(less_than_now:); end
-
-  sig { void }
-  def mock_task_ready_false_due_in_future_at_time; end
-
-  sig { void }
-  def test_task_ready_false_due_in_future_at_time; end
-
-  sig { params(task: T.untyped, dependency_gids: T.untyped).void }
-  def expect_dependency_gids_pulled(task, dependency_gids); end
-
-  sig { void }
-  def test_task_ready_true_no_due_anything; end
-
-  sig { void }
-  def expect_asana_tasks_client_pulled; end
-
-  sig { void }
-  def default_fields; end
-
-  sig { params(extra_fields: T.untyped).void }
-  def fields_including(extra_fields); end
-
-  sig { params(dependency_gid: T.untyped, dependency_full_task: T.untyped, completed: T.untyped).void }
-  def expect_dependency_completion_pulled(dependency_gid, dependency_full_task, completed); end
-
-  sig { void }
-  def mock_task_ready_false_dependency; end
-
-  sig { returns(T.untyped) }
-  def test_task_ready_false_dependency; end
-
-  sig { void }
-  def test_task_ready_false_dependency_cached; end
-
-  sig do
-    params(
-      start_on: T.untyped,
-      start_at: T.untyped,
-      due_on: T.untyped,
-      due_at: T.untyped
-    ).void
-  end
-  def allow_task_due(start_on: nil, start_at: nil, due_on: nil, due_at: nil); end
-
-  sig { params(task: T.untyped, start_at: T.untyped).void }
-  def allow_start_at_pulled(task, start_at); end
-
-  sig { params(task: T.untyped, start_on: T.untyped).returns(T.untyped) }
-  def allow_start_on_pulled(task, start_on); end
-
-  sig { params(task: T.untyped, due_at: T.untyped).void }
-  def allow_due_at_pulled(task, due_at); end
-
-  sig { params(task: T.untyped, due_on: T.untyped).returns(T.untyped) }
-  def allow_due_on_pulled(task, due_on); end
-
-  sig { returns(T.untyped) }
-  def test_url_of_task; end
-
-  sig { returns(T.untyped) }
-  def expect_task_created; end
-
-  sig { void }
-  def mock_add_task; end
-
-  sig { void }
-  def test_add_task; end
-
-  sig { returns(T.untyped) }
-  def expect_tasks_from_project_pulled; end
-
-  sig { void }
-  def expect_project_pulled; end
-
-  sig { params(extra_fields: T.untyped).returns(T.untyped) }
-  def expect_task_by_gid_pulled(extra_fields: []); end
-
-  sig { returns(T.untyped) }
-  def expect_tasks_from_section_pulled; end
-
-  sig { returns(T.untyped) }
-  def projects; end
-
-  sig { returns(T.untyped) }
-  def expect_task_options_pulled; end
-
-  sig { returns(T.untyped) }
-  def mock_task_with_section; end
-
-  sig { void }
-  def test_task_with_section; end
-
-  sig { returns(T.untyped) }
-  def mock_task; end
-
-  sig { void }
-  def test_task; end
-
-  sig { void }
-  def test_in_portfolio_more_than_once; end
-
-  sig { void }
-  def test_in_portfolio_more_than_once_true; end
-
-  sig { void }
-  def test_gid_for_task; end
-
-  sig { void }
-  def test_gid_for_task_not_found; end
-
-  sig { returns(T.untyped) }
-  def test_task_to_h_delegates; end
-
-  sig { void }
-  def expect_default_workspace_name_pulled; end
-
-  sig { void }
-  def mock_in_portfolio_named_false_no_projects_no_memberships; end
-
-  sig { void }
-  def test_in_portfolio_named_false_no_projects_no_memberships; end
-
-  sig { void }
-  def mock_in_portfolio_named_false_no_projects_but_memberships; end
-
-  sig { void }
-  def test_in_portfolio_named_false_no_projects_but_memberships; end
-
-  sig { void }
-  def mock_in_portfolio_named_false_projects_wrong_memberships; end
-
-  sig { void }
-  def test_in_portfolio_named_false_projects_wrong_memberships; end
-
-  sig { void }
-  def test_date_or_time_field_by_name; end
-
-  sig { void }
-  def test_h_to_task; end
-
-  sig { void }
-  def test_all_dependent_tasks_empty; end
-
-  sig { void }
-  def test_all_dependent_tasks_one; end
-
-  sig { void }
-  def test_as_cache_key; end
-
-  sig { void }
-  def class_under_test; end
-end
-
-# Test the Checkoff::CLI class with mv subcommand
-class TestCLIMv < Minitest::Test
   sig { void }
   def expect_workspaces_created; end
 
@@ -7466,99 +7280,6 @@ end
 # Test the Checkoff::Projects class
 class TestProjects < BaseAsana
   extend Forwardable
-  TIME_BY_PERIOD = T.let({
-  two_am: '02:00:20',
-  morning_during_breakfast: '07:30:20',
-  morning: '07:33:20',
-  eight_thirty_am: '8:30:00',
-  ten_am: '10:00:20',
-  mid_morning: '10:33:20',
-  eleven_thirty_am: '11:30:00',
-  afternoon: '14:33:20',
-  three_forty_five_pm: '15:45:20',
-  four_fifteen_pm: '16:15:20',
-  four_forty_five_pm: '16:45:20',
-  five_forty_five_pm: '17:45:20',
-  six_fifteen_pm: '18:15:00',
-  six_forty_five_pm: '18:45:00',
-  night: '19:00:20',
-  evening: '19:01:20',
-  late_evening: '21:33:20',
-  late_late_evening: '22:33:20',
-}.freeze, T.untyped)
-
-  sig { void }
-  def setup_config; end
-
-  sig { void }
-  def setup_projects_pulled; end
-
-  sig { void }
-  def sample_projects; end
-
-  sig { params(workspace_gid: T.untyped).returns(T.untyped) }
-  def setup_projects_queried(workspace_gid: my_workspace_gid); end
-
-  sig { params(options: T.untyped).void }
-  def expect_tasks_found(options:); end
-
-  sig { params(options: T.untyped).void }
-  def mock_tasks_from_project(options:); end
-
-  sig { void }
-  def test_tasks_from_project_not_only_uncompleted; end
-
-  sig { void }
-  def test_tasks_from_project; end
-
-  sig { void }
-  def test_active_tasks; end
-
-  sig { void }
-  def setup_workspace_pulled; end
-
-  sig { void }
-  def setup_user_task_list_pulled; end
-
-  sig { void }
-  def mock_project_or_raise_unknown; end
-
-  sig { void }
-  def test_project_or_raise_unknown; end
-
-  sig { returns(T.untyped) }
-  def test_project_by_gid; end
-
-  sig { void }
-  def test_project_or_raise_my_tasks; end
-
-  sig { returns(T.untyped) }
-  def mock_project_my_tasks; end
-
-  sig { void }
-  def test_project_my_tasks; end
-
-  sig { returns(T.untyped) }
-  def test_project_to_h; end
-
-  sig { returns(T.untyped) }
-  def mock_test_in_period; end
-
-  sig { void }
-  def test_in_period; end
-
-  sig { void }
-  def mock_project_ready; end
-
-  sig { void }
-  def test_project_ready; end
-
-  sig { void }
-  def class_under_test; end
-end
-
-# Test the Checkoff::Sections class
-class TestSections < BaseAsana
   extend Forwardable
   TIME_BY_PERIOD = T.let({
   two_am: '02:00:20',
@@ -7963,53 +7684,6 @@ end
 # Test the Checkoff::Workspaces class
 class TestWorkspaces < BaseAsana
   extend Forwardable
-  TIME_BY_PERIOD = T.let({
-  two_am: '02:00:20',
-  morning_during_breakfast: '07:30:20',
-  morning: '07:33:20',
-  eight_thirty_am: '8:30:00',
-  ten_am: '10:00:20',
-  mid_morning: '10:33:20',
-  eleven_thirty_am: '11:30:00',
-  afternoon: '14:33:20',
-  three_forty_five_pm: '15:45:20',
-  four_fifteen_pm: '16:15:20',
-  four_forty_five_pm: '16:45:20',
-  five_forty_five_pm: '17:45:20',
-  six_fifteen_pm: '18:15:00',
-  six_forty_five_pm: '18:45:00',
-  night: '19:00:20',
-  evening: '19:01:20',
-  late_evening: '21:33:20',
-  late_late_evening: '22:33:20',
-}.freeze, T.untyped)
-
-  sig { void }
-  def mock_workspace_or_raise_nil; end
-
-  sig { void }
-  def test_workspace_or_raise_nil; end
-
-  sig { void }
-  def mock_workspace_or_raise; end
-
-  sig { void }
-  def test_workspace_or_raise; end
-
-  sig { void }
-  def expect_default_workspace_gid_config_fetched; end
-
-  sig { void }
-  def test_default_workspace_gid; end
-
-  sig { void }
-  def test_default_workspace; end
-
-  sig { void }
-  def class_under_test; end
-end
-
-class TestAttachments < ClassTest
   extend Forwardable
 
   sig { params(url: T.untyped).void }
@@ -9278,3 +8952,27 @@ class TestAsanaEventFilter < ClassTest
   sig { void }
   def respond_like; end
 end
+
+class TestPruneCheckoffRbiTestConstants < Minitest::Test
+  SAMPLE = T.let(<<~RBI, T.untyped)
+  module TestDate
+    TIME_BY_PERIOD = T.let({ a: '1' }.freeze, T.untyped)
+  end
+
+  class TestTasks < BaseAsana
+    extend Forwardable
+    TIME_BY_PERIOD = T.let({
+    two_am: '02:00:20',
+    }.freeze, T.untyped)
+
+    sig { void }
+    def foo; end
+  end
+RBI
+
+  sig { returns(T.untyped) }
+  def test_prunes_subclass_constant; end
+
+  sig { returns(T.untyped) }
+  def test_noop_when_nothing_to_prune; end
+end

data/sig/checkoff.rbs

@@ -499,6 +499,7 @@ module Checkoff
     # sord warn - Asana::Resources::Task wasn't able to be resolved to a constant in this project
     # True if the task is in a project which is in the given portfolio
     # 
+    # CI quality (pipeline 1902): "in_portfolio_named? return type could not be inferred".
     # @sg-ignore
     # 
     # _@param_ `task`
@@ -2933,6 +2934,9 @@ module Checkoff
         def matches?: () -> bool
 
         # sord warn - Asana::Resources::Task wasn't able to be resolved to a constant in this project
+        # CI quality (pipeline 1902): "return type could not be inferred" on modified lines
+        # after 7eeb5b1 removed @sg-ignore. Local overcommit may report "Unneeded @sg-ignore";
+        # `== true` alone did not satisfy the CI overcommit Solargraph hook.
         # @sg-ignore
         # 
         # _@param_ `task`
@@ -2946,6 +2950,7 @@ module Checkoff
         def matches?: () -> bool
 
         # sord warn - Asana::Resources::Task wasn't able to be resolved to a constant in this project
+        # Same CI/local Solargraph drift as UnassignedPFunctionEvaluator#evaluate (pipeline 1902).
         # @sg-ignore
         # 
         # _@param_ `task`
@@ -3593,6 +3598,20 @@ module Checkoff
     # sord warn - Asana::Client wasn't able to be resolved to a constant in this project
     attr_reader client: Asana::Client
   end
+
+  # Remove TIME_BY_PERIOD redeclarations Sord emits on BaseAsana test subclasses.
+  module PruneRbiTestConstants
+    SUBCLASSES: untyped
+
+    # _@param_ `klass`
+    def self.pattern_for: (String klass) -> Regexp
+
+    # _@param_ `path`
+    def self.call: (String path) -> void
+
+    # _@param_ `content`
+    def self.prune_subclasses: (String content) -> String
+  end
 end
 
 # include this to add ability to log at different levels
@@ -5156,4 +5175,12 @@ class TestAsanaEventFilter < ClassTest
   def respond_like_instance_of: () -> void
 
   def respond_like: () -> void
+end
+
+class TestPruneCheckoffRbiTestConstants < Minitest::Test
+  SAMPLE: untyped
+
+  def test_prunes_subclass_constant: () -> untyped
+
+  def test_noop_when_nothing_to_prune: () -> untyped
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.246.0
+  version: 0.248.0
 platform: ruby
 authors:
 - Vince Broz