checkoff 0.23.0 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53900365a6e35f146515f3a6043bb12907a67cefa1d0fd86f92b90e700946946
-  data.tar.gz: 57ccc5292ae4f07fe278697c7377d6187859c5a0b1b0be6b301ca945a18579eb
+  metadata.gz: 26474f8f2f94c75d46d16eadd8c773a22d139d56e0d4bcaaae4c698519e8fa89
+  data.tar.gz: fc1b3a92a5736360fec289c1f2c156bc6570ad465fe8ecfdaa63a1b5a10cef5f
 SHA512:
-  metadata.gz: f08fb1c0242675a728cf58151c4e9a990cd8bf961fd75ce7e01b154c39e759b557289651ff16033599809f1df251d4bbed45f02c07cb37aa70e7abfb8e714169
-  data.tar.gz: 248aa5d50f3245dc1af18f4afcef40194d32a57deeb12bec0444965bacbdef523a4a60dda7f473a09deaa8ef1b8a1d499c2d434a02ac83bad41d9c6cd39ebc4b
+  metadata.gz: 80a903a43039264b205cb4ae61f4637360d8a9b4db4cf47062fd4d8e0ed127f420e6da5baebb30c2cbde792261c2265133157f45a19f7cfea8f0577b862327ac
+  data.tar.gz: f6a30feeda861f28f96bb8a7a6b38d68bd3a4042bf21b7521c4382c1b2107aeee8a04c405d5f79fe7fec0acfe27bce778f48ff93c00d27bc552b3f0e531a0359

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.23.0)
+    checkoff (0.24.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/internal/search_url/custom_field_param_converter.rb

@@ -49,6 +49,7 @@ module Checkoff
           'is_not' => CustomFieldVariant::IsNot,
           'less_than' => CustomFieldVariant::LessThan,
           'greater_than' => CustomFieldVariant::GreaterThan,
+          'doesnt_contain_any' => CustomFieldVariant::DoesntContainAny,
         }.freeze
 
         def convert_single_custom_field_params(gid, single_custom_field_params)

data/lib/checkoff/internal/search_url/custom_field_variant.rb

@@ -3,6 +3,7 @@
 module Checkoff
   module Internal
     module SearchUrl
+      # https://developers.asana.com/docs/search-tasks-in-a-workspace
       module CustomFieldVariant
         # base class for handling different custom_field_#{gid}.variant params
         class CustomFieldVariant
@@ -48,28 +49,33 @@ module Checkoff
           end
         end
 
+        # This is used in the UI for select fields
+        #
         # custom_field_#{gid}.variant = 'is_not'
         class IsNot < CustomFieldVariant
           def convert
-            case remaining_params.keys
-            when ["custom_field_#{gid}.selected_options"]
-              convert_single_custom_field_is_not_params_selected_options
-            else
-              raise "Teach me how to handle #{remaining_params}"
-            end
-          end
+            selected_options = fetch_solo_param("custom_field_#{gid}.selected_options").split('~')
 
-          private
+            [{ "custom_fields.#{gid}.is_set" => 'true' },
+             ['not',
+              ['custom_field_gid_value_contains_any_gid',
+               gid,
+               selected_options]]]
+          end
+        end
 
-          def convert_single_custom_field_is_not_params_selected_options
-            selected_options = remaining_params.fetch("custom_field_#{gid}.selected_options")
-            raise "Teach me how to handle #{remaining_params}" unless selected_options.length == 1
+        # This is used in the UI for multi-select fields
+        #
+        # custom_field_#{gid}.variant = 'doesnt_contain_any'
+        class DoesntContainAny < CustomFieldVariant
+          def convert
+            selected_options = fetch_solo_param("custom_field_#{gid}.selected_options").split('~')
 
             [{ "custom_fields.#{gid}.is_set" => 'true' },
              ['not',
               ['custom_field_gid_value_contains_any_gid',
                gid,
-               selected_options.fetch(0).split('~')]]]
+               selected_options]]]
           end
         end
 

data/lib/checkoff/internal/task_selector_evaluator.rb

@@ -105,24 +105,40 @@ module Checkoff
       end
 
       matched_custom_field = custom_fields.find { |data| data.fetch('gid') == custom_field_gid }
-      raise "Could not find custom field with gid #{custom_field_gid}" if matched_custom_field.nil?
+      if matched_custom_field.nil?
+        raise "Could not find custom field with gid #{custom_field_gid} in #{task.gid} with #{custom_fields}"
+      end
 
       matched_custom_field
     end
 
-    def pull_custom_field_values_gids(task, custom_field_gid)
-      matched_custom_field = pull_custom_field_or_raise(task, custom_field_gid)
+    def pull_enum_values(custom_field)
+      resource_subtype = custom_field.fetch('resource_subtype')
+      case resource_subtype
+      when 'enum'
+        [custom_field.fetch('enum_value')]
+      when 'multi_enum'
+        custom_field.fetch('multi_enum_values')
+      else
+        raise "Teach me how to handle resource_subtype #{resource_subtype}"
+      end
+    end
 
-      enum_value = matched_custom_field.fetch('enum_value')
-      actual_custom_field_values_gids = []
-      unless enum_value.nil?
-        if enum_value.fetch('enabled') == false
-          raise "Unexpected enabled value on custom field: #{matched_custom_field}"
-        end
+    def find_gids(custom_field, enum_value)
+      if enum_value.nil?
+        []
+      else
+        raise "Unexpected enabled value on custom field: #{custom_field}" if enum_value.fetch('enabled') == false
 
-        actual_custom_field_values_gids = [enum_value.fetch('gid')]
+        [enum_value.fetch('gid')]
+      end
+    end
+
+    def pull_custom_field_values_gids(task, custom_field_gid)
+      custom_field = pull_custom_field_or_raise(task, custom_field_gid)
+      pull_enum_values(custom_field).flat_map do |enum_value|
+        find_gids(custom_field, enum_value)
       end
-      actual_custom_field_values_gids
     end
   end
 

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.23.0'
+  VERSION = '0.24.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.24.0
 platform: ruby
 authors:
 - Vince Broz