checkoff 0.226.0 → 0.227.0

data/lib/checkoff/sections.rb

@@ -40,16 +40,16 @@ module Checkoff
     # @param workspaces [Checkoff::Workspaces]
     # @param time [Class<Time>]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
-                   client: Checkoff::Clients.new(config: config).client,
-                   projects: Checkoff::Projects.new(config: config,
-                                                    client: client),
-                   workspaces: Checkoff::Workspaces.new(config: config,
-                                                        client: client),
+                   client: Checkoff::Clients.new(config:).client,
+                   projects: Checkoff::Projects.new(config:,
+                                                    client:),
+                   workspaces: Checkoff::Workspaces.new(config:,
+                                                        client:),
                    time: Time)
       @projects = projects
       @workspaces = workspaces
       @my_tasks = Checkoff::MyTasks
-        .new(config: config, projects: projects, client: client)
+        .new(config:, projects:, client:)
       @client = client
       @time = time
     end
@@ -62,7 +62,7 @@ module Checkoff
     # @return [Enumerable<Asana::Resources::Section>]
     def sections_or_raise(workspace_name, project_name, extra_fields: [])
       project = project_or_raise(workspace_name, project_name)
-      sections_by_project_gid(project.gid, extra_fields: extra_fields)
+      sections_by_project_gid(project.gid, extra_fields:)
     end
     cache_method :sections_or_raise, SHORT_CACHE_TIME
 
@@ -73,8 +73,8 @@ module Checkoff
     # @return [Enumerable<Asana::Resources::Section>]
     def sections_by_project_gid(project_gid, extra_fields: [])
       fields = (%w[name] + extra_fields).sort.uniq
-      client.sections.get_sections_for_project(project_gid: project_gid,
-                                               options: { fields: fields })
+      client.sections.get_sections_for_project(project_gid:,
+                                               options: { fields: })
     end
     cache_method :sections_by_project_gid, SHORT_CACHE_TIME
 
@@ -94,9 +94,9 @@ module Checkoff
 
       project = project_or_raise(workspace_name, project_name)
       if project_name == :my_tasks
-        my_tasks.tasks_by_section_for_my_tasks(project, only_uncompleted: only_uncompleted, extra_fields: extra_fields)
+        my_tasks.tasks_by_section_for_my_tasks(project, only_uncompleted:, extra_fields:)
       else
-        tasks_by_section_for_project(project, only_uncompleted: only_uncompleted, extra_fields: extra_fields)
+        tasks_by_section_for_project(project, only_uncompleted:, extra_fields:)
       end
     end
 
@@ -108,8 +108,8 @@ module Checkoff
     def tasks_by_section_gid(section_gid,
                              only_uncompleted: true,
                              extra_fields: [])
-      options = projects.task_options(extra_fields: extra_fields,
-                                      only_uncompleted: only_uncompleted)
+      options = projects.task_options(extra_fields:,
+                                      only_uncompleted:)
       client.tasks.get_tasks(section: section_gid, **options)
     end
 
@@ -126,8 +126,8 @@ module Checkoff
               only_uncompleted: true,
               extra_fields: [])
       section = section_or_raise(workspace_name, project_name, section_name)
-      options = projects.task_options(extra_fields: extra_fields,
-                                      only_uncompleted: only_uncompleted)
+      options = projects.task_options(extra_fields:,
+                                      only_uncompleted:)
       # Note: 30 minute cache time on a raw Enumerable from SDK gives
       # 'Your pagination token has expired' errors.  So we go ahead
       # and eagerly evaluate here so we can enjoy the cache.
@@ -157,7 +157,7 @@ module Checkoff
     # @return [Asana::Resources::Section]
     def section_or_raise(workspace_name, project_name, section_name, extra_section_fields: [])
       s = section(workspace_name, project_name, section_name,
-                  extra_section_fields: extra_section_fields)
+                  extra_section_fields:)
       if s.nil?
         valid_sections = sections_or_raise(workspace_name, project_name,
                                            extra_fields: extra_section_fields).map(&:name)
@@ -199,8 +199,8 @@ module Checkoff
     # @return [Asana::Resources::Section, nil]
     def section_by_gid(gid)
       options = {}
-      Asana::Resources::Section.new(parse(client.get("/sections/#{gid}", options: options)).first,
-                                    client: client)
+      Asana::Resources::Section.new(parse(client.get("/sections/#{gid}", options:)).first,
+                                    client:)
     rescue Asana::Errors::NotFound => e
       debug e
       nil
@@ -254,8 +254,8 @@ module Checkoff
                                      only_uncompleted: true,
                                      extra_fields: [])
       raw_tasks = projects.tasks_from_project(project,
-                                              only_uncompleted: only_uncompleted,
-                                              extra_fields: extra_fields)
+                                              only_uncompleted:,
+                                              extra_fields:)
       active_tasks = projects.active_tasks(raw_tasks)
       by_section(active_tasks, project.gid)
     end
@@ -267,7 +267,7 @@ module Checkoff
     def by_section(tasks, project_gid)
       by_section = {}
       # @sg-ignore
-      sections = client.sections.get_sections_for_project(project_gid: project_gid,
+      sections = client.sections.get_sections_for_project(project_gid:,
                                                           options: { fields: ['name'] })
       sections.each_entry { |section| by_section[section_key(section.name)] = [] }
       tasks.each { |task| file_task_by_section(by_section, task, project_gid) }

data/lib/checkoff/subtasks.rb

@@ -17,12 +17,12 @@ module Checkoff
 
     extend Forwardable
 
-    # @param config [Hash]
+    # @param config [Hash,Checkoff::Internal::EnvFallbackConfigLoader]
     # @param projects [Checkoff::Projects]
     # @param clients [Checkoff::Clients]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
-                   projects: Checkoff::Projects.new(config: config),
-                   clients: Checkoff::Clients.new(config: config))
+                   projects: Checkoff::Projects.new(config:),
+                   clients: Checkoff::Clients.new(config:))
       @projects = projects
       @client = clients.client
     end
@@ -75,11 +75,11 @@ module Checkoff
                         only_uncompleted: true)
       # @type [Hash]
       all_options = projects.task_options(extra_fields: extra_fields + %w[is_rendered_as_separator],
-                                          only_uncompleted: only_uncompleted)
+                                          only_uncompleted:)
       options = all_options.fetch(:options, {})
-      client.tasks.get_subtasks_for_task(task_gid: task_gid,
+      client.tasks.get_subtasks_for_task(task_gid:,
                                          # per_page: 100, # stub doesn't have this arg available
-                                         options: options)
+                                         options:)
     end
     cache_method :subtasks_by_gid, LONG_CACHE_TIME
 

data/lib/checkoff/tags.rb

@@ -30,10 +30,10 @@ module Checkoff
     # @param projects [Checkoff::Projects]
     # @param workspaces [Checkoff::Workspaces]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
-                   clients: Checkoff::Clients.new(config: config),
+                   clients: Checkoff::Clients.new(config:),
                    client: clients.client,
-                   projects: Checkoff::Projects.new(config: config, client: client),
-                   workspaces: Checkoff::Workspaces.new(config: config, client: client))
+                   projects: Checkoff::Projects.new(config:, client:),
+                   workspaces: Checkoff::Workspaces.new(config:, client:))
       @workspaces = T.let(workspaces, Checkoff::Workspaces)
       @projects = T.let(projects, Checkoff::Projects)
       @client = T.let(client, Asana::Client)
@@ -52,7 +52,7 @@ module Checkoff
       tag_gid = tag.gid
 
       tasks_by_tag_gid(workspace_name, tag_gid,
-                       only_uncompleted: only_uncompleted, extra_fields: extra_fields)
+                       only_uncompleted:, extra_fields:)
     end
 
     # @param workspace_name [String]
@@ -62,13 +62,13 @@ module Checkoff
     #
     # @return [Enumerable<Asana::Resources::Task>]
     def tasks_by_tag_gid(workspace_name, tag_gid, only_uncompleted: true, extra_fields: [])
-      options = projects.task_options(extra_fields: extra_fields,
-                                      only_uncompleted: only_uncompleted)
+      options = projects.task_options(extra_fields:,
+                                      only_uncompleted:)
       params = build_params(options)
       Asana::Resources::Collection.new(parse(client.get("/tags/#{tag_gid}/tasks",
-                                                        params: params, options: options[:options])),
+                                                        params:, options: options[:options])),
                                        type: Asana::Resources::Task,
-                                       client: client)
+                                       client:)
     end
 
     # @param workspace_name [String]

data/lib/checkoff/task_searches.rb

@@ -33,7 +33,7 @@ module Checkoff
     # @!parse
     #   extend CacheMethod::ClassMethods
 
-    # @param config [Hash<Symbol, Object>]
+    # @param config [Hash<Symbol, Object>,Checkoff::Internal::EnvFallbackConfigLoader]
     # @param workspaces [Checkoff::Workspaces]
     # @param task_selectors [Checkoff::TaskSelectors]
     # @param projects [Checkoff::Projects]
@@ -42,10 +42,10 @@ module Checkoff
     # @param search_url_parser [Checkoff::Internal::SearchUrl::Parser]
     # @param asana_resources_collection_class [Class<Asana::Resources::Collection>]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
-                   workspaces: Checkoff::Workspaces.new(config: config),
-                   task_selectors: Checkoff::TaskSelectors.new(config: config),
-                   projects: Checkoff::Projects.new(config: config),
-                   clients: Checkoff::Clients.new(config: config),
+                   workspaces: Checkoff::Workspaces.new(config:),
+                   task_selectors: Checkoff::TaskSelectors.new(config:),
+                   projects: Checkoff::Projects.new(config:),
+                   clients: Checkoff::Clients.new(config:),
                    client: clients.client,
                    search_url_parser: Checkoff::Internal::SearchUrl::Parser.new,
                    asana_resources_collection_class: Asana::Resources::Collection)
@@ -74,8 +74,8 @@ module Checkoff
       # @sg-ignore
       api_params, task_selector = @search_url_parser.convert_params(url)
       debug { "Task search params: api_params=#{api_params}, task_selector=#{task_selector}" }
-      raw_task_search(api_params, workspace_gid: workspace.gid, task_selector: task_selector,
-                                  extra_fields: extra_fields)
+      raw_task_search(api_params, workspace_gid: workspace.gid, task_selector:,
+                                  extra_fields:)
     end
     cache_method :task_search, SHORT_CACHE_TIME
 
@@ -94,11 +94,11 @@ module Checkoff
                         workspace_gid:, extra_fields: [], task_selector: [],
                         fetch_all: true)
       # @sg-ignore
-      tasks = api_task_search_request(api_params, workspace_gid: workspace_gid, extra_fields: extra_fields)
+      tasks = api_task_search_request(api_params, workspace_gid:, extra_fields:)
 
       if fetch_all && tasks.count == 100
         # @sg-ignore
-        tasks = iterated_raw_task_search(api_params, workspace_gid: workspace_gid, extra_fields: extra_fields)
+        tasks = iterated_raw_task_search(api_params, workspace_gid:, extra_fields:)
       end
 
       debug { "#{tasks.count} raw tasks returned" }
@@ -131,9 +131,9 @@ module Checkoff
       options = calculate_api_options(extra_fields)
       @asana_resources_collection_class.new(parse(client.get(path,
                                                              params: api_params,
-                                                             options: options)),
+                                                             options:)),
                                             type: Asana::Resources::Task,
-                                            client: client)
+                                            client:)
     end
 
     # Perform a search using the Asana Task Search API and use manual pagination to
@@ -171,7 +171,7 @@ module Checkoff
 
         # @type [Array<Asana::Resources::Task>]
         task_batch = raw_task_search(new_api_params,
-                                     workspace_gid: workspace_gid, extra_fields: extra_fields + ['created_at'],
+                                     workspace_gid:, extra_fields: extra_fields + ['created_at'],
                                      fetch_all: false).to_a
         oldest = task_batch.to_a.last
 

data/lib/checkoff/task_selectors.rb

@@ -21,18 +21,18 @@ module Checkoff
     SHORT_CACHE_TIME = MINUTE
 
     # @sg-ignore
-    # @param [Hash] config
+    # @param [Hash,Checkoff::Internal::EnvFallbackConfigLoader] config
     # @param [Asana::Client] client
     # @param [Checkoff::Tasks] tasks
     # @param [Checkoff::Timelines] timelines
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
-                   client: Checkoff::Clients.new(config: config).client,
-                   tasks: Checkoff::Tasks.new(config: config,
-                                              client: client),
-                   timelines: Checkoff::Timelines.new(config: config,
-                                                      client: client),
-                   custom_fields: Checkoff::CustomFields.new(config: config,
-                                                             client: client))
+                   client: Checkoff::Clients.new(config:).client,
+                   tasks: Checkoff::Tasks.new(config:,
+                                              client:),
+                   timelines: Checkoff::Timelines.new(config:,
+                                                      client:),
+                   custom_fields: Checkoff::CustomFields.new(config:,
+                                                             client:))
       @config = config
       @tasks = tasks
       @timelines = timelines
@@ -44,8 +44,8 @@ module Checkoff
     #        task details.  Examples: [:tag, 'foo'] [:not, [:tag, 'foo']] [:tag, 'foo']
     # @return [Boolean]
     def filter_via_task_selector(task, task_selector)
-      evaluator = TaskSelectorEvaluator.new(task: task, tasks: tasks, timelines: timelines,
-                                            custom_fields: custom_fields)
+      evaluator = TaskSelectorEvaluator.new(task:, tasks:, timelines:,
+                                            custom_fields:)
       evaluator.evaluate(task_selector)
     end
 
@@ -89,7 +89,7 @@ module Checkoff
         extra_fields = ['custom_fields']
         projects = Checkoff::Projects.new
         project = projects.project_or_raise(workspace_name, project_name)
-        raw_tasks = projects.tasks_from_project(project, extra_fields: extra_fields)
+        raw_tasks = projects.tasks_from_project(project, extra_fields:)
         tasks = raw_tasks.filter { |task| task_selectors.filter_via_task_selector(task, task_selector) }
         # avoid n+1 queries generating the full task formatting
         puts JSON.pretty_generate(tasks.map(&:to_h))

data/lib/checkoff/tasks.rb

@@ -42,15 +42,15 @@ module Checkoff
     # @param date_class [Class<Date>]
     # @param asana_task [Class<Asana::Resources::Task>]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
-                   client: Checkoff::Clients.new(config: config).client,
-                   workspaces: Checkoff::Workspaces.new(config: config,
-                                                        client: client),
-                   sections: Checkoff::Sections.new(config: config,
-                                                    client: client),
-                   portfolios: Checkoff::Portfolios.new(config: config,
-                                                        client: client),
-                   custom_fields: Checkoff::CustomFields.new(config: config,
-                                                             client: client),
+                   client: Checkoff::Clients.new(config:).client,
+                   workspaces: Checkoff::Workspaces.new(config:,
+                                                        client:),
+                   sections: Checkoff::Sections.new(config:,
+                                                    client:),
+                   portfolios: Checkoff::Portfolios.new(config:,
+                                                        client:),
+                   custom_fields: Checkoff::CustomFields.new(config:,
+                                                             client:),
                    time_class: Time,
                    date_class: Date,
                    asana_task: Asana::Resources::Task)
@@ -130,7 +130,7 @@ module Checkoff
       end
       return nil if task_gid.nil?
 
-      task_by_gid(task_gid, only_uncompleted: only_uncompleted, extra_fields: extra_fields)
+      task_by_gid(task_gid, only_uncompleted:, extra_fields:)
     end
     cache_method :task, LONG_CACHE_TIME
 
@@ -145,7 +145,7 @@ module Checkoff
       # @sg-ignore
       t = tasks(workspace_name,
                 project_name,
-                section_name: section_name,
+                section_name:,
                 only_uncompleted: false)
       task_for_gid = t.find { |task| task.name == task_name }
       task_for_gid&.gid
@@ -162,12 +162,12 @@ module Checkoff
     def task_by_gid(task_gid,
                     extra_fields: [],
                     only_uncompleted: true)
-      all_options = projects.task_options(extra_fields: extra_fields,
-                                          only_uncompleted: only_uncompleted)
+      all_options = projects.task_options(extra_fields:,
+                                          only_uncompleted:)
       # @type [Hash]
       options = all_options.fetch(:options, {})
       options[:completed_since] = all_options[:completed_since] unless all_options[:completed_since].nil?
-      client.tasks.find_by_id(task_gid, options: options)
+      client.tasks.find_by_id(task_gid, options:)
     rescue Asana::Errors::NotFound => e
       debug e
       nil
@@ -186,7 +186,7 @@ module Checkoff
                  assignee_gid: default_assignee_gid)
       @asana_task.create(client,
                          assignee: assignee_gid,
-                         workspace: workspace_gid, name: name)
+                         workspace: workspace_gid, name:)
     end
 
     # Return user-accessible URL for a task
@@ -254,7 +254,7 @@ module Checkoff
 
         dependent_tasks << dependent_task
         dependent_tasks += all_dependent_tasks(dependent_task,
-                                               extra_task_fields: extra_task_fields)
+                                               extra_task_fields:)
       end
       dependent_tasks
     end
@@ -281,7 +281,7 @@ module Checkoff
     #
     # @return [Asana::Resources::Task]
     def h_to_task(task_data)
-      task_hashes.h_to_task(task_data, client: client)
+      task_hashes.h_to_task(task_data, client:)
     end
 
     # True if the task is in a project which is in the given portfolio
@@ -332,8 +332,8 @@ module Checkoff
     # @return [Checkoff::Internal::TaskTiming]
     def task_timing
       @task_timing ||= Checkoff::Internal::TaskTiming.new(time_class: @time_class, date_class: @date_class,
-                                                          client: client,
-                                                          custom_fields: custom_fields)
+                                                          client:,
+                                                          custom_fields:)
     end
 
     # @return [Checkoff::Internal::TaskHashes]
@@ -353,12 +353,12 @@ module Checkoff
       if section_name == :unspecified
         project = projects.project_or_raise(workspace_name, project_name)
         projects.tasks_from_project(project,
-                                    only_uncompleted: only_uncompleted,
-                                    extra_fields: extra_fields)
+                                    only_uncompleted:,
+                                    extra_fields:)
       else
         @sections.tasks(workspace_name, project_name, section_name,
-                        only_uncompleted: only_uncompleted,
-                        extra_fields: extra_fields)
+                        only_uncompleted:,
+                        extra_fields:)
       end
     end
     cache_method :tasks, SHORT_CACHE_TIME

data/lib/checkoff/timelines.rb

@@ -24,7 +24,7 @@ module Checkoff
     LONG_CACHE_TIME = MINUTE * 15
     SHORT_CACHE_TIME = MINUTE
 
-    # @param config [Hash]
+    # @param config [Hash,Checkoff::Internal::EnvFallbackConfigLoader]
     # @param workspaces [Checkoff::Workspaces]
     # @param sections [Checkoff::Sections]
     # @param tasks [Checkoff::Tasks]
@@ -32,11 +32,11 @@ module Checkoff
     # @param clients [Checkoff::Clients]
     # @param client [Asana::Client]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
-                   workspaces: Checkoff::Workspaces.new(config: config),
-                   sections: Checkoff::Sections.new(config: config),
-                   tasks: Checkoff::Tasks.new(config: config),
-                   portfolios: Checkoff::Portfolios.new(config: config),
-                   clients: Checkoff::Clients.new(config: config),
+                   workspaces: Checkoff::Workspaces.new(config:),
+                   sections: Checkoff::Sections.new(config:),
+                   tasks: Checkoff::Tasks.new(config:),
+                   portfolios: Checkoff::Portfolios.new(config:),
+                   clients: Checkoff::Clients.new(config:),
                    client: clients.client)
       @workspaces = workspaces
       @sections = sections

data/lib/checkoff/version.rb

@@ -4,5 +4,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.226.0'
+  VERSION = '0.227.0'
 end

data/lib/checkoff/workspaces.rb

@@ -26,7 +26,7 @@ module Checkoff
     # @param client [Asana::Client]
     # @param asana_workspace [Class<Asana::Resources::Workspace>]
     def initialize(config: Checkoff::Internal::ConfigLoader.load(:asana),
-                   client: Checkoff::Clients.new(config: config).client,
+                   client: Checkoff::Clients.new(config:).client,
                    asana_workspace: Asana::Resources::Workspace)
       @config = config
       @client = client