checkoff 0.22.0 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '084d67648e9668ace7b8d103e4e1f9ec1d8d66bb0048cc1f8c7d652dd115397c'
-  data.tar.gz: e1cf9b3f5639841462290ac1a5228fa5ca3dba3d4e70c62d84644184e63e6b89
+  metadata.gz: 26474f8f2f94c75d46d16eadd8c773a22d139d56e0d4bcaaae4c698519e8fa89
+  data.tar.gz: fc1b3a92a5736360fec289c1f2c156bc6570ad465fe8ecfdaa63a1b5a10cef5f
 SHA512:
-  metadata.gz: f49cd3bded68cdcc502b26ac03fe6b7e073aaa93294c4104b36c7bfb014fbbc9e3a792fb85d712e39251ec13ce1e7430e067c06a3075120bb37bcf23de457672
-  data.tar.gz: a4886b2dabc6332688434e0bce0009c1bf1db10b97588f857dc729320b5f840e4f8368afaf03ea78bdbf2e1025c1f4fa9d23839d19d0df8fa2650839226915f0
+  metadata.gz: 80a903a43039264b205cb4ae61f4637360d8a9b4db4cf47062fd4d8e0ed127f420e6da5baebb30c2cbde792261c2265133157f45a19f7cfea8f0577b862327ac
+  data.tar.gz: f6a30feeda861f28f96bb8a7a6b38d68bd3a4042bf21b7521c4382c1b2107aeee8a04c405d5f79fe7fec0acfe27bce778f48ff93c00d27bc552b3f0e531a0359

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.22.0)
+    checkoff (0.24.0)
       activesupport
       asana (> 0.10.0)
       cache_method

data/lib/checkoff/internal/search_url/custom_field_param_converter.rb

@@ -48,6 +48,8 @@ module Checkoff
           'no_value' => CustomFieldVariant::NoValue,
           'is_not' => CustomFieldVariant::IsNot,
           'less_than' => CustomFieldVariant::LessThan,
+          'greater_than' => CustomFieldVariant::GreaterThan,
+          'doesnt_contain_any' => CustomFieldVariant::DoesntContainAny,
         }.freeze
 
         def convert_single_custom_field_params(gid, single_custom_field_params)

data/lib/checkoff/internal/search_url/custom_field_variant.rb

@@ -3,6 +3,7 @@
 module Checkoff
   module Internal
     module SearchUrl
+      # https://developers.asana.com/docs/search-tasks-in-a-workspace
       module CustomFieldVariant
         # base class for handling different custom_field_#{gid}.variant params
         class CustomFieldVariant
@@ -14,56 +15,67 @@ module Checkoff
           private
 
           attr_reader :gid, :remaining_params
-        end
 
-        # custom_field_#{gid}.variant = 'less_than'
-        class LessThan < CustomFieldVariant
-          def convert
-            max_param = "custom_field_#{gid}.max"
+          def fetch_solo_param(param_name)
             case remaining_params.keys
-            when [max_param]
-              convert_single_custom_field_less_than_params_max_param(max_param)
+            when [param_name]
+              param_values = remaining_params.fetch(param_name)
+              unless param_values.length == 1
+                raise "Teach me how to handle these remaining keys for #{param_name}: #{remaining_params}"
+              end
+
+              param_values[0]
             else
               raise "Teach me how to handle #{remaining_params}"
             end
           end
+        end
 
-          private
-
-          def convert_single_custom_field_less_than_params_max_param(max_param)
-            max_values = remaining_params.fetch(max_param)
-            unless max_values.length == 1
-              raise "Teach me how to handle these remaining keys for #{max_param}: #{remaining_params}"
-            end
-
-            max_value = max_values[0]
+        # custom_field_#{gid}.variant = 'less_than'
+        class LessThan < CustomFieldVariant
+          def convert
+            max_value = fetch_solo_param("custom_field_#{gid}.max")
             empty_task_selector = []
             [{ "custom_fields.#{gid}.less_than" => max_value }, empty_task_selector]
           end
         end
 
+        # custom_field_#{gid}.variant = 'greater_than'
+        class GreaterThan < CustomFieldVariant
+          def convert
+            max_value = fetch_solo_param("custom_field_#{gid}.min")
+            empty_task_selector = []
+            [{ "custom_fields.#{gid}.greater_than" => max_value }, empty_task_selector]
+          end
+        end
+
+        # This is used in the UI for select fields
+        #
         # custom_field_#{gid}.variant = 'is_not'
         class IsNot < CustomFieldVariant
           def convert
-            case remaining_params.keys
-            when ["custom_field_#{gid}.selected_options"]
-              convert_single_custom_field_is_not_params_selected_options
-            else
-              raise "Teach me how to handle #{remaining_params}"
-            end
-          end
+            selected_options = fetch_solo_param("custom_field_#{gid}.selected_options").split('~')
 
-          private
+            [{ "custom_fields.#{gid}.is_set" => 'true' },
+             ['not',
+              ['custom_field_gid_value_contains_any_gid',
+               gid,
+               selected_options]]]
+          end
+        end
 
-          def convert_single_custom_field_is_not_params_selected_options
-            selected_options = remaining_params.fetch("custom_field_#{gid}.selected_options")
-            raise "Teach me how to handle #{remaining_params}" unless selected_options.length == 1
+        # This is used in the UI for multi-select fields
+        #
+        # custom_field_#{gid}.variant = 'doesnt_contain_any'
+        class DoesntContainAny < CustomFieldVariant
+          def convert
+            selected_options = fetch_solo_param("custom_field_#{gid}.selected_options").split('~')
 
             [{ "custom_fields.#{gid}.is_set" => 'true' },
              ['not',
               ['custom_field_gid_value_contains_any_gid',
                gid,
-               selected_options.fetch(0).split('~')]]]
+               selected_options]]]
           end
         end
 

data/lib/checkoff/internal/task_selector_evaluator.rb

@@ -105,24 +105,40 @@ module Checkoff
       end
 
       matched_custom_field = custom_fields.find { |data| data.fetch('gid') == custom_field_gid }
-      raise "Could not find custom field with gid #{custom_field_gid}" if matched_custom_field.nil?
+      if matched_custom_field.nil?
+        raise "Could not find custom field with gid #{custom_field_gid} in #{task.gid} with #{custom_fields}"
+      end
 
       matched_custom_field
     end
 
-    def pull_custom_field_values_gids(task, custom_field_gid)
-      matched_custom_field = pull_custom_field_or_raise(task, custom_field_gid)
+    def pull_enum_values(custom_field)
+      resource_subtype = custom_field.fetch('resource_subtype')
+      case resource_subtype
+      when 'enum'
+        [custom_field.fetch('enum_value')]
+      when 'multi_enum'
+        custom_field.fetch('multi_enum_values')
+      else
+        raise "Teach me how to handle resource_subtype #{resource_subtype}"
+      end
+    end
 
-      enum_value = matched_custom_field.fetch('enum_value')
-      actual_custom_field_values_gids = []
-      unless enum_value.nil?
-        if enum_value.fetch('enabled') == false
-          raise "Unexpected enabled value on custom field: #{matched_custom_field}"
-        end
+    def find_gids(custom_field, enum_value)
+      if enum_value.nil?
+        []
+      else
+        raise "Unexpected enabled value on custom field: #{custom_field}" if enum_value.fetch('enabled') == false
 
-        actual_custom_field_values_gids = [enum_value.fetch('gid')]
+        [enum_value.fetch('gid')]
+      end
+    end
+
+    def pull_custom_field_values_gids(task, custom_field_gid)
+      custom_field = pull_custom_field_or_raise(task, custom_field_gid)
+      pull_enum_values(custom_field).flat_map do |enum_value|
+        find_gids(custom_field, enum_value)
       end
-      actual_custom_field_values_gids
     end
   end
 

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.22.0'
+  VERSION = '0.24.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.22.0
+  version: 0.24.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-01-09 00:00:00.000000000 Z
+date: 2023-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport