checkoff 0.219.0 → 0.221.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7da0b9ca0d23eef9a6e173b31d4816cc7e3d101213f27822609163ae5e0d5057
-  data.tar.gz: a5f7a9d1a9887cb4f4b8f888d26d9254340f0dd5aa5b8be65f791a06c233e5c4
+  metadata.gz: 852a3ff26e52a45c94de5254c46b9295965f1f666ce46079710ef8dc122f9e41
+  data.tar.gz: 77522c0a820d2f619f70cfabbe59965c1aa5a125c99ed398a56fca62413fb97a
 SHA512:
-  metadata.gz: c2f23a332f26cc9f5f9b00f221ee311a6e247966c60e49cd5811d29c6e6317975c1314f335da8f80326330f2cd774759ac86bcdcf01d10cefc8a315efd2070bd
-  data.tar.gz: fa89c8a3d37d82ff1fb7e0ecccbf22efd3869eef58cd72f9485030782e8c31d93c8cbc6424863e64ecd55bf8f12e7fcea6f927dc630a376f0902ffa4318e66e6
+  metadata.gz: 57d780efb0d8189698a948695daf6d3f014331b3133b6f487619d024baa18f5318ce0cf11ee78cdffbd528367093830e48b553bcccd29cfba45ed8679f8325d6
+  data.tar.gz: 54c25e37cb80b3015c1b92e99740e4b7d00ebad595cb6fa74add99d6d2eff06ffc36933a3b4ae4d207efef96df4cd988a0ca9e1c3fcdea24850e43bb777b655f

data/.circleci/config.yml

@@ -48,9 +48,8 @@ commands:
             done
       - restore_cache:
           keys:
-            - rbenv-v4-{{ checksum "Gemfile.lock" }}-
-            - rbenv-v4-
-            - rbenv-
+            - rbenv-v5-{{ checksum "Gemfile.lock" }}-
+            - rbenv-v5-
       - restore_cache:
           keys:
             - pyenv-v2-{{ checksum "requirements_dev.txt" }}-
@@ -218,7 +217,7 @@ jobs:
       #     label: Typecheck
       #     command: make citypecheck citypecoverage
       - save_cache:
-          key: rbenv-v4-{{ checksum "Gemfile.lock" }}-{{ checksum ".ruby-version" }}
+          key: rbenv-v5-{{ checksum "Gemfile.lock" }}-{{ checksum ".ruby-version" }}
           paths:
             - "Gemfile.lock.installed"
             - "types.installed"

data/.overcommit.yml

@@ -83,6 +83,8 @@ PreCommit:
       - test/**/*
       - ".bundle/**/*"
       - ".markdownlint_style.rb"
+  Sorbet:
+    enabled: true
   Punchlist:
     command: ['bundle', 'exec', 'punchlist']
     enabled: true

data/.rubocop.yml

@@ -42,6 +42,10 @@ Metrics/ParameterLists:
 Minitest/TestMethodName:
   Enabled: false
 
+Naming/FileName:
+  Exclude:
+    - 'lib/checkoff.rb'
+
 Naming/HeredocDelimiterNaming:
   Enabled: false
 

data/.rubocop_todo.yml

@@ -6,12 +6,13 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 20
+# Offense count: 21
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Exclude:
     - 'lib/checkoff/internal/asana_event_filter.rb'
     - 'lib/checkoff/task_searches.rb'
+    - 'lib/checkoff/tasks.rb'
     - 'lib/checkoff/timelines.rb'
     - 'test/unit/test_portfolios.rb'
     - 'test/unit/test_task_selectors.rb'

data/Gemfile

@@ -17,6 +17,7 @@ group :development, :test do
   # ensure version with branch coverage
   gem 'simplecov', ['>=0.18.0']
   gem 'simplecov-lcov'
+  gem 'tapioca', require: false
   gem 'undercover'
   gem 'webmock'
 end

data/Gemfile.lock

@@ -43,12 +43,13 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.219.0)
+    checkoff (0.221.0)
       activesupport
       asana (> 0.10.0)
       cache_method
       gli
       mime-types
+      sorbet-runtime
 
 GEM
   remote: https://rubygems.org/
@@ -94,6 +95,7 @@ GEM
     docile (1.4.0)
     drb (2.2.1)
     e2mmap (0.1.0)
+    erubi (1.13.0)
     faraday (1.10.3)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
@@ -167,16 +169,17 @@ GEM
     multi_xml (0.6.0)
     multipart-post (2.3.0)
     mutex_m (0.3.0)
-    nokogiri (1.16.8)
+    netrc (0.11.0)
+    nokogiri (1.17.0)
       mini_portile2 (~> 2.8.2)
       racc (~> 1.4)
-    nokogiri (1.16.8-aarch64-linux)
+    nokogiri (1.17.0-aarch64-linux)
       racc (~> 1.4)
-    nokogiri (1.16.8-arm64-darwin)
+    nokogiri (1.17.0-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.16.8-x86_64-darwin)
+    nokogiri (1.17.0-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.16.8-x86_64-linux)
+    nokogiri (1.17.0-x86_64-linux)
       racc (~> 1.4)
     oauth2 (1.4.11)
       faraday (>= 0.17.3, < 3.0)
@@ -192,6 +195,7 @@ GEM
     parser (3.2.2.4)
       ast (~> 2.4.1)
       racc
+    prism (1.2.0)
     pry (0.14.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
@@ -199,9 +203,12 @@ GEM
     punchlist (1.3.2)
       source_finder (>= 2)
     racc (1.8.1)
-    rack (3.0.8)
+    rack (3.1.8)
     rainbow (3.1.1)
     rake (13.1.0)
+    rbi (0.2.1)
+      prism (~> 1.0)
+      sorbet-runtime (>= 0.5.9204)
     rbs (2.8.4)
     regexp_parser (2.8.3)
     reverse_markdown (2.1.1)
@@ -241,7 +248,30 @@ GEM
     simplecov-html (0.12.3)
     simplecov-lcov (0.8.0)
     simplecov_json_formatter (0.1.4)
+    sorbet (0.5.11690)
+      sorbet-static (= 0.5.11690)
+    sorbet-runtime (0.5.11690)
+    sorbet-static (0.5.11690-aarch64-linux)
+    sorbet-static (0.5.11690-universal-darwin)
+    sorbet-static (0.5.11690-x86_64-linux)
+    sorbet-static-and-runtime (0.5.11690)
+      sorbet (= 0.5.11690)
+      sorbet-runtime (= 0.5.11690)
     source_finder (3.2.1)
+    spoom (1.5.0)
+      erubi (>= 1.10.0)
+      prism (>= 0.28.0)
+      sorbet-static-and-runtime (>= 0.5.10187)
+      thor (>= 0.19.2)
+    tapioca (0.16.5)
+      bundler (>= 2.2.25)
+      netrc (>= 0.11.0)
+      parallel (>= 1.21.0)
+      rbi (~> 0.2)
+      sorbet-static-and-runtime (>= 0.5.11087)
+      spoom (>= 1.2.0)
+      thor (>= 1.2.0)
+      yard-sorbet
     thor (1.3.2)
     tilt (2.4.0)
     tomlrb (2.0.3)
@@ -257,7 +287,10 @@ GEM
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    yard (0.9.34)
+    yard (0.9.37)
+    yard-sorbet (0.9.0)
+      sorbet-runtime
+      yard
 
 PLATFORMS
   aarch64-linux
@@ -294,6 +327,7 @@ DEPENDENCIES
   simplecov-lcov
   solargraph!
   solargraph-rails!
+  tapioca
   undercover
   webmock
   yard

data/Makefile

@@ -15,13 +15,16 @@ export PRINT_HELP_PYSCRIPT
 help:
 	@python -c "$$PRINT_HELP_PYSCRIPT" < $(MAKEFILE_LIST)
 
-default: clean-coverage test coverage clean-typecoverage typecheck typecoverage quality ## run default typechecking, tests and quality
+default: clean-typecoverage typecheck typecoverage clean-coverage test coverage quality ## run default typechecking, tests and quality
 
-build-typecheck: types.installed ## Fetch information that type checking depends on
+build-typecheck: Gemfile.lock.installed types.installed ## Fetch information that type checking depends on
 
 types.installed: Gemfile.lock Gemfile.lock.installed ## Install Ruby dependencies
 	bundle exec yard gems 2>&1 || bundle exec yard gems --safe 2>&1 || bundle exec yard gems 2>&1
 	# bundle exec solargraph scan 2>&1
+	bin/tapioca gems
+	bin/tapioca annotations
+	bin/tapioca dsl
 	touch types.installed
 
 clean-typecheck: ## Refresh information that type checking depends on
@@ -29,10 +32,13 @@ clean-typecheck: ## Refresh information that type checking depends on
 	rm -fr .yardoc/
 	echo all clear
 
-typecheck: ## validate types in code and configuration
-	bundle exec solargraph typecheck --level strong
+typecheck: build-typecheck ## validate types in code and configuration
+	bin/tapioca dsl --verify
+	bundle exec srb tc
+	bin/overcommit_branch # ideally this would just run solargraph
 
 citypecheck: typecheck ## Run type check from CircleCI
+	bundle exec solargraph typecheck --level strong
 
 typecoverage: typecheck ## Run type checking and then ratchet coverage in metrics/
 
@@ -46,9 +52,8 @@ requirements_dev.txt.installed: requirements_dev.txt
 
 pip_install: requirements_dev.txt.installed ## Install Python dependencies
 
-# bundle install doesn't get run here so that we can catch it below in
-# fresh-checkout and fresh-rbenv cases
 Gemfile.lock: Gemfile checkoff.gemspec
+	bundle install
 
 # Ensure any Gemfile.lock changes ensure a bundle is installed.
 Gemfile.lock.installed: Gemfile.lock
@@ -65,7 +70,7 @@ clean: clear_metrics ## remove all built artifacts
 citest: test ## Run unit tests from CircleCI
 
 overcommit: ## run precommit quality checks
-	bundle exec overcommit --run
+	bin/overcommit_branch
 
 quality: overcommit ## run precommit quality checks
 
@@ -104,6 +109,7 @@ update_from_cookiecutter: ## Bring in changes from template project used to crea
 	git checkout --ours Gemfile.lock || true
 	# update frequently security-flagged gems while we're here
 	bundle update --conservative nokogiri rack rexml yard || true
+	make build-typecheck
 	git add Gemfile.lock || true
 	bundle install || true
 	bundle exec overcommit --install || true

data/bin/tapioca

@@ -13,7 +13,7 @@ ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
 bundle_binstub = File.expand_path("bundle", __dir__)
 
 if File.file?(bundle_binstub)
-  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
     load(bundle_binstub)
   else
     abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.

data/checkoff.gemspec

@@ -29,6 +29,7 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'cache_method'
   spec.add_runtime_dependency 'gli'
   spec.add_runtime_dependency 'mime-types'
+  spec.add_runtime_dependency 'sorbet-runtime'
 
   spec.metadata = {
     'rubygems_mfa_required' => 'false',

data/fix.sh

@@ -263,6 +263,7 @@ ensure_bundle() {
       bundle lock --add-platform "${platform}"
     fi
   done
+  ls -l
   make bundle_install
 }
 

data/lib/checkoff/tasks.rb

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+# typed: true
+
 # frozen_string_literal: true
 
 require_relative 'sections'
@@ -11,6 +13,7 @@ require_relative 'internal/task_hashes'
 require_relative 'internal/logging'
 require_relative 'internal/thread_local'
 require 'asana'
+require 'sorbet-runtime'
 
 module Checkoff
   # Pull tasks from Asana
@@ -18,6 +21,8 @@ module Checkoff
     # @!parse
     #   extend CacheMethod::ClassMethods
 
+    extend T::Sig
+
     include Logging
 
     MINUTE = 60
@@ -227,7 +232,8 @@ module Checkoff
     #
     # @return [Array<Hash>]
     def all_dependent_tasks(task, extra_task_fields: [])
-      dependent_tasks = []
+      # @type [Array<Hash>]
+      dependent_tasks = T.let([], T::Array[Hash])
       # See note above - same applies as does in @dependencies
       #
       # @type [Array<Hash>]
@@ -305,7 +311,7 @@ module Checkoff
                                      workspace_name: @workspaces.default_workspace.name)
       portfolio_projects = @portfolios.projects_in_portfolio(workspace_name, portfolio_name)
       portfolio_project_gids = portfolio_projects.map(&:gid)
-      seen = false
+      seen = T.let(false, T::Boolean)
       task.memberships.each do |membership|
         project_gid = membership.fetch('project').fetch('gid')
         next unless portfolio_project_gids.include?(project_gid)

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.219.0'
+  VERSION = '0.221.0'
 end