checkoff 0.200.0 → 0.203.0

data/Gemfile.lock

@@ -9,10 +9,32 @@ GIT
       faraday_middleware-multi_json (~> 0.0)
       oauth2 (~> 1.4)
 
+GIT
+  remote: https://github.com/apiology/solargraph
+  revision: 904b9304770a59fac393c5cc3cad481e5bdf0fd8
+  branch: master
+  specs:
+    solargraph (0.50.1)
+      backport (~> 1.2)
+      benchmark
+      bundler (~> 2.0)
+      diff-lcs (~> 1.4)
+      e2mmap
+      jaro_winkler (~> 1.5)
+      kramdown (~> 2.3)
+      kramdown-parser-gfm (~> 1.1)
+      parser (~> 3.0)
+      rbs (~> 2.0)
+      reverse_markdown (~> 2.0)
+      rubocop (~> 1.38)
+      thor (~> 1.0)
+      tilt (~> 2.0)
+      yard (~> 0.9, >= 0.9.24)
+
 PATH
   remote: .
   specs:
-    checkoff (0.200.0)
+    checkoff (0.203.0)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -22,15 +44,18 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.3)
+    activesupport (7.1.5)
       base64
+      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      logger (>= 1.4.2)
       minitest (>= 5.1)
       mutex_m
+      securerandom (>= 0.3)
       tzinfo (~> 2.0)
     addressable (2.8.6)
       public_suffix (>= 2.0.2, < 6.0)
@@ -38,8 +63,10 @@ GEM
     ast (2.4.2)
     backport (1.2.0)
     base64 (0.2.0)
-    benchmark (0.3.0)
+    benchmark (0.4.0)
     bigdecimal (3.1.5)
+    brakeman (6.2.2)
+      racc
     builder (3.2.4)
     bump (0.10.0)
     cache (0.4.1)
@@ -47,18 +74,17 @@ GEM
       cache (>= 0.2.1)
     chef-utils (18.3.0)
       concurrent-ruby
-    childprocess (4.1.0)
+    childprocess (5.1.0)
+      logger (~> 1.5)
     coderay (1.1.3)
     concurrent-ruby (1.2.3)
     connection_pool (2.4.1)
     crack (0.4.5)
       rexml
-    diff-lcs (1.5.0)
+    diff-lcs (1.5.1)
     docile (1.4.0)
-    drb (2.2.0)
-      ruby2_keywords
+    drb (2.2.1)
     e2mmap (0.1.0)
-    fakeweb (1.3.0)
     faraday (1.10.3)
       faraday-em_http (~> 1.0)
       faraday-em_synchrony (~> 1.0)
@@ -87,14 +113,14 @@ GEM
     faraday_middleware-multi_json (0.0.6)
       faraday_middleware
       multi_json
-    gli (2.21.1)
+    gli (2.22.0)
     hashdiff (1.0.1)
-    i18n (1.14.1)
+    i18n (1.14.6)
       concurrent-ruby (~> 1.0)
     imagen (0.1.8)
       parser (>= 2.5, != 2.5.1.1)
     iniparse (1.5.0)
-    jaro_winkler (1.5.6)
+    jaro_winkler (1.6.0)
     json (2.7.1)
     jwt (2.7.1)
     kramdown (2.4.0)
@@ -102,6 +128,7 @@ GEM
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
     language_server-protocol (3.17.0.3)
+    logger (1.6.1)
     mdl (0.13.0)
       kramdown (~> 2.3)
       kramdown-parser-gfm (~> 1.1)
@@ -129,12 +156,16 @@ GEM
     multi_json (1.15.0)
     multi_xml (0.6.0)
     multipart-post (2.3.0)
-    mutex_m (0.2.0)
-    nokogiri (1.16.2-arm64-darwin)
+    mutex_m (0.3.0)
+    nokogiri (1.16.7-aarch64-linux)
       racc (~> 1.4)
-    nokogiri (1.16.2-x86_64-darwin)
+    nokogiri (1.16.7-arm-linux)
       racc (~> 1.4)
-    nokogiri (1.16.2-x86_64-linux)
+    nokogiri (1.16.7-arm64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.16.7-x86_64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.16.7-x86_64-linux)
       racc (~> 1.4)
     oauth2 (1.4.11)
       faraday (>= 0.17.3, < 3.0)
@@ -142,8 +173,9 @@ GEM
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
       rack (>= 1.2, < 4)
-    overcommit (0.60.0)
-      childprocess (>= 0.6.3, < 5)
+    ostruct (0.6.1)
+    overcommit (0.64.0)
+      childprocess (>= 0.6.3, < 6)
       iniparse (~> 1.4)
       rexml (~> 3.2)
     parallel (1.23.0)
@@ -154,7 +186,7 @@ GEM
       coderay (~> 1.1)
       method_source (~> 1.0)
     public_suffix (5.0.4)
-    punchlist (1.3.0)
+    punchlist (1.3.2)
       source_finder (>= 2)
     racc (1.7.3)
     rack (3.0.8)
@@ -181,11 +213,15 @@ GEM
     rubocop-minitest (0.34.5)
       rubocop (>= 1.39, < 2.0)
       rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-performance (1.20.2)
+      rubocop (>= 1.48.1, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
     ruby-progressbar (1.13.0)
     ruby2_keywords (0.0.5)
     rugged (1.6.3)
+    securerandom (0.3.2)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
@@ -193,25 +229,9 @@ GEM
     simplecov-html (0.12.3)
     simplecov-lcov (0.8.0)
     simplecov_json_formatter (0.1.4)
-    solargraph (0.50.0)
-      backport (~> 1.2)
-      benchmark
-      bundler (~> 2.0)
-      diff-lcs (~> 1.4)
-      e2mmap
-      jaro_winkler (~> 1.5)
-      kramdown (~> 2.3)
-      kramdown-parser-gfm (~> 1.1)
-      parser (~> 3.0)
-      rbs (~> 2.0)
-      reverse_markdown (~> 2.0)
-      rubocop (~> 1.38)
-      thor (~> 1.0)
-      tilt (~> 2.0)
-      yard (~> 0.9, >= 0.9.24)
     source_finder (3.2.1)
-    thor (1.3.0)
-    tilt (2.3.0)
+    thor (1.3.2)
+    tilt (2.4.0)
     tomlrb (2.0.3)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
@@ -228,36 +248,40 @@ GEM
     yard (0.9.34)
 
 PLATFORMS
+  aarch64-linux
   arm64-darwin-23
+  arm64-linux
   x86_64-darwin-23
   x86_64-linux
   x86_64-linux-musl
 
 DEPENDENCIES
   asana!
+  brakeman
   bump
   bundler
   checkoff!
-  fakeweb
   mdl
   mime-types (= 3.5.1)
   minitest-profile
   minitest-reporters
   mocha (>= 2)
-  overcommit (>= 0.60.0, < 0.61.0)
+  ostruct
+  overcommit (>= 0.64.0, < 0.65.0)
   pry
-  punchlist
-  rake (~> 13.0)
+  punchlist (>= 1.3.1)
+  rake
   rbs
   rubocop (~> 1.52)
   rubocop-minitest
+  rubocop-performance
   rubocop-rake
   simplecov (>= 0.18.0)
   simplecov-lcov
-  solargraph (>= 0.50.0)
+  solargraph!
   undercover
   webmock
   yard
 
 BUNDLED WITH
-   2.5.5
+   2.3.27

data/LICENSE

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2016-2023, Vince Broz
+Copyright (c) 2016-2024, Vince Broz
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/Makefile

@@ -1,4 +1,4 @@
-.PHONY: clean test help quality localtest
+.PHONY: build-typecheck bundle_install cicoverage citypecheck citest citypecoverage clean clean-coverage clean-typecheck clean-typecoverage coverage default help localtest overcommit quality repl report-coverage report-coverage-to-codecov rubocop test typecheck typecoverage update_from_cookiecutter
 .DEFAULT_GOAL := default
 
 define PRINT_HELP_PYSCRIPT
@@ -17,7 +17,17 @@ help:
 
 default: clean-coverage test coverage clean-typecoverage typecheck typecoverage quality ## run default typechecking, tests and quality
 
+build-typecheck: bundle_install ## Fetch information that type checking depends on
+	bundle exec yard gems 2>&1; bundle exec yard gems --safe 2>&1; bundle exec yard gems 2>&1
+	# bundle exec solargraph scan 2>&1
+
+clean-typecheck: ## Refresh information that type checking depends on
+	bundle exec solargraph clear
+	rm -fr .yardoc/
+	echo all clear
+
 typecheck: ## validate types in code and configuration
+	bundle exec solargraph typecheck --level strong
 
 citypecheck: typecheck ## Run type check from CircleCI
 
@@ -68,14 +78,6 @@ repl:  ## Load up checkoff in pry
 clean-coverage:
 	@bundle exec rake clear_metrics
 
-clean-typecheck: ## Refresh information that type checking depends on
-	bundle install
-	bundle exec solargraph clear
-	rm -fr .yardoc/
-	bundle exec yard gems
-	bundle exec solargraph scan
-	echo all clear
-
 coverage: test report-coverage ## check code coverage
 	@bundle exec rake undercover
 
@@ -87,10 +89,10 @@ update_from_cookiecutter: ## Bring in changes from template project used to crea
 	bundle exec overcommit --uninstall
 	cookiecutter_project_upgrader --help >/dev/null
 	IN_COOKIECUTTER_PROJECT_UPGRADER=1 cookiecutter_project_upgrader || true
-	git checkout cookiecutter-template && git push && git checkout main
-	git checkout main && git pull && git checkout -b update-from-cookiecutter-$$(date +%Y-%m-%d-%H%M)
+	git checkout cookiecutter-template && git push --no-verify
+	git checkout main; overcommit --sign && overcommit --sign pre-commit && git checkout main && git pull && git checkout -b update-from-cookiecutter-$$(date +%Y-%m-%d-%H%M)
 	git merge cookiecutter-template || true
-	bundle exec overcommit --install
+	bundle exec overcommit --install || true
 	@echo
 	@echo "Please resolve any merge conflicts below and push up a PR with:"
 	@echo

data/bin/brakeman

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'brakeman' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("brakeman", "brakeman")

data/bin/overcommit_branch

@@ -0,0 +1,117 @@
+#!/usr/bin/env ruby
+
+# frozen_string_literal: true
+
+require 'overcommit'
+require 'optparse'
+
+# frozen_string_literal: true
+
+require 'set'
+
+module Overcommit::HookContext
+  # Simulates a pre-commit context representing all commits on the
+  # current feature branch, useful for automated CI scripts in large
+  # projects where not all unchanged files are assumed to pass.
+  class FeatureBranch < Base
+    # @return [Array<String>]
+    def modified_files
+      # use git cli to get the list of files changed on this feature branch
+      # @sg-ignore
+      # @type [Array<String>]
+      @modified_files ||= begin
+        # @sg-ignore
+        # @type [Array<String>]
+        relative_filenames = `git diff --name-only origin/main...HEAD`.split("\n")
+        absolute_filenames = relative_filenames.map { |f| File.expand_path(f) }
+        absolute_filenames.select { |f| File.exist?(f) }
+      end
+    end
+
+    # @param file [String]
+    #
+    # @return [Set]
+    def modified_lines_in_file(file)
+      modified_lines = Set.new
+
+      # use git cli to get the list of lines changed in this file on this feature branch
+      # @sg-ignore
+      # @type [Array<String>]
+      lines = `git diff -U0 origin/main...HEAD -- #{file}`.split("\n")
+
+      lines.each do |line|
+        if line =~ /^@@ -\d+,\d+ \+(\d+),(\d+)/
+          first_line = Regexp.last_match(1).to_i
+          last_line = first_line + Regexp.last_match(2).to_i - 1
+          # add each line # to modified_lines
+          (first_line..last_line).each do |line_number|
+            modified_lines << line_number
+          end
+        end
+      end
+
+      modified_lines
+    end
+
+    def hook_class_name
+      'PreCommit'
+    end
+
+    def hook_type_name
+      'pre_commit'
+    end
+
+    def hook_script_name
+      'pre-commit'
+    end
+
+    def initial_commit?
+      return @initial_commit unless @initial_commit.nil?
+
+      @initial_commit = Overcommit::GitRepo.initial_commit?
+    end
+
+    private
+
+    # @param file [IO]
+    #
+    # @return [Integer]
+    def count_lines(file)
+      File.foreach(file).count
+    end
+  end
+end
+
+# Returns the configuration for this repository.
+
+# Used for ease of stubbing in tests
+# @param status [Integer] The exit status to return
+# @return [void]
+def halt(status = 0)
+  exit status
+end
+
+# @return [Overcommit::Logger]
+def log
+  # @sg-ignore
+  @log ||= Overcommit::Logger.new(STDOUT)
+end
+
+# @param options [Hash]
+#
+# @return [Overcommit::Configuration]
+def config(options = {})
+  @config ||= Overcommit::ConfigurationLoader.new(log, options).load_repo_config
+end
+
+empty_stdin = File.open(File::NULL) # pre-commit hooks don't take input
+context = Overcommit::HookContext::FeatureBranch.new(config, [], empty_stdin)
+config.apply_environment!(context, ENV)
+
+printer = Overcommit::Printer.new(config, log, context)
+# @sg-ignore
+runner  = Overcommit::HookRunner.new(config, log, context, printer)
+
+status = runner.run
+
+halt(status ? 0 : 65)

data/bin/spoom

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'spoom' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("spoom", "spoom")

data/bin/srb

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'srb' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("sorbet", "srb")

data/bin/srb-rbi

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'srb-rbi' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("sorbet", "srb-rbi")

data/bin/tapioca

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'tapioca' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300) =~ /This file was generated by Bundler/
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("tapioca", "tapioca")

data/config/annotations_misc.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+#
+# https://gist.github.com/castwide/28b349566a223dfb439a337aea29713e
+#
+# The following comments fill some of the gaps in Solargraph's
+# understanding of types. Since they're all in YARD, they get mapped
+# in Solargraph but ignored at runtime.
+#
+# You can put this file anywhere in the project, as long as it gets included in
+# the workspace maps. It's recommended that you keep it in a standalone file
+# instead of pasting it into an existing one.
+#
+# @!override Hash<[String,Symbol],String>#fetch
+#   @return [String>]
+#
+# @!parse
+#   class ENV
+#     # @param key [String]
+#     # @param default [Object]
+#     #
+#     # @return [String,Symbol<:none>,nil]
+#     def self.fetch(key, default = :none); end
+#     # @param key [String]
+#     #
+#     # @return [Object,nil]
+#     def self.[](key); end
+#   end
+#   module Bundler
+#     class << self
+#       # @param groups [Array<Symbol>]
+#       #
+#       # @return [void]
+#       def require(*groups); end
+#     end
+#   end

data/docs/cookiecutter_input.json

@@ -12,5 +12,6 @@
     "project_short_description": "Command-line and gem client for Asana (unofficial)",
     "project_slug": "checkoff",
     "type_of_github_repo": "public",
+    "use_checkoff": "No",
     "version": "0.8.0"
 }

data/fix.sh

@@ -87,10 +87,12 @@ ensure_dev_library() {
   header_file_name=${1:?header file name}
   homebrew_package=${2:?homebrew package}
   apt_package=${3:-${homebrew_package}}
-  if ! [ -f /usr/include/"${header_file_name}" ] && \
+  if ! [ -f /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/"${header_file_name}" ] && \
+      ! [ -f /opt/homebrew/include/"${header_file_name}" ] && \
+      ! [ -f /usr/include/"${header_file_name}" ] && \
       ! [ -f /usr/include/x86_64-linux-gnu/"${header_file_name}" ] && \
       ! [ -f /usr/local/include/"${header_file_name}" ] && \
-      ! [ -f  /usr/local/opt/"${homebrew_package}"/include/"${header_file_name}" ]
+      ! [ -f /usr/local/opt/"${homebrew_package}"/include/"${header_file_name}" ]
   then
     install_package "${homebrew_package}" "${apt_package}"
   fi
@@ -116,7 +118,7 @@ ensure_ruby_versions() {
 
   # You can find out which feature versions are still supported / have
   # been release here: https://www.ruby-lang.org/en/downloads/
-  ruby_versions="$(latest_ruby_version 3.0)"
+  ruby_versions="$(latest_ruby_version 3.1)"
 
   echo "Latest Ruby versions: ${ruby_versions}"
 
@@ -191,7 +193,7 @@ ensure_bundle() {
   #
   # This affects nokogiri, which will try to reinstall itself in
   # Docker builds where it's already installed if this is not run.
-  for platform in arm64-darwin-23 x86_64-darwin-23 x86_64-linux x86_64-linux-musl
+  for platform in arm64-darwin-23 x86_64-darwin-23 x86_64-linux x86_64-linux-musl aarch64-linux arm64-linux
   do
     grep "${platform:?}" Gemfile.lock >/dev/null 2>&1 || bundle lock --add-platform "${platform:?}"
   done
@@ -264,7 +266,7 @@ install_package() {
     HOMEBREW_NO_AUTO_UPDATE=1 HOMEBREW_NO_INSTALL_UPGRADE=1 brew install "${homebrew_package}"
   elif type apt-get >/dev/null 2>&1
   then
-    if ! time dpkg -s "${apt_package}" >/dev/null
+    if ! dpkg -s "${apt_package}" >/dev/null
     then
       update_apt
       sudo DEBIAN_FRONTEND=noninteractive apt-get install -y "${apt_package}"
@@ -295,7 +297,7 @@ ensure_python_build_requirements() {
   ensure_dev_library zlib.h zlib zlib1g-dev
   ensure_dev_library bzlib.h bzip2 libbz2-dev
   ensure_dev_library openssl/ssl.h openssl libssl-dev
-  ensure_dev_library ffi.h libffi libffi-dev
+  ensure_dev_library ffi/ffi.h libffi libffi-dev
   ensure_dev_library sqlite3.h sqlite3 libsqlite3-dev
   ensure_dev_library lzma.h xz liblzma-dev
   ensure_dev_library readline/readline.h readline libreadline-dev
@@ -388,6 +390,10 @@ ensure_rugged_packages_installed() {
 
 ensure_rbenv
 
+ensure_types_built() {
+  make build-typecheck
+}
+
 ensure_ruby_versions
 
 set_ruby_local_version
@@ -408,4 +414,6 @@ ensure_python_requirements
 
 ensure_shellcheck
 
+ensure_types_built
+
 ensure_overcommit

data/lib/checkoff/custom_fields.rb

@@ -70,6 +70,9 @@ module Checkoff
       resource_custom_field_enum_values(custom_field).flat_map do |enum_value|
         find_gids(custom_field, enum_value)
       end
+    rescue StandardError => e
+      raise "Could not process custom field with gid #{custom_field_gid} " \
+            "in gid #{resource.gid} with custom fields #{resource.custom_fields.inspect}: #{e}"
     end
 
     # @param resource [Asana::Resources::Project,Asana::Resources::Task]
@@ -162,8 +165,6 @@ module Checkoff
       if enum_value.nil?
         []
       else
-        raise "Unexpected enabled value on custom field: #{custom_field}" if enum_value.fetch('enabled') == false
-
         [enum_value.fetch('gid')]
       end
     end