checkoff 0.186.0 → 0.188.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab93a442000f1d706e304c5d574a9266c19dcff4be222107dc943f6c1d3ecd3f
-  data.tar.gz: 373ce95b10e181827c2423bfce1a0a37f43a12b32ebebd79ea5b8e98dcc0787f
+  metadata.gz: 6adfa7e1e576e5fe7d462404260037f351d1995cfdbcac89f1292b3baf71aa69
+  data.tar.gz: a2bd18068eddd8f0844390dc22002710e7338d73c85b33733d3f4f426a223c1b
 SHA512:
-  metadata.gz: b4f7267e3254bb4d22593bca64557ec58641b69ff95ceb7890c34a5c87512b27a5dda4fecf7db78ee5088692dbcc8c5380f673459a9df3c1edd744746215d364
-  data.tar.gz: '0680cf901961be8001249375c81ceaa77ed903e0acb2f06ecc3b62093a110d7d4bcc225e706d46b31838a50d08d0f8811f4e636166715f5d48b73e33a940f521'
+  metadata.gz: 64c3cb55f53d9fd2904a5e29327f3ae42a3b2e52ee3a891e3730245f1edd32af2815ae1e80bbbb0cb838b21e79dca8f10edf6a0f8594cc00fce492a55276ca47
+  data.tar.gz: 830d6ac25e2d4f638eec6258cd6ea8d4ccc40f1d51e05d0f96be7ac831ff7eddf5c76f2da0f6b5dc16d1b4b041623634b1c7450a20513b3041c30140d9bd299e

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.186.0)
+    checkoff (0.188.0)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -180,7 +180,7 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.30.0)
       parser (>= 3.2.1.0)
-    rubocop-minitest (0.34.4)
+    rubocop-minitest (0.34.5)
       rubocop (>= 1.39, < 2.0)
       rubocop-ast (>= 1.30.0, < 2.0)
     rubocop-rake (0.6.0)
@@ -262,4 +262,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   2.4.22
+   2.5.5

data/config/definitions.rb

@@ -2,6 +2,14 @@
 #
 # rubocop:disable Layout/LineLength
 # @!parse
+#   module OpenSSL
+#     module SSL
+#       # @type [Integer]
+#       VERIFY_PEER = 1
+#       # @type [Integer]
+#       VERIFY_NONE = 0
+#     end
+#   end
 #   class Time
 #     class << self
 #       # @param time [String]

data/fix.sh

@@ -146,18 +146,23 @@ ensure_bundle() {
   # Version <2.2.22 of bundler isn't compatible with Ruby 3.3:
   #
   # https://stackoverflow.com/questions/70800753/rails-calling-didyoumeanspell-checkers-mergeerror-name-spell-checker-h
+  #
+  #
+  # Version 2.5.5 fixed an issue in 2.2.22 with the 'bump' gem:
+  #
+  # https://app.circleci.com/pipelines/github/apiology/checkoff/1281/workflows/f667f909-c3fc-4ae2-8593-dde2b588a7a7/jobs/2491
   need_better_bundler=false
   if [ "${bundler_version_major}" -lt 2 ]
   then
     need_better_bundler=true
   elif [ "${bundler_version_major}" -eq 2 ]
   then
-    if [ "${bundler_version_minor}" -lt 2 ]
+    if [ "${bundler_version_minor}" -lt 5 ]
     then
       need_better_bundler=true
-    elif [ "${bundler_version_minor}" -eq 2 ]
+    elif [ "${bundler_version_minor}" -eq 5 ]
     then
-      if [ "${bundler_version_patch}" -lt 23 ]
+      if [ "${bundler_version_patch}" -lt 5 ]
       then
         need_better_bundler=true
       fi
@@ -165,9 +170,12 @@ ensure_bundle() {
   fi
   if [ "${need_better_bundler}" = true ]
   then
+    >&2 echo "Original bundler version: ${bundler_version}"
     # need to do this first before 'bundle update --bundler' will work
     make bundle_install
     bundle update --bundler
+    gem install bundler:2.5.5
+    >&2 echo "Updated bundler version: $(bundle --version)"
     # ensure next step installs fresh bundle
     rm -f Gemfile.lock.installed
   fi

data/lib/checkoff/attachments.rb

@@ -9,6 +9,7 @@ require 'mime/types'
 require 'net/http'
 require 'net/http/response'
 require 'net/http/responses'
+require 'openssl'
 require 'tempfile'
 require_relative 'internal/config_loader'
 require_relative 'internal/logging'
@@ -55,16 +56,19 @@ module Checkoff
     # @param resource [Asana::Resources::Resource]
     # @param attachment_name [String,nil]
     # @param just_the_url [Boolean]
+    # @param verify_mode [Integer<OpenSSL::SSL::VERIFY_NONE,OpenSSL::SSL::VERIFY_PEER>]
     #
     # @return [Asana::Resources::Attachment]
     def create_attachment_from_url!(url,
                                     resource,
                                     attachment_name: nil,
+                                    verify_mode: OpenSSL::SSL::VERIFY_PEER,
                                     just_the_url: false)
       if just_the_url
         create_attachment_from_url_alone!(url, resource, attachment_name: attachment_name)
       else
-        create_attachment_from_downloaded_url!(url, resource, attachment_name: attachment_name)
+        create_attachment_from_downloaded_url!(url, resource, attachment_name: attachment_name,
+                                                              verify_mode: verify_mode)
       end
     end
 
@@ -75,25 +79,23 @@ module Checkoff
     # not succesful
     #
     # @param uri [URI]
+    # @param verify_mode [OpenSSL::SSL::VERIFY_NONE,OpenSSL::SSL::VERIFY_PEER]
     #
     # @return [Object]
     # @sg-ignore
-    def download_uri(uri, &block)
+    def download_uri(uri, verify_mode: OpenSSL::SSL::VERIFY_PEER, &block)
       out = nil
-      Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https') do |http|
+      Net::HTTP.start(uri.host, uri.port, use_ssl: uri.scheme == 'https', verify_mode: verify_mode) do |http|
         # @sg-ignore
-        request = Net::HTTP::Get.new(uri)
-        http.request(request) do |response|
-          # use a block to ensure the file is closed after we're done with it
+        http.request(Net::HTTP::Get.new(uri)) do |response|
           raise("Unexpected response code: #{response.code}") unless response.code == '200'
 
-          write_tempfile_from_response(response) do |tempfile|
-            out = block.yield tempfile
-          end
+          write_tempfile_from_response(response) { |tempfile| out = block.yield tempfile }
         end
       end
       out
     rescue StandardError => e
+      debug { e }
       raise "Error downloading #{uri}: #{e}"
     end
 
@@ -119,12 +121,14 @@ module Checkoff
     # @param url [String]
     # @param resource [Asana::Resources::Resource]
     # @param attachment_name [String,nil]
+    # @param verify_mode [Integer<OpenSSL::SSL::VERIFY_NONE,OpenSSL::SSL::VERIFY_PEER>]
     #
     # @return [Asana::Resources::Attachment]
-    def create_attachment_from_downloaded_url!(url, resource, attachment_name:)
+    def create_attachment_from_downloaded_url!(url, resource, attachment_name:,
+                                               verify_mode: OpenSSL::SSL::VERIFY_PEER)
       uri = URI(url)
       attachment_name ||= File.basename(uri.path)
-      download_uri(uri) do |tempfile|
+      download_uri(uri, verify_mode: verify_mode) do |tempfile|
         content_type ||= content_type_from_filename(attachment_name)
         content_type ||= content_type_from_filename(uri.path)
 

data/lib/checkoff/internal/selector_classes/task.rb

@@ -100,6 +100,26 @@ module Checkoff
         end
       end
 
+      # :in_portfolio_more_than_once? function
+      class InPortfolioMoreThanOncePFunctionEvaluator < FunctionEvaluator
+        def matches?
+          fn?(selector, :in_portfolio_more_than_once?)
+        end
+
+        # @param _index [Integer]
+        def evaluate_arg?(_index)
+          false
+        end
+
+        # @sg-ignore
+        # @param task [Asana::Resources::Task]
+        # @param portfolio_name [String]
+        # @return [Boolean]
+        def evaluate(task, portfolio_name)
+          @tasks.in_portfolio_more_than_once?(task, portfolio_name)
+        end
+      end
+
       # :tag? function
       class TagPFunctionEvaluator < FunctionEvaluator
         def matches?

data/lib/checkoff/tasks.rb

@@ -242,10 +242,11 @@ module Checkoff
                                      only_uncompleted: true,
                                      extra_fields: ['dependents'] + extra_task_fields)
         debug { "#{task.name} has dependent task #{dependent_task.name}" }
-        unless dependent_task.nil?
-          dependent_tasks << dependent_task
-          dependent_tasks += all_dependent_tasks(dependent_task)
-        end
+        next if dependent_task.nil?
+
+        dependent_tasks << dependent_task
+        dependent_tasks += all_dependent_tasks(dependent_task,
+                                               extra_task_fields: extra_task_fields)
       end
       dependent_tasks
     end
@@ -292,6 +293,27 @@ module Checkoff
       end
     end
 
+    # True if the task is in a project which is in the given portfolio
+    #
+    # @param task [Asana::Resources::Task]
+    # @param portfolio_name [String]
+    # @param workspace_name [String]
+    def in_portfolio_more_than_once?(task,
+                                     portfolio_name,
+                                     workspace_name: @workspaces.default_workspace.name)
+      portfolio_projects = @portfolios.projects_in_portfolio(workspace_name, portfolio_name)
+      portfolio_project_gids = portfolio_projects.map(&:gid)
+      seen = false
+      task.memberships.each do |membership|
+        project_gid = membership.fetch('project').fetch('gid')
+        next unless portfolio_project_gids.include?(project_gid)
+        return true if seen
+
+        seen = true
+      end
+      false
+    end
+
     # @return [Hash]
     def as_cache_key
       {}

data/lib/checkoff/timelines.rb

@@ -107,6 +107,8 @@ module Checkoff
           next true unless limit_to_projects.map(&:gid).include? project_gid
         end
 
+        # do this once, but lazily, so we don't have to do it if all
+        # projects are excluded
         all_dependent_milestones ||=
           @tasks.all_dependent_tasks(task,
                                      extra_task_fields: ['resource_subtype',

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.186.0'
+  VERSION = '0.188.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.186.0
+  version: 0.188.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-01-27 00:00:00.000000000 Z
+date: 2024-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport