checkoff 0.174.0 → 0.176.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afd1b7c89796ffabac7ae3776f3b1f55abd649355d30b2f7c05865d359841116
-  data.tar.gz: 7970b7b72e38f600ff5ff03f21ab8a97fc6e4f583d963422c79006541758344b
+  metadata.gz: '009e431ea6abee485edb629966f1412508a9f376750b84ab1db639bb7a252735'
+  data.tar.gz: 439f1735a8f14aa173d9fe7dce52d264e1473ed25b447bc4173055a536a03bae
 SHA512:
-  metadata.gz: ffb5752c0a924f5fb4942a44a22e0778fe0c129048f7a893ae899b73731f13f5f5890671c018322d98057f82d284c35febe3ca92dbb7d34247dbc7b68d8bc5b4
-  data.tar.gz: 4456268d46432f2187d4984b1df16711bcc1fc82efb3c07f899225d21df897308cc6f5d206a8ff3b8859dfc4d9feaaed60925f697a1fa8646fdd0a45385b81d2
+  metadata.gz: d9f2bf902b971678c75fbaa3ed182ddcaeff35c808df829ada02869efb197d91bfa3624d2410ede703b45b8d1e029f4ac105fad4cd1ec8cccc61cd7a71e0bb50
+  data.tar.gz: e21848eb4e6b57b48c661676cac5f33de827f90b378e102e1d4c16a9ceb081f11f5f34aab95c121236697ef5a770bb55e3595d39cabcfc63b4bb617ba96d2e16

data/Gemfile.lock

@@ -12,7 +12,7 @@ GIT
 PATH
   remote: .
   specs:
-    checkoff (0.174.0)
+    checkoff (0.176.0)
       activesupport
       asana (> 0.10.0)
       cache_method
@@ -23,7 +23,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (7.1.2)
+    activesupport (7.1.3)
       base64
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.0.2)
@@ -50,7 +50,7 @@ GEM
       concurrent-ruby
     childprocess (4.1.0)
     coderay (1.1.3)
-    concurrent-ruby (1.2.2)
+    concurrent-ruby (1.2.3)
     connection_pool (2.4.1)
     crack (0.4.5)
       rexml
@@ -114,7 +114,7 @@ GEM
     mime-types (3.5.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2023.1205)
-    minitest (5.20.0)
+    minitest (5.21.1)
     minitest-profile (0.0.2)
     minitest-reporters (1.6.1)
       ansi

data/lib/checkoff/internal/asana_event_filter.rb

@@ -18,12 +18,15 @@ module Checkoff
 
       # @param filters [Array<Hash>, nil] The filters to match against
       # @param clients [Checkoff::Clients]
+      # @param tasks [Checkoff::Tasks]
       # @param client [Asana::Client]
       def initialize(filters:,
                      clients: Checkoff::Clients.new,
+                     tasks: Checkoff::Tasks.new,
                      client: clients.client)
         @filters = filters
         @client = client
+        @tasks = tasks
       end
 
       # @param asana_event [Hash] The event that Asana sent
@@ -85,27 +88,42 @@ module Checkoff
           asana_event.fetch('parent', {})['gid'] == value
         when 'checkoff:resource.gid'
           asana_event.fetch('resource', {})['gid'] == value
+        when 'checkoff:fetched.section.gid'
+          fields = ['memberships.section.gid', 'assignee', 'assignee_section']
+          task = uncached_fetch_task(key, asana_event, fields)
+          task_data = @tasks.task_to_h(task)
+          task_data.fetch('membership_by_section_gid').keys.include?(value)
         when 'checkoff:fetched.completed'
-          # @type [Hash{String => String}]
-          # @sg-ignore
-          resource = asana_event.fetch('resource')
-          # @type [String]
-          resource_type = resource.fetch('resource_type')
-          unless resource_type == 'task'
-            raise "Teach me how to check #{key.inspect} on resource type #{resource_type.inspect}"
-          end
-
-          task_gid = resource.fetch('gid')
-          options = {
-            fields: ['completed_at'],
-          }
-          task = @client.tasks.find_by_id(task_gid, options: options)
+          fields = ['completed_at']
+          task = uncached_fetch_task(key, asana_event, fields)
           task_completed = !task.completed_at.nil?
           task_completed == value
         else
           raise "Unknown filter key #{key}"
         end
       end
+
+      # @param key [String]
+      # @param asana_event [Hash]
+      # @param fields [Array<String>]
+      #
+      # @return [Asana::Resources::Task]
+      def uncached_fetch_task(key, asana_event, fields)
+        # @type [Hash{String => String}]
+        # @sg-ignore
+        resource = asana_event.fetch('resource')
+        # @type [String]
+        resource_type = resource.fetch('resource_type')
+        unless resource_type == 'task'
+          raise "Teach me how to check #{key.inspect} on resource type #{resource_type.inspect}"
+        end
+
+        task_gid = resource.fetch('gid')
+        options = {
+          fields: fields,
+        }
+        @client.tasks.find_by_id(task_gid, options: options)
+      end
     end
   end
 end

data/lib/checkoff/internal/task_hashes.rb

@@ -12,7 +12,7 @@ module Checkoff
         task_hash = task.to_h
         task_hash['unwrapped'] = {}
         unwrap_custom_fields(task_hash)
-        unwrap_memberships(task_hash)
+        unwrap_all_memberships(task_hash)
         task_hash['task'] = task.name
         task_hash
       end
@@ -39,15 +39,32 @@ module Checkoff
         task_hash['unwrapped']['custom_fields'] = unwrapped_custom_fields
       end
 
+      # @param [Hash<String, Hash, Array>] task_hash
+      # @param [Array<Hash>] memberships
+      #
+      # @return [void]
+      def add_user_task_list(task_hash, memberships)
+        return unless task_hash.key? 'assignee_section'
+
+        assignee_section = task_hash.fetch('assignee_section')
+        # @type [Hash]
+        assignee = task_hash.fetch('assignee')
+        memberships << {
+          'section' => assignee_section.dup,
+          'project' => {
+            'gid' => assignee.fetch('gid'),
+            'name' => :my_tasks,
+          },
+        }
+      end
+
       # @param task_hash [Hash]
       # @param resource [String]
+      # @param memberships [Array<Hash>]
       # @param key [String]
       #
       # @return [void]
-      def unwrap_membership(task_hash, resource, key)
-        # @sg-ignore
-        # @type [Array<Hash>]
-        memberships = task_hash.fetch('memberships', [])
+      def unwrap_memberships(task_hash, memberships, resource, key)
         # @sg-ignore
         # @type [Hash]
         unwrapped = task_hash.fetch('unwrapped')
@@ -58,11 +75,15 @@ module Checkoff
 
       # @param task_hash [Hash]
       # @return [void]
-      def unwrap_memberships(task_hash)
-        unwrap_membership(task_hash, 'section', 'gid')
-        unwrap_membership(task_hash, 'section', 'name')
-        unwrap_membership(task_hash, 'project', 'gid')
-        unwrap_membership(task_hash, 'project', 'name')
+      def unwrap_all_memberships(task_hash)
+        # @sg-ignore
+        # @type [Array<Hash>]
+        memberships = task_hash.fetch('memberships', []).dup
+        add_user_task_list(task_hash, memberships)
+        unwrap_memberships(task_hash, memberships, 'section', 'gid')
+        unwrap_memberships(task_hash, memberships, 'section', 'name')
+        unwrap_memberships(task_hash, memberships, 'project', 'gid')
+        unwrap_memberships(task_hash, memberships, 'project', 'name')
       end
     end
   end

data/lib/checkoff/internal/thread_local.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module Checkoff
+  module Internal
+    # Manage thread lock variables in a block
+    class ThreadLocal
+      # @sg-ignore
+      # @param name [Symbol]
+      # @param value [Object,Boolean]
+      #
+      # @return [Object,Boolean]
+      def with_thread_local_variable(name, value, &block)
+        old_value = Thread.current[name]
+        Thread.current[name] = value
+        block.yield
+      ensure
+        Thread.current[name] = old_value
+      end
+    end
+  end
+end

data/lib/checkoff/tasks.rb

@@ -9,6 +9,7 @@ require_relative 'internal/config_loader'
 require_relative 'internal/task_timing'
 require_relative 'internal/task_hashes'
 require_relative 'internal/logging'
+require_relative 'internal/thread_local'
 require 'asana'
 
 module Checkoff
@@ -116,8 +117,11 @@ module Checkoff
              section_name: :unspecified,
              only_uncompleted: true,
              extra_fields: [])
-      task_gid = gid_for_task(workspace_name, project_name, section_name, task_name)
-
+      thread_local = Checkoff::Internal::ThreadLocal.new
+      task_gid = thread_local.with_thread_local_variable(:suppress_asana_webhook_watch_creation,
+                                                         true) do
+        gid_for_task(workspace_name, project_name, section_name, task_name)
+      end
       return nil if task_gid.nil?
 
       task_by_gid(task_gid, only_uncompleted: only_uncompleted, extra_fields: extra_fields)

data/lib/checkoff/version.rb

@@ -3,5 +3,5 @@
 # Command-line and gem client for Asana (unofficial)
 module Checkoff
   # Version of library
-  VERSION = '0.174.0'
+  VERSION = '0.176.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: checkoff
 version: !ruby/object:Gem::Version
-  version: 0.174.0
+  version: 0.176.0
 platform: ruby
 authors:
 - Vince Broz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-01-15 00:00:00.000000000 Z
+date: 2024-01-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -177,6 +177,7 @@ files:
 - lib/checkoff/internal/task_hashes.rb
 - lib/checkoff/internal/task_selector_evaluator.rb
 - lib/checkoff/internal/task_timing.rb
+- lib/checkoff/internal/thread_local.rb
 - lib/checkoff/monkeypatches/resource_marshalling.rb
 - lib/checkoff/my_tasks.rb
 - lib/checkoff/portfolios.rb